| @@ -6,10 +6,9 @@ | ||
| 6 | 6 | class FrmForm { |
| 7 | 7 | |
| 8 | 8 | /** |
| 9 | 9 | * @param array $values |
| 10 | - * | |
| 11 | - * @return bool|int id on success or false on failure. | |
| 10 | + * @return int|bool id on success or false on failure. | |
| 12 | 11 | */ |
| 13 | 12 | public static function create( $values ) { |
| 14 | 13 | global $wpdb; |
| 15 | 14 | |
| @@ -18,22 +17,22 @@ | ||
| 18 | 17 | $new_values = array( |
| 19 | 18 | 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ), |
| 20 | 19 | 'name' => $values['name'], |
| 21 | 20 | 'description' => $values['description'], |
| 22 | - 'status' => $values['status'] ?? 'published', | |
| 23 | - 'logged_in' => $values['logged_in'] ?? 0, | |
| 21 | + 'status' => isset( $values['status'] ) ? $values['status'] : 'published', | |
| 22 | + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0, | |
| 24 | 23 | 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0, |
| 25 | 24 | 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0, |
| 26 | 25 | 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0, |
| 27 | - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ), | |
| 26 | + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ), | |
| 28 | 27 | ); |
| 29 | 28 | |
| 30 | 29 | $options = isset( $values['options'] ) ? (array) $values['options'] : array(); |
| 31 | 30 | FrmFormsHelper::fill_form_options( $options, $values ); |
| 32 | 31 | |
| 33 | - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' ); | |
| 34 | - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' ); | |
| 35 | - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' ); | |
| 32 | + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' ); | |
| 33 | + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' ); | |
| 34 | + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); | |
| 36 | 35 | |
| 37 | 36 | /** |
| 38 | 37 | * Allows modifying form options before updating or creating. |
| 39 | 38 | * |
| @@ -60,9 +59,8 @@ | ||
| 60 | 59 | /** |
| 61 | 60 | * @since 5.0.08 |
| 62 | 61 | * |
| 63 | 62 | * @param array $options |
| 64 | - * | |
| 65 | 63 | * @return array |
| 66 | 64 | */ |
| 67 | 65 | private static function maybe_filter_form_options( $options ) { |
| 68 | 66 | if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) { |
| @@ -71,22 +69,14 @@ | ||
| 71 | 69 | return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) ); |
| 72 | 70 | } |
| 73 | 71 | |
| 74 | 72 | /** |
| 75 | - * Duplicate a form. | |
| 76 | - * | |
| 77 | - * @param int $id Form ID to duplicate. | |
| 78 | - * @param bool $template Whether the duplicated form is a template. | |
| 79 | - * @param bool $copy_keys Whether to copy the original form key. | |
| 80 | - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site. | |
| 81 | - * | |
| 82 | - * @return bool|int ID on success or false on failure | |
| 73 | + * @return int|boolean ID on success or false on failure | |
| 83 | 74 | */ |
| 84 | 75 | public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) { |
| 85 | 76 | global $wpdb; |
| 86 | 77 | |
| 87 | 78 | $values = self::getOne( $id, $blog_id ); |
| 88 | - | |
| 89 | 79 | if ( ! $values ) { |
| 90 | 80 | return false; |
| 91 | 81 | } |
| 92 | 82 | |
| @@ -103,10 +93,10 @@ | ||
| 103 | 93 | 'is_template' => $template ? 1 : 0, |
| 104 | 94 | ); |
| 105 | 95 | |
| 106 | 96 | if ( $blog_id ) { |
| 107 | - $new_values['status'] = 'published'; | |
| 108 | - $new_options = $values->options; | |
| 97 | + $new_values['status'] = 'published'; | |
| 98 | + $new_options = $values->options; | |
| 109 | 99 | FrmAppHelper::unserialize_or_decode( $new_options ); |
| 110 | 100 | $new_options['email_to'] = get_option( 'admin_email' ); |
| 111 | 101 | $new_options['copy'] = false; |
| 112 | 102 | $new_values['options'] = $new_options; |
| @@ -126,9 +116,9 @@ | ||
| 126 | 116 | |
| 127 | 117 | $form_id = $wpdb->insert_id; |
| 128 | 118 | FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id ); |
| 129 | 119 | |
| 130 | - // Update form settings after fields are created | |
| 120 | + // update form settings after fields are created | |
| 131 | 121 | do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) ); |
| 132 | 122 | |
| 133 | 123 | return $form_id; |
| 134 | 124 | } |
| @@ -135,16 +125,10 @@ | ||
| 135 | 125 | |
| 136 | 126 | return false; |
| 137 | 127 | } |
| 138 | 128 | |
| 139 | - /** | |
| 140 | - * @param int $form_id | |
| 141 | - * @param array $values | |
| 142 | - * | |
| 143 | - * @return void | |
| 144 | - */ | |
| 145 | 129 | public static function after_duplicate( $form_id, $values ) { |
| 146 | - $new_opts = $values['options']; | |
| 130 | + $new_opts = $values['options']; | |
| 147 | 131 | FrmAppHelper::unserialize_or_decode( $new_opts ); |
| 148 | 132 | $values['options'] = $new_opts; |
| 149 | 133 | |
| 150 | 134 | if ( isset( $new_opts['success_msg'] ) ) { |
| @@ -152,9 +136,8 @@ | ||
| 152 | 136 | } |
| 153 | 137 | |
| 154 | 138 | $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id ); |
| 155 | 139 | |
| 156 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 157 | 140 | if ( $new_opts != $values['options'] ) { |
| 158 | 141 | global $wpdb; |
| 159 | 142 | $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) ); |
| 160 | 143 | } |
| @@ -167,10 +150,8 @@ | ||
| 167 | 150 | * |
| 168 | 151 | * @since 5.3 |
| 169 | 152 | * |
| 170 | 153 | * @param int $form_id Form ID. |
| 171 | - * | |
| 172 | - * @return void | |
| 173 | 154 | */ |
| 174 | 155 | private static function switch_field_ids_in_fields( $form_id ) { |
| 175 | 156 | global $wpdb; |
| 176 | 157 | |
| @@ -176,11 +157,10 @@ | ||
| 176 | 157 | |
| 177 | 158 | // Keys of fields that you want to check to replace field ID. |
| 178 | 159 | $keys = array( 'default_value', 'field_options' ); |
| 179 | 160 | $sql_cols = 'fi.id'; |
| 180 | - | |
| 181 | 161 | foreach ( $keys as $key ) { |
| 182 | - $sql_cols .= ',fi.' . $key; | |
| 162 | + $sql_cols .= ( ',fi.' . $key ); | |
| 183 | 163 | } |
| 184 | 164 | |
| 185 | 165 | $fields = FrmDb::get_results( |
| 186 | 166 | "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id", |
| @@ -206,14 +186,11 @@ | ||
| 206 | 186 | * |
| 207 | 187 | * @since 5.3 |
| 208 | 188 | * |
| 209 | 189 | * @param array $field Field array. |
| 210 | - * | |
| 211 | - * @return void | |
| 212 | 190 | */ |
| 213 | 191 | private static function switch_field_ids_in_field( $field ) { |
| 214 | 192 | $new_values = array(); |
| 215 | - | |
| 216 | 193 | foreach ( $field as $key => $value ) { |
| 217 | 194 | if ( 'id' === $key || ! $value ) { |
| 218 | 195 | continue; |
| 219 | 196 | } |
| @@ -235,21 +212,15 @@ | ||
| 235 | 212 | $new_values[ $key ] = $new_val; |
| 236 | 213 | } |
| 237 | 214 | }//end foreach |
| 238 | 215 | |
| 239 | - if ( $new_values ) { | |
| 216 | + if ( ! empty( $new_values ) ) { | |
| 240 | 217 | FrmField::update( $field['id'], $new_values ); |
| 241 | 218 | } |
| 242 | 219 | } |
| 243 | 220 | |
| 244 | 221 | /** |
| 245 | - * Update a form. | |
| 246 | - * | |
| 247 | - * @param int $id Form ID. | |
| 248 | - * @param array $values Form values to update. | |
| 249 | - * @param bool $create_link Whether this is being called from link creation. | |
| 250 | - * | |
| 251 | - * @return bool|int | |
| 222 | + * @return int|boolean | |
| 252 | 223 | */ |
| 253 | 224 | public static function update( $id, $values, $create_link = false ) { |
| 254 | 225 | global $wpdb; |
| 255 | 226 | |
| @@ -263,23 +234,23 @@ | ||
| 263 | 234 | $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id ); |
| 264 | 235 | } |
| 265 | 236 | |
| 266 | 237 | $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' ); |
| 267 | - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) ); | |
| 268 | 238 | |
| 239 | + $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) ); | |
| 240 | + | |
| 269 | 241 | foreach ( $values as $value_key => $value ) { |
| 270 | - if ( $value_key && in_array( $value_key, $form_fields, true ) ) { | |
| 242 | + if ( $value_key && in_array( $value_key, $form_fields ) ) { | |
| 271 | 243 | $new_values[ $value_key ] = $value; |
| 272 | 244 | } |
| 273 | 245 | } |
| 274 | 246 | |
| 275 | - if ( ! empty( $values['new_status'] ) ) { | |
| 247 | + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) { | |
| 276 | 248 | $new_values['status'] = $values['new_status']; |
| 277 | 249 | } |
| 278 | 250 | |
| 279 | - if ( $new_values ) { | |
| 251 | + if ( ! empty( $new_values ) ) { | |
| 280 | 252 | $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) ); |
| 281 | - | |
| 282 | 253 | if ( $query_results ) { |
| 283 | 254 | self::clear_form_cache(); |
| 284 | 255 | } |
| 285 | 256 | } else { |
| @@ -298,9 +269,8 @@ | ||
| 298 | 269 | /** |
| 299 | 270 | * @param array $new_values |
| 300 | 271 | * @param array $values |
| 301 | 272 | * @param array $args |
| 302 | - * | |
| 303 | 273 | * @return array |
| 304 | 274 | */ |
| 305 | 275 | public static function set_update_options( $new_values, $values, $args = array() ) { |
| 306 | 276 | if ( ! isset( $values['options'] ) ) { |
| @@ -309,12 +279,12 @@ | ||
| 309 | 279 | |
| 310 | 280 | $options = ! empty( $values['options'] ) ? (array) $values['options'] : array(); |
| 311 | 281 | FrmFormsHelper::fill_form_options( $options, $values ); |
| 312 | 282 | |
| 313 | - $options['custom_style'] = $values['options']['custom_style'] ?? 0; | |
| 314 | - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' ); | |
| 315 | - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' ); | |
| 316 | - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 283 | + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0; | |
| 284 | + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' ); | |
| 285 | + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' ); | |
| 286 | + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); | |
| 317 | 287 | |
| 318 | 288 | /** |
| 319 | 289 | * Allows modifying form options before updating or creating. |
| 320 | 290 | * |
| @@ -331,14 +301,11 @@ | ||
| 331 | 301 | return $new_values; |
| 332 | 302 | } |
| 333 | 303 | |
| 334 | 304 | /** |
| 335 | - * @param int $id Form ID. | |
| 336 | - * @param array $values Form values array. | |
| 337 | - * | |
| 338 | 305 | * @return array |
| 339 | 306 | */ |
| 340 | - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh | |
| 307 | + public static function update_fields( $id, $values ) { | |
| 341 | 308 | |
| 342 | 309 | if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) { |
| 343 | 310 | return $values; |
| 344 | 311 | } |
| @@ -343,10 +310,9 @@ | ||
| 343 | 310 | return $values; |
| 344 | 311 | } |
| 345 | 312 | |
| 346 | 313 | $all_fields = FrmField::get_all_for_form( $id ); |
| 347 | - | |
| 348 | - if ( ! $all_fields ) { | |
| 314 | + if ( empty( $all_fields ) ) { | |
| 349 | 315 | return $values; |
| 350 | 316 | } |
| 351 | 317 | |
| 352 | 318 | if ( ! isset( $values['item_meta'] ) ) { |
| @@ -354,28 +320,28 @@ | ||
| 354 | 320 | } |
| 355 | 321 | |
| 356 | 322 | $field_array = array(); |
| 357 | 323 | $existing_keys = array_keys( $values['item_meta'] ); |
| 358 | - | |
| 359 | 324 | foreach ( $all_fields as $fid ) { |
| 360 | - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 361 | 325 | if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) { |
| 362 | 326 | $values['item_meta'][ $fid->id ] = ''; |
| 363 | 327 | } |
| 364 | - | |
| 365 | 328 | $field_array[ $fid->id ] = $fid; |
| 366 | 329 | } |
| 367 | 330 | unset( $all_fields ); |
| 368 | 331 | |
| 369 | 332 | foreach ( $values['item_meta'] as $field_id => $default_value ) { |
| 370 | - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id ); | |
| 333 | + if ( isset( $field_array[ $field_id ] ) ) { | |
| 334 | + $field = $field_array[ $field_id ]; | |
| 335 | + } else { | |
| 336 | + $field = FrmField::getOne( $field_id ); | |
| 337 | + } | |
| 371 | 338 | |
| 372 | 339 | if ( ! $field ) { |
| 373 | 340 | continue; |
| 374 | 341 | } |
| 375 | 342 | |
| 376 | - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ); | |
| 377 | - | |
| 343 | + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) ); | |
| 378 | 344 | if ( $is_settings_page ) { |
| 379 | 345 | self::get_settings_page_html( $values, $field ); |
| 380 | 346 | |
| 381 | 347 | if ( ! defined( 'WP_IMPORTING' ) ) { |
| @@ -388,14 +354,10 @@ | ||
| 388 | 354 | // Don't check for POST html. |
| 389 | 355 | unset( $update_options['custom_html'] ); |
| 390 | 356 | $update_options = apply_filters( 'frm_field_options_to_update', $update_options ); |
| 391 | 357 | |
| 392 | - if ( ! is_array( $field->field_options ) ) { | |
| 393 | - $field->field_options = array(); | |
| 394 | - } | |
| 395 | - | |
| 396 | 358 | foreach ( $update_options as $opt => $default ) { |
| 397 | - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default; | |
| 359 | + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default; | |
| 398 | 360 | self::sanitize_field_opt( $opt, $field->field_options[ $opt ] ); |
| 399 | 361 | } |
| 400 | 362 | |
| 401 | 363 | $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values ); |
| @@ -404,9 +366,9 @@ | ||
| 404 | 366 | 'field_options' => $field->field_options, |
| 405 | 367 | 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '', |
| 406 | 368 | ); |
| 407 | 369 | |
| 408 | - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 370 | + if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { | |
| 409 | 371 | foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) { |
| 410 | 372 | if ( is_array( $option ) ) { |
| 411 | 373 | foreach ( $option as $key => $item ) { |
| 412 | 374 | $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' ); |
| @@ -431,12 +393,11 @@ | ||
| 431 | 393 | * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc. |
| 432 | 394 | * |
| 433 | 395 | * @since 6.7 |
| 434 | 396 | * |
| 435 | - * @param object $field | |
| 436 | - * @param array $values | |
| 437 | - * @param array $new_field | |
| 438 | - * | |
| 397 | + * @param array $field | |
| 398 | + * @param array $values | |
| 399 | + * @param array $new_field | |
| 439 | 400 | * @return void |
| 440 | 401 | */ |
| 441 | 402 | private static function maybe_update_max_option( $field, $values, &$new_field ) { |
| 442 | 403 | if ( $field->type === 'textarea' && |
| @@ -441,8 +402,9 @@ | ||
| 441 | 402 | private static function maybe_update_max_option( $field, $values, &$new_field ) { |
| 442 | 403 | if ( $field->type === 'textarea' && |
| 443 | 404 | ! empty( $values['field_options'][ 'type_' . $field->id ] ) && |
| 444 | 405 | in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) { |
| 406 | + | |
| 445 | 407 | $new_field['field_options']['max'] = ''; |
| 446 | 408 | |
| 447 | 409 | /** |
| 448 | 410 | * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads. |
| @@ -454,9 +416,8 @@ | ||
| 454 | 416 | |
| 455 | 417 | /** |
| 456 | 418 | * @param string $opt |
| 457 | 419 | * @param mixed $value |
| 458 | - * | |
| 459 | 420 | * @return void |
| 460 | 421 | */ |
| 461 | 422 | private static function sanitize_field_opt( $opt, &$value ) { |
| 462 | 423 | if ( ! is_string( $value ) ) { |
| @@ -477,19 +438,23 @@ | ||
| 477 | 438 | if ( ! $should_sanitize ) { |
| 478 | 439 | return; |
| 479 | 440 | } |
| 480 | 441 | |
| 481 | - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' ); | |
| 442 | + if ( $opt === 'calc' ) { | |
| 443 | + $value = self::sanitize_calc( $value ); | |
| 444 | + } else { | |
| 445 | + $value = FrmAppHelper::kses( $value, 'all' ); | |
| 446 | + } | |
| 447 | + | |
| 482 | 448 | $value = trim( $value ); |
| 483 | 449 | } |
| 484 | 450 | |
| 485 | 451 | /** |
| 486 | 452 | * @param string $value |
| 487 | - * | |
| 488 | 453 | * @return string |
| 489 | 454 | */ |
| 490 | 455 | private static function sanitize_calc( $value ) { |
| 491 | - if ( str_contains( $value, '<' ) ) { | |
| 456 | + if ( false !== strpos( $value, '<' ) ) { | |
| 492 | 457 | $value = self::normalize_calc_spaces( $value ); |
| 493 | 458 | } |
| 494 | 459 | // Allow <= and >=. |
| 495 | 460 | $allow = array( '<= ', ' >=' ); |
| @@ -495,9 +460,10 @@ | ||
| 495 | 460 | $allow = array( '<= ', ' >=' ); |
| 496 | 461 | $temp = array( '< = ', ' > =' ); |
| 497 | 462 | $value = str_replace( $allow, $temp, $value ); |
| 498 | 463 | $value = strip_tags( $value ); |
| 499 | - return str_replace( $temp, $allow, $value ); | |
| 464 | + $value = str_replace( $temp, $allow, $value ); | |
| 465 | + return $value; | |
| 500 | 466 | } |
| 501 | 467 | |
| 502 | 468 | /** |
| 503 | 469 | * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations. |
| @@ -503,58 +469,41 @@ | ||
| 503 | 469 | * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations. |
| 504 | 470 | * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called. |
| 505 | 471 | * |
| 506 | 472 | * @param string $calc |
| 507 | - * | |
| 508 | 473 | * @return string |
| 509 | 474 | */ |
| 510 | 475 | private static function normalize_calc_spaces( $calc ) { |
| 511 | 476 | // Check for a pattern with 5 parts |
| 512 | - // $1 \d|\] the first comparison digit or the end of a comparison shortcode. | |
| 477 | + // $1 \d the first comparison digit. | |
| 513 | 478 | // $2 a space (optional). |
| 514 | 479 | // $3 an equals sign (optional) that follows the < operator for <= comparisons. |
| 515 | 480 | // $4 another space (optional). |
| 516 | - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode. | |
| 517 | - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc ); | |
| 481 | + // $5 \d the second comparison digit. | |
| 482 | + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc ); | |
| 518 | 483 | } |
| 519 | 484 | |
| 520 | 485 | /** |
| 521 | 486 | * Updating the settings page |
| 522 | - * | |
| 523 | - * @param array $values Form values array. | |
| 524 | - * @param object $field Field object, passed by reference. | |
| 525 | - * | |
| 526 | - * @return void | |
| 527 | 487 | */ |
| 528 | 488 | private static function get_settings_page_html( $values, &$field ) { |
| 529 | 489 | if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) { |
| 530 | 490 | $prev_opts = array(); |
| 531 | - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type ); | |
| 491 | + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type ); | |
| 532 | 492 | |
| 533 | - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html; | |
| 534 | - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) { | |
| 493 | + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html; | |
| 494 | + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) { | |
| 535 | 495 | $prev_opts = $field->field_options; |
| 536 | 496 | } |
| 537 | 497 | |
| 538 | - if ( ! isset( $prev_opts ) ) { | |
| 539 | - return; | |
| 498 | + if ( isset( $prev_opts ) ) { | |
| 499 | + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values ); | |
| 500 | + if ( $prev_opts != $field->field_options ) { | |
| 501 | + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) ); | |
| 502 | + } | |
| 540 | 503 | } |
| 541 | - | |
| 542 | - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values ); | |
| 543 | - | |
| 544 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 545 | - if ( $prev_opts != $field->field_options ) { | |
| 546 | - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) ); | |
| 547 | - } | |
| 548 | 504 | } |
| 549 | 505 | |
| 550 | - /** | |
| 551 | - * @param object $field | |
| 552 | - * @param array $values | |
| 553 | - * @param array $new_field | |
| 554 | - * | |
| 555 | - * @return void | |
| 556 | - */ | |
| 557 | 506 | private static function prepare_field_update_values( $field, $values, &$new_field ) { |
| 558 | 507 | $field_cols = array( |
| 559 | 508 | 'field_order' => 0, |
| 560 | 509 | 'field_key' => '', |
| @@ -563,16 +512,12 @@ | ||
| 563 | 512 | 'description' => '', |
| 564 | 513 | 'options' => '', |
| 565 | 514 | 'name' => '', |
| 566 | 515 | ); |
| 567 | - | |
| 568 | 516 | foreach ( $field_cols as $col => $default ) { |
| 569 | - $default = $default === '' ? $field->{$col} : $default; | |
| 570 | - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default; | |
| 571 | - } | |
| 517 | + $default = ( $default === '' ) ? $field->{$col} : $default; | |
| 572 | 518 | |
| 573 | - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) { | |
| 574 | - $new_field['field_order'] = $field->field_order; | |
| 519 | + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default; | |
| 575 | 520 | } |
| 576 | 521 | |
| 577 | 522 | // Don't save the template option. |
| 578 | 523 | if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) { |
| @@ -584,12 +529,9 @@ | ||
| 584 | 529 | * Get a list of all form settings that should be translated |
| 585 | 530 | * on a multilingual site. |
| 586 | 531 | * |
| 587 | 532 | * @since 3.06.01 |
| 588 | - * | |
| 589 | 533 | * @param object $form The form object. |
| 590 | - * | |
| 591 | - * @return array | |
| 592 | 534 | */ |
| 593 | 535 | public static function translatable_strings( $form ) { |
| 594 | 536 | $strings = array( |
| 595 | 537 | 'name', |
| @@ -606,21 +548,20 @@ | ||
| 606 | 548 | return apply_filters( 'frm_form_strings', $strings, $form ); |
| 607 | 549 | } |
| 608 | 550 | |
| 609 | 551 | /** |
| 610 | - * @param array|int $id | |
| 611 | - * @param string $status | |
| 552 | + * @param int $id | |
| 553 | + * @param string $status | |
| 612 | 554 | * |
| 613 | - * @return bool|int | |
| 555 | + * @return int|boolean | |
| 614 | 556 | */ |
| 615 | 557 | public static function set_status( $id, $status ) { |
| 616 | - if ( 'trash' === $status ) { | |
| 558 | + if ( 'trash' == $status ) { | |
| 617 | 559 | return self::trash( $id ); |
| 618 | 560 | } |
| 619 | 561 | |
| 620 | 562 | $statuses = array( 'published', 'draft', 'trash' ); |
| 621 | - | |
| 622 | - if ( ! in_array( $status, $statuses, true ) ) { | |
| 563 | + if ( ! in_array( $status, $statuses ) ) { | |
| 623 | 564 | return false; |
| 624 | 565 | } |
| 625 | 566 | |
| 626 | 567 | global $wpdb; |
| @@ -633,9 +574,9 @@ | ||
| 633 | 574 | ); |
| 634 | 575 | FrmDb::get_where_clause_and_values( $where ); |
| 635 | 576 | array_unshift( $where['values'], $status ); |
| 636 | 577 | |
| 637 | - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 578 | + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared | |
| 638 | 579 | } else { |
| 639 | 580 | $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) ); |
| 640 | 581 | $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) ); |
| 641 | 582 | } |
| @@ -647,11 +588,9 @@ | ||
| 647 | 588 | return $query_results; |
| 648 | 589 | } |
| 649 | 590 | |
| 650 | 591 | /** |
| 651 | - * @param int|string $id Form ID. | |
| 652 | - * | |
| 653 | - * @return bool|int | |
| 592 | + * @return int|boolean | |
| 654 | 593 | */ |
| 655 | 594 | public static function trash( $id ) { |
| 656 | 595 | if ( ! EMPTY_TRASH_DAYS ) { |
| 657 | 596 | return self::destroy( $id ); |
| @@ -657,17 +596,12 @@ | ||
| 657 | 596 | return self::destroy( $id ); |
| 658 | 597 | } |
| 659 | 598 | |
| 660 | 599 | $form = self::getOne( $id ); |
| 661 | - | |
| 662 | 600 | if ( ! $form ) { |
| 663 | 601 | return false; |
| 664 | 602 | } |
| 665 | 603 | |
| 666 | - if ( $form->status === 'trash' ) { | |
| 667 | - return false; | |
| 668 | - } | |
| 669 | - | |
| 670 | 604 | $options = $form->options; |
| 671 | 605 | $options['trash_time'] = time(); |
| 672 | 606 | |
| 673 | 607 | global $wpdb; |
| @@ -700,26 +634,21 @@ | ||
| 700 | 634 | return $query_results; |
| 701 | 635 | } |
| 702 | 636 | |
| 703 | 637 | /** |
| 704 | - * @param int|string $id Form ID. | |
| 705 | - * | |
| 706 | - * @return bool|int | |
| 638 | + * @return int|boolean | |
| 707 | 639 | */ |
| 708 | 640 | public static function destroy( $id ) { |
| 709 | 641 | global $wpdb; |
| 710 | 642 | |
| 711 | 643 | $form = self::getOne( $id ); |
| 712 | - | |
| 713 | 644 | if ( ! $form ) { |
| 714 | 645 | return false; |
| 715 | 646 | } |
| 716 | - | |
| 717 | 647 | $id = $form->id; |
| 718 | 648 | |
| 719 | 649 | // Disconnect the entries from this form |
| 720 | - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) ); | |
| 721 | - | |
| 650 | + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) ); | |
| 722 | 651 | foreach ( $entries as $entry_id ) { |
| 723 | 652 | FrmEntry::destroy( $entry_id ); |
| 724 | 653 | unset( $entry_id ); |
| 725 | 654 | } |
| @@ -724,29 +653,23 @@ | ||
| 724 | 653 | unset( $entry_id ); |
| 725 | 654 | } |
| 726 | 655 | |
| 727 | 656 | // Disconnect the fields from this form |
| 728 | - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 657 | + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); | |
| 729 | 658 | |
| 730 | 659 | $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) ); |
| 660 | + if ( $query_results ) { | |
| 661 | + // Delete all form actions linked to this form | |
| 662 | + $action_control = FrmFormActionsController::get_form_actions( 'email' ); | |
| 663 | + $action_control->destroy( $id, 'all' ); | |
| 731 | 664 | |
| 732 | - if ( ! $query_results ) { | |
| 733 | - return $query_results; | |
| 665 | + // Clear form caching | |
| 666 | + self::clear_form_cache(); | |
| 667 | + | |
| 668 | + do_action( 'frm_destroy_form', $id ); | |
| 669 | + do_action( 'frm_destroy_form_' . $id ); | |
| 734 | 670 | } |
| 735 | 671 | |
| 736 | - // Delete all form actions linked to this form | |
| 737 | - /** | |
| 738 | - * @var FrmFormAction | |
| 739 | - */ | |
| 740 | - $action_control = FrmFormActionsController::get_form_actions( 'email' ); | |
| 741 | - $action_control->destroy( $id, 'all' ); | |
| 742 | - | |
| 743 | - // Clear form caching | |
| 744 | - self::clear_form_cache(); | |
| 745 | - | |
| 746 | - do_action( 'frm_destroy_form', $id ); | |
| 747 | - do_action( 'frm_destroy_form_' . $id ); | |
| 748 | - | |
| 749 | 672 | return $query_results; |
| 750 | 673 | } |
| 751 | 674 | |
| 752 | 675 | /** |
| @@ -751,33 +674,30 @@ | ||
| 751 | 674 | |
| 752 | 675 | /** |
| 753 | 676 | * Delete trashed forms based on how long they have been trashed |
| 754 | 677 | * |
| 755 | - * @param int|string $delete_timestamp Timestamp cutoff for deletion. | |
| 756 | - * | |
| 757 | 678 | * @return int The number of forms deleted |
| 758 | 679 | */ |
| 759 | 680 | public static function scheduled_delete( $delete_timestamp = '' ) { |
| 760 | - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' ); | |
| 681 | + global $wpdb; | |
| 761 | 682 | |
| 683 | + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' ); | |
| 684 | + | |
| 762 | 685 | if ( ! $trash_forms ) { |
| 763 | 686 | return 0; |
| 764 | 687 | } |
| 765 | 688 | |
| 766 | - if ( ! $delete_timestamp ) { | |
| 689 | + if ( empty( $delete_timestamp ) ) { | |
| 767 | 690 | $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS ); |
| 768 | 691 | } |
| 769 | 692 | |
| 770 | 693 | $count = 0; |
| 771 | - | |
| 772 | 694 | foreach ( $trash_forms as $form ) { |
| 773 | 695 | FrmAppHelper::unserialize_or_decode( $form->options ); |
| 774 | - | |
| 775 | 696 | if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) { |
| 776 | 697 | self::destroy( $form->id ); |
| 777 | - | |
| 778 | 698 | if ( empty( $form->parent_form_id ) ) { |
| 779 | - ++$count; | |
| 699 | + $count ++; | |
| 780 | 700 | } |
| 781 | 701 | } |
| 782 | 702 | |
| 783 | 703 | unset( $form ); |
| @@ -786,17 +706,16 @@ | ||
| 786 | 706 | return $count; |
| 787 | 707 | } |
| 788 | 708 | |
| 789 | 709 | /** |
| 790 | - * @param int|string $id Form ID or key. | |
| 791 | - * | |
| 792 | 710 | * @return string form name |
| 793 | 711 | */ |
| 794 | 712 | public static function getName( $id ) { |
| 795 | 713 | $form = FrmDb::check_cache( $id, 'frm_form' ); |
| 714 | + if ( $form ) { | |
| 715 | + $r = stripslashes( $form->name ); | |
| 796 | 716 | |
| 797 | - if ( $form ) { | |
| 798 | - return stripslashes( $form->name ); | |
| 717 | + return $r; | |
| 799 | 718 | } |
| 800 | 719 | |
| 801 | 720 | $query_key = is_numeric( $id ) ? 'id' : 'form_key'; |
| 802 | 721 | $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' ); |
| @@ -801,9 +720,11 @@ | ||
| 801 | 720 | $query_key = is_numeric( $id ) ? 'id' : 'form_key'; |
| 802 | 721 | $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' ); |
| 803 | 722 | |
| 804 | 723 | // An empty form name can result in a null value. |
| 805 | - return is_null( $r ) ? '' : stripslashes( $r ); | |
| 724 | + $r = is_null( $r ) ? '' : stripslashes( $r ); | |
| 725 | + | |
| 726 | + return $r; | |
| 806 | 727 | } |
| 807 | 728 | |
| 808 | 729 | /** |
| 809 | 730 | * @since 3.0 |
| @@ -818,9 +739,9 @@ | ||
| 818 | 739 | |
| 819 | 740 | /** |
| 820 | 741 | * @since 3.0 |
| 821 | 742 | * |
| 822 | - * @param int|string $id | |
| 743 | + * @param int $id | |
| 823 | 744 | * |
| 824 | 745 | * @return string form key |
| 825 | 746 | */ |
| 826 | 747 | public static function get_key_by_id( $id ) { |
| @@ -825,57 +746,59 @@ | ||
| 825 | 746 | */ |
| 826 | 747 | public static function get_key_by_id( $id ) { |
| 827 | 748 | $id = (int) $id; |
| 828 | 749 | $cache = FrmDb::check_cache( $id, 'frm_form' ); |
| 829 | - | |
| 830 | 750 | if ( $cache ) { |
| 831 | 751 | return $cache->form_key; |
| 832 | 752 | } |
| 833 | 753 | |
| 834 | - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' ); | |
| 754 | + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' ); | |
| 755 | + | |
| 756 | + return $key; | |
| 835 | 757 | } |
| 836 | 758 | |
| 837 | 759 | /** |
| 838 | 760 | * If $form is numeric, get the form object |
| 839 | 761 | * |
| 762 | + * @param object|int $form | |
| 763 | + * | |
| 840 | 764 | * @since 2.0.9 |
| 841 | - * | |
| 842 | - * @param array|int|object $form | |
| 843 | - * | |
| 844 | - * @return void | |
| 845 | 765 | */ |
| 846 | 766 | public static function maybe_get_form( &$form ) { |
| 847 | - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) { | |
| 767 | + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) { | |
| 848 | 768 | $form = self::getOne( $form ); |
| 849 | 769 | } |
| 850 | 770 | } |
| 851 | 771 | |
| 852 | 772 | /** |
| 853 | - * @param int|string $id | |
| 854 | - * @param false|int $blog_id | |
| 855 | - * | |
| 856 | - * @return stdClass|null | |
| 773 | + * @return object form | |
| 857 | 774 | */ |
| 858 | 775 | public static function getOne( $id, $blog_id = false ) { |
| 859 | 776 | global $wpdb; |
| 860 | 777 | |
| 861 | 778 | if ( $blog_id && is_multisite() ) { |
| 862 | - $prefix = $wpdb->get_blog_prefix( $blog_id ); | |
| 779 | + global $wpmuBaseTablePrefix; | |
| 780 | + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id ); | |
| 781 | + | |
| 863 | 782 | $table_name = $prefix . 'frm_forms'; |
| 864 | 783 | } else { |
| 865 | 784 | $table_name = $wpdb->prefix . 'frm_forms'; |
| 866 | 785 | $cache = wp_cache_get( $id, 'frm_form' ); |
| 867 | - | |
| 868 | 786 | if ( $cache ) { |
| 869 | 787 | if ( isset( $cache->options ) ) { |
| 870 | 788 | FrmAppHelper::unserialize_or_decode( $cache->options ); |
| 871 | 789 | } |
| 872 | 790 | |
| 873 | - return self::prepare_form_row_data( $cache ); | |
| 791 | + return apply_filters( 'frm_form_object', wp_unslash( $cache ) ); | |
| 874 | 792 | } |
| 875 | 793 | } |
| 876 | 794 | |
| 877 | - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id ); | |
| 795 | + if ( is_numeric( $id ) ) { | |
| 796 | + $where = array( 'id' => $id ); | |
| 797 | + } else { | |
| 798 | + $where = array( 'form_key' => $id ); | |
| 799 | + } | |
| 800 | + | |
| 878 | 801 | $results = FrmDb::get_row( $table_name, $where ); |
| 879 | 802 | |
| 880 | 803 | if ( isset( $results->options ) ) { |
| 881 | 804 | FrmDb::set_cache( $results->id, $results, 'frm_form' ); |
| @@ -881,50 +804,18 @@ | ||
| 881 | 804 | FrmDb::set_cache( $results->id, $results, 'frm_form' ); |
| 882 | 805 | FrmAppHelper::unserialize_or_decode( $results->options ); |
| 883 | 806 | } |
| 884 | 807 | |
| 885 | - return self::prepare_form_row_data( $results ); | |
| 808 | + return apply_filters( 'frm_form_object', wp_unslash( $results ) ); | |
| 886 | 809 | } |
| 887 | 810 | |
| 888 | 811 | /** |
| 889 | - * Make sure that if $row is an object, that $row->options is an array and not a string. | |
| 890 | - * | |
| 891 | - * @since 6.8.3 | |
| 892 | - * | |
| 893 | - * @param stdClass|null $row The database row for a target form. | |
| 894 | - * | |
| 895 | - * @return stdClass|null | |
| 812 | + * @return object|array of objects | |
| 896 | 813 | */ |
| 897 | - private static function prepare_form_row_data( $row ) { | |
| 898 | - $row = wp_unslash( $row ); | |
| 899 | - | |
| 900 | - if ( ! is_object( $row ) ) { | |
| 901 | - return $row; | |
| 902 | - } | |
| 903 | - | |
| 904 | - if ( ! is_array( $row->options ) ) { | |
| 905 | - $row->options = FrmFormsHelper::get_default_opts(); | |
| 906 | - } | |
| 907 | - | |
| 908 | - /** | |
| 909 | - * @since 4.03.02 | |
| 910 | - * | |
| 911 | - * @param stdClass $row | |
| 912 | - */ | |
| 913 | - return apply_filters( 'frm_form_object', $row ); | |
| 914 | - } | |
| 915 | - | |
| 916 | - /** | |
| 917 | - * @param array|string $where Where conditions array or raw WHERE string. | |
| 918 | - * @param string $order_by Order by clause. | |
| 919 | - * @param int|string $limit Limit clause or number. | |
| 920 | - * | |
| 921 | - * @return array|object Array of objects. If $limit is 1, a single object is returned. | |
| 922 | - */ | |
| 923 | 814 | public static function getAll( $where = array(), $order_by = '', $limit = '' ) { |
| 924 | - if ( is_array( $where ) && $where ) { | |
| 925 | - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) { | |
| 926 | - // Don't get trashed templates | |
| 815 | + if ( is_array( $where ) && ! empty( $where ) ) { | |
| 816 | + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) { | |
| 817 | + // don't get trashed templates | |
| 927 | 818 | $where['status'] = array( null, '', 'published' ); |
| 928 | 819 | } |
| 929 | 820 | |
| 930 | 821 | $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) ); |
| @@ -931,9 +822,9 @@ | ||
| 931 | 822 | } else { |
| 932 | 823 | global $wpdb; |
| 933 | 824 | |
| 934 | 825 | // The query has already been prepared if this is not an array. |
| 935 | - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 826 | + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); | |
| 936 | 827 | $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared |
| 937 | 828 | } |
| 938 | 829 | |
| 939 | 830 | if ( $results ) { |
| @@ -942,10 +833,10 @@ | ||
| 942 | 833 | FrmAppHelper::unserialize_or_decode( $result->options ); |
| 943 | 834 | } |
| 944 | 835 | } |
| 945 | 836 | |
| 946 | - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) { | |
| 947 | - // Return the first form object if we are only getting one form | |
| 837 | + if ( $limit == ' LIMIT 1' || $limit == 1 ) { | |
| 838 | + // return the first form object if we are only getting one form | |
| 948 | 839 | $results = reset( $results ); |
| 949 | 840 | } |
| 950 | 841 | |
| 951 | 842 | return wp_unslash( $results ); |
| @@ -958,20 +849,20 @@ | ||
| 958 | 849 | * |
| 959 | 850 | * @param array $query |
| 960 | 851 | * @param int $limit |
| 961 | 852 | * @param string $inc_children |
| 962 | - * | |
| 963 | - * @return array|object Array of forms. A single form object is returned if $limit is set to 1. | |
| 853 | + * @return array|object of forms A single form object would be passed if $limit was set to 1. | |
| 964 | 854 | */ |
| 965 | 855 | public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) { |
| 966 | 856 | $query['is_template'] = 0; |
| 967 | 857 | $query['status'] = array( null, '', 'published' ); |
| 968 | - | |
| 969 | - if ( $inc_children === 'exclude' ) { | |
| 858 | + if ( $inc_children == 'exclude' ) { | |
| 970 | 859 | $query['parent_form_id'] = array( null, 0 ); |
| 971 | 860 | } |
| 972 | 861 | |
| 973 | - return self::getAll( $query, 'name', $limit ); | |
| 862 | + $forms = self::getAll( $query, 'name', $limit ); | |
| 863 | + | |
| 864 | + return $forms; | |
| 974 | 865 | } |
| 975 | 866 | |
| 976 | 867 | /** |
| 977 | 868 | * @return object count of forms |
| @@ -976,16 +867,18 @@ | ||
| 976 | 867 | /** |
| 977 | 868 | * @return object count of forms |
| 978 | 869 | */ |
| 979 | 870 | public static function get_count() { |
| 871 | + global $wpdb; | |
| 872 | + | |
| 980 | 873 | $cache_key = 'frm_form_counts'; |
| 981 | - $counts = wp_cache_get( $cache_key, 'frm_form' ); | |
| 982 | 874 | |
| 875 | + $counts = wp_cache_get( $cache_key, 'frm_form' ); | |
| 983 | 876 | if ( false !== $counts ) { |
| 984 | 877 | return $counts; |
| 985 | 878 | } |
| 986 | 879 | |
| 987 | - $results = FrmDb::get_results( | |
| 880 | + $results = (array) FrmDb::get_results( | |
| 988 | 881 | 'frm_forms', |
| 989 | 882 | array( |
| 990 | 883 | 'or' => 1, |
| 991 | 884 | 'parent_form_id' => null, |
| @@ -997,20 +890,20 @@ | ||
| 997 | 890 | $statuses = array( 'published', 'draft', 'template', 'trash' ); |
| 998 | 891 | $counts = array_fill_keys( $statuses, 0 ); |
| 999 | 892 | |
| 1000 | 893 | foreach ( $results as $row ) { |
| 1001 | - if ( 'trash' !== $row->status ) { | |
| 894 | + if ( 'trash' != $row->status ) { | |
| 1002 | 895 | if ( $row->is_template ) { |
| 1003 | - ++$counts['template']; | |
| 896 | + $counts['template'] ++; | |
| 1004 | 897 | } else { |
| 1005 | - ++$counts['published']; | |
| 898 | + $counts['published'] ++; | |
| 1006 | 899 | } |
| 1007 | 900 | } else { |
| 1008 | - ++$counts['trash']; | |
| 901 | + $counts['trash'] ++; | |
| 1009 | 902 | } |
| 1010 | 903 | |
| 1011 | - if ( 'draft' === $row->status ) { | |
| 1012 | - ++$counts['draft']; | |
| 904 | + if ( 'draft' == $row->status ) { | |
| 905 | + $counts['draft'] ++; | |
| 1013 | 906 | } |
| 1014 | 907 | |
| 1015 | 908 | unset( $row ); |
| 1016 | 909 | } |
| @@ -1026,10 +919,8 @@ | ||
| 1026 | 919 | * Called when a form is created, updated, duplicated, or deleted |
| 1027 | 920 | * or when the form status is changed |
| 1028 | 921 | * |
| 1029 | 922 | * @since 2.0.4 |
| 1030 | - * | |
| 1031 | - * @return void | |
| 1032 | 923 | */ |
| 1033 | 924 | public static function clear_form_cache() { |
| 1034 | 925 | FrmDb::cache_delete_group( 'frm_form' ); |
| 1035 | 926 | } |
| @@ -1034,22 +925,16 @@ | ||
| 1034 | 925 | FrmDb::cache_delete_group( 'frm_form' ); |
| 1035 | 926 | } |
| 1036 | 927 | |
| 1037 | 928 | /** |
| 1038 | - * @param array $values Form values to validate. | |
| 1039 | - * | |
| 1040 | 929 | * @return array of errors |
| 1041 | 930 | */ |
| 1042 | 931 | public static function validate( $values ) { |
| 1043 | 932 | $errors = array(); |
| 933 | + | |
| 1044 | 934 | return apply_filters( 'frm_validate_form', $errors, $values ); |
| 1045 | 935 | } |
| 1046 | 936 | |
| 1047 | - /** | |
| 1048 | - * @param object|null $form | |
| 1049 | - * | |
| 1050 | - * @return array | |
| 1051 | - */ | |
| 1052 | 937 | public static function get_params( $form = null ) { |
| 1053 | 938 | global $frm_vars; |
| 1054 | 939 | |
| 1055 | 940 | if ( ! $form ) { |
| @@ -1079,18 +964,16 @@ | ||
| 1079 | 964 | ); |
| 1080 | 965 | |
| 1081 | 966 | $values = array(); |
| 1082 | 967 | $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' ); |
| 1083 | - | |
| 1084 | 968 | if ( ! $values['posted_form_id'] ) { |
| 1085 | 969 | $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' ); |
| 1086 | 970 | } |
| 1087 | 971 | |
| 1088 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 1089 | 972 | if ( $form->id == $values['posted_form_id'] ) { |
| 1090 | 973 | // If there are two forms on the same page, make sure not to submit both. |
| 1091 | 974 | foreach ( $default_values as $var => $default ) { |
| 1092 | - if ( $var === 'action' ) { | |
| 975 | + if ( $var == 'action' ) { | |
| 1093 | 976 | $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' ); |
| 1094 | 977 | } else { |
| 1095 | 978 | $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
| 1096 | 979 | } |
| @@ -1102,9 +985,9 @@ | ||
| 1102 | 985 | unset( $var, $default ); |
| 1103 | 986 | } |
| 1104 | 987 | } |
| 1105 | 988 | |
| 1106 | - if ( in_array( $values['action'], array( 'create', 'update' ), true ) && | |
| 989 | + if ( in_array( $values['action'], array( 'create', 'update' ) ) && | |
| 1107 | 990 | ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing |
| 1108 | 991 | ) { |
| 1109 | 992 | $values['action'] = 'new'; |
| 1110 | 993 | } |
| @@ -1111,11 +994,8 @@ | ||
| 1111 | 994 | |
| 1112 | 995 | return $values; |
| 1113 | 996 | } |
| 1114 | 997 | |
| 1115 | - /** | |
| 1116 | - * @return array | |
| 1117 | - */ | |
| 1118 | 998 | public static function list_page_params() { |
| 1119 | 999 | $values = array(); |
| 1120 | 1000 | $defaults = array( |
| 1121 | 1001 | 'template' => 0, |
| @@ -1125,9 +1005,8 @@ | ||
| 1125 | 1005 | 'search' => '', |
| 1126 | 1006 | 'sort' => '', |
| 1127 | 1007 | 'sdir' => '', |
| 1128 | 1008 | ); |
| 1129 | - | |
| 1130 | 1009 | foreach ( $defaults as $var => $default ) { |
| 1131 | 1010 | $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
| 1132 | 1011 | } |
| 1133 | 1012 | |
| @@ -1133,16 +1012,10 @@ | ||
| 1133 | 1012 | |
| 1134 | 1013 | return $values; |
| 1135 | 1014 | } |
| 1136 | 1015 | |
| 1137 | - /** | |
| 1138 | - * @param int|object|string|null $form | |
| 1139 | - * | |
| 1140 | - * @return array | |
| 1141 | - */ | |
| 1142 | 1016 | public static function get_admin_params( $form = null ) { |
| 1143 | 1017 | $form_id = $form; |
| 1144 | - | |
| 1145 | 1018 | if ( $form === null ) { |
| 1146 | 1019 | $form_id = self::get_current_form_id(); |
| 1147 | 1020 | } elseif ( $form && is_object( $form ) ) { |
| 1148 | 1021 | $form_id = $form->id; |
| @@ -1160,9 +1033,8 @@ | ||
| 1160 | 1033 | 'sdir' => '', |
| 1161 | 1034 | 'fid' => '', |
| 1162 | 1035 | 'keep_post' => '', |
| 1163 | 1036 | ); |
| 1164 | - | |
| 1165 | 1037 | foreach ( $defaults as $var => $default ) { |
| 1166 | 1038 | $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
| 1167 | 1039 | } |
| 1168 | 1040 | |
| @@ -1168,55 +1040,47 @@ | ||
| 1168 | 1040 | |
| 1169 | 1041 | return $values; |
| 1170 | 1042 | } |
| 1171 | 1043 | |
| 1172 | - /** | |
| 1173 | - * @param string $default_form | |
| 1174 | - * | |
| 1175 | - * @return int|string | |
| 1176 | - */ | |
| 1177 | 1044 | public static function get_current_form_id( $default_form = 'none' ) { |
| 1178 | - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form(); | |
| 1179 | - return $form ? $form->id : 0; | |
| 1045 | + if ( 'first' == $default_form ) { | |
| 1046 | + $form = self::get_current_form(); | |
| 1047 | + } else { | |
| 1048 | + $form = self::maybe_get_current_form(); | |
| 1049 | + } | |
| 1050 | + $form_id = $form ? $form->id : 0; | |
| 1051 | + | |
| 1052 | + return $form_id; | |
| 1180 | 1053 | } |
| 1181 | 1054 | |
| 1182 | - /** | |
| 1183 | - * @param int|string $form_id | |
| 1184 | - * | |
| 1185 | - * @return false|int|object|string | |
| 1186 | - */ | |
| 1187 | 1055 | public static function maybe_get_current_form( $form_id = 0 ) { |
| 1188 | 1056 | global $frm_vars; |
| 1189 | 1057 | |
| 1190 | - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) { | |
| 1058 | + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) { | |
| 1191 | 1059 | return $frm_vars['current_form']; |
| 1192 | 1060 | } |
| 1193 | 1061 | |
| 1194 | 1062 | $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' ); |
| 1063 | + if ( $form_id ) { | |
| 1064 | + $form_id = self::set_current_form( $form_id ); | |
| 1065 | + } | |
| 1195 | 1066 | |
| 1196 | - return $form_id ? self::set_current_form( $form_id ) : $form_id; | |
| 1067 | + return $form_id; | |
| 1197 | 1068 | } |
| 1198 | 1069 | |
| 1199 | - /** | |
| 1200 | - * @param int $form_id | |
| 1201 | - * | |
| 1202 | - * @return false|object | |
| 1203 | - */ | |
| 1204 | 1070 | public static function get_current_form( $form_id = 0 ) { |
| 1205 | 1071 | $form = self::maybe_get_current_form( $form_id ); |
| 1206 | - return is_numeric( $form ) ? self::set_current_form( $form ) : $form; | |
| 1072 | + if ( is_numeric( $form ) ) { | |
| 1073 | + $form = self::set_current_form( $form ); | |
| 1074 | + } | |
| 1075 | + | |
| 1076 | + return $form; | |
| 1207 | 1077 | } |
| 1208 | 1078 | |
| 1209 | - /** | |
| 1210 | - * @param int $form_id | |
| 1211 | - * | |
| 1212 | - * @return false|object | |
| 1213 | - */ | |
| 1214 | 1079 | public static function set_current_form( $form_id ) { |
| 1215 | 1080 | global $frm_vars; |
| 1216 | 1081 | |
| 1217 | 1082 | $query = array(); |
| 1218 | - | |
| 1219 | 1083 | if ( $form_id ) { |
| 1220 | 1084 | $query['id'] = $form_id; |
| 1221 | 1085 | } |
| 1222 | 1086 | |
| @@ -1224,19 +1088,11 @@ | ||
| 1224 | 1088 | |
| 1225 | 1089 | return $frm_vars['current_form']; |
| 1226 | 1090 | } |
| 1227 | 1091 | |
| 1228 | - /** | |
| 1229 | - * @param object $form | |
| 1230 | - * @param int|string $this_load | |
| 1231 | - * @param bool $global_load | |
| 1232 | - * | |
| 1233 | - * @return bool | |
| 1234 | - */ | |
| 1235 | 1092 | public static function is_form_loaded( $form, $this_load, $global_load ) { |
| 1236 | 1093 | global $frm_vars; |
| 1237 | 1094 | $small_form = new stdClass(); |
| 1238 | - | |
| 1239 | 1095 | foreach ( array( 'id', 'form_key', 'name' ) as $var ) { |
| 1240 | 1096 | $small_form->{$var} = $form->{$var}; |
| 1241 | 1097 | unset( $var ); |
| 1242 | 1098 | } |
| @@ -1242,14 +1098,14 @@ | ||
| 1242 | 1098 | } |
| 1243 | 1099 | |
| 1244 | 1100 | $frm_vars['forms_loaded'][] = $small_form; |
| 1245 | 1101 | |
| 1246 | - if ( $this_load && ! $global_load ) { | |
| 1102 | + if ( $this_load && empty( $global_load ) ) { | |
| 1247 | 1103 | $global_load = true; |
| 1248 | 1104 | $frm_vars['load_css'] = true; |
| 1249 | 1105 | } |
| 1250 | 1106 | |
| 1251 | - return empty( $frm_vars['css_loaded'] ) && $global_load; | |
| 1107 | + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load ); | |
| 1252 | 1108 | } |
| 1253 | 1109 | |
| 1254 | 1110 | /** |
| 1255 | 1111 | * @since 4.06.03 |
| @@ -1257,9 +1113,9 @@ | ||
| 1257 | 1113 | * @param object $form |
| 1258 | 1114 | * |
| 1259 | 1115 | * @return bool |
| 1260 | 1116 | */ |
| 1261 | - public static function is_visible_to_user( $form ) { | |
| 1117 | + public static function &is_visible_to_user( $form ) { | |
| 1262 | 1118 | if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) { |
| 1263 | 1119 | $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] ); |
| 1264 | 1120 | } else { |
| 1265 | 1121 | $visible = true; |
| @@ -1264,39 +1120,26 @@ | ||
| 1264 | 1120 | } else { |
| 1265 | 1121 | $visible = true; |
| 1266 | 1122 | } |
| 1267 | 1123 | |
| 1268 | - /** | |
| 1269 | - * @since 6.25 | |
| 1270 | - * | |
| 1271 | - * @param bool $visible | |
| 1272 | - * @param object $form | |
| 1273 | - */ | |
| 1274 | - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form ); | |
| 1124 | + return $visible; | |
| 1275 | 1125 | } |
| 1276 | 1126 | |
| 1277 | - /** | |
| 1278 | - * @param object $form | |
| 1279 | - * | |
| 1280 | - * @return bool | |
| 1281 | - */ | |
| 1282 | 1127 | public static function show_submit( $form ) { |
| 1283 | - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin(); | |
| 1284 | - return apply_filters( 'frm_show_submit_button', $show, $form ); | |
| 1128 | + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() ); | |
| 1129 | + $show = apply_filters( 'frm_show_submit_button', $show, $form ); | |
| 1130 | + | |
| 1131 | + return $show; | |
| 1285 | 1132 | } |
| 1286 | 1133 | |
| 1287 | 1134 | /** |
| 1288 | 1135 | * @since 2.3 |
| 1289 | - * | |
| 1290 | - * @param array $atts Attributes including form, option, and default. | |
| 1291 | - * | |
| 1292 | - * @return mixed | |
| 1293 | 1136 | */ |
| 1294 | 1137 | public static function get_option( $atts ) { |
| 1295 | - $form = $atts['form']; | |
| 1296 | - $default = $atts['default'] ?? ''; | |
| 1138 | + $form = $atts['form']; | |
| 1139 | + $default = isset( $atts['default'] ) ? $atts['default'] : ''; | |
| 1297 | 1140 | |
| 1298 | - return $form->options[ $atts['option'] ] ?? $default; | |
| 1141 | + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default; | |
| 1299 | 1142 | } |
| 1300 | 1143 | |
| 1301 | 1144 | /** |
| 1302 | 1145 | * Get the link to edit this form. |
| @@ -1301,12 +1144,9 @@ | ||
| 1301 | 1144 | /** |
| 1302 | 1145 | * Get the link to edit this form. |
| 1303 | 1146 | * |
| 1304 | 1147 | * @since 4.0 |
| 1305 | - * | |
| 1306 | 1148 | * @param int $form_id The id of the form. |
| 1307 | - * | |
| 1308 | - * @return string | |
| 1309 | 1149 | */ |
| 1310 | 1150 | public static function get_edit_link( $form_id ) { |
| 1311 | 1151 | return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id ); |
| 1312 | 1152 | } |
| @@ -1316,9 +1156,8 @@ | ||
| 1316 | 1156 | * |
| 1317 | 1157 | * @since 6.2 |
| 1318 | 1158 | * |
| 1319 | 1159 | * @param stdClass $form |
| 1320 | - * | |
| 1321 | 1160 | * @return bool |
| 1322 | 1161 | */ |
| 1323 | 1162 | public static function is_ajax_on( $form ) { |
| 1324 | 1163 | return ! empty( $form->options['ajax_submit'] ); |
| @@ -1327,12 +1166,12 @@ | ||
| 1327 | 1166 | /** |
| 1328 | 1167 | * Get the latest form available. |
| 1329 | 1168 | * |
| 1330 | 1169 | * @since 6.8 |
| 1331 | - * | |
| 1332 | 1170 | * @return object |
| 1333 | 1171 | */ |
| 1334 | 1172 | public static function get_latest_form() { |
| 1173 | + | |
| 1335 | 1174 | $args = array( |
| 1336 | 1175 | array( |
| 1337 | 1176 | 'or' => 1, |
| 1338 | 1177 | 'parent_form_id' => null, |
| @@ -1348,12 +1187,12 @@ | ||
| 1348 | 1187 | /** |
| 1349 | 1188 | * Count and return total forms. |
| 1350 | 1189 | * |
| 1351 | 1190 | * @since 6.8 |
| 1352 | - * | |
| 1353 | 1191 | * @return int |
| 1354 | 1192 | */ |
| 1355 | 1193 | public static function get_forms_count() { |
| 1194 | + | |
| 1356 | 1195 | $args = array( |
| 1357 | 1196 | array( |
| 1358 | 1197 | 'or' => 1, |
| 1359 | 1198 | 'parent_form_id' => null, |
| @@ -1367,13 +1206,11 @@ | ||
| 1367 | 1206 | } |
| 1368 | 1207 | |
| 1369 | 1208 | /** |
| 1370 | 1209 | * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations). |
| 1371 | - * | |
| 1372 | 1210 | * @codeCoverageIgnore |
| 1373 | 1211 | * |
| 1374 | 1212 | * @param string $key |
| 1375 | - * | |
| 1376 | 1213 | * @return int form id |
| 1377 | 1214 | */ |
| 1378 | 1215 | public static function getIdByKey( $key ) { |
| 1379 | 1216 | _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' ); |
| @@ -1381,13 +1218,11 @@ | ||
| 1381 | 1218 | } |
| 1382 | 1219 | |
| 1383 | 1220 | /** |
| 1384 | 1221 | * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13. |
| 1385 | - * | |
| 1386 | 1222 | * @codeCoverageIgnore |
| 1387 | 1223 | * |
| 1388 | - * @param int|string $id | |
| 1389 | - * | |
| 1224 | + * @param string|int $id | |
| 1390 | 1225 | * @return string |
| 1391 | 1226 | */ |
| 1392 | 1227 | public static function getKeyById( $id ) { |
| 1393 | 1228 | _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' ); |
