← All changes | classes/helpers/FrmListHelper.php +14 -15 6.28 → trunk View file →

		@@ -304,12 +304,14 @@
304	304	*
305	305	* @return void
306	306	*/
307	307	private function hidden_search_inputs( $param_name ) {
308		- if ( ! empty( $_REQUEST[ $param_name ] ) ) {
309		- $value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
310		- echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
	308	+ if ( empty( $_REQUEST[ $param_name ] ) ) {
	309	+ return;
311	310	}
	311	+
	312	+ $value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
	313	+ echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
312	314	}
313	315
314	316	/**
315	317	* Get an associative array ( id => link ) with the list
		@@ -399,9 +401,9 @@
399	401	} else {
400	402	$two = '2';
401	403	}//end if
402	404
403		- if ( empty( $this->_actions ) ) {
	405	+ if ( ! $this->_actions ) {
404	406	return;
405	407	}
406	408
407	409	echo "<label for='bulk-action-selector-" . esc_attr( $which ) . "' class='screen-reader-text'>" . esc_html__( 'Select bulk action', 'formidable' ) . '</label>';
		@@ -540,10 +542,9 @@
540	542	<?php
541	543	foreach ( $this->modes as $mode => $title ) {
542	544	$classes = array( 'view-' . $mode );
543	545
544		- // phpcs:ignore Universal.Operators.StrictComparisons
545		- if ( $current_mode == $mode ) {
	546	+ if ( $current_mode === $mode ) {
546	547	$classes[] = 'current';
547	548	}
548	549
549	550	printf(
		@@ -616,9 +617,9 @@
616	617	*
617	618	* @param string $which
618	619	*/
619	620	protected function pagination( $which ) {
620		- if ( empty( $this->_pagination_args ) ) {
	621	+ if ( ! $this->_pagination_args ) {
621	622	return;
622	623	}
623	624
624	625	$total_items = $this->_pagination_args['total_items'];
		@@ -822,14 +823,13 @@
822	823	*
823	824	* @return string Name of the default primary column, in this case, an empty string.
824	825	*/
825	826	protected function get_default_primary_column_name() {
826		- $columns = $this->get_columns();
827		- $column = '';
	827	+ $column = '';
828	828
829	829	// We need a primary defined so responsive views show something,
830	830	// So let's fall back to the first non-checkbox column.
831		- foreach ( $columns as $col => $column_name ) {
	831	+ foreach ( $this->get_columns() as $col => $column_name ) {
832	832	if ( 'cb' === $col ) {
833	833	continue;
834	834	}
835	835
		@@ -894,11 +894,10 @@
894	894
895	895	return $column_headers;
896	896	}
897	897
898		- $columns = get_column_headers( $this->screen );
899		- $hidden = get_hidden_columns( $this->screen );
900		- $sortable_columns = $this->get_sortable_columns();
	898	+ $columns = get_column_headers( $this->screen );
	899	+ $hidden = get_hidden_columns( $this->screen );
901	900	/**
902	901	* Filter the list table sortable columns for a specific screen.
903	902	*
904	903	* The dynamic portion of the hook name, `$this->screen->id`, refers
		@@ -907,9 +906,9 @@
907	906	* @since 3.5.0
908	907	*
909	908	* @param array $sortable_columns An array of sortable columns.
910	909	*/
911		- $_sortable = apply_filters( "manage_{$this->screen->id}_sortable_columns", $sortable_columns );
	910	+ $_sortable = apply_filters( "manage_{$this->screen->id}_sortable_columns", $this->get_sortable_columns() );
912	911
913	912	$sortable = array();
914	913
915	914	foreach ( $_sortable as $id => $data ) {
		@@ -1214,9 +1213,9 @@
1214	1213	* Generates content for a single row of the table
1215	1214	*
1216	1215	* @since 2.0.18
1217	1216	*
1218		- * @param object $item The current item.
	1217	+ * @param stdClass $item The current item.
1219	1218	*/
1220	1219	public function single_row( $item ) {
1221	1220	echo '<tr>';
1222	1221	$this->single_row_columns( $item );