| @@ -1,8 +1,14 @@ | ||
| 1 | 1 | <?php // phpcs:ignore WordPress.Files.FileName.InvalidClassFileName |
| 2 | 2 | |
| 3 | 3 | // phpcs:disable Universal.Files.SeparateFunctionsFromOO.Mixed -- TODO: Move classes to appropriately-named class files. |
| 4 | 4 | |
| 5 | +use Automattic\Jetpack\Assets; | |
| 6 | + | |
| 7 | +if ( ! defined( 'ABSPATH' ) ) { | |
| 8 | + exit( 0 ); | |
| 9 | +} | |
| 10 | + | |
| 5 | 11 | /** |
| 6 | 12 | * Jetpack_Subscriptions_Widget main view class. |
| 7 | 13 | */ |
| 8 | 14 | class Jetpack_Subscriptions_Widget extends WP_Widget { |
| @@ -64,14 +70,16 @@ | ||
| 64 | 70 | $name, |
| 65 | 71 | $widget_ops |
| 66 | 72 | ); |
| 67 | 73 | |
| 68 | - if ( self::is_jetpack() && | |
| 69 | - ( | |
| 74 | + if ( | |
| 75 | + self::is_jetpack() | |
| 76 | + && ( | |
| 70 | 77 | is_active_widget( false, false, $this->id_base ) || |
| 71 | 78 | is_active_widget( false, false, 'monster' ) || |
| 72 | 79 | is_customize_preview() |
| 73 | 80 | ) |
| 81 | + && ! wp_is_block_theme() | |
| 74 | 82 | ) { |
| 75 | 83 | add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_style' ) ); |
| 76 | 84 | } |
| 77 | 85 | |
| @@ -94,15 +102,28 @@ | ||
| 94 | 102 | * |
| 95 | 103 | * @since 4.5.0 |
| 96 | 104 | */ |
| 97 | 105 | public function enqueue_style() { |
| 98 | - wp_register_style( | |
| 106 | + $path = Assets::get_file_url_for_environment( | |
| 107 | + '_inc/build/subscriptions/subscriptions.min.css', | |
| 108 | + 'modules/subscriptions/subscriptions.css' | |
| 109 | + ); | |
| 110 | + | |
| 111 | + wp_enqueue_style( | |
| 99 | 112 | 'jetpack-subscriptions', |
| 100 | - plugins_url( 'subscriptions.css', __FILE__ ), | |
| 113 | + $path, | |
| 101 | 114 | array(), |
| 102 | 115 | JETPACK__VERSION |
| 103 | 116 | ); |
| 104 | - wp_enqueue_style( 'jetpack-subscriptions' ); | |
| 117 | + | |
| 118 | + // `wp_maybe_inline_styles()` requires a filesystem path, not a URL. | |
| 119 | + $style_path = JETPACK__PLUGIN_DIR . ( | |
| 120 | + /** This filter is documented in projects/plugins/jetpack/load-jetpack.php */ | |
| 121 | + apply_filters( 'jetpack_should_use_minified_assets', true ) | |
| 122 | + ? '_inc/build/subscriptions/subscriptions.min.css' | |
| 123 | + : 'modules/subscriptions/subscriptions.css' | |
| 124 | + ); | |
| 125 | + wp_style_add_data( 'jetpack-subscriptions', 'path', $style_path ); | |
| 105 | 126 | } |
| 106 | 127 | |
| 107 | 128 | /** |
| 108 | 129 | * Renders a full widget either within the context of WordPress widget, or in response to a shortcode. |
| @@ -113,10 +134,14 @@ | ||
| 113 | 134 | public function widget( $args, $instance ) { |
| 114 | 135 | if ( self::is_wpcom() && ! self::wpcom_has_status_message() && self::is_current_user_subscribed() ) { |
| 115 | 136 | return null; |
| 116 | 137 | } |
| 138 | + | |
| 139 | + // Enqueue styles. | |
| 140 | + self::enqueue_style(); | |
| 141 | + | |
| 117 | 142 | if ( self::is_jetpack() && |
| 118 | - /** This filter is documented in modules/contact-form/grunion-contact-form.php */ | |
| 143 | + /** This filter is documented in \Automattic\Jetpack\Forms\ContactForm\Contact_Form */ | |
| 119 | 144 | false === apply_filters( 'jetpack_auto_fill_logged_in_user', false ) |
| 120 | 145 | ) { |
| 121 | 146 | $subscribe_email = ''; |
| 122 | 147 | } else { |
| @@ -131,10 +156,10 @@ | ||
| 131 | 156 | $stats_action = self::is_jetpack() ? 'jetpack_subscriptions' : 'follow_blog'; |
| 132 | 157 | /** This action is documented in modules/widgets/gravatar-profile.php */ |
| 133 | 158 | do_action( 'jetpack_stats_extra', 'widget_view', $stats_action ); |
| 134 | 159 | |
| 135 | - $after_widget = isset( $args['after_widget'] ) ? $args['after_widget'] : ''; | |
| 136 | - $before_widget = isset( $args['before_widget'] ) ? $args['before_widget'] : ''; | |
| 160 | + $after_widget = $args['after_widget'] ?? ''; | |
| 161 | + $before_widget = $args['before_widget'] ?? ''; | |
| 137 | 162 | $instance = wp_parse_args( (array) $instance, static::defaults() ); |
| 138 | 163 | |
| 139 | 164 | echo $before_widget; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped |
| 140 | 165 | |
| @@ -156,22 +181,42 @@ | ||
| 156 | 181 | * @param array $instance The settings for the particular instance of the widget. |
| 157 | 182 | */ |
| 158 | 183 | public static function render_widget_title( $args, $instance ) { |
| 159 | 184 | $show_only_email_and_button = $instance['show_only_email_and_button']; |
| 160 | - $before_title = isset( $args['before_title'] ) ? $args['before_title'] : ''; | |
| 161 | - $after_title = isset( $args['after_title'] ) ? $args['after_title'] : ''; | |
| 185 | + $before_title = $args['before_title'] ?? ''; | |
| 186 | + $after_title = $args['after_title'] ?? ''; | |
| 162 | 187 | if ( self::is_wpcom() && ! $show_only_email_and_button ) { |
| 163 | 188 | if ( self::is_current_user_subscribed() ) { |
| 164 | 189 | if ( ! empty( $instance['title_following'] ) ) { |
| 165 | - echo $before_title . '<label for="subscribe-field' . ( self::$instance_count > 1 ? '-' . self::$instance_count : '' ) . '">' . esc_attr( $instance['title_following'] ) . '</label>' . $after_title . "\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 190 | + printf( | |
| 191 | + '%1$s<label for="subscribe-field%2$s">%3$s</label>%4$s%5$s', | |
| 192 | + $before_title, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 193 | + ( self::$instance_count > 1 ? '-' . (int) self::$instance_count : '' ), | |
| 194 | + esc_html( $instance['title_following'] ), | |
| 195 | + $after_title, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 196 | + "\n" | |
| 197 | + ); | |
| 166 | 198 | } |
| 167 | 199 | } elseif ( ! empty( $instance['title'] ) ) { |
| 168 | - echo $before_title . '<label for="subscribe-field' . ( self::$instance_count > 1 ? '-' . self::$instance_count : '' ) . '">' . $instance['title'] . '</label>' . $after_title . "\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 200 | + printf( | |
| 201 | + '%1$s<label for="subscribe-field%2$s">%3$s</label>%4$s%5$s', | |
| 202 | + $before_title, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 203 | + ( self::$instance_count > 1 ? '-' . (int) self::$instance_count : '' ), | |
| 204 | + esc_html( $instance['title'] ), | |
| 205 | + $after_title, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 206 | + "\n" | |
| 207 | + ); | |
| 169 | 208 | } |
| 170 | 209 | } |
| 171 | 210 | |
| 172 | 211 | if ( self::is_jetpack() && empty( $instance['show_only_email_and_button'] ) ) { |
| 173 | - echo $args['before_title'] . $instance['title'] . $args['after_title'] . "\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 212 | + printf( | |
| 213 | + '%1$s%2$s%3$s%4$s', | |
| 214 | + $before_title, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 215 | + esc_html( $instance['title'] ), | |
| 216 | + $after_title, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 217 | + "\n" | |
| 218 | + ); | |
| 174 | 219 | } |
| 175 | 220 | } |
| 176 | 221 | |
| 177 | 222 | /** |
| @@ -337,9 +382,9 @@ | ||
| 337 | 382 | $show_only_email_and_button = $instance['show_only_email_and_button']; |
| 338 | 383 | $show_subscribers_total = (bool) $instance['show_subscribers_total']; |
| 339 | 384 | $subscribers_total = self::fetch_subscriber_count(); |
| 340 | 385 | $subscribe_text = empty( $instance['show_only_email_and_button'] ) ? |
| 341 | - stripslashes( $instance['subscribe_text'] ) : | |
| 386 | + wp_kses_post( stripslashes( $instance['subscribe_text'] ) ) : | |
| 342 | 387 | false; |
| 343 | 388 | $referer = esc_url_raw( ( is_ssl() ? 'https' : 'http' ) . '://' . ( isset( $_SERVER['HTTP_HOST'] ) ? wp_unslash( $_SERVER['HTTP_HOST'] ) : '' ) . ( isset( $_SERVER['REQUEST_URI'] ) ? wp_unslash( $_SERVER['REQUEST_URI'] ) : '' ) ); |
| 344 | 389 | $source = 'widget'; |
| 345 | 390 | $widget_id = ! empty( $args['widget_id'] ) ? $args['widget_id'] : self::$instance_count; |
| @@ -345,12 +390,12 @@ | ||
| 345 | 390 | $widget_id = ! empty( $args['widget_id'] ) ? $args['widget_id'] : self::$instance_count; |
| 346 | 391 | $subscribe_button = ! empty( $instance['submit_button_text'] ) ? $instance['submit_button_text'] : $instance['subscribe_button']; |
| 347 | 392 | $subscribe_placeholder = isset( $instance['subscribe_placeholder'] ) ? stripslashes( $instance['subscribe_placeholder'] ) : ''; |
| 348 | 393 | $submit_button_classes = isset( $instance['submit_button_classes'] ) ? 'wp-block-button__link ' . $instance['submit_button_classes'] : 'wp-block-button__link'; |
| 349 | - $submit_button_styles = isset( $instance['submit_button_styles'] ) ? $instance['submit_button_styles'] : ''; | |
| 350 | - $submit_button_wrapper_styles = isset( $instance['submit_button_wrapper_styles'] ) ? $instance['submit_button_wrapper_styles'] : ''; | |
| 351 | - $email_field_classes = isset( $instance['email_field_classes'] ) ? $instance['email_field_classes'] : ''; | |
| 352 | - $email_field_styles = isset( $instance['email_field_styles'] ) ? $instance['email_field_styles'] : ''; | |
| 394 | + $submit_button_styles = $instance['submit_button_styles'] ?? ''; | |
| 395 | + $submit_button_wrapper_styles = $instance['submit_button_wrapper_styles'] ?? ''; | |
| 396 | + $email_field_classes = $instance['email_field_classes'] ?? ''; | |
| 397 | + $email_field_styles = $instance['email_field_styles'] ?? ''; | |
| 353 | 398 | |
| 354 | 399 | // We need to include those in case Jetpack blocks are disabled |
| 355 | 400 | require_once JETPACK__PLUGIN_DIR . 'modules/memberships/class-jetpack-memberships.php'; |
| 356 | 401 | require_once JETPACK__PLUGIN_DIR . 'extensions/blocks/premium-content/_inc/subscription-service/include.php'; |
| @@ -396,8 +441,9 @@ | ||
| 396 | 441 | printf( |
| 397 | 442 | '<input |
| 398 | 443 | type="email" |
| 399 | 444 | name="email" |
| 445 | + autocomplete="email" | |
| 400 | 446 | %1$s |
| 401 | 447 | style="%2$s" |
| 402 | 448 | placeholder="%3$s" |
| 403 | 449 | value="" |
| @@ -490,9 +536,9 @@ | ||
| 490 | 536 | class="screen-reader-text" |
| 491 | 537 | for="<?php echo esc_attr( $subscribe_field_id . '-' . $widget_id ); ?>"> |
| 492 | 538 | <?php echo ! empty( $subscribe_placeholder ) ? esc_html( $subscribe_placeholder ) : esc_html__( 'Email Address:', 'jetpack' ); ?> |
| 493 | 539 | </label> |
| 494 | - <input type="email" name="email" required="required" | |
| 540 | + <input type="email" name="email" autocomplete="email" required="required" | |
| 495 | 541 | <?php if ( ! empty( $email_field_classes ) ) { ?> |
| 496 | 542 | class="<?php echo esc_attr( $email_field_classes ); ?> required" |
| 497 | 543 | <?php } ?> |
| 498 | 544 | <?php if ( ! empty( $email_field_styles ) ) { ?> |
| @@ -619,9 +665,9 @@ | ||
| 619 | 665 | $subs_count = array( |
| 620 | 666 | 'status' => 'failed', |
| 621 | 667 | 'code' => $xml->getErrorCode(), |
| 622 | 668 | 'message' => $xml->getErrorMessage(), |
| 623 | - 'value' => ( isset( $subs_count['value'] ) ) ? $subs_count['value'] : 0, | |
| 669 | + 'value' => $subs_count['value'] ?? 0, | |
| 624 | 670 | ); |
| 625 | 671 | } else { |
| 626 | 672 | $subs_count = array( |
| 627 | 673 | 'status' => 'success', |
| @@ -647,27 +693,28 @@ | ||
| 647 | 693 | * |
| 648 | 694 | * @return array |
| 649 | 695 | */ |
| 650 | 696 | public function update( $new_instance, $old_instance ) { |
| 651 | - $instance = $old_instance; | |
| 697 | + // Merge new values over old, then fill in any missing keys with defaults | |
| 698 | + $instance = wp_parse_args( (array) $new_instance, wp_parse_args( (array) $old_instance, static::defaults() ) ); | |
| 652 | 699 | |
| 653 | 700 | if ( self::is_jetpack() ) { |
| 654 | - $instance['title'] = wp_kses( stripslashes( $new_instance['title'] ), array() ); | |
| 655 | - $instance['subscribe_placeholder'] = wp_kses( stripslashes( $new_instance['subscribe_placeholder'] ), array() ); | |
| 656 | - $instance['subscribe_button'] = wp_kses( stripslashes( $new_instance['subscribe_button'] ), array() ); | |
| 657 | - $instance['success_message'] = wp_kses( stripslashes( $new_instance['success_message'] ), array() ); | |
| 701 | + $instance['title'] = wp_kses( stripslashes( $instance['title'] ), array() ); | |
| 702 | + $instance['subscribe_placeholder'] = wp_kses( stripslashes( $instance['subscribe_placeholder'] ), array() ); | |
| 703 | + $instance['subscribe_button'] = wp_kses( stripslashes( $instance['subscribe_button'] ), array() ); | |
| 704 | + $instance['success_message'] = wp_kses( stripslashes( $instance['success_message'] ), array() ); | |
| 658 | 705 | } |
| 659 | 706 | |
| 660 | 707 | if ( self::is_wpcom() ) { |
| 661 | - $instance['title'] = wp_strip_all_tags( stripslashes( $new_instance['title'] ) ); | |
| 662 | - $instance['title_following'] = wp_strip_all_tags( stripslashes( $new_instance['title_following'] ) ); | |
| 663 | - $instance['subscribe_logged_in'] = wp_filter_post_kses( stripslashes( $new_instance['subscribe_logged_in'] ) ); | |
| 664 | - $instance['subscribe_button'] = wp_strip_all_tags( stripslashes( $new_instance['subscribe_button'] ) ); | |
| 708 | + $instance['title'] = wp_strip_all_tags( stripslashes( $instance['title'] ) ); | |
| 709 | + $instance['title_following'] = isset( $instance['title_following'] ) ? wp_strip_all_tags( stripslashes( $instance['title_following'] ) ) : ''; | |
| 710 | + $instance['subscribe_logged_in'] = isset( $instance['subscribe_logged_in'] ) ? wp_filter_post_kses( stripslashes( $instance['subscribe_logged_in'] ) ) : ''; | |
| 711 | + $instance['subscribe_button'] = wp_strip_all_tags( stripslashes( $instance['subscribe_button'] ) ); | |
| 665 | 712 | } |
| 666 | 713 | |
| 667 | 714 | $instance['show_subscribers_total'] = isset( $new_instance['show_subscribers_total'] ) && $new_instance['show_subscribers_total']; |
| 668 | 715 | $instance['show_only_email_and_button'] = isset( $new_instance['show_only_email_and_button'] ) && $new_instance['show_only_email_and_button']; |
| 669 | - $instance['subscribe_text'] = wp_filter_post_kses( stripslashes( $new_instance['subscribe_text'] ) ); | |
| 716 | + $instance['subscribe_text'] = wp_filter_post_kses( stripslashes( $instance['subscribe_text'] ) ); | |
| 670 | 717 | |
| 671 | 718 | return $instance; |
| 672 | 719 | } |
| 673 | 720 | |
| @@ -686,9 +733,9 @@ | ||
| 686 | 733 | $defaults['title'] = esc_html__( 'Subscribe to Blog via Email', 'jetpack' ); |
| 687 | 734 | $defaults['subscribe_text'] = esc_html__( 'Enter your email address to subscribe to this blog and receive notifications of new posts by email.', 'jetpack' ); |
| 688 | 735 | $defaults['subscribe_placeholder'] = esc_html__( 'Email Address', 'jetpack' ); |
| 689 | 736 | $defaults['subscribe_button'] = esc_html__( 'Subscribe', 'jetpack' ); |
| 690 | - $defaults['success_message'] = esc_html__( "Success! An email was just sent to confirm your subscription. Please find the email now and click 'Confirm Follow' to start subscribing.", 'jetpack' ); | |
| 737 | + $defaults['success_message'] = esc_html__( "Success! An email was just sent to confirm your subscription. Please find the email now and click 'Confirm' to start subscribing.", 'jetpack' ); | |
| 691 | 738 | |
| 692 | 739 | return $defaults; |
| 693 | 740 | } |
| 694 | 741 | |
| @@ -695,8 +742,9 @@ | ||
| 695 | 742 | /** |
| 696 | 743 | * Renders the widget's options form in wp-admin. |
| 697 | 744 | * |
| 698 | 745 | * @param array $instance Widget instance. |
| 746 | + * @return string|void | |
| 699 | 747 | */ |
| 700 | 748 | public function form( $instance ) { |
| 701 | 749 | $instance = wp_parse_args( (array) $instance, static::defaults() ); |
| 702 | 750 | $show_subscribers_total = checked( $instance['show_subscribers_total'], true, false ); |
| @@ -701,26 +749,14 @@ | ||
| 701 | 749 | $instance = wp_parse_args( (array) $instance, static::defaults() ); |
| 702 | 750 | $show_subscribers_total = checked( $instance['show_subscribers_total'], true, false ); |
| 703 | 751 | |
| 704 | 752 | if ( self::is_wpcom() ) { |
| 705 | - $title = esc_attr( stripslashes( $instance['title'] ) ); | |
| 706 | - $title_following = esc_attr( stripslashes( $instance['title_following'] ) ); | |
| 707 | - $subscribe_text = esc_attr( stripslashes( $instance['subscribe_text'] ) ); | |
| 708 | - $subscribe_logged_in = esc_attr( stripslashes( $instance['subscribe_logged_in'] ) ); | |
| 709 | - $subscribe_button = esc_attr( stripslashes( $instance['subscribe_button'] ) ); | |
| 753 | + $title = ! empty( $instance['title'] ) ? esc_attr( stripslashes( $instance['title'] ) ) : ''; | |
| 754 | + $title_following = ! empty( $instance['title_following'] ) ? esc_attr( stripslashes( $instance['title_following'] ) ) : ''; | |
| 755 | + $subscribe_text = ! empty( $instance['subscribe_text'] ) ? esc_attr( stripslashes( $instance['subscribe_text'] ) ) : ''; | |
| 756 | + $subscribe_logged_in = ! empty( $instance['subscribe_logged_in'] ) ? esc_attr( stripslashes( $instance['subscribe_logged_in'] ) ) : ''; | |
| 757 | + $subscribe_button = ! empty( $instance['subscribe_button'] ) ? esc_attr( stripslashes( $instance['subscribe_button'] ) ) : ''; | |
| 710 | 758 | $subscribers_total = self::fetch_subscriber_count(); |
| 711 | - } | |
| 712 | - | |
| 713 | - if ( self::is_jetpack() ) { | |
| 714 | - $title = stripslashes( $instance['title'] ); | |
| 715 | - $subscribe_text = stripslashes( $instance['subscribe_text'] ); | |
| 716 | - $subscribe_placeholder = stripslashes( $instance['subscribe_placeholder'] ); | |
| 717 | - $subscribe_button = stripslashes( $instance['subscribe_button'] ); | |
| 718 | - $success_message = stripslashes( $instance['success_message'] ); | |
| 719 | - $subscribers_total = self::fetch_subscriber_count(); | |
| 720 | - } | |
| 721 | - | |
| 722 | - if ( self::is_wpcom() ) : | |
| 723 | 759 | ?> |
| 724 | 760 | <p> |
| 725 | 761 | <label for="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>"> |
| 726 | 762 | <?php esc_html_e( 'Widget title for non-followers:', 'jetpack' ); ?> |
| @@ -772,11 +808,17 @@ | ||
| 772 | 808 | ?> |
| 773 | 809 | </label> |
| 774 | 810 | </p> |
| 775 | 811 | <?php |
| 776 | - endif; | |
| 812 | + } | |
| 777 | 813 | |
| 778 | - if ( self::is_jetpack() ) : | |
| 814 | + if ( self::is_jetpack() ) { | |
| 815 | + $title = ! empty( $instance['title'] ) ? stripslashes( $instance['title'] ) : ''; | |
| 816 | + $subscribe_text = ! empty( $instance['subscribe_text'] ) ? stripslashes( $instance['subscribe_text'] ) : ''; | |
| 817 | + $subscribe_placeholder = ! empty( $instance['subscribe_placeholder'] ) ? stripslashes( $instance['subscribe_placeholder'] ) : ''; | |
| 818 | + $subscribe_button = ! empty( $instance['subscribe_button'] ) ? stripslashes( $instance['subscribe_button'] ) : ''; | |
| 819 | + $success_message = ! empty( $instance['success_message'] ) ? stripslashes( $instance['success_message'] ) : ''; | |
| 820 | + $subscribers_total = self::fetch_subscriber_count(); | |
| 779 | 821 | ?> |
| 780 | 822 | <p> |
| 781 | 823 | <label for="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>"> |
| 782 | 824 | <?php esc_html_e( 'Widget title:', 'jetpack' ); ?> |
| @@ -828,9 +870,9 @@ | ||
| 828 | 870 | ?> |
| 829 | 871 | </label> |
| 830 | 872 | </p> |
| 831 | 873 | <?php |
| 832 | - endif; | |
| 874 | + } | |
| 833 | 875 | } |
| 834 | 876 | } |
| 835 | 877 | |
| 836 | 878 | if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) { |
| @@ -870,14 +912,14 @@ | ||
| 870 | 912 | } else { |
| 871 | 913 | $instance['include_social_followers'] = false; |
| 872 | 914 | } |
| 873 | 915 | |
| 874 | - $show_only_email_and_button = isset( $instance['show_only_email_and_button'] ) ? $instance['show_only_email_and_button'] : false; | |
| 875 | - $submit_button_text = isset( $instance['submit_button_text'] ) ? $instance['submit_button_text'] : ''; | |
| 916 | + $show_only_email_and_button = $instance['show_only_email_and_button'] ?? false; | |
| 917 | + $submit_button_text = $instance['submit_button_text'] ?? ''; | |
| 876 | 918 | |
| 877 | 919 | // Build up a string with the submit button's classes and styles and set it on the instance. |
| 878 | - $submit_button_classes = isset( $instance['submit_button_classes'] ) ? $instance['submit_button_classes'] : ''; | |
| 879 | - $email_field_classes = isset( $instance['email_field_classes'] ) ? $instance['email_field_classes'] : ''; | |
| 920 | + $submit_button_classes = $instance['submit_button_classes'] ?? ''; | |
| 921 | + $email_field_classes = $instance['email_field_classes'] ?? ''; | |
| 880 | 922 | $style = ''; |
| 881 | 923 | $submit_button_styles = ''; |
| 882 | 924 | $submit_button_wrapper_styles = ''; |
| 883 | 925 | $email_field_styles = ''; |
| @@ -913,11 +955,11 @@ | ||
| 913 | 955 | } |
| 914 | 956 | if ( isset( $instance['custom_padding'] ) && 'undefined' !== $instance['custom_padding'] ) { |
| 915 | 957 | $style = 'padding: ' . |
| 916 | 958 | $instance['custom_padding'] . 'px ' . |
| 917 | - round( $instance['custom_padding'] * 1.5 ) . 'px ' . | |
| 959 | + round( floatval( $instance['custom_padding'] ) * 1.5 ) . 'px ' . | |
| 918 | 960 | $instance['custom_padding'] . 'px ' . |
| 919 | - round( $instance['custom_padding'] * 1.5 ) . 'px; '; | |
| 961 | + round( floatval( $instance['custom_padding'] ) * 1.5 ) . 'px; '; | |
| 920 | 962 | |
| 921 | 963 | $submit_button_styles .= $style; |
| 922 | 964 | $email_field_styles .= $style; |
| 923 | 965 | } |
| @@ -928,9 +970,9 @@ | ||
| 928 | 970 | } |
| 929 | 971 | if ( isset( $instance['button_on_newline'] ) && 'true' === $instance['button_on_newline'] ) { |
| 930 | 972 | $submit_button_styles .= 'margin-top: ' . $button_spacing . 'px; '; |
| 931 | 973 | } else { |
| 932 | - $submit_button_styles .= 'margin: 0px; '; // Reset Safari's 2px default margin for buttons affecting input and button union | |
| 974 | + $submit_button_styles .= 'margin: 0; '; // Reset Safari's 2px default margin for buttons affecting input and button union | |
| 933 | 975 | $submit_button_styles .= 'margin-left: ' . $button_spacing . 'px; '; |
| 934 | 976 | } |
| 935 | 977 | |
| 936 | 978 | if ( isset( $instance['custom_border_radius'] ) && 'undefined' !== $instance['custom_border_radius'] ) { |
