| @@ -7,10 +7,18 @@ | ||
| 7 | 7 | |
| 8 | 8 | use Automattic\Jetpack\Assets; |
| 9 | 9 | use Automattic\Jetpack\Stats\Options as Stats_Options; |
| 10 | 10 | use Automattic\Jetpack\Status; |
| 11 | +use Automattic\Jetpack\Status\Host; | |
| 12 | + | |
| 13 | +if ( ! defined( 'ABSPATH' ) ) { | |
| 14 | + exit( 0 ); | |
| 15 | +} | |
| 16 | + | |
| 11 | 17 | /** |
| 12 | 18 | * Jetpack_Carousel class. |
| 19 | + * | |
| 20 | + * @phan-constructor-used-for-side-effects | |
| 13 | 21 | */ |
| 14 | 22 | class Jetpack_Carousel { |
| 15 | 23 | /** |
| 16 | 24 | * Defines Carousel pre-built widths |
| @@ -42,9 +50,9 @@ | ||
| 42 | 50 | */ |
| 43 | 51 | public $in_gallery = false; |
| 44 | 52 | |
| 45 | 53 | /** |
| 46 | - * Determines whether the Jetpack class and method exists. Default is true. | |
| 54 | + * Determines whether the module runs in the Jetpack plugin, as opposed to WP.com Simple site environment | |
| 47 | 55 | * |
| 48 | 56 | * @var bool |
| 49 | 57 | */ |
| 50 | 58 | public $in_jetpack = true; |
| @@ -77,9 +85,9 @@ | ||
| 77 | 85 | if ( $this->maybe_disable_jp_carousel() ) { |
| 78 | 86 | return; |
| 79 | 87 | } |
| 80 | 88 | |
| 81 | - $this->in_jetpack = ( class_exists( 'Jetpack' ) && method_exists( 'Jetpack', 'enable_module_configurable' ) ) ? true : false; | |
| 89 | + $this->in_jetpack = ! ( new Host() )->is_wpcom_simple(); | |
| 82 | 90 | |
| 83 | 91 | $this->single_image_gallery_enabled = ! $this->maybe_disable_jp_carousel_single_images(); |
| 84 | 92 | $this->single_image_gallery_enabled_media_file = $this->maybe_enable_jp_carousel_single_images_media_file(); |
| 85 | 93 | |
| @@ -122,8 +130,10 @@ | ||
| 122 | 130 | if ( $this->single_image_gallery_enabled ) { |
| 123 | 131 | add_filter( 'the_content', array( $this, 'add_data_img_tags_and_enqueue_assets' ) ); |
| 124 | 132 | } |
| 125 | 133 | |
| 134 | + add_filter( 'render_block_data', array( $this, 'remove_core_lightbox_in_gallery' ), 10, 3 ); | |
| 135 | + | |
| 126 | 136 | // `is_amp_request()` can't be called until the 'wp' filter. |
| 127 | 137 | add_action( 'wp', array( $this, 'check_amp_support' ) ); |
| 128 | 138 | } |
| 129 | 139 | |
| @@ -334,8 +344,28 @@ | ||
| 334 | 344 | return $content; |
| 335 | 345 | } |
| 336 | 346 | |
| 337 | 347 | /** |
| 348 | + * Remove core lightbox settings from images in a gallery, if Carousel is enabled. | |
| 349 | + * | |
| 350 | + * @param array $parsed_block An associative array of the block being rendered. | |
| 351 | + * @param array $source_block An un-modified copy of `$parsed_block`, as it appeared in the source content. | |
| 352 | + * @param WP_Block|null $parent_block If this is a nested block, a reference to the parent block. | |
| 353 | + * @return array The modified block data. | |
| 354 | + */ | |
| 355 | + public function remove_core_lightbox_in_gallery( $parsed_block, $source_block, $parent_block ) { | |
| 356 | + if ( | |
| 357 | + ! empty( $parsed_block['blockName'] ) && | |
| 358 | + 'core/image' === $parsed_block['blockName'] && | |
| 359 | + ! empty( $parent_block->name ) && | |
| 360 | + 'core/gallery' === $parent_block->name | |
| 361 | + ) { | |
| 362 | + unset( $parsed_block['attrs']['lightbox'] ); | |
| 363 | + } | |
| 364 | + return $parsed_block; | |
| 365 | + } | |
| 366 | + | |
| 367 | + /** | |
| 338 | 368 | * Enrich the gallery block content using the render_block_{$this->name} filter. |
| 339 | 369 | * This function is triggered after block render to make sure we track galleries within |
| 340 | 370 | * reusable blocks. |
| 341 | 371 | * |
| @@ -355,9 +385,9 @@ | ||
| 355 | 385 | } |
| 356 | 386 | |
| 357 | 387 | $this->enqueue_assets(); |
| 358 | 388 | |
| 359 | - if ( ! isset( $post ) ) { | |
| 389 | + if ( ! $post instanceof WP_Post ) { | |
| 360 | 390 | return $block_content; |
| 361 | 391 | } |
| 362 | 392 | |
| 363 | 393 | $blog_id = (int) get_current_blog_id(); |
| @@ -388,9 +418,9 @@ | ||
| 388 | 418 | $extra_attributes = implode( |
| 389 | 419 | ' ', |
| 390 | 420 | array_map( |
| 391 | 421 | function ( $data_key, $data_values ) { |
| 392 | - return esc_attr( $data_key ) . "='" . wp_json_encode( $data_values ) . "'"; | |
| 422 | + return esc_attr( $data_key ) . "='" . esc_attr( wp_json_encode( $data_values, JSON_UNESCAPED_SLASHES | JSON_HEX_AMP ) ) . "'"; | |
| 393 | 423 | }, |
| 394 | 424 | array_keys( $extra_data ), |
| 395 | 425 | array_values( $extra_data ) |
| 396 | 426 | ) |
| @@ -421,14 +451,12 @@ | ||
| 421 | 451 | true |
| 422 | 452 | ); |
| 423 | 453 | |
| 424 | 454 | $swiper_library_path = array( |
| 425 | - 'url' => Assets::get_file_url_for_environment( | |
| 426 | - '_inc/build/carousel/swiper-bundle.min.js', | |
| 427 | - 'modules/carousel/swiper-bundle.js' | |
| 428 | - ), | |
| 455 | + 'url' => plugins_url( '_inc/blocks/swiper.js', JETPACK__PLUGIN_FILE ), | |
| 429 | 456 | ); |
| 430 | 457 | wp_localize_script( 'jetpack-carousel', 'jetpackSwiperLibraryPath', $swiper_library_path ); |
| 458 | + add_action( 'wp_footer', array( $this, 'prefetch_swiper_library' ) ); | |
| 431 | 459 | |
| 432 | 460 | // Note: using home_url() instead of admin_url() for ajaxurl to be sure to get same domain on wpcom when using mapped domains (also works on self-hosted). |
| 433 | 461 | // Also: not hardcoding path since there is no guarantee site is running on site root in self-hosted context. |
| 434 | 462 | $is_logged_in = is_user_logged_in(); |
| @@ -448,8 +476,9 @@ | ||
| 448 | 476 | 'comment' => __( 'Comment', 'jetpack' ), |
| 449 | 477 | 'post_comment' => __( 'Post Comment', 'jetpack' ), |
| 450 | 478 | 'write_comment' => __( 'Write a Comment...', 'jetpack' ), |
| 451 | 479 | 'loading_comments' => __( 'Loading Comments...', 'jetpack' ), |
| 480 | + 'image_label' => __( 'Open image in full-screen.', 'jetpack' ), | |
| 452 | 481 | 'download_original' => sprintf( |
| 453 | 482 | /* translators: %1s is the full-size image width, and %2s is the height. */ |
| 454 | 483 | __( 'View full size <span class="photo-size">%1$s<span class="photo-size-times">×</span>%2$s</span>', 'jetpack' ), |
| 455 | 484 | '{0}', |
| @@ -513,12 +542,12 @@ | ||
| 513 | 542 | */ |
| 514 | 543 | $localize_strings = apply_filters( 'jp_carousel_localize_strings', $localize_strings ); |
| 515 | 544 | wp_localize_script( 'jetpack-carousel', 'jetpackCarouselStrings', $localize_strings ); |
| 516 | 545 | wp_enqueue_style( |
| 517 | - 'jetpack-carousel-swiper-css', | |
| 518 | - plugins_url( 'swiper-bundle.css', __FILE__ ), | |
| 546 | + 'jetpack-swiper-library', | |
| 547 | + plugins_url( '_inc/blocks/swiper.css', JETPACK__PLUGIN_FILE ), | |
| 519 | 548 | array(), |
| 520 | - $this->asset_version( JETPACK__VERSION ) | |
| 549 | + JETPACK__VERSION | |
| 521 | 550 | ); |
| 522 | 551 | wp_enqueue_style( 'jetpack-carousel', plugins_url( 'jetpack-carousel.css', __FILE__ ), array(), $this->asset_version( JETPACK__VERSION ) ); |
| 523 | 552 | wp_style_add_data( 'jetpack-carousel', 'rtl', 'replace' ); |
| 524 | 553 | |
| @@ -543,8 +572,24 @@ | ||
| 543 | 572 | } |
| 544 | 573 | } |
| 545 | 574 | |
| 546 | 575 | /** |
| 576 | + * Hint the browser to fetch the Swiper library while it is idle. | |
| 577 | + * | |
| 578 | + * Swiper is only requested when the lightbox is first opened, which puts a network | |
| 579 | + * round trip in front of that first click. This is deliberately `prefetch` rather than | |
| 580 | + * `preload`: most visitors never open the lightbox, so the fetch must stay at low | |
| 581 | + * priority and out of the way of the page's own images. `loadSwiper()` still loads the | |
| 582 | + * library on demand, since a prefetch is a hint the browser is free to ignore. | |
| 583 | + */ | |
| 584 | + public function prefetch_swiper_library() { | |
| 585 | + printf( | |
| 586 | + '<link rel="prefetch" href="%s" as="script" />' . "\n", | |
| 587 | + esc_url( plugins_url( '_inc/blocks/swiper.js', JETPACK__PLUGIN_FILE ) ) | |
| 588 | + ); | |
| 589 | + } | |
| 590 | + | |
| 591 | + /** | |
| 547 | 592 | * Generate the HTML skeleton that will be picked up by the Carousel JS and used for showing the carousel. |
| 548 | 593 | */ |
| 549 | 594 | public function add_carousel_skeleton() { |
| 550 | 595 | $localize_strings = $this->localize_strings; |
| @@ -554,12 +599,13 @@ | ||
| 554 | 599 | $current_user = wp_get_current_user(); |
| 555 | 600 | $require_name_email = (int) get_option( 'require_name_email' ); |
| 556 | 601 | /* translators: %s is replaced with a field name in the form, e.g. "Email" */ |
| 557 | 602 | $required = ( $require_name_email ) ? __( '%s (Required)', 'jetpack' ) : '%s'; |
| 603 | + require_once JETPACK__PLUGIN_DIR . '_inc/lib/class-jetpack-spinner.php'; | |
| 558 | 604 | ?> |
| 559 | - <div id="jp-carousel-loading-overlay"> | |
| 605 | + <div id="jp-carousel-loading-overlay" style="display: none;"> | |
| 560 | 606 | <div id="jp-carousel-loading-wrapper"> |
| 561 | - <span id="jp-carousel-library-loading"> </span> | |
| 607 | + <span id="jp-carousel-library-loading"><?php echo Jetpack_Spinner::render( 40 ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- static SVG markup. ?></span> | |
| 562 | 608 | </div> |
| 563 | 609 | </div> |
| 564 | 610 | <div class="jp-carousel-overlay<?php echo( $is_light ? ' jp-carousel-light' : '' ); ?>" style="display: none;"> |
| 565 | 611 | |
| @@ -565,9 +611,9 @@ | ||
| 565 | 611 | |
| 566 | 612 | <div class="jp-carousel-container<?php echo( $is_light ? ' jp-carousel-light' : '' ); ?>"> |
| 567 | 613 | <!-- The Carousel Swiper --> |
| 568 | 614 | <div |
| 569 | - class="jp-carousel-wrap swiper-container jp-carousel-swiper-container jp-carousel-transitions" | |
| 615 | + class="jp-carousel-wrap swiper jp-carousel-swiper-container jp-carousel-transitions" | |
| 570 | 616 | itemscope |
| 571 | 617 | itemtype="https://schema.org/ImageGallery"> |
| 572 | 618 | <div class="jp-carousel swiper-wrapper"></div> |
| 573 | 619 | <div class="jp-swiper-button-prev swiper-button-prev"> |
| @@ -609,9 +655,9 @@ | ||
| 609 | 655 | <div class="jp-swiper-pagination swiper-pagination"></div> |
| 610 | 656 | <div class="jp-carousel-pagination"></div> |
| 611 | 657 | </div> |
| 612 | 658 | <div class="jp-carousel-photo-title-container"> |
| 613 | - <h2 class="jp-carousel-photo-caption"></h2> | |
| 659 | + <div class="jp-carousel-photo-caption"></div> | |
| 614 | 660 | </div> |
| 615 | 661 | <div class="jp-carousel-photo-icons-container"> |
| 616 | 662 | <a href="#" class="jp-carousel-icon-btn jp-carousel-icon-info" aria-label="<?php esc_attr_e( 'Toggle photo metadata visibility', 'jetpack' ); ?>"> |
| 617 | 663 | <span class="jp-carousel-icon"> |
| @@ -645,9 +691,9 @@ | ||
| 645 | 691 | </div> |
| 646 | 692 | <div class="jp-carousel-info-extra"> |
| 647 | 693 | <div class="jp-carousel-info-content-wrapper"> |
| 648 | 694 | <div class="jp-carousel-photo-title-container"> |
| 649 | - <h2 class="jp-carousel-photo-title"></h2> | |
| 695 | + <div class="jp-carousel-photo-title"></div> | |
| 650 | 696 | </div> |
| 651 | 697 | <div class="jp-carousel-comments-wrapper"> |
| 652 | 698 | <?php if ( $localize_strings['display_comments'] ) : ?> |
| 653 | 699 | <div id="jp-carousel-comments-loading"> |
| @@ -654,9 +700,9 @@ | ||
| 654 | 700 | <span><?php echo esc_html( $localize_strings['loading_comments'] ); ?></span> |
| 655 | 701 | </div> |
| 656 | 702 | <div class="jp-carousel-comments"></div> |
| 657 | 703 | <div id="jp-carousel-comment-form-container"> |
| 658 | - <span id="jp-carousel-comment-form-spinner"> </span> | |
| 704 | + <span id="jp-carousel-comment-form-spinner"><?php echo Jetpack_Spinner::render( 20 ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- static SVG markup. ?></span> | |
| 659 | 705 | <div id="jp-carousel-comment-post-results"></div> |
| 660 | 706 | <?php if ( $use_local_comments ) : ?> |
| 661 | 707 | <?php if ( ! $localize_strings['is_logged_in'] && $localize_strings['comment_registration'] ) : ?> |
| 662 | 708 | <div id="jp-carousel-comment-form-commenting-as"> |
| @@ -725,15 +771,14 @@ | ||
| 725 | 771 | </div> |
| 726 | 772 | <div class="jp-carousel-image-meta"> |
| 727 | 773 | <div class="jp-carousel-title-and-caption"> |
| 728 | 774 | <div class="jp-carousel-photo-info"> |
| 729 | - <h3 class="jp-carousel-caption" itemprop="caption description"></h3> | |
| 775 | + <div class="jp-carousel-caption" itemprop="caption description"></div> | |
| 730 | 776 | </div> |
| 731 | 777 | |
| 732 | 778 | <div class="jp-carousel-photo-description"></div> |
| 733 | 779 | </div> |
| 734 | - <ul class="jp-carousel-image-exif" style="display: none;"></ul> | |
| 735 | - <a class="jp-carousel-image-download" href="#" target="_blank" style="display: none;"> | |
| 780 | + <a class="jp-carousel-image-download" href="#" aria-label="<?php esc_attr_e( 'Download image', 'jetpack' ); ?>" target="_blank" style="display: none;"> | |
| 736 | 781 | <svg width="25" height="24" viewBox="0 0 25 24" fill="none" xmlns="http://www.w3.org/2000/svg"> |
| 737 | 782 | <mask id="mask0" mask-type="alpha" maskUnits="userSpaceOnUse" x="3" y="3" width="19" height="18"> |
| 738 | 783 | <path fill-rule="evenodd" clip-rule="evenodd" d="M5.84615 5V19H19.7775V12H21.7677V19C21.7677 20.1 20.8721 21 19.7775 21H5.84615C4.74159 21 3.85596 20.1 3.85596 19V5C3.85596 3.9 4.74159 3 5.84615 3H12.8118V5H5.84615ZM14.802 5V3H21.7677V10H19.7775V6.41L9.99569 16.24L8.59261 14.83L18.3744 5H14.802Z" fill="white"/> |
| 739 | 784 | </mask> |
| @@ -784,8 +829,11 @@ | ||
| 784 | 829 | * @param string $content HTML content of the post. |
| 785 | 830 | * @return string |
| 786 | 831 | */ |
| 787 | 832 | public function add_data_img_tags_and_enqueue_assets( $content ) { |
| 833 | + if ( ! is_string( $content ) || $content === '' ) { | |
| 834 | + return ''; | |
| 835 | + } | |
| 788 | 836 | if ( |
| 789 | 837 | class_exists( 'Jetpack_AMP_Support' ) |
| 790 | 838 | && Jetpack_AMP_Support::is_amp_request() |
| 791 | 839 | ) { |
| @@ -796,11 +844,19 @@ | ||
| 796 | 844 | return $content; |
| 797 | 845 | } |
| 798 | 846 | $selected_images = array(); |
| 799 | 847 | foreach ( $matches[0] as $image_html ) { |
| 848 | + // This image already carries the attributes this method adds, so adding | |
| 849 | + // them again would emit every one of them twice. Tiled Gallery output | |
| 850 | + // reaches this filter twice: once as 'jetpack_tiled_galleries_block_content' | |
| 851 | + // from inside the block's render callback, and again as 'the_content' when | |
| 852 | + // single image galleries are enabled. See JETPACK-1990. | |
| 853 | + if ( str_contains( $image_html, 'data-attachment-id=' ) ) { | |
| 854 | + continue; | |
| 855 | + } | |
| 800 | 856 | if ( |
| 801 | 857 | preg_match( '/(wp-image-|data-id=)\"?([0-9]+)\"?/i', $image_html, $class_id ) |
| 802 | - && ! preg_match( '/wp-block-jetpack-slideshow_image/', $image_html ) | |
| 858 | + && ! str_contains( $image_html, 'wp-block-jetpack-slideshow_image' ) | |
| 803 | 859 | ) { |
| 804 | 860 | /** |
| 805 | 861 | * Allow filtering the attachment ID used to fetch and populate metadata about an image in a gallery. |
| 806 | 862 | * |
| @@ -852,9 +908,13 @@ | ||
| 852 | 908 | * |
| 853 | 909 | * This is meant as a relatively quick fix, as a better fix is likely to update the get_posts call above to only |
| 854 | 910 | * include attachments. |
| 855 | 911 | */ |
| 856 | - if ( ! isset( $attachment->ID ) || ! wp_attachment_is_image( $attachment->ID ) ) { | |
| 912 | + if ( | |
| 913 | + ! isset( $attachment->ID ) | |
| 914 | + || ! wp_attachment_is_image( $attachment->ID ) | |
| 915 | + || ! isset( $selected_images[ $attachment->ID ] ) | |
| 916 | + ) { | |
| 857 | 917 | continue; |
| 858 | 918 | } |
| 859 | 919 | $image_elements = $selected_images[ $attachment->ID ]; |
| 860 | 920 | |
| @@ -883,10 +943,10 @@ | ||
| 883 | 943 | * |
| 884 | 944 | * @see add_data_img_tags_and_enqueue_assets() |
| 885 | 945 | * @see https://developer.wordpress.org/reference/functions/wp_get_attachment_image/ Documentation about wp_get_attachment_image |
| 886 | 946 | * |
| 887 | - * @param string[] $attr Array of attribute values for the image markup, keyed by attribute name. | |
| 888 | - * @param WP_Post $attachment Image attachment post. | |
| 947 | + * @param string[] $attr Array of attribute values for the image markup, keyed by attribute name. | |
| 948 | + * @param null|WP_Post $attachment Image attachment post. | |
| 889 | 949 | * |
| 890 | 950 | * @return string[] Modified image attributes. |
| 891 | 951 | */ |
| 892 | 952 | public function add_data_to_images( $attr, $attachment = null ) { |
| @@ -896,19 +956,24 @@ | ||
| 896 | 956 | ) { |
| 897 | 957 | return $attr; |
| 898 | 958 | } |
| 899 | 959 | |
| 900 | - $attachment_id = (int) $attachment->ID; | |
| 901 | - if ( ! wp_attachment_is_image( $attachment_id ) ) { | |
| 960 | + if ( | |
| 961 | + ! $attachment instanceof WP_Post | |
| 962 | + || ! isset( $attachment->ID ) | |
| 963 | + || ! wp_attachment_is_image( $attachment ) | |
| 964 | + ) { | |
| 902 | 965 | return $attr; |
| 903 | 966 | } |
| 904 | 967 | |
| 968 | + $attachment_id = (int) $attachment->ID; | |
| 905 | 969 | $orig_file = wp_get_attachment_image_src( $attachment_id, 'full' ); |
| 906 | - $orig_file = isset( $orig_file[0] ) ? $orig_file[0] : wp_get_attachment_url( $attachment_id ); | |
| 970 | + $orig_file = $orig_file[0] ?? wp_get_attachment_url( $attachment_id ); | |
| 907 | 971 | $meta = wp_get_attachment_metadata( $attachment_id ); |
| 908 | 972 | $size = isset( $meta['width'] ) ? (int) $meta['width'] . ',' . (int) $meta['height'] : ''; |
| 909 | 973 | $img_meta = ( ! empty( $meta['image_meta'] ) ) ? (array) $meta['image_meta'] : array(); |
| 910 | 974 | $comments_opened = (int) comments_open( $attachment_id ); |
| 975 | + $display_exif = $this->test_1or0_option( Jetpack_Options::get_option_and_ensure_autoload( 'carousel_display_exif', true ) ); | |
| 911 | 976 | |
| 912 | 977 | /** |
| 913 | 978 | * Note: Cannot generate a filename from the width and height wp_get_attachment_image_src() returns because |
| 914 | 979 | * it takes the $content_width global variable themes can set in consideration, therefore returning sizes |
| @@ -923,39 +988,62 @@ | ||
| 923 | 988 | * EG with Twenty Ten activated: |
| 924 | 989 | * array(4) { [0]=> string(82) "http://vanillawpinstall.blah/wp-content/uploads/2012/06/IMG_3534-1024x764.jpg" [1]=> int(640) [2]=> int(477) [3]=> bool(true) } |
| 925 | 990 | */ |
| 926 | 991 | |
| 927 | - $medium_file_info = wp_get_attachment_image_src( $attachment_id, 'medium' ); | |
| 928 | - $medium_file = isset( $medium_file_info[0] ) ? $medium_file_info[0] : ''; | |
| 929 | - | |
| 930 | 992 | $large_file_info = wp_get_attachment_image_src( $attachment_id, 'large' ); |
| 931 | - $large_file = isset( $large_file_info[0] ) ? $large_file_info[0] : ''; | |
| 993 | + $large_file = $large_file_info[0] ?? ''; | |
| 932 | 994 | |
| 933 | - $attachment = get_post( $attachment_id ); | |
| 934 | - $attachment_title = ! empty( $attachment ) ? wptexturize( $attachment->post_title ) : ''; | |
| 935 | - $attachment_desc = ! empty( $attachment ) ? wpautop( wptexturize( $attachment->post_content ) ) : ''; | |
| 936 | - $attachment_caption = ! empty( $attachment ) ? wpautop( wptexturize( $attachment->post_excerpt ) ) : ''; | |
| 995 | + $attachment_title = wptexturize( $attachment->post_title ); | |
| 996 | + $attachment_desc = wpautop( wptexturize( $attachment->post_content ) ); | |
| 997 | + $attachment_caption = wpautop( wptexturize( $attachment->post_excerpt ) ); | |
| 937 | 998 | |
| 938 | - // See https://github.com/Automattic/jetpack/issues/2765. | |
| 939 | - if ( isset( $img_meta['keywords'] ) ) { | |
| 940 | - unset( $img_meta['keywords'] ); | |
| 941 | - } | |
| 942 | - | |
| 943 | - $img_meta = wp_json_encode( array_map( 'strval', array_filter( $img_meta, 'is_scalar' ) ) ); | |
| 944 | - | |
| 945 | 999 | $attr['data-attachment-id'] = $attachment_id; |
| 946 | 1000 | $attr['data-permalink'] = esc_attr( get_permalink( $attachment_id ) ); |
| 947 | 1001 | $attr['data-orig-file'] = esc_attr( $orig_file ); |
| 948 | 1002 | $attr['data-orig-size'] = $size; |
| 949 | 1003 | $attr['data-comments-opened'] = $comments_opened; |
| 950 | - $attr['data-image-meta'] = esc_attr( $img_meta ); | |
| 1004 | + | |
| 1005 | + /* | |
| 1006 | + Lets the Carousel show its "has comments" badge without fetching the comments | |
| 1007 | + themselves. Omitted when there are none, which is the common case, so galleries | |
| 1008 | + without comments pay nothing for it. | |
| 1009 | + */ | |
| 1010 | + $comments_count = (int) $attachment->comment_count; | |
| 1011 | + if ( $comments_count > 0 ) { | |
| 1012 | + $attr['data-comments-count'] = $comments_count; | |
| 1013 | + } | |
| 1014 | + | |
| 1015 | + if ( $display_exif ) { | |
| 1016 | + // See https://github.com/Automattic/jetpack/issues/2765. | |
| 1017 | + if ( isset( $img_meta['keywords'] ) ) { | |
| 1018 | + unset( $img_meta['keywords'] ); | |
| 1019 | + } | |
| 1020 | + | |
| 1021 | + /* | |
| 1022 | + Filtering on `is_scalar` alone kept every "" and "0" in the metadata array, which | |
| 1023 | + on a typical photo is most of it. The carousel skips those values when it renders | |
| 1024 | + the EXIF panel anyway, so serialising them only inflates the page. Mirror that | |
| 1025 | + check here: drop empties and numeric zeroes, but keep text that merely casts to | |
| 1026 | + zero, such as a camera name. | |
| 1027 | + */ | |
| 1028 | + $img_meta = array_filter( | |
| 1029 | + array_map( 'strval', array_filter( $img_meta, 'is_scalar' ) ), | |
| 1030 | + function ( $value ) { | |
| 1031 | + return '' !== $value && ! ( is_numeric( $value ) && 0.0 === (float) $value ); | |
| 1032 | + } | |
| 1033 | + ); | |
| 1034 | + | |
| 1035 | + // With nothing left to show, the attribute itself is dead weight. | |
| 1036 | + if ( ! empty( $img_meta ) ) { | |
| 1037 | + $attr['data-image-meta'] = esc_attr( wp_json_encode( $img_meta, JSON_UNESCAPED_SLASHES | JSON_HEX_AMP ) ); | |
| 1038 | + } | |
| 1039 | + } | |
| 1040 | + | |
| 951 | 1041 | // The lines below use `esc_attr( htmlspecialchars( ) )` because esc_attr tries to be too smart and won't double-encode, and we need that here. |
| 952 | 1042 | $attr['data-image-title'] = esc_attr( htmlspecialchars( $attachment_title, ENT_COMPAT ) ); |
| 953 | 1043 | $attr['data-image-description'] = esc_attr( htmlspecialchars( $attachment_desc, ENT_COMPAT ) ); |
| 954 | 1044 | $attr['data-image-caption'] = esc_attr( htmlspecialchars( $attachment_caption, ENT_COMPAT ) ); |
| 955 | - $attr['data-medium-file'] = esc_attr( $medium_file ); | |
| 956 | 1045 | $attr['data-large-file'] = esc_attr( $large_file ); |
| 957 | - | |
| 958 | 1046 | return $attr; |
| 959 | 1047 | } |
| 960 | 1048 | |
| 961 | 1049 | /** |
| @@ -994,12 +1082,12 @@ | ||
| 994 | 1082 | * @param array $extra_data Array of data about the site and the post. |
| 995 | 1083 | */ |
| 996 | 1084 | $extra_data = apply_filters( 'jp_carousel_add_data_to_container', $extra_data ); |
| 997 | 1085 | foreach ( (array) $extra_data as $data_key => $data_values ) { |
| 998 | - $html = str_replace( '<div ', '<div ' . esc_attr( $data_key ) . "='" . wp_json_encode( $data_values ) . "' ", $html ); | |
| 999 | - $html = str_replace( '<ul class="wp-block-gallery', '<ul ' . esc_attr( $data_key ) . "='" . wp_json_encode( $data_values ) . "' class=\"wp-block-gallery", $html ); | |
| 1000 | - $html = str_replace( '<ul class="blocks-gallery-grid', '<ul ' . esc_attr( $data_key ) . "='" . wp_json_encode( $data_values ) . "' class=\"blocks-gallery-grid", $html ); | |
| 1001 | - $html = preg_replace( '/\<figure([^>]*)class="(wp-block-gallery[^"]*?has-nested-images.*?)"/', '<figure ' . esc_attr( $data_key ) . "='" . wp_json_encode( $data_values ) . "' $1 class=\"$2\"", $html ); | |
| 1086 | + $html = str_replace( '<div ', '<div ' . esc_attr( $data_key ) . "='" . esc_attr( wp_json_encode( $data_values, JSON_HEX_AMP | JSON_UNESCAPED_SLASHES ) ) . "' ", $html ); | |
| 1087 | + $html = str_replace( '<ul class="wp-block-gallery', '<ul ' . esc_attr( $data_key ) . "='" . esc_attr( wp_json_encode( $data_values, JSON_HEX_AMP | JSON_UNESCAPED_SLASHES ) ) . "' class=\"wp-block-gallery", $html ); | |
| 1088 | + $html = str_replace( '<ul class="blocks-gallery-grid', '<ul ' . esc_attr( $data_key ) . "='" . esc_attr( wp_json_encode( $data_values, JSON_HEX_AMP | JSON_UNESCAPED_SLASHES ) ) . "' class=\"blocks-gallery-grid", $html ); | |
| 1089 | + $html = preg_replace( '/\<figure([^>]*)class="(wp-block-gallery[^"]*?has-nested-images.*?)"/', '<figure ' . esc_attr( $data_key ) . "='" . esc_attr( wp_json_encode( $data_values, JSON_HEX_AMP | JSON_UNESCAPED_SLASHES ) ) . "' $1 class=\"$2\"", $html ); | |
| 1002 | 1090 | } |
| 1003 | 1091 | } |
| 1004 | 1092 | |
| 1005 | 1093 | return $html; |
| @@ -1044,9 +1132,9 @@ | ||
| 1044 | 1132 | |
| 1045 | 1133 | /** |
| 1046 | 1134 | * Retrieves comment information |
| 1047 | 1135 | * |
| 1048 | - * @return string | |
| 1136 | + * @return never | |
| 1049 | 1137 | */ |
| 1050 | 1138 | public function get_attachment_comments() { |
| 1051 | 1139 | if ( ! headers_sent() ) { |
| 1052 | 1140 | header( 'Content-type: text/javascript' ); |
| @@ -1070,11 +1158,11 @@ | ||
| 1070 | 1158 | |
| 1071 | 1159 | if ( ! $attachment_id ) { |
| 1072 | 1160 | wp_send_json_error( |
| 1073 | 1161 | __( 'Missing attachment ID.', 'jetpack' ), |
| 1074 | - 403 | |
| 1162 | + 403, | |
| 1163 | + JSON_UNESCAPED_SLASHES | |
| 1075 | 1164 | ); |
| 1076 | - return; | |
| 1077 | 1165 | } |
| 1078 | 1166 | |
| 1079 | 1167 | $attachment_post = get_post( $attachment_id ); |
| 1080 | 1168 | // If we have no info about that attachment, bail. |
| @@ -1080,11 +1168,11 @@ | ||
| 1080 | 1168 | // If we have no info about that attachment, bail. |
| 1081 | 1169 | if ( ! ( $attachment_post instanceof WP_Post ) ) { |
| 1082 | 1170 | wp_send_json_error( |
| 1083 | 1171 | __( 'Missing attachment info.', 'jetpack' ), |
| 1084 | - 403 | |
| 1172 | + 403, | |
| 1173 | + JSON_UNESCAPED_SLASHES | |
| 1085 | 1174 | ); |
| 1086 | - return; | |
| 1087 | 1175 | } |
| 1088 | 1176 | |
| 1089 | 1177 | // This AJAX call should only be used to fetch comments of attachments. |
| 1090 | 1178 | if ( 'attachment' !== $attachment_post->post_type ) { |
| @@ -1089,11 +1177,11 @@ | ||
| 1089 | 1177 | // This AJAX call should only be used to fetch comments of attachments. |
| 1090 | 1178 | if ( 'attachment' !== $attachment_post->post_type ) { |
| 1091 | 1179 | wp_send_json_error( |
| 1092 | 1180 | __( 'You aren’t authorized to do that.', 'jetpack' ), |
| 1093 | - 403 | |
| 1181 | + 403, | |
| 1182 | + JSON_UNESCAPED_SLASHES | |
| 1094 | 1183 | ); |
| 1095 | - return; | |
| 1096 | 1184 | } |
| 1097 | 1185 | |
| 1098 | 1186 | $parent_post = get_post_parent( $attachment_id ); |
| 1099 | 1187 | |
| @@ -1111,11 +1199,11 @@ | ||
| 1111 | 1199 | $current_user = wp_get_current_user(); |
| 1112 | 1200 | if ( ! ( $current_user instanceof WP_User ) ) { |
| 1113 | 1201 | wp_send_json_error( |
| 1114 | 1202 | __( 'Missing user info.', 'jetpack' ), |
| 1115 | - 403 | |
| 1203 | + 403, | |
| 1204 | + JSON_UNESCAPED_SLASHES | |
| 1116 | 1205 | ); |
| 1117 | - return; | |
| 1118 | 1206 | } |
| 1119 | 1207 | |
| 1120 | 1208 | /* |
| 1121 | 1209 | * If a post is private / draft |
| @@ -1127,11 +1215,11 @@ | ||
| 1127 | 1215 | && ! current_user_can( 'read_post', $parent_post->ID ) |
| 1128 | 1216 | ) { |
| 1129 | 1217 | wp_send_json_error( |
| 1130 | 1218 | __( 'You aren’t authorized to do that.', 'jetpack' ), |
| 1131 | - 403 | |
| 1219 | + 403, | |
| 1220 | + JSON_UNESCAPED_SLASHES | |
| 1132 | 1221 | ); |
| 1133 | - return; | |
| 1134 | 1222 | } |
| 1135 | 1223 | } |
| 1136 | 1224 | |
| 1137 | 1225 | if ( $offset < 1 ) { |
| @@ -1165,13 +1253,15 @@ | ||
| 1165 | 1253 | 'content' => wpautop( $comment->comment_content ), |
| 1166 | 1254 | ); |
| 1167 | 1255 | } |
| 1168 | 1256 | |
| 1169 | - die( wp_json_encode( $out ) ); | |
| 1257 | + wp_send_json( $out, null, JSON_UNESCAPED_SLASHES ); | |
| 1170 | 1258 | } |
| 1171 | 1259 | |
| 1172 | 1260 | /** |
| 1173 | 1261 | * Adds a new comment to the database |
| 1262 | + * | |
| 1263 | + * @return never | |
| 1174 | 1264 | */ |
| 1175 | 1265 | public function post_attachment_comment() { |
| 1176 | 1266 | if ( ! headers_sent() ) { |
| 1177 | 1267 | header( 'Content-type: text/javascript' ); |
| @@ -1177,9 +1267,9 @@ | ||
| 1177 | 1267 | header( 'Content-type: text/javascript' ); |
| 1178 | 1268 | } |
| 1179 | 1269 | |
| 1180 | 1270 | if ( empty( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'carousel_nonce' ) ) { // phpcs:ignore WordPress.Security.ValidatedSanitizedInput -- WP Core doesn't unslash or sanitize nonces either |
| 1181 | - die( wp_json_encode( array( 'error' => __( 'Nonce verification failed.', 'jetpack' ) ) ) ); | |
| 1271 | + die( wp_json_encode( array( 'error' => __( 'Nonce verification failed.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1182 | 1272 | } |
| 1183 | 1273 | |
| 1184 | 1274 | $_blog_id = isset( $_POST['blog_id'] ) ? (int) $_POST['blog_id'] : 0; |
| 1185 | 1275 | $_post_id = isset( $_POST['id'] ) ? (int) $_POST['id'] : 0; |
| @@ -1185,17 +1275,17 @@ | ||
| 1185 | 1275 | $_post_id = isset( $_POST['id'] ) ? (int) $_POST['id'] : 0; |
| 1186 | 1276 | $comment = isset( $_POST['comment'] ) ? filter_var( wp_unslash( $_POST['comment'] ) ) : null; |
| 1187 | 1277 | |
| 1188 | 1278 | if ( empty( $_blog_id ) ) { |
| 1189 | - die( wp_json_encode( array( 'error' => __( 'Missing target blog ID.', 'jetpack' ) ) ) ); | |
| 1279 | + die( wp_json_encode( array( 'error' => __( 'Missing target blog ID.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1190 | 1280 | } |
| 1191 | 1281 | |
| 1192 | 1282 | if ( empty( $_post_id ) ) { |
| 1193 | - die( wp_json_encode( array( 'error' => __( 'Missing target post ID.', 'jetpack' ) ) ) ); | |
| 1283 | + die( wp_json_encode( array( 'error' => __( 'Missing target post ID.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1194 | 1284 | } |
| 1195 | 1285 | |
| 1196 | 1286 | if ( empty( $comment ) ) { |
| 1197 | - die( wp_json_encode( array( 'error' => __( 'No comment text was submitted.', 'jetpack' ) ) ) ); | |
| 1287 | + die( wp_json_encode( array( 'error' => __( 'No comment text was submitted.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1198 | 1288 | } |
| 1199 | 1289 | |
| 1200 | 1290 | // Used in context like NewDash. |
| 1201 | 1291 | $switched = false; |
| @@ -1210,9 +1300,9 @@ | ||
| 1210 | 1300 | if ( ! comments_open( $_post_id ) ) { |
| 1211 | 1301 | if ( $switched ) { |
| 1212 | 1302 | restore_current_blog(); |
| 1213 | 1303 | } |
| 1214 | - die( wp_json_encode( array( 'error' => __( 'Comments on this post are closed.', 'jetpack' ) ) ) ); | |
| 1304 | + die( wp_json_encode( array( 'error' => __( 'Comments on this post are closed.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1215 | 1305 | } |
| 1216 | 1306 | |
| 1217 | 1307 | if ( is_user_logged_in() ) { |
| 1218 | 1308 | $user = wp_get_current_user(); |
| @@ -1224,15 +1314,18 @@ | ||
| 1224 | 1314 | if ( empty( $user_id ) ) { |
| 1225 | 1315 | if ( $switched ) { |
| 1226 | 1316 | restore_current_blog(); |
| 1227 | 1317 | } |
| 1228 | - die( wp_json_encode( array( 'error' => __( 'Sorry, but we could not authenticate your request.', 'jetpack' ) ) ) ); | |
| 1318 | + die( wp_json_encode( array( 'error' => __( 'Sorry, but we could not authenticate your request.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1229 | 1319 | } |
| 1230 | 1320 | } else { |
| 1231 | 1321 | $user_id = 0; |
| 1232 | 1322 | $display_name = isset( $_POST['author'] ) ? sanitize_text_field( wp_unslash( $_POST['author'] ) ) : null; |
| 1233 | - $email = isset( $_POST['email'] ) ? wp_unslash( $_POST['email'] ) : null; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Checked or sanitized below. | |
| 1234 | - $url = isset( $_POST['url'] ) ? esc_url_raw( wp_unslash( $_POST['url'] ) ) : null; | |
| 1323 | + $email = null; | |
| 1324 | + if ( isset( $_POST['email'] ) && is_string( $_POST['email'] ) ) { | |
| 1325 | + $email = wp_unslash( $_POST['email'] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Checked or sanitized below. | |
| 1326 | + } | |
| 1327 | + $url = isset( $_POST['url'] ) && is_string( $_POST['url'] ) ? esc_url_raw( wp_unslash( $_POST['url'] ) ) : null; | |
| 1235 | 1328 | |
| 1236 | 1329 | if ( get_option( 'require_name_email' ) ) { |
| 1237 | 1330 | if ( empty( $display_name ) ) { |
| 1238 | 1331 | if ( $switched ) { |
| @@ -1237,9 +1330,9 @@ | ||
| 1237 | 1330 | if ( empty( $display_name ) ) { |
| 1238 | 1331 | if ( $switched ) { |
| 1239 | 1332 | restore_current_blog(); |
| 1240 | 1333 | } |
| 1241 | - die( wp_json_encode( array( 'error' => __( 'Please provide your name.', 'jetpack' ) ) ) ); | |
| 1334 | + die( wp_json_encode( array( 'error' => __( 'Please provide your name.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1242 | 1335 | } |
| 1243 | 1336 | |
| 1244 | 1337 | if ( empty( $email ) ) { |
| 1245 | 1338 | if ( $switched ) { |
| @@ -1244,9 +1337,9 @@ | ||
| 1244 | 1337 | if ( empty( $email ) ) { |
| 1245 | 1338 | if ( $switched ) { |
| 1246 | 1339 | restore_current_blog(); |
| 1247 | 1340 | } |
| 1248 | - die( wp_json_encode( array( 'error' => __( 'Please provide an email address.', 'jetpack' ) ) ) ); | |
| 1341 | + die( wp_json_encode( array( 'error' => __( 'Please provide an email address.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1249 | 1342 | } |
| 1250 | 1343 | |
| 1251 | 1344 | if ( ! is_email( $email ) ) { |
| 1252 | 1345 | if ( $switched ) { |
| @@ -1251,9 +1344,9 @@ | ||
| 1251 | 1344 | if ( ! is_email( $email ) ) { |
| 1252 | 1345 | if ( $switched ) { |
| 1253 | 1346 | restore_current_blog(); |
| 1254 | 1347 | } |
| 1255 | - die( wp_json_encode( array( 'error' => __( 'Please provide a valid email address.', 'jetpack' ) ) ) ); | |
| 1348 | + die( wp_json_encode( array( 'error' => __( 'Please provide a valid email address.', 'jetpack' ) ), JSON_UNESCAPED_SLASHES ) ); | |
| 1256 | 1349 | } |
| 1257 | 1350 | } else { |
| 1258 | 1351 | $email = $email !== null ? sanitize_email( $email ) : null; |
| 1259 | 1352 | } |
| @@ -1294,9 +1387,10 @@ | ||
| 1294 | 1387 | wp_json_encode( |
| 1295 | 1388 | array( |
| 1296 | 1389 | 'comment_id' => $comment_id, |
| 1297 | 1390 | 'comment_status' => $comment_status, |
| 1298 | - ) | |
| 1391 | + ), | |
| 1392 | + JSON_UNESCAPED_SLASHES | |
| 1299 | 1393 | ) |
| 1300 | 1394 | ); |
| 1301 | 1395 | } |
| 1302 | 1396 | |
| @@ -1424,9 +1518,9 @@ | ||
| 1424 | 1518 | * Sanitize input for the `carousel_display_exif` setting. |
| 1425 | 1519 | * |
| 1426 | 1520 | * @param mixed $value User input setting value. |
| 1427 | 1521 | * |
| 1428 | - * @return number Sanitized value, only 1 or 0. | |
| 1522 | + * @return int Sanitized value, only 1 or 0. | |
| 1429 | 1523 | */ |
| 1430 | 1524 | public function carousel_display_exif_sanitize( $value ) { |
| 1431 | 1525 | return $this->sanitize_1or0_option( $value ); |
| 1432 | 1526 | } |
| @@ -1433,11 +1527,11 @@ | ||
| 1433 | 1527 | |
| 1434 | 1528 | /** |
| 1435 | 1529 | * Return sanitized option for value that controls whether comments will be hidden or not. |
| 1436 | 1530 | * |
| 1437 | - * @param number $value Value to sanitize. | |
| 1531 | + * @param mixed $value Value to sanitize. | |
| 1438 | 1532 | * |
| 1439 | - * @return number Sanitized value, only 1 or 0. | |
| 1533 | + * @return int Sanitized value, only 1 or 0. | |
| 1440 | 1534 | */ |
| 1441 | 1535 | public function carousel_display_comments_sanitize( $value ) { |
| 1442 | 1536 | return $this->sanitize_1or0_option( $value ); |
| 1443 | 1537 | } |
| @@ -1477,9 +1571,9 @@ | ||
| 1477 | 1571 | * Sanitize input for the `carousel_enable_it` setting. |
| 1478 | 1572 | * |
| 1479 | 1573 | * @param mixed $value User input. |
| 1480 | 1574 | * |
| 1481 | - * @return number Sanitized value, only 1 or 0. | |
| 1575 | + * @return int Sanitized value, only 1 or 0. | |
| 1482 | 1576 | */ |
| 1483 | 1577 | public function carousel_enable_it_sanitize( $value ) { |
| 1484 | 1578 | return $this->sanitize_1or0_option( $value ); |
| 1485 | 1579 | } |
