| @@ -8,8 +8,12 @@ | ||
| 8 | 8 | require __DIR__ . '/base.php'; |
| 9 | 9 | use Automattic\Jetpack\Connection\Tokens; |
| 10 | 10 | use Automattic\Jetpack\Status\Host; |
| 11 | 11 | |
| 12 | +if ( ! defined( 'ABSPATH' ) ) { | |
| 13 | + exit( 0 ); | |
| 14 | +} | |
| 15 | + | |
| 12 | 16 | /** |
| 13 | 17 | * Main Comments class |
| 14 | 18 | * |
| 15 | 19 | * @package automattic/jetpack |
| @@ -84,9 +88,9 @@ | ||
| 84 | 88 | */ |
| 85 | 89 | public function set_default_color_theme_based_on_theme_settings() { |
| 86 | 90 | if ( function_exists( 'twentyeleven_get_theme_options' ) ) { |
| 87 | 91 | $theme_options = twentyeleven_get_theme_options(); |
| 88 | - $theme_color_scheme = isset( $theme_options['color_scheme'] ) ? $theme_options['color_scheme'] : 'transparent'; | |
| 92 | + $theme_color_scheme = $theme_options['color_scheme'] ?? 'transparent'; | |
| 89 | 93 | } else { |
| 90 | 94 | $theme_color_scheme = get_theme_mod( 'color_scheme', 'transparent' ); |
| 91 | 95 | } |
| 92 | 96 | // Default for $theme_color_scheme is 'transparent' just so it doesn't match 'light' or 'dark'. |
| @@ -120,13 +124,30 @@ | ||
| 120 | 124 | ); |
| 121 | 125 | } |
| 122 | 126 | |
| 123 | 127 | /** |
| 128 | + * Whether the rebuilt Jetpack Comments form has taken over from this one. | |
| 129 | + * | |
| 130 | + * Guarded because this file and the jetpack-comments package can land in | |
| 131 | + * either order on a staged deploy. | |
| 132 | + * | |
| 133 | + * @return bool | |
| 134 | + */ | |
| 135 | + private static function new_comments_enabled() { | |
| 136 | + return class_exists( '\Automattic\Jetpack\Comments\Comments' ) | |
| 137 | + && \Automattic\Jetpack\Comments\Comments::is_enabled(); | |
| 138 | + } | |
| 139 | + | |
| 140 | + /** | |
| 124 | 141 | * Setup actions for methods in this class |
| 125 | 142 | * |
| 126 | 143 | * @since 1.4 |
| 127 | 144 | */ |
| 128 | 145 | protected function setup_actions() { |
| 146 | + if ( self::new_comments_enabled() ) { | |
| 147 | + return; | |
| 148 | + } | |
| 149 | + | |
| 129 | 150 | parent::setup_actions(); |
| 130 | 151 | |
| 131 | 152 | // Selfishly remove everything from the existing comment form. |
| 132 | 153 | remove_all_actions( 'comment_form_before' ); |
| @@ -131,8 +152,9 @@ | ||
| 131 | 152 | // Selfishly remove everything from the existing comment form. |
| 132 | 153 | remove_all_actions( 'comment_form_before' ); |
| 133 | 154 | |
| 134 | 155 | // Selfishly add only our actions back to the comment form. |
| 156 | + add_action( 'comment_form_before', array( $this, 'manage_post_cookie' ) ); | |
| 135 | 157 | add_action( 'comment_form_before', array( $this, 'comment_form_before' ) ); |
| 136 | 158 | add_action( 'comment_form_after', array( $this, 'comment_form_after' ), 1 ); // Set very early since we remove everything outputed before our action. |
| 137 | 159 | |
| 138 | 160 | // Before a comment is posted. |
| @@ -147,8 +169,12 @@ | ||
| 147 | 169 | * |
| 148 | 170 | * @since 1.6.2 |
| 149 | 171 | */ |
| 150 | 172 | protected function setup_filters() { |
| 173 | + if ( self::new_comments_enabled() ) { | |
| 174 | + return; | |
| 175 | + } | |
| 176 | + | |
| 151 | 177 | parent::setup_filters(); |
| 152 | 178 | |
| 153 | 179 | add_filter( 'comment_post_redirect', array( $this, 'capture_comment_post_redirect_to_reload_parent_frame' ), 100 ); |
| 154 | 180 | add_filter( 'comment_duplicate_trigger', array( $this, 'capture_comment_duplicate_trigger' ), 100 ); |
| @@ -157,8 +183,55 @@ | ||
| 157 | 183 | add_filter( 'comment_reply_link', array( $this, 'comment_reply_link' ), 10, 4 ); |
| 158 | 184 | } |
| 159 | 185 | |
| 160 | 186 | /** |
| 187 | + * In order for comments to work properly for password-protected posts we need to set `wp-postpass` cookie to SameSite none. | |
| 188 | + */ | |
| 189 | + public function manage_post_cookie() { | |
| 190 | + if ( headers_sent() ) { | |
| 191 | + return; | |
| 192 | + } | |
| 193 | + | |
| 194 | + $postpass_cookie_key = 'wp-postpass_' . COOKIEHASH; | |
| 195 | + | |
| 196 | + if ( empty( $_COOKIE[ $postpass_cookie_key ] ) ) { | |
| 197 | + return; | |
| 198 | + } | |
| 199 | + | |
| 200 | + $postpass_cookie_value = sanitize_text_field( wp_unslash( $_COOKIE[ $postpass_cookie_key ] ) ); | |
| 201 | + | |
| 202 | + if ( empty( $_COOKIE['verbum-wp-postpass'] ) || ( $_COOKIE['verbum-wp-postpass'] !== $postpass_cookie_value ) ) { | |
| 203 | + $expire = apply_filters( 'post_password_expires', time() + 10 * DAY_IN_SECONDS ); | |
| 204 | + | |
| 205 | + setcookie( | |
| 206 | + $postpass_cookie_key, | |
| 207 | + $postpass_cookie_value, | |
| 208 | + array( | |
| 209 | + 'expires' => $expire, | |
| 210 | + 'samesite' => 'None', | |
| 211 | + 'path' => '/', | |
| 212 | + 'domain' => COOKIE_DOMAIN, | |
| 213 | + 'secure' => is_ssl(), | |
| 214 | + 'httponly' => false, // phpcs:ignore Jetpack.Functions.SetCookie.FoundNonHTTPOnlyFalse -- @todo Can this be set true? | |
| 215 | + ) | |
| 216 | + ); | |
| 217 | + | |
| 218 | + setcookie( | |
| 219 | + 'verbum-wp-postpass', | |
| 220 | + $postpass_cookie_value, | |
| 221 | + array( | |
| 222 | + 'expires' => $expire, | |
| 223 | + 'samesite' => 'None', | |
| 224 | + 'path' => '/', | |
| 225 | + 'domain' => COOKIE_DOMAIN, | |
| 226 | + 'secure' => is_ssl(), | |
| 227 | + 'httponly' => false, // phpcs:ignore Jetpack.Functions.SetCookie.FoundNonHTTPOnlyFalse -- @todo Can this be set true? | |
| 228 | + ) | |
| 229 | + ); | |
| 230 | + } | |
| 231 | + } | |
| 232 | + | |
| 233 | + /** | |
| 161 | 234 | * Get the comment avatar from Gravatar or Twitter/Facebook. |
| 162 | 235 | * |
| 163 | 236 | * Leaving the Twitter reference for legacy comments even though support is no longer offered. |
| 164 | 237 | * |
| @@ -183,10 +256,18 @@ | ||
| 183 | 256 | ! preg_match( '/\.?(graph\.facebook\.com|twimg\.com)$/', $foreign_avatar_hostname ) ) { |
| 184 | 257 | return $avatar; |
| 185 | 258 | } |
| 186 | 259 | |
| 187 | - // Return the Facebook or Twitter avatar. | |
| 188 | - return preg_replace( '#src=([\'"])[^\'"]+\\1#', 'src=\\1' . esc_url( set_url_scheme( $this->photon_avatar( $foreign_avatar, $size ), 'https' ) ) . '\\1', $avatar ); | |
| 260 | + // Insert the escaped URL through a callback: a preg_replace() replacement string would expand a | |
| 261 | + // `$1` inside it into the captured quote, breaking out of the src attribute (stored-XSS vector). | |
| 262 | + $photon_url = esc_url( set_url_scheme( $this->photon_avatar( $foreign_avatar, $size ), 'https' ) ); | |
| 263 | + return preg_replace_callback( | |
| 264 | + '#src=([\'"])[^\'"]+\\1#', | |
| 265 | + static function ( $matches ) use ( $photon_url ) { | |
| 266 | + return 'src=' . $matches[1] . $photon_url . $matches[1]; | |
| 267 | + }, | |
| 268 | + $avatar | |
| 269 | + ); | |
| 189 | 270 | } |
| 190 | 271 | |
| 191 | 272 | /** |
| 192 | 273 | * Set comment reply link. |
| @@ -351,8 +432,9 @@ | ||
| 351 | 432 | ), |
| 352 | 433 | 'color_scheme' => get_option( 'jetpack_comment_form_color_scheme', $this->default_color_scheme ), |
| 353 | 434 | 'lang' => get_locale(), |
| 354 | 435 | 'jetpack_version' => JETPACK__VERSION, |
| 436 | + 'iframe_unique_id' => wp_unique_id(), | |
| 355 | 437 | ); |
| 356 | 438 | |
| 357 | 439 | // Extra parameters for logged in user. |
| 358 | 440 | if ( is_user_logged_in() ) { |
| @@ -368,9 +450,9 @@ | ||
| 368 | 450 | } else { |
| 369 | 451 | $commenter = wp_get_current_commenter(); |
| 370 | 452 | $params['show_cookie_consent'] = (int) has_action( 'set_comment_cookies', 'wp_set_comment_cookies' ); |
| 371 | 453 | $params['has_cookie_consent'] = (int) ! empty( $commenter['comment_author_email'] ); |
| 372 | - // Jetpack_Memberships for logged out users only checks for the jp-premium-content-session cookie | |
| 454 | + // Jetpack_Memberships for logged out users only checks for the wp-jp-premium-content-session cookie | |
| 373 | 455 | $params['is_current_user_subscribed'] = class_exists( '\Jetpack_Memberships' ) ? (int) Jetpack_Memberships::is_current_user_subscribed() : 0; |
| 374 | 456 | } |
| 375 | 457 | |
| 376 | 458 | list( $token_key ) = explode( '.', $blog_token->secret, 2 ); |
| @@ -513,52 +595,72 @@ | ||
| 513 | 595 | return; |
| 514 | 596 | } |
| 515 | 597 | ?> |
| 516 | 598 | <script type="text/javascript"> |
| 517 | - const iframe = document.getElementById( 'jetpack_remote_comment' ); | |
| 518 | - <?php if ( get_option( 'thread_comments' ) && get_option( 'thread_comments_depth' ) ) : ?> | |
| 519 | - const watchReply = function() { | |
| 520 | - // Check addComment._Jetpack_moveForm to make sure we don't monkey-patch twice. | |
| 521 | - if ( 'undefined' !== typeof addComment && ! addComment._Jetpack_moveForm ) { | |
| 522 | - // Cache the Core function. | |
| 523 | - addComment._Jetpack_moveForm = addComment.moveForm; | |
| 524 | - const commentParent = document.getElementById( 'comment_parent' ); | |
| 525 | - const cancel = document.getElementById( 'cancel-comment-reply-link' ); | |
| 599 | + (function () { | |
| 600 | + const iframe = document.getElementById( 'jetpack_remote_comment' ); | |
| 601 | + <?php if ( get_option( 'thread_comments' ) && get_option( 'thread_comments_depth' ) ) : ?> | |
| 602 | + const watchReply = function() { | |
| 603 | + // Check addComment._Jetpack_moveForm to make sure we don't monkey-patch twice. | |
| 604 | + if ( 'undefined' !== typeof addComment && ! addComment._Jetpack_moveForm ) { | |
| 605 | + // Cache the Core function. | |
| 606 | + addComment._Jetpack_moveForm = addComment.moveForm; | |
| 607 | + const commentParent = document.getElementById( 'comment_parent' ); | |
| 608 | + const cancel = document.getElementById( 'cancel-comment-reply-link' ); | |
| 526 | 609 | |
| 527 | - function tellFrameNewParent ( commentParentValue ) { | |
| 528 | - const url = new URL( iframe.src ); | |
| 529 | - if ( commentParentValue ) { | |
| 530 | - url.searchParams.set( 'replytocom', commentParentValue ) | |
| 531 | - } else { | |
| 532 | - url.searchParams.delete( 'replytocom' ); | |
| 533 | - } | |
| 534 | - if( iframe.src !== url.href ) { | |
| 535 | - iframe.src = url.href; | |
| 536 | - } | |
| 537 | - }; | |
| 610 | + function tellFrameNewParent ( commentParentValue ) { | |
| 611 | + const url = new URL( iframe.src ); | |
| 612 | + if ( commentParentValue ) { | |
| 613 | + url.searchParams.set( 'replytocom', commentParentValue ) | |
| 614 | + } else { | |
| 615 | + url.searchParams.delete( 'replytocom' ); | |
| 616 | + } | |
| 617 | + if( iframe.src !== url.href ) { | |
| 618 | + iframe.src = url.href; | |
| 619 | + } | |
| 620 | + }; | |
| 538 | 621 | |
| 539 | - cancel.addEventListener( 'click', function () { | |
| 540 | - tellFrameNewParent( false ); | |
| 541 | - } ); | |
| 622 | + cancel.addEventListener( 'click', function () { | |
| 623 | + tellFrameNewParent( false ); | |
| 624 | + } ); | |
| 542 | 625 | |
| 543 | - addComment.moveForm = function ( _, parentId ) { | |
| 544 | - tellFrameNewParent( parentId ); | |
| 545 | - return addComment._Jetpack_moveForm.apply( null, arguments ); | |
| 546 | - }; | |
| 626 | + addComment.moveForm = function ( _, parentId ) { | |
| 627 | + tellFrameNewParent( parentId ); | |
| 628 | + return addComment._Jetpack_moveForm.apply( null, arguments ); | |
| 629 | + }; | |
| 630 | + } | |
| 547 | 631 | } |
| 548 | - } | |
| 549 | - document.addEventListener( 'DOMContentLoaded', watchReply ); | |
| 550 | - // In WP 6.4+, the script is loaded asynchronously, so we need to wait for it to load before we monkey-patch the functions it introduces. | |
| 551 | - document.querySelector('#comment-reply-js')?.addEventListener( 'load', watchReply ); | |
| 632 | + document.addEventListener( 'DOMContentLoaded', watchReply ); | |
| 633 | + // In WP 6.4+, the script is loaded asynchronously, so we need to wait for it to load before we monkey-patch the functions it introduces. | |
| 634 | + document.querySelector('#comment-reply-js')?.addEventListener( 'load', watchReply ); | |
| 552 | 635 | |
| 553 | - <?php endif; ?> | |
| 636 | + <?php endif; ?> | |
| 637 | + | |
| 638 | + const commentIframes = document.getElementsByClassName('jetpack_remote_comment'); | |
| 554 | 639 | |
| 555 | - window.addEventListener( 'message', function ( event ) { | |
| 556 | - if ( event.origin !== 'https://jetpack.wordpress.com' ) { | |
| 557 | - return; | |
| 558 | - } | |
| 559 | - iframe.style.height = event.data + 'px'; | |
| 560 | - }); | |
| 640 | + window.addEventListener('message', function(event) { | |
| 641 | + if (event.origin !== 'https://jetpack.wordpress.com') { | |
| 642 | + return; | |
| 643 | + } | |
| 644 | + | |
| 645 | + if (!event?.data?.iframeUniqueId && !event?.data?.height) { | |
| 646 | + return; | |
| 647 | + } | |
| 648 | + | |
| 649 | + const eventDataUniqueId = event.data.iframeUniqueId; | |
| 650 | + | |
| 651 | + // Change height for the matching comment iframe | |
| 652 | + for (let i = 0; i < commentIframes.length; i++) { | |
| 653 | + const iframe = commentIframes[i]; | |
| 654 | + const url = new URL(iframe.src); | |
| 655 | + const iframeUniqueIdParam = url.searchParams.get('iframe_unique_id'); | |
| 656 | + if (iframeUniqueIdParam == event.data.iframeUniqueId) { | |
| 657 | + iframe.style.height = event.data.height + 'px'; | |
| 658 | + return; | |
| 659 | + } | |
| 660 | + } | |
| 661 | + }); | |
| 662 | + })(); | |
| 561 | 663 | </script> |
| 562 | 664 | <?php |
| 563 | 665 | } |
| 564 | 666 | |
| @@ -573,19 +675,21 @@ | ||
| 573 | 675 | public function pre_comment_on_post() { |
| 574 | 676 | $post_array = stripslashes_deep( $_POST ); |
| 575 | 677 | |
| 576 | 678 | // Bail if missing the Jetpack token. |
| 577 | - if ( ! isset( $post_array['sig'] ) || ! isset( $post_array['token_key'] ) ) { | |
| 679 | + if ( ! isset( $post_array['sig'] ) || ! isset( $post_array['token_key'] ) || ! is_string( $post_array['sig'] ) || ! is_string( $post_array['token_key'] ) ) { | |
| 578 | 680 | unset( $_POST['hc_post_as'] ); |
| 579 | - | |
| 580 | 681 | return; |
| 581 | 682 | } |
| 582 | 683 | |
| 583 | 684 | if ( empty( $post_array['jetpack_comments_nonce'] ) || ! wp_verify_nonce( $post_array['jetpack_comments_nonce'], "jetpack_comments_nonce-{$post_array['comment_post_ID']}" ) ) { |
| 584 | - wp_die( esc_html__( 'Nonce verification failed.', 'jetpack' ), 400 ); | |
| 685 | + if ( ! isset( $_GET['only_once'] ) ) { | |
| 686 | + self::retry_submit_comment_form_locally(); | |
| 687 | + } | |
| 688 | + wp_die( esc_html__( 'Nonce verification failed.', 'jetpack' ), 400 ); | |
| 585 | 689 | } |
| 586 | 690 | |
| 587 | - if ( str_contains( $post_array['hc_avatar'], '.gravatar.com' ) ) { | |
| 691 | + if ( isset( $post_array['hc_avatar'] ) && is_string( $post_array['hc_avatar'] ) && str_contains( $post_array['hc_avatar'], '.gravatar.com' ) ) { | |
| 588 | 692 | $post_array['hc_avatar'] = htmlentities( $post_array['hc_avatar'], ENT_COMPAT ); |
| 589 | 693 | } |
| 590 | 694 | |
| 591 | 695 | $blog_token = ( new Tokens() )->get_access_token( false, $post_array['token_key'] ); |
| @@ -610,8 +714,67 @@ | ||
| 610 | 714 | wp_die( esc_html__( 'Comments are not allowed.', 'jetpack' ), 403 ); |
| 611 | 715 | } |
| 612 | 716 | } |
| 613 | 717 | |
| 718 | + /** | |
| 719 | + * Handle Jetpack Comments POST requests: process the comment form, then client-side POST the results to the self-hosted blog | |
| 720 | + * | |
| 721 | + * This function exists because when we submit the form via the jetpack.wordpress.com iframe | |
| 722 | + * in Chrome the request comes in to Jetpack but for some reason the request doesn't have access to cookies yet. | |
| 723 | + * By submitting the form again locally with the same data the process works as expected. | |
| 724 | + * | |
| 725 | + * @return never | |
| 726 | + */ | |
| 727 | + public function retry_submit_comment_form_locally() { | |
| 728 | + // We are not doing any validation here since all the validation will be done again by pre_comment_on_post(). | |
| 729 | + // phpcs:ignore WordPress.Security.NonceVerification.Missing | |
| 730 | + $comment_data = stripslashes_deep( $_POST ); | |
| 731 | + ?> | |
| 732 | + <!DOCTYPE html> | |
| 733 | + <html> | |
| 734 | + <head> | |
| 735 | + <meta charset="utf-8"> | |
| 736 | + <title><?php echo esc_html__( 'Submitting Comment', 'jetpack' ); ?></title> | |
| 737 | + <style type="text/css"> | |
| 738 | + body { | |
| 739 | + display: table; | |
| 740 | + width: 100%; | |
| 741 | + height: 60%; | |
| 742 | + position: absolute; | |
| 743 | + top: 0; | |
| 744 | + left: 0; | |
| 745 | + overflow: hidden; | |
| 746 | + color: #333; | |
| 747 | + } | |
| 748 | + .jetpack-comment-spinner { | |
| 749 | + display: table-cell; | |
| 750 | + vertical-align: middle; | |
| 751 | + text-align: center; | |
| 752 | + } | |
| 753 | + </style> | |
| 754 | + </head> | |
| 755 | + <body> | |
| 756 | + <div class="jetpack-comment-spinner"> | |
| 757 | + <?php | |
| 758 | + require_once JETPACK__PLUGIN_DIR . '_inc/lib/class-jetpack-spinner.php'; | |
| 759 | + echo Jetpack_Spinner::render( 28 ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- static SVG markup. | |
| 760 | + ?> | |
| 761 | + </div> | |
| 762 | + <form id="jetpack-remote-comment-post-form" action="<?php echo esc_url( get_site_url() ); ?>/wp-comments-post.php?for=jetpack&only_once=true" method="POST"> | |
| 763 | + <?php foreach ( $comment_data as $key => $val ) : ?> | |
| 764 | + <input type="hidden" name="<?php echo esc_attr( $key ); ?>" value="<?php echo esc_attr( $val ); ?>" /> | |
| 765 | + <?php endforeach; ?> | |
| 766 | + </form> | |
| 767 | + | |
| 768 | + <script type="text/javascript"> | |
| 769 | + document.getElementById("jetpack-remote-comment-post-form").submit(); | |
| 770 | + </script> | |
| 771 | + </body> | |
| 772 | + </html> | |
| 773 | + <?php | |
| 774 | + exit( 0 ); | |
| 775 | + } | |
| 776 | + | |
| 614 | 777 | /** Capabilities **********************************************************/ |
| 615 | 778 | |
| 616 | 779 | /** |
| 617 | 780 | * Add some additional comment meta after comment is saved about what |
| @@ -621,16 +784,36 @@ | ||
| 621 | 784 | * |
| 622 | 785 | * @param int $comment_id The comment ID. |
| 623 | 786 | */ |
| 624 | 787 | public function add_comment_meta( $comment_id ) { |
| 788 | + // phpcs:disable WordPress.Security.NonceVerification.Missing -- The hc_* fields are authenticated by the HMAC check below. | |
| 789 | + $post_array = stripslashes_deep( $_POST ); | |
| 790 | + | |
| 791 | + // The hc_* identity fields are only trustworthy on a signed request. pre_comment_on_post() checks | |
| 792 | + // that, but only on wp-comments-post.php, so re-check here for any other producer that reaches | |
| 793 | + // comment_post (e.g. Carousel's unauthenticated post_attachment_comment endpoint). | |
| 794 | + if ( ! isset( $post_array['sig'] ) || ! isset( $post_array['token_key'] ) || ! is_string( $post_array['sig'] ) || ! is_string( $post_array['token_key'] ) ) { | |
| 795 | + return; | |
| 796 | + } | |
| 797 | + if ( isset( $post_array['hc_avatar'] ) && is_string( $post_array['hc_avatar'] ) && str_contains( $post_array['hc_avatar'], '.gravatar.com' ) ) { | |
| 798 | + $post_array['hc_avatar'] = htmlentities( $post_array['hc_avatar'], ENT_COMPAT ); | |
| 799 | + } | |
| 800 | + $blog_token = ( new Tokens() )->get_access_token( false, $post_array['token_key'] ); | |
| 801 | + if ( ! $blog_token || is_wp_error( $blog_token ) ) { | |
| 802 | + return; | |
| 803 | + } | |
| 804 | + $check = self::sign_remote_comment_parameters( $post_array, $blog_token->secret ); | |
| 805 | + if ( is_wp_error( $check ) || ! hash_equals( $check, $post_array['sig'] ) ) { | |
| 806 | + return; | |
| 807 | + } | |
| 808 | + | |
| 625 | 809 | $comment_meta = array(); |
| 626 | 810 | |
| 627 | - // phpcs:disable WordPress.Security.NonceVerification.Missing | |
| 628 | 811 | switch ( $this->is_highlander_comment_post() ) { |
| 629 | 812 | case 'facebook': |
| 630 | 813 | $comment_meta['hc_post_as'] = 'facebook'; |
| 631 | - $comment_meta['hc_avatar'] = isset( $_POST['hc_avatar'] ) ? filter_var( wp_unslash( $_POST['hc_avatar'] ) ) : null; | |
| 632 | - $comment_meta['hc_foreign_user_id'] = isset( $_POST['hc_userid'] ) ? filter_var( wp_unslash( $_POST['hc_userid'] ) ) : null; | |
| 814 | + $comment_meta['hc_avatar'] = isset( $_POST['hc_avatar'] ) ? esc_url_raw( wp_unslash( $_POST['hc_avatar'] ) ) : null; | |
| 815 | + $comment_meta['hc_foreign_user_id'] = isset( $_POST['hc_userid'] ) ? sanitize_text_field( wp_unslash( $_POST['hc_userid'] ) ) : null; | |
| 633 | 816 | break; |
| 634 | 817 | |
| 635 | 818 | // phpcs:ignore WordPress.WP.CapitalPDangit |
| 636 | 819 | case 'wordpress': |
| @@ -635,17 +818,17 @@ | ||
| 635 | 818 | // phpcs:ignore WordPress.WP.CapitalPDangit |
| 636 | 819 | case 'wordpress': |
| 637 | 820 | // phpcs:ignore WordPress.WP.CapitalPDangit |
| 638 | 821 | $comment_meta['hc_post_as'] = 'wordpress'; |
| 639 | - $comment_meta['hc_avatar'] = isset( $_POST['hc_avatar'] ) ? filter_var( wp_unslash( $_POST['hc_avatar'] ) ) : null; | |
| 640 | - $comment_meta['hc_foreign_user_id'] = isset( $_POST['hc_userid'] ) ? filter_var( wp_unslash( $_POST['hc_userid'] ) ) : null; | |
| 641 | - $comment_meta['hc_wpcom_id_sig'] = isset( $_POST['hc_wpcom_id_sig'] ) ? filter_var( wp_unslash( $_POST['hc_wpcom_id_sig'] ) ) : null; // since 1.9. | |
| 822 | + $comment_meta['hc_avatar'] = isset( $_POST['hc_avatar'] ) ? esc_url_raw( wp_unslash( $_POST['hc_avatar'] ) ) : null; | |
| 823 | + $comment_meta['hc_foreign_user_id'] = isset( $_POST['hc_userid'] ) ? sanitize_text_field( wp_unslash( $_POST['hc_userid'] ) ) : null; | |
| 824 | + $comment_meta['hc_wpcom_id_sig'] = isset( $_POST['hc_wpcom_id_sig'] ) ? sanitize_text_field( wp_unslash( $_POST['hc_wpcom_id_sig'] ) ) : null; // since 1.9. | |
| 642 | 825 | break; |
| 643 | 826 | |
| 644 | 827 | case 'jetpack': |
| 645 | 828 | $comment_meta['hc_post_as'] = 'jetpack'; |
| 646 | - $comment_meta['hc_avatar'] = isset( $_POST['hc_avatar'] ) ? filter_var( wp_unslash( $_POST['hc_avatar'] ) ) : null; | |
| 647 | - $comment_meta['hc_foreign_user_id'] = isset( $_POST['hc_userid'] ) ? filter_var( wp_unslash( $_POST['hc_userid'] ) ) : null; | |
| 829 | + $comment_meta['hc_avatar'] = isset( $_POST['hc_avatar'] ) ? esc_url_raw( wp_unslash( $_POST['hc_avatar'] ) ) : null; | |
| 830 | + $comment_meta['hc_foreign_user_id'] = isset( $_POST['hc_userid'] ) ? sanitize_text_field( wp_unslash( $_POST['hc_userid'] ) ) : null; | |
| 648 | 831 | break; |
| 649 | 832 | |
| 650 | 833 | } |
| 651 | 834 | // phpcs:enable WordPress.Security.NonceVerification.Missing |
| @@ -673,9 +856,9 @@ | ||
| 673 | 856 | return false; |
| 674 | 857 | } |
| 675 | 858 | |
| 676 | 859 | // phpcs:disable WordPress.Security.NonceVerification.Missing |
| 677 | - $is_current_user_subscribed = (bool) isset( $_POST['is_current_user_subscribed'] ) ? filter_var( wp_unslash( $_POST['is_current_user_subscribed'] ) ) : null; | |
| 860 | + $is_current_user_subscribed = isset( $_POST['is_current_user_subscribed'] ) ? filter_var( wp_unslash( $_POST['is_current_user_subscribed'] ) ) : null; | |
| 678 | 861 | |
| 679 | 862 | // Atomic sites with jetpack_verbum_subscription_modal option enabled |
| 680 | 863 | $modal_enabled = ( new Host() )->is_woa_site() && get_option( 'jetpack_verbum_subscription_modal', true ); |
| 681 | 864 | |
| @@ -714,9 +897,9 @@ | ||
| 714 | 897 | $tracking_event = 'hidden_self_hosted'; |
| 715 | 898 | } |
| 716 | 899 | |
| 717 | 900 | // phpcs:disable WordPress.Security.NonceVerification.Missing |
| 718 | - $is_current_user_subscribed = (bool) isset( $_POST['is_current_user_subscribed'] ) ? filter_var( wp_unslash( $_POST['is_current_user_subscribed'] ) ) : null; | |
| 901 | + $is_current_user_subscribed = isset( $_POST['is_current_user_subscribed'] ) ? filter_var( wp_unslash( $_POST['is_current_user_subscribed'] ) ) : null; | |
| 719 | 902 | |
| 720 | 903 | if ( $is_current_user_subscribed ) { |
| 721 | 904 | $tracking_event = 'hidden_already_subscribed'; |
| 722 | 905 | } |
| @@ -729,13 +912,13 @@ | ||
| 729 | 912 | |
| 730 | 913 | /** |
| 731 | 914 | * Catch the duplicated comment error and show a custom error page |
| 732 | 915 | * |
| 733 | - * @return void | |
| 916 | + * @return never | |
| 734 | 917 | */ |
| 735 | 918 | public function capture_comment_duplicate_trigger() { |
| 736 | 919 | if ( ! isset( $_GET['for'] ) || 'jetpack' !== $_GET['for'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended |
| 737 | - exit; | |
| 920 | + exit( 0 ); | |
| 738 | 921 | } |
| 739 | 922 | |
| 740 | 923 | ?> |
| 741 | 924 | <!DOCTYPE html> |
| @@ -812,9 +995,9 @@ | ||
| 812 | 995 | |
| 813 | 996 | </body> |
| 814 | 997 | </html> |
| 815 | 998 | <?php |
| 816 | - exit; | |
| 999 | + exit( 0 ); | |
| 817 | 1000 | } |
| 818 | 1001 | |
| 819 | 1002 | /** |
| 820 | 1003 | * POST the submitted comment to the iframe |
| @@ -913,13 +1096,13 @@ | ||
| 913 | 1096 | ?> |
| 914 | 1097 | </h3> |
| 915 | 1098 | <script type="text/javascript"> |
| 916 | 1099 | try { |
| 917 | - window.parent.location = <?php echo wp_json_encode( $url ); ?>; | |
| 918 | - window.parent.location.reload(true); | |
| 1100 | + window.parent.location.href = <?php echo wp_json_encode( $url, JSON_UNESCAPED_SLASHES | JSON_HEX_TAG | JSON_HEX_AMP ); ?>; | |
| 1101 | + window.parent.location.reload( true ); | |
| 919 | 1102 | } catch (e) { |
| 920 | - window.location = <?php echo wp_json_encode( $url ); ?>; | |
| 921 | - window.location.reload(true); | |
| 1103 | + window.location.href = <?php echo wp_json_encode( $url, JSON_UNESCAPED_SLASHES | JSON_HEX_TAG | JSON_HEX_AMP ); ?>; | |
| 1104 | + window.location.reload( true ); | |
| 922 | 1105 | } |
| 923 | 1106 | ellipsis = document.getElementById('ellipsis'); |
| 924 | 1107 | |
| 925 | 1108 | function toggleEllipsis() { |
| @@ -941,9 +1124,9 @@ | ||
| 941 | 1124 | |
| 942 | 1125 | window.parent.postMessage( |
| 943 | 1126 | { |
| 944 | 1127 | type: 'subscriptionModalShow', |
| 945 | - data: <?php echo wp_json_encode( $this->get_subscription_modal_data_to_parent( $url ) ); ?>, | |
| 1128 | + data: <?php echo wp_json_encode( $this->get_subscription_modal_data_to_parent( $url ), JSON_UNESCAPED_SLASHES | JSON_HEX_TAG | JSON_HEX_AMP ); ?>, | |
| 946 | 1129 | }, |
| 947 | 1130 | window.location.origin |
| 948 | 1131 | ); |
| 949 | 1132 | } |
| @@ -951,9 +1134,9 @@ | ||
| 951 | 1134 | <?php } ?> |
| 952 | 1135 | </body> |
| 953 | 1136 | </html> |
| 954 | 1137 | <?php |
| 955 | - exit; | |
| 1138 | + exit( 0 ); | |
| 956 | 1139 | } |
| 957 | 1140 | } |
| 958 | 1141 | |
| 959 | 1142 | Jetpack_Comments::init(); |
