| @@ -40,13 +40,99 @@ | ||
| 40 | 40 | */ |
| 41 | 41 | private static $instance; |
| 42 | 42 | |
| 43 | 43 | /** |
| 44 | + * Per-request memo for get_default_og_values(), keyed on post ID. See that | |
| 45 | + * method for why the defaults are worth memoizing and where the memo is | |
| 46 | + * dropped. | |
| 47 | + * | |
| 48 | + * @var array<int, array{title:string,description:string,image:string}> | |
| 49 | + */ | |
| 50 | + private static $default_og_values_memo = []; | |
| 51 | + | |
| 52 | + /** | |
| 44 | 53 | * Meta box ID |
| 45 | 54 | */ |
| 46 | 55 | const META_BOX_ID = 'metasync_opengraph_meta_box'; |
| 47 | 56 | |
| 48 | 57 | /** |
| 58 | + * The social title/description keys the meta box pre-fills from the post | |
| 59 | + * title/excerpt and persists on save. These are the keys that can capture the | |
| 60 | + * "Auto Draft" placeholder WordPress gives a brand-new, still-untitled post. | |
| 61 | + */ | |
| 62 | + const AUTO_DRAFT_PRONE_KEYS = [ | |
| 63 | + '_metasync_og_title', | |
| 64 | + '_metasync_og_description', | |
| 65 | + '_metasync_twitter_title', | |
| 66 | + '_metasync_twitter_description', | |
| 67 | + ]; | |
| 68 | + | |
| 69 | + /** | |
| 70 | + * The social title keys whose meta box default is the post title itself. | |
| 71 | + * Unlike the description keys — whose pre-fill (the excerpt) is content the | |
| 72 | + * editor curates separately — these mirror the title verbatim, so a stored | |
| 73 | + * value equal to it carries no information of its own: it is the pre-fill | |
| 74 | + * snapshot, not a customization. Reads collapse such rows to '' so the live | |
| 75 | + * title (which a rename keeps fresh) applies instead. | |
| 76 | + */ | |
| 77 | + const TITLE_DEFAULTED_KEYS = [ | |
| 78 | + '_metasync_og_title', | |
| 79 | + '_metasync_twitter_title', | |
| 80 | + ]; | |
| 81 | + | |
| 82 | + /** | |
| 83 | + * The social description keys whose meta box default is the resolved | |
| 84 | + * description (the excerpt the emitter would derive). The pre-fill persisted | |
| 85 | + * that default verbatim on save, so rows exist where these keys hold a copy | |
| 86 | + * of the excerpt as it was on save day — stale the moment the excerpt or the | |
| 87 | + * content it is generated from changes. Reads collapse such rows to '' so | |
| 88 | + * the live default applies instead. A value that differs from the default is | |
| 89 | + * untouched: only text the editor genuinely typed survives. | |
| 90 | + */ | |
| 91 | + const DESCRIPTION_DEFAULTED_KEYS = [ | |
| 92 | + '_metasync_og_description', | |
| 93 | + '_metasync_twitter_description', | |
| 94 | + ]; | |
| 95 | + | |
| 96 | + /** | |
| 97 | + * Site option holding every "Auto Draft" placeholder variant this install | |
| 98 | + * has actually seen, keyed by nothing, de-duplicated, capped. Core fills a | |
| 99 | + * new post's title with __( 'Auto Draft' ) in the *creating admin user's* | |
| 100 | + * locale, and that translation is not loaded on front-end requests, so no | |
| 101 | + * render-time literal/translation list can be complete. The registry is the | |
| 102 | + * locale-free source of truth: captured verbatim at creation time in admin, | |
| 103 | + * where the translation does resolve, and re-read anywhere. | |
| 104 | + */ | |
| 105 | + const AUTO_DRAFT_PLACEHOLDER_OPTION = 'metasync_auto_draft_placeholders'; | |
| 106 | + | |
| 107 | + /** | |
| 108 | + * Upper bound on registered placeholder variants. Locales change rarely; | |
| 109 | + * the cap keeps the site option tiny no matter how many editors come and | |
| 110 | + * go with different locales. | |
| 111 | + */ | |
| 112 | + const AUTO_DRAFT_PLACEHOLDER_CAP = 20; | |
| 113 | + | |
| 114 | + /** | |
| 115 | + * Upper bound on posts held in the get_default_og_values() memo. One | |
| 116 | + * front-end render touches one or two posts; a back-end loop (an importer, | |
| 117 | + * a bulk action, a resync walking every post) would otherwise grow the | |
| 118 | + * memo — and the excerpt-derivation results it caches — without end for | |
| 119 | + * the life of the request. When full the oldest entry is dropped first: | |
| 120 | + * insertion order is the only order the memo has, and a dropped post | |
| 121 | + * simply re-derives on its next read. | |
| 122 | + */ | |
| 123 | + const DEFAULT_OG_VALUES_MEMO_CAP = 10; | |
| 124 | + | |
| 125 | + /** | |
| 126 | + * Per-post flag marking "this post was saved while its title was still the | |
| 127 | + * untitled placeholder". Stores the exact placeholder string that was | |
| 128 | + * recognized at save time, so the render path can suppress by state (flag | |
| 129 | + * present + title still equals it) rather than by string matching alone — | |
| 130 | + * a genuinely-titled post never carries the flag. | |
| 131 | + */ | |
| 132 | + const UNTITLED_FLAG_META = '_metasync_untitled_placeholder'; | |
| 133 | + | |
| 134 | + /** | |
| 49 | 135 | * Initialize the class and set its properties. |
| 50 | 136 | */ |
| 51 | 137 | public function __construct($plugin_name, $version) { |
| 52 | 138 | $this->plugin_name = $plugin_name; |
| @@ -63,8 +149,375 @@ | ||
| 63 | 149 | return self::$instance; |
| 64 | 150 | } |
| 65 | 151 | |
| 66 | 152 | /** |
| 153 | + * Whether a value is the placeholder title WordPress assigns to a brand-new, | |
| 154 | + * still-untitled post. | |
| 155 | + * | |
| 156 | + * Core creates the row with a *translated* title — | |
| 157 | + * wp-admin/includes/post.php: 'post_title' => __( 'Auto Draft' ) — so matching | |
| 158 | + * only the English literal misses every localized site. Compare against the | |
| 159 | + * literal and the current locale's translation, so both an English install and | |
| 160 | + * a translated one are covered, as is a value stored before a locale switch. | |
| 161 | + * A third arm checks the captured-variant registry, because the translation | |
| 162 | + * only resolves in admin: on front-end requests __( 'Auto Draft' ) stays | |
| 163 | + * English even on a localized site, and a stored de_DE placeholder would | |
| 164 | + * otherwise pass every check above. | |
| 165 | + * | |
| 166 | + * Exact match after trim, never fuzzy: an editor who legitimately titles a post | |
| 167 | + * "Auto Draft" on purpose is a caller-side concern, and only the four social | |
| 168 | + * keys in AUTO_DRAFT_PRONE_KEYS are ever routed through here. | |
| 169 | + * | |
| 170 | + * @param mixed $value | |
| 171 | + * @return bool | |
| 172 | + */ | |
| 173 | + public static function is_auto_draft_title($value) { | |
| 174 | + if (!is_string($value)) { | |
| 175 | + return false; | |
| 176 | + } | |
| 177 | + $value = trim($value); | |
| 178 | + if ($value === '') { | |
| 179 | + return false; | |
| 180 | + } | |
| 181 | + # 'default' text domain, matching the __() call core itself uses. | |
| 182 | + if ($value === 'Auto Draft' || $value === trim(__('Auto Draft', 'default'))) { // phpcs:ignore WordPress.WP.I18n.TextDomainMismatch -- resolves core's own 'Auto Draft' placeholder, which only exists in core's 'default' domain; the plugin text domain cannot reproduce it | |
| 183 | + return true; | |
| 184 | + } | |
| 185 | + # Registry arm: a variant captured in another locale's admin request. | |
| 186 | + # Without it the guard above is English-only on every non-admin request, | |
| 187 | + # because core never loads the 'default' MO files out there. | |
| 188 | + return in_array($value, self::known_auto_draft_placeholders(), true); | |
| 189 | + } | |
| 190 | + | |
| 191 | + /** | |
| 192 | + * Every placeholder variant known to this install: the English literal plus | |
| 193 | + * whatever has been captured into the site option so far. | |
| 194 | + * | |
| 195 | + * @return string[] | |
| 196 | + */ | |
| 197 | + public static function known_auto_draft_placeholders() { | |
| 198 | + $stored = get_option(self::AUTO_DRAFT_PLACEHOLDER_OPTION, []); | |
| 199 | + if (!is_array($stored)) { | |
| 200 | + $stored = []; | |
| 201 | + } | |
| 202 | + $variants = ['Auto Draft']; | |
| 203 | + foreach ($stored as $variant) { | |
| 204 | + if (is_string($variant) && trim($variant) !== '' && !in_array(trim($variant), $variants, true)) { | |
| 205 | + $variants[] = trim($variant); | |
| 206 | + } | |
| 207 | + } | |
| 208 | + return $variants; | |
| 209 | + } | |
| 210 | + | |
| 211 | + /** | |
| 212 | + * Capture a placeholder variant into the site option. Called from the | |
| 213 | + * admin save path, where the creating request's own __( 'Auto Draft' ) | |
| 214 | + * has already verified the title *is* core's placeholder — so no | |
| 215 | + * translation is needed here, only de-duplication and capping. | |
| 216 | + * | |
| 217 | + * @param mixed $title Verbatim post title recognized as the placeholder. | |
| 218 | + * @return void | |
| 219 | + */ | |
| 220 | + public static function remember_auto_draft_placeholder($title) { | |
| 221 | + $title = is_string($title) ? trim($title) : ''; | |
| 222 | + if ($title === '' || $title === 'Auto Draft') { | |
| 223 | + return; | |
| 224 | + } | |
| 225 | + $known = self::known_auto_draft_placeholders(); | |
| 226 | + if (in_array($title, $known, true)) { | |
| 227 | + return; | |
| 228 | + } | |
| 229 | + # Persist captured variants only: the English literal is seeded | |
| 230 | + # code-side by known_auto_draft_placeholders(), so storing it would be | |
| 231 | + # redundant state. | |
| 232 | + $captured = array_values(array_diff($known, ['Auto Draft'])); | |
| 233 | + $captured[] = $title; | |
| 234 | + update_option(self::AUTO_DRAFT_PLACEHOLDER_OPTION, array_slice($captured, -self::AUTO_DRAFT_PLACEHOLDER_CAP), false); | |
| 235 | + } | |
| 236 | + | |
| 237 | + /** | |
| 238 | + * admin_init callback: register the placeholder variant the current admin | |
| 239 | + * request's translation resolves to. remember_auto_draft_placeholder() | |
| 240 | + * de-duplicates, so repeated requests only cost one cached option read. | |
| 241 | + * | |
| 242 | + * @return void | |
| 243 | + */ | |
| 244 | + public static function seed_auto_draft_placeholder() { | |
| 245 | + self::remember_auto_draft_placeholder(__('Auto Draft', 'default')); // phpcs:ignore WordPress.WP.I18n.TextDomainMismatch -- resolves core's own 'Auto Draft' placeholder, which only exists in core's 'default' domain; the plugin text domain cannot reproduce it | |
| 246 | + } | |
| 247 | + | |
| 248 | + /** | |
| 249 | + * Read a persisted social meta value, collapsing the "Auto Draft" placeholder | |
| 250 | + * to an empty string. | |
| 251 | + * | |
| 252 | + * Every consumer resolves these fields through a "first non-empty wins" chain | |
| 253 | + * (persisted key -> OTTO staging key -> real post title). A stored placeholder | |
| 254 | + * is truthy, so the chain would keep it; returning '' lets the chain fall | |
| 255 | + * through to the real title. That fixes rows already polluted before this fix | |
| 256 | + * shipped, at render time, without a DB migration. | |
| 257 | + * | |
| 258 | + * Public and static because the three consumers that actually emit or forward | |
| 259 | + * these values live in different classes: this emitter, | |
| 260 | + * Otto_html_class::apply_metabox_og_precedence(), and Metasync_Plugin_Sync's | |
| 261 | + * mirror into Yoast/RankMath/AIOSEO storage. Follows the same | |
| 262 | + * sanitize-at-the-source pattern as Metasync_Canonical_Sanitizer::sanitize(). | |
| 263 | + * | |
| 264 | + * @param mixed $value Raw stored meta value. | |
| 265 | + * @return string | |
| 266 | + */ | |
| 267 | + public static function strip_auto_draft_title($value) { | |
| 268 | + if (self::is_auto_draft_title($value)) { | |
| 269 | + return ''; | |
| 270 | + } | |
| 271 | + return is_scalar($value) ? (string) $value : ''; | |
| 272 | + } | |
| 273 | + | |
| 274 | + /** | |
| 275 | + * Read one of the AUTO_DRAFT_PRONE_KEYS for a post with the placeholder | |
| 276 | + * collapsed to '' — and, for the title keys, a stored snapshot of the | |
| 277 | + * title default the pre-fill showed (the post title, or the og title for | |
| 278 | + * the twitter twin), and for the description keys a stored snapshot of | |
| 279 | + * the resolved description, collapsed too. | |
| 280 | + * | |
| 281 | + * @param int $post_id | |
| 282 | + * @param string $key | |
| 283 | + * @return string | |
| 284 | + */ | |
| 285 | + public static function get_social_meta($post_id, $key) { | |
| 286 | + return self::strip_description_snapshot( | |
| 287 | + $post_id, | |
| 288 | + $key, | |
| 289 | + self::strip_title_snapshot( | |
| 290 | + $post_id, | |
| 291 | + $key, | |
| 292 | + self::strip_auto_draft_title(get_post_meta($post_id, $key, true)) | |
| 293 | + ) | |
| 294 | + ); | |
| 295 | + } | |
| 296 | + | |
| 297 | + /** | |
| 298 | + * Collapse a stored social title that merely mirrors the post's own title. | |
| 299 | + * | |
| 300 | + * The meta box used to pre-fill Title from the post title as a real value | |
| 301 | + * and persist it on save, so rows exist where `_metasync_og_title` (and the | |
| 302 | + * twitter twin) hold a verbatim copy of the title as it was on save day. | |
| 303 | + * Renaming the post then left that snapshot stale with nothing to tell it | |
| 304 | + * apart from a typed title. Collapsing it here — at the read, the same | |
| 305 | + * place the "Auto Draft" placeholder collapses — makes such a row read as | |
| 306 | + * unset, and the render-time fallback to the *live* title keeps the social | |
| 307 | + * title in step with every rename. A value that differs from the title is | |
| 308 | + * untouched: only text the editor genuinely typed survives. | |
| 309 | + * | |
| 310 | + * The twitter twin compares against what the og title field showed when | |
| 311 | + * the pre-fill was rendered — a stored og title if one is set, otherwise | |
| 312 | + * the same live post title — since that is exactly what the pre-fill | |
| 313 | + * echoed into the twitter field. Without that chain, a twitter row echoed | |
| 314 | + * from a typed og title would read as a deliberate override and stop | |
| 315 | + * following the og title it always rendered. | |
| 316 | + * | |
| 317 | + * Compared after trim on both sides: stored values pass through | |
| 318 | + * sanitize_text_field, which trims, so only the post title side can carry | |
| 319 | + * surrounding whitespace. | |
| 320 | + * | |
| 321 | + * Public and static for the same reason strip_auto_draft_title() is: the | |
| 322 | + * consumers live in different classes (this emitter, the precedence | |
| 323 | + * resolver, the plugin sync mirror, the SEO suite). | |
| 324 | + * | |
| 325 | + * @param int $post_id | |
| 326 | + * @param string $key One of TITLE_DEFAULTED_KEYS; others pass through. | |
| 327 | + * @param mixed $value Stored meta value, already placeholder-collapsed. | |
| 328 | + * @return string | |
| 329 | + */ | |
| 330 | + public static function strip_title_snapshot($post_id, $key, $value) { | |
| 331 | + $value = is_scalar($value) ? (string) $value : ''; | |
| 332 | + if ($value === '' || !in_array($key, self::TITLE_DEFAULTED_KEYS, true)) { | |
| 333 | + return $value; | |
| 334 | + } | |
| 335 | + | |
| 336 | + $default = self::default_social_title($post_id, $key); | |
| 337 | + if ($default === '') { | |
| 338 | + return $value; | |
| 339 | + } | |
| 340 | + | |
| 341 | + return trim($value) === trim($default) ? '' : $value; | |
| 342 | + } | |
| 343 | + | |
| 344 | + /** | |
| 345 | + * The default a title key renders when its own field is blank: the live | |
| 346 | + * post title for the og key, and for the twitter key whatever the og field | |
| 347 | + * would show (a stored og title if one is set, otherwise the same live | |
| 348 | + * title) — the exact chain the meta box fallback used to pre-fill as a | |
| 349 | + * value and still shows as the twitter field's placeholder. | |
| 350 | + * | |
| 351 | + * social_post_title() — not the raw post_title — is what the pre-fill ever | |
| 352 | + * stored, and it returns '' for a still-untitled post, where there is no | |
| 353 | + * meaningful default to compare against anyway (such rows are the | |
| 354 | + * placeholder case strip_auto_draft_title() already handles). | |
| 355 | + * | |
| 356 | + * @param int $post_id | |
| 357 | + * @param string $key | |
| 358 | + * @return string | |
| 359 | + */ | |
| 360 | + private static function default_social_title($post_id, $key) { | |
| 361 | + $title = self::social_post_title(get_post($post_id)); | |
| 362 | + if ($key === '_metasync_og_title') { | |
| 363 | + return $title; | |
| 364 | + } | |
| 365 | + | |
| 366 | + $og = self::get_social_meta($post_id, '_metasync_og_title'); | |
| 367 | + return $og !== '' ? $og : $title; | |
| 368 | + } | |
| 369 | + | |
| 370 | + /** | |
| 371 | + * Collapse a stored social description that merely mirrors the default the | |
| 372 | + * meta box pre-filled. | |
| 373 | + * | |
| 374 | + * The meta box pre-filled Description from the resolved description (the | |
| 375 | + * manual excerpt, or one generated from the content) as a real value and | |
| 376 | + * persisted it on save, so rows exist where `_metasync_og_description` (and | |
| 377 | + * the twitter twin) hold a copy of the excerpt as it was on save day. | |
| 378 | + * Changing the excerpt — or the content the excerpt is generated from — then | |
| 379 | + * left that snapshot stale with nothing to tell it apart from a typed | |
| 380 | + * description. Collapsing it here — at the read, the same place the "Auto | |
| 381 | + * Draft" placeholder and title snapshots collapse — makes such a row read as | |
| 382 | + * unset, and the render-time fallback to the *live* excerpt keeps the social | |
| 383 | + * description in step. A value that differs from the default is untouched: | |
| 384 | + * only text the editor genuinely typed survives. | |
| 385 | + * | |
| 386 | + * The twitter twin compares against what the og description field showed | |
| 387 | + * when the pre-fill was rendered — a stored og description if one is set, | |
| 388 | + * otherwise the same resolved default — since that is exactly what the | |
| 389 | + * pre-fill echoed into the twitter field. | |
| 390 | + * | |
| 391 | + * Compared after whitespace normalization on both sides: descriptions pass | |
| 392 | + * through sanitize_textarea_field, which preserves line breaks, and a manual | |
| 393 | + * excerpt can carry them while the generated default cannot, so a snapshot | |
| 394 | + * and its default must be compared with runs of whitespace treated as one | |
| 395 | + * space rather than byte-for-byte. | |
| 396 | + * | |
| 397 | + * Public and static for the same reason strip_title_snapshot() is: the | |
| 398 | + * consumers live in different classes (this emitter, the precedence | |
| 399 | + * resolver, the plugin sync mirror, the SEO suite). | |
| 400 | + * | |
| 401 | + * @param int $post_id | |
| 402 | + * @param string $key One of DESCRIPTION_DEFAULTED_KEYS; others pass through. | |
| 403 | + * @param mixed $value Stored meta value, already placeholder-collapsed. | |
| 404 | + * @return string | |
| 405 | + */ | |
| 406 | + public static function strip_description_snapshot($post_id, $key, $value) { | |
| 407 | + $value = is_scalar($value) ? (string) $value : ''; | |
| 408 | + if ($value === '' || !in_array($key, self::DESCRIPTION_DEFAULTED_KEYS, true)) { | |
| 409 | + return $value; | |
| 410 | + } | |
| 411 | + | |
| 412 | + $default = self::default_social_description($post_id, $key); | |
| 413 | + if ($default === '') { | |
| 414 | + return $value; | |
| 415 | + } | |
| 416 | + | |
| 417 | + return self::normalize_description_compare($value) === self::normalize_description_compare($default) | |
| 418 | + ? '' | |
| 419 | + : $value; | |
| 420 | + } | |
| 421 | + | |
| 422 | + /** | |
| 423 | + * The default a description key renders when its own field is blank: the | |
| 424 | + * resolved description for the og key, and for the twitter key whatever the | |
| 425 | + * og field would show (a stored og description if one is set, otherwise the | |
| 426 | + * same resolved default — even when that default is empty) — the exact | |
| 427 | + * chain the meta box fallback used to pre-fill as a value. | |
| 428 | + * | |
| 429 | + * Resolved through the emitter's own instance so it matches what actually | |
| 430 | + * renders; when no instance is available the default cannot be proven, so '' | |
| 431 | + * is returned and the caller keeps the stored value rather than risk | |
| 432 | + * discarding text the editor typed. | |
| 433 | + * | |
| 434 | + * @param int $post_id | |
| 435 | + * @param string $key | |
| 436 | + * @return string | |
| 437 | + */ | |
| 438 | + private static function default_social_description($post_id, $key) { | |
| 439 | + $instance = self::get_instance(); | |
| 440 | + if (!$instance) { | |
| 441 | + return ''; | |
| 442 | + } | |
| 443 | + | |
| 444 | + $default = (string) $instance->get_default_og_values($post_id)['description']; | |
| 445 | + if ($key === '_metasync_og_description') { | |
| 446 | + return $default; | |
| 447 | + } | |
| 448 | + | |
| 449 | + # The og chain runs for the twitter twin even when the resolved default | |
| 450 | + # is empty: the pre-fill echoed the og description into the twitter | |
| 451 | + # field whenever the og field carried a value, so that — not the empty | |
| 452 | + # excerpt — is the default a stored twitter echo must match to collapse. | |
| 453 | + $og = self::get_social_meta($post_id, '_metasync_og_description'); | |
| 454 | + return $og !== '' ? $og : $default; | |
| 455 | + } | |
| 456 | + | |
| 457 | + /** | |
| 458 | + * Normalize a description for equality comparison: trimmed, with runs of | |
| 459 | + * whitespace collapsed to a single space. Falls back to a plain trim when | |
| 460 | + * the value is not valid UTF-8 and the /u pattern therefore fails. | |
| 461 | + * | |
| 462 | + * @param string $value | |
| 463 | + * @return string | |
| 464 | + */ | |
| 465 | + private static function normalize_description_compare($value) { | |
| 466 | + $normalized = preg_replace('/\s+/u', ' ', trim((string) $value)); | |
| 467 | + return is_string($normalized) ? $normalized : trim((string) $value); | |
| 468 | + } | |
| 469 | + | |
| 470 | + /** | |
| 471 | + * A post's title for social use, suppressing only WordPress's own placeholder. | |
| 472 | + * | |
| 473 | + * Distinct from strip_auto_draft_title(), which is for *stored* meta values: | |
| 474 | + * there the string is all we have, since a legacy row carries no clue about the | |
| 475 | + * status it was written under. A live post gives us both signals, so require | |
| 476 | + * both — the post is still an auto-draft AND its title is the placeholder. An | |
| 477 | + * editor who genuinely titles a published post "Auto Draft" (an article about | |
| 478 | + * the placeholder itself, say) keeps it as their og:title. | |
| 479 | + * | |
| 480 | + * @param WP_Post|mixed $post | |
| 481 | + * @return string | |
| 482 | + */ | |
| 483 | + public static function social_post_title($post) { | |
| 484 | + if (!$post instanceof WP_Post) { | |
| 485 | + return ''; | |
| 486 | + } | |
| 487 | + if ($post->post_status === 'auto-draft' && self::is_auto_draft_title($post->post_title)) { | |
| 488 | + return ''; | |
| 489 | + } | |
| 490 | + # State-based arm: the post was saved while still untitled (flag set at | |
| 491 | + # save time, where translations resolve) and its title is still that | |
| 492 | + # flagged placeholder. This is what catches a placeholder-titled post | |
| 493 | + # that went on to be published — the status check above no longer | |
| 494 | + # matches it, and on a localized site the string checks cannot either. | |
| 495 | + $flagged = get_post_meta($post->ID, self::UNTITLED_FLAG_META, true); | |
| 496 | + if (is_string($flagged) && trim($flagged) !== '' && trim((string) $post->post_title) === trim($flagged)) { | |
| 497 | + return ''; | |
| 498 | + } | |
| 499 | + return (string) $post->post_title; | |
| 500 | + } | |
| 501 | + | |
| 502 | + /** | |
| 503 | + * Whether MetaSync social output is disabled for a post. | |
| 504 | + * | |
| 505 | + * The site-wide switch and the per-post switch both disable only MetaSync's | |
| 506 | + * social output; callers must leave third-party SEO output untouched. | |
| 507 | + * | |
| 508 | + * @param int $post_id Post ID. | |
| 509 | + * @return bool | |
| 510 | + */ | |
| 511 | + public static function is_social_output_disabled($post_id = 0) { | |
| 512 | + if (Metasync_Feature_Flags::is_disabled(Metasync_Feature_Flags::SOCIAL_OG)) { | |
| 513 | + return true; | |
| 514 | + } | |
| 515 | + | |
| 516 | + return $post_id > 0 && get_post_meta($post_id, '_metasync_og_enabled', true) === '0'; | |
| 517 | + } | |
| 518 | + | |
| 519 | + /** | |
| 67 | 520 | * The default OG values the meta box pre-fills for a post: post title, |
| 68 | 521 | * generated excerpt, and featured image. Computed with the same helpers the |
| 69 | 522 | * meta box/emitter use, so a caller can compare a stored _metasync_og_* value |
| 70 | 523 | * against the default and tell whether the user genuinely customized it (the |
| @@ -70,18 +523,51 @@ | ||
| 70 | 523 | * against the default and tell whether the user genuinely customized it (the |
| 71 | 524 | * meta box persists these defaults on save, so a non-empty value alone does |
| 72 | 525 | * not prove user intent). |
| 73 | 526 | * |
| 527 | + * The title is returned empty on a still-untitled post rather than as the | |
| 528 | + * "Auto Draft" placeholder, so the meta box pre-fills nothing and callers | |
| 529 | + * comparing a stored value against this default don't read the placeholder as | |
| 530 | + * a deliberate override. | |
| 531 | + * | |
| 532 | + * Memoized per request: the values are pure functions of the post, and one | |
| 533 | + * front-end render resolves them several times (every collapsed description | |
| 534 | + * read asks for the default, and the OTTO precedence walk asks again) — on | |
| 535 | + * page-builder content the excerpt pass alone re-runs the whole | |
| 536 | + * shortcode-strip pipeline each time. The save handler drops the memo | |
| 537 | + * before its comparisons, since save_post fires after the post row write | |
| 538 | + * and the comparison must see the new title/excerpt. Capped at | |
| 539 | + * DEFAULT_OG_VALUES_MEMO_CAP posts for loops that walk many posts in one | |
| 540 | + * request. | |
| 541 | + * | |
| 74 | 542 | * @param int $post_id |
| 75 | 543 | * @return array{title:string,description:string,image:string} |
| 76 | 544 | */ |
| 77 | 545 | public function get_default_og_values($post_id) { |
| 546 | + $post_id = (int) $post_id; | |
| 547 | + // No real post: get_post(0) answers with the global post, which would | |
| 548 | + // then be memoized under key 0 and served for every later bogus id. | |
| 549 | + if ($post_id <= 0) { | |
| 550 | + return ['title' => '', 'description' => '', 'image' => '']; | |
| 551 | + } | |
| 552 | + if (isset(self::$default_og_values_memo[$post_id])) { | |
| 553 | + return self::$default_og_values_memo[$post_id]; | |
| 554 | + } | |
| 555 | + | |
| 78 | 556 | $post = get_post($post_id); |
| 79 | 557 | if (!$post instanceof WP_Post) { |
| 80 | 558 | return ['title' => '', 'description' => '', 'image' => '']; |
| 81 | 559 | } |
| 82 | - return [ | |
| 83 | - 'title' => (string) $post->post_title, | |
| 560 | + | |
| 561 | + if (count(self::$default_og_values_memo) >= self::DEFAULT_OG_VALUES_MEMO_CAP) { | |
| 562 | + // unset() on the first key, NOT array_shift(): the memo is keyed by | |
| 563 | + // post id, and array_shift() reindexes integer keys from zero — | |
| 564 | + // after one eviction the survivors would live under 0..8 and any | |
| 565 | + // post with a low id would be served another post's defaults. | |
| 566 | + unset(self::$default_og_values_memo[array_key_first(self::$default_og_values_memo)]); | |
| 567 | + } | |
| 568 | + return self::$default_og_values_memo[$post_id] = [ | |
| 569 | + 'title' => self::social_post_title($post), | |
| 84 | 570 | 'description' => (string) $this->get_post_excerpt($post), |
| 85 | 571 | 'image' => (string) $this->get_featured_image_url($post->ID), |
| 86 | 572 | ]; |
| 87 | 573 | } |
| @@ -86,13 +572,27 @@ | ||
| 86 | 572 | ]; |
| 87 | 573 | } |
| 88 | 574 | |
| 89 | 575 | /** |
| 576 | + * Drop the get_default_og_values() memo. Called on the save path, where the | |
| 577 | + * just-written post row must be re-read rather than served from a memo | |
| 578 | + * populated earlier in the request; also the seam long-lived processes | |
| 579 | + * (tests, CLI) use to simulate a fresh request. Mirrors | |
| 580 | + * Metasync_Otto_Config::clear_cache(). | |
| 581 | + */ | |
| 582 | + public static function clear_default_og_values_memo() { | |
| 583 | + self::$default_og_values_memo = []; | |
| 584 | + } | |
| 585 | + | |
| 586 | + /** | |
| 90 | 587 | * Register all hooks for this class |
| 91 | 588 | */ |
| 92 | 589 | public function init() { |
| 93 | 590 | # Admin hooks |
| 94 | 591 | add_action('add_meta_boxes', [$this, 'add_meta_box']); |
| 592 | + # Runs before save_meta_box_data so the untitled flag it maintains is | |
| 593 | + # already current when the meta box save guard consults it. | |
| 594 | + add_action('save_post', [$this, 'track_untitled_post'], 5, 2); | |
| 95 | 595 | add_action('save_post', [$this, 'save_meta_box_data']); |
| 96 | 596 | add_action('admin_enqueue_scripts', [$this, 'enqueue_admin_scripts']); |
| 97 | 597 | |
| 98 | 598 | # Alternative script loading for post edit screens |
| @@ -120,8 +620,19 @@ | ||
| 120 | 620 | |
| 121 | 621 | # Register cross-plugin dedup filters (Yoast / Rank Math) when their plugins are active |
| 122 | 622 | $this->register_dedup_filters(); |
| 123 | 623 | |
| 624 | + # Keep the localized "Auto Draft" placeholder out of SEO-plugin titles | |
| 625 | + # for posts published while still untitled. | |
| 626 | + $this->register_untitled_title_filters(); | |
| 627 | + | |
| 628 | + # Seed the placeholder registry with this admin user's locale variant, | |
| 629 | + # so localized values are recognized everywhere even before any new | |
| 630 | + # post is created on a localized install. | |
| 631 | + if (is_admin()) { | |
| 632 | + add_action('admin_init', [self::class, 'seed_auto_draft_placeholder']); | |
| 633 | + } | |
| 634 | + | |
| 124 | 635 | # Shared predicate so the legacy emitter (Metasync_Seo_Output::hook_metasync_metatags) |
| 125 | 636 | # can suppress its own OG/Twitter blocks whenever this class will emit for the post |
| 126 | 637 | add_filter('metasync_opengraph_will_emit', [$this, 'will_emit']); |
| 127 | 638 | } |
| @@ -138,8 +649,15 @@ | ||
| 138 | 649 | * @param bool $default Filter default (ignored; the real answer is computed). |
| 139 | 650 | * @return bool |
| 140 | 651 | */ |
| 141 | 652 | public function will_emit($default = false) { |
| 653 | + # Feature switched off, so this emitter stays silent. The legacy emitter | |
| 654 | + # checks the same switch independently, so reporting false here cannot | |
| 655 | + # hand it the work. | |
| 656 | + if (Metasync_Feature_Flags::is_disabled(Metasync_Feature_Flags::SOCIAL_OG)) { | |
| 657 | + return false; | |
| 658 | + } | |
| 659 | + | |
| 142 | 660 | if (!is_singular($this->get_supported_post_types())) { |
| 143 | 661 | return false; |
| 144 | 662 | } |
| 145 | 663 | |
| @@ -212,9 +730,9 @@ | ||
| 212 | 730 | |
| 213 | 731 | # LPS / custom-HTML pages bake their own OG/social tags into their HTML bundle, |
| 214 | 732 | # served before wp_head — so this box does nothing on them. Hide it; the SEO |
| 215 | 733 | # read-only notice covers the messaging. |
| 216 | - $lps_post_id = isset($_GET['post']) ? intval($_GET['post']) : (isset($_POST['post_ID']) ? intval($_POST['post_ID']) : 0); | |
| 734 | + $lps_post_id = isset($_GET['post']) ? intval($_GET['post']) : (isset($_POST['post_ID']) ? intval($_POST['post_ID']) : 0); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.NonceVerification.Recommended -- read-only post ID to pick meta boxes | |
| 217 | 735 | if (function_exists('metasync_is_custom_or_lps_page') && $lps_post_id > 0 && metasync_is_custom_or_lps_page($lps_post_id)) { |
| 218 | 736 | return; |
| 219 | 737 | } |
| 220 | 738 | |
| @@ -224,8 +742,9 @@ | ||
| 224 | 742 | |
| 225 | 743 | foreach ($post_types as $post_type) { |
| 226 | 744 | add_meta_box( |
| 227 | 745 | self::META_BOX_ID, |
| 746 | + /* translators: %s: effective plugin name (whitelabel-aware). */ | |
| 228 | 747 | sprintf(esc_html__('Social Media & Open Graph by %s', 'metasync'), $plugin_name), |
| 229 | 748 | [$this, 'render_meta_box'], |
| 230 | 749 | $post_type, |
| 231 | 750 | 'normal', |
| @@ -240,12 +759,16 @@ | ||
| 240 | 759 | public function render_meta_box($post) { |
| 241 | 760 | # Add nonce for security |
| 242 | 761 | wp_nonce_field('metasync_opengraph_nonce', 'metasync_opengraph_nonce'); |
| 243 | 762 | |
| 244 | - # Get existing values | |
| 763 | + # Get existing values. The four social title/description keys are read through | |
| 764 | + # get_social_meta(), which collapses the "Auto Draft" placeholder, a stored | |
| 765 | + # snapshot of the post title, and a stored snapshot of the resolved | |
| 766 | + # description to '' — so a polluted legacy row shows an empty field (the | |
| 767 | + # default lives in the placeholder) and re-saving clears it. | |
| 245 | 768 | $og_enabled = get_post_meta($post->ID, '_metasync_og_enabled', true); |
| 246 | - $og_title = get_post_meta($post->ID, '_metasync_og_title', true); | |
| 247 | - $og_description = get_post_meta($post->ID, '_metasync_og_description', true); | |
| 769 | + $og_title = self::get_social_meta($post->ID, '_metasync_og_title'); | |
| 770 | + $og_description = self::get_social_meta($post->ID, '_metasync_og_description'); | |
| 248 | 771 | $og_image = get_post_meta($post->ID, '_metasync_og_image', true); |
| 249 | 772 | $og_url = get_post_meta($post->ID, '_metasync_og_url', true); |
| 250 | 773 | $og_type = get_post_meta($post->ID, '_metasync_og_type', true); |
| 251 | 774 | |
| @@ -251,10 +774,10 @@ | ||
| 251 | 774 | |
| 252 | 775 | # Twitter Card fields |
| 253 | 776 | $twitter_card = get_post_meta($post->ID, '_metasync_twitter_card', true); |
| 254 | 777 | $twitter_site = get_post_meta($post->ID, '_metasync_twitter_site', true); |
| 255 | - $twitter_title = get_post_meta($post->ID, '_metasync_twitter_title', true); | |
| 256 | - $twitter_description = get_post_meta($post->ID, '_metasync_twitter_description', true); | |
| 778 | + $twitter_title = self::get_social_meta($post->ID, '_metasync_twitter_title'); | |
| 779 | + $twitter_description = self::get_social_meta($post->ID, '_metasync_twitter_description'); | |
| 257 | 780 | $twitter_image = get_post_meta($post->ID, '_metasync_twitter_image', true); |
| 258 | 781 | $twitter_image_alt = get_post_meta($post->ID, '_metasync_twitter_image_alt', true); |
| 259 | 782 | |
| 260 | 783 | # Twitter App Card fields |
| @@ -276,14 +799,36 @@ | ||
| 276 | 799 | if ($og_enabled === '') { |
| 277 | 800 | # For new posts, default to enabled |
| 278 | 801 | $og_enabled = '1'; |
| 279 | 802 | } |
| 280 | - if (empty($og_title)) { | |
| 281 | - $og_title = $post->post_title; | |
| 282 | - } | |
| 283 | - if (empty($og_description)) { | |
| 284 | - $og_description = $this->get_post_excerpt($post); | |
| 285 | - } | |
| 803 | + # The post title is the default social title, but it is shown as a | |
| 804 | + # placeholder, never as the field's value. Submitting a page carries | |
| 805 | + # every value attribute to the save handler, so pre-filling the title | |
| 806 | + # persisted a verbatim snapshot of it — one a later rename left stale | |
| 807 | + # (and indistinguishable from a typed title). An empty field plus a | |
| 808 | + # placeholder keeps the default visible while storing nothing, and the | |
| 809 | + # render-time fallback to the live title tracks renames on its own. | |
| 810 | + # social_post_title() suppresses WordPress's own "Auto Draft" | |
| 811 | + # placeholder, so a brand-new post shows no misleading hint either. | |
| 812 | + $title_placeholder = self::social_post_title($post); | |
| 813 | + # What twitter:title actually renders when its own field is blank: the | |
| 814 | + # OG title if one is set, otherwise the same live post title. Shown as | |
| 815 | + # the twitter field's placeholder for the same reason as above. | |
| 816 | + $twitter_title_placeholder = ($og_title !== '') ? $og_title : $title_placeholder; | |
| 817 | + # The resolved description (the manual excerpt, or one generated from | |
| 818 | + # the content) is the default social description, and like the title it | |
| 819 | + # is shown as a placeholder, never as the field's value. Pre-filling it | |
| 820 | + # persisted a snapshot of the excerpt as of save day — one a later | |
| 821 | + # excerpt or content edit left stale, and indistinguishable from a | |
| 822 | + # typed description. An empty field plus a placeholder keeps the | |
| 823 | + # default visible while storing nothing, and the render-time fallback | |
| 824 | + # to the live excerpt tracks edits on its own. | |
| 825 | + $description_placeholder = $this->get_post_excerpt($post); | |
| 826 | + # What twitter:description actually renders when its own field is | |
| 827 | + # blank: the OG description if one is set, otherwise the same resolved | |
| 828 | + # default. Shown as the twitter field's placeholder for the same | |
| 829 | + # reason as above. | |
| 830 | + $twitter_description_placeholder = ($og_description !== '') ? $og_description : $description_placeholder; | |
| 286 | 831 | if (empty($og_url)) { |
| 287 | 832 | $og_url = $this->get_canonical_url($post); |
| 288 | 833 | } |
| 289 | 834 | if (empty($og_type)) { |
| @@ -291,19 +836,13 @@ | ||
| 291 | 836 | } |
| 292 | 837 | if (empty($og_image)) { |
| 293 | 838 | $og_image = $this->get_featured_image_url($post->ID); |
| 294 | 839 | } |
| 295 | - | |
| 840 | + | |
| 296 | 841 | # Twitter defaults |
| 297 | 842 | if (empty($twitter_card)) { |
| 298 | 843 | $twitter_card = 'summary_large_image'; |
| 299 | 844 | } |
| 300 | - if (empty($twitter_title)) { | |
| 301 | - $twitter_title = $og_title; | |
| 302 | - } | |
| 303 | - if (empty($twitter_description)) { | |
| 304 | - $twitter_description = $og_description; | |
| 305 | - } | |
| 306 | 845 | if (empty($twitter_image)) { |
| 307 | 846 | $twitter_image = $og_image; |
| 308 | 847 | } |
| 309 | 848 | |
| @@ -317,10 +856,20 @@ | ||
| 317 | 856 | /** |
| 318 | 857 | * Save meta box data |
| 319 | 858 | */ |
| 320 | 859 | public function save_meta_box_data($post_id) { |
| 860 | + # Drop the defaults memo before anything below can bail. This handler is | |
| 861 | + # hooked to save_post, so it runs for EVERY save of the post — including | |
| 862 | + # ones initiated by another meta box, a bulk action, or a sync flow that | |
| 863 | + # carries no OG nonce and would have returned early above the old flush | |
| 864 | + # position. Without this clear, a memo seeded earlier in the same request | |
| 865 | + # (a metabox render, a sync read) survives the post-row write and serves | |
| 866 | + # the pre-save title/excerpt to the snapshot comparisons in later | |
| 867 | + # save_post subscribers — the Yoast re-sync on shutdown among them. | |
| 868 | + self::clear_default_og_values_memo(); | |
| 869 | + | |
| 321 | 870 | # Check if nonce is valid |
| 322 | - if (!isset($_POST['metasync_opengraph_nonce']) || | |
| 871 | + if (!isset($_POST['metasync_opengraph_nonce']) || | |
| 323 | 872 | !wp_verify_nonce($_POST['metasync_opengraph_nonce'], 'metasync_opengraph_nonce')) { |
| 324 | 873 | return; |
| 325 | 874 | } |
| 326 | 875 | |
| @@ -385,14 +934,156 @@ | ||
| 385 | 934 | |
| 386 | 935 | foreach ($all_fields as $field => $sanitize_callback) { |
| 387 | 936 | if (isset($_POST[$field])) { |
| 388 | 937 | $value = call_user_func($sanitize_callback, $_POST[$field]); |
| 389 | - update_post_meta($post_id, $field, $value); | |
| 938 | + | |
| 939 | + # The meta box pre-fills empty social title/description fields from the | |
| 940 | + # post title, and on a brand-new post that title is the "Auto Draft" | |
| 941 | + # placeholder. Persisting it ships "Auto Draft" as the post's social | |
| 942 | + # title and description forever, so store empty instead and let the | |
| 943 | + # render-time fallback chain resolve the real title once one is set. | |
| 944 | + if (in_array($field, self::AUTO_DRAFT_PRONE_KEYS, true) | |
| 945 | + && $this->is_auto_draft_prefill_echo($post_id, $value) | |
| 946 | + ) { | |
| 947 | + $value = ''; | |
| 948 | + } | |
| 949 | + | |
| 950 | + # A social title identical to the post's title is the default, not a | |
| 951 | + # customization — whether the editor left an older pre-filled form | |
| 952 | + # untouched or typed the title back verbatim. Store empty so the | |
| 953 | + # render-time fallback to the live title applies, which is what keeps | |
| 954 | + # a rename from leaving a stale snapshot behind. Text that differs | |
| 955 | + # from the title passes through untouched. save_post fires after the | |
| 956 | + # post row is written, so the comparison is against the *new* title. | |
| 957 | + if (in_array($field, self::TITLE_DEFAULTED_KEYS, true)) { | |
| 958 | + $value = self::strip_title_snapshot($post_id, $field, $value); | |
| 959 | + } | |
| 960 | + | |
| 961 | + # A social description identical to its rendered default — the | |
| 962 | + # resolved excerpt the older pre-filled form carried, or the | |
| 963 | + # same text typed back verbatim — is the default, not a | |
| 964 | + # customization. Store empty so the render-time fallback to the | |
| 965 | + # live excerpt applies, which is what keeps an excerpt or | |
| 966 | + # content edit from leaving a stale snapshot behind. Text that | |
| 967 | + # differs from the default passes through untouched. save_post | |
| 968 | + # fires after the post row is written, so the comparison is | |
| 969 | + # against the *new* excerpt and content. | |
| 970 | + if (in_array($field, self::DESCRIPTION_DEFAULTED_KEYS, true)) { | |
| 971 | + $value = self::strip_description_snapshot($post_id, $field, $value); | |
| 972 | + } | |
| 973 | + | |
| 974 | + # An empty value means "no value" for every field in this box, | |
| 975 | + # and must not be stored as one: update_post_meta(..., '') keeps | |
| 976 | + # a row with an empty meta_value in the table (visible only to | |
| 977 | + # metadata_exists, EXISTS queries and exports, which would then | |
| 978 | + # report a customization where the field is merely blank). The | |
| 979 | + # plain read answers '' for a missing row too, so deleting is | |
| 980 | + # behaviour-preserving for every reader. Same pattern the | |
| 981 | + # untitled-flag write below has always used. | |
| 982 | + if ($value === '') { | |
| 983 | + delete_post_meta($post_id, $field); | |
| 984 | + } else { | |
| 985 | + update_post_meta($post_id, $field, $value); | |
| 986 | + } | |
| 390 | 987 | } |
| 391 | 988 | } |
| 392 | 989 | } |
| 393 | 990 | |
| 394 | 991 | /** |
| 992 | + * Whether a submitted social field value is the meta box echoing back a | |
| 993 | + * placeholder pre-fill rather than something the editor typed. | |
| 994 | + * | |
| 995 | + * Two cases, both narrow on purpose so genuinely typed text is never discarded: | |
| 996 | + * - the value is the "Auto Draft" placeholder itself; or | |
| 997 | + * - the post is still an auto-draft and the value is just its title echoed | |
| 998 | + * back, which is what the pre-fill submits when the editor never touched | |
| 999 | + * the field. | |
| 1000 | + * | |
| 1001 | + * @param int $post_id | |
| 1002 | + * @param mixed $value Sanitized submitted value. | |
| 1003 | + * @return bool | |
| 1004 | + */ | |
| 1005 | + /** | |
| 1006 | + * save_post tracker maintaining the untitled state this class suppresses by. | |
| 1007 | + * | |
| 1008 | + * Two jobs, both anchored at save time — the only place the "Auto Draft" | |
| 1009 | + * translation reliably resolves — so the render path never has to guess: | |
| 1010 | + * | |
| 1011 | + * 1. Capture: when core creates an auto-draft, its title *is* | |
| 1012 | + * __( 'Auto Draft' ) in the creating request's locale (admin requests | |
| 1013 | + * carry the creating user's locale). Verified against that same __() | |
| 1014 | + * call here, then remembered verbatim, so every locale variant this | |
| 1015 | + * install ever uses is known to all contexts. | |
| 1016 | + * 2. Flag: mark posts saved while still placeholder-titled (recognized via | |
| 1017 | + * literal + translation + the registry above, so REST/CLI saves — where | |
| 1018 | + * the translation stays English — still recognize a registry hit), and | |
| 1019 | + * clear the mark as soon as a real title arrives. | |
| 1020 | + * | |
| 1021 | + * @param int $post_id | |
| 1022 | + * @param WP_Post|mixed $post | |
| 1023 | + * @return void | |
| 1024 | + */ | |
| 1025 | + public function track_untitled_post($post_id, $post) { | |
| 1026 | + if (wp_is_post_revision($post_id) || wp_is_post_autosave($post_id)) { | |
| 1027 | + return; | |
| 1028 | + } | |
| 1029 | + if (!$post instanceof WP_Post) { | |
| 1030 | + $post = get_post($post_id); | |
| 1031 | + } | |
| 1032 | + if (!$post instanceof WP_Post || $post->post_type === 'revision' || $post->post_status === 'trash') { | |
| 1033 | + return; | |
| 1034 | + } | |
| 1035 | + if (!in_array($post->post_type, $this->get_supported_post_types(), true)) { | |
| 1036 | + return; | |
| 1037 | + } | |
| 1038 | + | |
| 1039 | + $title = trim((string) $post->post_title); | |
| 1040 | + | |
| 1041 | + # Capture: an auto-draft's title is core's placeholder in whatever | |
| 1042 | + # locale resolved for the saving request — admin requests carry the | |
| 1043 | + # creating user's locale; on untranslated requests (front end, REST, | |
| 1044 | + # CLI) the equality below degenerates to the English literal, which | |
| 1045 | + # remember_auto_draft_placeholder() already skips. Verified against | |
| 1046 | + # __( 'Auto Draft' ), never trusted as a bare string, so a builder's | |
| 1047 | + # custom-seeded auto-draft title is never captured. | |
| 1048 | + if ($post->post_status === 'auto-draft' | |
| 1049 | + && $title !== '' && $title === trim(__('Auto Draft', 'default'))) { // phpcs:ignore WordPress.WP.I18n.TextDomainMismatch -- resolves core's own 'Auto Draft' placeholder, which only exists in core's 'default' domain; the plugin text domain cannot reproduce it | |
| 1050 | + self::remember_auto_draft_placeholder($title); | |
| 1051 | + } | |
| 1052 | + | |
| 1053 | + # Flag maintenance: recognition is context-independent thanks to the | |
| 1054 | + # registry (an untranslated REST/CLI save still matches a captured | |
| 1055 | + # variant), so the flag can never go stale in either direction. | |
| 1056 | + if (self::is_auto_draft_title($title)) { | |
| 1057 | + update_post_meta($post_id, self::UNTITLED_FLAG_META, $title); | |
| 1058 | + } else { | |
| 1059 | + delete_post_meta($post_id, self::UNTITLED_FLAG_META); | |
| 1060 | + } | |
| 1061 | + } | |
| 1062 | + | |
| 1063 | + private function is_auto_draft_prefill_echo($post_id, $value) { | |
| 1064 | + if (self::is_auto_draft_title($value)) { | |
| 1065 | + return true; | |
| 1066 | + } | |
| 1067 | + if (!is_string($value) || trim($value) === '') { | |
| 1068 | + return false; | |
| 1069 | + } | |
| 1070 | + $post = get_post($post_id); | |
| 1071 | + if (!$post instanceof WP_Post || trim($value) !== trim((string) $post->post_title)) { | |
| 1072 | + return false; | |
| 1073 | + } | |
| 1074 | + if (get_post_status($post_id) === 'auto-draft') { | |
| 1075 | + return true; | |
| 1076 | + } | |
| 1077 | + # State arm: the submitted value echoes a title that was flagged as the | |
| 1078 | + # placeholder at save time. Covers a value the string checks above | |
| 1079 | + # missed — e.g. a localized placeholder stored under an admin user | |
| 1080 | + # whose locale differs from the one that created the post. | |
| 1081 | + $flagged = get_post_meta($post_id, self::UNTITLED_FLAG_META, true); | |
| 1082 | + return is_string($flagged) && trim($flagged) !== '' && trim($flagged) === trim($value); | |
| 1083 | + } | |
| 1084 | + | |
| 1085 | + /** | |
| 395 | 1086 | * Enqueue admin scripts and styles |
| 396 | 1087 | */ |
| 397 | 1088 | public function enqueue_admin_scripts($hook) { |
| 398 | 1089 | global $post_type; |
| @@ -493,8 +1184,13 @@ | ||
| 493 | 1184 | /** |
| 494 | 1185 | * Output Open Graph and Twitter Card tags in wp_head |
| 495 | 1186 | */ |
| 496 | 1187 | public function output_opengraph_tags() { |
| 1188 | + # Social Media & Open Graph switched off — emit nothing. | |
| 1189 | + if (Metasync_Feature_Flags::is_disabled(Metasync_Feature_Flags::SOCIAL_OG)) { | |
| 1190 | + return; | |
| 1191 | + } | |
| 1192 | + | |
| 497 | 1193 | if (!is_singular($this->get_supported_post_types())) { |
| 498 | 1194 | return; |
| 499 | 1195 | } |
| 500 | 1196 | |
| @@ -508,10 +1204,9 @@ | ||
| 508 | 1204 | # Check if Open Graph is enabled for this post. |
| 509 | 1205 | # Only an explicit '0' opt-out suppresses output; unset/empty counts as enabled |
| 510 | 1206 | # so a MetaSync-only site gets one consolidated set whether or not the meta |
| 511 | 1207 | # box was ever saved. Must stay in sync with will_emit(). |
| 512 | - $og_enabled = get_post_meta($post->ID, '_metasync_og_enabled', true); | |
| 513 | - if ($og_enabled === '0') { | |
| 1208 | + if (self::is_social_output_disabled($post->ID)) { | |
| 514 | 1209 | return; |
| 515 | 1210 | } |
| 516 | 1211 | |
| 517 | 1212 | # When OTTO owns this page's OG (enabled + persisted OG data), skip legacy |
| @@ -526,17 +1221,53 @@ | ||
| 526 | 1221 | if (apply_filters('metasync_opengraph_check_conflicts', true) && $this->has_seo_plugin_conflicts()) { |
| 527 | 1222 | return; |
| 528 | 1223 | } |
| 529 | 1224 | |
| 530 | - # Get Open Graph data — check persisted key first, fall back to OTTO staging key, then post default | |
| 531 | - $og_title = get_post_meta($post->ID, '_metasync_og_title', true) | |
| 532 | - ?: get_post_meta($post->ID, '_metasync_otto_og_title', true) | |
| 533 | - ?: $post->post_title; | |
| 534 | - $og_description = get_post_meta($post->ID, '_metasync_og_description', true) | |
| 535 | - ?: get_post_meta($post->ID, '_metasync_otto_og_description', true) | |
| 1225 | + # Open Graph data. The tier order — what the customer set, then OTTO, then | |
| 1226 | + # a value brought in from another SEO plugin — comes from | |
| 1227 | + # Metasync_Seo_Precedence so this emitter and the conflict handler cannot | |
| 1228 | + # disagree about which value the page should carry. The resolver collapses a | |
| 1229 | + # stored "Auto Draft" placeholder, a snapshot of the post title, and a | |
| 1230 | + # snapshot of the resolved description to '' as it walks the chain, so a | |
| 1231 | + # row polluted by the meta box pre-fill falls through to the live | |
| 1232 | + # fallback (or OTTO's tier) rather than outranking it. The literal | |
| 1233 | + # fallbacks below the chain (post title, excerpt, featured image) stay | |
| 1234 | + # here: they are derived at render time, not stored. | |
| 1235 | + $og_title = Metasync_Seo_Precedence::value($post->ID, Metasync_Seo_Precedence::FIELD_OG_TITLE) | |
| 1236 | + ?: self::social_post_title($post); | |
| 1237 | + $og_description = Metasync_Seo_Precedence::value($post->ID, Metasync_Seo_Precedence::FIELD_OG_DESCRIPTION) | |
| 536 | 1238 | ?: $this->get_post_excerpt($post); |
| 537 | - $og_image = get_post_meta($post->ID, '_metasync_og_image', true) ?: $this->get_featured_image_url($post->ID); | |
| 538 | - $og_url = get_post_meta($post->ID, '_metasync_og_url', true) ?: $this->get_canonical_url($post); | |
| 1239 | + $og_image = Metasync_Seo_Precedence::value($post->ID, Metasync_Seo_Precedence::FIELD_OG_IMAGE) | |
| 1240 | + ?: $this->get_featured_image_url($post->ID); | |
| 1241 | + $canonical_override = ''; | |
| 1242 | + if (class_exists('Metasync_Headless_Config') && Metasync_Headless_Config::is_active()) { | |
| 1243 | + # The same two-key chain the canonical tag itself resolves, so the | |
| 1244 | + # two cannot disagree. meta_canonical is not a legacy alias: the | |
| 1245 | + # REST sync and the classic-editor Canonical box both still write | |
| 1246 | + # it, and the GraphQL surface reads both keys as well. | |
| 1247 | + foreach (array('_metasync_canonical_url', 'meta_canonical') as $canonical_key) { | |
| 1248 | + $canonical_override = Metasync_Canonical_Sanitizer::sanitize( | |
| 1249 | + get_post_meta($post->ID, $canonical_key, true) | |
| 1250 | + ); | |
| 1251 | + if ($canonical_override !== '') { | |
| 1252 | + break; | |
| 1253 | + } | |
| 1254 | + } | |
| 1255 | + } | |
| 1256 | + | |
| 1257 | + # A validated canonical override is the author's final answer. It may | |
| 1258 | + # deliberately name another host, so it bypasses headless rehosting. | |
| 1259 | + if ($canonical_override !== '') { | |
| 1260 | + $og_url = esc_url($canonical_override); | |
| 1261 | + } else { | |
| 1262 | + $og_url = get_post_meta($post->ID, '_metasync_og_url', true) ?: $this->get_canonical_url($post); | |
| 1263 | + | |
| 1264 | + # On a headless site the rendered page is not the public page, so | |
| 1265 | + # an own-host og:url must name the frontend. Applied at the single | |
| 1266 | + # emission source so update_opengraph_url() continues to persist | |
| 1267 | + # the WordPress URL used outside headless mode. | |
| 1268 | + $og_url = $this->maybe_build_headless_url($og_url, $post->post_type); | |
| 1269 | + } | |
| 539 | 1270 | $og_type = get_post_meta($post->ID, '_metasync_og_type', true) ?: 'article'; |
| 540 | 1271 | |
| 541 | 1272 | # Get Twitter Card data — check persisted key first, fall back to OTTO staging key |
| 542 | 1273 | $twitter_card = get_post_meta($post->ID, '_metasync_twitter_card', true) ?: 'summary_large_image'; |
| @@ -549,15 +1280,14 @@ | ||
| 549 | 1280 | if (empty($twitter_site) && !empty($twitter_username)) { |
| 550 | 1281 | $twitter_site = '@' . $twitter_username; |
| 551 | 1282 | } |
| 552 | 1283 | $twitter_creator = !empty($twitter_username) ? '@' . $twitter_username : ''; |
| 553 | - $twitter_title = get_post_meta($post->ID, '_metasync_twitter_title', true) | |
| 554 | - ?: get_post_meta($post->ID, '_metasync_otto_twitter_title', true) | |
| 1284 | + $twitter_title = Metasync_Seo_Precedence::value($post->ID, Metasync_Seo_Precedence::FIELD_TWITTER_TITLE) | |
| 555 | 1285 | ?: $og_title; |
| 556 | - $twitter_description = get_post_meta($post->ID, '_metasync_twitter_description', true) | |
| 557 | - ?: get_post_meta($post->ID, '_metasync_otto_twitter_description', true) | |
| 1286 | + $twitter_description = Metasync_Seo_Precedence::value($post->ID, Metasync_Seo_Precedence::FIELD_TWITTER_DESCRIPTION) | |
| 558 | 1287 | ?: $og_description; |
| 559 | - $twitter_image = get_post_meta($post->ID, '_metasync_twitter_image', true) ?: $og_image; | |
| 1288 | + $twitter_image = Metasync_Seo_Precedence::value($post->ID, Metasync_Seo_Precedence::FIELD_TWITTER_IMAGE) | |
| 1289 | + ?: $og_image; | |
| 560 | 1290 | $twitter_image_alt = get_post_meta($post->ID, '_metasync_twitter_image_alt', true); |
| 561 | 1291 | |
| 562 | 1292 | # Resolve OG image attachment ID once for reuse (twitter:image:alt fallback + og:image dimensions) |
| 563 | 1293 | $og_image_attachment_id = 0; |
| @@ -756,8 +1486,14 @@ | ||
| 756 | 1486 | * complete article metadata while other SEO plugins handle og:title/description. |
| 757 | 1487 | * Cross-plugin dedup is handled via register_dedup_filters() instead. |
| 758 | 1488 | */ |
| 759 | 1489 | public function output_article_tags() { |
| 1490 | + # article:* tags are part of the same Open Graph block, so they follow | |
| 1491 | + # the same switch as output_opengraph_tags(). | |
| 1492 | + if (Metasync_Feature_Flags::is_disabled(Metasync_Feature_Flags::SOCIAL_OG)) { | |
| 1493 | + return; | |
| 1494 | + } | |
| 1495 | + | |
| 760 | 1496 | if (!is_singular()) { |
| 761 | 1497 | return; |
| 762 | 1498 | } |
| 763 | 1499 | |
| @@ -765,8 +1501,12 @@ | ||
| 765 | 1501 | if (!$post instanceof WP_Post) { |
| 766 | 1502 | return; |
| 767 | 1503 | } |
| 768 | 1504 | |
| 1505 | + if (self::is_social_output_disabled($post->ID)) { | |
| 1506 | + return; | |
| 1507 | + } | |
| 1508 | + | |
| 769 | 1509 | $og_type = get_post_meta($post->ID, '_metasync_og_type', true) ?: 'article'; |
| 770 | 1510 | if ($og_type !== 'article') { |
| 771 | 1511 | return; |
| 772 | 1512 | } |
| @@ -872,16 +1612,27 @@ | ||
| 872 | 1612 | $yoast_active = is_plugin_active('wordpress-seo/wp-seo.php') |
| 873 | 1613 | || is_plugin_active('wordpress-seo-premium/wp-seo-premium.php'); |
| 874 | 1614 | $rank_math_active = is_plugin_active('seo-by-rank-math/rank-math.php'); |
| 875 | 1615 | |
| 876 | - $article_timestamps_enabled = ($settings['article_timestamps'] ?? 'true') !== 'false'; | |
| 877 | - $article_author_enabled = ($settings['article_author'] ?? 'true') !== 'false'; | |
| 878 | - $article_section_enabled = ($settings['article_section'] ?? 'true') !== 'false'; | |
| 879 | - $article_tags_enabled = ($settings['article_tags'] ?? 'true') !== 'false'; | |
| 1616 | + # The article:* tags these filters suppress are emitted by | |
| 1617 | + # output_article_tags(), which stands down when the Social Media & Open | |
| 1618 | + # Graph feature is switched off. Treat every article feature as disabled | |
| 1619 | + # in that case so the third party keeps rendering its own tags — pulling | |
| 1620 | + # ours without releasing theirs would leave the page with none. | |
| 1621 | + $social_enabled = Metasync_Feature_Flags::is_enabled(Metasync_Feature_Flags::SOCIAL_OG); | |
| 880 | 1622 | |
| 1623 | + $article_timestamps_enabled = $social_enabled && ($settings['article_timestamps'] ?? 'true') !== 'false'; | |
| 1624 | + $article_author_enabled = $social_enabled && ($settings['article_author'] ?? 'true') !== 'false'; | |
| 1625 | + $article_section_enabled = $social_enabled && ($settings['article_section'] ?? 'true') !== 'false'; | |
| 1626 | + $article_tags_enabled = $social_enabled && ($settings['article_tags'] ?? 'true') !== 'false'; | |
| 1627 | + | |
| 881 | 1628 | # Yoast: remove individual presenters based on which MetaSync features are enabled |
| 882 | 1629 | if ($yoast_active && ($article_timestamps_enabled || $article_author_enabled)) { |
| 883 | 1630 | add_filter('wpseo_frontend_presenters', function( $presenters ) use ( $article_timestamps_enabled, $article_author_enabled ) { |
| 1631 | + $post_id = function_exists('get_queried_object_id') ? (int) get_queried_object_id() : 0; | |
| 1632 | + if (self::is_social_output_disabled($post_id)) { | |
| 1633 | + return $presenters; | |
| 1634 | + } | |
| 884 | 1635 | foreach ( $presenters as $key => $presenter ) { |
| 885 | 1636 | if ( $article_timestamps_enabled && ( |
| 886 | 1637 | $presenter instanceof \Yoast\WP\SEO\Presenters\Open_Graph\Article_Published_Time_Presenter || |
| 887 | 1638 | $presenter instanceof \Yoast\WP\SEO\Presenters\Open_Graph\Article_Modified_Time_Presenter |
| @@ -901,25 +1652,98 @@ | ||
| 901 | 1652 | # Rank Math's tag() method passes content through rank_math/opengraph/facebook/{property} |
| 902 | 1653 | # where {property} is the OG property with colons replaced by underscores. |
| 903 | 1654 | # Returning false causes tag() to skip output (empty($content) check). |
| 904 | 1655 | if ($rank_math_active) { |
| 1656 | + $keep_third_party = function ($value) { | |
| 1657 | + $post_id = function_exists('get_queried_object_id') ? (int) get_queried_object_id() : 0; | |
| 1658 | + return self::is_social_output_disabled($post_id) ? $value : false; | |
| 1659 | + }; | |
| 905 | 1660 | if ($article_timestamps_enabled) { |
| 906 | - add_filter('rank_math/opengraph/facebook/article_published_time', '__return_false', 999); | |
| 907 | - add_filter('rank_math/opengraph/facebook/article_modified_time', '__return_false', 999); | |
| 1661 | + add_filter('rank_math/opengraph/facebook/article_published_time', $keep_third_party, 999); | |
| 1662 | + add_filter('rank_math/opengraph/facebook/article_modified_time', $keep_third_party, 999); | |
| 908 | 1663 | } |
| 909 | 1664 | if ($article_tags_enabled) { |
| 910 | - add_filter('rank_math/opengraph/facebook/article_tag', '__return_false', 999); | |
| 1665 | + add_filter('rank_math/opengraph/facebook/article_tag', $keep_third_party, 999); | |
| 911 | 1666 | } |
| 912 | 1667 | if ($article_author_enabled) { |
| 913 | - add_filter('rank_math/opengraph/facebook/article_author', '__return_false', 999); | |
| 1668 | + add_filter('rank_math/opengraph/facebook/article_author', $keep_third_party, 999); | |
| 914 | 1669 | } |
| 915 | 1670 | if ($article_section_enabled) { |
| 916 | - add_filter('rank_math/opengraph/facebook/article_section', '__return_false', 999); | |
| 1671 | + add_filter('rank_math/opengraph/facebook/article_section', $keep_third_party, 999); | |
| 917 | 1672 | } |
| 918 | 1673 | } |
| 919 | 1674 | } |
| 920 | 1675 | |
| 921 | 1676 | /** |
| 1677 | + * Hook the untitled-placeholder suppression into the title pipelines of | |
| 1678 | + * the SEO plugins that can own the <title>/og:title/twitter:title output | |
| 1679 | + * when MetaSync's own emitter stands down due to a conflict. | |
| 1680 | + * | |
| 1681 | + * Rank Math funnels <title>, og:title and twitter:title through one filter | |
| 1682 | + * (rank_math/frontend/title wraps Paper::get_title()), so one hook covers | |
| 1683 | + * all three. Yoast builds them from separate presenters, so it needs the | |
| 1684 | + * title filter plus the og/twitter title filters. | |
| 1685 | + * | |
| 1686 | + * The hooks are registered unconditionally: each only fires while its | |
| 1687 | + * plugin is actually generating a title, and the callback no-ops unless | |
| 1688 | + * the current post carries the untitled flag. | |
| 1689 | + * | |
| 1690 | + * @return void | |
| 1691 | + */ | |
| 1692 | + private function register_untitled_title_filters() { | |
| 1693 | + add_filter('rank_math/frontend/title', [$this, 'strip_untitled_from_seo_title'], 99); | |
| 1694 | + add_filter('wpseo_title', [$this, 'strip_untitled_from_seo_title'], 99); | |
| 1695 | + add_filter('wpseo_opengraph_title', [$this, 'strip_untitled_from_seo_title'], 99); | |
| 1696 | + add_filter('wpseo_twitter_title', [$this, 'strip_untitled_from_seo_title'], 99); | |
| 1697 | + } | |
| 1698 | + | |
| 1699 | + /** | |
| 1700 | + * Remove the flagged placeholder from an SEO plugin's assembled title. | |
| 1701 | + * | |
| 1702 | + * The incoming value is the finished template output ("placeholder - | |
| 1703 | + * Site name"), so the placeholder segment is cut out and any dangling | |
| 1704 | + * separator tidied. An empty result (title was the placeholder alone) | |
| 1705 | + * cannot be returned as-is: both plugins treat an empty value as "do | |
| 1706 | + * nothing" and re-use their own generated title, so the site name is the | |
| 1707 | + * replacement of last resort. | |
| 1708 | + * | |
| 1709 | + * @param mixed $title Assembled title from the SEO plugin. | |
| 1710 | + * @return string | |
| 1711 | + */ | |
| 1712 | + public function strip_untitled_from_seo_title($title) { | |
| 1713 | + if (!is_string($title) || trim($title) === '') { | |
| 1714 | + return $title; | |
| 1715 | + } | |
| 1716 | + $post = get_post(); | |
| 1717 | + if (!$post instanceof WP_Post) { | |
| 1718 | + return $title; | |
| 1719 | + } | |
| 1720 | + $flagged = get_post_meta($post->ID, self::UNTITLED_FLAG_META, true); | |
| 1721 | + if (!is_string($flagged) || trim($flagged) === '') { | |
| 1722 | + return $title; | |
| 1723 | + } | |
| 1724 | + # Same state check as social_post_title(): only while the live title | |
| 1725 | + # still *is* the flagged placeholder. | |
| 1726 | + if (trim((string) $post->post_title) !== trim($flagged)) { | |
| 1727 | + return $title; | |
| 1728 | + } | |
| 1729 | + if (strpos($title, $flagged) === false) { | |
| 1730 | + return $title; | |
| 1731 | + } | |
| 1732 | + $remainder = trim(str_replace($flagged, '', $title)); | |
| 1733 | + # Tidy the separator(s) that flanked the removed segment. | |
| 1734 | + $remainder = trim((string) preg_replace('/^[\s\-–—|·»•]+|[\s\-–—|·»•]+$/u', '', $remainder)); | |
| 1735 | + if ($remainder === '') { | |
| 1736 | + $remainder = trim((string) get_bloginfo('name')); | |
| 1737 | + } | |
| 1738 | + if ($remainder === '') { | |
| 1739 | + # A space, not '': an empty return is a no-op for these filters. | |
| 1740 | + $remainder = ' '; | |
| 1741 | + } | |
| 1742 | + return $remainder; | |
| 1743 | + } | |
| 1744 | + | |
| 1745 | + /** | |
| 922 | 1746 | * AJAX handler for generating social media preview |
| 923 | 1747 | */ |
| 924 | 1748 | public function ajax_generate_preview() { |
| 925 | 1749 | |
| @@ -962,9 +1786,9 @@ | ||
| 962 | 1786 | private function generate_preview_html($title, $description, $image, $url, $twitter_title = '', $twitter_description = '', $twitter_image = '') { |
| 963 | 1787 | # Parse domain from URL |
| 964 | 1788 | $domain = ''; |
| 965 | 1789 | if (!empty($url)) { |
| 966 | - $parsed = parse_url($url); | |
| 1790 | + $parsed = wp_parse_url($url); | |
| 967 | 1791 | $domain = $parsed['host'] ?? ''; |
| 968 | 1792 | } |
| 969 | 1793 | |
| 970 | 1794 | # Fallback to site URL if no domain found |
| @@ -969,9 +1793,9 @@ | ||
| 969 | 1793 | |
| 970 | 1794 | # Fallback to site URL if no domain found |
| 971 | 1795 | if (empty($domain)) { |
| 972 | 1796 | $site_url = get_site_url(); |
| 973 | - $parsed = parse_url($site_url); | |
| 1797 | + $parsed = wp_parse_url($site_url); | |
| 974 | 1798 | $domain = $parsed['host'] ?? 'your-site.com'; |
| 975 | 1799 | } |
| 976 | 1800 | |
| 977 | 1801 | # Provide fallbacks for empty values |
| @@ -1158,13 +1982,20 @@ | ||
| 1158 | 1982 | # Remove extra whitespace, line breaks, and special characters |
| 1159 | 1983 | $content = preg_replace('/\s+/', ' ', $content); |
| 1160 | 1984 | $content = trim($content); |
| 1161 | 1985 | |
| 1162 | - # If content is still empty or too short, fallback to post title | |
| 1986 | + # If content is still empty or too short, fallback to post title. A brand-new | |
| 1987 | + # post has no content and its title is the "Auto Draft" placeholder, which | |
| 1988 | + # must not become the og:/twitter:description — strip it so the caller's | |
| 1989 | + # fallback chain resolves to something real instead. | |
| 1163 | 1990 | if (empty($content) || strlen($content) < 20) { |
| 1164 | - $content = $post->post_title; | |
| 1991 | + $content = self::social_post_title($post); | |
| 1165 | 1992 | } |
| 1166 | 1993 | |
| 1994 | + if ($content === '') { | |
| 1995 | + return ''; | |
| 1996 | + } | |
| 1997 | + | |
| 1167 | 1998 | # Generate excerpt |
| 1168 | 1999 | $excerpt = wp_trim_words($content, 30, '...'); |
| 1169 | 2000 | |
| 1170 | 2001 | return $excerpt; |
| @@ -1346,8 +2177,62 @@ | ||
| 1346 | 2177 | return $permalink; |
| 1347 | 2178 | } |
| 1348 | 2179 | |
| 1349 | 2180 | /** |
| 2181 | + * Rehost a URL onto the public frontend when headless mode is active. | |
| 2182 | + * | |
| 2183 | + * Unlike the derived-URL callers elsewhere, the value handed here can be a | |
| 2184 | + * stored one an editor typed, which may legitimately point at a third-party | |
| 2185 | + * host. Only a URL on this site's own host is rewritten; anything else is | |
| 2186 | + * returned untouched. A builder failure is returned as an empty string so | |
| 2187 | + * the emitter cannot advertise the WordPress host on an active headless site. | |
| 2188 | + * | |
| 2189 | + * @param mixed $url URL to consider rehosting. | |
| 2190 | + * @param string $post_type Post type, for the frontend path prefix. | |
| 2191 | + * @return mixed Original URL when inactive or foreign; public URL or empty | |
| 2192 | + * string for an own-host URL while active. | |
| 2193 | + */ | |
| 2194 | + private function maybe_build_headless_url($url, $post_type = '') { | |
| 2195 | + if (!class_exists('Metasync_Headless_Config') || !Metasync_Headless_Config::is_active() || !$this->is_own_host_url($url)) { | |
| 2196 | + return $url; | |
| 2197 | + } | |
| 2198 | + | |
| 2199 | + return Metasync_Headless_Url_Builder::from_wp_url($url, $post_type); | |
| 2200 | + } | |
| 2201 | + | |
| 2202 | + /** | |
| 2203 | + * Whether a URL addresses this WordPress site rather than a foreign host. | |
| 2204 | + * | |
| 2205 | + * Accepts only HTTP(S) URLs on the exact site host, protocol-relative URLs | |
| 2206 | + * on that host, and genuine site-relative paths beginning with one slash. | |
| 2207 | + * | |
| 2208 | + * @param mixed $url URL to test. | |
| 2209 | + * @return bool | |
| 2210 | + */ | |
| 2211 | + private function is_own_host_url($url) { | |
| 2212 | + if (!is_string($url) || $url === '' || preg_match('/\s/', $url)) { | |
| 2213 | + return false; | |
| 2214 | + } | |
| 2215 | + | |
| 2216 | + if ($url[0] === '/' && (!isset($url[1]) || $url[1] !== '/')) { | |
| 2217 | + return true; | |
| 2218 | + } | |
| 2219 | + | |
| 2220 | + $is_protocol_relative = strpos($url, '//') === 0; | |
| 2221 | + $scheme = strtolower((string) wp_parse_url($url, PHP_URL_SCHEME)); | |
| 2222 | + if (!$is_protocol_relative && !in_array($scheme, array('http', 'https'), true)) { | |
| 2223 | + return false; | |
| 2224 | + } | |
| 2225 | + | |
| 2226 | + $url_host = wp_parse_url($url, PHP_URL_HOST); | |
| 2227 | + $site_host = wp_parse_url(home_url('/'), PHP_URL_HOST); | |
| 2228 | + | |
| 2229 | + return !empty($url_host) | |
| 2230 | + && !empty($site_host) | |
| 2231 | + && strcasecmp((string) $url_host, (string) $site_host) === 0; | |
| 2232 | + } | |
| 2233 | + | |
| 2234 | + /** | |
| 1350 | 2235 | * Update OpenGraph URL when post is saved |
| 1351 | 2236 | */ |
| 1352 | 2237 | public function update_opengraph_url($post_id) { |
| 1353 | 2238 | # Only update for supported post types |
| @@ -1487,11 +2372,20 @@ | ||
| 1487 | 2372 | /** |
| 1488 | 2373 | * Check if post slug changed via edit slug functionality |
| 1489 | 2374 | */ |
| 1490 | 2375 | public function check_slug_change() { |
| 2376 | + # Fires on the same admin-ajax request as core's sample-permalink | |
| 2377 | + # handler, but at priority 5 — before core validates the nonce and | |
| 2378 | + # capability at its own priority-10 callback. Verify them ourselves | |
| 2379 | + # before any post-meta write. Return (not die) so core still serves | |
| 2380 | + # the preview request normally. | |
| 2381 | + if (!check_ajax_referer('samplepermalink', 'samplepermalinknonce', false)) { | |
| 2382 | + return; | |
| 2383 | + } | |
| 2384 | + | |
| 1491 | 2385 | # Get the post ID from the request |
| 1492 | 2386 | $post_id = isset($_POST['post_id']) ? intval($_POST['post_id']) : 0; |
| 1493 | - if (!$post_id) { | |
| 2387 | + if (!$post_id || !current_user_can('edit_post', $post_id)) { | |
| 1494 | 2388 | return; |
| 1495 | 2389 | } |
| 1496 | 2390 | |
| 1497 | 2391 | # Only check for supported post types |
| @@ -1524,9 +2418,9 @@ | ||
| 1524 | 2418 | # This means the og:url was set to the post permalink (not a custom URL) |
| 1525 | 2419 | if ($current_og_url !== $current_permalink && strpos($current_og_url, '?p=') === false) { |
| 1526 | 2420 | # Check if the og:url was the old permalink by comparing with a generated old permalink |
| 1527 | 2421 | $old_post = clone $post; |
| 1528 | - $old_slug = isset($_POST['new_slug']) ? sanitize_title($_POST['new_slug']) : $post->post_name; | |
| 2422 | + $old_slug = isset($_POST['new_slug']) ? sanitize_title(wp_unslash($_POST['new_slug'])) : $post->post_name; | |
| 1529 | 2423 | |
| 1530 | 2424 | # If the og:url doesn't match the current permalink, it might be the old one |
| 1531 | 2425 | # We'll update it to the new permalink |
| 1532 | 2426 | if ($current_og_url !== $current_permalink) { |
