PluginProbe
Search Atlas SEO – OTTO AI SEO Automation for WordPress / 2.7.1
Search Atlas SEO – OTTO AI SEO Automation for WordPress v2.7.1
2.7.1 2.7.2 2.7.0 2.6.26 2.6.25 2.6.24 2.6.23 2.6.22 2.6.21 2.6.20 2.6.19 2.6.18 2.6.17 2.6.16 2.6.15 2.6.14 2.6.13 2.6.12 2.6.11 2.6.10 2.6.9 2.6.8 2.6.7 2.6.6 2.6.5 All 141 releases
← All changes | views/metasync-xml-sitemap.php +169 -41 2.6.24 → 2.7.1 View file →
@@ -55,39 +55,27 @@
55 55 <?php
56 56 $sitemap_files = $sitemap_generator->get_sitemap_files();
57 57 $sitemap_count = count($sitemap_files);
58 58
59 - // Check news/video sitemap status
59 + // Check news/video sitemap status.
60 + //
61 + // Read through get_sitemap_document() — the same accessor the
62 + // served route uses — so these tiles always describe the document
63 + // crawlers actually receive. Reading the transient and the
64 + // physical file in a different order than the serving code is
65 + // what made the dashboard report a URL count no crawler ever saw.
60 66 $news_sm_enabled = !empty($news_settings['enabled']);
61 67 $video_sm_enabled = !empty($video_settings['enabled']);
62 - $news_sm_exists = false !== get_transient('metasync_vsm_' . md5('news-sitemap.xml'))
63 - || file_exists(ABSPATH . 'news-sitemap.xml');
64 - $video_sm_exists = false !== get_transient('metasync_vsm_' . md5('video-sitemap.xml'))
65 - || file_exists(ABSPATH . 'video-sitemap.xml');
68 + $news_xml = $sitemap_generator->get_sitemap_document('news-sitemap.xml');
69 + $video_xml = $sitemap_generator->get_sitemap_document('video-sitemap.xml');
70 + $news_sm_exists = false !== $news_xml;
71 + $video_sm_exists = false !== $video_xml;
66 72 $extra_sitemap_count = ($news_sm_exists ? 1 : 0) + ($video_sm_exists ? 1 : 0);
67 73 $total_sitemap_count = $sitemap_count + $extra_sitemap_count;
68 74
69 75 // Count URLs in news/video sitemaps for total
70 - $news_url_count = 0;
71 - $video_url_count = 0;
72 - if ($news_sm_exists) {
73 - $news_xml = get_transient('metasync_vsm_' . md5('news-sitemap.xml'));
74 - if (!$news_xml && file_exists(ABSPATH . 'news-sitemap.xml')) {
75 - $news_xml = file_get_contents(ABSPATH . 'news-sitemap.xml');
76 - }
77 - if ($news_xml) {
78 - $news_url_count = substr_count($news_xml, '<url>');
79 - }
80 - }
81 - if ($video_sm_exists) {
82 - $video_xml = get_transient('metasync_vsm_' . md5('video-sitemap.xml'));
83 - if (!$video_xml && file_exists(ABSPATH . 'video-sitemap.xml')) {
84 - $video_xml = file_get_contents(ABSPATH . 'video-sitemap.xml');
85 - }
86 - if ($video_xml) {
87 - $video_url_count = substr_count($video_xml, '<url>');
88 - }
89 - }
76 + $news_url_count = $news_sm_exists ? substr_count($news_xml, '<url>') : 0;
77 + $video_url_count = $video_sm_exists ? substr_count($video_xml, '<url>') : 0;
90 78 $total_url_count = $url_count + $news_url_count + $video_url_count;
91 79 $any_sitemap_exists = $sitemap_exists || $news_sm_exists || $video_sm_exists;
92 80 ?>
93 81
@@ -450,9 +438,9 @@
450 438 <td><?php echo number_format($urls_in_file); ?></td>
451 439 <td>
452 440 <?php
453 441 if ($last_generated) {
454 - echo esc_html(date('M j, Y g:i A', strtotime($last_generated)));
442 + echo esc_html(gmdate('M j, Y g:i A', strtotime($last_generated)));
455 443 } else {
456 444 echo '—';
457 445 }
458 446 ?>
@@ -481,9 +469,9 @@
481 469 <div class="sitemap-filename">news-sitemap.xml</div>
482 470 <div class="sitemap-url-range"><?php esc_html_e('Google News Sitemap', 'metasync'); ?></div>
483 471 </td>
484 472 <td><?php echo $news_sm_exists ? $news_url_count : '<em style="color:var(--dashboard-text-secondary);">Not generated</em>'; ?></td>
485 - <td><?php echo ($news_sm_exists && $last_generated) ? esc_html(date('M j, Y g:i A', strtotime($last_generated))) : '—'; ?></td>
473 + <td><?php echo ($news_sm_exists && $last_generated) ? esc_html(gmdate('M j, Y g:i A', strtotime($last_generated))) : '—'; ?></td>
486 474 <td>
487 475 <?php if ($news_sm_exists): ?>
488 476 <a href="<?php echo esc_url(home_url('/news-sitemap.xml')); ?>" target="_blank" class="button-view">
489 477 <span class="dashicons dashicons-external"></span>
@@ -509,9 +497,9 @@
509 497 <div class="sitemap-filename">video-sitemap.xml</div>
510 498 <div class="sitemap-url-range"><?php esc_html_e('Video Sitemap', 'metasync'); ?></div>
511 499 </td>
512 500 <td><?php echo $video_sm_exists ? $video_url_count : '<em style="color:var(--dashboard-text-secondary);">Not generated</em>'; ?></td>
513 - <td><?php echo ($video_sm_exists && $last_generated) ? esc_html(date('M j, Y g:i A', strtotime($last_generated))) : '—'; ?></td>
501 + <td><?php echo ($video_sm_exists && $last_generated) ? esc_html(gmdate('M j, Y g:i A', strtotime($last_generated))) : '—'; ?></td>
514 502 <td>
515 503 <?php if ($video_sm_exists): ?>
516 504 <a href="<?php echo esc_url(home_url('/video-sitemap.xml')); ?>" target="_blank" class="button-view">
517 505 <span class="dashicons dashicons-external"></span>
@@ -580,10 +568,11 @@
580 568 <?php
581 569 require_once plugin_dir_path(dirname(__FILE__)) . 'sitemap/class-metasync-sitemap-news.php';
582 570 $news_checker = new Metasync_Sitemap_News();
583 571 $news_conflicts = $news_checker->get_conflict_notices();
584 - $news_has_content = false !== get_transient('metasync_vsm_' . md5('news-sitemap.xml'))
585 - || file_exists(ABSPATH . 'news-sitemap.xml');
572 + // Reuse the accessor-derived value computed for the status tiles so
573 + // this panel cannot disagree with them, or with the served document.
574 + $news_has_content = $news_sm_exists;
586 575 $news_conflict_name = $news_checker->get_conflict_plugin_name();
587 576 $mss_brand = Metasync::get_effective_plugin_name();
588 577
589 578 # Flag a generated-but-empty news sitemap. $news_url_count is already
@@ -597,8 +586,9 @@
597 586
598 587 <?php if (!empty($news_conflict_name)): ?>
599 588 <div class="metasync-sitemap-conflict-note" style="display:flex; gap:7px; align-items:center; margin:0 0 16px; padding:8px 12px; border-radius:7px; background:rgba(245,158,11,0.08); border:1px solid rgba(245,158,11,0.28); font-size:12px; line-height:1.5; color:var(--dashboard-text-secondary,#6b7280);">
600 589 <span style="font-size:13px; line-height:1;">&#9888;&#65039;</span>
590 + <?php /* translators: %s: plugin brand name. */ ?>
601 591 <span><strong style="color:#8a5a00;"><?php echo esc_html($news_conflict_name); ?></strong> <?php printf(esc_html__('is also active — its news sitemap settings may conflict with %s\'s.', 'metasync'), esc_html($mss_brand)); ?></span>
602 592 </div>
603 593 <?php endif; ?>
604 594
@@ -779,8 +769,9 @@
779 769 <td>
780 770 <?php
781 771 $tax_scrollable = count($tax_terms) > 10;
782 772 if ($tax_scrollable) : ?>
773 + <?php /* translators: %s: taxonomy name. */ ?>
783 774 <input type="text" class="metasync-checkbox-search" placeholder="<?php echo esc_attr(sprintf(__('Filter %s...', 'metasync'), strtolower($tax->label))); ?>">
784 775 <?php endif; ?>
785 776 <div class="metasync-checkbox-list <?php echo $tax_scrollable ? 'metasync-checkbox-scroll' : ''; ?>">
786 777 <?php foreach ($tax_terms as $term) : ?>
@@ -839,25 +830,68 @@
839 830 <?php
840 831 require_once plugin_dir_path(dirname(__FILE__)) . 'sitemap/class-metasync-sitemap-video.php';
841 832 $video_checker = new Metasync_Sitemap_Video();
842 833 $video_conflicts = $video_checker->get_conflict_notices();
843 - $video_has_content = false !== get_transient('metasync_vsm_' . md5('video-sitemap.xml'))
844 - || file_exists(ABSPATH . 'video-sitemap.xml');
834 + // Reuse the accessor-derived value computed for the status tiles so
835 + // this panel cannot disagree with them, or with the served document.
836 + $video_has_content = $video_sm_exists;
845 837 $video_conflict_name = $video_checker->get_conflict_plugin_name();
846 838 $mss_brand = Metasync::get_effective_plugin_name();
847 839
848 - # Flag a generated-but-empty video sitemap. $video_url_count is already
849 - # computed once near the top of this file for the status card, so reuse it
850 - # rather than re-reading and re-scanning the XML on the same page load.
851 - $video_empty_warning = !empty($video_settings['enabled'])
840 + # Why videos were left out. Recorded by generate_video_sitemap() so the
841 + # notices below can name the actual cause: a post with a video but no
842 + # resolvable thumbnail is skipped (thumbnail_loc is required by Google),
843 + # which is invisible without this.
844 + $video_diagnostics = get_option('metasync_video_sitemap_diagnostics', []);
845 + $video_skipped_no_thumb = isset($video_diagnostics['skipped_no_thumbnail'])
846 + ? (int) $video_diagnostics['skipped_no_thumbnail']
847 + : 0;
848 + $video_skipped_ids = isset($video_diagnostics['skipped_no_thumbnail_ids'])
849 + ? (array) $video_diagnostics['skipped_no_thumbnail_ids']
850 + : [];
851 + # Videos, not posts: a post that emits one working video and drops
852 + # another is invisible to the per-post counter, and that partial case
853 + # is the more common shape on a real catalog.
854 + $video_skipped_videos = isset($video_diagnostics['skipped_no_thumbnail_videos'])
855 + ? (int) $video_diagnostics['skipped_no_thumbnail_videos']
856 + : $video_skipped_no_thumb;
857 + $video_skipped_dupe = isset($video_diagnostics['skipped_duplicate_thumbnail'])
858 + ? (int) $video_diagnostics['skipped_duplicate_thumbnail']
859 + : 0;
860 +
861 + # Common gate: the feature is on, nothing else owns the video sitemap,
862 + # and something has actually been generated to report on.
863 + $video_notices_active = !empty($video_settings['enabled'])
852 864 && empty($video_conflicts)
853 - && $video_has_content
854 - && $video_url_count === 0;
865 + && $video_has_content;
866 +
867 + # Posts whose video was dropped for want of a thumbnail. Deliberately
868 + # NOT gated on an empty sitemap: the common case is a mixed site where
869 + # most videos resolve and a few do not, and gating on $video_url_count
870 + # === 0 would keep exactly that case silent — the silence this notice
871 + # exists to end.
872 + $video_nothumb_notice = $video_notices_active && $video_skipped_videos > 0;
873 +
874 + # A generated-but-empty sitemap with nothing skipped means detection
875 + # found no videos at all, which is a different problem with a different
876 + # fix (post types, or a theme-injected player). $video_url_count is
877 + # already computed near the top of this file for the status card.
878 + $video_no_videos_notice = $video_notices_active
879 + && $video_url_count === 0
880 + && $video_skipped_videos === 0;
881 +
882 + # A post-level image (featured image, OG image, first content image)
883 + # may only be the thumbnail for ONE video on that post: Google treats a
884 + # reused thumbnail as a sign that two videos are the same. Extra videos
885 + # on such a post are left out, which needs saying even when the sitemap
886 + # is otherwise healthy.
887 + $video_dupe_notice = $video_notices_active && $video_skipped_dupe > 0;
855 888 ?>
856 889
857 890 <?php if (!empty($video_conflict_name)): ?>
858 891 <div class="metasync-sitemap-conflict-note" style="display:flex; gap:7px; align-items:center; margin:0 0 16px; padding:8px 12px; border-radius:7px; background:rgba(245,158,11,0.08); border:1px solid rgba(245,158,11,0.28); font-size:12px; line-height:1.5; color:var(--dashboard-text-secondary,#6b7280);">
859 892 <span style="font-size:13px; line-height:1;">&#9888;&#65039;</span>
893 + <?php /* translators: %s: plugin brand name. */ ?>
860 894 <span><strong style="color:#8a5a00;"><?php echo esc_html($video_conflict_name); ?></strong> <?php printf(esc_html__('is also active — its video sitemap settings may conflict with %s\'s.', 'metasync'), esc_html($mss_brand)); ?></span>
861 895 </div>
862 896 <?php endif; ?>
863 897
@@ -914,16 +948,95 @@
914 948 $notice_type = (strpos($notice, 'can coexist') !== false) ? 'notice-info' : 'notice-warning';
915 949 echo '<div class="notice ' . $notice_type . ' inline" style="margin-bottom: 12px; padding: 12px 16px; border-radius: 8px; background: rgba(255, 152, 0, 0.1); border-left: 4px solid var(--dashboard-warning, #f59e0b); color: var(--dashboard-text-primary, #fff);"><p style="margin: 0;">&#9888; ' . esc_html($notice) . '</p></div>';
916 950 } ?>
917 951
918 - <?php if ($video_empty_warning): ?>
952 + <?php if ($video_nothumb_notice): ?>
919 953 <div class="notice notice-warning inline" style="margin-bottom: 12px; padding: 12px 40px 12px 16px; border-radius: 8px; background: rgba(255, 152, 0, 0.1); border-left: 4px solid var(--dashboard-warning, #f59e0b); color: var(--dashboard-text-primary, #fff);">
920 954 <p style="margin: 0;">
921 - &#9888; <?php esc_html_e('The last generated video sitemap contains 0 URLs. A video sitemap only includes posts that contain an embedded video, so this can be normal. If you expected entries here, regenerate it above and review the Post Types and filters below.', 'metasync'); ?>
955 + &#9888;
956 + <?php
957 + printf(
958 + esc_html(
959 + /* translators: %s: number of posts. */
960 + _n(
961 + '%s video was left out because no thumbnail could be resolved for it. Google requires a thumbnail on every video sitemap entry — set a featured image on the post, or fill Thumbnail URL in the Video Sitemap box.',
962 + '%s videos were left out because no thumbnail could be resolved for them. Google requires a thumbnail on every video sitemap entry — set a featured image on those posts, or fill Thumbnail URL in the Video Sitemap box.',
963 + $video_skipped_videos,
964 + 'metasync'
965 + )
966 + ),
967 + esc_html(number_format_i18n($video_skipped_videos))
968 + );
969 + ?>
922 970 </p>
971 + <?php if (!empty($video_skipped_ids)): ?>
972 + <p style="margin: 8px 0 0;">
973 + <?php esc_html_e('Affected posts:', 'metasync'); ?>
974 + <?php
975 + $video_skipped_links = [];
976 + foreach (array_slice($video_skipped_ids, 0, 20) as $skipped_id) {
977 + $skipped_id = (int) $skipped_id;
978 + $skipped_title = get_the_title($skipped_id);
979 + if ($skipped_title === '') {
980 + /* translators: %d: post ID. */
981 + $skipped_title = sprintf(esc_html__('Post %d', 'metasync'), $skipped_id);
982 + }
983 + // Null for a post deleted since the last generation, an
984 + // unregistered post type, or a user without edit_post.
985 + // esc_url(null) both emits a PHP 8.1 deprecation and
986 + // renders an anchor pointing at the current page.
987 + $skipped_link = get_edit_post_link($skipped_id);
988 + if (empty($skipped_link)) {
989 + $video_skipped_links[] = esc_html($skipped_title);
990 + continue;
991 + }
992 + $video_skipped_links[] = '<a href="' . esc_url($skipped_link) . '" target="_blank" style="color: var(--dashboard-accent, #3b82f6);">' . esc_html($skipped_title) . '</a>';
993 + }
994 + echo wp_kses_post(implode(', ', $video_skipped_links));
995 + if ($video_skipped_videos > count($video_skipped_links)) {
996 + echo ' ' . esc_html(
997 + sprintf(
998 + /* translators: %s: number of additional posts. */
999 + __('and %s more.', 'metasync'),
1000 + number_format_i18n($video_skipped_videos - count($video_skipped_links))
1001 + )
1002 + );
1003 + }
1004 + ?>
1005 + </p>
1006 + <?php endif; ?>
923 1007 </div>
924 1008 <?php endif; ?>
925 1009
1010 + <?php if ($video_no_videos_notice): ?>
1011 + <div class="notice notice-warning inline" style="margin-bottom: 12px; padding: 12px 40px 12px 16px; border-radius: 8px; background: rgba(255, 152, 0, 0.1); border-left: 4px solid var(--dashboard-warning, #f59e0b); color: var(--dashboard-text-primary, #fff);">
1012 + <p style="margin: 0;">
1013 + &#9888; <?php esc_html_e('The last generated video sitemap contains 0 URLs, because no videos were found in the selected post types. Check that the right content types are ticked under Post Types below. Note that players injected by a theme or page builder are not visible in post content — if that is your setup, point the plugin at the custom field holding the video with the Video URL Meta Keys setting below.', 'metasync'); ?>
1014 + </p>
1015 + </div>
1016 + <?php endif; ?>
1017 +
1018 + <?php if ($video_dupe_notice): ?>
1019 + <div class="notice notice-info inline" style="margin-bottom: 12px; padding: 12px 40px 12px 16px; border-radius: 8px; background: rgba(59, 130, 246, 0.1); border-left: 4px solid var(--dashboard-accent, #3b82f6); color: var(--dashboard-text-primary, #fff);">
1020 + <p style="margin: 0;">
1021 + <?php
1022 + printf(
1023 + esc_html(
1024 + /* translators: %s: number of videos. */
1025 + _n(
1026 + '%s video was left out because the only thumbnail available was already used by another video on the same post. Google treats a reused thumbnail as a sign that two videos are the same, so every video needs its own image. The Thumbnail URL field and thumbnail custom fields apply to the whole post, so giving each video on one post a distinct thumbnail needs the metasync_video_sitemap_thumbnail filter — or split the videos across separate posts.',
1027 + '%s videos were left out because the only thumbnail available was already used by another video on the same post. Google treats a reused thumbnail as a sign that two videos are the same, so every video needs its own image. The Thumbnail URL field and thumbnail custom fields apply to the whole post, so giving each video on one post a distinct thumbnail needs the metasync_video_sitemap_thumbnail filter — or split the videos across separate posts.',
1028 + $video_skipped_dupe,
1029 + 'metasync'
1030 + )
1031 + ),
1032 + esc_html(number_format_i18n($video_skipped_dupe))
1033 + );
1034 + ?>
1035 + </p>
1036 + </div>
1037 + <?php endif; ?>
1038 +
926 1039 <div class="dashboard-card">
927 1040 <h2><?php esc_html_e('Video Sitemap Settings', 'metasync'); ?></h2>
928 1041 <p style="color: var(--dashboard-text-secondary); margin-bottom: 20px;">
929 1042 <?php esc_html_e('Configure the Video Sitemap. Auto-detects YouTube, Vimeo, VideoPress, and self-hosted videos in your content.', 'metasync'); ?>
@@ -970,11 +1083,25 @@
970 1083 <label>
971 1084 <input type="checkbox" name="auto_detect" value="1" <?php checked(!empty($video_settings['auto_detect'])); ?> />
972 1085 <?php esc_html_e('Automatically detect embedded videos from post content', 'metasync'); ?>
973 1086 </label>
974 - <p class="description"><?php esc_html_e('Detects YouTube, Vimeo, VideoPress, and self-hosted &lt;video&gt; tags.', 'metasync'); ?></p>
1087 + <p class="description"><?php esc_html_e('Detects YouTube, Vimeo, Vimeo OTT (VHX), VideoPress, and self-hosted &lt;video&gt; tags in post content.', 'metasync'); ?></p>
975 1088 </td>
976 1089 </tr>
1090 + <tr>
1091 + <th scope="row"><?php esc_html_e('Video URL Meta Keys', 'metasync'); ?><?php Metasync::render_tooltip_icon('video_sitemap_url_meta_keys', 'For sites whose theme or page builder stores the video in a custom field (ACF, for example) instead of the post content. Enter the custom-field name(s) holding the video URL, one per line. Leave empty if your videos are embedded directly in the content.'); ?></th>
1092 + <td>
1093 + <textarea name="video_url_meta_keys" rows="3" class="large-text code" placeholder="<?php esc_attr_e("my_video_url\nepisode_embed_url", 'metasync'); ?>"><?php echo esc_textarea($video_settings['video_url_meta_keys'] ?? ''); ?></textarea>
1094 + <p class="description"><?php esc_html_e('One custom-field name per line. Use this when the video player is added by your theme or page builder, so the video URL never appears in the post content. Checked in the order listed; the first field with a valid URL wins.', 'metasync'); ?></p>
1095 + </td>
1096 + </tr>
1097 + <tr>
1098 + <th scope="row"><?php esc_html_e('Thumbnail Meta Keys', 'metasync'); ?><?php Metasync::render_tooltip_icon('video_sitemap_thumbnail_meta_keys', 'Custom-field name(s) holding the video thumbnail image URL. Google requires a thumbnail for every video, and entries without one are left out. If empty, the plugin falls back to the post\'s Open Graph image, then its featured image, then the first image in the content.'); ?></th>
1099 + <td>
1100 + <textarea name="video_thumbnail_meta_keys" rows="3" class="large-text code" placeholder="<?php esc_attr_e("my_video_thumbnail\nepisode_poster", 'metasync'); ?>"><?php echo esc_textarea($video_settings['video_thumbnail_meta_keys'] ?? ''); ?></textarea>
1101 + <p class="description"><?php esc_html_e('One custom-field name per line. Falls back to the post\'s Open Graph image, then the featured image, then the first image in the content. Each video needs its own thumbnail — Google treats a reused thumbnail as a sign that two videos are the same.', 'metasync'); ?></p>
1102 + </td>
1103 + </tr>
977 1104 <?php
978 1105 // Taxonomy filters for video sitemap
979 1106 $video_all_taxonomies = get_taxonomies(['public' => true], 'objects');
980 1107 $video_saved_taxonomies = isset($video_settings['taxonomies']) ? (array) $video_settings['taxonomies'] : [];
@@ -992,8 +1119,9 @@
992 1119 <td>
993 1120 <?php
994 1121 $vtax_scrollable = count($tax_terms) > 10;
995 1122 if ($vtax_scrollable) : ?>
1123 + <?php /* translators: %s: taxonomy name. */ ?>
996 1124 <input type="text" class="metasync-checkbox-search" placeholder="<?php echo esc_attr(sprintf(__('Filter %s...', 'metasync'), strtolower($tax->label))); ?>">
997 1125 <?php endif; ?>
998 1126 <div class="metasync-checkbox-list <?php echo $vtax_scrollable ? 'metasync-checkbox-scroll' : ''; ?>">
999 1127 <?php foreach ($tax_terms as $term) : ?>