| @@ -41,9 +41,8 @@ | ||
| 41 | 41 | const SECTION_SEO_CONTROLS = "seo_controls"; |
| 42 | 42 | const SECTION_SEO_CONTROLS_ADVANCED = "seo_controls_advanced"; |
| 43 | 43 | const SECTION_SEO_CONTROLS_INSTANT_INDEX = "seo_controls_instant_index"; |
| 44 | 44 | const SECTION_PLUGIN_VISIBILITY = "plugin_visibility_settings"; |
| 45 | - const SECTION_BREADCRUMBS = "breadcrumbs_settings"; | |
| 46 | 45 | const SECTION_LLMS_TXT = "llms_txt_settings"; |
| 47 | 46 | |
| 48 | 47 | /** |
| 49 | 48 | * The ID of this plugin. |
| @@ -213,9 +212,8 @@ | ||
| 213 | 212 | add_action('admin_menu', array($this, 'add_import_external_data_page')); |
| 214 | 213 | add_action('admin_init', array($this, 'settings_page_init')); |
| 215 | 214 | add_filter('all_plugins', array($this,'metasync_plugin_white_label')); |
| 216 | 215 | add_filter( 'plugin_row_meta',array($this,'metasync_view_detials_url'),10,3); |
| 217 | - add_filter('site_transient_update_plugins', array($this, 'inject_whitelabel_icon_into_update_transient')); | |
| 218 | 216 | |
| 219 | 217 | // Display transient error/success messages for redirections |
| 220 | 218 | add_action('admin_notices', array($this, 'display_redirection_messages')); |
| 221 | 219 | |
| @@ -265,8 +263,15 @@ | ||
| 265 | 263 | |
| 266 | 264 | add_action('admin_init', array($this, 'initialize_cookie')); |
| 267 | 265 | add_action('admin_init', array($this, 'maybe_redirect_to_wizard')); |
| 268 | 266 | |
| 267 | + // The redirect must run on admin_menu, not admin_init: in current | |
| 268 | + // WordPress the unregistered-page access check in wp-admin/includes/ | |
| 269 | + // menu.php fires from wp-admin/menu.php (required at admin.php:163), | |
| 270 | + // which is BEFORE admin_init (admin.php:180). Hooked on admin_init the | |
| 271 | + // redirect never ran — WP died with a 403 first for the removed slug. | |
| 272 | + add_action('admin_menu', array($this, 'redirect_legacy_instant_indexing_page')); | |
| 273 | + | |
| 269 | 274 | // Add admin_post hooks for form submissions (WordPress standard way - no output buffering needed) |
| 270 | 275 | add_action('admin_post_metasync_clear_all_cache_plugins', array($this, 'handle_clear_all_cache_plugins')); |
| 271 | 276 | add_action('admin_post_metasync_clear_otto_cache_all', array($this, 'handle_clear_otto_cache_all')); |
| 272 | 277 | add_action('admin_post_metasync_clear_otto_cache_url', array($this, 'handle_clear_otto_cache_url')); |
| @@ -283,8 +288,11 @@ | ||
| 283 | 288 | |
| 284 | 289 | // Add AJAX for saving execution settings |
| 285 | 290 | add_action( 'wp_ajax_metasync_save_execution_settings', array($this, 'ajax_save_execution_settings') ); |
| 286 | 291 | |
| 292 | + // Add AJAX for saving the Headless Mode demo controls on the Advanced tab | |
| 293 | + add_action( 'wp_ajax_metasync_save_headless_settings', array(Metasync_Settings_Registration::instance(), 'ajax_save_headless_settings') ); | |
| 294 | + | |
| 287 | 295 | // Add AJAX for saving hosting cache settings |
| 288 | 296 | add_action( 'wp_ajax_metasync_save_hosting_cache_settings', array($this, 'ajax_save_hosting_cache_settings') ); |
| 289 | 297 | |
| 290 | 298 | // Add AJAX for saving OTTO Cache TTL |
| @@ -373,8 +381,15 @@ | ||
| 373 | 381 | add_action('wp_ajax_metasync_process_batch_tick', array($this, 'ajax_process_batch_tick')); |
| 374 | 382 | add_action('wp_ajax_metasync_delete_orphaned_image', array($this, 'ajax_delete_orphaned_image')); |
| 375 | 383 | add_action('metasync_media_batch_optimize_cron', array($this, 'handle_media_batch_cron')); |
| 376 | 384 | |
| 385 | + # SEO Restore (Rollback) AJAX & Cron handlers | |
| 386 | + add_action('wp_ajax_metasync_seo_restore_start', array($this, 'ajax_seo_restore_start')); | |
| 387 | + add_action('wp_ajax_metasync_seo_restore_cancel', array($this, 'ajax_seo_restore_cancel')); | |
| 388 | + add_action('wp_ajax_metasync_seo_restore_progress', array($this, 'ajax_seo_restore_progress')); | |
| 389 | + add_action('wp_ajax_metasync_seo_restore_process_tick', array($this, 'ajax_seo_restore_process_tick')); | |
| 390 | + add_action('metasync_seo_restore_cron', array($this, 'handle_seo_restore_cron')); | |
| 391 | + | |
| 377 | 392 | # Add AJAX handlers for Google Instant Indexing |
| 378 | 393 | add_action('wp_ajax_metasync_send_giapi', array($this, 'ajax_send_giapi')); |
| 379 | 394 | |
| 380 | 395 | # Add AJAX handlers for Bing Instant Indexing (IndexNow) |
| @@ -379,11 +394,8 @@ | ||
| 379 | 394 | |
| 380 | 395 | # Add AJAX handlers for Bing Instant Indexing (IndexNow) |
| 381 | 396 | add_action('wp_ajax_metasync_send_bing_indexnow', array($this, 'ajax_send_bing_indexnow')); |
| 382 | 397 | |
| 383 | - # Add hooks for instant indexing settings saves | |
| 384 | - add_action('admin_init', array($this, 'save_instant_indexing_settings')); | |
| 385 | - | |
| 386 | 398 | # Add hooks for instant indexing post actions |
| 387 | 399 | add_filter('post_row_actions', array($this, 'add_instant_indexing_post_actions'), 10, 2); |
| 388 | 400 | add_filter('page_row_actions', array($this, 'add_instant_indexing_post_actions'), 10, 2); |
| 389 | 401 | |
| @@ -488,9 +500,9 @@ | ||
| 488 | 500 | <?php |
| 489 | 501 | } |
| 490 | 502 | |
| 491 | 503 | public function metasync_fouc_prevention_style() { |
| 492 | - if ( ! isset( $_GET['page'] ) || strpos( $_GET['page'], self::$page_slug ) !== 0 ) { | |
| 504 | + if ( ! isset( $_GET['page'] ) || strpos( sanitize_key(wp_unslash($_GET['page'])), self::$page_slug ) !== 0 ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check for an inline style | |
| 493 | 505 | return; |
| 494 | 506 | } |
| 495 | 507 | ?> |
| 496 | 508 | <style> |
| @@ -512,13 +524,13 @@ | ||
| 512 | 524 | <?php |
| 513 | 525 | } |
| 514 | 526 | |
| 515 | 527 | public function suppress_notices_on_wizard_page() { |
| 516 | - if ( ! isset( $_GET['page'] ) ) { | |
| 528 | + if ( ! isset( $_GET['page'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to hide notices for this request | |
| 517 | 529 | return; |
| 518 | 530 | } |
| 519 | 531 | |
| 520 | - $page = sanitize_text_field( wp_unslash( $_GET['page'] ) ); | |
| 532 | + $page = sanitize_key(wp_unslash($_GET['page'])); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only navigation values for a same-site redirect | |
| 521 | 533 | |
| 522 | 534 | // Setup wizard: strip every notice for a fully focused, distraction-free screen. |
| 523 | 535 | if ( strpos( $page, '-setup-wizard' ) !== false ) { |
| 524 | 536 | remove_all_actions( 'admin_notices' ); |
| @@ -636,9 +648,9 @@ | ||
| 636 | 648 | |
| 637 | 649 | #Redirect url to the new slug |
| 638 | 650 | $redirect_url = admin_url('admin.php?page=' . $current_slug); |
| 639 | 651 | |
| 640 | - wp_redirect($redirect_url); | |
| 652 | + wp_safe_redirect($redirect_url); | |
| 641 | 653 | exit; |
| 642 | 654 | } |
| 643 | 655 | } |
| 644 | 656 | |
| @@ -690,13 +702,11 @@ | ||
| 690 | 702 | * @since 1.0.0 |
| 691 | 703 | */ |
| 692 | 704 | public function maybe_redirect_to_wizard() { |
| 693 | 705 | // Only redirect if wizard should be shown |
| 694 | - if (get_option('metasync_show_wizard') && !isset($_GET['page'])) { | |
| 695 | - delete_option('metasync_show_wizard'); | |
| 696 | - | |
| 706 | + if (get_option('metasync_show_wizard') && !isset($_GET['page'])) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- isset() routing check for a redirect to a fixed admin URL | |
| 697 | 707 | // Don't redirect during AJAX, cron, or bulk activation |
| 698 | - if (wp_doing_ajax() || wp_doing_cron() || isset($_GET['activate-multi'])) { | |
| 708 | + if (wp_doing_ajax() || wp_doing_cron() || isset($_GET['activate-multi'])) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- isset() routing check for a redirect to a fixed admin URL | |
| 699 | 709 | return; |
| 700 | 710 | } |
| 701 | 711 | |
| 702 | 712 | // Only redirect if user has access to the plugin |
| @@ -703,16 +713,66 @@ | ||
| 703 | 713 | if (!Metasync::current_user_has_plugin_access()) { |
| 704 | 714 | return; |
| 705 | 715 | } |
| 706 | 716 | |
| 717 | + delete_option('metasync_show_wizard'); | |
| 707 | 718 | wp_safe_redirect(admin_url('admin.php?page=' . self::$page_slug . '-setup-wizard')); |
| 708 | 719 | exit; |
| 709 | 720 | } |
| 710 | 721 | } |
| 711 | 722 | |
| 723 | + /** | |
| 724 | + * Redirect the removed standalone Instant Indexing page to Indexation Control. | |
| 725 | + * | |
| 726 | + * The menu entry is gone, but bookmarks and external links can still target | |
| 727 | + * the old URL. Resolve the current white-label slug rather than assuming | |
| 728 | + * "searchatlas". | |
| 729 | + * | |
| 730 | + * Hooked on admin_menu (see its registration): the unregistered-page 403 in | |
| 731 | + * wp-admin/includes/menu.php fires before admin_init, so any later hook | |
| 732 | + * would be too late to redirect. | |
| 733 | + */ | |
| 734 | + public function redirect_legacy_instant_indexing_page() { | |
| 735 | + if (wp_doing_ajax() || wp_doing_cron() || !is_admin() || !isset($_GET['page'])) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only navigation values for a same-site redirect | |
| 736 | + return; | |
| 737 | + } | |
| 738 | + | |
| 739 | + $page = sanitize_key(wp_unslash($_GET['page'])); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to hide notices for this request | |
| 740 | + $legacy_page = self::$page_slug . '-instant-index'; | |
| 741 | + if ($page !== $legacy_page || !Metasync::current_user_has_plugin_access()) { | |
| 742 | + return; | |
| 743 | + } | |
| 744 | + | |
| 745 | + // Indexation Control is registered only when access control keeps it | |
| 746 | + // visible. Redirecting to it blindly would dead-end on an | |
| 747 | + // unregistered slug (wp_die "Invalid plugin page") for users whose | |
| 748 | + // white-label config hides that page — the exact configs where the | |
| 749 | + // removed standalone page was the feature's only UI. The bare plugin | |
| 750 | + // slug is the floor: its top-level callback resolves to the first | |
| 751 | + // reachable page, so it is always a safe target. | |
| 752 | + if (Metasync_Access_Control::user_can_access('hide_indexation_control')) { | |
| 753 | + $target = admin_url('admin.php?page=' . self::$page_slug . '-seo-controls'); | |
| 754 | + $query = []; | |
| 755 | + foreach (['tab', 'subtab'] as $key) { | |
| 756 | + if (isset($_GET[$key])) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only navigation values for a same-site redirect | |
| 757 | + $query[$key] = sanitize_key(wp_unslash($_GET[$key])); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only navigation values for a same-site redirect | |
| 758 | + } | |
| 759 | + } | |
| 760 | + if (!empty($query)) { | |
| 761 | + $target = add_query_arg($query, $target); | |
| 762 | + } | |
| 763 | + } else { | |
| 764 | + $target = admin_url('admin.php?page=' . self::$page_slug); | |
| 765 | + } | |
| 766 | + | |
| 767 | + wp_safe_redirect($target); | |
| 768 | + exit; | |
| 769 | + } | |
| 770 | + | |
| 712 | 771 | public function metasync_display_error_log() { |
| 713 | 772 | Metasync_Debug_Manager::instance()->metasync_display_error_log($this); |
| 714 | 773 | } |
| 774 | + | |
| 715 | 775 | public function metasync_update_wp_config() { |
| 716 | 776 | Metasync_Debug_Manager::instance()->metasync_update_wp_config(); |
| 717 | 777 | } |
| 718 | 778 | |
| @@ -755,9 +815,9 @@ | ||
| 755 | 815 | ]); |
| 756 | 816 | $_COOKIE['metasync_previous_slug'] = $new_slug; |
| 757 | 817 | // Redirect to the new slug |
| 758 | 818 | $redirect_url = admin_url('admin.php?page=' . $old_slug); |
| 759 | - wp_redirect($redirect_url); | |
| 819 | + wp_safe_redirect($redirect_url); | |
| 760 | 820 | exit; |
| 761 | 821 | }else{ |
| 762 | 822 | self::$page_slug = Metasync::get_option('general')['white_label_plugin_menu_slug']=="" ? "searchatlas":Metasync::get_option('general')['white_label_plugin_menu_slug']; |
| 763 | 823 | $redirect_url = admin_url('admin.php?page=' . self::$page_slug); |
| @@ -763,9 +823,9 @@ | ||
| 763 | 823 | $redirect_url = admin_url('admin.php?page=' . self::$page_slug); |
| 764 | 824 | |
| 765 | 825 | #add redirection for when the old slug is not defined |
| 766 | 826 | #this fixes the redirect issue # |
| 767 | - wp_redirect($redirect_url); | |
| 827 | + wp_safe_redirect($redirect_url); | |
| 768 | 828 | exit; |
| 769 | 829 | } |
| 770 | 830 | } |
| 771 | 831 | public function metasync_view_detials_url( $plugin_meta, $plugin_file, $plugin_data ) { |
| @@ -776,9 +836,10 @@ | ||
| 776 | 836 | if (strpos($meta, 'open-plugin-details-modal') !== false) { |
| 777 | 837 | $meta = sprintf( |
| 778 | 838 | '<a href="%s" class="thickbox open-plugin-details-modal" aria-label="%s" data-title="%s">%s</a>', |
| 779 | 839 | add_query_arg('TB_iframe', 'true', $plugin_uri), |
| 780 | - esc_attr(sprintf(esc_html__('More information about %s'), $plugin_data['Name'])), | |
| 840 | + /* translators: %s: plugin name. */ | |
| 841 | + esc_attr(sprintf(esc_html__('More information about %s', 'metasync'), $plugin_data['Name'])), | |
| 781 | 842 | esc_attr($plugin_data['Name']), |
| 782 | 843 | esc_html__('View details', 'metasync') |
| 783 | 844 | ); |
| 784 | 845 | break; // Exit loop after replacing the link |
| @@ -826,53 +887,8 @@ | ||
| 826 | 887 | return $all_plugins; |
| 827 | 888 | } |
| 828 | 889 | |
| 829 | 890 | /** |
| 830 | - * Inject the whitelabel icon into the update_plugins transient so that | |
| 831 | - * /wp-admin/update-core.php (Dashboard → Updates) shows the WL icon | |
| 832 | - * instead of the SearchAtlas icon returned by the update API. | |
| 833 | - * | |
| 834 | - * @param object $transient The site transient object. | |
| 835 | - * @return object | |
| 836 | - */ | |
| 837 | - public function inject_whitelabel_icon_into_update_transient($transient) { | |
| 838 | - if (empty($transient) || !is_object($transient)) { | |
| 839 | - return $transient; | |
| 840 | - } | |
| 841 | - | |
| 842 | - $general = Metasync::get_option('general'); | |
| 843 | - if (!is_array($general)) { | |
| 844 | - return $transient; | |
| 845 | - } | |
| 846 | - | |
| 847 | - $icon_url = $general['white_label_plugin_menu_icon'] ?? ''; | |
| 848 | - if (empty($icon_url)) { | |
| 849 | - return $transient; | |
| 850 | - } | |
| 851 | - | |
| 852 | - $this_plugin = plugin_basename(dirname(__DIR__) . '/metasync.php'); | |
| 853 | - | |
| 854 | - // Inject into pending updates list | |
| 855 | - if (!empty($transient->response) && isset($transient->response[$this_plugin])) { | |
| 856 | - $transient->response[$this_plugin]->icons = [ | |
| 857 | - '1x' => $icon_url, | |
| 858 | - '2x' => $icon_url, | |
| 859 | - ]; | |
| 860 | - } | |
| 861 | - | |
| 862 | - // Also inject into the "no update needed" list so the icon appears | |
| 863 | - // on the updates screen even when the plugin is up-to-date | |
| 864 | - if (!empty($transient->no_update) && isset($transient->no_update[$this_plugin])) { | |
| 865 | - $transient->no_update[$this_plugin]->icons = [ | |
| 866 | - '1x' => $icon_url, | |
| 867 | - '2x' => $icon_url, | |
| 868 | - ]; | |
| 869 | - } | |
| 870 | - | |
| 871 | - return $transient; | |
| 872 | - } | |
| 873 | - | |
| 874 | - /** | |
| 875 | 891 | * Register the stylesheets for the admin area. |
| 876 | 892 | * |
| 877 | 893 | * @since 1.0.0 |
| 878 | 894 | */ |
| @@ -877,9 +893,9 @@ | ||
| 877 | 893 | * @since 1.0.0 |
| 878 | 894 | */ |
| 879 | 895 | public function enqueue_styles() |
| 880 | 896 | { |
| 881 | - $current_page = isset($_GET['page']) ? sanitize_text_field(wp_unslash($_GET['page'])) : ''; | |
| 897 | + $current_page = isset($_GET['page']) ? sanitize_text_field(wp_unslash($_GET['page'])) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to pick stylesheets | |
| 882 | 898 | |
| 883 | 899 | if (strpos($current_page, self::$page_slug) === 0) { |
| 884 | 900 | wp_enqueue_style( |
| 885 | 901 | $this->plugin_name, |
| @@ -907,10 +923,11 @@ | ||
| 907 | 923 | 'all' |
| 908 | 924 | ); |
| 909 | 925 | } |
| 910 | 926 | |
| 911 | - // Enqueue wizard CSS if on wizard page | |
| 912 | - if (isset($_GET['page']) && strpos($_GET['page'], '-setup-wizard') !== false) { | |
| 927 | + // Enqueue wizard CSS on all MetaSync pages because the reusable consent | |
| 928 | + // card is also displayed inside General Settings. | |
| 929 | + if (strpos($current_page, self::$page_slug) === 0 || (isset($_GET['page']) && strpos(sanitize_key(wp_unslash($_GET['page'])), '-setup-wizard') !== false)) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to pick stylesheets | |
| 913 | 930 | wp_enqueue_style( |
| 914 | 931 | $this->plugin_name . '-setup-wizard', |
| 915 | 932 | plugin_dir_url(__FILE__) . 'css/metasync-setup-wizard.css', |
| 916 | 933 | array($this->plugin_name . '-dashboard'), |
| @@ -919,9 +936,9 @@ | ||
| 919 | 936 | ); |
| 920 | 937 | } |
| 921 | 938 | |
| 922 | 939 | // Enqueue SEO Health CSS if on the SEO Health page |
| 923 | - if (isset($_GET['page']) && strpos($_GET['page'], '-seo-health') !== false) { | |
| 940 | + if (isset($_GET['page']) && strpos(sanitize_key(wp_unslash($_GET['page'])), '-seo-health') !== false) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to pick stylesheets | |
| 924 | 941 | wp_enqueue_style( |
| 925 | 942 | $this->plugin_name . '-seo-health', |
| 926 | 943 | plugin_dir_url(__FILE__) . 'css/metasync-seo-health.css', |
| 927 | 944 | array($this->plugin_name . '-dashboard'), |
| @@ -938,9 +955,9 @@ | ||
| 938 | 955 | */ |
| 939 | 956 | public function enqueue_scripts() |
| 940 | 957 | { |
| 941 | 958 | // --- Phase 5 (#887): Extracted inline JS files --- |
| 942 | - $current_page = isset($_GET['page']) ? sanitize_text_field(wp_unslash($_GET['page'])) : ''; | |
| 959 | + $current_page = isset($_GET['page']) ? sanitize_text_field(wp_unslash($_GET['page'])) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to pick scripts | |
| 943 | 960 | $plugin_root_url = plugin_dir_url(dirname(__FILE__)); |
| 944 | 961 | $is_metasync_page = ($current_page === self::$page_slug || strpos($current_page, self::$page_slug) === 0); |
| 945 | 962 | |
| 946 | 963 | if ($is_metasync_page) { |
| @@ -970,10 +987,49 @@ | ||
| 970 | 987 | array('jquery'), |
| 971 | 988 | $this->version, |
| 972 | 989 | true |
| 973 | 990 | ); |
| 991 | + | |
| 992 | + // Keeps core's admin-menu pinning in step with pages whose height | |
| 993 | + // changes after load. Depends on 'common' so core has bound its | |
| 994 | + // own handlers before this runs. | |
| 995 | + wp_enqueue_script( | |
| 996 | + $this->plugin_name . '-admin-menu-height', | |
| 997 | + plugin_dir_url(__FILE__) . 'js/metasync-admin-menu-height.js', | |
| 998 | + array('jquery', 'common'), | |
| 999 | + $this->version, | |
| 1000 | + true | |
| 1001 | + ); | |
| 974 | 1002 | } |
| 975 | 1003 | |
| 1004 | + $per_page_screens = [ | |
| 1005 | + self::$page_slug . '-redirections', | |
| 1006 | + self::$page_slug . '-404-monitor', | |
| 1007 | + self::$page_slug . '-sync-log', | |
| 1008 | + self::$page_slug . '-media-optimization', | |
| 1009 | + ]; | |
| 1010 | + | |
| 1011 | + if (in_array($current_page, $per_page_screens, true)) { | |
| 1012 | + // Results-per-page selectors use this external handler instead of | |
| 1013 | + // an inline event attribute so changing a page size always reloads | |
| 1014 | + // the current admin page. | |
| 1015 | + wp_enqueue_script( | |
| 1016 | + $this->plugin_name . '-per-page', | |
| 1017 | + plugin_dir_url(__FILE__) . 'js/metasync-per-page.js', | |
| 1018 | + array(), | |
| 1019 | + $this->version, | |
| 1020 | + true | |
| 1021 | + ); | |
| 1022 | + // Selector navigation is a GET, so the per-page nonce rides along | |
| 1023 | + // as a query parameter and gates the user_meta persist in | |
| 1024 | + // Metasync_Per_Page_Helper::resolve(). | |
| 1025 | + wp_localize_script( | |
| 1026 | + $this->plugin_name . '-per-page', | |
| 1027 | + 'metasyncPerPage', | |
| 1028 | + array('nonces' => Metasync_Per_Page_Helper::page_nonces()) | |
| 1029 | + ); | |
| 1030 | + } | |
| 1031 | + | |
| 976 | 1032 | // Dashboard iframe height (only on dashboard page) |
| 977 | 1033 | if ($current_page === self::$page_slug . '-dashboard' || $current_page === self::$page_slug) { |
| 978 | 1034 | wp_enqueue_script( |
| 979 | 1035 | $this->plugin_name . '-iframe', |
| @@ -1022,12 +1078,12 @@ | ||
| 1022 | 1078 | true |
| 1023 | 1079 | ); |
| 1024 | 1080 | // Pass the active tab from server (handles POST redirect) |
| 1025 | 1081 | $sitemap_active_tab = 'general'; |
| 1026 | - if (isset($_GET['tab']) && in_array($_GET['tab'], ['general', 'news', 'video'], true)) { | |
| 1027 | - $sitemap_active_tab = sanitize_text_field(wp_unslash($_GET['tab'])); | |
| 1028 | - } elseif (isset($_POST['redirect_tab']) && in_array($_POST['redirect_tab'], ['general', 'news', 'video'], true)) { | |
| 1029 | - $sitemap_active_tab = sanitize_text_field(wp_unslash($_POST['redirect_tab'])); | |
| 1082 | + if (isset($_GET['tab']) && in_array($_GET['tab'], ['general', 'news', 'video'], true)) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only, allow-listed tab selection for the UI | |
| 1083 | + $sitemap_active_tab = sanitize_text_field(wp_unslash($_GET['tab'])); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only, allow-listed tab selection for the UI | |
| 1084 | + } elseif (isset($_POST['redirect_tab']) && in_array($_POST['redirect_tab'], ['general', 'news', 'video'], true)) { // phpcs:ignore WordPress.Security.NonceVerification.Missing -- read-only, allow-listed tab selection for the UI | |
| 1085 | + $sitemap_active_tab = sanitize_text_field(wp_unslash($_POST['redirect_tab'])); // phpcs:ignore WordPress.Security.NonceVerification.Missing -- read-only, allow-listed tab selection for the UI | |
| 1030 | 1086 | } |
| 1031 | 1087 | wp_localize_script($this->plugin_name . '-sitemap-tabs', 'metasyncSitemapTabs', [ |
| 1032 | 1088 | 'activeTab' => $sitemap_active_tab, |
| 1033 | 1089 | ]); |
| @@ -1355,8 +1411,10 @@ | ||
| 1355 | 1411 | 'nonce' => wp_create_nonce('metasync_nonce'), |
| 1356 | 1412 | 'sa_connect_nonce' => $sa_connect_nonce, |
| 1357 | 1413 | 'reset_auth_nonce' => wp_create_nonce('metasync_reset_auth_nonce'), |
| 1358 | 1414 | 'burst_ping_nonce' => wp_create_nonce('metasync_burst_ping'), |
| 1415 | + 'clear_otto_cache_nonce' => wp_create_nonce('metasync_clear_otto_cache'), | |
| 1416 | + 'lglogin_nonce' => wp_create_nonce('metasync_lglogin'), | |
| 1359 | 1417 | 'heartbeat_state' => $heartbeat_state, |
| 1360 | 1418 | 'dashboard_domain' => self::get_effective_dashboard_domain(), |
| 1361 | 1419 | 'support_email' => Metasync::SUPPORT_EMAIL, |
| 1362 | 1420 | 'documentation_domain' => Metasync::DOCUMENTATION_DOMAIN, |
| @@ -1420,9 +1478,9 @@ | ||
| 1420 | 1478 | add_action('admin_notices', array($this, 'display_page_builder_notice')); |
| 1421 | 1479 | // Display update warning banner if plugin update is available |
| 1422 | 1480 | add_action('admin_notices', array($this, 'display_update_warning_banner')); |
| 1423 | 1481 | // Enqueue wizard assets if on wizard page |
| 1424 | - if (isset($_GET['page']) && strpos($_GET['page'], '-setup-wizard') !== false) { | |
| 1482 | + if (isset($_GET['page']) && strpos(sanitize_key(wp_unslash($_GET['page'])), '-setup-wizard') !== false) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only page check to pick scripts | |
| 1425 | 1483 | wp_enqueue_script( |
| 1426 | 1484 | $this->plugin_name . '-setup-wizard', |
| 1427 | 1485 | plugin_dir_url(__FILE__) . 'js/metasync-setup-wizard.js', |
| 1428 | 1486 | array('jquery'), |
| @@ -1446,14 +1504,44 @@ | ||
| 1446 | 1504 | } |
| 1447 | 1505 | |
| 1448 | 1506 | /** |
| 1449 | 1507 | * Settings of HeartBeat API for admin area. |
| 1450 | - * Set time interval of send request. | |
| 1508 | + * | |
| 1509 | + * The only thing the plugin rides the beat for is a periodic admin | |
| 1510 | + * telemetry ping (the `heartbeat-send` handler in admin/js/metasync-admin.js), | |
| 1511 | + * so it slows the beat down rather than speeding it up. Two contexts are | |
| 1512 | + * left on whatever core decided, because core leans on the beat there: | |
| 1513 | + * | |
| 1514 | + * - The front end, where the beat drives wp-auth-check — the "your session | |
| 1515 | + * has expired, log in again" prompt. | |
| 1516 | + * - The editor screens, where each tick renews the post lock. A lock only | |
| 1517 | + * lives for wp_check_post_lock_window() seconds (150 by default), so any | |
| 1518 | + * interval longer than that drops the lock between beats and lets a | |
| 1519 | + * second editor silently take over a post someone still has open. | |
| 1520 | + * | |
| 1521 | + * Core clamps this to 1-3600 seconds in wp-includes/js/heartbeat.js, so an | |
| 1522 | + * over-long interval is not corrected on our behalf. | |
| 1523 | + * | |
| 1524 | + * @param array $settings Heartbeat settings array. | |
| 1525 | + * @return array Heartbeat settings array. | |
| 1451 | 1526 | */ |
| 1452 | 1527 | function metasync_heartbeat_settings($settings) |
| 1453 | 1528 | { |
| 1454 | - global $heartbeat_frequency; | |
| 1455 | - $settings['interval'] = 300; | |
| 1529 | + if (!is_admin()) { | |
| 1530 | + return $settings; | |
| 1531 | + } | |
| 1532 | + | |
| 1533 | + # $pagenow is set in wp-includes/vars.php, long before this filter runs; | |
| 1534 | + # core's own wp_heartbeat_set_suspension() reads it exactly this way. | |
| 1535 | + global $pagenow; | |
| 1536 | + $lock_dependent_screens = array('post.php', 'post-new.php', 'customize.php'); | |
| 1537 | + if (isset($pagenow) && in_array($pagenow, $lock_dependent_screens, true)) { | |
| 1538 | + return $settings; | |
| 1539 | + } | |
| 1540 | + | |
| 1541 | + # 60s matches heartbeat.js's own default and stays well inside the | |
| 1542 | + # 150s post-lock window, so nothing core does can fall through a gap. | |
| 1543 | + $settings['interval'] = 60; | |
| 1456 | 1544 | return $settings; |
| 1457 | 1545 | } |
| 1458 | 1546 | |
| 1459 | 1547 | /** |
| @@ -1591,13 +1679,8 @@ | ||
| 1591 | 1679 | { |
| 1592 | 1680 | Metasync_Connect_Manager::instance()->test_searchatlas_ajax_endpoint(); |
| 1593 | 1681 | } |
| 1594 | 1682 | |
| 1595 | - public function simple_ajax_test() | |
| 1596 | - { | |
| 1597 | - Metasync_Connect_Manager::instance()->simple_ajax_test(); | |
| 1598 | - } | |
| 1599 | - | |
| 1600 | 1683 | /** |
| 1601 | 1684 | * Create Admin Dashboard Iframe Page |
| 1602 | 1685 | * Embeds the Search Atlas dashboard directly in WordPress admin |
| 1603 | 1686 | */ |
| @@ -1626,9 +1709,9 @@ | ||
| 1626 | 1709 | <!-- OTTO Cache TTL Setting --> |
| 1627 | 1710 | <div style="margin-bottom: 30px; padding-top: 20px;"> |
| 1628 | 1711 | <h4 style="margin-top: 0; color: var(--dashboard-text-primary);"><?php echo esc_html(Metasync::get_whitelabel_otto_name()); ?> Cache TTL</h4> |
| 1629 | 1712 | <p style="margin-bottom: 15px; color: var(--dashboard-text-secondary);"> |
| 1630 | - Configure how long <?php echo esc_html(Metasync::get_whitelabel_otto_name()); ?> API suggestions are cached before a fresh API call. Stale cache expires at 2× this value. | |
| 1713 | + Configure how long <?php echo esc_html(Metasync::get_whitelabel_otto_name()); ?> API suggestions are cached before a fresh API call. The stale fallback expires after 12 hours. | |
| 1631 | 1714 | </p> |
| 1632 | 1715 | |
| 1633 | 1716 | <div style="background: rgba(255,255,255,0.02); border: 1px solid var(--dashboard-border); border-radius: 8px; padding: 20px; margin-bottom: 20px;"> |
| 1634 | 1717 | <div style="display: flex; align-items: center; gap: 10px; margin-bottom: 12px;"> |
| @@ -1684,9 +1767,9 @@ | ||
| 1684 | 1767 | } else { |
| 1685 | 1768 | echo '<p style="color: var(--dashboard-text-secondary);">ℹ️ No cache plugins detected.</p>'; |
| 1686 | 1769 | } |
| 1687 | 1770 | } catch (Exception $e) { |
| 1688 | - error_log('MetaSync Cache Status Error: ' . $e->getMessage()); | |
| 1771 | + error_log('MetaSync Cache Status Error: ' . $e->getMessage()); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 1689 | 1772 | echo '<p style="color: var(--dashboard-error);">⚠️ An error occurred while retrieving cache plugin status.</p>'; |
| 1690 | 1773 | } |
| 1691 | 1774 | } else { |
| 1692 | 1775 | echo '<p style="color: var(--dashboard-error);">⚠️ Cache Purge class not loaded.</p>'; |
| @@ -1703,12 +1786,12 @@ | ||
| 1703 | 1786 | </form> |
| 1704 | 1787 | |
| 1705 | 1788 | <?php |
| 1706 | 1789 | // Display success/error messages |
| 1707 | - if (isset($_GET['cache_cleared']) && $_GET['cache_cleared'] == '1') { | |
| 1708 | - $cleared = isset($_GET['cleared']) ? intval($_GET['cleared']) : 0; | |
| 1709 | - $failed = isset($_GET['failed']) ? intval($_GET['failed']) : 0; | |
| 1710 | - $plugins = isset($_GET['plugins']) ? sanitize_text_field(wp_unslash($_GET['plugins'])) : ''; | |
| 1790 | + if (isset($_GET['cache_cleared']) && $_GET['cache_cleared'] == '1') { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1791 | + $cleared = isset($_GET['cleared']) ? intval($_GET['cleared']) : 0; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1792 | + $failed = isset($_GET['failed']) ? intval($_GET['failed']) : 0; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1793 | + $plugins = isset($_GET['plugins']) ? sanitize_text_field(wp_unslash($_GET['plugins'])) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1711 | 1794 | |
| 1712 | 1795 | if ($cleared > 0) { |
| 1713 | 1796 | echo '<div class="notice notice-success inline" style="margin-top: 15px;"><p>'; |
| 1714 | 1797 | echo '✅ <strong>Success!</strong> Cleared cache for ' . intval( $cleared ) . ' plugin(s)'; |
| @@ -1728,10 +1811,10 @@ | ||
| 1728 | 1811 | echo '</p></div>'; |
| 1729 | 1812 | } |
| 1730 | 1813 | } |
| 1731 | 1814 | |
| 1732 | - if (isset($_GET['cache_error']) && $_GET['cache_error'] == '1') { | |
| 1733 | - $message = isset($_GET['message']) ? urldecode(sanitize_text_field(wp_unslash($_GET['message']))) : ''; | |
| 1815 | + if (isset($_GET['cache_error']) && $_GET['cache_error'] == '1') { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1816 | + $message = isset($_GET['message']) ? urldecode(sanitize_text_field(wp_unslash($_GET['message']))) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1734 | 1817 | if (empty($message)) { |
| 1735 | 1818 | $message = 'An unknown error occurred while clearing cache. Please check error logs for details.'; |
| 1736 | 1819 | } |
| 1737 | 1820 | echo '<div class="notice notice-error inline" style="margin-top: 15px;"><p>'; |
| @@ -1828,12 +1911,13 @@ | ||
| 1828 | 1911 | </form> |
| 1829 | 1912 | |
| 1830 | 1913 | <?php |
| 1831 | 1914 | // Hosting cache result messages |
| 1832 | - if (isset($_GET['hosting_cache_cleared']) && $_GET['hosting_cache_cleared'] == '1') { | |
| 1833 | - $hc_cleared = isset($_GET['hc_cleared']) ? sanitize_text_field(urldecode($_GET['hc_cleared'])) : ''; | |
| 1834 | - $hc_failed = isset($_GET['hc_failed']) ? sanitize_text_field(urldecode($_GET['hc_failed'])) : ''; | |
| 1835 | - $hc_not_detected = isset($_GET['hc_not_detected']) ? sanitize_text_field(urldecode($_GET['hc_not_detected'])) : ''; | |
| 1915 | + if (isset($_GET['hosting_cache_cleared']) && $_GET['hosting_cache_cleared'] == '1') { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1916 | + // phpcs:disable WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- each value is unslashed and sanitized on the following assignments. | |
| 1917 | + $hc_cleared = isset($_GET['hc_cleared']) ? sanitize_text_field(urldecode(wp_unslash($_GET['hc_cleared']))) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1918 | + $hc_failed = isset($_GET['hc_failed']) ? sanitize_text_field(urldecode(wp_unslash($_GET['hc_failed']))) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1919 | + $hc_not_detected = isset($_GET['hc_not_detected']) ? sanitize_text_field(urldecode(wp_unslash($_GET['hc_not_detected']))) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only result notice after a nonce-checked purge | |
| 1836 | 1920 | |
| 1837 | 1921 | if ($hc_cleared) { |
| 1838 | 1922 | echo '<div class="notice notice-success inline" style="margin-top: 15px;"><p>'; |
| 1839 | 1923 | echo '✅ <strong>Success!</strong> Purged hosting cache on: ' . esc_html($hc_cleared); |
| @@ -1848,8 +1932,9 @@ | ||
| 1848 | 1932 | echo '<div class="notice notice-info inline" style="margin-top: 10px;"><p>'; |
| 1849 | 1933 | echo 'ℹ️ No enabled hosting providers were detected on this server (' . esc_html($hc_not_detected) . ').'; |
| 1850 | 1934 | echo '</p></div>'; |
| 1851 | 1935 | } |
| 1936 | + // phpcs:enable WordPress.Security.ValidatedSanitizedInput.InputNotSanitized | |
| 1852 | 1937 | } |
| 1853 | 1938 | ?> |
| 1854 | 1939 | |
| 1855 | 1940 | <script> |
| @@ -2014,11 +2099,11 @@ | ||
| 2014 | 2099 | </div> |
| 2015 | 2100 | |
| 2016 | 2101 | <?php |
| 2017 | 2102 | // Display success/error messages |
| 2018 | - if (isset($_GET['otto_cache_cleared']) && $_GET['otto_cache_cleared'] == '1') { | |
| 2019 | - $cleared_count = isset($_GET['count']) ? intval($_GET['count']) : 0; | |
| 2020 | - $url = isset($_GET['url']) ? urldecode(sanitize_text_field(wp_unslash($_GET['url']))) : ''; | |
| 2103 | + if (isset($_GET['otto_cache_cleared']) && $_GET['otto_cache_cleared'] == '1') { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only notice or prefill, the form submit carries a nonce | |
| 2104 | + $cleared_count = isset($_GET['count']) ? intval($_GET['count']) : 0; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only notice or prefill, the form submit carries a nonce | |
| 2105 | + $url = isset($_GET['url']) ? urldecode(sanitize_text_field(wp_unslash($_GET['url']))) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only notice or prefill, the form submit carries a nonce | |
| 2021 | 2106 | |
| 2022 | 2107 | echo '<div class="notice notice-success inline" style="margin-top: 15px;"><p>'; |
| 2023 | 2108 | if (!empty($url)) { |
| 2024 | 2109 | echo '✅ <strong>Success!</strong> Cleared cache for URL: <code>' . esc_html($url) . '</code> (' . intval( $cleared_count ) . ' entries)'; |
| @@ -2027,10 +2112,10 @@ | ||
| 2027 | 2112 | } |
| 2028 | 2113 | echo '</p></div>'; |
| 2029 | 2114 | } |
| 2030 | 2115 | |
| 2031 | - if (isset($_GET['otto_cache_error']) && $_GET['otto_cache_error'] == '1') { | |
| 2032 | - $message = isset($_GET['message']) ? urldecode(sanitize_text_field(wp_unslash($_GET['message']))) : 'An unknown error occurred.'; | |
| 2116 | + if (isset($_GET['otto_cache_error']) && $_GET['otto_cache_error'] == '1') { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only notice or prefill, the form submit carries a nonce | |
| 2117 | + $message = isset($_GET['message']) ? urldecode(sanitize_text_field(wp_unslash($_GET['message']))) : 'An unknown error occurred.'; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only notice or prefill, the form submit carries a nonce | |
| 2033 | 2118 | echo '<div class="notice notice-error inline" style="margin-top: 15px;"><p>'; |
| 2034 | 2119 | echo '❌ <strong>Error:</strong> ' . esc_html($message); |
| 2035 | 2120 | echo '</p></div>'; |
| 2036 | 2121 | } |
| @@ -2069,9 +2154,9 @@ | ||
| 2069 | 2154 | <td> |
| 2070 | 2155 | <input type="url" |
| 2071 | 2156 | id="otto_cache_url" |
| 2072 | 2157 | name="otto_cache_url" |
| 2073 | - value="<?php echo isset($_GET['url']) ? esc_attr(urldecode(sanitize_text_field(wp_unslash($_GET['url'])))) : ''; ?>" | |
| 2158 | + value="<?php echo isset($_GET['url']) ? esc_attr(urldecode(sanitize_text_field(wp_unslash($_GET['url'])))) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only notice or prefill, the form submit carries a nonce ?>" | |
| 2074 | 2159 | class="regular-text" |
| 2075 | 2160 | placeholder="https://example.com/page/" |
| 2076 | 2161 | required /> |
| 2077 | 2162 | <p class="description" style="color: var(--dashboard-text-secondary);">Enter the full URL of the page whose cache you want to clear.</p> |
| @@ -2142,9 +2227,10 @@ | ||
| 2142 | 2227 | /** |
| 2143 | 2228 | * AJAX handler for saving hosting cache settings |
| 2144 | 2229 | */ |
| 2145 | 2230 | public function ajax_save_hosting_cache_settings() { |
| 2146 | - if (!isset($_POST['hosting_cache_nonce']) || !wp_verify_nonce($_POST['hosting_cache_nonce'], 'metasync_hosting_cache_nonce')) { | |
| 2231 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 2232 | + if (!isset($_POST['hosting_cache_nonce']) || !wp_verify_nonce(wp_unslash($_POST['hosting_cache_nonce']), 'metasync_hosting_cache_nonce')) { | |
| 2147 | 2233 | wp_send_json_error(array('message' => 'Security check failed')); |
| 2148 | 2234 | return; |
| 2149 | 2235 | } |
| 2150 | 2236 | |
| @@ -2165,9 +2251,10 @@ | ||
| 2165 | 2251 | /** |
| 2166 | 2252 | * AJAX handler: save object cache behaviour settings |
| 2167 | 2253 | */ |
| 2168 | 2254 | public function ajax_save_object_cache_settings() { |
| 2169 | - if (!isset($_POST['object_cache_nonce']) || !wp_verify_nonce($_POST['object_cache_nonce'], 'metasync_object_cache_nonce')) { | |
| 2255 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 2256 | + if (!isset($_POST['object_cache_nonce']) || !wp_verify_nonce(wp_unslash($_POST['object_cache_nonce']), 'metasync_object_cache_nonce')) { | |
| 2170 | 2257 | wp_send_json_error(array('message' => 'Security check failed')); |
| 2171 | 2258 | return; |
| 2172 | 2259 | } |
| 2173 | 2260 | |
| @@ -2194,9 +2281,10 @@ | ||
| 2194 | 2281 | /** |
| 2195 | 2282 | * AJAX handler for saving OTTO Cache TTL |
| 2196 | 2283 | */ |
| 2197 | 2284 | public function ajax_save_otto_cache_ttl() { |
| 2198 | - if (!isset($_POST['otto_cache_ttl_nonce']) || !wp_verify_nonce($_POST['otto_cache_ttl_nonce'], 'metasync_otto_cache_ttl_nonce')) { | |
| 2285 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 2286 | + if (!isset($_POST['otto_cache_ttl_nonce']) || !wp_verify_nonce(wp_unslash($_POST['otto_cache_ttl_nonce']), 'metasync_otto_cache_ttl_nonce')) { | |
| 2199 | 2287 | wp_send_json_error(array('message' => 'Security check failed.')); |
| 2200 | 2288 | return; |
| 2201 | 2289 | } |
| 2202 | 2290 | |
| @@ -2222,9 +2310,10 @@ | ||
| 2222 | 2310 | /** |
| 2223 | 2311 | * admin_post handler: purge WP Engine and Kinsta hosting-level caches |
| 2224 | 2312 | */ |
| 2225 | 2313 | public function handle_purge_hosting_cache() { |
| 2226 | - if (!isset($_POST['hosting_cache_purge_nonce']) || !wp_verify_nonce($_POST['hosting_cache_purge_nonce'], 'metasync_hosting_cache_purge_nonce')) { | |
| 2314 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 2315 | + if (!isset($_POST['hosting_cache_purge_nonce']) || !wp_verify_nonce(wp_unslash($_POST['hosting_cache_purge_nonce']), 'metasync_hosting_cache_purge_nonce')) { | |
| 2227 | 2316 | wp_die('Security check failed'); |
| 2228 | 2317 | } |
| 2229 | 2318 | |
| 2230 | 2319 | if (!Metasync::current_user_has_plugin_access()) { |
| @@ -2244,9 +2333,9 @@ | ||
| 2244 | 2333 | WpeCommon::purge_varnish_cache(); |
| 2245 | 2334 | WpeCommon::purge_memcached(); |
| 2246 | 2335 | $cleared[] = 'WP Engine'; |
| 2247 | 2336 | } catch (Exception $e) { |
| 2248 | - error_log('MetaSync: WP Engine hosting cache purge failed - ' . $e->getMessage()); | |
| 2337 | + error_log('MetaSync: WP Engine hosting cache purge failed - ' . $e->getMessage()); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 2249 | 2338 | $failed[] = 'WP Engine'; |
| 2250 | 2339 | } |
| 2251 | 2340 | } else { |
| 2252 | 2341 | $not_detected[] = 'WP Engine'; |
| @@ -2259,9 +2348,9 @@ | ||
| 2259 | 2348 | try { |
| 2260 | 2349 | KinstaCache::get_instance()->kinsta_cache_purge_full(); |
| 2261 | 2350 | $cleared[] = 'Kinsta'; |
| 2262 | 2351 | } catch (Exception $e) { |
| 2263 | - error_log('MetaSync: Kinsta hosting cache purge failed - ' . $e->getMessage()); | |
| 2352 | + error_log('MetaSync: Kinsta hosting cache purge failed - ' . $e->getMessage()); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 2264 | 2353 | $failed[] = 'Kinsta'; |
| 2265 | 2354 | } |
| 2266 | 2355 | } else { |
| 2267 | 2356 | $not_detected[] = 'Kinsta'; |
| @@ -2656,9 +2745,9 @@ | ||
| 2656 | 2745 | # Initialize MetaSync API request class and trigger synchronization |
| 2657 | 2746 | (new Metasync_Sync_Requests())->SyncCustomerParams(); |
| 2658 | 2747 | } catch (Exception $e) { |
| 2659 | 2748 | # Log any API request errors for debugging |
| 2660 | - error_log('Metasync API Error: ' . $e->getMessage()); | |
| 2749 | + error_log('Metasync API Error: ' . $e->getMessage()); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 2661 | 2750 | } |
| 2662 | 2751 | } |
| 2663 | 2752 | |
| 2664 | 2753 | /* |
| @@ -2673,9 +2762,9 @@ | ||
| 2673 | 2762 | # Initialize MetaSync API request class and trigger synchronization |
| 2674 | 2763 | (new Metasync_Sync_Requests())->SyncCustomerParams(); |
| 2675 | 2764 | } catch (Exception $e) { |
| 2676 | 2765 | # Log any API request errors for debugging |
| 2677 | - error_log('Metasync API Error: ' . $e->getMessage()); | |
| 2766 | + error_log('Metasync API Error: ' . $e->getMessage()); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 2678 | 2767 | } |
| 2679 | 2768 | } |
| 2680 | 2769 | |
| 2681 | 2770 | /** |
| @@ -2708,8 +2797,15 @@ | ||
| 2708 | 2797 | // Handle form submissions |
| 2709 | 2798 | if (isset($_POST['metasync_media_optimization_nonce'])) { |
| 2710 | 2799 | check_admin_referer('metasync_save_media_optimization', 'metasync_media_optimization_nonce'); |
| 2711 | 2800 | |
| 2801 | + // Settings shape the whole site's conversion pipeline — restrict | |
| 2802 | + // the save (and the reset) to site admins, not just anyone who can | |
| 2803 | + // open the page via plugin_access_roles. | |
| 2804 | + if (!current_user_can('manage_options')) { | |
| 2805 | + wp_die(esc_html__('Sorry, you are not allowed to manage media optimization settings.', 'metasync')); | |
| 2806 | + } | |
| 2807 | + | |
| 2712 | 2808 | // Handle reset to defaults |
| 2713 | 2809 | if (!empty($_POST['metasync_media_reset'])) { |
| 2714 | 2810 | $defaults = Metasync_Media_Settings::get_defaults(); |
| 2715 | 2811 | Metasync_Media_Settings::save_settings($defaults); |
| @@ -2714,8 +2810,9 @@ | ||
| 2714 | 2810 | $defaults = Metasync_Media_Settings::get_defaults(); |
| 2715 | 2811 | Metasync_Media_Settings::save_settings($defaults); |
| 2716 | 2812 | $save_success = true; |
| 2717 | 2813 | } elseif (isset($_POST['metasync_media'])) { |
| 2814 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- validated and sanitised by Metasync_Media_Settings::save_settings(). | |
| 2718 | 2815 | $input = wp_unslash($_POST['metasync_media']); |
| 2719 | 2816 | Metasync_Media_Settings::save_settings($input); |
| 2720 | 2817 | $save_success = true; |
| 2721 | 2818 | } |
| @@ -2747,8 +2844,15 @@ | ||
| 2747 | 2844 | * Code Minification page callback |
| 2748 | 2845 | */ |
| 2749 | 2846 | public function create_admin_code_minification_page() |
| 2750 | 2847 | { |
| 2848 | + // Settings shape the whole site's asset pipeline — restrict | |
| 2849 | + // the save (and the reset) to site admins, not just anyone who can | |
| 2850 | + // open the page via plugin_access_roles. | |
| 2851 | + if (!empty($_POST) && !current_user_can('manage_options')) { | |
| 2852 | + wp_die(esc_html__('Sorry, you are not allowed to manage code minification settings.', 'metasync')); | |
| 2853 | + } | |
| 2854 | + | |
| 2751 | 2855 | $this->render_layout_open('Code Minification', 'code_minification', 'Minify CSS, JavaScript, and HTML to improve performance.'); |
| 2752 | 2856 | // Load settings and compatibility classes |
| 2753 | 2857 | require_once plugin_dir_path(dirname(__FILE__)) . 'code-minification/class-minification-settings.php'; |
| 2754 | 2858 | require_once plugin_dir_path(dirname(__FILE__)) . 'code-minification/class-minification-cache.php'; |
| @@ -2765,8 +2869,9 @@ | ||
| 2765 | 2869 | $defaults = Metasync_Minification_Settings::get_defaults(); |
| 2766 | 2870 | Metasync_Minification_Settings::save_settings($defaults); |
| 2767 | 2871 | $save_success = true; |
| 2768 | 2872 | } elseif (isset($_POST['metasync_code_min'])) { |
| 2873 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- validated and sanitised by Metasync_Minification_Settings::save_settings(). | |
| 2769 | 2874 | $input = (array) wp_unslash($_POST['metasync_code_min']); |
| 2770 | 2875 | Metasync_Minification_Settings::save_settings($input); |
| 2771 | 2876 | $save_success = true; |
| 2772 | 2877 | } |
| @@ -2799,8 +2904,15 @@ | ||
| 2799 | 2904 | if (!$attachment_id) { |
| 2800 | 2905 | wp_send_json_error(__('Invalid attachment ID.', 'metasync')); |
| 2801 | 2906 | } |
| 2802 | 2907 | |
| 2908 | + // Ownership: under the replace strategy this permanently deletes the | |
| 2909 | + // attachment's original file, so upload_files alone is not enough — | |
| 2910 | + // the caller must be allowed to edit this specific attachment. | |
| 2911 | + if (!current_user_can('edit_post', $attachment_id)) { | |
| 2912 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 2913 | + } | |
| 2914 | + | |
| 2803 | 2915 | require_once plugin_dir_path(dirname(__FILE__)) . 'media-optimization/class-media-settings.php'; |
| 2804 | 2916 | require_once plugin_dir_path(dirname(__FILE__)) . 'media-optimization/class-image-converter.php'; |
| 2805 | 2917 | $settings = Metasync_Media_Settings::get_settings(); |
| 2806 | 2918 | |
| @@ -2814,8 +2926,9 @@ | ||
| 2814 | 2926 | $max_bytes = 10 * 1024 * 1024; |
| 2815 | 2927 | if (filesize($file) > $max_bytes) { |
| 2816 | 2928 | $size_mb = round(filesize($file) / 1024 / 1024, 1); |
| 2817 | 2929 | wp_send_json_error(sprintf( |
| 2930 | + /* translators: %s: file size in megabytes. */ | |
| 2818 | 2931 | __('Optimization skipped: file size (%s MB) exceeds the 10 MB safety limit to prevent memory issues.', 'metasync'), |
| 2819 | 2932 | $size_mb |
| 2820 | 2933 | )); |
| 2821 | 2934 | } |
| @@ -2852,8 +2965,14 @@ | ||
| 2852 | 2965 | if (!$attachment_id) { |
| 2853 | 2966 | wp_send_json_error(__('Invalid attachment ID.', 'metasync')); |
| 2854 | 2967 | } |
| 2855 | 2968 | |
| 2969 | + // Ownership: reverting deletes the attachment's converted files, so | |
| 2970 | + // restrict it to users who may edit this specific attachment. | |
| 2971 | + if (!current_user_can('edit_post', $attachment_id)) { | |
| 2972 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 2973 | + } | |
| 2974 | + | |
| 2856 | 2975 | // Replace-strategy conversions have no original to restore — reverting |
| 2857 | 2976 | // would delete the attachment's only file. Refuse up front, like bulk revert does. |
| 2858 | 2977 | if (!Metasync_Image_Converter::can_revert($attachment_id)) { |
| 2859 | 2978 | wp_send_json_error(__('This image cannot be reverted. The original file no longer exists (replace strategy).', 'metasync')); |
| @@ -2911,8 +3030,15 @@ | ||
| 2911 | 3030 | public function ajax_batch_progress() |
| 2912 | 3031 | { |
| 2913 | 3032 | check_ajax_referer('metasync_media_opt_nonce', 'nonce'); |
| 2914 | 3033 | |
| 3034 | + // Read-only progress/stats polling — the same capability that can | |
| 3035 | + // open the media optimization page is enough, but a nonce alone | |
| 3036 | + // never was. | |
| 3037 | + if (!current_user_can('upload_files')) { | |
| 3038 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 3039 | + } | |
| 3040 | + | |
| 2915 | 3041 | require_once plugin_dir_path(dirname(__FILE__)) . 'media-optimization/class-media-batch-optimizer.php'; |
| 2916 | 3042 | require_once plugin_dir_path(dirname(__FILE__)) . 'media-optimization/class-media-library-list-table.php'; |
| 2917 | 3043 | |
| 2918 | 3044 | $progress = Metasync_Media_Batch_Optimizer::get_progress(); |
| @@ -2943,10 +3069,19 @@ | ||
| 2943 | 3069 | $settings = Metasync_Media_Settings::get_settings(); |
| 2944 | 3070 | |
| 2945 | 3071 | $success = 0; |
| 2946 | 3072 | $failed = 0; |
| 3073 | + $denied = 0; | |
| 2947 | 3074 | |
| 2948 | 3075 | foreach ($ids as $id) { |
| 3076 | + // Per-attachment ownership: replace mode deletes originals, so | |
| 3077 | + // upload_files alone must not allow converting images the caller | |
| 3078 | + // does not own/cannot edit. | |
| 3079 | + if (!current_user_can('edit_post', $id)) { | |
| 3080 | + $denied++; | |
| 3081 | + continue; | |
| 3082 | + } | |
| 3083 | + | |
| 2949 | 3084 | if (Metasync_Image_Converter::convert_attachment($id, $settings)) { |
| 2950 | 3085 | $success++; |
| 2951 | 3086 | } else { |
| 2952 | 3087 | $failed++; |
| @@ -2955,8 +3090,9 @@ | ||
| 2955 | 3090 | |
| 2956 | 3091 | wp_send_json_success([ |
| 2957 | 3092 | 'success' => $success, |
| 2958 | 3093 | 'failed' => $failed, |
| 3094 | + 'denied' => $denied, | |
| 2959 | 3095 | ]); |
| 2960 | 3096 | } |
| 2961 | 3097 | |
| 2962 | 3098 | /** |
| @@ -2979,11 +3115,19 @@ | ||
| 2979 | 3115 | |
| 2980 | 3116 | $success = 0; |
| 2981 | 3117 | $failed = 0; |
| 2982 | 3118 | $skipped = 0; |
| 3119 | + $denied = 0; | |
| 2983 | 3120 | $errors = []; |
| 2984 | 3121 | |
| 2985 | 3122 | foreach ($ids as $id) { |
| 3123 | + // Per-attachment ownership: reverting deletes the attachment's | |
| 3124 | + // converted files, so restrict it per image, not per role. | |
| 3125 | + if (!current_user_can('edit_post', $id)) { | |
| 3126 | + $denied++; | |
| 3127 | + continue; | |
| 3128 | + } | |
| 3129 | + | |
| 2986 | 3130 | $format = get_post_meta($id, '_metasync_converted_format', true); |
| 2987 | 3131 | |
| 2988 | 3132 | if (!$format) { |
| 2989 | 3133 | $skipped++; |
| @@ -2993,8 +3137,9 @@ | ||
| 2993 | 3137 | if (!Metasync_Image_Converter::can_revert($id)) { |
| 2994 | 3138 | $skipped++; |
| 2995 | 3139 | $file = get_attached_file($id); |
| 2996 | 3140 | $name = $file ? basename($file) : "ID {$id}"; |
| 3141 | + /* translators: %s: attachment file name. */ | |
| 2997 | 3142 | $errors[] = sprintf(__('%s: skipped — original image unavailable.', 'metasync'), $name); |
| 2998 | 3143 | continue; |
| 2999 | 3144 | } |
| 3000 | 3145 | |
| @@ -3003,8 +3148,9 @@ | ||
| 3003 | 3148 | } else { |
| 3004 | 3149 | $failed++; |
| 3005 | 3150 | $file = get_attached_file($id); |
| 3006 | 3151 | $name = $file ? basename($file) : "ID {$id}"; |
| 3152 | + /* translators: %s: attachment file name. */ | |
| 3007 | 3153 | $errors[] = sprintf(__('%s: revert failed (original file may not exist).', 'metasync'), $name); |
| 3008 | 3154 | } |
| 3009 | 3155 | } |
| 3010 | 3156 | |
| @@ -3011,8 +3157,9 @@ | ||
| 3011 | 3157 | wp_send_json_success([ |
| 3012 | 3158 | 'success' => $success, |
| 3013 | 3159 | 'failed' => $failed, |
| 3014 | 3160 | 'skipped' => $skipped, |
| 3161 | + 'denied' => $denied, | |
| 3015 | 3162 | 'errors' => $errors, |
| 3016 | 3163 | ]); |
| 3017 | 3164 | } |
| 3018 | 3165 | |
| @@ -3088,8 +3235,86 @@ | ||
| 3088 | 3235 | Metasync_Media_Batch_Optimizer::process_batch_tick(); |
| 3089 | 3236 | } |
| 3090 | 3237 | |
| 3091 | 3238 | /** |
| 3239 | + * AJAX: Start SEO Restore batch. | |
| 3240 | + */ | |
| 3241 | + public function ajax_seo_restore_start() | |
| 3242 | + { | |
| 3243 | + check_ajax_referer('metasync_seo_restore_nonce', 'nonce'); | |
| 3244 | + | |
| 3245 | + if (!current_user_can('manage_options')) { | |
| 3246 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 3247 | + } | |
| 3248 | + | |
| 3249 | + require_once plugin_dir_path(dirname(__FILE__)) . 'includes/class-metasync-seo-restore.php'; | |
| 3250 | + | |
| 3251 | + $progress = Metasync_Seo_Restore::start_batch(); | |
| 3252 | + wp_send_json_success($progress); | |
| 3253 | + } | |
| 3254 | + | |
| 3255 | + /** | |
| 3256 | + * AJAX: Cancel SEO Restore batch. | |
| 3257 | + */ | |
| 3258 | + public function ajax_seo_restore_cancel() | |
| 3259 | + { | |
| 3260 | + check_ajax_referer('metasync_seo_restore_nonce', 'nonce'); | |
| 3261 | + | |
| 3262 | + if (!current_user_can('manage_options')) { | |
| 3263 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 3264 | + } | |
| 3265 | + | |
| 3266 | + require_once plugin_dir_path(dirname(__FILE__)) . 'includes/class-metasync-seo-restore.php'; | |
| 3267 | + | |
| 3268 | + Metasync_Seo_Restore::cancel_batch(); | |
| 3269 | + wp_send_json_success(); | |
| 3270 | + } | |
| 3271 | + | |
| 3272 | + /** | |
| 3273 | + * AJAX: Get SEO Restore batch progress. | |
| 3274 | + */ | |
| 3275 | + public function ajax_seo_restore_progress() | |
| 3276 | + { | |
| 3277 | + check_ajax_referer('metasync_seo_restore_nonce', 'nonce'); | |
| 3278 | + | |
| 3279 | + if (!current_user_can('manage_options')) { | |
| 3280 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 3281 | + } | |
| 3282 | + | |
| 3283 | + require_once plugin_dir_path(dirname(__FILE__)) . 'includes/class-metasync-seo-restore.php'; | |
| 3284 | + | |
| 3285 | + $progress = Metasync_Seo_Restore::get_progress(); | |
| 3286 | + wp_send_json_success($progress); | |
| 3287 | + } | |
| 3288 | + | |
| 3289 | + /** | |
| 3290 | + * AJAX: Process one SEO Restore tick (browser-driven chaining). | |
| 3291 | + */ | |
| 3292 | + public function ajax_seo_restore_process_tick() | |
| 3293 | + { | |
| 3294 | + check_ajax_referer('metasync_seo_restore_nonce', 'nonce'); | |
| 3295 | + | |
| 3296 | + if (!current_user_can('manage_options')) { | |
| 3297 | + wp_send_json_error(__('Permission denied.', 'metasync')); | |
| 3298 | + } | |
| 3299 | + | |
| 3300 | + require_once plugin_dir_path(dirname(__FILE__)) . 'includes/class-metasync-seo-restore.php'; | |
| 3301 | + | |
| 3302 | + $progress = Metasync_Seo_Restore::process_ajax_tick(); | |
| 3303 | + wp_send_json_success($progress); | |
| 3304 | + } | |
| 3305 | + | |
| 3306 | + /** | |
| 3307 | + * Cron handler: Process SEO Restore batch tick. | |
| 3308 | + */ | |
| 3309 | + public function handle_seo_restore_cron() | |
| 3310 | + { | |
| 3311 | + require_once plugin_dir_path(dirname(__FILE__)) . 'includes/class-metasync-seo-restore.php'; | |
| 3312 | + | |
| 3313 | + Metasync_Seo_Restore::process_batch_tick(); | |
| 3314 | + } | |
| 3315 | + | |
| 3316 | + /** | |
| 3092 | 3317 | * Report Issue page callback |
| 3093 | 3318 | */ |
| 3094 | 3319 | public function create_admin_report_issue_page() |
| 3095 | 3320 | { |
| @@ -3101,8 +3326,17 @@ | ||
| 3101 | 3326 | * XML Sitemap page callback |
| 3102 | 3327 | */ |
| 3103 | 3328 | public function create_admin_xml_sitemap_page() |
| 3104 | 3329 | { |
| 3330 | + // Every form action below mutates site-wide state — sitemap options, | |
| 3331 | + // sitemap files on disk, robots.txt, other plugins' sitemap generators | |
| 3332 | + // — so they are restricted to site admins, not just anyone who can | |
| 3333 | + // open the page via plugin_access_roles. The nonce is CSRF | |
| 3334 | + // protection, not authorization. | |
| 3335 | + if (!empty($_POST) && !current_user_can('manage_options')) { | |
| 3336 | + wp_die(esc_html__('Sorry, you are not allowed to manage sitemap settings.', 'metasync')); | |
| 3337 | + } | |
| 3338 | + | |
| 3105 | 3339 | // Load sitemap generator class |
| 3106 | 3340 | require_once plugin_dir_path(dirname(__FILE__)) . 'sitemap/class-metasync-sitemap-generator.php'; |
| 3107 | 3341 | |
| 3108 | 3342 | $sitemap_generator = new Metasync_Sitemap_Generator(); |
| @@ -3130,13 +3364,16 @@ | ||
| 3130 | 3364 | |
| 3131 | 3365 | update_option('metasync_sitemap_settings', $sitemap_settings); |
| 3132 | 3366 | |
| 3133 | 3367 | // Regenerate sitemap with new content settings |
| 3134 | - $result = $sitemap_generator->generate_sitemap(); | |
| 3368 | + $result = $sitemap_generator->generate_sitemap( true ); | |
| 3135 | 3369 | if (is_wp_error($result)) { |
| 3136 | 3370 | echo '<div class="notice notice-error"><p>' . esc_html( |
| 3371 | + /* translators: %s: error message. */ | |
| 3137 | 3372 | sprintf(__('Settings saved but sitemap generation failed: %s', 'metasync'), $result->get_error_message()) |
| 3138 | 3373 | ) . '</p></div>'; |
| 3374 | + } elseif (false === $result) { | |
| 3375 | + echo '<div class="notice notice-error"><p>' . esc_html__('Settings saved but sitemap generation failed: the sitemap data could not be stored, so no sitemap is being served. Check your object cache and database write settings, then try again.', 'metasync') . '</p></div>'; | |
| 3139 | 3376 | } else { |
| 3140 | 3377 | echo '<div class="notice notice-success"><p>' . esc_html__('Sitemap content settings saved and sitemap regenerated!', 'metasync') . '</p></div>'; |
| 3141 | 3378 | } |
| 3142 | 3379 | } |
| @@ -3147,10 +3384,10 @@ | ||
| 3147 | 3384 | |
| 3148 | 3385 | // Build generic taxonomy filters |
| 3149 | 3386 | $news_taxonomies = []; |
| 3150 | 3387 | if (!empty($_POST['news_taxonomies']) && is_array($_POST['news_taxonomies'])) { |
| 3151 | - foreach ($_POST['news_taxonomies'] as $tax_name => $term_ids) { | |
| 3152 | - $news_taxonomies[sanitize_key($tax_name)] = array_map('absint', (array) $term_ids); | |
| 3388 | + foreach (wp_unslash($_POST['news_taxonomies']) as $tax_name => $term_ids) { | |
| 3389 | + $news_taxonomies[sanitize_key($tax_name)] = array_map('absint', (array) wp_unslash($term_ids)); | |
| 3153 | 3390 | } |
| 3154 | 3391 | } |
| 3155 | 3392 | |
| 3156 | 3393 | $news_settings = [ |
| @@ -3175,9 +3412,9 @@ | ||
| 3175 | 3412 | echo '<div class="notice notice-success"><p>' . esc_html__('News sitemap settings saved and sitemap regenerated!', 'metasync') . '</p></div>'; |
| 3176 | 3413 | } else { |
| 3177 | 3414 | // Also remove physical file if it exists |
| 3178 | 3415 | if (file_exists(ABSPATH . 'news-sitemap.xml')) { |
| 3179 | - @unlink(ABSPATH . 'news-sitemap.xml'); | |
| 3416 | + @wp_delete_file(ABSPATH . 'news-sitemap.xml'); | |
| 3180 | 3417 | } |
| 3181 | 3418 | echo '<div class="notice notice-success"><p>' . esc_html__('News sitemap settings saved. Sitemap cache cleared.', 'metasync') . '</p></div>'; |
| 3182 | 3419 | } |
| 3183 | 3420 | } |
| @@ -3188,10 +3425,10 @@ | ||
| 3188 | 3425 | |
| 3189 | 3426 | // Build generic taxonomy filters |
| 3190 | 3427 | $video_taxonomies = []; |
| 3191 | 3428 | if (!empty($_POST['video_taxonomies']) && is_array($_POST['video_taxonomies'])) { |
| 3192 | - foreach ($_POST['video_taxonomies'] as $tax_name => $term_ids) { | |
| 3193 | - $video_taxonomies[sanitize_key($tax_name)] = array_map('absint', (array) $term_ids); | |
| 3429 | + foreach (wp_unslash($_POST['video_taxonomies']) as $tax_name => $term_ids) { | |
| 3430 | + $video_taxonomies[sanitize_key($tax_name)] = array_map('absint', (array) wp_unslash($term_ids)); | |
| 3194 | 3431 | } |
| 3195 | 3432 | } |
| 3196 | 3433 | |
| 3197 | 3434 | $video_settings = [ |
| @@ -3199,8 +3436,12 @@ | ||
| 3199 | 3436 | 'post_types' => array_map('sanitize_key', (array) ($_POST['video_post_types'] ?? ['post', 'page'])), |
| 3200 | 3437 | 'auto_detect' => isset($_POST['auto_detect']), |
| 3201 | 3438 | 'taxonomies' => $video_taxonomies, |
| 3202 | 3439 | 'excluded_urls' => sanitize_textarea_field(wp_unslash($_POST['video_excluded_urls'] ?? '')), |
| 3440 | + // This array replaces the stored option wholesale, so every | |
| 3441 | + // setting must be represented here or it is wiped on save. | |
| 3442 | + 'video_url_meta_keys' => sanitize_textarea_field(wp_unslash($_POST['video_url_meta_keys'] ?? '')), | |
| 3443 | + 'video_thumbnail_meta_keys' => sanitize_textarea_field(wp_unslash($_POST['video_thumbnail_meta_keys'] ?? '')), | |
| 3203 | 3444 | ]; |
| 3204 | 3445 | |
| 3205 | 3446 | // Always invalidate old cache before saving new settings |
| 3206 | 3447 | delete_transient('metasync_vsm_' . md5('video-sitemap.xml')); |
| @@ -3213,9 +3454,9 @@ | ||
| 3213 | 3454 | echo '<div class="notice notice-success"><p>' . esc_html__('Video sitemap settings saved and sitemap regenerated!', 'metasync') . '</p></div>'; |
| 3214 | 3455 | } else { |
| 3215 | 3456 | // Also remove physical file if it exists |
| 3216 | 3457 | if (file_exists(ABSPATH . 'video-sitemap.xml')) { |
| 3217 | - @unlink(ABSPATH . 'video-sitemap.xml'); | |
| 3458 | + @wp_delete_file(ABSPATH . 'video-sitemap.xml'); | |
| 3218 | 3459 | } |
| 3219 | 3460 | echo '<div class="notice notice-success"><p>' . esc_html__('Video sitemap settings saved. Sitemap cache cleared.', 'metasync') . '</p></div>'; |
| 3220 | 3461 | } |
| 3221 | 3462 | } |
| @@ -3279,20 +3520,24 @@ | ||
| 3279 | 3520 | gc_collect_cycles(); |
| 3280 | 3521 | } |
| 3281 | 3522 | |
| 3282 | 3523 | // Generate main sitemap (its index will include news/video since they now exist) |
| 3283 | - $result = $sitemap_generator->generate_sitemap(); | |
| 3524 | + $result = $sitemap_generator->generate_sitemap( true ); | |
| 3284 | 3525 | |
| 3285 | 3526 | if (is_wp_error($result)) { |
| 3286 | 3527 | $error_msg = $result->get_error_message(); |
| 3287 | - error_log('[MetaSync] Sitemap generation failed: ' . $error_msg); | |
| 3528 | + error_log('[MetaSync] Sitemap generation failed: ' . $error_msg); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 3288 | 3529 | echo '<div class="notice notice-error"><p>' . esc_html( |
| 3530 | + /* translators: %s: error message. */ | |
| 3289 | 3531 | sprintf(__('Sitemap generation failed: %s', 'metasync'), $error_msg) |
| 3290 | 3532 | ) . '</p></div>'; |
| 3533 | + } elseif (false === $result) { | |
| 3534 | + echo '<div class="notice notice-error"><p>' . esc_html__('Sitemap generation failed: the sitemap data could not be stored, so no sitemap is being served. Check your object cache and database write settings, then try again.', 'metasync') . '</p></div>'; | |
| 3291 | 3535 | } else { |
| 3292 | 3536 | $message = esc_html__('Sitemap generated successfully!', 'metasync'); |
| 3293 | 3537 | if (!empty($extras)) { |
| 3294 | 3538 | $message .= ' ' . sprintf( |
| 3539 | + /* translators: %s: list of sitemap types. */ | |
| 3295 | 3540 | esc_html__('Also generated %s sitemap(s).', 'metasync'), |
| 3296 | 3541 | implode(' & ', $extras) |
| 3297 | 3542 | ); |
| 3298 | 3543 | } |
| @@ -3481,47 +3726,8 @@ | ||
| 3481 | 3726 | Metasync_Admin_Pages::get_instance($this)->create_admin_breadcrumbs_page(); |
| 3482 | 3727 | } |
| 3483 | 3728 | |
| 3484 | 3729 | /** |
| 3485 | - * Google Instant Index Setting page callback | |
| 3486 | - */ | |
| 3487 | - public function create_admin_google_instant_index_page() | |
| 3488 | - { | |
| 3489 | - $this->render_layout_open('Instant Indexing', 'instant_index', 'Submit URLs to Google for instant indexing via the Indexing API.'); | |
| 3490 | - | |
| 3491 | - // Render shared Google Index credentials section | |
| 3492 | - if (!function_exists('google_index_direct')) { | |
| 3493 | - if (file_exists(plugin_dir_path(dirname(__FILE__)) . 'google-index/google-index-init.php')) { | |
| 3494 | - require_once plugin_dir_path(dirname(__FILE__)) . 'google-index/google-index-init.php'; | |
| 3495 | - } else { | |
| 3496 | - error_log('MetaSync Google Index: google-index-init.php not found at ' . plugin_dir_path(dirname(__FILE__)) . 'google-index/google-index-init.php'); | |
| 3497 | - return; | |
| 3498 | - } | |
| 3499 | - } | |
| 3500 | - $google_index = google_index_direct(); | |
| 3501 | - $service_info = $google_index->get_service_account_info(); | |
| 3502 | - $is_configured = !isset($service_info['error']); | |
| 3503 | - | |
| 3504 | - $saved_json_display = $is_configured ? $google_index->get_redacted_config_json() : ''; | |
| 3505 | - | |
| 3506 | - include plugin_dir_path(dirname(__FILE__)) . 'views/metasync-google-index-api-settings.php'; | |
| 3507 | - | |
| 3508 | - // Render post types selection with save form | |
| 3509 | - $options = get_option('metasync_options_instant_indexing', ['post_types' => []]); | |
| 3510 | - $post_types_settings = isset($options['post_types']) && is_array($options['post_types']) ? $options['post_types'] : []; | |
| 3511 | - ?> | |
| 3512 | - <form method="POST" action=""> | |
| 3513 | - <?php include plugin_dir_path(dirname(__FILE__)) . 'views/metasync-google-instant-post-types.php'; ?> | |
| 3514 | - <div class="dashboard-card" style="padding: 20px;"> | |
| 3515 | - <?php submit_button('Save Post Types', 'primary', 'submit', false, array('class' => 'button button-primary')); ?> | |
| 3516 | - </div> | |
| 3517 | - </form> | |
| 3518 | - <?php | |
| 3519 | - | |
| 3520 | - $this->render_layout_close(); | |
| 3521 | - } | |
| 3522 | - | |
| 3523 | - /** | |
| 3524 | 3730 | * Google Console page callback |
| 3525 | 3731 | */ |
| 3526 | 3732 | public function create_admin_google_console_page() |
| 3527 | 3733 | { |
| @@ -3627,8 +3833,9 @@ | ||
| 3627 | 3833 | if (!get_transient('metasync_llms_conflict')) { |
| 3628 | 3834 | return; |
| 3629 | 3835 | } |
| 3630 | 3836 | echo '<div class="notice notice-info is-dismissible"><p>'; |
| 3837 | + /* translators: %s: effective plugin name (whitelabel-aware). */ | |
| 3631 | 3838 | echo esc_html(sprintf(__('Note: Another SEO plugin (Yoast, Rank Math, or AIOSEO) may also be generating /llms.txt. %s\'s version takes priority when enabled.', 'metasync'), Metasync::get_effective_plugin_name())); |
| 3632 | 3839 | echo '</p></div>'; |
| 3633 | 3840 | } |
| 3634 | 3841 | |
| @@ -3736,9 +3943,9 @@ | ||
| 3736 | 3943 | { |
| 3737 | 3944 | register_rest_route('metasync/v1', '/ping', array( |
| 3738 | 3945 | 'methods' => array('GET', 'POST'), |
| 3739 | 3946 | 'callback' => array($this, 'handle_ping_rest_endpoint'), |
| 3740 | - 'permission_callback' => '__return_true', // Allow public access | |
| 3947 | + 'permission_callback' => '__return_true', | |
| 3741 | 3948 | 'args' => array( |
| 3742 | 3949 | 'test' => array( |
| 3743 | 3950 | 'description' => 'Optional test parameter', |
| 3744 | 3951 | 'type' => 'string', |
| @@ -3820,17 +4027,17 @@ | ||
| 3820 | 4027 | return; |
| 3821 | 4028 | } |
| 3822 | 4029 | |
| 3823 | 4030 | // Get pagination parameters |
| 3824 | - $page = isset($_GET['paged']) ? max(1, intval($_GET['paged'])) : 1; | |
| 3825 | - $per_page = 10; | |
| 4031 | + $page = isset($_GET['paged']) ? max(1, intval($_GET['paged'])) : 1; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log | |
| 4032 | + $per_page = Metasync_Per_Page_Helper::resolve('sync_log', 10); | |
| 3826 | 4033 | $offset = ($page - 1) * $per_page; |
| 3827 | 4034 | |
| 3828 | 4035 | // Get filters |
| 3829 | 4036 | $filters = [ |
| 3830 | 4037 | // UI exposes date_range and status only. We compute date_from/date_to based on date_range |
| 3831 | - 'date_range' => isset($_GET['date_range']) ? sanitize_text_field(wp_unslash($_GET['date_range'])) : '', | |
| 3832 | - 'status' => isset($_GET['status']) ? sanitize_text_field(wp_unslash($_GET['status'])) : '', | |
| 4038 | + 'date_range' => isset($_GET['date_range']) ? sanitize_text_field(wp_unslash($_GET['date_range'])) : '', // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log | |
| 4039 | + 'status' => isset($_GET['status']) ? sanitize_text_field(wp_unslash($_GET['status'])) : '', // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log | |
| 3833 | 4040 | ]; |
| 3834 | 4041 | |
| 3835 | 4042 | // Map date_range to concrete date_from/date_to for DB queries |
| 3836 | 4043 | $date_range = $filters['date_range']; |
| @@ -3839,28 +4046,28 @@ | ||
| 3839 | 4046 | $date_to = ''; |
| 3840 | 4047 | |
| 3841 | 4048 | if (!empty($date_range)) { |
| 3842 | 4049 | // End boundary is now by default |
| 3843 | - $date_to = date('Y-m-d H:i:s', $wp_now_ts); | |
| 4050 | + $date_to = gmdate('Y-m-d H:i:s', $wp_now_ts); | |
| 3844 | 4051 | |
| 3845 | 4052 | if ($date_range === 'today') { |
| 3846 | 4053 | $start_ts = strtotime('today', $wp_now_ts); |
| 3847 | - $date_from = date('Y-m-d H:i:s', $start_ts); | |
| 4054 | + $date_from = gmdate('Y-m-d H:i:s', $start_ts); | |
| 3848 | 4055 | } elseif ($date_range === 'yesterday') { |
| 3849 | 4056 | $start_ts = strtotime('yesterday', $wp_now_ts); |
| 3850 | 4057 | $end_ts = strtotime('today', $wp_now_ts) - 1; // end of yesterday |
| 3851 | - $date_from = date('Y-m-d H:i:s', $start_ts); | |
| 3852 | - $date_to = date('Y-m-d H:i:s', $end_ts); | |
| 4058 | + $date_from = gmdate('Y-m-d H:i:s', $start_ts); | |
| 4059 | + $date_to = gmdate('Y-m-d H:i:s', $end_ts); | |
| 3853 | 4060 | } elseif ($date_range === 'this_week') { |
| 3854 | 4061 | $start_of_week = (int) get_option('start_of_week', 1); // 0=Sun, 1=Mon |
| 3855 | - $day_of_week = (int) date('w', $wp_now_ts); // 0=Sun..6=Sat | |
| 4062 | + $day_of_week = (int) gmdate('w', $wp_now_ts); // 0=Sun..6=Sat | |
| 3856 | 4063 | // Convert start_of_week to PHP's 0..6 where 0=Sunday |
| 3857 | 4064 | $delta_days = ($day_of_week - $start_of_week + 7) % 7; |
| 3858 | 4065 | $start_ts = strtotime('-' . $delta_days . ' days', strtotime('today', $wp_now_ts)); |
| 3859 | - $date_from = date('Y-m-d H:i:s', $start_ts); | |
| 4066 | + $date_from = gmdate('Y-m-d H:i:s', $start_ts); | |
| 3860 | 4067 | } elseif ($date_range === 'this_month') { |
| 3861 | - $start_ts = strtotime(date('Y-m-01 00:00:00', $wp_now_ts)); | |
| 3862 | - $date_from = date('Y-m-d H:i:s', $start_ts); | |
| 4068 | + $start_ts = strtotime(gmdate('Y-m-01 00:00:00', $wp_now_ts)); | |
| 4069 | + $date_from = gmdate('Y-m-d H:i:s', $start_ts); | |
| 3863 | 4070 | } elseif ($date_range === 'all') { |
| 3864 | 4071 | // no bounds |
| 3865 | 4072 | } |
| 3866 | 4073 | } |
| @@ -3887,12 +4094,24 @@ | ||
| 3887 | 4094 | ?> |
| 3888 | 4095 | <div class="dashboard-card"> |
| 3889 | 4096 | <div class="sync-log-header"> |
| 3890 | 4097 | <div class="sync-log-title-section"> |
| 3891 | - <h2>Changes Log</h2> | |
| 3892 | - <p style="color: var(--dashboard-text-secondary); margin-bottom: 0;"> | |
| 3893 | - Recent content synchronizations from external tools. | |
| 3894 | - <span style="margin-left:8px; font-size:12px; opacity:.75;">Records are automatically removed after 90 days.</span> | |
| 4098 | + <?php | |
| 4099 | + // The page title and description are already rendered by | |
| 4100 | + // render_layout_open() above. Repeating them here printed | |
| 4101 | + // "Changes Log" twice on screen, so the card keeps only the | |
| 4102 | + // retention hint — the one piece of copy the layout header | |
| 4103 | + // does not carry. | |
| 4104 | + ?> | |
| 4105 | + <p style="color: var(--dashboard-text-secondary); margin-top: 0; margin-bottom: 0;"> | |
| 4106 | + <?php | |
| 4107 | + // No opacity here: this used to be a de-emphasised | |
| 4108 | + // aside trailing a full-contrast sentence, but it is | |
| 4109 | + // now the card's only copy. At 12px/.75 it composites | |
| 4110 | + // to 4.28:1 on the card background, under the 4.5:1 | |
| 4111 | + // AA floor; at full strength it reads 6.52:1. | |
| 4112 | + ?> | |
| 4113 | + <span style="font-size:13px;">Records are automatically removed after 90 days.</span> | |
| 3895 | 4114 | </p> |
| 3896 | 4115 | </div> |
| 3897 | 4116 | |
| 3898 | 4117 | <!-- Filters + Clear Log button - Right aligned --> |
| @@ -3902,9 +4121,9 @@ | ||
| 3902 | 4121 | data-nonce="<?php echo esc_attr(wp_create_nonce('metasync_clear_sync_log')); ?>"> |
| 3903 | 4122 | 🗑 Clear Log |
| 3904 | 4123 | </button> |
| 3905 | 4124 | <form method="get" class="sync-filters-form" onchange="this.submit()" style="display:flex;flex-direction:row;align-items:center;gap:12px;flex-wrap:nowrap;"> |
| 3906 | - <input type="hidden" name="page" value="<?php echo esc_attr($_GET['page']); ?>"> | |
| 4125 | + <input type="hidden" name="page" value="<?php echo esc_attr(sanitize_key(wp_unslash($_GET['page']))); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log ?>"> | |
| 3907 | 4126 | |
| 3908 | 4127 | <select name="date_range" class="sync-filter-select"> |
| 3909 | 4128 | <option value="all" <?php selected($filters['date_range'] ?? 'all', 'all'); ?>> All Time</option> |
| 3910 | 4129 | <option value="today" <?php selected($filters['date_range'] ?? '', 'today'); ?>>Today</option> |
| @@ -3926,9 +4145,9 @@ | ||
| 3926 | 4145 | <div class="sync-log-list"> |
| 3927 | 4146 | <?php if (empty($sync_records)): ?> |
| 3928 | 4147 | <div class="sync-log-empty"> |
| 3929 | 4148 | <div class="sync-log-empty-icon"><span class="dashicons dashicons-media-default" style="font-size:48px;width:48px;height:48px;color:var(--dashboard-text-secondary);"></span></div> |
| 3930 | - <h3>No sync records found</h3> | |
| 4149 | + <h2>No sync records found</h2> | |
| 3931 | 4150 | <p>Sync records will appear here when content/pages receive new updates.</p> |
| 3932 | 4151 | </div> |
| 3933 | 4152 | <?php else: ?> |
| 3934 | 4153 | <?php foreach ($sync_records as $record): ?> |
| @@ -3982,30 +4201,32 @@ | ||
| 3982 | 4201 | <?php endif; ?> |
| 3983 | 4202 | </div> |
| 3984 | 4203 | |
| 3985 | 4204 | <!-- Pagination --> |
| 3986 | - <?php if ($total_pages > 1): ?> | |
| 3987 | - <div class="sync-log-pagination"> | |
| 3988 | - <div class="sync-log-pagination-info"> | |
| 3989 | - Total records: <?php echo intval( $total_records ); ?> | Showing <?php echo intval( $offset ) + 1; ?>-<?php echo intval( min($offset + $per_page, $total_records) ); ?> | |
| 3990 | - </div> | |
| 4205 | + <div class="sync-log-pagination"> | |
| 4206 | + <div class="sync-log-pagination-info"> | |
| 4207 | + Total records: <?php echo intval( $total_records ); ?><?php if ($total_records > 0): ?> | Showing <?php echo intval( $offset ) + 1; ?>-<?php echo intval( min($offset + $per_page, $total_records) ); ?><?php endif; ?> | |
| 4208 | + <?php // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- helper returns a complete escaped selector element. | |
| 4209 | + echo Metasync_Per_Page_Helper::render_selector('sync_log', absint($per_page)); ?> | |
| 4210 | + </div> | |
| 3991 | 4211 | |
| 4212 | + <?php if ($total_pages > 1): ?> | |
| 3992 | 4213 | <div class="sync-log-pagination-controls"> |
| 3993 | 4214 | <?php if ($page > 1): ?> |
| 3994 | - <a href="?page=<?php echo esc_attr($_GET['page']); ?>&paged=<?php echo intval( $page ) - 1; ?><?php echo esc_html( $this->build_filter_query_string($filters) ); ?>" class="sync-pagination-btn">‹</a> | |
| 4215 | + <a href="?page=<?php echo esc_attr(sanitize_key(wp_unslash($_GET['page']))); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log ?>&paged=<?php echo intval( $page ) - 1; ?><?php echo esc_html( $this->build_filter_query_string($filters) ); ?>" class="sync-pagination-btn">‹</a> | |
| 3995 | 4216 | <?php endif; ?> |
| 3996 | 4217 | |
| 3997 | 4218 | <?php for ($i = max(1, $page - 2); $i <= min($total_pages, $page + 2); $i++): ?> |
| 3998 | - <a href="?page=<?php echo esc_attr($_GET['page']); ?>&paged=<?php echo intval( $i ); ?><?php echo esc_html( $this->build_filter_query_string($filters) ); ?>" | |
| 4219 | + <a href="?page=<?php echo esc_attr(sanitize_key(wp_unslash($_GET['page']))); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log ?>&paged=<?php echo intval( $i ); ?><?php echo esc_html( $this->build_filter_query_string($filters) ); ?>" | |
| 3999 | 4220 | class="sync-pagination-btn <?php echo $i === $page ? 'active' : ''; ?>"><?php echo intval( $i ); ?></a> |
| 4000 | 4221 | <?php endfor; ?> |
| 4001 | 4222 | |
| 4002 | 4223 | <?php if ($page < $total_pages): ?> |
| 4003 | - <a href="?page=<?php echo esc_attr($_GET['page']); ?>&paged=<?php echo intval( $page ) + 1; ?><?php echo esc_html( $this->build_filter_query_string($filters) ); ?>" class="sync-pagination-btn">›</a> | |
| 4224 | + <a href="?page=<?php echo esc_attr(sanitize_key(wp_unslash($_GET['page']))); // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only filter and pagination values for the sync log ?>&paged=<?php echo intval( $page ) + 1; ?><?php echo esc_html( $this->build_filter_query_string($filters) ); ?>" class="sync-pagination-btn">›</a> | |
| 4004 | 4225 | <?php endif; ?> |
| 4005 | 4226 | </div> |
| 4006 | - </div> | |
| 4007 | - <?php endif; ?> | |
| 4227 | + <?php endif; ?> | |
| 4228 | + </div> | |
| 4008 | 4229 | </div> |
| 4009 | 4230 | <?php $this->render_layout_close(); ?> |
| 4010 | 4231 | |
| 4011 | 4232 | <script> |
| @@ -4086,8 +4307,19 @@ | ||
| 4086 | 4307 | if (!empty($value)) { |
| 4087 | 4308 | $query_parts[] = $key . '=' . urlencode($value); |
| 4088 | 4309 | } |
| 4089 | 4310 | } |
| 4311 | + | |
| 4312 | + // Preserve the user-selected results-per-page value across page | |
| 4313 | + // navigation so a non-default page size survives clicking a page link. | |
| 4314 | + $per_page_key = Metasync_Per_Page_Helper::request_key('sync_log'); | |
| 4315 | + if (isset($_GET[$per_page_key])) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only, allow-listed per-page value for links | |
| 4316 | + $per_page = (int) $_GET[$per_page_key]; // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only, allow-listed per-page value for links | |
| 4317 | + if (in_array($per_page, Metasync_Per_Page_Helper::allowed_values(), true)) { | |
| 4318 | + $query_parts[] = $per_page_key . '=' . $per_page; | |
| 4319 | + } | |
| 4320 | + } | |
| 4321 | + | |
| 4090 | 4322 | return !empty($query_parts) ? '&' . implode('&', $query_parts) : ''; |
| 4091 | 4323 | } |
| 4092 | 4324 | |
| 4093 | 4325 | /** |
| @@ -4261,18 +4493,8 @@ | ||
| 4261 | 4493 | { |
| 4262 | 4494 | Metasync_Connect_Manager::instance()->handle_session_management_early(); |
| 4263 | 4495 | } |
| 4264 | 4496 | |
| 4265 | - /** | |
| 4266 | - * @deprecated 2.5.12 Use Metasync_Auth_Manager instead of sessions for authentication | |
| 4267 | - */ | |
| 4268 | - private function safe_session_start() { | |
| 4269 | - // This method is deprecated and no longer used | |
| 4270 | - // Authentication now uses Metasync_Auth_Manager with WordPress transients and user meta | |
| 4271 | - _deprecated_function(__METHOD__, '2.5.12', 'Metasync_Auth_Manager'); | |
| 4272 | - return Metasync_Session_Helper::safe_start(); | |
| 4273 | - } | |
| 4274 | - | |
| 4275 | 4497 | private function handle_whitelabel_session_logic() |
| 4276 | 4498 | { |
| 4277 | 4499 | Metasync_Connect_Manager::instance()->handle_whitelabel_session_logic(); |
| 4278 | 4500 | } |
| @@ -4368,9 +4590,9 @@ | ||
| 4368 | 4590 | <label style="display: block; margin-bottom: 8px; font-weight: 500; color: var(--dashboard-text);"> |
| 4369 | 4591 | Effective Threshold |
| 4370 | 4592 | </label> |
| 4371 | 4593 | <div style="padding: 10px 12px; background: var(--dashboard-input-bg); border: 1px solid var(--dashboard-border); border-radius: 6px; color: var(--dashboard-text-secondary);"> |
| 4372 | - <strong id="effective_threshold_value"><?php echo round($effective_threshold, 2); ?></strong> | |
| 4594 | + <strong id="effective_threshold_value"><?php echo esc_html((string) round($effective_threshold, 2)); ?></strong> | |
| 4373 | 4595 | </div> |
| 4374 | 4596 | <p style="margin: 8px 0 0 0; font-size: 12px; color: var(--dashboard-text-secondary);"> |
| 4375 | 4597 | Calculated as: cores × per-core threshold |
| 4376 | 4598 | </p> |
| @@ -4388,13 +4610,13 @@ | ||
| 4388 | 4610 | <div style="font-size: 18px; font-weight: 600; color: var(--dashboard-text);"><?php echo intval($stats['deferrals']); ?></div> |
| 4389 | 4611 | </div> |
| 4390 | 4612 | <div> |
| 4391 | 4613 | <div style="font-size: 12px; color: var(--dashboard-text-secondary); margin-bottom: 4px;">Max Load Observed</div> |
| 4392 | - <div style="font-size: 18px; font-weight: 600; color: var(--dashboard-text);"><?php echo round($stats['max_load'], 2); ?></div> | |
| 4614 | + <div style="font-size: 18px; font-weight: 600; color: var(--dashboard-text);"><?php echo esc_html((string) round($stats['max_load'], 2)); ?></div> | |
| 4393 | 4615 | </div> |
| 4394 | 4616 | <div> |
| 4395 | 4617 | <div style="font-size: 12px; color: var(--dashboard-text-secondary); margin-bottom: 4px;">Average Load</div> |
| 4396 | - <div style="font-size: 18px; font-weight: 600; color: var(--dashboard-text);"><?php echo round($stats['avg_load'], 2); ?></div> | |
| 4618 | + <div style="font-size: 18px; font-weight: 600; color: var(--dashboard-text);"><?php echo esc_html((string) round($stats['avg_load'], 2)); ?></div> | |
| 4397 | 4619 | </div> |
| 4398 | 4620 | </div> |
| 4399 | 4621 | </div> |
| 4400 | 4622 | |
| @@ -5099,8 +5321,14 @@ | ||
| 5099 | 5321 | * Show a one-time admin notice when a page builder is detected but the |
| 5100 | 5322 | * "Default Page Builder" setting has never been explicitly saved. |
| 5101 | 5323 | */ |
| 5102 | 5324 | public function display_page_builder_notice() { |
| 5325 | + // Only relevant on the plugin's own settings page — avoid repeating | |
| 5326 | + // this notice across every admin screen. | |
| 5327 | + if (!isset($_GET['page']) || wp_unslash($_GET['page']) !== self::$page_slug) { | |
| 5328 | + return; | |
| 5329 | + } | |
| 5330 | + | |
| 5103 | 5331 | $configured = Metasync::get_option('general')['default_page_builder'] ?? ''; |
| 5104 | 5332 | |
| 5105 | 5333 | // Setting already saved — nothing to warn about |
| 5106 | 5334 | if (!empty($configured)) { |
| @@ -5113,9 +5341,9 @@ | ||
| 5113 | 5341 | return; |
| 5114 | 5342 | } |
| 5115 | 5343 | |
| 5116 | 5344 | // Handle dismiss action |
| 5117 | - if (isset($_GET['metasync_dismiss_builder_notice']) && wp_verify_nonce($_GET['_wpnonce'] ?? '', 'metasync_dismiss_builder')) { | |
| 5345 | + if (isset($_GET['metasync_dismiss_builder_notice'], $_GET['_wpnonce']) && wp_verify_nonce(sanitize_text_field(wp_unslash($_GET['_wpnonce'])), 'metasync_dismiss_builder')) { | |
| 5118 | 5346 | update_user_meta(get_current_user_id(), 'metasync_builder_notice_dismissed', '1'); |
| 5119 | 5347 | return; |
| 5120 | 5348 | } |
| 5121 | 5349 | |
| @@ -5210,9 +5438,10 @@ | ||
| 5210 | 5438 | * Saves the CPU load threshold and returns statistics |
| 5211 | 5439 | */ |
| 5212 | 5440 | public function ajax_save_performance_settings() { |
| 5213 | 5441 | # Check nonce for security and return early if invalid |
| 5214 | - if (!isset($_POST['meta_sync_nonce']) || !wp_verify_nonce($_POST['meta_sync_nonce'], 'meta_sync_general_setting_nonce')) { | |
| 5442 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 5443 | + if (!isset($_POST['meta_sync_nonce']) || !wp_verify_nonce(wp_unslash($_POST['meta_sync_nonce']), 'meta_sync_general_setting_nonce')) { | |
| 5215 | 5444 | wp_send_json_error(array('message' => 'Invalid nonce')); |
| 5216 | 5445 | return; |
| 5217 | 5446 | } |
| 5218 | 5447 | |
| @@ -5280,9 +5509,9 @@ | ||
| 5280 | 5509 | if (!wp_next_scheduled('metasync_cleanup_transients')) { |
| 5281 | 5510 | $scheduled = wp_schedule_event(time(), 'metasync_daily_cleanup', 'metasync_cleanup_transients'); |
| 5282 | 5511 | |
| 5283 | 5512 | if (!$scheduled) { |
| 5284 | - error_log('MetaSync: Failed to schedule transient cleanup cron job'); | |
| 5513 | + error_log('MetaSync: Failed to schedule transient cleanup cron job'); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 5285 | 5514 | } |
| 5286 | 5515 | } |
| 5287 | 5516 | } |
| 5288 | 5517 | |
| @@ -5293,9 +5522,9 @@ | ||
| 5293 | 5522 | { |
| 5294 | 5523 | $timestamp = wp_next_scheduled('metasync_cleanup_transients'); |
| 5295 | 5524 | if ($timestamp) { |
| 5296 | 5525 | wp_unschedule_event($timestamp, 'metasync_cleanup_transients'); |
| 5297 | - error_log('MetaSync: Transient cleanup cron job unscheduled'); | |
| 5526 | + error_log('MetaSync: Transient cleanup cron job unscheduled'); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- unreachable in production | |
| 5298 | 5527 | } |
| 5299 | 5528 | } |
| 5300 | 5529 | |
| 5301 | 5530 | /** |
| @@ -5317,12 +5546,10 @@ | ||
| 5317 | 5546 | { |
| 5318 | 5547 | if (!wp_next_scheduled('metasync_hidden_post_check')) { |
| 5319 | 5548 | $scheduled = wp_schedule_event(time(), 'metasync_weekly', 'metasync_hidden_post_check'); |
| 5320 | 5549 | |
| 5321 | - if ($scheduled) { | |
| 5322 | - error_log('MetaSync: Hidden post manager cron job scheduled successfully (runs every 7 days)'); | |
| 5323 | - } else { | |
| 5324 | - error_log('MetaSync: Failed to schedule hidden post manager cron job'); | |
| 5550 | + if (!$scheduled) { | |
| 5551 | + error_log('MetaSync: Failed to schedule hidden post manager cron job'); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 5325 | 5552 | } |
| 5326 | 5553 | } |
| 5327 | 5554 | } |
| 5328 | 5555 | |
| @@ -5333,12 +5560,10 @@ | ||
| 5333 | 5560 | public function maybe_schedule_otto_recheck_404_cron() |
| 5334 | 5561 | { |
| 5335 | 5562 | if (!wp_next_scheduled('metasync_otto_recheck_404_exclusions')) { |
| 5336 | 5563 | $scheduled = wp_schedule_event(time(), 'metasync_daily_cleanup', 'metasync_otto_recheck_404_exclusions'); |
| 5337 | - if ($scheduled) { | |
| 5338 | - error_log('MetaSync: OTTO 404 recheck cron job scheduled successfully (runs daily)'); | |
| 5339 | - } else { | |
| 5340 | - error_log('MetaSync: Failed to schedule OTTO 404 recheck cron job'); | |
| 5564 | + if (!$scheduled) { | |
| 5565 | + error_log('MetaSync: Failed to schedule OTTO 404 recheck cron job'); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 5341 | 5566 | } |
| 5342 | 5567 | } |
| 5343 | 5568 | } |
| 5344 | 5569 | |
| @@ -5411,13 +5636,13 @@ | ||
| 5411 | 5636 | |
| 5412 | 5637 | try { |
| 5413 | 5638 | // 1. Post revisions |
| 5414 | 5639 | if (!empty($settings['clean_post_revisions'])) { |
| 5415 | - $stats['post_revisions'] = (int) $wpdb->query( | |
| 5640 | + $stats['post_revisions'] = (int) $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5416 | 5641 | "DELETE FROM {$wpdb->posts} WHERE post_type = 'revision'" |
| 5417 | 5642 | ); |
| 5418 | 5643 | // Remove postmeta left behind by deleted revisions |
| 5419 | - $wpdb->query( | |
| 5644 | + $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5420 | 5645 | "DELETE pm FROM {$wpdb->postmeta} pm |
| 5421 | 5646 | LEFT JOIN {$wpdb->posts} p ON p.ID = pm.post_id |
| 5422 | 5647 | WHERE p.ID IS NULL" |
| 5423 | 5648 | ); |
| @@ -5425,20 +5650,19 @@ | ||
| 5425 | 5650 | |
| 5426 | 5651 | // 2. Trashed posts + their postmeta |
| 5427 | 5652 | if (!empty($settings['clean_trashed_posts'])) { |
| 5428 | 5653 | // Collect IDs first to cleanly remove postmeta |
| 5429 | - $trashed_ids = $wpdb->get_col( | |
| 5654 | + $trashed_ids = $wpdb->get_col( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5430 | 5655 | "SELECT ID FROM {$wpdb->posts} WHERE post_status = 'trash'" |
| 5431 | 5656 | ); |
| 5432 | 5657 | if (!empty($trashed_ids)) { |
| 5433 | - $placeholders = implode(',', array_fill(0, count($trashed_ids), '%d')); | |
| 5434 | - $wpdb->query( | |
| 5658 | + $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5435 | 5659 | $wpdb->prepare( |
| 5436 | - "DELETE FROM {$wpdb->postmeta} WHERE post_id IN ($placeholders)", | |
| 5660 | + 'DELETE FROM ' . $wpdb->postmeta . ' WHERE post_id IN (' . implode(',', array_fill(0, count($trashed_ids), '%d')) . ')', | |
| 5437 | 5661 | $trashed_ids |
| 5438 | 5662 | ) |
| 5439 | 5663 | ); |
| 5440 | - $stats['trashed_posts'] = (int) $wpdb->query( | |
| 5664 | + $stats['trashed_posts'] = (int) $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5441 | 5665 | "DELETE FROM {$wpdb->posts} WHERE post_status = 'trash'" |
| 5442 | 5666 | ); |
| 5443 | 5667 | } else { |
| 5444 | 5668 | $stats['trashed_posts'] = 0; |
| @@ -5446,9 +5670,9 @@ | ||
| 5446 | 5670 | } |
| 5447 | 5671 | |
| 5448 | 5672 | // 3. Trashed comments |
| 5449 | 5673 | if (!empty($settings['clean_trashed_comments'])) { |
| 5450 | - $stats['trashed_comments'] = (int) $wpdb->query( | |
| 5674 | + $stats['trashed_comments'] = (int) $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5451 | 5675 | "DELETE FROM {$wpdb->comments} WHERE comment_approved = 'trash'" |
| 5452 | 5676 | ); |
| 5453 | 5677 | } |
| 5454 | 5678 | |
| @@ -5453,9 +5677,9 @@ | ||
| 5453 | 5677 | } |
| 5454 | 5678 | |
| 5455 | 5679 | // 4. Spam comments |
| 5456 | 5680 | if (!empty($settings['clean_spam_comments'])) { |
| 5457 | - $stats['spam_comments'] = (int) $wpdb->query( | |
| 5681 | + $stats['spam_comments'] = (int) $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5458 | 5682 | "DELETE FROM {$wpdb->comments} WHERE comment_approved = 'spam'" |
| 5459 | 5683 | ); |
| 5460 | 5684 | } |
| 5461 | 5685 | |
| @@ -5461,15 +5685,15 @@ | ||
| 5461 | 5685 | |
| 5462 | 5686 | // 5. Expired transients — direct SQL, no cache flush |
| 5463 | 5687 | if (!empty($settings['clean_expired_transients'])) { |
| 5464 | 5688 | // Delete timeout rows that have already expired |
| 5465 | - $wpdb->query( | |
| 5689 | + $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5466 | 5690 | "DELETE FROM {$wpdb->options} |
| 5467 | 5691 | WHERE option_name LIKE '\_transient\_timeout\_%' |
| 5468 | 5692 | AND option_value + 0 < UNIX_TIMESTAMP()" |
| 5469 | 5693 | ); |
| 5470 | 5694 | // Delete value rows whose timeout row no longer exists |
| 5471 | - $stats['expired_transients'] = (int) $wpdb->query( | |
| 5695 | + $stats['expired_transients'] = (int) $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5472 | 5696 | "DELETE o FROM {$wpdb->options} o |
| 5473 | 5697 | LEFT JOIN {$wpdb->options} t |
| 5474 | 5698 | ON t.option_name = CONCAT('_transient_timeout_', SUBSTRING(o.option_name, 12)) |
| 5475 | 5699 | WHERE o.option_name LIKE '\_transient\_%' |
| @@ -5479,9 +5703,9 @@ | ||
| 5479 | 5703 | } |
| 5480 | 5704 | |
| 5481 | 5705 | // 6. Orphaned postmeta (post_id references a post that no longer exists) |
| 5482 | 5706 | if (!empty($settings['clean_orphaned_postmeta'])) { |
| 5483 | - $stats['orphaned_postmeta'] = (int) $wpdb->query( | |
| 5707 | + $stats['orphaned_postmeta'] = (int) $wpdb->query( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- bulk site-maintenance operations (revisions/trash/spam/transients/orphans) — no bulk WordPress API exists | |
| 5484 | 5708 | "DELETE pm FROM {$wpdb->postmeta} pm |
| 5485 | 5709 | LEFT JOIN {$wpdb->posts} p ON p.ID = pm.post_id |
| 5486 | 5710 | WHERE p.ID IS NULL" |
| 5487 | 5711 | ); |
| @@ -5493,12 +5717,10 @@ | ||
| 5493 | 5717 | $settings['last_run_at'] = time(); |
| 5494 | 5718 | $settings['last_run_stats'] = $stats; |
| 5495 | 5719 | update_option('metasync_db_cleanup_settings', $settings); |
| 5496 | 5720 | |
| 5497 | - error_log('MetaSync: DB cleanup completed — ' . json_encode($stats)); | |
| 5498 | - | |
| 5499 | 5721 | } catch (Exception $e) { |
| 5500 | - error_log('MetaSync: DB cleanup failed — ' . $e->getMessage()); | |
| 5722 | + error_log('MetaSync: DB cleanup failed — ' . $e->getMessage()); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- genuine failure path, bounded, no secrets | |
| 5501 | 5723 | } |
| 5502 | 5724 | } |
| 5503 | 5725 | |
| 5504 | 5726 | /** |
| @@ -5715,10 +5937,11 @@ | ||
| 5715 | 5937 | /** |
| 5716 | 5938 | * AJAX: Save DB cleanup settings and reschedule cron accordingly. |
| 5717 | 5939 | */ |
| 5718 | 5940 | public function ajax_save_db_cleanup_settings() { |
| 5941 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 5719 | 5942 | if (!isset($_POST['db_cleanup_settings_nonce']) || |
| 5720 | - !wp_verify_nonce($_POST['db_cleanup_settings_nonce'], 'metasync_db_cleanup_settings_nonce')) { | |
| 5943 | + !wp_verify_nonce(wp_unslash($_POST['db_cleanup_settings_nonce']), 'metasync_db_cleanup_settings_nonce')) { | |
| 5721 | 5944 | wp_send_json_error(array('message' => 'Invalid security token. Please refresh the page and try again.')); |
| 5722 | 5945 | return; |
| 5723 | 5946 | } |
| 5724 | 5947 | |
| @@ -5775,10 +5998,11 @@ | ||
| 5775 | 5998 | * AJAX: Manually trigger the DB cleanup and return stats for the UI. |
| 5776 | 5999 | * Persists current form state first so unsaved checkbox changes are respected. |
| 5777 | 6000 | */ |
| 5778 | 6001 | public function ajax_run_db_cleanup() { |
| 6002 | + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- nonce is validated immediately by wp_verify_nonce(). | |
| 5779 | 6003 | if (!isset($_POST['db_cleanup_settings_nonce']) || |
| 5780 | - !wp_verify_nonce($_POST['db_cleanup_settings_nonce'], 'metasync_db_cleanup_settings_nonce')) { | |
| 6004 | + !wp_verify_nonce(wp_unslash($_POST['db_cleanup_settings_nonce']), 'metasync_db_cleanup_settings_nonce')) { | |
| 5781 | 6005 | wp_send_json_error(array('message' => 'Invalid security token.')); |
| 5782 | 6006 | return; |
| 5783 | 6007 | } |
| 5784 | 6008 | |
| @@ -5854,35 +6078,8 @@ | ||
| 5854 | 6078 | )); |
| 5855 | 6079 | } |
| 5856 | 6080 | |
| 5857 | 6081 | /** |
| 5858 | - * Control plugin auto-updates based on user setting | |
| 5859 | - * | |
| 5860 | - * @param bool $update Whether to update | |
| 5861 | - * @param object $item Update offer | |
| 5862 | - * @return bool Whether to allow auto-update | |
| 5863 | - */ | |
| 5864 | - public function control_plugin_auto_updates($update, $item) | |
| 5865 | - { | |
| 5866 | - # Check if the item object has the slug property | |
| 5867 | - if (!isset($item->slug)) { | |
| 5868 | - return $update; | |
| 5869 | - } | |
| 5870 | - | |
| 5871 | - // Check if this is our plugin | |
| 5872 | - if ($item->slug === 'metasync') { | |
| 5873 | - $general_settings = Metasync::get_option('general') ?? []; | |
| 5874 | - $enable_auto_updates = $general_settings['enable_auto_updates'] ?? false; | |
| 5875 | - | |
| 5876 | - // Return the user's preference (true = allow auto-updates, false = prevent) | |
| 5877 | - return $enable_auto_updates === 'true' || $enable_auto_updates === true; | |
| 5878 | - } | |
| 5879 | - | |
| 5880 | - // For other plugins, don't interfere with their auto-update settings | |
| 5881 | - return $update; | |
| 5882 | - } | |
| 5883 | - | |
| 5884 | - /** | |
| 5885 | 6082 | * AJAX handler to add excluded URL for OTTO |
| 5886 | 6083 | */ |
| 5887 | 6084 | public function ajax_otto_add_excluded_url() |
| 5888 | 6085 | { |
| @@ -6028,8 +6225,9 @@ | ||
| 6028 | 6225 | // If page has raw HTML or custom CSS from conversion, show badge |
| 6029 | 6226 | if ($has_raw_html || !empty($has_custom_css)) { |
| 6030 | 6227 | $label = $this->get_html_source_label(); |
| 6031 | 6228 | $tooltip = sprintf( |
| 6229 | + /* translators: %s: HTML source label. */ | |
| 6032 | 6230 | __('This page was created using %s HTML-to-Builder converter', 'metasync'), |
| 6033 | 6231 | $label |
| 6034 | 6232 | ); |
| 6035 | 6233 | |
| @@ -6082,8 +6280,9 @@ | ||
| 6082 | 6280 | |
| 6083 | 6281 | if ($has_raw_html || !empty($has_custom_css)) { |
| 6084 | 6282 | $label = $this->get_html_source_label(); |
| 6085 | 6283 | $message = sprintf( |
| 6284 | + /* translators: %s: HTML source label. */ | |
| 6086 | 6285 | __('This page was created using %s HTML-to-Builder converter. The design is preserved with custom CSS and inline styles.', 'metasync'), |
| 6087 | 6286 | '<strong>' . esc_html($label) . '</strong>' |
| 6088 | 6287 | ); |
| 6089 | 6288 | |
| @@ -6097,9 +6296,9 @@ | ||
| 6097 | 6296 | <p class="metasync-editor-message">%s</p> |
| 6098 | 6297 | </div> |
| 6099 | 6298 | </div>', |
| 6100 | 6299 | esc_html($label), |
| 6101 | - $message | |
| 6300 | + wp_kses($message, array('strong' => array())) | |
| 6102 | 6301 | ); |
| 6103 | 6302 | } |
| 6104 | 6303 | } |
| 6105 | 6304 | |
| @@ -6122,9 +6321,9 @@ | ||
| 6122 | 6321 | ?> |
| 6123 | 6322 | <fieldset class="inline-edit-col-left metasync-quick-edit-source"> |
| 6124 | 6323 | <div class="inline-edit-col"> |
| 6125 | 6324 | <label> |
| 6126 | - <span class="title"><?php _e('Source', 'metasync'); ?></span> | |
| 6325 | + <span class="title"><?php esc_html_e('Source', 'metasync'); ?></span> | |
| 6127 | 6326 | <span class="metasync-quick-edit-badge-container"></span> |
| 6128 | 6327 | </label> |
| 6129 | 6328 | </div> |
| 6130 | 6329 | </fieldset> |
| @@ -6136,8 +6335,9 @@ | ||
| 6136 | 6335 | */ |
| 6137 | 6336 | public function add_html_pages_dashboard_widget() |
| 6138 | 6337 | { |
| 6139 | 6338 | $label = $this->get_html_source_label(); |
| 6339 | + /* translators: %s: HTML source label. */ | |
| 6140 | 6340 | $widget_title = sprintf(__('%s Pages', 'metasync'), $label); |
| 6141 | 6341 | |
| 6142 | 6342 | wp_add_dashboard_widget( |
| 6143 | 6343 | 'metasync_html_pages_widget', |
| @@ -6278,34 +6478,8 @@ | ||
| 6278 | 6478 | $bing_instant_index->send(); |
| 6279 | 6479 | } |
| 6280 | 6480 | |
| 6281 | 6481 | /** |
| 6282 | - * Save instant indexing settings (Google and Bing) | |
| 6283 | - * | |
| 6284 | - * @since 2.6.0 | |
| 6285 | - * @return void | |
| 6286 | - */ | |
| 6287 | - public function save_instant_indexing_settings() | |
| 6288 | - { | |
| 6289 | - // Check if this is a settings submission | |
| 6290 | - if (!isset($_POST['submit'])) { | |
| 6291 | - return; | |
| 6292 | - } | |
| 6293 | - | |
| 6294 | - // Save post types for Google Instant Indexing auto-submit | |
| 6295 | - if (isset($_POST['metasync_post_types'])) { | |
| 6296 | - $post_data = metasync_sanitize_input_array($_POST); | |
| 6297 | - $post_types = is_array($post_data['metasync_post_types']) ? array_map('sanitize_title', $post_data['metasync_post_types']) : []; | |
| 6298 | - | |
| 6299 | - $settings = get_option('metasync_options_instant_indexing', ['post_types' => []]); | |
| 6300 | - $settings['post_types'] = array_values($post_types); | |
| 6301 | - update_option('metasync_options_instant_indexing', $settings); | |
| 6302 | - } | |
| 6303 | - | |
| 6304 | - // Note: Bing Instant Indexing settings are saved via AJAX in save_bing_inline_settings_ajax() | |
| 6305 | - } | |
| 6306 | - | |
| 6307 | - /** | |
| 6308 | 6482 | * Save Bing instant indexing settings from inline form (Indexation Control page) |
| 6309 | 6483 | * |
| 6310 | 6484 | * @since 2.6.0 |
| 6311 | 6485 | * @return bool True on success, false on failure |
| @@ -6375,12 +6549,24 @@ | ||
| 6375 | 6549 | if (!empty($seo_controls['enable_googleinstantindex']) && $seo_controls['enable_googleinstantindex'] === 'true') { |
| 6376 | 6550 | $options = get_option('metasync_options_instant_indexing', ['post_types' => []]); |
| 6377 | 6551 | $post_types = isset($options['post_types']) && is_array($options['post_types']) ? $options['post_types'] : []; |
| 6378 | 6552 | |
| 6379 | - if (in_array($post->post_type, $post_types) && function_exists('google_index_direct')) { | |
| 6380 | - $service_info = google_index_direct()->get_service_account_info(); | |
| 6381 | - if (!isset($service_info['error'])) { | |
| 6382 | - google_index_direct()->index_post($post_id, $post->post_type, 'update'); | |
| 6553 | + if (in_array($post->post_type, $post_types)) { | |
| 6554 | + // save_post is the single owner of auto-submit and also fires | |
| 6555 | + // on REST-created posts, where nothing else may have loaded | |
| 6556 | + // the Google Index helpers yet — load them on demand instead | |
| 6557 | + // of silently skipping. | |
| 6558 | + if (!function_exists('google_index_direct')) { | |
| 6559 | + $google_index_path = plugin_dir_path(dirname(__FILE__)) . 'google-index/google-index-init.php'; | |
| 6560 | + if (file_exists($google_index_path)) { | |
| 6561 | + require_once $google_index_path; | |
| 6562 | + } | |
| 6563 | + } | |
| 6564 | + if (function_exists('google_index_direct')) { | |
| 6565 | + $service_info = google_index_direct()->get_service_account_info(); | |
| 6566 | + if (!isset($service_info['error'])) { | |
| 6567 | + google_index_direct()->index_post($post_id, $post->post_type, 'update'); | |
| 6568 | + } | |
| 6383 | 6569 | } |
| 6384 | 6570 | } |
| 6385 | 6571 | } |
| 6386 | 6572 | |
