PluginProbe
Search Atlas SEO – OTTO AI SEO Automation for WordPress / 2.7.2
Search Atlas SEO – OTTO AI SEO Automation for WordPress v2.7.2
2.7.1 2.7.2 2.7.0 2.6.26 2.6.25 2.6.24 2.6.23 2.6.22 2.6.21 2.6.20 2.6.19 2.6.18 2.6.17 2.6.16 2.6.15 2.6.14 2.6.13 2.6.12 2.6.11 2.6.10 2.6.9 2.6.8 2.6.7 2.6.6 2.6.5 All 141 releases
← All changes | includes/class-metasync-plugin-sync.php +467 -45 2.6.25 → 2.7.2 View file →
@@ -61,8 +61,9 @@
61 61 '_metasync_seo_title',
62 62 '_metasync_seo_desc',
63 63 '_metasync_metatitle',
64 64 '_metasync_metadesc',
65 + '_metasync_metakeywords',
65 66 '_metasync_robots_index',
66 67 '_metasync_robots_advanced',
67 68 '_metasync_og_title',
68 69 '_metasync_og_description',
@@ -80,8 +81,9 @@
80 81 '_metasync_otto_og_description',
81 82 '_metasync_otto_twitter_title',
82 83 '_metasync_otto_twitter_description',
83 84 '_metasync_otto_keywords',
85 + '_metasync_otto_canonical',
84 86 ];
85 87
86 88 /**
87 89 * Internal OTTO meta keys mapped to the OTTO Persistence setting that
@@ -102,8 +104,9 @@
102 104 const OTTO_PERSISTENCE_KEYS = [
103 105 '_metasync_otto_title' => 'meta_title',
104 106 '_metasync_otto_description' => 'meta_description',
105 107 '_metasync_otto_keywords' => 'meta_keywords',
108 + '_metasync_metakeywords' => 'meta_keywords',
106 109 '_metasync_otto_og_title' => 'og_title',
107 110 '_metasync_otto_og_description' => 'og_description',
108 111 '_metasync_otto_twitter_title' => 'twitter_title',
109 112 '_metasync_otto_twitter_description' => 'twitter_description',
@@ -253,8 +256,9 @@
253 256 '_metasync_otto_og_description' => 'og_desc',
254 257 '_metasync_otto_twitter_title' => 'twitter_title',
255 258 '_metasync_otto_twitter_description' => 'twitter_desc',
256 259 '_metasync_otto_keywords' => 'focus_keyword',
260 + '_metasync_metakeywords' => 'focus_keyword',
257 261 // Legacy meta box keys → rebuild JSON
258 262 'metasync_common_robots' => '_legacy_robots_to_json',
259 263 'metasync_advance_robots' => '_legacy_robots_to_json',
260 264 ];
@@ -283,8 +287,16 @@
283 287 if ($this->is_yoast_active()) {
284 288 $sync_instance = $this;
285 289 $sync_post_id = (int) $post_id;
286 290 add_action('shutdown', function() use ($sync_instance, $sync_post_id) {
291 + // By shutdown this request has typically seeded the OG defaults
292 + // memo for the post (the sync above reads it); the row write
293 + // has since landed, so drop the memo or the re-sync below
294 + // compares against the pre-save title/excerpt.
295 + // @phpstan-ignore-next-line function.alreadyNarrowedType
296 + if (method_exists('Metasync_OpenGraph', 'clear_default_og_values_memo')) {
297 + Metasync_OpenGraph::clear_default_og_values_memo();
298 + }
287 299 $sync_instance->sync_post($sync_post_id);
288 300 }, 0);
289 301 }
290 302 return;
@@ -382,9 +394,9 @@
382 394 }
383 395
384 396 $all_meta = get_post_custom($post_id);
385 397
386 - $get = function ($key) use ($all_meta) {
398 + $get = function ($key) use ($all_meta, $post_id) {
387 399 if (!isset($all_meta[$key])) {
388 400 return '';
389 401 }
390 402 $value = is_array($all_meta[$key]) ? $all_meta[$key][0] : $all_meta[$key];
@@ -403,11 +415,38 @@
403 415 if (method_exists('Metasync_OpenGraph', 'strip_auto_draft_title')
404 416 && defined('Metasync_OpenGraph::AUTO_DRAFT_PRONE_KEYS')
405 417 && in_array($key, Metasync_OpenGraph::AUTO_DRAFT_PRONE_KEYS, true)
406 418 ) {
407 - return Metasync_OpenGraph::strip_auto_draft_title($value);
419 + $value = Metasync_OpenGraph::strip_auto_draft_title($value);
408 420 }
409 421
422 + // A social title that is a verbatim snapshot of the post title is the
423 + // old pre-fill, not a customization — mirroring it would hand a
424 + // third-party plugin a copy that a rename leaves stale (and that
425 + // outranks OTTO's fresh value there). Collapsed for the same reason
426 + // as the placeholder above; the chain in $first then falls through
427 + // to OTTO's staging key.
428 + // @phpstan-ignore-next-line function.alreadyNarrowedType
429 + if (method_exists('Metasync_OpenGraph', 'strip_title_snapshot')
430 + && defined('Metasync_OpenGraph::TITLE_DEFAULTED_KEYS')
431 + && in_array($key, Metasync_OpenGraph::TITLE_DEFAULTED_KEYS, true)
432 + ) {
433 + $value = Metasync_OpenGraph::strip_title_snapshot($post_id, $key, $value);
434 + }
435 +
436 + // A social description that is a verbatim snapshot of the resolved
437 + // excerpt is the old pre-fill, not a customization — mirroring it
438 + // would hand a third-party plugin a copy that a later excerpt or
439 + // content edit leaves stale. Collapsed for the same reason as the
440 + // title snapshot above.
441 + // @phpstan-ignore-next-line function.alreadyNarrowedType
442 + if (method_exists('Metasync_OpenGraph', 'strip_description_snapshot')
443 + && defined('Metasync_OpenGraph::DESCRIPTION_DEFAULTED_KEYS')
444 + && in_array($key, Metasync_OpenGraph::DESCRIPTION_DEFAULTED_KEYS, true)
445 + ) {
446 + $value = Metasync_OpenGraph::strip_description_snapshot($post_id, $key, $value);
447 + }
448 +
410 449 return $value;
411 450 };
412 451
413 452 $data = [];
@@ -524,9 +563,13 @@
524 563 // Canonical, focus keyword, breadcrumb
525 564 // Canonical is validated at the source so a corrupted value ("Array")
526 565 // never propagates into Yoast/RankMath/AIOSEO storage.
527 566 $data['canonical'] = Metasync_Canonical_Sanitizer::sanitize($get('_metasync_canonical_url'));
528 - $data['focus_keyword'] = $first('_metasync_focus_keyword', '_metasync_otto_keywords');
567 + // The keyword takes its order from the resolver — customer value, then
568 + // OTTO's volatile tier, then OTTO's persisted tier — so the persistence
569 + // gating in $first() reaches the persisted copy too. Previously the
570 + // persisted copy sat on the customer key, outranking the live one.
571 + $data['focus_keyword'] = $first(...Metasync_Seo_Precedence::keys(Metasync_Seo_Precedence::FIELD_FOCUS_KEYWORD));
529 572 $data['breadcrumb_title'] = $get('_metasync_breadcrumb_title');
530 573
531 574 return $this->apply_feature_flags_to_payload($data);
532 575 }
@@ -660,35 +703,85 @@
660 703 // Per-plugin sync
661 704 // ------------------------------------------------------------------
662 705
663 706 /**
707 + * Whether third-party SEO storage may be written at all.
708 + *
709 + * The site owner's consent switch. Checked once per plugin dispatch rather
710 + * than per field so a sync that is not permitted does no work and, more
711 + * importantly, leaves no half-written row behind.
712 + *
713 + * @return bool
714 + */
715 + private function third_party_writes_allowed() {
716 + return class_exists('Metasync_Seo_Backup') && Metasync_Seo_Backup::is_enabled();
717 + }
718 +
719 + /**
720 + * Write one third-party post-meta field, preserving what it held before.
721 + *
722 + * This bridge runs on `updated_post_meta`, which means it fires from inside
723 + * an OTTO sync's `_metasync_otto_*` write — before the same sync reaches its
724 + * own direct Rank Math / Yoast writes further down. It is therefore usually
725 + * the first code to touch the customer's value, and the backup it takes here
726 + * is the one that holds the true original.
727 + *
728 + * @param int $post_id Post ID.
729 + * @param string $key Third-party meta key.
730 + * @param mixed $value Value to write.
731 + * @return bool True when the write happened.
732 + */
733 + private function write_post_field($post_id, $key, $value) {
734 + return class_exists('Metasync_Seo_Backup')
735 + && Metasync_Seo_Backup::write_post_meta($post_id, $key, $value);
736 + }
737 +
738 + /**
664 739 * Mirror canonical data into Yoast post meta and indexable cache.
665 740 *
666 741 * @param int $post_id Post ID.
667 742 * @param array $data Canonical key/value pairs.
668 - * @return bool True once dispatch completes.
743 + * @return bool True when at least one value-bearing field was mirrored,
744 + * false when the payload carried nothing to write. The caller
745 + * stamps `_metasync_plugin_sync_ts` from this, so it must
746 + * describe what was written and not merely that dispatch was
747 + * reached.
748 + *
749 + * Robots directives are excluded from that answer on purpose.
750 + * collect_post_data() synthesises noindex/nofollow on every
751 + * payload — absent any stored value they resolve to plain
752 + * index/follow — so they are written on every sync and say
753 + * nothing about whether a canonical value existed to mirror.
754 + * Counting them would make the result unconditionally true,
755 + * which is the bug this return contract exists to fix.
669 756 */
670 757 private function sync_yoast($post_id, array $data) {
758 + if (!$this->third_party_writes_allowed()) {
759 + return false;
760 + }
761 +
762 + $wrote = false;
763 +
671 764 // title
672 765 if (!empty($data['title'])) {
673 - update_post_meta($post_id, '_yoast_wpseo_title', (string) $data['title']);
766 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_title', (string) $data['title']);
674 767 }
675 768
676 769 // description -- strip newlines first
677 770 if (!empty($data['desc'])) {
678 771 $desc = str_replace(["\n", "\r", "\t"], ' ', $data['desc']);
679 - update_post_meta($post_id, '_yoast_wpseo_metadesc', $desc);
772 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_metadesc', $desc) || $wrote;
680 773 }
681 774
682 775 // noindex: '0'=default, '1'=noindex, '2'=index
683 776 if (array_key_exists('noindex', $data)) {
684 777 $val = $data['noindex'] ? '1' : '2';
685 - update_post_meta($post_id, '_yoast_wpseo_meta-robots-noindex', $val);
778 + $this->write_post_field($post_id, '_yoast_wpseo_meta-robots-noindex', $val);
686 779 }
687 780
688 781 // nofollow: '0'=follow, '1'=nofollow
689 782 if (array_key_exists('nofollow', $data)) {
690 - update_post_meta($post_id, '_yoast_wpseo_meta-robots-nofollow', $data['nofollow'] ? '1' : '0');
783 + $this->write_post_field($post_id, '_yoast_wpseo_meta-robots-nofollow', $data['nofollow'] ? '1' : '0');
691 784 }
692 785
693 786 // advanced robots: comma-separated NO spaces
694 787 $adv = [];
@@ -700,38 +793,41 @@
700 793 }
701 794 if (!empty($data['noimageindex'])) {
702 795 $adv[] = 'noimageindex';
703 796 }
704 - update_post_meta($post_id, '_yoast_wpseo_meta-robots-adv', implode(',', $adv));
797 + // Written unconditionally so clearing the last directive clears the
798 + // field. Like the other robots writes it carries no canonical value,
799 + // so it does not make this a successful sync.
800 + $this->write_post_field($post_id, '_yoast_wpseo_meta-robots-adv', implode(',', $adv));
705 801
706 802 // OG
707 803 if (!empty($data['og_title'])) {
708 - update_post_meta($post_id, '_yoast_wpseo_opengraph-title', $data['og_title']);
804 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_opengraph-title', $data['og_title']) || $wrote;
709 805 }
710 806 if (!empty($data['og_desc'])) {
711 - update_post_meta($post_id, '_yoast_wpseo_opengraph-description', $data['og_desc']);
807 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_opengraph-description', $data['og_desc']) || $wrote;
712 808 }
713 809 if (!empty($data['og_image'])) {
714 - update_post_meta($post_id, '_yoast_wpseo_opengraph-image', esc_url_raw($data['og_image']));
810 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_opengraph-image', esc_url_raw($data['og_image'])) || $wrote;
715 811 }
716 812
717 813 // Twitter
718 814 if (!empty($data['twitter_title'])) {
719 - update_post_meta($post_id, '_yoast_wpseo_twitter-title', $data['twitter_title']);
815 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_twitter-title', $data['twitter_title']) || $wrote;
720 816 }
721 817 if (!empty($data['twitter_desc'])) {
722 - update_post_meta($post_id, '_yoast_wpseo_twitter-description', $data['twitter_desc']);
818 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_twitter-description', $data['twitter_desc']) || $wrote;
723 819 }
724 820
725 821 // Canonical, focus keyword, breadcrumb
726 822 if (!empty($data['canonical'])) {
727 - update_post_meta($post_id, '_yoast_wpseo_canonical', esc_url_raw($data['canonical']));
823 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_canonical', esc_url_raw($data['canonical'])) || $wrote;
728 824 }
729 825 if (!empty($data['focus_keyword'])) {
730 - update_post_meta($post_id, '_yoast_wpseo_focuskw', $data['focus_keyword']);
826 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_focuskw', $data['focus_keyword']) || $wrote;
731 827 }
732 828 if (!empty($data['breadcrumb_title'])) {
733 - update_post_meta($post_id, '_yoast_wpseo_bctitle', $data['breadcrumb_title']);
829 + $wrote = $this->write_post_field($post_id, '_yoast_wpseo_bctitle', $data['breadcrumb_title']) || $wrote;
734 830 }
735 831
736 832 // Update wp_yoast_indexable cache row for immediate effect
737 833 global $wpdb;
@@ -769,9 +865,9 @@
769 865 $updates['twitter_title'] = mb_substr($data['twitter_title'], 0, 191);
770 866 }
771 867 if (!empty($data['twitter_card'])) {
772 868 // twitter_card column only exists in newer Yoast versions; skip if absent
773 - $col_check = $wpdb->get_var($wpdb->prepare(
869 + $col_check = $wpdb->get_var($wpdb->prepare( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
774 870 "SELECT COUNT(*) FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_SCHEMA = %s AND TABLE_NAME = %s AND COLUMN_NAME = 'twitter_card'",
775 871 DB_NAME,
776 872 $indexable_table
777 873 ));
@@ -789,15 +885,38 @@
789 885 $updates['breadcrumb_title'] = mb_substr($data['breadcrumb_title'], 0, 191);
790 886 }
791 887
792 888 if (!empty($updates)) {
793 - $row_exists = $wpdb->get_var($wpdb->prepare(
794 - "SELECT id FROM {$indexable_table} WHERE object_id = %d AND object_type = 'post'",
889 + $row_exists = $wpdb->get_var($wpdb->prepare( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
890 + "SELECT id FROM {$wpdb->prefix}yoast_indexable WHERE object_id = %d AND object_type = 'post'",
795 891 $post_id
796 892 ));
797 893
894 + // This probe decides two things at once: the value of the write-once
895 + // row_existed marker, and whether the write below is an UPDATE or an
896 + // INSERT. A failed probe answers "no row" for a row that is really
897 + // there, which commits a '0' marker telling a restore to delete the
898 + // customer's row and fires an INSERT against a row that already
899 + // exists. Neither is correctable afterwards, so an unreadable probe
900 + // has to abandon the indexable write entirely.
901 + //
902 + // The post meta above has already landed, so the receipt still
903 + // reports it. Only the indexable is skipped.
904 + if (!Metasync_Seo_Backup::db_read_succeeded()) {
905 + return $wrote;
906 + }
907 +
908 + // No original saved means no write, exactly as on the AIOSEO table.
909 + // This row is what Yoast actually renders from, so a restore that
910 + // cannot reach it puts the meta back and leaves the customer's live
911 + // pages still showing OTTO's values.
912 + $backups_created = [];
913 + if (!$this->backup_yoast_indexable_columns($post_id, $indexable_table, $updates, (bool) $row_exists, $backups_created)) {
914 + return $wrote;
915 + }
916 +
798 917 if ($row_exists) {
799 - $wpdb->update(
918 + $wpdb->update( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
800 919 $indexable_table,
801 920 $updates,
802 921 ['object_id' => $post_id, 'object_type' => 'post']
803 922 );
@@ -817,12 +936,139 @@
817 936 'is_cornerstone' => 0,
818 937 'created_at' => current_time('mysql'),
819 938 'updated_at' => current_time('mysql'),
820 939 ], $updates);
821 - $wpdb->insert($indexable_table, $insert);
940 +
941 + // The row_existed='0' marker was recorded before this insert,
942 + // because a marker that will not save has to be able to veto the
943 + // write. A failed insert means no row of ours exists, and a
944 + // marker left saying otherwise would let a restore delete a row
945 + // Yoast or the customer creates afterwards. The per-column
946 + // backups recorded beside it go too: they are write-once, so a
947 + // column captured as NULL because there was no row would stay
948 + // NULL for good and blank a real value the customer later puts
949 + // in that row.
950 + //
951 + // The post meta above has already been written, so the return
952 + // still reports what landed. Claiming nothing was written would
953 + // tell the conflict handler this post is unsynced to Yoast while
954 + // Yoast's own meta holds our values, and it would hand tag
955 + // ownership to the wrong plugin.
956 + if ($wpdb->insert($indexable_table, $insert) === false) { // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
957 + Metasync_Seo_Backup::discard_backups('post', $post_id, $backups_created);
958 + return $wrote;
959 + }
822 960 }
823 961 }
824 962
963 + return $wrote;
964 + }
965 +
966 + /**
967 + * Preserve the wp_yoast_indexable columns this sync is about to overwrite.
968 + *
969 + * Yoast serves the frontend from this table, not from post meta, so the
970 + * meta backups taken by write_post_field() do not by themselves make the
971 + * change reversible. Same shape as backup_aioseo_columns():
972 + *
973 + * - one backup per column being written, so a restore can put the originals
974 + * back and leave every other column of the user's row alone;
975 + * - whether the row existed at all, so a restore can delete a row that only
976 + * exists because we created it instead of leaving an empty shell behind.
977 + *
978 + * @param int $post_id Post ID.
979 + * @param string $table Fully prefixed indexable table name.
980 + * @param array $updates Columns and values about to be written.
981 + * @param bool $row_existed Whether Yoast already had a row for this post.
982 + * @param array $created Out-param, filled with the backup fields this
983 + * call created, so a failed write can withdraw
984 + * exactly its own rows and no one else's.
985 + * @return bool True when every original was preserved and the caller may write.
986 + */
987 + private function backup_yoast_indexable_columns($post_id, $table, array $updates, $row_existed, array &$created) {
988 + $created = [];
989 +
990 + if (!class_exists('Metasync_Seo_Backup')) {
991 + return false;
992 + }
993 +
994 + global $wpdb;
995 +
996 + if (!Metasync_Seo_Backup::record_marker(
997 + 'post',
998 + $post_id,
999 + 'yoast_indexable_row_existed',
1000 + $row_existed ? '1' : '0',
1001 + $marker_created
1002 + )) {
1003 + return false;
1004 + }
1005 +
1006 + if ($marker_created) {
1007 + $created[] = 'yoast_indexable_row_existed';
1008 + }
1009 +
1010 + $columns = array_keys($updates);
1011 + if (empty($columns)) {
1012 + return true;
1013 + }
1014 +
1015 + $current = null;
1016 + if ($row_existed) {
1017 + $select = '`' . implode('`, `', array_map('esc_sql', $columns)) . '`';
1018 + // Column list is esc_sql()'d above; the table is a fixed literal.
1019 + $current = $wpdb->get_row( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
1020 + $wpdb->prepare(
1021 + // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- column list esc_sql()'d above, table is a fixed literal
1022 + "SELECT {$select} FROM {$wpdb->prefix}yoast_indexable WHERE object_id = %d AND object_type = 'post'",
1023 + $post_id
1024 + ),
1025 + ARRAY_A
1026 + );
1027 +
1028 + // The row was there a moment ago, so a null answer now is a failed
1029 + // read, not an empty row. Recording it as "every column was NULL"
1030 + // would tell a later restore to delete values it should put back,
1031 + // which is the exact loss this layer exists to prevent. No write is
1032 + // happening, so the marker recorded above has to go too — a marker
1033 + // left describing a write that never ran is a stale story.
1034 + if ($current === null || !Metasync_Seo_Backup::db_read_succeeded()) {
1035 + Metasync_Seo_Backup::discard_backups('post', $post_id, $created);
1036 + return false;
1037 + }
1038 + }
1039 +
1040 + foreach ($columns as $column) {
1041 + // A missing row and a NULL column are the same thing to a restore:
1042 + // there was no value here, so put nothing back.
1043 + $current_value = ($current !== null && isset($current[$column])) ? $current[$column] : null;
1044 +
1045 + $field = 'yoast_indexable_' . $column;
1046 +
1047 + // One unsaved column is enough to refuse the whole write: a
1048 + // half-original, half-OTTO row is something no restore can unpick.
1049 + // The refusal also means the caller writes nothing, so withdraw the
1050 + // marker and the columns recorded so far — the same rule as the
1051 + // failed-insert path in sync_yoast(). Left behind, a row_existed='0'
1052 + // marker would let a restore delete a row the customer creates
1053 + // later, and a NULL column backup would blank a real value in it.
1054 + if (!Metasync_Seo_Backup::backup_before_overwrite(
1055 + 'post',
1056 + $post_id,
1057 + $field,
1058 + $updates[$column],
1059 + $current_value,
1060 + $column_created
1061 + )) {
1062 + Metasync_Seo_Backup::discard_backups('post', $post_id, $created);
1063 + return false;
1064 + }
1065 +
1066 + if ($column_created) {
1067 + $created[] = $field;
1068 + }
1069 + }
1070 +
825 1071 return true;
826 1072 }
827 1073
828 1074 /**
@@ -829,17 +1075,25 @@
829 1075 * Mirror canonical data into Rank Math post meta.
830 1076 *
831 1077 * @param int $post_id Post ID.
832 1078 * @param array $data Canonical key/value pairs.
833 - * @return bool True once dispatch completes.
1079 + * @return bool True when at least one value-bearing field was mirrored,
1080 + * false when the payload carried nothing to write. Robots
1081 + * directives are excluded for the reason given on sync_yoast().
834 1082 */
835 1083 private function sync_rankmath($post_id, array $data) {
1084 + if (!$this->third_party_writes_allowed()) {
1085 + return false;
1086 + }
1087 +
1088 + $wrote = false;
1089 +
836 1090 // title, desc
837 1091 if (!empty($data['title'])) {
838 - update_post_meta($post_id, 'rank_math_title', $data['title']);
1092 + $wrote = $this->write_post_field($post_id, 'rank_math_title', $data['title']);
839 1093 }
840 1094 if (!empty($data['desc'])) {
841 - update_post_meta($post_id, 'rank_math_description', $data['desc']);
1095 + $wrote = $this->write_post_field($post_id, 'rank_math_description', $data['desc']) || $wrote;
842 1096 }
843 1097
844 1098 // robots: PHP indexed array
845 1099 if (array_key_exists('noindex', $data) || array_key_exists('nofollow', $data)) {
@@ -851,9 +1105,9 @@
851 1105 }
852 1106 if (array_key_exists('nofollow', $data)) {
853 1107 $robots[] = $data['nofollow'] ? 'nofollow' : 'follow';
854 1108 }
855 - update_post_meta($post_id, 'rank_math_robots', array_values(array_unique($robots)));
1109 + $this->write_post_field($post_id, 'rank_math_robots', array_values(array_unique($robots)));
856 1110 }
857 1111
858 1112 // Advanced robots: max-* go into rank_math_advanced_robots
859 1113 $adv_keys = ['max_snippet', 'max_image_preview', 'max_video_preview'];
@@ -881,9 +1135,9 @@
881 1135 $val = (int) $data['max_video_preview'];
882 1136 $adv['max-video-preview'] = (string) $val;
883 1137 }
884 1138 if (!empty($adv)) {
885 - update_post_meta($post_id, 'rank_math_advanced_robots', $adv);
1139 + $this->write_post_field($post_id, 'rank_math_advanced_robots', $adv);
886 1140 }
887 1141 }
888 1142
889 1143 // Sync noarchive/nosnippet/noimageindex into rank_math_robots
@@ -898,51 +1152,164 @@
898 1152 if (!empty($data[$dir])) {
899 1153 $robots[] = $dir;
900 1154 }
901 1155 }
902 - update_post_meta($post_id, 'rank_math_robots', array_values(array_unique($robots)));
1156 + $this->write_post_field($post_id, 'rank_math_robots', array_values(array_unique($robots)));
903 1157 }
904 1158
905 1159 // OG
906 1160 if (!empty($data['og_title'])) {
907 - update_post_meta($post_id, 'rank_math_facebook_title', $data['og_title']);
1161 + $wrote = $this->write_post_field($post_id, 'rank_math_facebook_title', $data['og_title']) || $wrote;
908 1162 }
909 1163 if (!empty($data['og_desc'])) {
910 - update_post_meta($post_id, 'rank_math_facebook_description', $data['og_desc']);
1164 + $wrote = $this->write_post_field($post_id, 'rank_math_facebook_description', $data['og_desc']) || $wrote;
911 1165 }
912 1166 if (!empty($data['og_image'])) {
913 - update_post_meta($post_id, 'rank_math_facebook_image', esc_url_raw($data['og_image']));
1167 + $wrote = $this->write_post_field($post_id, 'rank_math_facebook_image', esc_url_raw($data['og_image'])) || $wrote;
914 1168 $img_id = attachment_url_to_postid($data['og_image']);
915 1169 if ($img_id) {
916 - update_post_meta($post_id, 'rank_math_facebook_image_id', $img_id);
1170 + $wrote = $this->write_post_field($post_id, 'rank_math_facebook_image_id', $img_id) || $wrote;
917 1171 }
918 1172 }
919 1173
920 1174 // Twitter
921 1175 if (!empty($data['twitter_title'])) {
922 - update_post_meta($post_id, 'rank_math_twitter_title', $data['twitter_title']);
1176 + $wrote = $this->write_post_field($post_id, 'rank_math_twitter_title', $data['twitter_title']) || $wrote;
923 1177 }
924 1178 if (!empty($data['twitter_desc'])) {
925 - update_post_meta($post_id, 'rank_math_twitter_description', $data['twitter_desc']);
1179 + $wrote = $this->write_post_field($post_id, 'rank_math_twitter_description', $data['twitter_desc']) || $wrote;
926 1180 }
927 1181 if (!empty($data['twitter_card'])) {
928 1182 $valid_cards = ['summary', 'summary_large_image', 'app', 'player'];
929 1183 if (in_array($data['twitter_card'], $valid_cards, true)) {
930 - update_post_meta($post_id, 'rank_math_twitter_card_type', $data['twitter_card']);
1184 + $wrote = $this->write_post_field($post_id, 'rank_math_twitter_card_type', $data['twitter_card']) || $wrote;
931 1185 }
932 1186 }
933 1187
934 1188 // Canonical, focus keyword, breadcrumb
935 1189 if (!empty($data['canonical'])) {
936 - update_post_meta($post_id, 'rank_math_canonical_url', esc_url_raw($data['canonical']));
1190 + $wrote = $this->write_post_field($post_id, 'rank_math_canonical_url', esc_url_raw($data['canonical'])) || $wrote;
937 1191 }
938 1192 if (!empty($data['focus_keyword'])) {
939 - update_post_meta($post_id, 'rank_math_focus_keyword', $data['focus_keyword']);
1193 + $wrote = $this->write_post_field($post_id, 'rank_math_focus_keyword', $data['focus_keyword']) || $wrote;
940 1194 }
941 1195 if (!empty($data['breadcrumb_title'])) {
942 - update_post_meta($post_id, 'rank_math_breadcrumb_title', $data['breadcrumb_title']);
1196 + $wrote = $this->write_post_field($post_id, 'rank_math_breadcrumb_title', $data['breadcrumb_title']) || $wrote;
943 1197 }
944 1198
1199 + return $wrote;
1200 + }
1201 +
1202 + /**
1203 + * Preserve the AIOSEO columns a sync is about to overwrite.
1204 + *
1205 + * AIOSEO keeps post SEO data in its own `aioseo_posts` table rather than in
1206 + * post meta, so there is no meta row to save and no field a restore could
1207 + * delete. Two things are recorded instead, both as post meta on the post
1208 + * itself:
1209 + *
1210 + * - one backup per column being written, so a restore can put the original
1211 + * values back and leave every other column of the user's row alone;
1212 + * - whether the row existed at all, so a restore can delete a row that only
1213 + * exists because we created it instead of leaving an empty shell behind.
1214 + *
1215 + * @param int $post_id Post ID.
1216 + * @param string $table Fully prefixed AIOSEO table name.
1217 + * @param array $row Columns and values about to be written.
1218 + * @param bool $row_existed Whether AIOSEO already had a row for this post.
1219 + * @param array $created Out-param, filled with the backup fields this
1220 + * call created, so a failed write can withdraw
1221 + * exactly its own rows and no one else's.
1222 + * @return bool True when every original was preserved and the caller may write.
1223 + */
1224 + private function backup_aioseo_columns($post_id, $table, array $row, $row_existed, array &$created) {
1225 + $created = [];
1226 +
1227 + if (!class_exists('Metasync_Seo_Backup')) {
1228 + return false;
1229 + }
1230 +
1231 + global $wpdb;
1232 +
1233 + // Whether the row pre-existed is what a restore uses to choose between
1234 + // putting the original columns back and deleting a row that only exists
1235 + // because we made it. A marker that will not record is as disqualifying
1236 + // as a column that will not.
1237 + if (!Metasync_Seo_Backup::record_marker(
1238 + 'post',
1239 + $post_id,
1240 + 'aioseo_row_existed',
1241 + $row_existed ? '1' : '0',
1242 + $marker_created
1243 + )) {
1244 + return false;
1245 + }
1246 +
1247 + if ($marker_created) {
1248 + $created[] = 'aioseo_row_existed';
1249 + }
1250 +
1251 + $columns = array_diff(array_keys($row), ['updated', 'created', 'post_id']);
1252 + if (empty($columns)) {
1253 + return true;
1254 + }
1255 +
1256 + $current = null;
1257 + if ($row_existed) {
1258 + $select = '`' . implode('`, `', array_map('esc_sql', $columns)) . '`';
1259 + // Column list is esc_sql()'d above; the table is a fixed literal.
1260 + $current = $wpdb->get_row( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
1261 + $wpdb->prepare(
1262 + // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- column list esc_sql()'d above, table is a fixed literal
1263 + "SELECT {$select} FROM {$wpdb->prefix}aioseo_posts WHERE post_id = %d",
1264 + $post_id
1265 + ),
1266 + ARRAY_A
1267 + );
1268 +
1269 + // The row was there a moment ago, so a null answer now is a failed
1270 + // read, not an empty row. Recording it as "every column was NULL"
1271 + // would tell a later restore to delete values it should put back,
1272 + // which is the exact loss this layer exists to prevent. No write is
1273 + // happening, so the marker recorded above has to go too — a marker
1274 + // left describing a write that never ran is a stale story.
1275 + if ($current === null || !Metasync_Seo_Backup::db_read_succeeded()) {
1276 + Metasync_Seo_Backup::discard_backups('post', $post_id, $created);
1277 + return false;
1278 + }
1279 + }
1280 +
1281 + foreach ($columns as $column) {
1282 + // A missing row and a NULL column are the same thing to a restore:
1283 + // there was no value here, so put nothing back.
1284 + $current_value = ($current !== null && isset($current[$column])) ? $current[$column] : null;
1285 +
1286 + $field = 'aioseo_' . $column;
1287 +
1288 + // One unsaved column is enough to refuse the whole write: a half-original,
1289 + // half-OTTO row is something no restore can unpick. The refusal also
1290 + // means the caller writes nothing, so withdraw the marker and the
1291 + // columns recorded so far — the same rule as the failed-insert path
1292 + // in sync_aioseo(). Left behind, a row_existed='0' marker would let
1293 + // a restore delete a row the customer creates later, and a NULL
1294 + // column backup would blank a real value in it.
1295 + if (!Metasync_Seo_Backup::backup_before_overwrite(
1296 + 'post',
1297 + $post_id,
1298 + $field,
1299 + $row[$column],
1300 + $current_value,
1301 + $column_created
1302 + )) {
1303 + Metasync_Seo_Backup::discard_backups('post', $post_id, $created);
1304 + return false;
1305 + }
1306 +
1307 + if ($column_created) {
1308 + $created[] = $field;
1309 + }
1310 + }
1311 +
945 1312 return true;
946 1313 }
947 1314
948 1315 /**
@@ -949,54 +1316,73 @@
949 1316 * Mirror canonical data into the AIOSEO wp_aioseo_posts custom table.
950 1317 *
951 1318 * @param int $post_id Post ID.
952 1319 * @param array $data Canonical key/value pairs.
953 - * @return bool True when the row was written, false when the table is
954 - * missing or the write failed.
1320 + * @return bool True when at least one value-bearing field was written,
1321 + * false when the table is missing, the write failed, or the
1322 + * payload carried only robots directives. Robots are excluded
1323 + * for the reason given on sync_yoast(), so the receipt means
1324 + * the same thing for all three plugins.
955 1325 */
956 1326 private function sync_aioseo($post_id, array $data) {
957 1327 global $wpdb;
958 1328
1329 + if (!$this->third_party_writes_allowed()) {
1330 + return false;
1331 + }
1332 +
959 1333 $table = $wpdb->prefix . 'aioseo_posts';
960 1334
961 1335 // Bail if the AIOSEO post table does not exist (plugin not initialised).
962 - $table_exists = $wpdb->get_var($wpdb->prepare('SHOW TABLES LIKE %s', $table));
1336 + $table_exists = $wpdb->get_var($wpdb->prepare('SHOW TABLES LIKE %s', $table)); // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
963 1337 if ($table_exists !== $table) {
964 1338 return false;
965 1339 }
966 1340
967 1341 $row = [];
1342 + // Robots fill $row too, so a separate flag is needed: the row is still
1343 + // written for a robots-only payload, it just is not a content sync.
1344 + $wrote = false;
968 1345
969 1346 if (!empty($data['title'])) {
970 1347 $row['title'] = sanitize_text_field($data['title']);
1348 + $wrote = true;
971 1349 }
972 1350 if (!empty($data['desc'])) {
973 1351 $row['description'] = sanitize_text_field($data['desc']);
1352 + $wrote = true;
974 1353 }
975 1354 if (!empty($data['og_title'])) {
976 1355 $row['og_title'] = sanitize_text_field($data['og_title']);
1356 + $wrote = true;
977 1357 }
978 1358 if (!empty($data['og_desc'])) {
979 1359 $row['og_description'] = sanitize_text_field($data['og_desc']);
1360 + $wrote = true;
980 1361 }
981 1362 if (!empty($data['og_image'])) {
982 1363 $row['og_image_type'] = 'custom';
983 1364 $row['og_image_custom_url'] = esc_url_raw($data['og_image']);
1365 + $wrote = true;
984 1366 }
985 1367 if (!empty($data['twitter_title'])) {
986 1368 $row['twitter_title'] = sanitize_text_field($data['twitter_title']);
1369 + $wrote = true;
987 1370 }
988 1371 if (!empty($data['twitter_desc'])) {
989 1372 $row['twitter_description'] = sanitize_text_field($data['twitter_desc']);
1373 + $wrote = true;
990 1374 }
991 1375 if (!empty($data['twitter_card'])) {
992 1376 $valid_cards = ['default', 'summary', 'summary_large_image', 'player', 'app'];
993 1377 if (in_array($data['twitter_card'], $valid_cards, true)) {
994 1378 $row['twitter_card'] = $data['twitter_card'];
1379 + $wrote = true;
995 1380 }
996 1381 }
997 1382 if (!empty($data['canonical'])) {
998 1383 $row['canonical_url'] = esc_url_raw($data['canonical']);
1384 + $wrote = true;
999 1385 }
1000 1386
1001 1387 // focus keyword as keyphrases JSON
1002 1388 if (!empty($data['focus_keyword'])) {
@@ -1007,8 +1393,9 @@
1007 1393 'analysis' => new \stdClass(),
1008 1394 ],
1009 1395 'additional' => [],
1010 1396 ]);
1397 + $wrote = true;
1011 1398 }
1012 1399
1013 1400 // Robots
1014 1401 $has_robots = false;
@@ -1054,17 +1441,38 @@
1054 1441 }
1055 1442
1056 1443 $row['updated'] = current_time('mysql');
1057 1444
1058 - $existing_id = $wpdb->get_var($wpdb->prepare(
1059 - "SELECT id FROM {$table} WHERE post_id = %d",
1445 + $existing_id = $wpdb->get_var($wpdb->prepare( // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
1446 + "SELECT id FROM {$wpdb->prefix}aioseo_posts WHERE post_id = %d",
1060 1447 $post_id
1061 1448 ));
1062 1449
1450 + // An unreadable probe cannot be treated as "no row". It would commit a
1451 + // write-once row_existed='0' for a row AIOSEO really has -- which a
1452 + // restore reads as licence to delete it -- and send an INSERT at a row
1453 + // that already exists. Leave AIOSEO's row alone and let the next sync
1454 + // record the truth.
1455 + if (!Metasync_Seo_Backup::db_read_succeeded()) {
1456 + return false;
1457 + }
1458 +
1459 + // No original saved means no write. Overwriting anyway is the data loss
1460 + // this whole layer exists to prevent.
1063 1461 if ($existing_id) {
1064 - return $wpdb->update($table, $row, ['post_id' => $post_id]) !== false;
1462 + $backups_created = [];
1463 + if (!$this->backup_aioseo_columns($post_id, $table, $row, true, $backups_created)) {
1464 + return false;
1465 + }
1466 +
1467 + return ($wpdb->update($table, $row, ['post_id' => $post_id]) !== false) && $wrote; // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
1065 1468 }
1066 1469
1470 + $backups_created = [];
1471 + if (!$this->backup_aioseo_columns($post_id, $table, $row, false, $backups_created)) {
1472 + return false;
1473 + }
1474 +
1067 1475 // New row -- must include all NOT NULL columns with no defaults
1068 1476 $row['post_id'] = $post_id;
1069 1477 $row['created'] = current_time('mysql');
1070 1478 $robot_defaults = [
@@ -1078,9 +1486,23 @@
1078 1486 'robots_notranslate' => 0,
1079 1487 ];
1080 1488 $row = array_merge($robot_defaults, $row);
1081 1489
1082 - return $wpdb->insert($table, $row) !== false;
1490 + $inserted = $wpdb->insert($table, $row); // phpcs:ignore WordPress.DB.DirectDatabaseQuery -- mirrors SEO meta into third-party plugin storage (Yoast indexables/AIOSEO tables) — no WordPress API for their schemas
1491 +
1492 + // The row_existed='0' marker was recorded before the insert, because a
1493 + // marker that will not save has to be able to veto the write. If the
1494 + // insert then failed there is no row of ours, and leaving the marker
1495 + // behind would let a restore delete a row the customer creates later.
1496 + // The per-column backups beside it go too, or a column captured as NULL
1497 + // for a row that never existed would blank a real value the customer
1498 + // later puts in one.
1499 + if ($inserted === false) {
1500 + Metasync_Seo_Backup::discard_backups('post', $post_id, $backups_created);
1501 + return false;
1502 + }
1503 +
1504 + return $wrote;
1083 1505 }
1084 1506
1085 1507 // ------------------------------------------------------------------
1086 1508 // Two-way sync: sidebar JSON ↔ legacy meta boxes