← All changes | admin/class-ajax-handler.php +271 -9 3.2.18 → 3.2.24 View file →

		@@ -27,8 +27,9 @@
27	27	private function mxchat_init_ajax_hooks() {
28	28	// Settings AJAX
29	29	add_action('wp_ajax_mxchat_save_setting', array($this, 'mxchat_save_setting_callback'));
30	30	add_action('wp_ajax_mxchat_save_prompts_setting', array($this, 'mxchat_save_prompts_setting_callback'));
	31	+ add_action('wp_ajax_mxchat_acf_toggle_group', array($this, 'mxchat_acf_toggle_group_callback'));
31	32	add_action('wp_ajax_migrate_pinecone_settings', array($this, 'ajax_migrate_pinecone_settings'));
32	33
33	34	// License AJAX
34	35	add_action('wp_ajax_mxchat_handle_activate_license', array($this, 'mxchat_handle_activate_license'));
		@@ -429,8 +430,34 @@
429	430	update_option('mxchat_acf_pdf_extraction', $apx_value);
430	431	wp_send_json_success(['message' => esc_html__('Setting saved', 'mxchat')]);
431	432	return;
432	433
	434	+ // In-chat YouTube card: master switch + its own confidence floor
	435	+ // (plan f52492). STANDALONE options, same pattern as the cases above.
	436	+ // Default ON — the card already ships, so this is an opt-OUT.
	437	+ case 'mxchat_video_embed_enabled':
	438	+ $vce_value = ($value === 'on' || $value === '1') ? 'on' : 'off';
	439	+ update_option('mxchat_video_embed_enabled', $vce_value);
	440	+ wp_send_json_success(['message' => esc_html__('Setting saved', 'mxchat')]);
	441	+ return;
	442	+
	443	+ // Clamped to the same 20-95 the field advertises. An out-of-range or
	444	+ // non-numeric POST is corrected rather than refused, and the corrected
	445	+ // value is echoed back so the field can reconcile — a silently stored
	446	+ // 0 here would put a video on every answer, which is the bug.
	447	+ case 'mxchat_video_embed_threshold':
	448	+ $vct_value = is_numeric($value)
	449	+ ? (int) $value
	450	+ : MXCHAT_VIDEO_EMBED_THRESHOLD_DEFAULT;
	451	+ if ($vct_value < 20) { $vct_value = 20; }
	452	+ if ($vct_value > 95) { $vct_value = 95; }
	453	+ update_option('mxchat_video_embed_threshold', $vct_value);
	454	+ wp_send_json_success([
	455	+ 'message' => esc_html__('Setting saved', 'mxchat'),
	456	+ 'value' => $vct_value,
	457	+ ]);
	458	+ return;
	459	+
433	460	// Live-agent availability schedules (plans 8ccaa2 + 99d7a4). STANDALONE
434	461	// options, same reasoning as the Editor Assistant case above — nested
435	462	// structures that mxchat_sanitize() would strip on the next autosave of any
436	463	// other field. Each channel's value arrives as JSON from its own hidden
		@@ -439,8 +466,9 @@
439	466	// browser still running pre-split cached admin JS: that UI edited "both
440	467	// channels" as one, so its save writes both.
441	468	case 'live_agent_schedule_slack':
442	469	case 'live_agent_schedule_telegram':
	470	+ case 'live_agent_schedule_webhook':
443	471	case 'live_agent_schedule':
444	472	if (!class_exists('MxChat_Live_Agent_Schedule')) {
445	473	wp_send_json_error(['message' => esc_html__('Schedule unavailable', 'mxchat')]);
446	474	return;
		@@ -552,8 +580,13 @@
552	580	case 'name_field_placeholder':
553	581	//error_log('MXChat Save: Processing name_field_placeholder');
554	582	$options[$field_name] = sanitize_text_field($value);
555	583	break;
	584	+ case 'consent_checkbox_label':
	585	+ // b062c4 — same allowlist as the options.php save path and the
	586	+ // widget render, so the stored label always equals the shown label.
	587	+ $options[$field_name] = MxChat_Utils::sanitize_consent_label($value);
	588	+ break;
556	589	case 'similarity_threshold':
557	590	//error_log('MXChat Save: Processing similarity_threshold');
558	591	// Validate and save - enforce min 20, max 85
559	592	$threshold = intval($value);
		@@ -580,8 +613,49 @@
580	613	//error_log('MXChat Save: Processing live_agent_status');
581	614	// Set the new value
582	615	$options[$field_name] = ($value === 'on') ? 'on' : 'off';
583	616	break;
	617	+ // Shared handoff channel (plan 1a2666): re-probe the channel's privacy
	618	+ // at configuration time so the settings screen can warn about private
	619	+ // channels (their inbound events arrive as message.groups, which the
	620	+ // documented app setup never subscribes to). Only id-shaped values can
	621	+ // be checked before the first handoff resolves a #name — the handoff
	622	+ // path probes those when it caches the resolved id.
	623	+ case 'live_agent_shared_channel':
	624	+ $options[$field_name] = sanitize_text_field($value);
	625	+ delete_option('mxchat_slack_shared_channel_privacy');
	626	+ $shared_channel_target = ltrim(trim((string) $options[$field_name]), '#');
	627	+ if ($shared_channel_target !== '' && preg_match('/^[CG][A-Z0-9]{6,}$/', $shared_channel_target)) {
	628	+ if (!class_exists('MxChat_Integrator')) {
	629	+ require_once plugin_dir_path(dirname(__FILE__)) . 'includes/class-mxchat-integrator.php';
	630	+ }
	631	+ MxChat_Integrator::mxchat_probe_slack_channel_privacy(
	632	+ $options['live_agent_bot_token'] ?? '',
	633	+ $shared_channel_target,
	634	+ trim((string) $options[$field_name])
	635	+ );
	636	+ }
	637	+ break;
	638	+ // Webhook handoff destination (plan d88e22). Status normalized like the
	639	+ // other channel toggles; the URL is refused outright when it isn't
	640	+ // https so the admin hears about it at save time instead of the
	641	+ // handoff silently never firing.
	642	+ case 'webhook_handoff_status':
	643	+ $options[$field_name] = ($value === 'on') ? 'on' : 'off';
	644	+ break;
	645	+ case 'webhook_handoff_url':
	646	+ $wh_url = trim((string) $value);
	647	+ if ($wh_url === '') {
	648	+ $options[$field_name] = '';
	649	+ break;
	650	+ }
	651	+ $wh_clean = esc_url_raw($wh_url, array('https'));
	652	+ if ($wh_clean === '' || stripos($wh_clean, 'https://') !== 0) {
	653	+ wp_send_json_error(['message' => esc_html__('Webhook URL must start with https://', 'mxchat')]);
	654	+ return;
	655	+ }
	656	+ $options[$field_name] = $wh_clean;
	657	+ break;
584	658	case 'enable_web_search':
585	659	//error_log('MXChat Save: Processing enable_web_search');
586	660	$options[$field_name] = ($value === 'on') ? 'on' : 'off';
587	661	break;
		@@ -629,9 +703,16 @@
629	703	$transcripts_options = array();
630	704	}
631	705
632	706	// Handle checkbox values (convert 'on'/'off' to 1/0)
633		- if ($value === 'on' || $value === '1') {
	707	+ if ($field_name === 'mxchat_retention_days') {
	708	+ // Number field, NOT a checkbox — without this branch a
	709	+ // value of '1' would hit the 'on'/'1' coercion below
	710	+ // (harmlessly) but nothing would clamp: this direct-DB
	711	+ // path bypasses the registered sanitiser and its
	712	+ // 0-3650 clamp entirely (plan-3c3338).
	713	+ $transcripts_options[$field_name] = max(0, min(3650, (int) $value));
	714	+ } else if ($value === 'on' || $value === '1') {
634	715	$transcripts_options[$field_name] = 1;
635	716	} else if ($value === 'off' || $value === '0' || $value === '') {
636	717	$transcripts_options[$field_name] = 0;
637	718	} else {
		@@ -636,9 +717,20 @@
636	717	$transcripts_options[$field_name] = 0;
637	718	} else {
638	719	// For text/select fields, sanitize appropriately
639	720	if ($field_name === 'mxchat_notification_email') {
640		- $transcripts_options[$field_name] = sanitize_email($value);
	721	+ // sanitize_email() alone CANNOT validate this field: given
	722	+ // "[email protected], [email protected]" it returns the single concatenated
	723	+ // address "[email protected]", which is_email() then accepts.
	724	+ // That is how two addresses used to be stored as one dead
	725	+ // one, silently. MxChat_Utils validates the raw parts first
	726	+ // and refuses the whole list if any of them is bad.
	727	+ $parsed = MxChat_Utils::parse_notification_emails($value);
	728	+ if ($parsed['error'] !== '') {
	729	+ // Reject: the previously stored value stays untouched.
	730	+ wp_send_json_error(array('message' => $parsed['error']));
	731	+ }
	732	+ $transcripts_options[$field_name] = implode(', ', $parsed['emails']);
641	733	} else {
642	734	$transcripts_options[$field_name] = sanitize_text_field($value);
643	735	}
644	736	}
		@@ -815,8 +907,10 @@
815	907	'contextual_awareness_toggle',
816	908	'citation_links_toggle',
817	909	'enable_email_block',
818	910	'enable_name_field',
	911	+ 'enable_consent_checkbox',
	912	+ 'consent_checkbox_required',
819	913	'custom_provider_for_embeddings',
820	914	'custom_provider_for_images',
821	915	'print_button_enabled',
822	916	'reset_chat_enabled'
		@@ -963,8 +1057,42 @@
963	1057	if ($field_name === 'mxchat_pinecone_host') {
964	1058	$new_value = str_replace(['https://', 'http://'], '', $new_value);
965	1059	}
966	1060	break;
	1061	+ case 'mxchat_pinecone_index_type':
	1062	+ // 362c31: document only once the host has been checked (see sanitize_pinecone_settings).
	1063	+ $new_value = ($value === 'document') ? 'document' : 'vector';
	1064	+ if ($new_value === 'document' && strtolower(trim((string) ($current_options['mxchat_pinecone_host'] ?? ''), '/')) !== strtolower((string) ($current_options['mxchat_pinecone_docs_verified_host'] ?? ''))) {
	1065	+ wp_send_json_error(['message' => esc_html__('Check the document index host first (Check index or Create index for me).', 'mxchat')]);
	1066	+ }
	1067	+ // 3e83e4: same gate as the form save — no switch onto a half-copied index.
	1068	+ if ($new_value === 'document' && (($current_options['mxchat_pinecone_index_type'] ?? 'vector') !== 'document') && class_exists('MxChat_Pinecone_Documents')) {
	1069	+ $running = MxChat_Pinecone_Documents::migration_blocks_switch((string) ($current_options['mxchat_pinecone_host'] ?? ''));
	1070	+ if ($running !== null) {
	1071	+ wp_send_json_error(['message' => MxChat_Pinecone_Documents::switch_blocked_message($running)]);
	1072	+ }
	1073	+ }
	1074	+ break;
	1075	+ case 'mxchat_pinecone_vector_host':
	1076	+ $new_value = trim(str_replace(['https://', 'http://'], '', sanitize_text_field($value)), '/');
	1077	+ break;
	1078	+ case 'mxchat_pinecone_vector_index':
	1079	+ case 'mxchat_pinecone_docs_region':
	1080	+ $new_value = sanitize_text_field($value);
	1081	+ break;
	1082	+ case 'mxchat_pinecone_docs_cloud':
	1083	+ $new_value = in_array($value, array('aws', 'gcp', 'azure'), true) ? $value : 'aws';
	1084	+ break;
	1085	+ case 'mxchat_pinecone_docs_language':
	1086	+ $lang_value = sanitize_key($value);
	1087	+ $new_value = (class_exists('MxChat_Pinecone_Documents') && array_key_exists($lang_value, MxChat_Pinecone_Documents::languages())) ? $lang_value : 'en';
	1088	+ break;
	1089	+ case 'mxchat_pinecone_top_k':
	1090	+ // d0cae1: out-of-range and junk normalize to the default 50 —
	1091	+ // same clamp the read site applies.
	1092	+ $top_k = absint($value);
	1093	+ $new_value = (string) (($top_k >= 1 && $top_k <= 1000) ? $top_k : 50);
	1094	+ break;
967	1095	default:
968	1096	wp_send_json_error(['message' => esc_html__('Unknown Pinecone field', 'mxchat')]);
969	1097	}
970	1098
		@@ -1121,10 +1249,18 @@
1121	1249	}
1122	1250
1123	1251	// Handle ACF field exclusion toggles
1124	1252	if (strpos($name, 'mxchat_acf_field_') === 0) {
1125		- // Extract field name from the input name (e.g., mxchat_acf_field_private_notes -> private_notes)
1126		- $field_name = str_replace('mxchat_acf_field_', '', $name);
	1253	+ // The identifier after the prefix is the ACF field KEY (unique per
	1254	+ // field), not the field name — names are shared across groups and
	1255	+ // collide (plan 30e81f). Reject anything that isn't key-shaped so a
	1256	+ // stale pre-3.2.20 page (or its exit beacon) posting a bare name
	1257	+ // can't write junk into the key-based list.
	1258	+ $field_key = str_replace('mxchat_acf_field_', '', $name);
	1259	+ if (!preg_match('/^field_[A-Za-z0-9_\-]+$/', $field_key)) {
	1260	+ wp_send_json_error(['message' => esc_html__('Invalid ACF field identifier', 'mxchat')]);
	1261	+ return;
	1262	+ }
1127	1263	$is_enabled = ($value === 'on' || $value === '1');
1128	1264
1129	1265	// Get current excluded fields
1130	1266	$excluded_fields = get_option('mxchat_acf_excluded_fields', array());
		@@ -1133,13 +1269,19 @@
1133	1269	}
1134	1270
1135	1271	if ($is_enabled) {
1136	1272	// Remove from exclusion list (field should be included)
1137		- $excluded_fields = array_values(array_diff($excluded_fields, array($field_name)));
	1273	+ $excluded_fields = array_values(array_diff($excluded_fields, array($field_key)));
	1274	+ // Lazy legacy-name conversion: if this field's NAME is still
	1275	+ // stored (its group was inactive when the 30e81f migration
	1276	+ // ran), including this one field must not silently include
	1277	+ // its same-named twins — swap the name entry for the keys of
	1278	+ // every OTHER field currently wearing that name.
	1279	+ $excluded_fields = $this->mxchat_expand_legacy_acf_name_entry($excluded_fields, $field_key);
1138	1280	} else {
1139	1281	// Add to exclusion list (field should be excluded)
1140		- if (!in_array($field_name, $excluded_fields)) {
1141		- $excluded_fields[] = $field_name;
	1282	+ if (!in_array($field_key, $excluded_fields, true)) {
	1283	+ $excluded_fields[] = $field_key;
1142	1284	}
1143	1285	}
1144	1286
1145	1287	$updated = update_option('mxchat_acf_excluded_fields', $excluded_fields);
		@@ -1146,10 +1288,10 @@
1146	1288
1147	1289	if ($updated || true) { // Always report success since the state may already be correct
1148	1290	wp_send_json_success([
1149	1291	'message' => $is_enabled
1150		- ? sprintf(esc_html__('Field "%s" will be included in imports', 'mxchat'), $field_name)
1151		- : sprintf(esc_html__('Field "%s" will be excluded from imports', 'mxchat'), $field_name)
	1292	+ ? esc_html__('Field will be included in imports', 'mxchat')
	1293	+ : esc_html__('Field will be excluded from imports', 'mxchat')
1152	1294	]);
1153	1295	} else {
1154	1296	wp_send_json_error(['message' => esc_html__('Failed to save ACF field setting', 'mxchat')]);
1155	1297	}
		@@ -1181,8 +1323,128 @@
1181	1323	wp_send_json_error(['message' => esc_html__('No changes detected', 'mxchat')]);
1182	1324	}
1183	1325	}
1184	1326
	1327	+ /**
	1328	+ * If the field behind $included_key still has its NAME stored in the
	1329	+ * exclusion list (a legacy entry the 30e81f migration could not resolve
	1330	+ * because the group was inactive), replace that name with the keys of
	1331	+ * every OTHER current field wearing it. Including one field must never
	1332	+ * silently include its same-named twins — that would be the original
	1333	+ * collision bug in reverse, in the unsafe (privacy-losing) direction.
	1334	+ */
	1335	+ private function mxchat_expand_legacy_acf_name_entry($excluded_fields, $included_key) {
	1336	+ if (!function_exists('acf_get_field')) {
	1337	+ return $excluded_fields;
	1338	+ }
	1339	+ $field = acf_get_field($included_key);
	1340	+ if (!$field || empty($field['name'])) {
	1341	+ return $excluded_fields;
	1342	+ }
	1343	+ $field_name = $field['name'];
	1344	+ if (!in_array($field_name, $excluded_fields, true)) {
	1345	+ return $excluded_fields;
	1346	+ }
	1347	+ $excluded_fields = array_values(array_diff($excluded_fields, array($field_name)));
	1348	+ foreach ($this->mxchat_acf_keys_for_name($field_name) as $twin_key) {
	1349	+ if ($twin_key !== $included_key && !in_array($twin_key, $excluded_fields, true)) {
	1350	+ $excluded_fields[] = $twin_key;
	1351	+ }
	1352	+ }
	1353	+ return $excluded_fields;
	1354	+ }
	1355	+
	1356	+ /**
	1357	+ * Keys of every currently-registered top-level ACF field with this name.
	1358	+ */
	1359	+ private function mxchat_acf_keys_for_name($field_name) {
	1360	+ $keys = array();
	1361	+ if (!function_exists('acf_get_field_groups') || !function_exists('acf_get_fields')) {
	1362	+ return $keys;
	1363	+ }
	1364	+ foreach (acf_get_field_groups() as $group) {
	1365	+ $group_fields = acf_get_fields($group['key']);
	1366	+ if (empty($group_fields)) {
	1367	+ continue;
	1368	+ }
	1369	+ foreach ($group_fields as $field) {
	1370	+ if (isset($field['name'], $field['key']) && $field['name'] === $field_name) {
	1371	+ $keys[] = $field['key'];
	1372	+ }
	1373	+ }
	1374	+ }
	1375	+ return $keys;
	1376	+ }
	1377	+
	1378	+ /**
	1379	+ * Group-level ACF toggle (plan bf57e0): sets every field in one ACF field
	1380	+ * group included or excluded in a SINGLE option write. The client must
	1381	+ * never loop the per-field endpoint for this — get_option → modify →
	1382	+ * update_option once per field from twenty concurrent requests is a
	1383	+ * lost-update race that silently drops most of the group.
	1384	+ */
	1385	+ public function mxchat_acf_toggle_group_callback() {
	1386	+ check_ajax_referer('mxchat_prompts_setting_nonce');
	1387	+
	1388	+ if (!current_user_can('manage_options')) {
	1389	+ wp_send_json_error(['message' => esc_html__('Insufficient permissions', 'mxchat')], 403);
	1390	+ return;
	1391	+ }
	1392	+
	1393	+ if (!function_exists('acf_get_fields')) {
	1394	+ wp_send_json_error(['message' => esc_html__('ACF is not active', 'mxchat')]);
	1395	+ return;
	1396	+ }
	1397	+
	1398	+ $group_key = isset($_POST['group_key']) ? sanitize_text_field(wp_unslash($_POST['group_key'])) : '';
	1399	+ if (!preg_match('/^group_[A-Za-z0-9_\-]+$/', $group_key)) {
	1400	+ wp_send_json_error(['message' => esc_html__('Invalid ACF group identifier', 'mxchat')]);
	1401	+ return;
	1402	+ }
	1403	+ $state = isset($_POST['state']) ? sanitize_text_field(wp_unslash($_POST['state'])) : '';
	1404	+ $include = ($state === 'on' || $state === '1');
	1405	+
	1406	+ // Resolve the group's fields SERVER-side — a client-supplied key list
	1407	+ // is not trusted. This is the same call the settings UI lists from,
	1408	+ // so the toggle covers exactly the rendered set (top-level fields).
	1409	+ $group_fields = acf_get_fields($group_key);
	1410	+ if (empty($group_fields)) {
	1411	+ wp_send_json_error(['message' => esc_html__('No fields found for this group', 'mxchat')]);
	1412	+ return;
	1413	+ }
	1414	+
	1415	+ $excluded_fields = get_option('mxchat_acf_excluded_fields', array());
	1416	+ if (!is_array($excluded_fields)) {
	1417	+ $excluded_fields = array();
	1418	+ }
	1419	+
	1420	+ $touched = array();
	1421	+ foreach ($group_fields as $field) {
	1422	+ if (empty($field['key'])) {
	1423	+ continue;
	1424	+ }
	1425	+ if ($include) {
	1426	+ $excluded_fields = array_values(array_diff($excluded_fields, array($field['key'])));
	1427	+ $excluded_fields = $this->mxchat_expand_legacy_acf_name_entry($excluded_fields, $field['key']);
	1428	+ } elseif (!in_array($field['key'], $excluded_fields, true)) {
	1429	+ $excluded_fields[] = $field['key'];
	1430	+ }
	1431	+ $touched[] = array(
	1432	+ 'name' => 'mxchat_acf_field_' . $field['key'],
	1433	+ 'value' => $include ? 'on' : 'off',
	1434	+ );
	1435	+ }
	1436	+
	1437	+ // The one write — the whole point of this endpoint.
	1438	+ update_option('mxchat_acf_excluded_fields', array_values($excluded_fields));
	1439	+
	1440	+ wp_send_json_success([
	1441	+ 'message' => $include
	1442	+ ? esc_html__('All fields in this group will be included in imports', 'mxchat')
	1443	+ : esc_html__('All fields in this group will be excluded from imports', 'mxchat'),
	1444	+ 'fields' => $touched,
	1445	+ ]);
	1446	+ }
1185	1447
1186	1448	/**
1187	1449	* Handles AJAX request for Pinecone settings migration
1188	1450	*/