PluginProbe
Patchstack – WordPress & Plugins Security / 2.1.24
Patchstack – WordPress & Plugins Security v2.1.24
2.3.7 trunk 2.1.0 2.1.1 2.1.10 2.1.11 2.1.12 2.1.13 2.1.14 2.1.15 2.1.16 2.1.17 2.1.18 2.1.19 2.1.2 2.1.20 2.1.21 2.1.22 2.1.23 2.1.24 2.1.25 2.1.3 2.1.4 2.1.5 2.1.6 All 49 releases
← All changes | includes/upload.php +74 -274 trunk2.1.24 View file →
@@ -20,24 +20,23 @@
20 20 public function __construct( $core ) {
21 21 parent::__construct( $core );
22 22
23 23 // In case the software has never been synchronized, force it.
24 - if ( ! get_option( 'patchstack_software_data_hash', false ) && ! get_option( 'patchstack_software_upload_attempted', false ) ) {
24 + if ( ! get_option( 'patchstack_software_data_hash', false ) ) {
25 25 $this->upload_software();
26 26 }
27 27
28 28 // Register the actions.
29 - add_action( 'patchstack_send_software_data', [ $this, 'upload_software' ] );
30 - add_action( 'patchstack_send_hacker_logs', [ $this, 'upload_firewall_logs' ] );
31 - add_action( 'patchstack_send_event_logs', [ $this, 'upload_activity_logs' ] );
32 - add_action( 'patchstack_import_ap_logs', [ $this, 'import_ap_logs' ] );
29 + add_action( 'patchstack_send_software_data', array( $this, 'upload_software' ) );
30 + add_action( 'patchstack_send_hacker_logs', array( $this, 'upload_firewall_logs' ) );
31 + add_action( 'patchstack_send_event_logs', array( $this, 'upload_activity_logs' ) );
33 32
34 33 // In case a plugin or upgrade has been performed, re-synchronize with the app.
35 - add_action( 'activated_plugin', [ $this, 'upload_software' ] );
36 - add_action( 'deactivated_plugin', [ $this, 'upload_software' ] );
37 - add_action( 'deleted_plugin', [ $this, 'upload_software' ] );
38 - add_action( 'upgrader_process_complete', [ $this, 'upload_software' ] );
39 - add_action( '_core_updated_successfully', [ &$this, 'upload_software' ] );
34 + add_action( 'activated_plugin', array( $this, 'upload_software' ) );
35 + add_action( 'deactivated_plugin', array( $this, 'upload_software' ) );
36 + add_action( 'deleted_plugin', array( $this, 'upload_software' ) );
37 + add_action( 'upgrader_process_complete', array( $this, 'upload_software' ) );
38 + add_action( '_core_updated_successfully', array( &$this, 'upload_software' ) );
40 39 }
41 40
42 41 /**
43 42 * Synchronize the software data with our API.
@@ -48,19 +47,14 @@
48 47 public function upload_software() {
49 48 // Get the software data and hash.
50 49 $data = $this->get_software_data();
51 50 $hash = sha1( json_encode( $data ) );
52 -
53 - // Do not sync for no reason.
54 - if ( ! defined( 'DOING_CRON' ) && ! isset( $_POST['patchstack_secret'] ) && get_option( 'patchstack_software_data_hash', false ) === $hash && ! is_admin() && ! defined( 'WP_CLI' ) ) {
51 + if ( ! defined( 'DOING_CRON' ) && ! isset( $_POST['webarx_secret'] ) && get_option( 'patchstack_software_data_hash', false ) === $hash && ! is_admin() ) {
55 52 return;
56 53 }
57 54
58 - // Make sure to not keep calling this function.
59 - update_option( 'patchstack_software_upload_attempted', 1 );
60 -
61 55 // Synchronize the software list with the API.
62 - $results = $this->plugin->api->upload_software( [ 'software' => json_encode( $data ) ] );
56 + $results = $this->plugin->api->upload_software( array( 'software' => json_encode( $data ) ) );
63 57 if ( isset( $results['success'] ) ) {
64 58 update_option( 'patchstack_software_data_hash', $hash );
65 59
66 60 // The result will also contain a list of all vulnerable plugins on the site that is returned by the API.
@@ -65,34 +59,13 @@
65 59
66 60 // The result will also contain a list of all vulnerable plugins on the site that is returned by the API.
67 61 // If the auto update setting is enabled for vulnerable plugins, perform the update once the 15 minute
68 62 // scheduled task "patchstack_update_plugins" is executed.
69 - $update = get_site_option( 'patchstack_auto_update', [] );
63 + $update = get_site_option( 'patchstack_auto_update', array() );
70 64 if ( isset( $results['vulnerable'] ) && is_array( $update ) && in_array( 'vulnerable', $update ) ) {
71 65 update_site_option( 'patchstack_vulnerable_plugins', $results['vulnerable'] );
72 66 }
73 67
74 - // If we have vulnerable plugins, determine if we had them before and if not, pull latest firewall rules.
75 - if ( isset( $results['vulnerable'] ) && count( $results['vulnerable'] ) > 0 ) {
76 - $prev = get_site_option( 'patchstack_latest_vulnerable', [] );
77 - foreach ( $results['vulnerable'] as $vuln ) {
78 - if ( is_array( $prev ) && ! in_array ( $vuln, $prev ) ) {
79 - do_action( 'patchstack_post_dynamic_firewall_rules' );
80 - break;
81 - }
82 - }
83 -
84 - update_site_option( 'patchstack_latest_vulnerable', $results['vulnerable'] );
85 - } else {
86 - update_site_option( 'patchstack_latest_vulnerable', [] );
87 - }
88 -
89 - // If we received the number of vulnerable count.
90 - if ( isset ( $results['vulnerability_count'], $results['vulnerability_fix_count'] ) ) {
91 - update_option( 'patchstack_vulns_present', $results['vulnerability_count'] );
92 - update_option( 'patchstack_fixes_present', $results['vulnerability_fix_count'] );
93 - }
94 -
95 68 return $results;
96 69 }
97 70
98 71 return;
@@ -104,90 +77,55 @@
104 77 * @return void
105 78 */
106 79 public function upload_firewall_logs() {
107 80 global $wpdb;
81 + $lastid = get_option( 'patchstack_firewall_log_lastid', 0 );
82 + $items = $wpdb->get_results( $wpdb->prepare( 'SELECT ip, log_date, request_uri, user_agent, fid, method, post_data FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE id > %d ORDER BY id', $lastid ) );
108 83
109 - // Do not execute upload action on free sites.
110 - if ( ! $this->license_is_active() || $this->get_option( 'patchstack_license_free', 0 ) == 1 ) {
84 + // No need to synchronize if there are no new logs present.
85 + if ( $wpdb->num_rows == 0 ) {
111 86 return;
112 87 }
113 88
114 - // Do not process if we are already processing a previous batch.
115 - if ( get_option( 'patchstack_firewall_log_processing', false ) ) {
116 - return;
117 - }
89 + // Construct the array to be uploaded to our API.
90 + $logs = array();
91 + foreach ( $items as $item ) {
118 92
119 - update_option( 'patchstack_firewall_log_processing', 1 );
120 -
121 - // Attempt to fetch data, if any.
122 - $lastId = get_option( 'patchstack_firewall_log_lastid', 0 );
123 - $successId = $lastId;
124 -
125 - // Do a maximum of 100 log entries per cronjob.
126 - for ($i = 0; $i <= 1; $i++) {
127 - // Pull the data from the database, in batches of 100.
128 - $items = $wpdb->get_results(
129 - $wpdb->prepare(
130 - 'SELECT id, ip, log_date, request_uri, user_agent, fid, method, post_data FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE id > %d ORDER BY id LIMIT 0,100',
131 - $lastId
132 - )
133 - );
134 -
135 - // No need to continue if we have no data.
136 - if ( $wpdb->num_rows == 0 ) {
137 - update_option( 'patchstack_firewall_log_lastid', 0 );
138 - break;
93 + // Entries that we don't want to store on the API side.
94 + if ( stripos( $item->request_uri, 'wp-comments-post' ) !== false ) {
95 + continue;
139 96 }
140 -
141 - // Construct the array to be uploaded to our API.
142 - $logs = [];
143 - foreach ( $items as $item ) {
144 97
145 - // Always advance the cursor so filtered rows don't stall the batch.
146 - $lastId = $item->id;
147 -
148 - // Entries that we don't want to store on the API side.
149 - if ( stripos( $item->request_uri, 'wp-comments-post' ) !== false ) {
150 - continue;
151 - }
152 -
153 - // Push to entries to be uploaded.
154 - $logs[] = [
155 - 'ip' => $item->ip,
156 - 'fid' => $item->fid,
157 - 'request_uri' => $item->request_uri,
158 - 'user_agent' => $item->user_agent,
159 - 'method' => $item->method,
160 - 'log_date' => $item->log_date,
161 - 'post_data' => $item->post_data,
162 - ];
163 - }
164 -
165 - // JSON encode the logs and upload.
166 - $logs = json_encode( $logs );
167 - $results = $this->plugin->api->upload_firewall_logs(
168 - [
169 - 'logs' => $logs,
170 - 'type' => 'firewall',
171 - ]
98 + // Push to entries to be uploaded.
99 + $logs[] = array(
100 + 'ip' => $item->ip,
101 + 'fid' => $item->fid,
102 + 'request_uri' => $item->request_uri,
103 + 'user_agent' => $item->user_agent,
104 + 'method' => $item->method,
105 + 'log_date' => $item->log_date,
106 + 'post_data' => $item->post_data,
172 107 );
108 + }
173 109
174 - // A failed upload returns a status code or null instead of an array;
175 - // bail without advancing so the logs are not deleted before they reach the API.
176 - if ( ! is_array( $results ) || isset( $results['errors'] ) ) {
177 - update_option( 'patchstack_firewall_log_lastid', $successId );
178 - break;
179 - }
180 -
181 - $successId = $lastId;
182 - update_option( 'patchstack_firewall_log_lastid', $successId );
110 + // JSON encode the logs and upload.
111 + $logs = json_encode( $logs );
112 + $results = $this->plugin->api->upload_firewall_logs(
113 + array(
114 + 'logs' => $logs,
115 + 'type' => 'firewall',
116 + )
117 + );
118 + if ( isset( $results['errors'] ) ) {
119 + return;
183 120 }
184 121
185 - // Delete the logs.
186 - $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE id <= ' . (int) $successId );
122 + // Get the most recent id of the logs.
123 + $lastid = $wpdb->get_var( 'SELECT id FROM ' . $wpdb->prefix . 'patchstack_firewall_log ORDER BY id DESC LIMIT 0, 1' );
124 + update_option( 'patchstack_firewall_log_lastid', $lastid );
187 125
188 - // No longer processing.
189 - update_option( 'patchstack_firewall_log_processing', 0 );
126 + // Delete logs that are older than 2 weeks.
127 + $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE log_date < DATE_SUB(NOW(), INTERVAL 14 DAY)' );
190 128 }
191 129
192 130 /**
193 131 * Synchronize the activity logs with our API.
@@ -196,20 +134,8 @@
196 134 */
197 135 public function upload_activity_logs() {
198 136 global $wpdb;
199 137
200 - // Do not execute upload action on free sites.
201 - if ( ! $this->license_is_active() || $this->get_option( 'patchstack_license_free', 0 ) == 1 ) {
202 - return;
203 - }
204 -
205 - // Do not process if we are already processing a previous batch.
206 - if ( get_option( 'patchstack_eventlog_processing', false ) ) {
207 - return;
208 - }
209 -
210 - update_option( 'patchstack_eventlog_processing', 1 );
211 -
212 138 // Determine if we should upload failed logins to the app.
213 139 $where = " AND action != 'failed login' ";
214 140 if ( $this->get_option( 'patchstack_activity_log_failed_logins_db', 0 ) == 1 ) {
215 141 $where = ' ';
@@ -214,52 +140,28 @@
214 140 if ( $this->get_option( 'patchstack_activity_log_failed_logins_db', 0 ) == 1 ) {
215 141 $where = ' ';
216 142 }
217 143
218 - // Attempt to fetch data, if any.
219 - $lastId = get_option( 'patchstack_eventlog_lastid', 0 );
220 - $successId = $lastId;
144 + // Do we have data to upload?
145 + $lastid = get_option( 'patchstack_eventlog_lastid', 0 );
146 + $items = $wpdb->get_results( $wpdb->prepare( 'SELECT author, ip, object, object_id, object_name, action, date FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE id > %d' . $where . 'ORDER BY id', array( $lastid ) ) );
147 + if ( $wpdb->num_rows == 0 ) {
148 + return;
149 + }
221 150
222 - // Do a maximum of several hundred log entries per cronjob.
223 - for ($i = 0; $i <= 1; $i++) {
224 - // Pull the data from the database, in batches of 100.
225 - $items = $wpdb->get_results(
226 - $wpdb->prepare(
227 - 'SELECT id, author, ip, object, object_id, object_name, action, date FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE id > %d' . $where . 'ORDER BY id LIMIT 0,100',
228 - $lastId
229 - ),
230 - ARRAY_A
231 - );
232 -
233 - // No need to continue if we have no data.
234 - if ( $wpdb->num_rows == 0 ) {
235 - update_option( 'patchstack_eventlog_lastid', 0 );
236 - break;
237 - }
238 -
239 - // Get the last ID in the result set.
240 - $lastId = $items[count($items) - 1]['id'];
241 -
242 - // Send to the API.
243 - $logs = json_encode( $items );
244 - $results = $this->plugin->api->upload_activity_logs( [ 'logs' => $logs ] );
245 -
246 - // A failed upload returns a status code or null instead of an array;
247 - // bail without advancing so the logs are not deleted before they reach the API.
248 - if ( ! is_array( $results ) || isset( $results['errors'] ) ) {
249 - update_option( 'patchstack_eventlog_lastid', $successId );
250 - break;
251 - }
252 -
253 - $successId = $lastId;
254 - update_option( 'patchstack_eventlog_lastid', $successId );
151 + // Send to the API.
152 + $logs = json_encode( $items );
153 + $results = $this->plugin->api->upload_activity_logs( array( 'logs' => $logs ) );
154 + if ( isset( $results['errors'] ) ) {
155 + return;
255 156 }
256 157
257 - // Delete the logs.
258 - $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE id <= ' . (int) $successId );
158 + // Get the most recent id of the logs.
159 + $lastid = $wpdb->get_var( 'SELECT id FROM ' . $wpdb->prefix . 'patchstack_event_log ORDER BY id DESC LIMIT 0, 1' );
160 + update_option( 'patchstack_eventlog_lastid', $lastid );
259 161
260 - // No longer processing.
261 - update_option( 'patchstack_eventlog_processing', 0 );
162 + // Delete logs that are older than 2 weeks.
163 + $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE date < DATE_SUB(NOW(), INTERVAL 14 DAY)' );
262 164 }
263 165
264 166 /**
265 167 * Obtain information about the software that the user has installed.
@@ -275,9 +177,9 @@
275 177 require_once ABSPATH . 'wp-admin/includes/update.php';
276 178 }
277 179
278 180 // Refetch updates data if we are performing a plugin listener related action.
279 - if ( isset( $_POST['patchstack_secret'] ) ) {
181 + if ( isset( $_POST['webarx_secret'] ) ) {
280 182 @require_once ABSPATH . 'wp-includes/update.php';
281 183 @wp_update_themes();
282 184 @wp_update_plugins();
283 185 }
@@ -285,9 +187,9 @@
285 187 // Fetch list of plugins.
286 188 $all_plugin = get_plugins();
287 189 $installed_plugins = array_keys( $all_plugin );
288 190 $updatable_plugins = get_plugin_updates();
289 - $software_list = [];
191 + $software_list = array();
290 192
291 193 foreach ( $installed_plugins as $plugin ) {
292 194 if ( ! file_exists( WP_PLUGIN_DIR . '/' . $plugin ) ) {
293 195 continue;
@@ -306,9 +208,9 @@
306 208 } else {
307 209 $active = (int) is_plugin_active( $plugin );
308 210 }
309 211
310 - $software_list[] = [
212 + $software_list[] = array(
311 213 'sw_type' => 'plugin',
312 214 'sw_name' => $plugin_name,
313 215 'sw_cur_ver' => $plugin_version,
314 216 'sw_new_ver' => $new_version,
@@ -313,9 +215,9 @@
313 215 'sw_cur_ver' => $plugin_version,
314 216 'sw_new_ver' => $new_version,
315 217 'sw_key' => $plugin,
316 218 'sw_active' => $active
317 - ];
219 + );
318 220 }
319 221 }
320 222
321 223 // Fetch list of themes.
@@ -330,15 +232,15 @@
330 232 $theme_name = $themes_data->get( 'Name' );
331 233 $theme_version = $themes_data->get( 'Version' );
332 234
333 235 if ( ! empty( $theme_name ) && ! empty( $theme_version ) ) {
334 - $software_list[] = [
236 + $software_list[] = array(
335 237 'sw_type' => 'theme',
336 238 'sw_name' => $theme_name,
337 239 'sw_cur_ver' => $theme_version,
338 240 'sw_new_ver' => $theme_new_version,
339 241 'sw_key' => $theme_key,
340 - ];
242 + );
341 243 }
342 244 }
343 245
344 246 // Fetch WordPress version.
@@ -344,124 +246,22 @@
344 246 // Fetch WordPress version.
345 247 global $wp_version;
346 248 $core_updates = get_core_updates();
347 249 $new_wp_version = ( ! empty( $core_updates ) && $core_updates[0]->response == 'upgrade' ) ? $core_updates[0]->version : '';
348 - $software_list[] = [
250 + $software_list[] = array(
349 251 'sw_type' => 'wordpress',
350 252 'sw_name' => 'WordPress',
351 253 'sw_cur_ver' => $wp_version,
352 254 'sw_new_ver' => $new_wp_version,
353 - ];
255 + );
354 256
355 257 // Fetch PHP version.
356 - $software_list[] = [
258 + $software_list[] = array(
357 259 'sw_type' => 'php',
358 260 'sw_name' => 'PHP',
359 - 'sw_cur_ver' => phpversion(),
261 + 'sw_cur_ver' => substr( phpversion(), 0, 5 ),
360 262 'sw_new_ver' => '',
361 - ];
263 + );
362 264
363 - // Fetch database server version.
364 - global $wpdb;
365 - if ( ! is_null( $wpdb ) ) {
366 - $software_list[] = [
367 - 'sw_type' => 'database',
368 - 'sw_name' => 'Database',
369 - 'sw_cur_ver' => $wpdb->get_var( 'SELECT VERSION()' ),
370 - 'sw_new_ver' => ''
371 - ];
372 - }
373 -
374 - $software_list = apply_filters( 'patchstack_get_software_data', $software_list );
375 265 return $software_list;
376 - }
377 -
378 - /**
379 - * Import the logs generated by the auto prepend firewall rules.
380 - *
381 - * @return void
382 - */
383 - public function import_ap_logs()
384 - {
385 - if ( ! get_option( 'patchstack_firewall_ap_enabled', false ) ) {
386 - return;
387 - }
388 -
389 - // Do not process if we are already processing a previous batch.
390 - if ( get_option( 'patchstack_firewall_log_ap_processing', false ) ) {
391 - return;
392 - }
393 -
394 - // Attempt to load config file.
395 - $logs = __DIR__ . '/../../../pslogs/logs.php';
396 - if ( ! file_exists( $logs ) ) {
397 - return;
398 - }
399 -
400 - // Load the extension.
401 - if ( ! file_exists( __DIR__ . '/../lib/patchstack/vendor/autoload.php' ) ) {
402 - return;
403 - }
404 -
405 - // Set the processing lock only once we know there is work to do, otherwise an
406 - // early return above would leave the lock stuck and block all future imports.
407 - update_option( 'patchstack_firewall_log_ap_processing', 1 );
408 -
409 - global $wpdb;
410 -
411 - require_once __DIR__ . '/../lib/patchstack/vendor/autoload.php';
412 - $extension = new Patchstack\Extensions\WordPress\Extension( [], $this );
413 -
414 - // Read the logs file.
415 - $file = new SplFileObject( $logs );
416 -
417 - // Iterate through each line.
418 - while ( ! $file->eof() ) {
419 - $line = $file->fgets();
420 -
421 - // Skip first line.
422 - if ( trim($line) == '' || strpos( $line, '<?php' ) !== false ) {
423 - continue;
424 - }
425 -
426 - // Decode the line to import.
427 - $data = json_decode( base64_decode( $line ), true );
428 - if ( ! $data || ! is_array( $data ) ) {
429 - continue;
430 - }
431 -
432 - // Skip malformed entries that are missing the fields we rely on below.
433 - if ( ! isset( $data['site_id'], $data['ip'], $data['request_uri'], $data['user_agent'], $data['method'], $data['fid'], $data['post_data'] ) ) {
434 - continue;
435 - }
436 -
437 - // Insert into the logs.
438 - $wpdb->insert(
439 - $wpdb->get_blog_prefix( $data['site_id'] ) . 'patchstack_firewall_log',
440 - [
441 - 'ip' => $data['ip'],
442 - 'request_uri' => $data['request_uri'],
443 - 'user_agent' => $data['user_agent'],
444 - 'method' => $data['method'],
445 - 'fid' => $data['fid'],
446 - 'flag' => '',
447 - 'post_data' => $data['post_data'],
448 - 'block_type' => 'BLOCK'
449 - ]
450 - );
451 -
452 - // Update counters.
453 - $hits = (int) $this->get_blog_option( $data['site_id'], 'patchstack_hits_all_time', 0 );
454 - $this->update_blog_option( $data['site_id'], 'patchstack_hits_all_time', $hits + 1 );
455 -
456 - $counters = $this->get_blog_option( $data['site_id'], 'patchstack_hits_last_30', [] );
457 - $counters = $extension->merge_counters( [ date('Y-m-d') => 1 ], $counters );
458 - $this->update_blog_option( $data['site_id'], 'patchstack_hits_last_30', $counters );
459 - }
460 -
461 - $file = null;
462 - file_put_contents( $logs, '<?php exit; ?>' . PHP_EOL );
463 -
464 - // Update processing state.
465 - update_option( 'patchstack_firewall_log_ap_processing', 0 );
466 266 }
467 267 }