PluginProbe
Patchstack – WordPress & Plugins Security / 2.2.7
Patchstack – WordPress & Plugins Security v2.2.7
2.3.7 trunk 2.1.0 2.1.1 2.1.10 2.1.11 2.1.12 2.1.13 2.1.14 2.1.15 2.1.16 2.1.17 2.1.18 2.1.19 2.1.2 2.1.20 2.1.21 2.1.22 2.1.23 2.1.24 2.1.25 2.1.3 2.1.4 2.1.5 2.1.6 All 49 releases
← All changes | includes/upload.php +56 -228 trunk2.2.7 View file →
@@ -20,9 +20,9 @@
20 20 public function __construct( $core ) {
21 21 parent::__construct( $core );
22 22
23 23 // In case the software has never been synchronized, force it.
24 - if ( ! get_option( 'patchstack_software_data_hash', false ) && ! get_option( 'patchstack_software_upload_attempted', false ) ) {
24 + if ( ! get_option( 'patchstack_software_data_hash', false ) ) {
25 25 $this->upload_software();
26 26 }
27 27
28 28 // Register the actions.
@@ -28,9 +28,8 @@
28 28 // Register the actions.
29 29 add_action( 'patchstack_send_software_data', [ $this, 'upload_software' ] );
30 30 add_action( 'patchstack_send_hacker_logs', [ $this, 'upload_firewall_logs' ] );
31 31 add_action( 'patchstack_send_event_logs', [ $this, 'upload_activity_logs' ] );
32 - add_action( 'patchstack_import_ap_logs', [ $this, 'import_ap_logs' ] );
33 32
34 33 // In case a plugin or upgrade has been performed, re-synchronize with the app.
35 34 add_action( 'activated_plugin', [ $this, 'upload_software' ] );
36 35 add_action( 'deactivated_plugin', [ $this, 'upload_software' ] );
@@ -50,15 +49,12 @@
50 49 $data = $this->get_software_data();
51 50 $hash = sha1( json_encode( $data ) );
52 51
53 52 // Do not sync for no reason.
54 - if ( ! defined( 'DOING_CRON' ) && ! isset( $_POST['patchstack_secret'] ) && get_option( 'patchstack_software_data_hash', false ) === $hash && ! is_admin() && ! defined( 'WP_CLI' ) ) {
53 + if ( ! defined( 'DOING_CRON' ) && ! isset( $_POST['webarx_secret'] ) && get_option( 'patchstack_software_data_hash', false ) === $hash && ! is_admin() ) {
55 54 return;
56 55 }
57 56
58 - // Make sure to not keep calling this function.
59 - update_option( 'patchstack_software_upload_attempted', 1 );
60 -
61 57 // Synchronize the software list with the API.
62 58 $results = $this->plugin->api->upload_software( [ 'software' => json_encode( $data ) ] );
63 59 if ( isset( $results['success'] ) ) {
64 60 update_option( 'patchstack_software_data_hash', $hash );
@@ -74,9 +70,9 @@
74 70 // If we have vulnerable plugins, determine if we had them before and if not, pull latest firewall rules.
75 71 if ( isset( $results['vulnerable'] ) && count( $results['vulnerable'] ) > 0 ) {
76 72 $prev = get_site_option( 'patchstack_latest_vulnerable', [] );
77 73 foreach ( $results['vulnerable'] as $vuln ) {
78 - if ( is_array( $prev ) && ! in_array ( $vuln, $prev ) ) {
74 + if ( ! in_array ( $vuln, $prev ) ) {
79 75 do_action( 'patchstack_post_dynamic_firewall_rules' );
80 76 break;
81 77 }
82 78 }
@@ -85,14 +81,8 @@
85 81 } else {
86 82 update_site_option( 'patchstack_latest_vulnerable', [] );
87 83 }
88 84
89 - // If we received the number of vulnerable count.
90 - if ( isset ( $results['vulnerability_count'], $results['vulnerability_fix_count'] ) ) {
91 - update_option( 'patchstack_vulns_present', $results['vulnerability_count'] );
92 - update_option( 'patchstack_fixes_present', $results['vulnerability_fix_count'] );
93 - }
94 -
95 85 return $results;
96 86 }
97 87
98 88 return;
@@ -104,90 +94,55 @@
104 94 * @return void
105 95 */
106 96 public function upload_firewall_logs() {
107 97 global $wpdb;
98 + $lastid = get_option( 'patchstack_firewall_log_lastid', 0 );
99 + $items = $wpdb->get_results( $wpdb->prepare( 'SELECT ip, log_date, request_uri, user_agent, fid, method, post_data FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE id > %d ORDER BY id', $lastid ) );
108 100
109 - // Do not execute upload action on free sites.
110 - if ( ! $this->license_is_active() || $this->get_option( 'patchstack_license_free', 0 ) == 1 ) {
101 + // No need to synchronize if there are no new logs present.
102 + if ( $wpdb->num_rows == 0 ) {
111 103 return;
112 104 }
113 105
114 - // Do not process if we are already processing a previous batch.
115 - if ( get_option( 'patchstack_firewall_log_processing', false ) ) {
116 - return;
117 - }
106 + // Construct the array to be uploaded to our API.
107 + $logs = [];
108 + foreach ( $items as $item ) {
118 109
119 - update_option( 'patchstack_firewall_log_processing', 1 );
120 -
121 - // Attempt to fetch data, if any.
122 - $lastId = get_option( 'patchstack_firewall_log_lastid', 0 );
123 - $successId = $lastId;
124 -
125 - // Do a maximum of 100 log entries per cronjob.
126 - for ($i = 0; $i <= 1; $i++) {
127 - // Pull the data from the database, in batches of 100.
128 - $items = $wpdb->get_results(
129 - $wpdb->prepare(
130 - 'SELECT id, ip, log_date, request_uri, user_agent, fid, method, post_data FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE id > %d ORDER BY id LIMIT 0,100',
131 - $lastId
132 - )
133 - );
134 -
135 - // No need to continue if we have no data.
136 - if ( $wpdb->num_rows == 0 ) {
137 - update_option( 'patchstack_firewall_log_lastid', 0 );
138 - break;
110 + // Entries that we don't want to store on the API side.
111 + if ( stripos( $item->request_uri, 'wp-comments-post' ) !== false ) {
112 + continue;
139 113 }
140 -
141 - // Construct the array to be uploaded to our API.
142 - $logs = [];
143 - foreach ( $items as $item ) {
144 114
145 - // Always advance the cursor so filtered rows don't stall the batch.
146 - $lastId = $item->id;
115 + // Push to entries to be uploaded.
116 + $logs[] = [
117 + 'ip' => $item->ip,
118 + 'fid' => $item->fid,
119 + 'request_uri' => $item->request_uri,
120 + 'user_agent' => $item->user_agent,
121 + 'method' => $item->method,
122 + 'log_date' => $item->log_date,
123 + 'post_data' => $item->post_data,
124 + ];
125 + }
147 126
148 - // Entries that we don't want to store on the API side.
149 - if ( stripos( $item->request_uri, 'wp-comments-post' ) !== false ) {
150 - continue;
151 - }
152 -
153 - // Push to entries to be uploaded.
154 - $logs[] = [
155 - 'ip' => $item->ip,
156 - 'fid' => $item->fid,
157 - 'request_uri' => $item->request_uri,
158 - 'user_agent' => $item->user_agent,
159 - 'method' => $item->method,
160 - 'log_date' => $item->log_date,
161 - 'post_data' => $item->post_data,
162 - ];
163 - }
164 -
165 - // JSON encode the logs and upload.
166 - $logs = json_encode( $logs );
167 - $results = $this->plugin->api->upload_firewall_logs(
168 - [
169 - 'logs' => $logs,
170 - 'type' => 'firewall',
171 - ]
172 - );
173 -
174 - // A failed upload returns a status code or null instead of an array;
175 - // bail without advancing so the logs are not deleted before they reach the API.
176 - if ( ! is_array( $results ) || isset( $results['errors'] ) ) {
177 - update_option( 'patchstack_firewall_log_lastid', $successId );
178 - break;
179 - }
180 -
181 - $successId = $lastId;
182 - update_option( 'patchstack_firewall_log_lastid', $successId );
127 + // JSON encode the logs and upload.
128 + $logs = json_encode( $logs );
129 + $results = $this->plugin->api->upload_firewall_logs(
130 + [
131 + 'logs' => $logs,
132 + 'type' => 'firewall',
133 + ]
134 + );
135 + if ( isset( $results['errors'] ) ) {
136 + return;
183 137 }
184 138
185 - // Delete the logs.
186 - $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE id <= ' . (int) $successId );
139 + // Get the most recent id of the logs.
140 + $lastid = $wpdb->get_var( 'SELECT id FROM ' . $wpdb->prefix . 'patchstack_firewall_log ORDER BY id DESC LIMIT 0, 1' );
141 + update_option( 'patchstack_firewall_log_lastid', $lastid );
187 142
188 - // No longer processing.
189 - update_option( 'patchstack_firewall_log_processing', 0 );
143 + // Delete logs that are older than 2 weeks.
144 + $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_firewall_log WHERE log_date < DATE_SUB(NOW(), INTERVAL 14 DAY)' );
190 145 }
191 146
192 147 /**
193 148 * Synchronize the activity logs with our API.
@@ -196,20 +151,8 @@
196 151 */
197 152 public function upload_activity_logs() {
198 153 global $wpdb;
199 154
200 - // Do not execute upload action on free sites.
201 - if ( ! $this->license_is_active() || $this->get_option( 'patchstack_license_free', 0 ) == 1 ) {
202 - return;
203 - }
204 -
205 - // Do not process if we are already processing a previous batch.
206 - if ( get_option( 'patchstack_eventlog_processing', false ) ) {
207 - return;
208 - }
209 -
210 - update_option( 'patchstack_eventlog_processing', 1 );
211 -
212 155 // Determine if we should upload failed logins to the app.
213 156 $where = " AND action != 'failed login' ";
214 157 if ( $this->get_option( 'patchstack_activity_log_failed_logins_db', 0 ) == 1 ) {
215 158 $where = ' ';
@@ -214,52 +157,28 @@
214 157 if ( $this->get_option( 'patchstack_activity_log_failed_logins_db', 0 ) == 1 ) {
215 158 $where = ' ';
216 159 }
217 160
218 - // Attempt to fetch data, if any.
219 - $lastId = get_option( 'patchstack_eventlog_lastid', 0 );
220 - $successId = $lastId;
161 + // Do we have data to upload?
162 + $lastid = get_option( 'patchstack_eventlog_lastid', 0 );
163 + $items = $wpdb->get_results( $wpdb->prepare( 'SELECT author, ip, object, object_id, object_name, action, date FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE id > %d' . $where . 'ORDER BY id', [ $lastid ] ) );
164 + if ( $wpdb->num_rows == 0 ) {
165 + return;
166 + }
221 167
222 - // Do a maximum of several hundred log entries per cronjob.
223 - for ($i = 0; $i <= 1; $i++) {
224 - // Pull the data from the database, in batches of 100.
225 - $items = $wpdb->get_results(
226 - $wpdb->prepare(
227 - 'SELECT id, author, ip, object, object_id, object_name, action, date FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE id > %d' . $where . 'ORDER BY id LIMIT 0,100',
228 - $lastId
229 - ),
230 - ARRAY_A
231 - );
232 -
233 - // No need to continue if we have no data.
234 - if ( $wpdb->num_rows == 0 ) {
235 - update_option( 'patchstack_eventlog_lastid', 0 );
236 - break;
237 - }
238 -
239 - // Get the last ID in the result set.
240 - $lastId = $items[count($items) - 1]['id'];
241 -
242 - // Send to the API.
243 - $logs = json_encode( $items );
244 - $results = $this->plugin->api->upload_activity_logs( [ 'logs' => $logs ] );
245 -
246 - // A failed upload returns a status code or null instead of an array;
247 - // bail without advancing so the logs are not deleted before they reach the API.
248 - if ( ! is_array( $results ) || isset( $results['errors'] ) ) {
249 - update_option( 'patchstack_eventlog_lastid', $successId );
250 - break;
251 - }
252 -
253 - $successId = $lastId;
254 - update_option( 'patchstack_eventlog_lastid', $successId );
168 + // Send to the API.
169 + $logs = json_encode( $items );
170 + $results = $this->plugin->api->upload_activity_logs( [ 'logs' => $logs ] );
171 + if ( isset( $results['errors'] ) ) {
172 + return;
255 173 }
256 174
257 - // Delete the logs.
258 - $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE id <= ' . (int) $successId );
175 + // Get the most recent id of the logs.
176 + $lastid = $wpdb->get_var( 'SELECT id FROM ' . $wpdb->prefix . 'patchstack_event_log ORDER BY id DESC LIMIT 0, 1' );
177 + update_option( 'patchstack_eventlog_lastid', $lastid );
259 178
260 - // No longer processing.
261 - update_option( 'patchstack_eventlog_processing', 0 );
179 + // Delete logs that are older than 2 weeks.
180 + $wpdb->query( 'DELETE FROM ' . $wpdb->prefix . 'patchstack_event_log WHERE date < DATE_SUB(NOW(), INTERVAL 14 DAY)' );
262 181 }
263 182
264 183 /**
265 184 * Obtain information about the software that the user has installed.
@@ -275,9 +194,9 @@
275 194 require_once ABSPATH . 'wp-admin/includes/update.php';
276 195 }
277 196
278 197 // Refetch updates data if we are performing a plugin listener related action.
279 - if ( isset( $_POST['patchstack_secret'] ) ) {
198 + if ( isset( $_POST['webarx_secret'] ) ) {
280 199 @require_once ABSPATH . 'wp-includes/update.php';
281 200 @wp_update_themes();
282 201 @wp_update_plugins();
283 202 }
@@ -370,98 +289,7 @@
370 289 'sw_new_ver' => ''
371 290 ];
372 291 }
373 292
374 - $software_list = apply_filters( 'patchstack_get_software_data', $software_list );
375 293 return $software_list;
376 - }
377 -
378 - /**
379 - * Import the logs generated by the auto prepend firewall rules.
380 - *
381 - * @return void
382 - */
383 - public function import_ap_logs()
384 - {
385 - if ( ! get_option( 'patchstack_firewall_ap_enabled', false ) ) {
386 - return;
387 - }
388 -
389 - // Do not process if we are already processing a previous batch.
390 - if ( get_option( 'patchstack_firewall_log_ap_processing', false ) ) {
391 - return;
392 - }
393 -
394 - // Attempt to load config file.
395 - $logs = __DIR__ . '/../../../pslogs/logs.php';
396 - if ( ! file_exists( $logs ) ) {
397 - return;
398 - }
399 -
400 - // Load the extension.
401 - if ( ! file_exists( __DIR__ . '/../lib/patchstack/vendor/autoload.php' ) ) {
402 - return;
403 - }
404 -
405 - // Set the processing lock only once we know there is work to do, otherwise an
406 - // early return above would leave the lock stuck and block all future imports.
407 - update_option( 'patchstack_firewall_log_ap_processing', 1 );
408 -
409 - global $wpdb;
410 -
411 - require_once __DIR__ . '/../lib/patchstack/vendor/autoload.php';
412 - $extension = new Patchstack\Extensions\WordPress\Extension( [], $this );
413 -
414 - // Read the logs file.
415 - $file = new SplFileObject( $logs );
416 -
417 - // Iterate through each line.
418 - while ( ! $file->eof() ) {
419 - $line = $file->fgets();
420 -
421 - // Skip first line.
422 - if ( trim($line) == '' || strpos( $line, '<?php' ) !== false ) {
423 - continue;
424 - }
425 -
426 - // Decode the line to import.
427 - $data = json_decode( base64_decode( $line ), true );
428 - if ( ! $data || ! is_array( $data ) ) {
429 - continue;
430 - }
431 -
432 - // Skip malformed entries that are missing the fields we rely on below.
433 - if ( ! isset( $data['site_id'], $data['ip'], $data['request_uri'], $data['user_agent'], $data['method'], $data['fid'], $data['post_data'] ) ) {
434 - continue;
435 - }
436 -
437 - // Insert into the logs.
438 - $wpdb->insert(
439 - $wpdb->get_blog_prefix( $data['site_id'] ) . 'patchstack_firewall_log',
440 - [
441 - 'ip' => $data['ip'],
442 - 'request_uri' => $data['request_uri'],
443 - 'user_agent' => $data['user_agent'],
444 - 'method' => $data['method'],
445 - 'fid' => $data['fid'],
446 - 'flag' => '',
447 - 'post_data' => $data['post_data'],
448 - 'block_type' => 'BLOCK'
449 - ]
450 - );
451 -
452 - // Update counters.
453 - $hits = (int) $this->get_blog_option( $data['site_id'], 'patchstack_hits_all_time', 0 );
454 - $this->update_blog_option( $data['site_id'], 'patchstack_hits_all_time', $hits + 1 );
455 -
456 - $counters = $this->get_blog_option( $data['site_id'], 'patchstack_hits_last_30', [] );
457 - $counters = $extension->merge_counters( [ date('Y-m-d') => 1 ], $counters );
458 - $this->update_blog_option( $data['site_id'], 'patchstack_hits_last_30', $counters );
459 - }
460 -
461 - $file = null;
462 - file_put_contents( $logs, '<?php exit; ?>' . PHP_EOL );
463 -
464 - // Update processing state.
465 - update_option( 'patchstack_firewall_log_ap_processing', 0 );
466 294 }
467 295 }