| @@ -1,83 +1,73 @@ | ||
| 1 | 1 | <?php |
| 2 | -/** | |
| 3 | - * @package Polylang | |
| 4 | - */ | |
| 5 | 2 | |
| 6 | -/** | |
| 7 | - * Manages strings translations storage | |
| 3 | +/* | |
| 4 | + * manages strings translations storage | |
| 8 | 5 | * |
| 9 | 6 | * @since 1.2 |
| 10 | - * @since 2.1 Stores the strings in a post meta instead of post content to avoid unserialize issues (See #63) | |
| 11 | 7 | */ |
| 12 | 8 | class PLL_MO extends MO { |
| 13 | 9 | |
| 14 | - /** | |
| 15 | - * Registers the polylang_mo custom post type, only at first object creation | |
| 10 | + /* | |
| 11 | + * registers the polylang_mo custom post type, only at first object creation | |
| 16 | 12 | * |
| 17 | 13 | * @since 1.2 |
| 18 | 14 | */ |
| 19 | 15 | public function __construct() { |
| 20 | - if ( ! post_type_exists( 'polylang_mo' ) ) { | |
| 21 | - $labels = array( 'name' => __( 'Strings translations', 'polylang' ) ); | |
| 22 | - register_post_type( 'polylang_mo', array( 'labels' => $labels, 'rewrite' => false, 'query_var' => false, '_pll' => true ) ); | |
| 23 | - | |
| 24 | - add_action( 'pll_add_language', array( $this, 'clean_cache' ) ); | |
| 25 | - } | |
| 16 | + if (!post_type_exists('polylang_mo')) | |
| 17 | + register_post_type('polylang_mo', array('rewrite' => false, 'query_var' => false, '_pll' => true)); | |
| 26 | 18 | } |
| 27 | 19 | |
| 28 | - /** | |
| 29 | - * Writes a PLL_MO object into a custom post meta | |
| 20 | + /* | |
| 21 | + * writes a PLL_MO object into a custom post | |
| 30 | 22 | * |
| 31 | 23 | * @since 1.2 |
| 32 | 24 | * |
| 33 | - * @param object $lang The language in which we want to export strings | |
| 25 | + * @param object $lang the language in which we want to export strings | |
| 34 | 26 | */ |
| 35 | - public function export_to_db( $lang ) { | |
| 36 | - $this->add_entry( $this->make_entry( '', '' ) ); // Empty string translation, just in case | |
| 27 | + public function export_to_db($lang) { | |
| 28 | + $this->add_entry($this->make_entry('', '')); // empty string translation, just in case | |
| 37 | 29 | |
| 38 | - // Would be convenient to store the whole object but it would take a huge space in DB | |
| 39 | - // So let's keep only the strings in an array | |
| 30 | + // would be convenient to store the whole object but it would take a huge space in DB | |
| 31 | + // so let's keep only the strings in an array | |
| 40 | 32 | $strings = array(); |
| 41 | - foreach ( $this->entries as $entry ) { | |
| 42 | - $strings[] = array( $entry->singular, $this->translate( $entry->singular ) ); | |
| 43 | - } | |
| 33 | + foreach ($this->entries as $entry) | |
| 34 | + $strings[] = array($entry->singular, $this->translate($entry->singular)); | |
| 44 | 35 | |
| 45 | - $strings = wp_slash( $strings ); // Avoid breaking slashed strings in update_post_meta. See https://codex.wordpress.org/Function_Reference/update_post_meta#Character_Escaping | |
| 36 | + $post = get_post($lang->mo_id, ARRAY_A); // wp_insert_post wants an array | |
| 46 | 37 | |
| 47 | - if ( empty( $lang->mo_id ) ) { | |
| 48 | - $post = array( | |
| 49 | - 'post_title' => 'polylang_mo_' . $lang->term_id, | |
| 50 | - 'post_status' => 'private', // To avoid a conflict with WP Super Cache. See https://wordpress.org/support/topic/polylang_mo-and-404s-take-2 | |
| 51 | - 'post_type' => 'polylang_mo', | |
| 52 | - ); | |
| 53 | - $mo_id = wp_insert_post( $post ); | |
| 54 | - update_post_meta( $mo_id, '_pll_strings_translations', $strings ); | |
| 55 | - } else { | |
| 56 | - update_post_meta( $lang->mo_id, '_pll_strings_translations', $strings ); | |
| 57 | - } | |
| 38 | + if (empty($post)) | |
| 39 | + $GLOBALS['polylang']->model->clean_languages_cache(); // to set mo_id | |
| 40 | + | |
| 41 | + $post['post_title'] = 'polylang_mo_' . $lang->term_id; | |
| 42 | + // json_encode would take less space but is slower to decode | |
| 43 | + // wp_insert_post expects slashed data | |
| 44 | + $post['post_content'] = addslashes(serialize($strings)); | |
| 45 | + $post['post_status'] = 'publish'; | |
| 46 | + $post['post_type'] = 'polylang_mo'; | |
| 47 | + wp_insert_post($post); | |
| 58 | 48 | } |
| 59 | 49 | |
| 60 | - /** | |
| 61 | - * Reads a PLL_MO object from a custom post meta | |
| 50 | + /* | |
| 51 | + * reads a PLL_MO object from a custom post | |
| 62 | 52 | * |
| 63 | 53 | * @since 1.2 |
| 64 | 54 | * |
| 65 | - * @param object $lang The language in which we want to get strings | |
| 55 | + * @param object $lang the language in which we want to get strings | |
| 66 | 56 | */ |
| 67 | - public function import_from_db( $lang ) { | |
| 68 | - if ( ! empty( $lang->mo_id ) ) { | |
| 69 | - $strings = get_post_meta( $lang->mo_id, '_pll_strings_translations', true ); | |
| 70 | - if ( is_array( $strings ) ) { | |
| 71 | - foreach ( $strings as $msg ) { | |
| 72 | - $this->add_entry( $this->make_entry( $msg[0], $msg[1] ) ); | |
| 73 | - } | |
| 57 | + public function import_from_db($lang) { | |
| 58 | + if (!empty($lang->mo_id)) { | |
| 59 | + $post = get_post($lang->mo_id, OBJECT); | |
| 60 | + $strings = unserialize($post->post_content); | |
| 61 | + if (is_array($strings)) { | |
| 62 | + foreach ($strings as $msg) | |
| 63 | + $this->add_entry($this->make_entry($msg[0], $msg[1])); | |
| 74 | 64 | } |
| 75 | 65 | } |
| 76 | 66 | } |
| 77 | 67 | |
| 78 | - /** | |
| 79 | - * Returns the post id of the post storing the strings translations | |
| 68 | + /* | |
| 69 | + * returns the post id of the post storing the strings translations | |
| 80 | 70 | * |
| 81 | 71 | * @since 1.4 |
| 82 | 72 | * |
| 83 | 73 | * @param object $lang |
| @@ -82,38 +72,9 @@ | ||
| 82 | 72 | * |
| 83 | 73 | * @param object $lang |
| 84 | 74 | * @return int |
| 85 | 75 | */ |
| 86 | - public static function get_id( $lang ) { | |
| 76 | + public static function get_id($lang) { | |
| 87 | 77 | global $wpdb; |
| 88 | - | |
| 89 | - $ids = wp_cache_get( 'polylang_mo_ids' ); | |
| 90 | - | |
| 91 | - if ( empty( $ids ) ) { | |
| 92 | - $ids = $wpdb->get_results( "SELECT post_title, ID FROM $wpdb->posts WHERE post_type='polylang_mo'", OBJECT_K ); | |
| 93 | - wp_cache_add( 'polylang_mo_ids', $ids ); | |
| 94 | - } | |
| 95 | - | |
| 96 | - // The mo id for a language can be transiently empty | |
| 97 | - return isset( $ids[ 'polylang_mo_' . $lang->term_id ] ) ? $ids[ 'polylang_mo_' . $lang->term_id ]->ID : null; | |
| 98 | - } | |
| 99 | - | |
| 100 | - /** | |
| 101 | - * Invalidate the cache when adding a new language | |
| 102 | - * | |
| 103 | - * @since 2.0.5 | |
| 104 | - */ | |
| 105 | - public function clean_cache() { | |
| 106 | - wp_cache_delete( 'polylang_mo_ids' ); | |
| 107 | - } | |
| 108 | - | |
| 109 | - /** | |
| 110 | - * Deletes a string | |
| 111 | - * | |
| 112 | - * @since 2.9 | |
| 113 | - * | |
| 114 | - * @param string $string The source string to remove from the translations. | |
| 115 | - */ | |
| 116 | - public function delete_entry( $string ) { | |
| 117 | - unset( $this->entries[ $string ] ); | |
| 78 | + return $wpdb->get_var($wpdb->prepare("SELECT ID FROM $wpdb->posts WHERE post_title = %s AND post_type= %s", 'polylang_mo_' . $lang->term_id, 'polylang_mo')); | |
| 118 | 79 | } |
| 119 | 80 | } |