| @@ -1,61 +1,62 @@ | ||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | /** |
| 4 | - * A fully static class to manage strings translations on admin side | |
| 4 | + * a fully static class to manage strings translations on admin side | |
| 5 | 5 | * |
| 6 | 6 | * @since 1.6 |
| 7 | 7 | */ |
| 8 | 8 | class PLL_Admin_Strings { |
| 9 | - protected static $strings = array(); // strings to translate | |
| 10 | - protected static $default_strings; // default strings to register | |
| 9 | + static protected $strings = array(); // strings to translate | |
| 10 | + static protected $default_strings; // default strings to register | |
| 11 | 11 | |
| 12 | 12 | /** |
| 13 | - * Add filters | |
| 13 | + * init: add filters | |
| 14 | 14 | * |
| 15 | 15 | * @since 1.6 |
| 16 | 16 | */ |
| 17 | - public static function init() { | |
| 17 | + static public function init() { | |
| 18 | 18 | // default strings translations sanitization |
| 19 | 19 | add_filter( 'pll_sanitize_string_translation', array( __CLASS__, 'sanitize_string_translation' ), 10, 2 ); |
| 20 | 20 | } |
| 21 | 21 | |
| 22 | 22 | /** |
| 23 | - * Register strings for translation making sure it is not duplicate or empty | |
| 23 | + * register strings for translation making sure it is not duplicate or empty | |
| 24 | 24 | * |
| 25 | 25 | * @since 0.6 |
| 26 | 26 | * |
| 27 | - * @param string $name A unique name for the string | |
| 28 | - * @param string $string The string to register | |
| 29 | - * @param string $context Optional, the group in which the string is registered, defaults to 'polylang' | |
| 30 | - * @param bool $multiline Optional, whether the string table should display a multiline textarea or a single line input, defaults to single line | |
| 27 | + * @param string $name a unique name for the string | |
| 28 | + * @param string $string the string to register | |
| 29 | + * @param string $context optional the group in which the string is registered, defaults to 'polylang' | |
| 30 | + * @param bool $multiline optional wether the string table should display a multiline textarea or a single line input, defaults to single line | |
| 31 | 31 | */ |
| 32 | - public static function register_string( $name, $string, $context = 'Polylang', $multiline = false ) { | |
| 33 | - // Backward compatibility with Polylang older than 1.1 | |
| 32 | + static public function register_string( $name, $string, $context = 'Polylang', $multiline = false ) { | |
| 33 | + // backward compatibility with Polylang older than 1.1 | |
| 34 | 34 | if ( is_bool( $context ) ) { |
| 35 | 35 | $multiline = $context; |
| 36 | 36 | $context = 'Polylang'; |
| 37 | 37 | } |
| 38 | 38 | |
| 39 | - if ( $string && is_scalar( $string ) ) { | |
| 40 | - self::$strings[ md5( $string ) ] = compact( 'name', 'string', 'context', 'multiline' ); | |
| 39 | + $to_register = compact( 'name', 'string', 'context', 'multiline' ); | |
| 40 | + if ( ! in_array( $to_register, self::$strings ) && $to_register['string'] ) { | |
| 41 | + self::$strings[] = $to_register; | |
| 41 | 42 | } |
| 42 | 43 | } |
| 43 | 44 | |
| 44 | 45 | /** |
| 45 | - * Get registered strings | |
| 46 | + * get registered strings | |
| 46 | 47 | * |
| 47 | 48 | * @since 0.6.1 |
| 48 | 49 | * |
| 49 | 50 | * @return array list of all registered strings |
| 50 | 51 | */ |
| 51 | - public static function &get_strings() { | |
| 52 | + static public function &get_strings() { | |
| 52 | 53 | self::$default_strings = array( |
| 53 | 54 | 'options' => array( |
| 54 | - 'blogname' => __( 'Site Title', 'polylang' ), | |
| 55 | - 'blogdescription' => __( 'Tagline', 'polylang' ), | |
| 56 | - 'date_format' => __( 'Date Format', 'polylang' ), | |
| 57 | - 'time_format' => __( 'Time Format', 'polylang' ), | |
| 55 | + 'blogname' => __( 'Site Title' ), | |
| 56 | + 'blogdescription' => __( 'Tagline' ), | |
| 57 | + 'date_format' => __( 'Date Format' ), | |
| 58 | + 'time_format' => __( 'Time Format' ), | |
| 58 | 59 | ), |
| 59 | 60 | 'widget_title' => __( 'Widget title', 'polylang' ), |
| 60 | 61 | 'widget_text' => __( 'Widget text', 'polylang' ), |
| 61 | 62 | ); |
| @@ -64,9 +65,9 @@ | ||
| 64 | 65 | foreach ( self::$default_strings['options'] as $option => $string ) { |
| 65 | 66 | self::register_string( $string, get_option( $option ), 'WordPress' ); |
| 66 | 67 | } |
| 67 | 68 | |
| 68 | - // Widgets titles | |
| 69 | + // widgets titles | |
| 69 | 70 | global $wp_registered_widgets; |
| 70 | 71 | $sidebars = wp_get_sidebars_widgets(); |
| 71 | 72 | foreach ( $sidebars as $sidebar => $widgets ) { |
| 72 | 73 | if ( 'wp_inactive_widgets' == $sidebar || empty( $widgets ) ) { |
| @@ -73,10 +74,10 @@ | ||
| 73 | 74 | continue; |
| 74 | 75 | } |
| 75 | 76 | |
| 76 | 77 | foreach ( $widgets as $widget ) { |
| 77 | - // Nothing can be done if the widget is created using pre WP2.8 API :( | |
| 78 | - // There is no object, so we can't access it to get the widget options | |
| 78 | + // nothing can be done if the widget is created using pre WP2.8 API :( | |
| 79 | + // there is no object, so we can't access it to get the widget options | |
| 79 | 80 | if ( ! isset( $wp_registered_widgets[ $widget ]['callback'][0] ) || ! is_object( $wp_registered_widgets[ $widget ]['callback'][0] ) || ! method_exists( $wp_registered_widgets[ $widget ]['callback'][0], 'get_settings' ) ) { |
| 80 | 81 | continue; |
| 81 | 82 | } |
| 82 | 83 | |
| @@ -82,9 +83,9 @@ | ||
| 82 | 83 | |
| 83 | 84 | $widget_settings = $wp_registered_widgets[ $widget ]['callback'][0]->get_settings(); |
| 84 | 85 | $number = $wp_registered_widgets[ $widget ]['params'][0]['number']; |
| 85 | 86 | |
| 86 | - // Don't enable widget translation if the widget is visible in only one language or if there is no title | |
| 87 | + // don't enable widget translation if the widget is visible in only one language or if there is no title | |
| 87 | 88 | if ( empty( $widget_settings[ $number ]['pll_lang'] ) ) { |
| 88 | 89 | if ( isset( $widget_settings[ $number ]['title'] ) && $title = $widget_settings[ $number ]['title'] ) { |
| 89 | 90 | self::register_string( self::$default_strings['widget_title'], $title, 'Widget' ); |
| 90 | 91 | } |
| @@ -108,9 +109,9 @@ | ||
| 108 | 109 | return self::$strings; |
| 109 | 110 | } |
| 110 | 111 | |
| 111 | 112 | /** |
| 112 | - * Performs the sanitization ( before saving in DB ) of default strings translations | |
| 113 | + * performs the sanitization ( before saving in DB ) of default strings translations | |
| 113 | 114 | * |
| 114 | 115 | * @since 1.6 |
| 115 | 116 | * |
| 116 | 117 | * @param string $translation translation to sanitize |
| @@ -116,9 +117,10 @@ | ||
| 116 | 117 | * @param string $translation translation to sanitize |
| 117 | 118 | * @param string $name unique name for the string |
| 118 | 119 | * @return string |
| 119 | 120 | */ |
| 120 | - public static function sanitize_string_translation( $translation, $name ) { | |
| 121 | + static public function sanitize_string_translation( $translation, $name ) { | |
| 122 | + $translation = wp_unslash( trim( $translation ) ); | |
| 121 | 123 | |
| 122 | 124 | if ( false !== ( $option = array_search( $name, self::$default_strings['options'], true ) ) ) { |
| 123 | 125 | $translation = sanitize_option( $option, $translation ); |
| 124 | 126 | } |
| @@ -123,13 +125,13 @@ | ||
| 123 | 125 | $translation = sanitize_option( $option, $translation ); |
| 124 | 126 | } |
| 125 | 127 | |
| 126 | 128 | if ( $name == self::$default_strings['widget_title'] ) { |
| 127 | - $translation = sanitize_text_field( $translation ); | |
| 129 | + $translation = strip_tags( $translation ); | |
| 128 | 130 | } |
| 129 | 131 | |
| 130 | 132 | if ( $name == self::$default_strings['widget_text'] && ! current_user_can( 'unfiltered_html' ) ) { |
| 131 | - $translation = wp_kses_post( $translation ); | |
| 133 | + $translation = wp_unslash( wp_filter_post_kses( addslashes( $translation ) ) ); // wp_filter_post_kses() expects slashed | |
| 132 | 134 | } |
| 133 | 135 | |
| 134 | 136 | return $translation; |
| 135 | 137 | } |
