| @@ -4,9 +4,10 @@ | ||
| 4 | 4 | * Manages copy and synchronization of terms and post metas |
| 5 | 5 | * |
| 6 | 6 | * @since 1.2 |
| 7 | 7 | */ |
| 8 | -class PLL_Admin_Sync extends PLL_Sync { | |
| 8 | +class PLL_Admin_Sync { | |
| 9 | + public $taxonomies, $post_metas, $term_meta; | |
| 9 | 10 | |
| 10 | 11 | /** |
| 11 | 12 | * Constructor |
| 12 | 13 | * |
| @@ -14,14 +15,28 @@ | ||
| 14 | 15 | * |
| 15 | 16 | * @param object $polylang |
| 16 | 17 | */ |
| 17 | 18 | public function __construct( &$polylang ) { |
| 18 | - parent::__construct( $polylang ); | |
| 19 | + $this->model = &$polylang->model; | |
| 20 | + $this->options = &$polylang->options; | |
| 19 | 21 | |
| 22 | + $this->taxonomies = new PLL_Sync_Tax( $polylang ); | |
| 23 | + $this->post_metas = new PLL_Sync_Post_Metas( $polylang ); | |
| 24 | + $this->term_metas = new PLL_Sync_Term_Metas( $polylang ); | |
| 25 | + | |
| 20 | 26 | add_filter( 'wp_insert_post_parent', array( $this, 'wp_insert_post_parent' ), 10, 3 ); |
| 21 | - add_filter( 'wp_insert_post_data', array( $this, 'wp_insert_post_data' ) ); | |
| 22 | - add_action( 'rest_api_init', array( $this, 'new_post_translation' ) ); // Block editor | |
| 23 | - add_action( 'add_meta_boxes', array( $this, 'new_post_translation' ), 5 ); // Classic editor, before Types which populates custom fields in same hook with priority 10 | |
| 27 | + add_action( 'add_meta_boxes', array( $this, 'add_meta_boxes' ), 5, 2 ); // Before Types which populates custom fields in same hook with priority 10 | |
| 28 | + | |
| 29 | + add_action( 'pll_save_post', array( $this, 'pll_save_post' ), 10, 3 ); | |
| 30 | + add_action( 'pll_save_term', array( $this, 'sync_term_parent' ), 10, 3 ); | |
| 31 | + | |
| 32 | + if ( $this->options['media_support'] ) { | |
| 33 | + add_action( 'pll_translate_media', array( $this->taxonomies, 'copy' ), 10, 3 ); | |
| 34 | + add_action( 'pll_translate_media', array( $this->post_metas, 'copy' ), 10, 3 ); | |
| 35 | + add_action( 'edit_attachment', array( $this, 'edit_attachment' ) ); | |
| 36 | + } | |
| 37 | + | |
| 38 | + add_filter( 'pre_update_option_sticky_posts', array( $this, 'sync_sticky_posts' ), 10, 2 ); | |
| 24 | 39 | } |
| 25 | 40 | |
| 26 | 41 | /** |
| 27 | 42 | * Translate post parent if exists when using "Add new" ( translation ) |
| @@ -33,145 +48,201 @@ | ||
| 33 | 48 | * @param array $postarr Array of parsed post data |
| 34 | 49 | * @return int |
| 35 | 50 | */ |
| 36 | 51 | public function wp_insert_post_parent( $post_parent, $post_id, $postarr ) { |
| 37 | - if ( isset( $_GET['from_post'], $_GET['new_lang'], $_GET['post_type'] ) ) { | |
| 38 | - check_admin_referer( 'new-post-translation' ); | |
| 39 | - // Make sure not to impact media translations created at the same time | |
| 40 | - if ( $_GET['post_type'] === $postarr['post_type'] && ( $id = wp_get_post_parent_id( (int) $_GET['from_post'] ) ) && $parent = $this->model->post->get_translation( $id, sanitize_key( $_GET['new_lang'] ) ) ) { | |
| 41 | - $post_parent = $parent; | |
| 42 | - } | |
| 43 | - } | |
| 44 | - return $post_parent; | |
| 52 | + // Make sure not to impact media translations created at the same time | |
| 53 | + return isset( $_GET['from_post'], $_GET['new_lang'], $_GET['post_type'] ) && $_GET['post_type'] === $postarr['post_type'] && ( $id = wp_get_post_parent_id( (int) $_GET['from_post'] ) ) && ( $parent = $this->model->post->get_translation( $id, $_GET['new_lang'] ) ) ? $parent : $post_parent; | |
| 45 | 54 | } |
| 46 | 55 | |
| 47 | 56 | /** |
| 48 | - * Copy menu order, comment, ping status and optionally the date when creating a new tanslation | |
| 57 | + * Copy post metas, menu order, comment and ping status when using "Add new" ( translation ) | |
| 58 | + * formerly used dbx_post_advanced deprecated in WP 3.7 | |
| 49 | 59 | * |
| 50 | - * @since 2.5 | |
| 60 | + * @since 1.2 | |
| 51 | 61 | * |
| 52 | - * @param array $data An array of slashed post data. | |
| 53 | - * @return array | |
| 62 | + * @param string $post_type unused | |
| 63 | + * @param object $post current post object | |
| 54 | 64 | */ |
| 55 | - public function wp_insert_post_data( $data ) { | |
| 56 | - if ( isset( $GLOBALS['pagenow'], $_GET['from_post'], $_GET['new_lang'] ) && 'post-new.php' === $GLOBALS['pagenow'] && $this->model->is_translated_post_type( $data['post_type'] ) ) { | |
| 57 | - check_admin_referer( 'new-post-translation' ); | |
| 65 | + public function add_meta_boxes( $post_type, $post ) { | |
| 66 | + if ( 'post-new.php' == $GLOBALS['pagenow'] && isset( $_GET['from_post'], $_GET['new_lang'] ) && $this->model->is_translated_post_type( $post->post_type ) ) { | |
| 67 | + // Capability check already done in post-new.php | |
| 68 | + $from_post_id = (int) $_GET['from_post']; | |
| 69 | + $from_post = get_post( $from_post_id ); | |
| 70 | + $lang = $this->model->get_language( $_GET['new_lang'] ); | |
| 58 | 71 | |
| 59 | - $from_post_id = (int) $_GET['from_post']; | |
| 60 | - $from_post = get_post( $from_post_id ); | |
| 72 | + if ( ! $from_post || ! $lang ) { | |
| 73 | + return; | |
| 74 | + } | |
| 61 | 75 | |
| 76 | + $this->taxonomies->copy( $from_post_id, $post->ID, $lang->slug ); | |
| 77 | + $this->post_metas->copy( $from_post_id, $post->ID, $lang->slug ); | |
| 78 | + | |
| 62 | 79 | foreach ( array( 'menu_order', 'comment_status', 'ping_status' ) as $property ) { |
| 63 | - $data[ $property ] = $from_post->$property; | |
| 80 | + $post->$property = $from_post->$property; | |
| 64 | 81 | } |
| 65 | 82 | |
| 66 | 83 | // Copy the date only if the synchronization is activated |
| 67 | 84 | if ( in_array( 'post_date', $this->options['sync'] ) ) { |
| 68 | - $data['post_date'] = $from_post->post_date; | |
| 69 | - $data['post_date_gmt'] = $from_post->post_date_gmt; | |
| 85 | + $post->post_date = $from_post->post_date; | |
| 86 | + $post->post_date_gmt = $from_post->post_date_gmt; | |
| 70 | 87 | } |
| 88 | + | |
| 89 | + if ( is_sticky( $from_post_id ) ) { | |
| 90 | + stick_post( $post->ID ); | |
| 91 | + } | |
| 71 | 92 | } |
| 72 | - | |
| 73 | - return $data; | |
| 74 | 93 | } |
| 75 | 94 | |
| 76 | 95 | /** |
| 77 | - * Copy post metas, and taxonomies when using "Add new" ( translation ) | |
| 96 | + * Synchronizes post fields in translations | |
| 78 | 97 | * |
| 79 | - * @since 2.5 | |
| 98 | + * @since 1.2 | |
| 99 | + * | |
| 100 | + * @param int $post_id post id | |
| 101 | + * @param object $post post object | |
| 102 | + * @param array $translations post translations | |
| 80 | 103 | */ |
| 81 | - public function new_post_translation() { | |
| 82 | - global $post; | |
| 83 | - static $done = array(); | |
| 104 | + public function pll_save_post( $post_id, $post, $translations ) { | |
| 105 | + global $wpdb; | |
| 84 | 106 | |
| 85 | - if ( isset( $GLOBALS['pagenow'], $_GET['from_post'], $_GET['new_lang'] ) && 'post-new.php' === $GLOBALS['pagenow'] && $this->model->is_translated_post_type( $post->post_type ) ) { | |
| 86 | - check_admin_referer( 'new-post-translation' ); | |
| 107 | + // Prepare properties to synchronize | |
| 108 | + foreach ( array( 'comment_status', 'ping_status', 'menu_order' ) as $property ) { | |
| 109 | + if ( in_array( $property, $this->options['sync'] ) ) { | |
| 110 | + $postarr[ $property ] = $post->$property; | |
| 111 | + } | |
| 112 | + } | |
| 87 | 113 | |
| 88 | - // Capability check already done in post-new.php | |
| 89 | - $from_post_id = (int) $_GET['from_post']; | |
| 90 | - $lang = $this->model->get_language( sanitize_key( $_GET['new_lang'] ) ); | |
| 114 | + if ( in_array( 'post_date', $this->options['sync'] ) ) { | |
| 115 | + // For new drafts, save the date now otherwise it is overriden by WP. Thanks to JoryHogeveen. See #32. | |
| 116 | + if ( 'post-new.php' === $GLOBALS['pagenow'] && isset( $_GET['from_post'], $_GET['new_lang'] ) ) { | |
| 117 | + $original = get_post( (int) $_GET['from_post'] ); | |
| 118 | + $wpdb->update( | |
| 119 | + $wpdb->posts, array( | |
| 120 | + 'post_date' => $original->post_date, | |
| 121 | + 'post_date_gmt' => $original->post_date_gmt, | |
| 122 | + ), | |
| 123 | + array( 'ID' => $post_id ) | |
| 124 | + ); | |
| 125 | + } else { | |
| 126 | + $postarr['post_date'] = $post->post_date; | |
| 127 | + $postarr['post_date_gmt'] = $post->post_date_gmt; | |
| 128 | + } | |
| 129 | + } | |
| 91 | 130 | |
| 92 | - if ( ! $from_post_id || ! $lang || ! empty( $done[ $from_post_id ] ) ) { | |
| 93 | - return; | |
| 131 | + foreach ( $translations as $lang => $tr_id ) { | |
| 132 | + if ( ! $tr_id || $tr_id === $post_id ) { | |
| 133 | + continue; | |
| 94 | 134 | } |
| 95 | 135 | |
| 96 | - $done[ $from_post_id ] = true; // Avoid a second duplication in the block editor. Using an array only to allow multiple phpunit tests. | |
| 136 | + // Add comment status, ping status, menu order... to synchronization | |
| 137 | + $tr_arr = empty( $postarr ) ? array() : $postarr; | |
| 97 | 138 | |
| 98 | - $this->taxonomies->copy( $from_post_id, $post->ID, $lang->slug ); | |
| 99 | - $this->post_metas->copy( $from_post_id, $post->ID, $lang->slug ); | |
| 139 | + if ( isset( $GLOBALS['post_type'] ) ) { | |
| 140 | + $post_type = $GLOBALS['post_type']; | |
| 141 | + } elseif ( isset( $_REQUEST['post_type'] ) ) { | |
| 142 | + $post_type = $_REQUEST['post_type']; // 2nd case for quick edit | |
| 143 | + } | |
| 100 | 144 | |
| 101 | - if ( is_sticky( $from_post_id ) ) { | |
| 102 | - stick_post( $post->ID ); | |
| 145 | + // Add post parent to synchronization | |
| 146 | + // Make sure not to impact media translations when creating them at the same time as post | |
| 147 | + // Do not udpate the translation parent if the user set a parent with no translation | |
| 148 | + if ( in_array( 'post_parent', $this->options['sync'] ) && isset( $post_type ) && $post_type === $post->post_type ) { | |
| 149 | + $post_parent = ( $parent_id = wp_get_post_parent_id( $post_id ) ) ? $this->model->post->get_translation( $parent_id, $lang ) : 0; | |
| 150 | + if ( ! ( $parent_id && ! $post_parent ) ) { | |
| 151 | + $tr_arr['post_parent'] = $post_parent; | |
| 152 | + } | |
| 103 | 153 | } |
| 154 | + | |
| 155 | + // Update all the row at once | |
| 156 | + // Don't use wp_update_post to avoid infinite loop | |
| 157 | + if ( ! empty( $tr_arr ) ) { | |
| 158 | + $wpdb->update( $wpdb->posts, $tr_arr, array( 'ID' => $tr_id ) ); | |
| 159 | + clean_post_cache( $tr_id ); | |
| 160 | + } | |
| 104 | 161 | } |
| 162 | + | |
| 163 | + // Sticky posts | |
| 164 | + if ( in_array( 'sticky_posts', $this->options['sync'] ) ) { | |
| 165 | + $stickies = get_option( 'sticky_posts' ); | |
| 166 | + if ( isset( $_REQUEST['sticky'] ) && 'sticky' === $_REQUEST['sticky'] ) { | |
| 167 | + $stickies = array_merge( $stickies, array_values( $translations ) ); | |
| 168 | + } else { | |
| 169 | + $stickies = array_diff( $stickies, array_values( $translations ) ); | |
| 170 | + } | |
| 171 | + update_option( 'sticky_posts', array_unique( $stickies ) ); | |
| 172 | + } | |
| 105 | 173 | } |
| 106 | 174 | |
| 107 | 175 | /** |
| 108 | - * Get post fields to synchronize | |
| 176 | + * Synchronize term parent in translations | |
| 177 | + * Calling clean_term_cache *after* this is mandatory otherwise the $taxonomy_children option is not correctly updated | |
| 178 | + * Before WP 3.9 clean_term_cache could be called ( efficiently ) only one time due to static array which prevented to update the option more than once | |
| 179 | + * This is the reason to use the edit_term filter and not edited_term | |
| 109 | 180 | * |
| 110 | - * @since 2.4 | |
| 181 | + * @since 2.3 | |
| 111 | 182 | * |
| 112 | - * @param object $post Post object | |
| 113 | - * @return array | |
| 183 | + * @param int $term_id Term id | |
| 184 | + * @param string $taxonomy Taxonomy name | |
| 185 | + * @param array $translations The list of translations term ids | |
| 114 | 186 | */ |
| 115 | - protected function get_fields_to_sync( $post ) { | |
| 187 | + public function sync_term_parent( $term_id, $taxonomy, $translations ) { | |
| 116 | 188 | global $wpdb; |
| 117 | 189 | |
| 118 | - $postarr = parent::get_fields_to_sync( $post ); | |
| 190 | + if ( is_taxonomy_hierarchical( $taxonomy ) && $this->model->is_translated_taxonomy( $taxonomy ) ) { | |
| 191 | + $term = get_term( $term_id ); | |
| 119 | 192 | |
| 120 | - // For new drafts, save the date now otherwise it is overriden by WP. Thanks to JoryHogeveen. See #32. | |
| 121 | - if ( in_array( 'post_date', $this->options['sync'] ) && isset( $GLOBALS['pagenow'], $_GET['from_post'], $_GET['new_lang'] ) && 'post-new.php' === $GLOBALS['pagenow'] ) { | |
| 122 | - check_admin_referer( 'new-post-translation' ); | |
| 193 | + foreach ( $translations as $lang => $tr_id ) { | |
| 194 | + if ( ! empty( $tr_id ) && $tr_id !== $term_id ) { | |
| 195 | + $tr_parent = $this->model->term->get_translation( $term->parent, $lang ); | |
| 123 | 196 | |
| 124 | - unset( $postarr['post_date'] ); | |
| 125 | - unset( $postarr['post_date_gmt'] ); | |
| 197 | + $wpdb->update( | |
| 198 | + $wpdb->term_taxonomy, | |
| 199 | + array( 'parent' => isset( $tr_parent ) ? $tr_parent : 0 ), | |
| 200 | + array( 'term_taxonomy_id' => get_term( (int) $tr_id, $taxonomy )->term_taxonomy_id ) | |
| 201 | + ); | |
| 126 | 202 | |
| 127 | - $original = get_post( (int) $_GET['from_post'] ); | |
| 128 | - $wpdb->update( | |
| 129 | - $wpdb->posts, | |
| 130 | - array( | |
| 131 | - 'post_date' => $original->post_date, | |
| 132 | - 'post_date_gmt' => $original->post_date_gmt, | |
| 133 | - ), | |
| 134 | - array( 'ID' => $post->ID ) | |
| 135 | - ); | |
| 203 | + clean_term_cache( $tr_id, $taxonomy ); // OK since WP 3.9 | |
| 204 | + } | |
| 205 | + } | |
| 136 | 206 | } |
| 207 | + } | |
| 137 | 208 | |
| 138 | - if ( isset( $GLOBALS['post_type'] ) ) { | |
| 139 | - $post_type = $GLOBALS['post_type']; | |
| 140 | - } elseif ( isset( $_REQUEST['post_type'] ) ) { | |
| 141 | - $post_type = sanitize_key( $_REQUEST['post_type'] ); // 2nd case for quick edit | |
| 142 | - } | |
| 143 | - | |
| 144 | - // Make sure not to impact media translations when creating them at the same time as post | |
| 145 | - if ( in_array( 'post_parent', $this->options['sync'] ) && ( ! isset( $post_type ) || $post_type !== $post->post_type ) ) { | |
| 146 | - unset( $postarr['post_parent'] ); | |
| 147 | - } | |
| 148 | - | |
| 149 | - return $postarr; | |
| 209 | + /** | |
| 210 | + * Synchronizes terms and metas in translations for media | |
| 211 | + * | |
| 212 | + * @since 1.8 | |
| 213 | + * | |
| 214 | + * @param int $post_id post id | |
| 215 | + */ | |
| 216 | + public function edit_attachment( $post_id ) { | |
| 217 | + $this->pll_save_post( $post_id, get_post( $post_id ), $this->model->post->get_translations( $post_id ) ); | |
| 150 | 218 | } |
| 151 | 219 | |
| 152 | 220 | /** |
| 153 | - * Synchronizes post fields in translations | |
| 221 | + * Synchronize sticky posts | |
| 154 | 222 | * |
| 155 | - * @since 1.2 | |
| 223 | + * @since 2.3 | |
| 156 | 224 | * |
| 157 | - * @param int $post_id post id | |
| 158 | - * @param object $post post object | |
| 159 | - * @param array $translations post translations | |
| 225 | + * @param array $value New option value | |
| 226 | + * @param array $old_value Old option value | |
| 227 | + * @return array | |
| 160 | 228 | */ |
| 161 | - public function pll_save_post( $post_id, $post, $translations ) { | |
| 162 | - parent::pll_save_post( $post_id, $post, $translations ); | |
| 229 | + public function sync_sticky_posts( $value, $old_value ) { | |
| 230 | + if ( in_array( 'sticky_posts', $this->options['sync'] ) ) { | |
| 231 | + // Stick post | |
| 232 | + if ( $sticked = array_diff( $value, $old_value ) ) { | |
| 233 | + $translations = $this->model->post->get_translations( reset( $sticked ) ); | |
| 234 | + $value = array_unique( array_merge( $value, array_values( $translations ) ) ); | |
| 235 | + } | |
| 163 | 236 | |
| 164 | - // Sticky posts | |
| 165 | - if ( in_array( 'sticky_posts', $this->options['sync'] ) ) { | |
| 166 | - $stickies = get_option( 'sticky_posts' ); | |
| 167 | - if ( isset( $_REQUEST['sticky'] ) && 'sticky' === $_REQUEST['sticky'] ) { // phpcs:ignore WordPress.Security.NonceVerification | |
| 168 | - $stickies = array_merge( $stickies, array_values( $translations ) ); | |
| 169 | - } else { | |
| 170 | - $stickies = array_diff( $stickies, array_values( $translations ) ); | |
| 237 | + // Unstick post | |
| 238 | + if ( $unsticked = array_diff( $old_value, $value ) ) { | |
| 239 | + $translations = $this->model->post->get_translations( reset( $unsticked ) ); | |
| 240 | + $value = array_unique( array_diff( $value, array_values( $translations ) ) ); | |
| 171 | 241 | } |
| 172 | - update_option( 'sticky_posts', array_unique( $stickies ) ); | |
| 173 | 242 | } |
| 243 | + | |
| 244 | + return $value; | |
| 174 | 245 | } |
| 175 | 246 | |
| 176 | 247 | /** |
| 177 | 248 | * Some backward compatibility with Polylang < 2.3 |
| @@ -188,32 +259,19 @@ | ||
| 188 | 259 | $obj = substr( $func, 5 ); |
| 189 | 260 | |
| 190 | 261 | if ( is_object( $this->$obj ) && method_exists( $this->$obj, 'copy' ) ) { |
| 191 | 262 | if ( WP_DEBUG ) { |
| 192 | - $debug = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS ); // phpcs:ignore WordPress.PHP.DevelopmentFunctions | |
| 263 | + $debug = debug_backtrace(); | |
| 193 | 264 | $i = 1 + empty( $debug[1]['line'] ); // The file and line are in $debug[2] if the function was called using call_user_func |
| 194 | 265 | |
| 195 | - trigger_error( // phpcs:ignore WordPress.PHP.DevelopmentFunctions | |
| 196 | - sprintf( | |
| 197 | - '%1$s was called incorrectly in %3$s on line %4$s: the call to PLL()->sync->%1$s() has been deprecated in Polylang 2.3, use PLL()->sync->%2$s->copy() instead.' . "\nError handler", | |
| 198 | - esc_html( $func ), | |
| 199 | - esc_html( $obj ), | |
| 200 | - esc_html( $debug[ $i ]['file'] ), | |
| 201 | - absint( $debug[ $i ]['line'] ) | |
| 202 | - ) | |
| 203 | - ); | |
| 266 | + trigger_error( sprintf( | |
| 267 | + '%1$s was called incorrectly in %3$s on line %4$s: the call to PLL()->sync->%1$s() has been deprecated in Polylang 2.3, use PLL()->sync->%2$s->copy() instead.' . "\nError handler", | |
| 268 | + $func, $obj, $debug[ $i ]['file'], $debug[ $i ]['line'] | |
| 269 | + ) ); | |
| 204 | 270 | } |
| 205 | 271 | return call_user_func_array( array( $this->$obj, 'copy' ), $args ); |
| 206 | 272 | } |
| 207 | 273 | |
| 208 | - $debug = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS ); // phpcs:ignore WordPress.PHP.DevelopmentFunctions | |
| 209 | - trigger_error( // phpcs:ignore WordPress.PHP.DevelopmentFunctions | |
| 210 | - sprintf( | |
| 211 | - 'Call to undefined function PLL()->sync->%1$s() in %2$s on line %3$s' . "\nError handler", | |
| 212 | - esc_html( $func ), | |
| 213 | - esc_html( $debug[0]['file'] ), | |
| 214 | - absint( $debug[0]['line'] ) | |
| 215 | - ), | |
| 216 | - E_USER_ERROR | |
| 217 | - ); | |
| 274 | + $debug = debug_backtrace(); | |
| 275 | + trigger_error( sprintf( 'Call to undefined function PLL()->sync->%1$s() in %2$s on line %3$s' . "\nError handler", $func, $debug[0]['file'], $debug[0]['line'] ), E_USER_ERROR ); | |
| 218 | 276 | } |
| 219 | 277 | } |
