PluginProbe
Polylang / 2.5.2
Polylang v2.5.2
3.8.9 3.8.8 3.8.7 3.8.6 3.8.5 3.8.4 3.8.3 2.7 2.7.0.1 2.7.1 2.7.2 2.7.3 2.7.4 2.8 2.8.1 2.8.2 2.8.3 2.8.4 2.9 2.9.1 2.9.2 3.0 3.0.1 3.0.2 3.0.3 All 233 releases
← All changes | admin/admin-base.php +96 -186 3.0.22.5.2 View file →
@@ -1,66 +1,28 @@
1 1 <?php
2 -/**
3 - * @package Polylang
4 - */
5 2
6 3 /**
7 - * Setup features available on all admin pages.
4 + * Base class for both admin
8 5 *
9 6 * @since 1.8
10 7 */
11 -abstract class PLL_Admin_Base extends PLL_Base {
12 - /**
13 - * Current language (used to filter the content).
14 - *
15 - * @var PLL_Language
16 - */
17 - public $curlang;
8 +class PLL_Admin_Base extends PLL_Base {
9 + public $filter_lang, $curlang, $pref_lang;
18 10
19 11 /**
20 - * Language selected in the admin language filter.
12 + * Loads the polylang text domain
13 + * Setups actions needed on all admin pages
21 14 *
22 - * @var PLL_Language
23 - */
24 - public $filter_lang;
25 -
26 - /**
27 - * Preferred language to assign to new contents.
28 - *
29 - * @var PLL_Language
30 - */
31 - public $pref_lang;
32 -
33 - /**
34 - * @var PLL_Filters_Links
35 - */
36 - public $filters_links;
37 -
38 - /**
39 - * @var PLL_Admin_Links
40 - */
41 - public $links;
42 -
43 - /**
44 - * @var PLL_Admin_Notices
45 - */
46 - public $notices;
47 -
48 - /**
49 - * @var PLL_Admin_Static_Pages
50 - */
51 - public $static_pages;
52 -
53 - /**
54 - * Setups actions needed on all admin pages.
55 - *
56 15 * @since 1.8
57 16 *
58 - * @param PLL_Links_Model $links_model Reference to the links model.
17 + * @param object $links_model
59 18 */
60 19 public function __construct( &$links_model ) {
61 20 parent::__construct( $links_model );
62 21
22 + // Plugin i18n, only needed for backend
23 + load_plugin_textdomain( 'polylang', false, basename( POLYLANG_DIR ) . '/languages' );
24 +
63 25 // Adds the link to the languages panel in the WordPress admin menu
64 26 add_action( 'admin_menu', array( $this, 'add_menus' ) );
65 27
66 28 // Setup js scripts and css styles
@@ -67,8 +29,13 @@
67 29 add_action( 'admin_enqueue_scripts', array( $this, 'admin_enqueue_scripts' ) );
68 30 add_action( 'admin_print_footer_scripts', array( $this, 'admin_print_footer_scripts' ), 0 ); // High priority in case an ajax request is sent by an immediately invoked function
69 31
70 32 add_action( 'customize_controls_enqueue_scripts', array( $this, 'customize_controls_enqueue_scripts' ) );
33 +
34 + // Lingotek
35 + if ( ! defined( 'POLYLANG_PRO' ) && ( ! defined( 'PLL_LINGOTEK_AD' ) || PLL_LINGOTEK_AD ) ) {
36 + require_once POLYLANG_DIR . '/lingotek/lingotek.php';
37 + }
71 38 }
72 39
73 40 /**
74 41 * Setups filters and action needed on all admin pages and on plugins page
@@ -76,16 +43,13 @@
76 43 *
77 44 * @since 1.2
78 45 */
79 46 public function init() {
80 - parent::init();
81 -
82 - $this->notices = new PLL_Admin_Notices( $this );
83 -
84 47 if ( ! $this->model->get_languages_list() ) {
85 48 return;
86 49 }
87 50
51 + $this->notices = new PLL_Admin_Notices( $this );
88 52 $this->links = new PLL_Admin_Links( $this ); // FIXME needed here ?
89 53 $this->static_pages = new PLL_Admin_Static_Pages( $this ); // FIXME needed here ?
90 54 $this->filters_links = new PLL_Filters_Links( $this ); // FIXME needed here ?
91 55
@@ -90,9 +54,9 @@
90 54 $this->filters_links = new PLL_Filters_Links( $this ); // FIXME needed here ?
91 55
92 56 // Filter admin language for users
93 57 // We must not call user info before WordPress defines user roles in wp-settings.php
94 - add_action( 'setup_theme', array( $this, 'init_user' ) );
58 + add_filter( 'setup_theme', array( $this, 'init_user' ) );
95 59 add_filter( 'request', array( $this, 'request' ) );
96 60
97 61 // Adds the languages in admin bar
98 62 add_action( 'admin_bar_menu', array( $this, 'admin_bar_menu' ), 100 ); // 100 determines the position
@@ -101,14 +65,10 @@
101 65 /**
102 66 * Adds the link to the languages panel in the WordPress admin menu
103 67 *
104 68 * @since 0.1
105 - *
106 - * @return void
107 69 */
108 70 public function add_menus() {
109 - global $admin_page_hooks;
110 -
111 71 // Prepare the list of tabs
112 72 $tabs = array( 'lang' => __( 'Languages', 'polylang' ) );
113 73
114 74 // Only if at least one language has been created
@@ -126,16 +86,13 @@
126 86 * @param array $tabs list of tab names
127 87 */
128 88 $tabs = apply_filters( 'pll_settings_tabs', $tabs );
129 89
130 - $parent = '';
131 -
132 90 foreach ( $tabs as $tab => $title ) {
133 91 $page = 'lang' === $tab ? 'mlang' : "mlang_$tab";
134 92 if ( empty( $parent ) ) {
135 93 $parent = $page;
136 - add_menu_page( $title, __( 'Languages', 'polylang' ), 'manage_options', $page, '__return_null', 'dashicons-translation' );
137 - $admin_page_hooks[ $page ] = 'languages'; // Hack to avoid the localization of the hook name. See: https://core.trac.wordpress.org/ticket/18857
94 + add_menu_page( $title, __( 'Languages', 'polylang' ), 'manage_options', $page, null, 'dashicons-translation' );
138 95 }
139 96
140 97 add_submenu_page( $parent, $title, $title, 'manage_options', $page, array( $this, 'languages_page' ) );
141 98 }
@@ -144,10 +101,8 @@
144 101 /**
145 102 * Setup js scripts & css styles ( only on the relevant pages )
146 103 *
147 104 * @since 0.6
148 - *
149 - * @return void
150 105 */
151 106 public function admin_enqueue_scripts() {
152 107 $screen = get_current_screen();
153 108 if ( empty( $screen ) ) {
@@ -155,49 +110,38 @@
155 110 }
156 111
157 112 $suffix = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
158 113
159 - /*
160 - * For each script:
161 - * 0 => the pages on which to load the script
162 - * 1 => the scripts it needs to work
163 - * 2 => 1 if loaded even if languages have not been defined yet, 0 otherwise
164 - * 3 => 1 if loaded in footer
165 - */
114 + // For each script:
115 + // 0 => the pages on which to load the script
116 + // 1 => the scripts it needs to work
117 + // 2 => 1 if loaded even if languages have not been defined yet, 0 otherwise
118 + // 3 => 1 if loaded in footer
119 + // FIXME: check if I can load more scripts in footer
166 120 $scripts = array(
167 - 'user' => array( array( 'profile', 'user-edit' ), array( 'jquery' ), 0, 0 ),
168 - 'widgets' => array( array( 'widgets' ), array( 'jquery' ), 0, 0 ),
121 + 'post' => array( array( 'edit' ), array( 'jquery', 'wp-ajax-response' ), 0, 1 ),
122 + 'media' => array( array( 'upload' ), array( 'jquery' ), 0, 1 ),
123 + 'term' => array( array( 'edit-tags', 'term' ), array( 'jquery', 'wp-ajax-response', 'jquery-ui-autocomplete' ), 0, 1 ),
124 + 'user' => array( array( 'profile', 'user-edit' ), array( 'jquery' ), 0, 0 ),
125 + 'widgets' => array( array( 'widgets' ), array( 'jquery' ), 0, 0 ),
169 126 );
170 127
171 128 if ( ! empty( $screen->post_type ) && $this->model->is_translated_post_type( $screen->post_type ) ) {
172 - $scripts['post'] = array( array( 'edit', 'upload' ), array( 'jquery', 'wp-ajax-response' ), 0, 1 );
129 + $scripts['classic-editor'] = array( array( 'post', 'media', 'async-upload' ), array( 'jquery', 'wp-ajax-response', 'post', 'jquery-ui-autocomplete' ), 0, 1 );
173 130
174 - // Classic editor.
175 - if ( ! method_exists( $screen, 'is_block_editor' ) || ! $screen->is_block_editor() ) {
176 - $scripts['classic-editor'] = array( array( 'post', 'media', 'async-upload' ), array( 'jquery', 'wp-ajax-response', 'post', 'jquery-ui-dialog', 'wp-i18n' ), 0, 1 );
131 + // Block editor in WP 5.0+
132 + if ( method_exists( $screen, 'is_block_editor' ) && $screen->is_block_editor() ) {
133 + $scripts['block-editor'] = array( array( 'post' ), array( 'wp-api-fetch' ), 0, 1 );
177 134 }
178 -
179 - // Block editor with legacy metabox in WP 5.0+.
180 - if ( method_exists( $screen, 'is_block_editor' ) && $screen->is_block_editor() && ! pll_use_block_editor_plugin() ) {
181 - $scripts['block-editor'] = array( array( 'post' ), array( 'jquery', 'wp-ajax-response', 'wp-api-fetch', 'jquery-ui-dialog', 'wp-i18n' ), 0, 1 );
182 - }
183 135 }
184 136
185 - if ( ! empty( $screen->taxonomy ) && $this->model->is_translated_taxonomy( $screen->taxonomy ) ) {
186 - $scripts['term'] = array( array( 'edit-tags', 'term' ), array( 'jquery', 'wp-ajax-response', 'jquery-ui-autocomplete' ), 0, 1 );
187 - }
188 -
189 137 foreach ( $scripts as $script => $v ) {
190 138 if ( in_array( $screen->base, $v[0] ) && ( $v[2] || $this->model->get_languages_list() ) ) {
191 - wp_enqueue_script( 'pll_' . $script, plugins_url( '/js/build/' . $script . $suffix . '.js', POLYLANG_ROOT_FILE ), $v[1], POLYLANG_VERSION, $v[3] );
192 - if ( 'classic-editor' === $script || 'block-editor' === $script ) {
193 - wp_set_script_translations( 'pll_' . $script, 'polylang' );
194 - }
139 + wp_enqueue_script( 'pll_' . $script, plugins_url( '/js/' . $script . $suffix . '.js', POLYLANG_FILE ), $v[1], POLYLANG_VERSION, $v[3] );
195 140 }
196 141 }
197 142
198 - wp_register_style( 'polylang_admin', plugins_url( '/css/build/admin' . $suffix . '.css', POLYLANG_ROOT_FILE ), array( 'wp-jquery-ui-dialog' ), POLYLANG_VERSION );
199 - wp_enqueue_style( 'polylang_dialog', plugins_url( '/css/build/dialog' . $suffix . '.css', POLYLANG_ROOT_FILE ), array( 'polylang_admin' ), POLYLANG_VERSION );
143 + wp_enqueue_style( 'polylang_admin', plugins_url( '/css/admin' . $suffix . '.css', POLYLANG_FILE ), array(), POLYLANG_VERSION );
200 144
201 145 $this->localize_scripts();
202 146 }
203 147
@@ -204,15 +148,13 @@
204 148 /**
205 149 * Enqueue scripts to the WP Customizer.
206 150 *
207 151 * @since 2.4.0
208 - *
209 - * @return void
210 152 */
211 153 public function customize_controls_enqueue_scripts() {
212 154 if ( $this->model->get_languages_list() ) {
213 155 $suffix = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
214 - wp_enqueue_script( 'pll_widgets', plugins_url( '/js/build/widgets' . $suffix . '.js', POLYLANG_ROOT_FILE ), array( 'jquery' ), POLYLANG_VERSION, true );
156 + wp_enqueue_script( 'pll_widgets', plugins_url( '/js/widgets' . $suffix . '.js', POLYLANG_FILE ), array( 'jquery' ), POLYLANG_VERSION, true );
215 157 $this->localize_scripts();
216 158 }
217 159 }
218 160
@@ -219,10 +161,8 @@
219 161 /**
220 162 * Localize scripts.
221 163 *
222 164 * @since 2.4.0
223 - *
224 - * @return void
225 165 */
226 166 public function localize_scripts() {
227 167 if ( wp_script_is( 'pll_widgets', 'enqueued' ) ) {
228 168 wp_localize_script(
@@ -247,10 +187,8 @@
247 187 * when options.data is an empty string (GET request with the method 'load')
248 188 * see: https://wordpress.org/support/topic/invalid-url-during-wordpress-new-dashboard-widget-operation
249 189 *
250 190 * @since 1.4
251 - *
252 - * @return void
253 191 */
254 192 public function admin_print_footer_scripts() {
255 193 global $post_ID, $tag_ID;
256 194
@@ -263,48 +201,38 @@
263 201 $params = array_merge( $params, array( 'pll_term_id' => (int) $tag_ID ) );
264 202 }
265 203
266 204 $str = http_build_query( $params );
267 - $arr = wp_json_encode( $params );
205 + $arr = json_encode( $params );
268 206 ?>
269 207 <script type="text/javascript">
270 208 if (typeof jQuery != 'undefined') {
271 - jQuery(
272 - function( $ ){
273 - $.ajaxPrefilter( function ( options, originalOptions, jqXHR ) {
274 - if ( -1 != options.url.indexOf( ajaxurl ) || -1 != ajaxurl.indexOf( options.url ) ) {
275 -
276 - function addStringParameters() {
277 - if ( 'undefined' === typeof options.data || '' === options.data ) {
278 - options.data = '<?php echo $str; // phpcs:ignore WordPress.Security.EscapeOutput ?>';
209 + (function($){
210 + $.ajaxPrefilter(function (options, originalOptions, jqXHR) {
211 + if ( -1 != options.url.indexOf( ajaxurl ) || -1 != ajaxurl.indexOf( options.url ) ) {
212 + if ( 'undefined' === typeof options.data ) {
213 + options.data = ( 'get' === options.type.toLowerCase() ) ? '<?php echo $str; ?>' : <?php echo $arr; ?>;
214 + } else {
215 + if ( 'string' === typeof options.data ) {
216 + if ( '' === options.data && 'get' === options.type.toLowerCase() ) {
217 + options.url = options.url+'&<?php echo $str; ?>';
279 218 } else {
280 - options.data = options.data + '&<?php echo $str; // phpcs:ignore WordPress.Security.EscapeOutput ?>';
219 + try {
220 + var o = $.parseJSON(options.data);
221 + o = $.extend(o, <?php echo $arr; ?>);
222 + options.data = JSON.stringify(o);
223 + }
224 + catch(e) {
225 + options.data = '<?php echo $str; ?>&'+options.data;
226 + }
281 227 }
282 - }
283 -
284 - /*
285 - * options.processData set to true is the default jQuery process where the data is converted in a query string by using jQuery.param().
286 - * This step is done before applying filters. Thus here the options.data is already a string in this case.
287 - * @See https://github.com/jquery/jquery/blob/3.5.1/src/ajax.js#L563-L569 jQuery ajax function.
288 - */
289 - if ( options.processData ) {
290 - addStringParameters();
291 228 } else {
292 - /*
293 - * If options.processData is set to false data could be undefined or pass as a string.
294 - * So data as to be processed as if options.processData is set to true.
295 - */
296 - if ( 'undefined' === typeof options.data || 'string' === typeof options.data ) {
297 - addStringParameters();
298 - } else {
299 - // Otherwise options.data is probably an object.
300 - options.data = Object.assign( options.data, <?php echo $arr; // phpcs:ignore WordPress.Security.EscapeOutput ?> );
301 - }
229 + options.data = $.extend(options.data, <?php echo $arr; ?>);
302 230 }
303 231 }
304 - });
305 - }
306 - );
232 + }
233 + });
234 + })(jQuery)
307 235 }
308 236 </script>
309 237 <?php
310 238 }
@@ -312,31 +240,30 @@
312 240 /**
313 241 * Sets the admin current language, used to filter the content
314 242 *
315 243 * @since 2.0
316 - *
317 - * @return void
318 244 */
319 245 public function set_current_language() {
320 246 $this->curlang = $this->filter_lang;
321 247
322 248 // Edit Post
323 - if ( isset( $_REQUEST['pll_post_id'] ) && $lang = $this->model->post->get_language( (int) $_REQUEST['pll_post_id'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification
249 + if ( isset( $_REQUEST['pll_post_id'] ) && $lang = $this->model->post->get_language( (int) $_REQUEST['pll_post_id'] ) ) {
324 250 $this->curlang = $lang;
325 - } elseif ( 'post.php' === $GLOBALS['pagenow'] && isset( $_GET['post'] ) && $this->model->is_translated_post_type( get_post_type( (int) $_GET['post'] ) ) && $lang = $this->model->post->get_language( (int) $_GET['post'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification
251 + } elseif ( 'post.php' === $GLOBALS['pagenow'] && isset( $_GET['post'] ) && is_numeric( $_GET['post'] ) && $lang = $this->model->post->get_language( (int) $_GET['post'] ) ) {
326 252 $this->curlang = $lang;
327 - } elseif ( 'post-new.php' === $GLOBALS['pagenow'] && ( empty( $_GET['post_type'] ) || $this->model->is_translated_post_type( sanitize_key( $_GET['post_type'] ) ) ) ) { // phpcs:ignore WordPress.Security.NonceVerification
328 - $this->curlang = empty( $_GET['new_lang'] ) ? $this->pref_lang : $this->model->get_language( sanitize_key( $_GET['new_lang'] ) ); // phpcs:ignore WordPress.Security.NonceVerification
253 + } elseif ( 'post-new.php' === $GLOBALS['pagenow'] && ( empty( $_GET['post_type'] ) || $this->model->is_translated_post_type( $_GET['post_type'] ) ) ) {
254 + $this->curlang = empty( $_GET['new_lang'] ) ? $this->pref_lang : $this->model->get_language( $_GET['new_lang'] );
329 255 }
330 256
331 257 // Edit Term
332 - elseif ( isset( $_REQUEST['pll_term_id'] ) && $lang = $this->model->term->get_language( (int) $_REQUEST['pll_term_id'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification
258 + // FIXME 'edit-tags.php' for backward compatibility with WP < 4.5
259 + elseif ( in_array( $GLOBALS['pagenow'], array( 'edit-tags.php', 'term.php' ) ) && isset( $_GET['tag_ID'] ) && $lang = $this->model->term->get_language( (int) $_GET['tag_ID'] ) ) {
333 260 $this->curlang = $lang;
334 - } elseif ( in_array( $GLOBALS['pagenow'], array( 'edit-tags.php', 'term.php' ) ) && isset( $_GET['taxonomy'] ) && $this->model->is_translated_taxonomy( sanitize_key( $_GET['taxonomy'] ) ) ) { // phpcs:ignore WordPress.Security.NonceVerification
335 - if ( isset( $_GET['tag_ID'] ) && $lang = $this->model->term->get_language( (int) $_GET['tag_ID'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification
336 - $this->curlang = $lang;
337 - } elseif ( ! empty( $_GET['new_lang'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification
338 - $this->curlang = $this->model->get_language( sanitize_key( $_GET['new_lang'] ) ); // phpcs:ignore WordPress.Security.NonceVerification
261 + } elseif ( isset( $_REQUEST['pll_term_id'] ) && $lang = $this->model->term->get_language( (int) $_REQUEST['pll_term_id'] ) ) {
262 + $this->curlang = $lang;
263 + } elseif ( 'edit-tags.php' === $GLOBALS['pagenow'] && isset( $_GET['taxonomy'] ) && $this->model->is_translated_taxonomy( $_GET['taxonomy'] ) ) {
264 + if ( ! empty( $_GET['new_lang'] ) ) {
265 + $this->curlang = $this->model->get_language( $_GET['new_lang'] );
339 266 } elseif ( empty( $this->curlang ) ) {
340 267 $this->curlang = $this->pref_lang;
341 268 }
342 269 }
@@ -341,20 +268,11 @@
341 268 }
342 269 }
343 270
344 271 // Ajax
345 - if ( wp_doing_ajax() && ! empty( $_REQUEST['lang'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification
346 - $this->curlang = $this->model->get_language( sanitize_key( $_REQUEST['lang'] ) ); // phpcs:ignore WordPress.Security.NonceVerification
272 + if ( wp_doing_ajax() && ! empty( $_REQUEST['lang'] ) ) {
273 + $this->curlang = $this->model->get_language( $_REQUEST['lang'] );
347 274 }
348 -
349 - // Inform that the admin language has been set.
350 - if ( $this->curlang ) {
351 - /** This action is documented in frontend/choose-lang.php */
352 - do_action( 'pll_language_defined', $this->curlang->slug, $this->curlang );
353 - } else {
354 - /** This action is documented in include/class-polylang.php */
355 - do_action( 'pll_no_language_defined' ); // To load overridden textdomains.
356 - }
357 275 }
358 276
359 277 /**
360 278 * Defines the backend language and the admin language filter based on user preferences
@@ -359,17 +277,14 @@
359 277 /**
360 278 * Defines the backend language and the admin language filter based on user preferences
361 279 *
362 280 * @since 1.2.3
363 - *
364 - * @return void
365 281 */
366 282 public function init_user() {
367 283 // Language for admin language filter: may be empty
368 284 // $_GET['lang'] is numeric when editing a language, not when selecting a new language in the filter
369 - // We intentionally don't use a nonce to update the language filter
370 - if ( ! wp_doing_ajax() && ! empty( $_GET['lang'] ) && ! is_numeric( sanitize_key( $_GET['lang'] ) ) && current_user_can( 'edit_user', $user_id = get_current_user_id() ) ) { // phpcs:ignore WordPress.Security.NonceVerification
371 - update_user_meta( $user_id, 'pll_filter_content', ( $lang = $this->model->get_language( sanitize_key( $_GET['lang'] ) ) ) ? $lang->slug : '' ); // phpcs:ignore WordPress.Security.NonceVerification
285 + if ( ! wp_doing_ajax() && ! empty( $_GET['lang'] ) && ! is_numeric( $_GET['lang'] ) && current_user_can( 'edit_user', $user_id = get_current_user_id() ) ) {
286 + update_user_meta( $user_id, 'pll_filter_content', ( $lang = $this->model->get_language( $_GET['lang'] ) ) ? $lang->slug : '' );
372 287 }
373 288
374 289 $this->filter_lang = $this->model->get_language( get_user_meta( get_current_user_id(), 'pll_filter_content', true ) );
375 290
@@ -376,21 +291,28 @@
376 291 // Set preferred language for use when saving posts and terms: must not be empty
377 292 $this->pref_lang = empty( $this->filter_lang ) ? $this->model->get_language( $this->options['default_lang'] ) : $this->filter_lang;
378 293
379 294 /**
380 - * Filters the preferred language on admin side.
381 - * The preferred language is used for example to determine the language of a new post.
295 + * Filter the preferred language on admin side
296 + * The preferred language is used for example to determine the language of a new post
382 297 *
383 298 * @since 1.2.3
384 299 *
385 - * @param PLL_Language $pref_lang Preferred language.
300 + * @param object $pref_lang preferred language
386 301 */
387 302 $this->pref_lang = apply_filters( 'pll_admin_preferred_language', $this->pref_lang );
388 303
389 304 $this->set_current_language();
390 305
391 - // Plugin i18n, only needed for backend.
392 - load_plugin_textdomain( 'polylang' );
306 + // Inform that the admin language has been set
307 + // Only if the admin language is one of the Polylang defined language
308 + if ( $curlang = $this->model->get_language( get_user_locale() ) ) {
309 + /** This action is documented in frontend/choose-lang.php */
310 + do_action( 'pll_language_defined', $curlang->slug, $curlang );
311 + } else {
312 + /** This action is documented in include/class-polylang.php */
313 + do_action( 'pll_no_language_defined' ); // to load overridden textdomains
314 + }
393 315 }
394 316
395 317 /**
396 318 * Avoids parsing a tax query when all languages are requested
@@ -395,9 +317,9 @@
395 317 /**
396 318 * Avoids parsing a tax query when all languages are requested
397 319 * Fixes https://wordpress.org/support/topic/notice-undefined-offset-0-in-wp-includesqueryphp-on-line-3877 introduced in WP 4.1
398 320 *
399 - * @see https://core.trac.wordpress.org/ticket/31246 the suggestion of @boonebgorges.
321 + * @see the suggestion of @boonebgorges, https://core.trac.wordpress.org/ticket/31246
400 322 *
401 323 * @since 1.6.5
402 324 *
403 325 * @param array $qvars
@@ -411,14 +333,13 @@
411 333 return $qvars;
412 334 }
413 335
414 336 /**
415 - * Adds the languages list in admin bar for the admin languages filter.
337 + * Adds the languages list in admin bar for the admin languages filter
416 338 *
417 339 * @since 0.9
418 340 *
419 - * @param WP_Admin_Bar $wp_admin_bar WP_Admin_Bar global object.
420 - * @return void
341 + * @param object $wp_admin_bar
421 342 */
422 343 public function admin_bar_menu( $wp_admin_bar ) {
423 344 $all_item = (object) array(
424 345 'slug' => 'all',
@@ -434,29 +355,18 @@
434 355 __( 'Filters content by language', 'polylang' ),
435 356 esc_html( $selected->name )
436 357 );
437 358
438 - /**
439 - * Filters the admin languages filter submenu items
440 - *
441 - * @since 2.6
442 - *
443 - * @param array $items The admin languages filter submenu items.
444 - */
445 - $items = apply_filters( 'pll_admin_languages_filter', array_merge( array( $all_item ), $this->model->get_languages_list() ) );
359 + $wp_admin_bar->add_menu(
360 + array(
361 + 'id' => 'languages',
362 + 'title' => $selected->flag . $title,
363 + 'href' => esc_url( add_query_arg( 'lang', $selected->slug, remove_query_arg( 'paged' ) ) ),
364 + 'meta' => array( 'title' => __( 'Filters content by language', 'polylang' ) ),
365 + )
366 + );
446 367
447 - if ( ! empty( $items ) ) {
448 - $wp_admin_bar->add_menu(
449 - array(
450 - 'id' => 'languages',
451 - 'title' => $selected->flag . $title,
452 - 'href' => esc_url( add_query_arg( 'lang', $selected->slug, remove_query_arg( 'paged' ) ) ),
453 - 'meta' => array( 'title' => __( 'Filters content by language', 'polylang' ) ),
454 - )
455 - );
456 - }
457 -
458 - foreach ( $items as $lang ) {
368 + foreach ( array_merge( array( $all_item ), $this->model->get_languages_list() ) as $lang ) {
459 369 if ( $selected->slug === $lang->slug ) {
460 370 continue;
461 371 }
462 372