| @@ -3,11 +3,10 @@ | ||
| 3 | 3 | * @package Polylang |
| 4 | 4 | */ |
| 5 | 5 | |
| 6 | 6 | /** |
| 7 | - * Links model for use when the language code is added in url as a directory | |
| 8 | - * for example mysite.com/en/something | |
| 9 | - * implements the "links_model interface" | |
| 7 | + * Links model for use when the language code is added in the url as a directory | |
| 8 | + * for example mysite.com/en/something. | |
| 10 | 9 | * |
| 11 | 10 | * @since 1.2 |
| 12 | 11 | */ |
| 13 | 12 | class PLL_Links_Directory extends PLL_Links_Permalinks { |
| @@ -28,18 +27,12 @@ | ||
| 28 | 27 | public function __construct( &$model ) { |
| 29 | 28 | parent::__construct( $model ); |
| 30 | 29 | |
| 31 | 30 | $this->home_relative = home_url( '/', 'relative' ); |
| 32 | - | |
| 33 | - if ( did_action( 'pll_init' ) ) { | |
| 34 | - $this->init(); | |
| 35 | - } else { | |
| 36 | - add_action( 'pll_init', array( $this, 'init' ) ); | |
| 37 | - } | |
| 38 | 31 | } |
| 39 | 32 | |
| 40 | 33 | /** |
| 41 | - * Called only at first object creation to avoid duplicating filters when switching blog | |
| 34 | + * Adds hooks for rewrite rules. | |
| 42 | 35 | * |
| 43 | 36 | * @since 1.6 |
| 44 | 37 | * |
| 45 | 38 | * @return void |
| @@ -44,38 +37,37 @@ | ||
| 44 | 37 | * |
| 45 | 38 | * @return void |
| 46 | 39 | */ |
| 47 | 40 | public function init() { |
| 48 | - if ( did_action( 'setup_theme' ) ) { | |
| 49 | - $this->add_permastruct(); | |
| 50 | - } else { | |
| 51 | - add_action( 'setup_theme', array( $this, 'add_permastruct' ), 2 ); | |
| 52 | - } | |
| 41 | + add_action( 'pll_prepare_rewrite_rules', array( $this, 'prepare_rewrite_rules' ) ); // Ensure it's hooked before `self::do_prepare_rewrite_rules()` is called. | |
| 53 | 42 | |
| 54 | - // Make sure to prepare rewrite rules when flushing | |
| 55 | - add_action( 'pre_option_rewrite_rules', array( $this, 'prepare_rewrite_rules' ) ); | |
| 43 | + parent::init(); | |
| 56 | 44 | } |
| 57 | 45 | |
| 58 | 46 | /** |
| 59 | 47 | * Adds the language code in a url. |
| 60 | - * links_model interface. | |
| 61 | 48 | * |
| 62 | 49 | * @since 1.2 |
| 50 | + * @since 3.4 Accepts now a language slug. | |
| 63 | 51 | * |
| 64 | - * @param string $url The url to modify. | |
| 65 | - * @param PLL_Language $lang The language object. | |
| 66 | - * @return string Modified url. | |
| 52 | + * @param string $url The url to modify. | |
| 53 | + * @param PLL_Language|string|false $language Language object or slug. | |
| 54 | + * @return string The modified url. | |
| 67 | 55 | */ |
| 68 | - public function add_language_to_link( $url, $lang ) { | |
| 69 | - if ( ! empty( $lang ) ) { | |
| 56 | + public function add_language_to_link( $url, $language ) { | |
| 57 | + if ( $language instanceof PLL_Language ) { | |
| 58 | + $language = $language->slug; | |
| 59 | + } | |
| 60 | + | |
| 61 | + if ( ! empty( $language ) ) { | |
| 70 | 62 | $base = $this->options['rewrite'] ? '' : 'language/'; |
| 71 | - $slug = $this->options['default_lang'] == $lang->slug && $this->options['hide_default'] ? '' : $base . $lang->slug . '/'; | |
| 63 | + $slug = $this->options['default_lang'] === $language && $this->options['hide_default'] ? '' : $base . $language . '/'; | |
| 72 | 64 | $root = ( false === strpos( $url, '://' ) ) ? $this->home_relative . $this->root : preg_replace( '#^https?://#', '://', $this->home . '/' . $this->root ); |
| 73 | 65 | |
| 74 | 66 | if ( false === strpos( $url, $new = $root . $slug ) ) { |
| 75 | 67 | $pattern = preg_quote( $root, '#' ); |
| 76 | 68 | $pattern = '#' . $pattern . '#'; |
| 77 | - return preg_replace( $pattern, $new, $url, 1 ); // Only once | |
| 69 | + return preg_replace( $pattern, $new, $url, 1 ); // Only once. | |
| 78 | 70 | } |
| 79 | 71 | } |
| 80 | 72 | return $url; |
| 81 | 73 | } |
| @@ -80,44 +72,41 @@ | ||
| 80 | 72 | return $url; |
| 81 | 73 | } |
| 82 | 74 | |
| 83 | 75 | /** |
| 84 | - * Returns the url without language code | |
| 85 | - * links_model interface | |
| 76 | + * Returns the url without the language code. | |
| 86 | 77 | * |
| 87 | 78 | * @since 1.2 |
| 88 | 79 | * |
| 89 | - * @param string $url url to modify | |
| 90 | - * @return string modified url | |
| 80 | + * @param string $url The url to modify. | |
| 81 | + * @return string The modified url. | |
| 91 | 82 | */ |
| 92 | 83 | public function remove_language_from_link( $url ) { |
| 93 | - $languages = array(); | |
| 84 | + $languages = $this->model->get_languages_list( | |
| 85 | + array( | |
| 86 | + 'hide_default' => $this->options['hide_default'], | |
| 87 | + 'fields' => 'slug', | |
| 88 | + ) | |
| 89 | + ); | |
| 94 | 90 | |
| 95 | - foreach ( $this->model->get_languages_list() as $language ) { | |
| 96 | - if ( ! $this->options['hide_default'] || $this->options['default_lang'] != $language->slug ) { | |
| 97 | - $languages[] = $language->slug; | |
| 98 | - } | |
| 99 | - } | |
| 100 | - | |
| 101 | 91 | if ( ! empty( $languages ) ) { |
| 102 | 92 | $root = ( false === strpos( $url, '://' ) ) ? $this->home_relative . $this->root : preg_replace( '#^https?://#', '://', $this->home . '/' . $this->root ); |
| 103 | 93 | |
| 104 | - $pattern = preg_quote( $root, '#' ); | |
| 105 | - $pattern = '#' . $pattern . ( $this->options['rewrite'] ? '' : 'language/' ) . '(' . implode( '|', $languages ) . ')(/|$)#'; | |
| 106 | - $url = preg_replace( $pattern, $root, $url ); | |
| 94 | + $pattern = preg_quote( $root, '@' ); | |
| 95 | + $pattern = '@' . $pattern . ( $this->options['rewrite'] ? '' : 'language/' ) . '(' . implode( '|', $languages ) . ')(([?#])|(/|$))@'; | |
| 96 | + $url = preg_replace( $pattern, $root . '$3', $url ); | |
| 107 | 97 | } |
| 108 | 98 | return $url; |
| 109 | 99 | } |
| 110 | 100 | |
| 111 | 101 | /** |
| 112 | - * Returns the language based on language code in url | |
| 113 | - * links_model interface | |
| 102 | + * Returns the language based on the language code in the url. | |
| 114 | 103 | * |
| 115 | 104 | * @since 1.2 |
| 116 | - * @since 2.0 add $url argument | |
| 105 | + * @since 2.0 Add the $url argument. | |
| 117 | 106 | * |
| 118 | - * @param string $url optional, defaults to current url | |
| 119 | - * @return string language slug | |
| 107 | + * @param string $url Optional, defaults to the current url. | |
| 108 | + * @return string The language slug. | |
| 120 | 109 | */ |
| 121 | 110 | public function get_language_from_url( $url = '' ) { |
| 122 | 111 | if ( empty( $url ) ) { |
| 123 | 112 | $url = pll_get_requested_url(); |
| @@ -122,74 +111,62 @@ | ||
| 122 | 111 | if ( empty( $url ) ) { |
| 123 | 112 | $url = pll_get_requested_url(); |
| 124 | 113 | } |
| 125 | 114 | |
| 126 | - $path = wp_parse_url( $url, PHP_URL_PATH ); | |
| 115 | + $path = (string) wp_parse_url( $url, PHP_URL_PATH ); | |
| 127 | 116 | $root = ( false === strpos( $url, '://' ) ) ? $this->home_relative . $this->root : $this->home . '/' . $this->root; |
| 128 | 117 | |
| 129 | - $pattern = wp_parse_url( $root . ( $this->options['rewrite'] ? '' : 'language/' ), PHP_URL_PATH ); | |
| 118 | + $pattern = (string) wp_parse_url( $root . ( $this->options['rewrite'] ? '' : 'language/' ), PHP_URL_PATH ); | |
| 130 | 119 | $pattern = preg_quote( $pattern, '#' ); |
| 131 | 120 | $pattern = '#^' . $pattern . '(' . implode( '|', $this->model->get_languages_list( array( 'fields' => 'slug' ) ) ) . ')(/|$)#'; |
| 132 | - return preg_match( $pattern, trailingslashit( $path ), $matches ) ? $matches[1] : ''; // $matches[1] is the slug of the requested language | |
| 121 | + return preg_match( $pattern, trailingslashit( $path ), $matches ) ? $matches[1] : ''; // $matches[1] is the slug of the requested language. | |
| 133 | 122 | } |
| 134 | 123 | |
| 135 | 124 | /** |
| 136 | 125 | * Returns the home url in a given language. |
| 137 | - * links_model interface. | |
| 138 | 126 | * |
| 139 | 127 | * @since 1.3.1 |
| 128 | + * @since 3.4 Accepts now a language slug. | |
| 140 | 129 | * |
| 141 | - * @param PLL_Language $lang PLL_Language object. | |
| 130 | + * @param PLL_Language|string $language Language object or slug. | |
| 142 | 131 | * @return string |
| 143 | 132 | */ |
| 144 | - public function home_url( $lang ) { | |
| 133 | + public function home_url( $language ) { | |
| 134 | + if ( $language instanceof PLL_Language ) { | |
| 135 | + $language = $language->slug; | |
| 136 | + } | |
| 137 | + | |
| 145 | 138 | $base = $this->options['rewrite'] ? '' : 'language/'; |
| 146 | - $slug = $this->options['default_lang'] == $lang->slug && $this->options['hide_default'] ? '' : '/' . $this->root . $base . $lang->slug; | |
| 139 | + $slug = $this->options['default_lang'] === $language && $this->options['hide_default'] ? '' : '/' . $this->root . $base . $language; | |
| 147 | 140 | return trailingslashit( $this->home . $slug ); |
| 148 | 141 | } |
| 149 | 142 | |
| 150 | 143 | /** |
| 151 | - * Optionally removes 'language' in permalinks so that we get http://www.myblog/en/ instead of http://www.myblog/language/en/ | |
| 144 | + * Prepares the rewrite rules filters. | |
| 152 | 145 | * |
| 153 | - * @since 1.2 | |
| 146 | + * @since 0.8.1 | |
| 147 | + * @since 3.5 Hooked to `pll_prepare_rewrite_rules` and remove `$pre` parameter. | |
| 154 | 148 | * |
| 155 | 149 | * @return void |
| 156 | 150 | */ |
| 157 | - public function add_permastruct() { | |
| 158 | - // Language information always in front of the uri ( 'with_front' => false ) | |
| 159 | - // The 3rd parameter structure has been modified in WP 3.4 | |
| 160 | - // Leads to error 404 for pages when there is no language created yet | |
| 161 | - if ( $this->model->get_languages_list() ) { | |
| 162 | - add_permastruct( 'language', $this->options['rewrite'] ? '%language%' : 'language/%language%', array( 'with_front' => false ) ); | |
| 151 | + public function prepare_rewrite_rules() { | |
| 152 | + /* | |
| 153 | + * Don't modify the rules if there is no languages created yet and make sure | |
| 154 | + * to add the filters only once and if all custom post types and taxonomies | |
| 155 | + * have been registered. | |
| 156 | + */ | |
| 157 | + if ( ! $this->model->has_languages() || ! did_action( 'wp_loaded' ) || ! self::$can_filter_rewrite_rules ) { | |
| 158 | + return; | |
| 163 | 159 | } |
| 164 | - } | |
| 165 | 160 | |
| 166 | - /** | |
| 167 | - * Prepares the rewrite rules filters. | |
| 168 | - * | |
| 169 | - * @since 0.8.1 | |
| 170 | - * | |
| 171 | - * @param mixed $pre Not used as the filter is used as an action. | |
| 172 | - * @return mixed | |
| 173 | - */ | |
| 174 | - public function prepare_rewrite_rules( $pre ) { | |
| 175 | - // Don't modify the rules if there is no languages created yet | |
| 176 | - // Make sure to add filter only once and if all custom post types and taxonomies have been registered | |
| 177 | - if ( $this->model->get_languages_list() && did_action( 'wp_loaded' ) && ! has_filter( 'language_rewrite_rules', '__return_empty_array' ) ) { | |
| 178 | - // Suppress the rules created by WordPress for our taxonomy | |
| 179 | - add_filter( 'language_rewrite_rules', '__return_empty_array' ); | |
| 180 | - | |
| 181 | - foreach ( $this->get_rewrite_rules_filters() as $type ) { | |
| 182 | - add_filter( $type . '_rewrite_rules', array( $this, 'rewrite_rules' ) ); | |
| 183 | - } | |
| 184 | - | |
| 185 | - add_filter( 'rewrite_rules_array', array( $this, 'rewrite_rules' ) ); // needed for post type archives | |
| 161 | + foreach ( $this->get_rewrite_rules_filters_with_callbacks() as $rule => $callback ) { | |
| 162 | + add_filter( $rule, $callback ); | |
| 186 | 163 | } |
| 187 | - return $pre; | |
| 188 | 164 | } |
| 189 | 165 | |
| 190 | 166 | /** |
| 191 | 167 | * The rewrite rules ! |
| 168 | + * | |
| 192 | 169 | * Always make sure that the default language is at the end in case the language information is hidden for default language. |
| 193 | 170 | * Thanks to brbrbr http://wordpress.org/support/topic/plugin-polylang-rewrite-rules-not-correct. |
| 194 | 171 | * |
| 195 | 172 | * @since 0.8.1 |
| @@ -211,25 +188,30 @@ | ||
| 211 | 188 | if ( ! empty( $languages ) ) { |
| 212 | 189 | $slug = $wp_rewrite->root . ( $this->options['rewrite'] ? '' : 'language/' ) . '(' . implode( '|', $languages ) . ')/'; |
| 213 | 190 | } |
| 214 | 191 | |
| 215 | - // For custom post type archives | |
| 192 | + // For custom post type archives. | |
| 216 | 193 | $cpts = array_intersect( $this->model->get_translated_post_types(), get_post_types( array( '_builtin' => false ) ) ); |
| 217 | 194 | $cpts = $cpts ? '#post_type=(' . implode( '|', $cpts ) . ')#' : ''; |
| 218 | 195 | |
| 219 | 196 | foreach ( $rules as $key => $rule ) { |
| 220 | - // Special case for translated post types and taxonomies to allow canonical redirection | |
| 197 | + if ( ! is_string( $rule ) || ! is_string( $key ) ) { | |
| 198 | + // Protection against a bug in Sendinblue for WooCommerce. See: https://wordpress.org/support/topic/bug-introduced-in-rewrite-rules/ | |
| 199 | + continue; | |
| 200 | + } | |
| 201 | + | |
| 202 | + // Special case for translated post types and taxonomies to allow canonical redirection. | |
| 221 | 203 | if ( $this->options['force_lang'] && in_array( $filter, array_merge( $this->model->get_translated_post_types(), $this->model->get_translated_taxonomies() ) ) ) { |
| 222 | 204 | |
| 223 | 205 | /** |
| 224 | - * Filters the rewrite rules to modify | |
| 206 | + * Filters the rewrite rules to modify. | |
| 225 | 207 | * |
| 226 | 208 | * @since 1.9.1 |
| 227 | 209 | * |
| 228 | - * @param bool $modify whether to modify or not the rule, defaults to true | |
| 229 | - * @param array $rule original rewrite rule | |
| 230 | - * @param string $filter current set of rules being modified | |
| 231 | - * @param string|bool $archive custom post post type archive name or false if it is not a cpt archive | |
| 210 | + * @param bool $modify Whether to modify or not the rule, defaults to true. | |
| 211 | + * @param array $rule Original rewrite rule. | |
| 212 | + * @param string $filter Current set of rules being modified. | |
| 213 | + * @param string|bool $archive Custom post post type archive name or false if it is not a cpt archive. | |
| 232 | 214 | */ |
| 233 | 215 | if ( isset( $slug ) && apply_filters( 'pll_modify_rewrite_rule', true, array( $key => $rule ), $filter, false ) ) { |
| 234 | 216 | $newrules[ $slug . str_replace( $wp_rewrite->root, '', ltrim( $key, '^' ) ) ] = str_replace( |
| 235 | 217 | array( '[8]', '[7]', '[6]', '[5]', '[4]', '[3]', '[2]', '[1]', '?' ), |
| @@ -240,9 +222,9 @@ | ||
| 240 | 222 | |
| 241 | 223 | $newrules[ $key ] = $rule; |
| 242 | 224 | } |
| 243 | 225 | |
| 244 | - // Rewrite rules filtered by language | |
| 226 | + // Rewrite rules filtered by language. | |
| 245 | 227 | elseif ( in_array( $filter, $this->always_rewrite ) || in_array( $filter, $this->model->get_filtered_taxonomies() ) || ( $cpts && preg_match( $cpts, $rule, $matches ) && ! strpos( $rule, 'name=' ) ) || ( 'rewrite_rules_array' != $filter && $this->options['force_lang'] ) ) { |
| 246 | 228 | |
| 247 | 229 | /** This filter is documented in include/links-directory.php */ |
| 248 | 230 | if ( apply_filters( 'pll_modify_rewrite_rule', true, array( $key => $rule ), $filter, empty( $matches[1] ) ? false : $matches[1] ) ) { |
| @@ -261,18 +243,53 @@ | ||
| 261 | 243 | $newrules[ $key ] = $rule; |
| 262 | 244 | } |
| 263 | 245 | } |
| 264 | 246 | |
| 265 | - // Unmodified rules | |
| 247 | + // Unmodified rules. | |
| 266 | 248 | else { |
| 267 | 249 | $newrules[ $key ] = $rule; |
| 268 | 250 | } |
| 269 | 251 | } |
| 270 | 252 | |
| 271 | - // The home rewrite rule | |
| 253 | + // The home rewrite rule. | |
| 272 | 254 | if ( 'root' == $filter && isset( $slug ) ) { |
| 273 | 255 | $newrules[ $slug . '?$' ] = $wp_rewrite->index . '?lang=$matches[1]'; |
| 274 | 256 | } |
| 275 | 257 | |
| 276 | 258 | return $newrules; |
| 259 | + } | |
| 260 | + | |
| 261 | + /** | |
| 262 | + * Removes hooks to filter rewrite rules, called when switching blog @see {PLL_Base::switch_blog()}. | |
| 263 | + * See `self::prepare_rewrite_rules()` for added hooks. | |
| 264 | + * | |
| 265 | + * @since 3.5 | |
| 266 | + * | |
| 267 | + * @return void | |
| 268 | + */ | |
| 269 | + public function remove_filters() { | |
| 270 | + parent::remove_filters(); | |
| 271 | + | |
| 272 | + foreach ( $this->get_rewrite_rules_filters_with_callbacks() as $rule => $callback ) { | |
| 273 | + remove_filter( $rule, $callback ); | |
| 274 | + } | |
| 275 | + } | |
| 276 | + | |
| 277 | + /** | |
| 278 | + * Returns *all* rewrite rules filters with their associated callbacks. | |
| 279 | + * | |
| 280 | + * @since 3.5 | |
| 281 | + * | |
| 282 | + * @return callable[] Array of hook names as key and callbacks as values. | |
| 283 | + */ | |
| 284 | + protected function get_rewrite_rules_filters_with_callbacks() { | |
| 285 | + $filters = array( | |
| 286 | + 'rewrite_rules_array' => array( $this, 'rewrite_rules' ), // Needed for post type archives. | |
| 287 | + ); | |
| 288 | + | |
| 289 | + foreach ( $this->get_rewrite_rules_filters() as $type ) { | |
| 290 | + $filters[ $type . '_rewrite_rules' ] = array( $this, 'rewrite_rules' ); | |
| 291 | + } | |
| 292 | + | |
| 293 | + return $filters; | |
| 277 | 294 | } |
| 278 | 295 | } |
