| @@ -110,8 +110,9 @@ | ||
| 110 | 110 | add_action('admin_notices', 'guaven_sqlcharts_onboarding_notice'); |
| 111 | 111 | |
| 112 | 112 | function guaven_sqlcharts_onboarding_notice_dismissed(){ |
| 113 | 113 | check_ajax_referer('notice_dismissed', 'nonce'); |
| 114 | + if (!current_user_can('manage_options')) return; | |
| 114 | 115 | |
| 115 | 116 | if(empty($_POST['type']))return; |
| 116 | 117 | switch ($_POST['type']){ |
| 117 | 118 | case 'onboarding_notice': |
| @@ -224,9 +225,31 @@ | ||
| 224 | 225 | 'item_updated' => __('Chart updated.','guaven_sqlcharts'), |
| 225 | 226 | ), |
| 226 | 227 | |
| 227 | 228 | 'public' => true, |
| 229 | + 'show_in_rest' => false, | |
| 228 | 230 | 'menu_icon' => 'dashicons-chart-pie', |
| 231 | + // Charts execute SQL, so every primitive capability of this post type maps to manage_options. | |
| 232 | + // Contributors/Authors cannot create, edit, publish or delete charts through any WordPress | |
| 233 | + // entry point (admin UI, XML-RPC, REST). Published charts stay viewable on the front end. | |
| 234 | + // Only primitive capabilities are remapped: mapping the meta capabilities edit_post/read_post/ | |
| 235 | + // delete_post to manage_options would make WordPress treat manage_options itself as a meta | |
| 236 | + // capability and break that check site-wide. | |
| 237 | + 'capability_type' => 'post', | |
| 238 | + 'map_meta_cap' => true, | |
| 239 | + 'capabilities' => array( | |
| 240 | + 'edit_posts' => 'manage_options', | |
| 241 | + 'edit_others_posts' => 'manage_options', | |
| 242 | + 'edit_published_posts' => 'manage_options', | |
| 243 | + 'edit_private_posts' => 'manage_options', | |
| 244 | + 'publish_posts' => 'manage_options', | |
| 245 | + 'read_private_posts' => 'manage_options', | |
| 246 | + 'delete_posts' => 'manage_options', | |
| 247 | + 'delete_private_posts' => 'manage_options', | |
| 248 | + 'delete_published_posts' => 'manage_options', | |
| 249 | + 'delete_others_posts' => 'manage_options', | |
| 250 | + 'create_posts' => 'manage_options', | |
| 251 | + ), | |
| 229 | 252 | 'supports' => array( |
| 230 | 253 | 'title', |
| 231 | 254 | 'postmeta' |
| 232 | 255 | ), |
| @@ -235,8 +258,14 @@ | ||
| 235 | 258 | |
| 236 | 259 | guaven_sqlcharts_load_defaults(); |
| 237 | 260 | } |
| 238 | 261 | |
| 262 | +// All guaven_sqlcharts_* meta keys are protected: they cannot be written through the Custom Fields box, | |
| 263 | +// XML-RPC or the REST API. The plugin's own save handler (update_post_meta) is not affected. | |
| 264 | +add_filter('is_protected_meta', function ($protected, $meta_key) { | |
| 265 | + return strpos((string) $meta_key, 'guaven_sqlcharts_') === 0 ? true : $protected; | |
| 266 | +}, 10, 2); | |
| 267 | + | |
| 239 | 268 | // "Add title" placeholder on the chart edit screen |
| 240 | 269 | add_filter('enter_title_here', function ($title, $post) { |
| 241 | 270 | if (!empty($post) and $post->post_type == 'gvn_schart') return __('Chart name', 'guaven_sqlcharts'); |
| 242 | 271 | return $title; |
| @@ -423,8 +452,11 @@ | ||
| 423 | 452 | { |
| 424 | 453 | if (!isset($_POST['meta_box_nonce_field']) or !wp_verify_nonce($_POST['meta_box_nonce_field'], 'meta_box_nonce_action')) { |
| 425 | 454 | return $post->ID; |
| 426 | 455 | } |
| 456 | + if ($post->post_type != 'gvn_schart' or !current_user_can('manage_options') or (defined('DOING_AUTOSAVE') and DOING_AUTOSAVE)) { | |
| 457 | + return $post->ID; | |
| 458 | + } | |
| 427 | 459 | $fields = array( |
| 428 | 460 | "guaven_sqlcharts_chartheight", |
| 429 | 461 | "guaven_sqlcharts_chartwidth", |
| 430 | 462 | "guaven_sqlcharts_graphtype", |
| @@ -480,13 +512,57 @@ | ||
| 480 | 512 | // save the custom fields |
| 481 | 513 | |
| 482 | 514 | |
| 483 | 515 | |
| 516 | +// Removes string literals (contents only), backtick identifiers and comments from SQL so keyword checks | |
| 517 | +// see the same code MySQL will execute. "/*!" and "/*+" comments are executable in MySQL and are kept. | |
| 518 | +function guaven_sqlcharts_strip_sql_literals($sql) | |
| 519 | +{ | |
| 520 | + $out = ''; $len = strlen($sql); $i = 0; | |
| 521 | + while ($i < $len) { | |
| 522 | + $c = $sql[$i]; | |
| 523 | + if ($c === "'" or $c === '"' or $c === '`') { | |
| 524 | + $out .= $c . $c; $i++; | |
| 525 | + while ($i < $len) { | |
| 526 | + if ($sql[$i] === '\\' and $c !== '`') { $i += 2; continue; } | |
| 527 | + if ($sql[$i] === $c) { if ($i + 1 < $len and $sql[$i + 1] === $c) { $i += 2; continue; } $i++; break; } | |
| 528 | + $i++; | |
| 529 | + } | |
| 530 | + continue; | |
| 531 | + } | |
| 532 | + if ($c === '#' or ($c === '-' and substr($sql, $i, 2) === '--' and ($i + 2 >= $len or ctype_space($sql[$i + 2])))) { | |
| 533 | + $nl = strpos($sql, "\n", $i); $i = ($nl === false) ? $len : $nl; continue; | |
| 534 | + } | |
| 535 | + if ($c === '/' and substr($sql, $i, 2) === '/*' and !in_array(substr($sql, $i + 2, 1), array('!', '+'), true)) { | |
| 536 | + $close = strpos($sql, '*/', $i + 2); $i = ($close === false) ? $len : $close + 2; $out .= ' '; continue; | |
| 537 | + } | |
| 538 | + $out .= $c; $i++; | |
| 539 | + } | |
| 540 | + return $out; | |
| 541 | +} | |
| 542 | + | |
| 543 | +// Returns 1 when the (fully substituted) SQL must not run, 0 when it is a read-only query. | |
| 544 | +// Called after every {tag}/{argN} replacement so user-supplied values are covered too. | |
| 484 | 545 | function gvn_chart_check_sql_query($sql) |
| 485 | 546 | { |
| 486 | - // case-insensitive, word-boundary check: only read-only SELECT queries are allowed | |
| 487 | - $pattern = '/\b(delete|update|insert|replace|drop|truncate|alter|create|rename|grant|revoke|call|handler|load\s+data|load_file|outfile|dumpfile)\b/i'; | |
| 488 | - return preg_match($pattern, $sql) ? 1 : 0; | |
| 547 | + // 1) data-changing statements: checked on the raw text, exactly as in every previous version | |
| 548 | + $write = '/\b(delete|update|insert|replace|drop|truncate|alter|create|rename|grant|revoke|call|handler|load\s+data|load_file|outfile|dumpfile)\b/i'; | |
| 549 | + if (preg_match($write, $sql)) return 1; | |
| 550 | + | |
| 551 | + // 2) further dangerous statements, matched outside string literals and comments so that ordinary | |
| 552 | + // values such as status = 'reset' keep working | |
| 553 | + $danger = '/\b(prepare|execute|deallocate|lock|unlock|kill|shutdown|flush|reset|purge|install|uninstall|import' | |
| 554 | + . '|set\s+(?:global|session|persist|persist_only|password|@@)|start\s+(?:replica|slave|group_replication)|stop\s+(?:replica|slave)|change\s+(?:master|replication))\b/i'; | |
| 555 | + if (preg_match($danger, guaven_sqlcharts_strip_sql_literals($sql))) return 1; | |
| 556 | + | |
| 557 | + // 3) every ";"-separated statement must be a read statement. The renderer sends each segment to the | |
| 558 | + // database on its own, so this stops a value from smuggling a second statement behind a ";". | |
| 559 | + foreach (explode(';', $sql) as $segment) { | |
| 560 | + $segment = ltrim(guaven_sqlcharts_strip_sql_literals($segment), " \t\r\n("); | |
| 561 | + if ($segment === '') continue; | |
| 562 | + if (!preg_match('/^(select|with|show|describe|desc|explain)\b/i', $segment)) return 1; | |
| 563 | + } | |
| 564 | + return 0; | |
| 489 | 565 | } |
| 490 | 566 | |
| 491 | 567 | function guaven_get_labels_and_values($id, $fvs) |
| 492 | 568 | { |
| @@ -580,9 +656,9 @@ | ||
| 580 | 656 | if (count($varfield_arr)<3) continue; |
| 581 | 657 | $varfield_arr=array_map("trim",$varfield_arr); |
| 582 | 658 | if (!empty($_GET[$varfield_arr[0]])) { |
| 583 | 659 | // User-supplied input: no () bypass allowed — sanitize strictly |
| 584 | - $varreplacement = sanitize_text_field(wp_unslash($_GET[$varfield_arr[0]])); | |
| 660 | + $varreplacement = str_replace(';', '', sanitize_text_field(wp_unslash($_GET[$varfield_arr[0]]))); | |
| 585 | 661 | if (is_numeric($varreplacement)) { |
| 586 | 662 | $varreplacement = $varreplacement + 0; |
| 587 | 663 | } else { |
| 588 | 664 | $varreplacement = '"' . esc_sql($varreplacement) . '"'; |
| @@ -676,8 +752,10 @@ | ||
| 676 | 752 | |
| 677 | 753 | function guaven_sqlcharts_local_shortcode($atts) { |
| 678 | 754 | if(empty($atts['id']))return 'ID is missing.'; |
| 679 | 755 | $atts['id']=intval($atts['id']); |
| 756 | + $post_g = get_post($atts['id']); | |
| 757 | + if (!$post_g or $post_g->post_type != 'gvn_schart') return 'Chart not found.'; | |
| 680 | 758 | $remote_host=get_post_meta($atts['id'], 'guaven_sqlcharts_dbhost', true); |
| 681 | 759 | if ($remote_host!=''){ |
| 682 | 760 | $remote_db=get_post_meta($atts['id'], 'guaven_sqlcharts_dbname', true); |
| 683 | 761 | $remote_login=get_post_meta($atts['id'], 'guaven_sqlcharts_dblogin', true); |
| @@ -694,34 +772,34 @@ | ||
| 694 | 772 | $GLOBALS["guaven_sqlcharts_atts"]=$atts; |
| 695 | 773 | |
| 696 | 774 | $sql = guaven_sqlcharts_get_code($atts['id']); |
| 697 | 775 | if(empty($sql))return 'SQL query is missing.'; |
| 698 | - $sql=gvn_chart_put_variables($sql,$atts['id']); | |
| 699 | 776 | |
| 700 | - | |
| 701 | - $sql=apply_filters('guaven_sqlcharts_rendered_sql',$sql,$atts); | |
| 702 | - | |
| 703 | - $blacklister_f = gvn_chart_check_sql_query($sql); | |
| 704 | - if ($blacklister_f == 1)return 'You given SQL code contains forbidden commands. Remember that you should only use SELECT queries'; | |
| 705 | - $tip_g = guaven_sqlcharts_normalize_type(get_post_meta($atts['id'], 'guaven_sqlcharts_graphtype', true)); | |
| 706 | - | |
| 707 | 777 | // {arg1}..{arg19} come from shortcode attributes: [gvn_schart_2 id="1" arg1="41"]. |
| 708 | 778 | // Substituted directly (not via wpdb::prepare) so the same tag may appear any number of times, |
| 709 | 779 | // e.g. in every query of a ";"-separated comparison chart. Numbers are inserted as-is, anything |
| 710 | 780 | // else is escaped and quoted; a tag already wrapped in quotes ('{arg1}') is not double-quoted. |
| 781 | + // ";" is removed from values because the finished SQL is split on ";" below. | |
| 711 | 782 | for($i=1;$i<20;$i++){ |
| 712 | 783 | $tag = '{arg'.$i.'}'; |
| 713 | 784 | if (strpos($sql, $tag) === false) continue; |
| 714 | 785 | $replacearg = !empty($atts['arg'.$i]) ? $atts['arg'.$i] : 0; |
| 715 | 786 | if (is_numeric($replacearg)) $replacearg = $replacearg + 0; |
| 716 | - else $replacearg = "'" . esc_sql($replacearg) . "'"; | |
| 787 | + else $replacearg = "'" . esc_sql(str_replace(';', '', sanitize_text_field((string) $replacearg))) . "'"; | |
| 717 | 788 | $sql = str_replace(array("'".$tag."'", '"'.$tag.'"', $tag), $replacearg, $sql); |
| 718 | 789 | } |
| 719 | 790 | |
| 791 | + $sql=gvn_chart_put_variables($sql,$atts['id']); | |
| 792 | + $sql=apply_filters('guaven_sqlcharts_rendered_sql',$sql,$atts); | |
| 793 | + | |
| 794 | + // command check on the final SQL, after every shortcode argument and filter value is in place | |
| 795 | + $blacklister_f = gvn_chart_check_sql_query($sql); | |
| 796 | + if ($blacklister_f == 1)return 'You given SQL code contains forbidden commands. Remember that you should only use SELECT queries'; | |
| 797 | + $tip_g = guaven_sqlcharts_normalize_type(get_post_meta($atts['id'], 'guaven_sqlcharts_graphtype', true)); | |
| 798 | + | |
| 720 | 799 | $sql_split = explode(';', $sql); |
| 721 | 800 | $labels_and_values = array(); |
| 722 | 801 | $labels = $values = $ylabel = $xlabel = array(); |
| 723 | - $post_g = get_post($atts['id']); | |
| 724 | 802 | |
| 725 | 803 | global $sqlcharts_inserted_script; |
| 726 | 804 | ob_start(); |
| 727 | 805 | for ($i = 0; $i < count($sql_split); $i++) { |
| @@ -801,14 +879,20 @@ | ||
| 801 | 879 | // distinct set of attributes gets its own cache entry. Append ?force_sql_cache_reload to the URL to bypass. |
| 802 | 880 | add_shortcode("gvn_schart_2_cached",function($atts){ |
| 803 | 881 | if(empty($atts["id"]))return; |
| 804 | 882 | $atts["id"]=intval($atts["id"]); |
| 805 | - $is_logged_in=is_user_logged_in()?'':'_guest'; | |
| 806 | 883 | $expire=!empty($atts["expire"])?intval($atts["expire"]):3600; |
| 807 | 884 | $inner_atts=$atts; |
| 808 | 885 | unset($inner_atts['expire']); |
| 809 | - $key='cached_sql_charts_'.$atts["id"].$is_logged_in; | |
| 810 | - if (count($inner_atts) > 1) $key .= '_'.md5(serialize($inner_atts)); | |
| 886 | + // One cache entry per user (charts may use {current_user_*} tags), per set of shortcode attributes | |
| 887 | + // and per value of every dynamic filter this chart reads from the URL. A visitor can therefore | |
| 888 | + // never be served, or pre-seed, a result computed for someone else or for other filter values. | |
| 889 | + $key_parts = array('atts' => $inner_atts, 'user' => is_user_logged_in() ? get_current_user_id() : 0, 'get' => array()); | |
| 890 | + foreach (explode('|', (string) get_post_meta($atts['id'], 'guaven_sqlcharts_variables', true)) as $vrow) { | |
| 891 | + $vname = trim(current(explode('~', $vrow))); | |
| 892 | + if ($vname !== '' and isset($_GET[$vname])) $key_parts['get'][$vname] = sanitize_text_field(wp_unslash($_GET[$vname])); | |
| 893 | + } | |
| 894 | + $key = 'cached_sql_charts_' . $atts["id"] . '_' . md5(serialize($key_parts)); | |
| 811 | 895 | $cached=get_transient($key); |
| 812 | 896 | if(!empty($cached) and !isset($_GET["force_sql_cache_reload"]) )return $cached; |
| 813 | 897 | $tobecached=guaven_sqlcharts_local_shortcode($inner_atts); |
| 814 | 898 | set_transient($key, $tobecached,$expire); |
| @@ -858,8 +942,17 @@ | ||
| 858 | 942 | if ($text === '' or ($which == 'y' and strpos($text, ';') !== false)) return ''; |
| 859 | 943 | return 'title: {display: true, text: ' . wp_json_encode($text) . '},'; |
| 860 | 944 | } |
| 861 | 945 | |
| 946 | +// "params" shortcode attribute: extra Chart.js dataset options, e.g. params="borderWidth: 3, borderDash: [5,5],". | |
| 947 | +// The text is placed inside the inline <script>, so only a conservative character set is accepted: | |
| 948 | +// no parentheses, semicolons, "=", "<", ">", "/", "\\", "+" or backticks, which rules out executable JavaScript. | |
| 949 | +function guaven_sqlcharts_dataset_params(){ | |
| 950 | + $params = isset($GLOBALS["guaven_sqlcharts_atts"]["params"]) ? (string) $GLOBALS["guaven_sqlcharts_atts"]["params"] : ''; | |
| 951 | + if ($params === '' or !preg_match('/^[A-Za-z0-9_\s,:.\'"#%\-\[\]{}]+$/', $params)) return ''; | |
| 952 | + return $params; | |
| 953 | +} | |
| 954 | + | |
| 862 | 955 | // dataset label as a safe JS string literal (labels saved before 3.0.1 may hold HTML entities) |
| 863 | 956 | function guaven_sqlcharts_js_label($label){ |
| 864 | 957 | return wp_json_encode(html_entity_decode((string) $label, ENT_QUOTES, 'UTF-8')); |
| 865 | 958 | } |
| @@ -920,12 +1013,9 @@ | ||
| 920 | 1013 | $points = $time_points !== false ? $time_points[$key_ak] : $values_new[$key_ak]; |
| 921 | 1014 | ?> |
| 922 | 1015 | { |
| 923 | 1016 | <?php |
| 924 | - if(!empty($GLOBALS["guaven_sqlcharts_atts"]["params"])){ | |
| 925 | - //passing chartJS params via the shortcode | |
| 926 | - echo wp_kses($GLOBALS["guaven_sqlcharts_atts"]["params"],[]); | |
| 927 | - } | |
| 1017 | + echo guaven_sqlcharts_dataset_params(); // "params" shortcode attribute (validated) | |
| 928 | 1018 | ?> |
| 929 | 1019 | label: <?php echo guaven_sqlcharts_js_label($ylabel[$key_ak]); ?>, |
| 930 | 1020 | backgroundColor: [ |
| 931 | 1021 | <?php |
| @@ -1009,12 +1099,9 @@ | ||
| 1009 | 1099 | else $fill = ($i == 0 and $dataset_count > 1) ? '"+1"' : '"origin"'; |
| 1010 | 1100 | ?> |
| 1011 | 1101 | { |
| 1012 | 1102 | <?php |
| 1013 | - if(!empty($GLOBALS["guaven_sqlcharts_atts"]["params"])){ | |
| 1014 | - //passing chartJS params via the shortcode | |
| 1015 | - echo wp_kses($GLOBALS["guaven_sqlcharts_atts"]["params"],[]); | |
| 1016 | - } | |
| 1103 | + echo guaven_sqlcharts_dataset_params(); // "params" shortcode attribute (validated) | |
| 1017 | 1104 | ?> |
| 1018 | 1105 | label: <?php echo guaven_sqlcharts_js_label($ylabel[$key_ak]); ?>, |
| 1019 | 1106 | fill: <?php echo wp_kses($fill,[]); |
| 1020 | 1107 | ?>, |
| @@ -1101,12 +1188,9 @@ | ||
| 1101 | 1188 | } |
| 1102 | 1189 | ?> |
| 1103 | 1190 | { |
| 1104 | 1191 | <?php |
| 1105 | - if(!empty($GLOBALS["guaven_sqlcharts_atts"]["params"])){ | |
| 1106 | - //passing chartJS params via the shortcode | |
| 1107 | - echo wp_kses($GLOBALS["guaven_sqlcharts_atts"]["params"],[]); | |
| 1108 | - } | |
| 1192 | + echo guaven_sqlcharts_dataset_params(); // "params" shortcode attribute (validated) | |
| 1109 | 1193 | ?> |
| 1110 | 1194 | label: <?php echo guaven_sqlcharts_js_label(isset($ylabel[$key_ak])?$ylabel[$key_ak]:''); ?>, |
| 1111 | 1195 | backgroundColor: <?php |
| 1112 | 1196 | echo wp_kses_post(guaven_sqlcharts_colorgenerator(1, 1, 0.2, guaven_sqlcharts_colors($i, $pid))); |
| @@ -1186,12 +1270,9 @@ | ||
| 1186 | 1270 | for ($i = 0; $i < count($values); $i++) { |
| 1187 | 1271 | ?> |
| 1188 | 1272 | { |
| 1189 | 1273 | <?php |
| 1190 | - if(!empty($GLOBALS["guaven_sqlcharts_atts"]["params"])){ | |
| 1191 | - //passing chartJS params via the shortcode | |
| 1192 | - echo wp_kses($GLOBALS["guaven_sqlcharts_atts"]["params"],[]); | |
| 1193 | - } | |
| 1274 | + echo guaven_sqlcharts_dataset_params(); // "params" shortcode attribute (validated) | |
| 1194 | 1275 | ?> |
| 1195 | 1276 | data: [<?php |
| 1196 | 1277 | echo wp_kses(implode(",", $values[$i]),[]); |
| 1197 | 1278 | ?>], |
