PluginProbe
ThinkRank AI SEO – AI SEO Plugin for WordPress: Schema, XML Sitemaps, Meta Tags, Search Console & Local SEO / 2.9.0
ThinkRank AI SEO – AI SEO Plugin for WordPress: Schema, XML Sitemaps, Meta Tags, Search Console & Local SEO v2.9.0
2.9.0 2.8.0 2.7.0 2.6.0 2.5.0 2.4.0 2.3.0 2.2.0 2.1.1 2.1.0 2.0.2 2.0.1 2.0.0 1.32.0 1.31.0 1.30.0 1.29.0 1.28.0 1.27.0 1.26.0 1.25.0 trunk 1.0.0 1.0.1 1.0.2 All 50 releases
← All changes | includes/seo/class-sitemap-generator.php +2763 -315 1.0.1 → 2.9.0 View file →
@@ -14,8 +14,20 @@
14 14 declare(strict_types=1);
15 15
16 16 namespace ThinkRank\SEO;
17 17
18 +use InvalidArgumentException;
19 +
20 +// Prevent direct access.
21 +if ( ! defined( 'ABSPATH' ) ) {
22 + exit;
23 +}
24 +
25 +// Filename derivation and web-root removal are shared with the deactivator and
26 +// with uninstall.php, which runs without an autoloader — so they live in a
27 +// plain function file both can require. See includes/cleanup-webroot.php.
28 +require_once __DIR__ . '/../cleanup-webroot.php';
29 +
18 30 /**
19 31 * Sitemap Generator Class
20 32 *
21 33 * Generates and manages XML sitemaps for search engine optimization.
@@ -26,13 +38,221 @@
26 38 */
27 39 class Sitemap_Generator extends Abstract_SEO_Manager {
28 40
29 41 /**
42 + * Memoised WooCommerce page IDs kept out of the sitemap. Null until resolved.
43 + *
44 + * @since 2.0.1
45 + * @var int[]|null
46 + */
47 + private ?array $woocommerce_excluded_page_ids = null;
48 +
49 + /**
50 + * Inclusion flag -> the child sitemap it controls.
51 + *
52 + * Shared by the child-list builder and by the "did the caller change what
53 + * the sitemap includes?" check in maybe_promote_to_index().
54 + *
55 + * @since 1.31.0
56 + * @var array<string, string>
57 + */
58 + private const INCLUSION_CHILD_TYPES = [
59 + 'include_posts' => 'posts',
60 + 'include_pages' => 'pages',
61 + 'include_categories' => 'categories',
62 + 'include_tags' => 'tags',
63 + ];
64 +
65 + /**
66 + * Child sitemap type -> the object that actually supplies its entries.
67 + *
68 + * A child normally carries its object's own slug, but the sitemap presets UI
69 + * writes a display name for the WooCommerce taxonomy child
70 + * ('product_categories', not 'product_cat'), so a saved child list can name a
71 + * type no post type or taxonomy answers to. Resolving through here lets those
72 + * children take the same generic path as every other custom taxonomy instead
73 + * of needing a case of their own (#690).
74 + *
75 + * @since 2.7.0
76 + * @var array<string, string>
77 + */
78 + private const CHILD_TYPE_ALIASES = [
79 + 'product_categories' => 'product_cat',
80 + ];
81 +
82 + /**
30 83 * Supported sitemap types
31 84 *
32 85 * @since 1.0.0
33 86 * @var array
34 87 */
88 + /**
89 + * How many post IDs to hydrate at a time while walking the sitemap set.
90 + *
91 + * @since 2.0.1
92 + * @var int
93 + */
94 + private const ID_WALK_CHUNK = 500;
95 +
96 + /**
97 + * How long a content or settings change is debounced before the sitemap is
98 + * rebuilt, in seconds. Coalesces bulk edits into a single regeneration.
99 + *
100 + * @since 2.2.1
101 + * @var int
102 + */
103 + private const REGENERATION_DEBOUNCE = 30;
104 +
105 + /**
106 + * How far past its due time the scheduled rebuild may sit before a request
107 + * takes it over, in seconds.
108 + *
109 + * WP-Cron is request-driven, so on a site running DISABLE_WP_CRON, blocking
110 + * loopback requests, or seeing very little traffic the event never fires and
111 + * the sitemap silently stops updating (#629). The grace keeps the fast path
112 + * (cron) in charge under normal conditions.
113 + *
114 + * @since 2.2.1
115 + * @var int
116 + */
117 + private const REGENERATION_TAKEOVER_GRACE = 120;
118 +
119 + /**
120 + * Longest backoff between takeover attempts after a failed rebuild, so a
121 + * persistently failing generation cannot run on every admin request.
122 + *
123 + * @since 2.2.1
124 + * @var int
125 + */
126 + private const REGENERATION_MAX_BACKOFF = 3600;
127 +
128 + /**
129 + * Option holding the rebuild that content/settings changes are still waiting
130 + * on: `since`, `source` ('content'|'settings'), `attempts`, `next_attempt`.
131 + * Absent means the served sitemap is up to date with what triggered it.
132 + *
133 + * @since 2.2.1
134 + * @var string
135 + */
136 + public const REGENERATION_PENDING_OPTION = 'thinkrank_sitemap_regeneration_pending';
137 +
138 + /**
139 + * Option holding the last automatic-regeneration failure (`message`,
140 + * `source`, `time`), so the failure is visible instead of swallowed.
141 + *
142 + * @since 2.2.1
143 + * @var string
144 + */
145 + public const REGENERATION_ERROR_OPTION = 'thinkrank_sitemap_regeneration_error';
146 +
147 + /**
148 + * Delivery modes accepted by the `delivery_mode` setting.
149 + *
150 + * Mirrors LLMs_Txt_Manager::DELIVERY_MODES, which solved the same problem
151 + * for llms.txt. `auto` is the only value a site should normally need.
152 + *
153 + * @since 2.9.0
154 + * @var string[]
155 + */
156 + public const DELIVERY_MODES = ['auto', 'static', 'dynamic'];
157 +
158 + /**
159 + * Cache group for documents rendered on the dynamic path.
160 + *
161 + * @since 2.9.0
162 + * @var string
163 + */
164 + private const DYNAMIC_CACHE_PREFIX = 'thinkrank_sitemap_doc_';
165 +
166 + /**
167 + * How long a dynamically rendered document is cached.
168 + *
169 + * Invalidated by content and settings changes through
170 + * {@see self::flush_dynamic_cache()}, so this is only the backstop for a
171 + * change nothing hooked.
172 + *
173 + * @since 2.9.0
174 + * @var int
175 + */
176 + private const DYNAMIC_CACHE_TTL = 12 * HOUR_IN_SECONDS;
177 +
178 + /**
179 + * How long the render lock is held before it is assumed abandoned.
180 + *
181 + * Long enough for a large site's full build, short enough that a request
182 + * killed mid-build does not lock the endpoint out for meaningfully long.
183 + *
184 + * @since 2.9.0
185 + * @var int
186 + */
187 + private const RENDER_LOCK_TTL = 60;
188 +
189 + /**
190 + * Cached stand-in for "this site does not publish that name".
191 + *
192 + * published_document_names() lists what the configuration *could* produce,
193 + * but a child whose type is excluded produces nothing. Without a negative
194 + * entry those names miss the cache forever, so every request for one
195 + * rebuilt the entire sitemap — the same cost the positive cache exists to
196 + * avoid, on a public endpoint (#754 review).
197 + *
198 + * @since 2.9.0
199 + * @var string
200 + */
201 + private const ABSENT_MARKER = "\0thinkrank-absent";
202 +
203 + /**
204 + * How many times, and how long, a losing request waits for the winner.
205 + *
206 + * Bounded at roughly a second in total: past that, building a second copy
207 + * costs less than making a crawler wait.
208 + *
209 + * @since 2.9.0
210 + * @var int
211 + */
212 + private const RENDER_LOCK_WAIT_ATTEMPTS = 4;
213 +
214 + /**
215 + * @since 2.9.0
216 + * @var int
217 + */
218 + private const RENDER_LOCK_WAIT_MICROSECONDS = 250000;
219 +
220 + /**
221 + * Where generated documents go instead of disk, when set.
222 + *
223 + * Every sitemap document this class produces — segments, the index, the
224 + * single flat file and local-sitemap.xml — is published through the one
225 + * writer, {@see self::save_sitemap_to_file()}. Swapping that writer for a
226 + * collector is therefore all it takes to render the same bytes without a
227 + * filesystem, which is what dynamic delivery needs (#752). Doing it here
228 + * rather than duplicating the build pipeline is deliberate: a second
229 + * pipeline would drift from this one, and the index in particular is
230 + * assembled from whatever the children actually produced.
231 + *
232 + * @since 2.9.0
233 + * @var callable|null
234 + */
235 + private $document_sink = null;
236 +
237 + /**
238 + * Transient guarding against two generations running at once. Shared with
239 + * Sitemap_Endpoint's manual generate route so an automatic rebuild and a
240 + * manual one cannot write the same files concurrently.
241 + *
242 + * @since 2.2.1
243 + * @var string
244 + */
245 + public const GENERATION_LOCK_TRANSIENT = 'thinkrank_sitemap_generation_lock';
246 +
247 + /**
248 + * How many term IDs to hydrate at a time while walking a taxonomy.
249 + *
250 + * @since 2.0.1
251 + * @var int
252 + */
253 + private const TERM_WALK_CHUNK = 1000;
254 +
35 255 private array $sitemap_types = [
36 256 'posts' => [
37 257 'name' => 'Posts',
38 258 'post_types' => ['post'],
@@ -62,17 +282,67 @@
62 282 /**
63 283 * Constructor
64 284 *
65 285 * @since 1.0.0
286 + *
287 + * @param bool $register_hooks Optional. Whether to register the auto-generation
288 + * hooks. Pass false for a read-only instance built
289 + * solely to query settings — the hooks are bound to
290 + * `$this`, so a second hook-registering instance
291 + * would run `handle_content_change()` twice per save.
66 292 */
67 - public function __construct() {
293 + public function __construct(bool $register_hooks = true) {
68 294 parent::__construct('sitemap');
69 295
70 296 // Initialize auto-generation hooks
71 - $this->init_auto_generation_hooks();
297 + if ($register_hooks) {
298 + $this->init_auto_generation_hooks();
299 + }
72 300 }
73 301
74 302 /**
303 + * Filter the args of a sitemap post query.
304 + *
305 + * Exists so integrations can widen what the sitemap sees — the multilingual
306 + * manager uses it to include every language, since these queries otherwise
307 + * run in whichever language happened to be active at generation time.
308 + *
309 + * @since 1.23.0
310 + *
311 + * @param array $args get_posts() arguments.
312 + * @return array Filtered arguments.
313 + */
314 + private function filter_query_args(array $args): array {
315 + /**
316 + * Filter the arguments of a sitemap post query.
317 + *
318 + * @since 1.23.0
319 + *
320 + * @param array $args get_posts() arguments.
321 + */
322 + return (array) apply_filters('thinkrank_sitemap_query_args', $args);
323 + }
324 +
325 + /**
326 + * Filter the args of a sitemap term query.
327 + *
328 + * @since 1.23.0
329 + *
330 + * @param array $args get_terms() arguments.
331 + * @return array Filtered arguments.
332 + */
333 + private function filter_term_query_args(array $args): array {
334 + /**
335 + * Filter the arguments of a sitemap term query.
336 + *
337 + * @since 1.23.0
338 + *
339 + * @param array $args get_terms() arguments.
340 + */
341 + return (array) apply_filters('thinkrank_sitemap_term_query_args', $args);
342 + }
343 +
344 + /**
75 345 * Initialize WordPress hooks for auto-generation
76 346 *
77 347 * @since 1.0.0
78 348 * @return void
@@ -88,10 +358,14 @@
88 358 add_action('created_term', [$this, 'handle_taxonomy_change'], 20, 3);
89 359 add_action('edited_term', [$this, 'handle_taxonomy_change'], 20, 3);
90 360 add_action('delete_term', [$this, 'handle_taxonomy_change'], 20, 3);
91 361
92 - // Debounced regeneration to prevent multiple rapid-fire generations
93 - add_action('thinkrank_regenerate_sitemap', [$this, 'auto_regenerate_sitemap']);
362 + // NOTE: the WP-Cron regeneration listeners (thinkrank_regenerate_sitemap
363 + // and thinkrank_regenerate_sitemap_settings) are registered at plugin
364 + // bootstrap (Plugin::register_sitemap_cron_listeners(), on plugins_loaded)
365 + // rather than here. A cron run never builds this class via the REST
366 + // endpoint (no rest_api_init), so registering them in the constructor
367 + // would leave the scheduled events with no listener at cron time.
94 368 }
95 369
96 370 /**
97 371 * Generate XML sitemap
@@ -103,15 +377,10 @@
103 377 */
104 378 public function generate_sitemap(array $options = []): string {
105 379 $settings = $this->get_settings('site');
106 380
107 - $xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
381 + $xml = $this->xml_prolog($settings, 'sitemap');
108 382
109 - // Add XSL stylesheet only if styling is enabled
110 - if (!empty($settings['enable_styling'])) {
111 - $xml .= '<?xml-stylesheet type="text/xsl" href="' . home_url('/wp-content/plugins/thinkrank/assets/sitemap.xsl') . '"?>' . "\n";
112 - }
113 -
114 383 // Add image namespace if images are enabled
115 384 if (!empty($settings['include_images'])) {
116 385 $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1">' . "\n";
117 386 } else {
@@ -117,15 +386,19 @@
117 386 } else {
118 387 $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
119 388 }
120 389
121 - // Add homepage
122 - $xml .= $this->generate_url_entry(home_url('/'), gmdate('c'), 1.0, 'daily');
390 + // Add homepage. Use the static front page's real modified time when set,
391 + // so lastmod reflects real changes rather than the generation time.
392 + $xml .= $this->generate_url_entry(home_url('/'), $this->get_homepage_lastmod(), 1.0, 'daily');
123 393
124 - // MEMORY-EFFICIENT: Generate posts using chunked processing
394 + // MEMORY-EFFICIENT: Generate posts using chunked processing.
395 + // Note: the single "general" sitemap includes every URL (no per-file cap);
396 + // per-file chunking applies to the segmented/index model where each type
397 + // gets its own paginated file (see generate_multiple_sitemaps).
125 398 $enabled_post_types = $this->get_enabled_post_types($settings);
126 399 if (!empty($enabled_post_types)) {
127 - $xml .= $this->generate_posts_chunked($enabled_post_types, $settings);
400 + $xml .= implode('', $this->collect_post_entries($enabled_post_types, $settings));
128 401 }
129 402
130 403 // OPTIMIZED: Get all enabled taxonomies and fetch in single query
131 404 $enabled_taxonomies = $this->get_enabled_taxonomies($settings);
@@ -219,8 +492,34 @@
219 492 ];
220 493 }
221 494
222 495 /**
496 + * Sitemap keys outside the defaults.
497 + *
498 + * @since 2.0.1
499 + *
500 + * @return string[]
501 + */
502 + protected function additional_setting_keys(): array {
503 + return ['selected_preset'];
504 + }
505 +
506 + /**
507 + * Inclusion flags are per post type and per taxonomy.
508 + *
509 + * A site registering a `product` post type stores `include_product`; an
510 + * enumerated list would go stale on the next registration, so the family
511 + * is matched instead.
512 + *
513 + * @since 2.0.1
514 + *
515 + * @return string[]
516 + */
517 + protected function dynamic_setting_key_patterns(): array {
518 + return ['/^include_[a-z0-9_]+$/', '/^exclude_[a-z0-9_]+$/'];
519 + }
520 +
521 + /**
223 522 * Get default settings for a context type (implements interface)
224 523 *
225 524 * @since 1.0.0
226 525 *
@@ -243,8 +542,15 @@
243 542 ]
244 543 ],
245 544 'use_sitemap_index' => false,
246 545
546 + // How the sitemap reaches crawlers. 'auto' keeps the historical
547 + // behaviour wherever the web root is writable, and only falls back
548 + // to serving the sitemap from PHP where writing a file is
549 + // impossible — previously a hard failure with nothing served
550 + // (#752).
551 + 'delivery_mode' => 'auto',
552 +
247 553 // General Settings
248 554 'links_per_sitemap' => 1000,
249 555 'include_images' => true,
250 556 'include_featured_images' => false,
@@ -266,8 +572,17 @@
266 572 // Advanced Options
267 573 'enable_styling' => true,
268 574 'custom_url_pattern' => 'sitemap-{type}.xml',
269 575
576 + // Stylesheet branding (#639). Both colours default to empty, not
577 + // to the stock hexes: empty means the stylesheet's own value
578 + // stands, so a site that never opens this screen renders exactly
579 + // as it did before the setting existed.
580 + 'styling_logo' => false,
581 + 'styling_logo_url' => '',
582 + 'styling_color_main' => '',
583 + 'styling_color_accent' => '',
584 +
270 585 // Generation tracking
271 586 'last_generated' => ''
272 587 ];
273 588 }
@@ -272,8 +587,49 @@
272 587 ];
273 588 }
274 589
275 590 /**
591 + * Normalize the stylesheet branding values on the way into the store.
592 + *
593 + * The generic sanitizer only runs `sanitize_text_field()` over a string,
594 + * which happily keeps "red" or "rebeccapurple" as a colour. Nothing
595 + * downstream can use those — {@see Sitemap_Stylesheet::render()} skips any
596 + * value it cannot read as a hex colour — so storing them would report a
597 + * successful save of a setting that changes nothing, and `get-sitemap-
598 + * settings` would hand an agent back a colour the sitemap does not use.
599 + * Reducing here instead keeps the store and the rendering in agreement.
600 + *
601 + * @since 2.7.0
602 + *
603 + * @param array $settings Settings to sanitize.
604 + * @param string $context_type Context the save is for.
605 + * @return array
606 + */
607 + protected function sanitize_settings(array $settings, string $context_type = 'site'): array {
608 + $sanitized = parent::sanitize_settings($settings, $context_type);
609 +
610 + foreach (['styling_color_main', 'styling_color_accent'] as $key) {
611 + if (array_key_exists($key, $sanitized)) {
612 + $sanitized[$key] = Sitemap_Stylesheet::hex($sanitized[$key]);
613 + }
614 + }
615 +
616 + if (array_key_exists('styling_logo_url', $sanitized)) {
617 + $sanitized['styling_logo_url'] = esc_url_raw((string) $sanitized['styling_logo_url']);
618 + }
619 +
620 + // A mode this build cannot act on has to be stored as the fallback
621 + // rather than kept verbatim, or get-sitemap-settings reports a delivery
622 + // mode the site does not actually apply.
623 + if (array_key_exists('delivery_mode', $sanitized)) {
624 + $mode = sanitize_key((string) $sanitized['delivery_mode']);
625 + $sanitized['delivery_mode'] = in_array($mode, self::DELIVERY_MODES, true) ? $mode : 'auto';
626 + }
627 +
628 + return $sanitized;
629 + }
630 +
631 + /**
276 632 * Get settings schema definition (implements interface)
277 633 *
278 634 * @since 1.0.0
279 635 *
@@ -287,8 +643,15 @@
287 643 'title' => 'Enable Sitemap',
288 644 'description' => 'Generate XML sitemap for search engines',
289 645 'default' => true
290 646 ],
647 + 'delivery_mode' => [
648 + 'type' => 'string',
649 + 'title' => 'Sitemap Delivery',
650 + 'description' => 'How the sitemap is served: auto picks static when the WordPress root is writable and dynamic when it is not, static writes files to the web root, dynamic serves the sitemap from WordPress with no files written',
651 + 'enum' => self::DELIVERY_MODES,
652 + 'default' => 'auto'
653 + ],
291 654 'include_posts' => [
292 655 'type' => 'boolean',
293 656 'title' => 'Include Posts',
294 657 'description' => 'Include blog posts in sitemap',
@@ -329,8 +692,32 @@
329 692 'type' => 'string',
330 693 'title' => 'Last Generated',
331 694 'description' => 'Timestamp of last sitemap generation',
332 695 'default' => ''
696 + ],
697 + 'styling_logo' => [
698 + 'type' => 'boolean',
699 + 'title' => 'Show Logo On Sitemap',
700 + 'description' => 'Show a logo above the sitemap heading',
701 + 'default' => false
702 + ],
703 + 'styling_logo_url' => [
704 + 'type' => 'string',
705 + 'title' => 'Sitemap Logo',
706 + 'description' => 'Logo image URL. Empty falls back to the site icon',
707 + 'default' => ''
708 + ],
709 + 'styling_color_main' => [
710 + 'type' => 'string',
711 + 'title' => 'Sitemap Main Color',
712 + 'description' => 'Hex color for the sitemap header, links and table head. Empty keeps the stock palette',
713 + 'default' => ''
714 + ],
715 + 'styling_color_accent' => [
716 + 'type' => 'string',
717 + 'title' => 'Sitemap Accent Color',
718 + 'description' => 'Hex color for the header gradient and link hovers. Empty keeps the stock palette',
719 + 'default' => ''
333 720 ]
334 721 ];
335 722 }
336 723
@@ -347,10 +734,19 @@
347 734 * @return string XML URL entry
348 735 */
349 736 private function generate_url_entry(string $url, string $lastmod, float $priority, string $changefreq, array $images = []): string {
350 737 $xml = " <url>\n";
351 - $xml .= " <loc>" . esc_url($url) . "</loc>\n";
352 - $xml .= " <lastmod>" . esc_html($lastmod) . "</lastmod>\n";
738 + // Every <loc> in every sitemap passes through here, which is why the
739 + // scheme preference is applied at this one point rather than at each
740 + // of the dozen collectors that build URLs (#638). An http sitemap on
741 + // an https site hands search engines the wrong address for the whole
742 + // site at once.
743 + $xml .= " <loc>" . esc_url(Url_Scheme::apply($url)) . "</loc>\n";
744 + // Omit <lastmod> when unknown (empty) — a fabricated timestamp is worse
745 + // than no timestamp, and an absent lastmod is valid per the spec.
746 + if (!empty($lastmod)) {
747 + $xml .= " <lastmod>" . esc_html($lastmod) . "</lastmod>\n";
748 + }
353 749 $xml .= " <priority>" . number_format($priority, 1) . "</priority>\n";
354 750 $xml .= " <changefreq>" . esc_html($changefreq) . "</changefreq>\n";
355 751
356 752 // Add image entries if provided
@@ -355,9 +751,9 @@
355 751
356 752 // Add image entries if provided
357 753 foreach ($images as $image) {
358 754 $xml .= " <image:image>\n";
359 - $xml .= " <image:loc>" . esc_url($image['url']) . "</image:loc>\n";
755 + $xml .= " <image:loc>" . esc_url(Url_Scheme::apply((string) $image['url'])) . "</image:loc>\n";
360 756
361 757 if (!empty($image['title'])) {
362 758 $xml .= " <image:title>" . esc_html($image['title']) . "</image:title>\n";
363 759 }
@@ -374,33 +770,62 @@
374 770 return $xml;
375 771 }
376 772
377 773 /**
378 - * Generate post entries for sitemap (MEMORY-EFFICIENT VERSION)
774 + * Collect every post <url> entry for the given post type(s) as an array of
775 + * XML strings, using memory-efficient chunked fetching.
379 776 *
380 - * @since 1.0.0
777 + * Unlike the old capped generator, this returns ALL matching entries — the
778 + * links-per-sitemap limit is applied later by paginating this array into
779 + * separate files (see generate_multiple_sitemaps), matching how Rank Math
780 + * splits large sitemaps instead of truncating them.
381 781 *
382 - * @param string $post_type Post type
383 - * @param array $settings Sitemap settings
384 - * @return string XML entries
782 + * @since 1.14.0
783 + *
784 + * @param array $post_types Array of post types to fetch
785 + * @param array $settings Sitemap settings
786 + * @return array<string> Individual <url>…</url> entry strings
385 787 */
386 - private function generate_post_entries(string $post_type, array $settings): string {
387 - // Use memory-efficient chunked processing for single post type
388 - return $this->generate_posts_chunked([$post_type], $settings);
788 + /**
789 + * lastmod for the homepage <url> entry: the static front page's real
790 + * modification time when one is set, otherwise the generation time.
791 + *
792 + * @return string ISO-8601 date.
793 + */
794 + private function get_homepage_lastmod(): string {
795 + if (get_option('show_on_front') === 'page') {
796 + $front_id = (int) get_option('page_on_front');
797 + if ($front_id) {
798 + $modified = get_post_field('post_modified_gmt', $front_id);
799 + if (!empty($modified) && $modified !== '0000-00-00 00:00:00') {
800 + return gmdate('c', strtotime($modified));
801 + }
802 + }
803 + }
804 + return gmdate('c');
389 805 }
390 806
807 + private function collect_post_entries(array $post_types, array $settings): array {
808 + // Materialize the streaming source for callers that need the full set
809 + // (e.g. the single un-paginated "general" sitemap). The paginated index
810 + // path streams collect_post_entries_iter() directly to bound memory.
811 + return iterator_to_array($this->collect_post_entries_iter($post_types, $settings), false);
812 + }
813 +
391 814 /**
392 - * Generate posts XML using memory-efficient chunked processing
815 + * Stream <url> entries for the given post types, yielding one at a time.
393 816 *
394 - * @since 1.0.0
817 + * Same chunked query, filtering, and ordering as before, but yields each
818 + * entry instead of accumulating the whole set — so the paginated index
819 + * generator never holds every URL of a large post type in memory at once.
395 820 *
396 - * @param array $post_types Array of post types to fetch
397 - * @param array $settings Sitemap settings
398 - * @return string XML entries for all posts
821 + * @param array $post_types Post types to include.
822 + * @param array $settings Sitemap settings.
823 + * @return \Generator<string> <url> entry strings.
399 824 */
400 - private function generate_posts_chunked(array $post_types, array $settings): string {
825 + private function collect_post_entries_iter(array $post_types, array $settings): \Generator {
401 826 if (empty($post_types)) {
402 - return '';
827 + return;
403 828 }
404 829
405 830 // Parse and validate exclude_posts setting
406 831 $exclude_ids = [];
@@ -411,66 +836,261 @@
411 836 // Continue with empty array on validation failure - error details available in exception
412 837 }
413 838 }
414 839
415 - // Use links_per_sitemap setting to limit posts per sitemap
416 - $links_per_sitemap = !empty($settings['links_per_sitemap']) ?
417 - intval($settings['links_per_sitemap']) : 1000;
840 + // The static front page is emitted once as the explicit homepage entry,
841 + // so exclude it here to avoid a duplicate <loc> (its permalink equals
842 + // home_url('/')).
843 + if (get_option('show_on_front') === 'page') {
844 + $front_id = (int) get_option('page_on_front');
845 + if ($front_id) {
846 + $exclude_ids[] = $front_id;
847 + }
848 + }
418 849
419 - // Ensure value is within reasonable bounds
420 - $links_per_sitemap = max(1, min(50000, $links_per_sitemap));
850 + // Resolve the ordered ID list in one indexed query, then hydrate in
851 + // chunks via post__in. This avoids large OFFSET windows (which MySQL
852 + // must scan-and-discard, making a full walk O(n^2)) while still loading
853 + // only one chunk of full post objects into memory at a time. The
854 + // original order is preserved (the id query and post__in hydration both
855 + // use it).
856 + $all_ids = get_posts($this->filter_query_args([
857 + 'post_type' => $post_types,
858 + 'post_status' => 'publish',
859 + 'numberposts' => -1,
860 + 'exclude' => $exclude_ids,
861 + 'orderby' => 'post_type post_date',
862 + 'order' => 'ASC DESC',
863 + 'fields' => 'ids',
864 + ]));
421 865
422 - $xml = '';
423 - $chunk_size = 500; // Process 500 posts at a time
424 - $offset = 0;
425 - $total_processed = 0;
866 + if (empty($all_ids)) {
867 + return;
868 + }
426 869
427 - do {
428 - // Fetch posts in chunks to prevent memory issues
429 - $posts = get_posts([
430 - 'post_type' => $post_types,
870 + // Walk the ID list with a moving window rather than array_chunk().
871 + // array_chunk() builds a second array holding every element again, so
872 + // peak memory was twice the ID list — on a 100k-post site that is ~16MB
873 + // where ~8MB is needed, and this walk is the one part of an otherwise
874 + // well-bounded routine with no ceiling (#402).
875 + $total = count($all_ids);
876 +
877 + for ($offset = 0; $offset < $total; $offset += self::ID_WALK_CHUNK) {
878 + $chunk = array_slice($all_ids, $offset, self::ID_WALK_CHUNK);
879 +
880 + $posts = get_posts($this->filter_query_args([
881 + 'post_type' => $post_types,
431 882 'post_status' => 'publish',
432 - 'numberposts' => $chunk_size,
433 - 'offset' => $offset,
434 - 'exclude' => $exclude_ids,
435 - 'orderby' => 'post_type post_date',
436 - 'order' => 'ASC DESC'
437 - ]);
883 + 'numberposts' => count($chunk),
884 + 'post__in' => $chunk,
885 + 'orderby' => 'post__in', // preserve the resolved order
886 + ]));
438 887
439 - // Process each post in the chunk
440 888 foreach ($posts as $post) {
441 - if ($total_processed >= $links_per_sitemap) {
442 - break 2; // Exit both loops when limit reached
443 - }
444 -
445 889 if ($this->should_include_in_sitemap($post, $settings)) {
446 - $url = get_permalink($post);
890 + /**
891 + * Filter a sitemap entry's permalink.
892 + *
893 + * The multilingual manager uses this to generate each
894 + * translation's URL in its OWN language: the sitemap query
895 + * deliberately runs with suppress_filters, and the cron
896 + * rebuild runs with no language context at all, so a bare
897 + * get_permalink() resolved every translation to the
898 + * default-language URL — N entries sharing one <loc> (#409).
899 + *
900 + * @since 2.0.1
901 + * @param string $url Permalink as WordPress resolved it.
902 + * @param \WP_Post $post Post the entry describes.
903 + */
904 + $url = apply_filters('thinkrank_sitemap_post_permalink', get_permalink($post), $post);
447 905 $lastmod = gmdate('c', strtotime($post->post_modified_gmt));
448 906 $priority = $this->calculate_intelligent_priority($post, $post->post_type);
449 907 $changefreq = $this->calculate_change_frequency($post, $post->post_type);
450 908 $images = $this->extract_post_images($post, $settings);
451 909
452 - $xml .= $this->generate_url_entry($url, $lastmod, $priority, $changefreq, $images);
453 - $total_processed++;
910 + yield $this->generate_url_entry($url, $lastmod, $priority, $changefreq, $images);
454 911 }
455 912 }
456 913
457 - $offset += $chunk_size;
914 + // Free the hydrated chunk before loading the next one.
915 + unset($posts);
916 + }
917 + }
458 918
459 - // Store count before freeing memory
460 - $posts_count = count($posts);
919 + /**
920 + * Resolve and bound the configured links-per-sitemap limit.
921 + *
922 + * @since 1.14.0
923 + *
924 + * @param array $settings Sitemap settings
925 + * @return int Links per sitemap file (1–50000)
926 + */
927 + private function get_links_per_sitemap(array $settings): int {
928 + $limit = !empty($settings['links_per_sitemap']) ? intval($settings['links_per_sitemap']) : 1000;
461 929
462 - // Free memory after each chunk
463 - unset($posts);
930 + return max(1, min(50000, $limit));
931 + }
464 932
465 - } while ($posts_count === $chunk_size && $total_processed < $links_per_sitemap);
933 + /**
934 + * Stream <url> entries for a taxonomy's terms, yielding one at a time and
935 + * fetching terms in bounded chunks (number/offset) — so the paginated index
936 + * generator never holds every term of a large taxonomy in memory at once.
937 + *
938 + * @param string $taxonomy Taxonomy name.
939 + * @param array $settings Sitemap settings.
940 + * @return \Generator<string> <url> entry strings.
941 + */
942 + private function collect_taxonomy_entries_iter(string $taxonomy, array $settings): \Generator {
943 + $exclude_term_ids = [];
944 + if (!empty($settings['exclude_terms'])) {
945 + try {
946 + $exclude_term_ids = $this->validate_exclude_terms($settings['exclude_terms']);
947 + } catch (InvalidArgumentException $e) {
948 + // Continue with an empty exclude list on validation failure.
949 + }
950 + }
466 951
952 + // product_cat may legitimately have empty terms (products added later);
953 + // every other taxonomy hides empties — matching fetch_taxonomies_optimized().
954 + $hide_empty = $taxonomy !== 'product_cat';
955 + $priority = $taxonomy === 'category' ? 0.6 : 0.4;
956 +
957 + // Resolve the ordered term IDs in one query, then hydrate in chunks via
958 + // include. Avoids large OFFSET windows (O(n^2) over a full walk) while
959 + // holding only one chunk of full term objects at a time.
960 + $all_ids = get_terms($this->filter_term_query_args([
961 + 'taxonomy' => $taxonomy,
962 + 'hide_empty' => $hide_empty,
963 + 'exclude' => $exclude_term_ids,
964 + 'orderby' => 'count',
965 + 'order' => 'DESC',
966 + 'fields' => 'ids',
967 + ]));
968 +
969 + if (is_wp_error($all_ids) || empty($all_ids)) {
970 + return;
971 + }
972 +
973 + // Same moving window as the post walk above, for the same reason.
974 + $total = count($all_ids);
975 +
976 + for ($offset = 0; $offset < $total; $offset += self::TERM_WALK_CHUNK) {
977 + $chunk = array_slice($all_ids, $offset, self::TERM_WALK_CHUNK);
978 +
979 + $terms = get_terms($this->filter_term_query_args([
980 + 'taxonomy' => $taxonomy,
981 + 'include' => $chunk,
982 + 'orderby' => 'include', // preserve the resolved order
983 + 'hide_empty' => false, // already filtered by the id query
984 + ]));
985 +
986 + if (is_wp_error($terms) || empty($terms)) {
987 + continue;
988 + }
989 +
990 + foreach ($terms as $term) {
991 + // A term the user marked noindex must not be advertised in the
992 + // sitemap: the robots tag now honours term meta, so listing it
993 + // here would have the sitemap contradict the page's own tag.
994 + if ($this->term_is_noindexed((int) $term->term_id)) {
995 + continue;
996 + }
997 +
998 + $url = get_term_link($term);
999 + if (!is_wp_error($url)) {
1000 + // Omit lastmod for terms — the generation time is not a real
1001 + // modification time and would mislabel every term as just-changed.
1002 + yield $this->generate_url_entry($url, '', $priority, 'weekly');
1003 + }
1004 + }
1005 +
1006 + unset($terms);
1007 + }
1008 + }
1009 +
1010 + /**
1011 + * The XML declaration, ownership marker and optional stylesheet every
1012 + * sitemap document opens with.
1013 + *
1014 + * The marker is written unconditionally, and that is the point: removal on
1015 + * deactivate and uninstall deletes a web-root sitemap only when the file
1016 + * says it is ours, and our filenames are the canonical ones another SEO
1017 + * plugin writes too (#515). Tying the proof to `enable_styling` — the one
1018 + * marker older versions left — would mean a site with styling off either
1019 + * kept a shadowing file behind (#510) or had a competitor's deleted.
1020 + *
1021 + * @since 2.1.1
1022 + *
1023 + * The stylesheet URL is served by {@see Sitemap_Stylesheet}, not read off
1024 + * disk by the web server, because a static file cannot carry the site's own
1025 + * logo and colours (#639). It is a fixed URL: the palette is applied per
1026 + * request, so changing a brand colour needs no regeneration and shows up on
1027 + * sitemaps published long before.
1028 + *
1029 + * @param array $settings Sitemap settings (read for `enable_styling`).
1030 + * @param string $variant Stylesheet variant, `sitemap` or `index`.
1031 + * @return string Prolog lines, newline-terminated.
1032 + */
1033 + private function xml_prolog(array $settings, string $variant): string {
1034 + $xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
1035 + $xml .= THINKRANK_SITEMAP_MARKER . "\n";
1036 +
1037 + // The stylesheet is presentation only, so it stays opt-in.
1038 + if (!empty($settings['enable_styling'])) {
1039 + $xml .= '<?xml-stylesheet type="text/xsl" href="' . esc_url(Sitemap_Stylesheet::url($variant)) . '"?>' . "\n";
1040 + }
1041 +
467 1042 return $xml;
468 1043 }
469 1044
1045 + /**
1046 + * Wrap a set of <url> entry strings in a complete <urlset> document.
1047 + *
1048 + * @since 1.14.0
1049 + *
1050 + * @param array<string> $entries Entry strings
1051 + * @param array $settings Sitemap settings
1052 + * @param bool $with_image_ns Include the image sitemap namespace
1053 + * @return string Full sitemap XML
1054 + */
1055 + private function wrap_urlset(array $entries, array $settings, bool $with_image_ns): string {
1056 + $xml = $this->xml_prolog($settings, 'sitemap');
470 1057
1058 + if ($with_image_ns && !empty($settings['include_images'])) {
1059 + $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1">' . "\n";
1060 + } else {
1061 + $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
1062 + }
471 1063
1064 + $xml .= implode('', $entries);
1065 + $xml .= '</urlset>';
1066 +
1067 + return $xml;
1068 + }
1069 +
472 1070 /**
1071 + * Derive the filename/URL for a given pagination page.
1072 + *
1073 + * Page 1 keeps the base URL (e.g. /sitemap-posts.xml); pages 2+ insert the
1074 + * page number before the extension (e.g. /sitemap-posts-2.xml).
1075 + *
1076 + * @since 1.14.0
1077 + *
1078 + * @param string $url Base sitemap URL
1079 + * @param int $page 1-based page number
1080 + * @return string Paginated URL
1081 + */
1082 + private function paginate_url(string $url, int $page): string {
1083 + if ($page <= 1) {
1084 + return $url;
1085 + }
1086 +
1087 + return (string) preg_replace('/\.xml$/i', '-' . $page . '.xml', $url);
1088 + }
1089 +
1090 +
1091 +
1092 + /**
473 1093 * Extract images from post for sitemap
474 1094 *
475 1095 * @since 1.0.0
476 1096 *
@@ -501,9 +1121,9 @@
501 1121 // Remove duplicates based on URL
502 1122 $unique_images = [];
503 1123 $seen_urls = [];
504 1124 foreach ($images as $image) {
505 - if (!in_array($image['url'], $seen_urls)) {
1125 + if (!in_array($image['url'], $seen_urls, true)) {
506 1126 $unique_images[] = $image;
507 1127 $seen_urls[] = $image['url'];
508 1128 }
509 1129 }
@@ -587,28 +1207,8 @@
587 1207 return $images;
588 1208 }
589 1209
590 1210 /**
591 - * Generate taxonomy entries for sitemap (OPTIMIZED VERSION)
592 - *
593 - * @since 1.0.0
594 - *
595 - * @param string $taxonomy Taxonomy name
596 - * @param array $settings Sitemap settings
597 - * @return string XML entries
598 - */
599 - private function generate_taxonomy_entries(string $taxonomy, array $settings): string {
600 - // Use optimized batch fetching for single taxonomy
601 - $taxonomy_data = $this->fetch_taxonomies_optimized([$taxonomy], $settings);
602 -
603 - if (empty($taxonomy_data[$taxonomy])) {
604 - return '';
605 - }
606 -
607 - return $this->process_taxonomies_to_xml($taxonomy_data[$taxonomy], $taxonomy, $settings);
608 - }
609 -
610 - /**
611 1211 * Get enabled taxonomies based on settings
612 1212 *
613 1213 * @since 1.0.0
614 1214 * @param array $settings Sitemap settings
@@ -632,9 +1232,16 @@
632 1232 '_builtin' => false
633 1233 ], 'names');
634 1234
635 1235 foreach ($custom_taxonomies as $taxonomy) {
636 - if ($this->should_include_taxonomy($taxonomy)) {
1236 + if (!$this->should_include_taxonomy($taxonomy)) {
1237 + continue;
1238 + }
1239 +
1240 + // Same as the post-type walk above: an explicit per-taxonomy flag
1241 + // now decides, and an unset flag keeps the previous "included"
1242 + // behaviour (#660).
1243 + if (\ThinkRank\SEO\Content_Type_Settings::is_included_in_sitemap('taxonomy', $taxonomy, $settings)) {
637 1244 $taxonomies[] = $taxonomy;
638 1245 }
639 1246 }
640 1247
@@ -677,20 +1284,28 @@
677 1284 }
678 1285 }
679 1286
680 1287 // OPTIMIZED: Single query for multiple taxonomies
681 - $all_terms = get_terms([
1288 + $all_terms = get_terms($this->filter_term_query_args([
682 1289 'taxonomy' => $taxonomies, // ✅ Multiple taxonomies in single query
683 1290 'hide_empty' => $hide_empty,
684 1291 'exclude' => $exclude_term_ids,
685 1292 'orderby' => 'taxonomy count',
686 1293 'order' => 'ASC DESC' // Order by taxonomy ASC, then count DESC
687 - ]);
1294 + ]));
688 1295
689 1296 if (is_wp_error($all_terms)) {
690 1297 return [];
691 1298 }
692 1299
1300 + // Drop terms the user marked noindex. This path feeds the single general
1301 + // sitemap while collect_taxonomy_entries_iter() feeds the segmented ones,
1302 + // so both need the filter or the two disagree about the same term.
1303 + $all_terms = array_values(array_filter(
1304 + $all_terms,
1305 + fn($term) => !$this->term_is_noindexed((int) $term->term_id)
1306 + ));
1307 +
693 1308 // Group terms by taxonomy
694 1309 return $this->group_terms_by_taxonomy($all_terms);
695 1310 }
696 1311
@@ -733,9 +1348,11 @@
733 1348
734 1349 foreach ($terms as $term) {
735 1350 $url = get_term_link($term);
736 1351 if (!is_wp_error($url)) {
737 - $lastmod = gmdate('c');
1352 + // Omit lastmod for terms (generation time is not a real
1353 + // modification time).
1354 + $lastmod = '';
738 1355 $priority = $taxonomy === 'category' ? 0.6 : 0.4;
739 1356 $changefreq = 'weekly';
740 1357
741 1358 $xml .= $this->generate_url_entry($url, $lastmod, $priority, $changefreq);
@@ -778,12 +1395,12 @@
778 1395
779 1396 // Special page types get higher priority
780 1397 if ($post_type === 'page') {
781 1398 $page_template = get_page_template_slug($post->ID);
782 - if (in_array($page_template, ['page-home.php', 'front-page.php']) ||
783 - $post->ID == get_option('page_on_front')) {
1399 + if (in_array($page_template, ['page-home.php', 'front-page.php'], true) ||
1400 + (int) $post->ID === (int) get_option('page_on_front')) {
784 1401 $base_priority = 1.0; // Homepage gets maximum priority
785 - } elseif (in_array($page_template, ['page-contact.php', 'page-about.php'])) {
1402 + } elseif (in_array($page_template, ['page-contact.php', 'page-about.php'], true)) {
786 1403 $adjustments += 0.05; // Important pages boost
787 1404 }
788 1405 }
789 1406
@@ -805,11 +1422,11 @@
805 1422 private function calculate_change_frequency(\WP_Post $post, string $post_type): string {
806 1423 // Pages typically change less frequently
807 1424 if ($post_type === 'page') {
808 1425 $page_template = get_page_template_slug($post->ID);
809 - if ($post->ID == get_option('page_on_front')) {
1426 + if ((int) $post->ID === (int) get_option('page_on_front')) {
810 1427 return 'daily'; // Homepage changes frequently
811 - } elseif (in_array($page_template, ['page-contact.php', 'page-about.php'])) {
1428 + } elseif (in_array($page_template, ['page-contact.php', 'page-about.php'], true)) {
812 1429 return 'monthly'; // Static pages change monthly
813 1430 }
814 1431 return 'yearly'; // Other pages change rarely
815 1432 }
@@ -837,8 +1454,17 @@
837 1454 * @param array $settings Sitemap settings
838 1455 * @return bool Whether to include in sitemap
839 1456 */
840 1457 private function should_include_in_sitemap(\WP_Post $post, array $settings): bool {
1458 + // The WooCommerce cart, checkout and account pages are transactional,
1459 + // never indexable, and generate_default_robots_rules() already emits a
1460 + // Disallow for each of them. Listing them here submitted URLs our own
1461 + // robots.txt blocks, which Search Console reports as "Submitted URL
1462 + // blocked by robots.txt". Yoast and Rank Math exclude the same three.
1463 + if (in_array($post->ID, $this->woocommerce_excluded_page_ids(), true)) {
1464 + return false;
1465 + }
1466 +
841 1467 // Respect user setting for password protected content
842 1468 if (!empty($post->post_password) && !empty($settings['exclude_password_protected'])) {
843 1469 return false;
844 1470 }
@@ -847,46 +1473,93 @@
847 1473 if ($post->post_status === 'private' && !empty($settings['exclude_private_posts'])) {
848 1474 return false;
849 1475 }
850 1476
851 - // Skip very short content (likely test/placeholder)
852 - $content_length = strlen(wp_strip_all_tags($post->post_content));
853 - if ($content_length < 100) {
1477 + // Only published (and, per setting, private) content belongs in the
1478 + // sitemap. Content-quality heuristics (length, "demo"/"test"/"sample"
1479 + // in the title, "lorem ipsum" text) were intentionally removed: an XML
1480 + // sitemap should list every indexable published URL. Filtering by
1481 + // description length silently dropped legitimate WooCommerce products
1482 + // with short descriptions, and the substring title match excluded real
1483 + // pages such as "Demo" or "Product Samples". Indexability is governed
1484 + // by noindex directives below, not by heuristics.
1485 + if (!in_array($post->post_status, ['publish', 'private'], true)) {
854 1486 return false;
855 1487 }
856 1488
857 - // Skip posts with test/demo indicators in title (refined filtering)
858 - $title_indicators = ['test', 'demo', 'sample', 'placeholder'];
859 - $title_lower = strtolower($post->post_title);
1489 + // Check if post overrides robots and sets noindex.
1490 + if ((bool) get_post_meta($post->ID, '_thinkrank_robots_meta_enabled', true)) {
1491 + $raw = get_post_meta($post->ID, '_thinkrank_robots_meta', true);
1492 + if (is_string($raw) && $raw !== '') {
1493 + $robots = json_decode($raw, true);
1494 + if (is_array($robots) && !empty($robots['noindex'])) {
1495 + return false;
1496 + }
1497 + }
1498 + }
860 1499
861 - foreach ($title_indicators as $indicator) {
862 - if (strpos($title_lower, $indicator) !== false) {
863 - return false;
864 - }
1500 + return true;
1501 + }
1502 +
1503 + /**
1504 + * WooCommerce pages that must never reach the sitemap.
1505 + *
1506 + * Resolved through wc_get_page_id() so a store that moved or renamed its
1507 + * cart/checkout/account pages is still matched. Returns an empty list when
1508 + * WooCommerce is not active. Memoised — should_include_in_sitemap() runs
1509 + * once per post.
1510 + *
1511 + * @since 2.0.1
1512 + *
1513 + * @return int[] Page IDs to exclude.
1514 + */
1515 + private function woocommerce_excluded_page_ids(): array {
1516 + if ($this->woocommerce_excluded_page_ids !== null) {
1517 + return $this->woocommerce_excluded_page_ids;
865 1518 }
866 1519
867 - // Skip content with obvious placeholder text
868 - $content_indicators = ['lorem ipsum'];
869 - $content_lower = strtolower($post->post_content);
1520 + $ids = [];
870 1521
871 - foreach ($content_indicators as $indicator) {
872 - if (strpos($content_lower, $indicator) !== false) {
873 - return false;
1522 + if (function_exists('wc_get_page_id')) {
1523 + foreach (['cart', 'checkout', 'myaccount'] as $page) {
1524 + $id = (int) wc_get_page_id($page);
1525 + // wc_get_page_id() returns -1 when the page is not configured.
1526 + if ($id > 0) {
1527 + $ids[] = $id;
1528 + }
874 1529 }
875 1530 }
876 1531
877 - // Skip drafts (but allow private posts if user setting permits)
878 - if (!in_array($post->post_status, ['publish', 'private'])) {
1532 + $this->woocommerce_excluded_page_ids = $ids;
1533 +
1534 + return $ids;
1535 + }
1536 +
1537 + /**
1538 + * Whether a term carries an explicit noindex override.
1539 + *
1540 + * Mirrors the post-side check in should_include_post(); terms store the same
1541 + * `_thinkrank_robots_meta_enabled` / `_thinkrank_robots_meta` keys, written
1542 + * by the update-term-seo ability and by the SEO importer.
1543 + *
1544 + * @since 1.31.0
1545 + *
1546 + * @param int $term_id Term to test.
1547 + * @return bool True when the term is marked noindex.
1548 + */
1549 + private function term_is_noindexed(int $term_id): bool {
1550 + if (!(bool) get_term_meta($term_id, '_thinkrank_robots_meta_enabled', true)) {
879 1551 return false;
880 1552 }
881 1553
882 - // Check if post is set to noindex via meta
883 - $noindex = get_post_meta($post->ID, '_thinkrank_noindex', true);
884 - if ($noindex === '1' || $noindex === 'true') {
1554 + $raw = get_term_meta($term_id, '_thinkrank_robots_meta', true);
1555 + if (!is_string($raw) || $raw === '') {
885 1556 return false;
886 1557 }
887 1558
888 - return true;
1559 + $robots = json_decode($raw, true);
1560 +
1561 + return is_array($robots) && !empty($robots['noindex']);
889 1562 }
890 1563
891 1564 /**
892 1565 * Count total URLs in sitemap
@@ -895,9 +1568,9 @@
895 1568 *
896 1569 * @param array $settings Sitemap settings
897 1570 * @return int Total URL count
898 1571 */
899 - private function count_sitemap_urls(array $settings): int {
1572 + public function count_sitemap_urls(array $settings): int {
900 1573 $count = 1; // Homepage
901 1574
902 1575 if (!empty($settings['include_posts'])) {
903 1576 $count += wp_count_posts('post')->publish;
@@ -1052,9 +1725,15 @@
1052 1725 if (!empty($settings['include_pages'])) {
1053 1726 $post_types[] = 'page';
1054 1727 }
1055 1728
1056 - // Auto-detect public custom post types that should be included
1729 + // Auto-detect public custom post types that should be included.
1730 + //
1731 + // A custom type's `include_<slug>` / `exclude_<slug>` flag is honoured
1732 + // here (#660). It was previously stored — additional_setting_keys()
1733 + // has always let those keys through — but never read, so a CPT was in
1734 + // the sitemap whatever the setting said. Unset still means included, so
1735 + // a site that never touched the flag is unaffected.
1057 1736 $custom_post_types = get_post_types([
1058 1737 'public' => true,
1059 1738 '_builtin' => false
1060 1739 ], 'names');
@@ -1059,9 +1738,13 @@
1059 1738 '_builtin' => false
1060 1739 ], 'names');
1061 1740
1062 1741 foreach ($custom_post_types as $post_type) {
1063 - if ($this->should_include_post_type($post_type)) {
1742 + if (!$this->should_include_post_type($post_type)) {
1743 + continue;
1744 + }
1745 +
1746 + if (\ThinkRank\SEO\Content_Type_Settings::is_included_in_sitemap('post_type', $post_type, $settings)) {
1064 1747 $post_types[] = $post_type;
1065 1748 }
1066 1749 }
1067 1750
@@ -1075,11 +1758,18 @@
1075 1758 * @param string $post_type Post type
1076 1759 * @return bool True if post type should trigger regeneration
1077 1760 */
1078 1761 private function should_include_post_type(string $post_type): bool {
1079 - // Include all public post types (presets control which sitemaps are created)
1080 - $post_type_obj = get_post_type_object($post_type);
1081 - return $post_type_obj && $post_type_obj->public;
1762 + // Match Rank Math: only publicly viewable post types belong in the
1763 + // sitemap (public && publicly_queryable). Additionally skip post types
1764 + // that opt out of front-end search (exclude_from_search => true) — e.g.
1765 + // Templately's internal `templately_library` store — which are template
1766 + // records, not standalone indexable URLs. BetterDocs `docs` and
1767 + // WooCommerce `product` register exclude_from_search => false, so they
1768 + // remain included.
1769 + // The predicate lives in Content_Type_Settings so the matrix can ask
1770 + // the same question before offering a switch for this post type.
1771 + return \ThinkRank\SEO\Content_Type_Settings::sitemap_accepts_post_type($post_type);
1082 1772 }
1083 1773
1084 1774 /**
1085 1775 * Check if taxonomy should trigger regeneration
@@ -1088,11 +1778,13 @@
1088 1778 * @param string $taxonomy Taxonomy slug
1089 1779 * @return bool True if taxonomy should trigger regeneration
1090 1780 */
1091 1781 private function should_include_taxonomy(string $taxonomy): bool {
1092 - // Include all public taxonomies (presets control which sitemaps are created)
1093 - $taxonomy_obj = get_taxonomy($taxonomy);
1094 - return $taxonomy_obj && $taxonomy_obj->public;
1782 + // Public taxonomies only, and only the ones this generator can actually
1783 + // emit — the same predicate the content-type matrix asks before it
1784 + // offers a sitemap switch for one (presets still control which
1785 + // sitemaps are created).
1786 + return \ThinkRank\SEO\Content_Type_Settings::sitemap_accepts_taxonomy($taxonomy);
1095 1787 }
1096 1788
1097 1789 /**
1098 1790 * Schedule debounced sitemap regeneration
@@ -1100,16 +1792,499 @@
1100 1792 * @since 1.0.0
1101 1793 * @return void
1102 1794 */
1103 1795 private function schedule_debounced_regeneration(): void {
1104 - // Clear any existing scheduled regeneration
1105 - wp_clear_scheduled_hook('thinkrank_regenerate_sitemap');
1796 + $this->mark_regeneration_pending('content');
1797 + $this->debounce_event('thinkrank_regenerate_sitemap');
1798 + }
1106 1799
1107 - // Schedule regeneration in 30 seconds to debounce rapid changes
1108 - wp_schedule_single_event(time() + 30, 'thinkrank_regenerate_sitemap');
1800 + /**
1801 + * Schedule (or keep) the debounced single event behind a regeneration hook.
1802 + *
1803 + * An event that is already due is left alone. WP-Cron only runs when a
1804 + * request arrives, so on a site with DISABLE_WP_CRON, a blocked loopback or
1805 + * little traffic an overdue event can sit in the queue for a long time —
1806 + * clearing and re-scheduling it on every save pushed the rebuild
1807 + * permanently 30 seconds into the future and the sitemap never updated
1808 + * (#629). Debouncing only against an event that has not come due yet keeps
1809 + * the bulk-edit coalescing without starving the rebuild.
1810 + *
1811 + * @since 2.2.1
1812 + * @param string $hook Regeneration hook to debounce.
1813 + * @return void
1814 + */
1815 + private function debounce_event(string $hook): void {
1816 + $next = wp_next_scheduled($hook);
1817 +
1818 + if ($next !== false) {
1819 + if ($next <= time()) {
1820 + return;
1821 + }
1822 +
1823 + wp_clear_scheduled_hook($hook);
1824 + }
1825 +
1826 + wp_schedule_single_event(time() + self::REGENERATION_DEBOUNCE, $hook);
1109 1827 }
1110 1828
1111 1829 /**
1830 + * Record that a rebuild is outstanding, so an overdue one can be taken over
1831 + * by a later request and its staleness surfaced in the UI.
1832 + *
1833 + * `since` is the *oldest* outstanding change: it is what the takeover grace
1834 + * and the admin staleness warning are measured from, so successive edits
1835 + * must not push it forward. A settings change outranks a content change —
1836 + * it rebuilds regardless of the auto_generate toggle and handles a sitemap
1837 + * that has just been disabled — so once one is outstanding it stays the
1838 + * recorded source until the rebuild lands.
1839 + *
1840 + * @since 2.2.1
1841 + * @param string $source Either 'content' or 'settings'.
1842 + * @return void
1843 + */
1844 + private function mark_regeneration_pending(string $source): void {
1845 + // Whatever made the static files stale made the rendered ones stale
1846 + // too. Invalidating here rather than only on the rebuild keeps the two
1847 + // delivery modes reacting to exactly the same triggers, which is the
1848 + // only way a dynamic site stays as fresh as a static one (#752).
1849 + $this->flush_dynamic_cache();
1850 +
1851 + $pending = get_option(self::REGENERATION_PENDING_OPTION, []);
1852 + $pending = is_array($pending) ? $pending : [];
1853 +
1854 + $since = !empty($pending['since']) ? (int) $pending['since'] : time();
1855 + $current = isset($pending['source']) ? (string) $pending['source'] : '';
1856 + $source = ($current === 'settings' || $source === 'settings') ? 'settings' : 'content';
1857 +
1858 + update_option(
1859 + self::REGENERATION_PENDING_OPTION,
1860 + [
1861 + 'since' => $since,
1862 + 'source' => $source,
1863 + 'attempts' => !empty($pending['attempts']) ? (int) $pending['attempts'] : 0,
1864 + 'next_attempt' => !empty($pending['next_attempt'])
1865 + ? (int) $pending['next_attempt']
1866 + : time() + self::REGENERATION_TAKEOVER_GRACE,
1867 + // Bumped on every change so a rebuild can tell whether the edit
1868 + // it started for is still the newest one outstanding.
1869 + 'revision' => (!empty($pending['revision']) ? (int) $pending['revision'] : 0) + 1,
1870 + ],
1871 + true
1872 + );
1873 + }
1874 +
1875 + /**
1876 + * The revision of the outstanding rebuild, for
1877 + * {@see mark_regeneration_complete()} to compare against once it is done.
1878 + *
1879 + * @since 2.2.1
1880 + * @return int Current revision, 0 when nothing is outstanding.
1881 + */
1882 + private function current_regeneration_revision(): int {
1883 + $pending = get_option(self::REGENERATION_PENDING_OPTION, []);
1884 +
1885 + return (is_array($pending) && !empty($pending['revision'])) ? (int) $pending['revision'] : 0;
1886 + }
1887 +
1888 + /**
1889 + * Clear the outstanding-rebuild marker and any recorded failure.
1890 + *
1891 + * Public because a manual generation satisfies whatever the automatic path
1892 + * was still waiting to write.
1893 + *
1894 + * @since 2.2.1
1895 + * @return void
1896 + */
1897 + public function mark_regeneration_complete(?int $revision = null): void {
1898 + // The write succeeded, so whatever failure was on record is history.
1899 + if (get_option(self::REGENERATION_ERROR_OPTION, null) !== null) {
1900 + delete_option(self::REGENERATION_ERROR_OPTION);
1901 + }
1902 +
1903 + $pending = get_option(self::REGENERATION_PENDING_OPTION, null);
1904 +
1905 + if ($pending === null) {
1906 + return;
1907 + }
1908 +
1909 + // A change that landed while this rebuild was running is not covered by
1910 + // the files it just wrote, so it has to stay outstanding — otherwise, on
1911 + // a site where WP-Cron never fires, clearing the marker would strand it
1912 + // exactly the way #629 stranded everything.
1913 + if (
1914 + $revision !== null
1915 + && is_array($pending)
1916 + && (int) ($pending['revision'] ?? 0) !== $revision
1917 + ) {
1918 + return;
1919 + }
1920 +
1921 + delete_option(self::REGENERATION_PENDING_OPTION);
1922 + }
1923 +
1924 + /**
1925 + * Record a failed regeneration instead of discarding it.
1926 + *
1927 + * Keeps the pending marker in place so the rebuild is retried, but backs the
1928 + * next attempt off exponentially (capped) so a persistently failing
1929 + * generation cannot run on every admin request.
1930 + *
1931 + * @since 2.2.1
1932 + * @param string $message Failure detail.
1933 + * @param string $source Either 'content' or 'settings'.
1934 + * @return void
1935 + */
1936 + private function record_regeneration_failure(string $message, string $source): void {
1937 + $pending = get_option(self::REGENERATION_PENDING_OPTION, []);
1938 + $pending = is_array($pending) ? $pending : [];
1939 + $attempts = (!empty($pending['attempts']) ? (int) $pending['attempts'] : 0) + 1;
1940 +
1941 + $backoff = min(
1942 + self::REGENERATION_TAKEOVER_GRACE * (2 ** min($attempts, 10)),
1943 + self::REGENERATION_MAX_BACKOFF
1944 + );
1945 +
1946 + // Same precedence mark_regeneration_pending() enforces: a settings
1947 + // rebuild outranks a content one and must not be downgraded by a failed
1948 + // attempt. Overwriting it routed the retry back through the content
1949 + // path, where should_auto_generate() can be false and the completion
1950 + // marker then discards the settings rebuild entirely. Only the
1951 + // outstanding rebuild is upgraded — the recorded error keeps reporting
1952 + // whichever attempt actually failed.
1953 + $current = isset($pending['source']) ? (string) $pending['source'] : '';
1954 + $pending_source = ($current === 'settings' || $source === 'settings') ? 'settings' : 'content';
1955 +
1956 + update_option(
1957 + self::REGENERATION_PENDING_OPTION,
1958 + [
1959 + 'since' => !empty($pending['since']) ? (int) $pending['since'] : time(),
1960 + 'source' => $pending_source,
1961 + 'attempts' => $attempts,
1962 + 'next_attempt' => time() + $backoff,
1963 + 'revision' => !empty($pending['revision']) ? (int) $pending['revision'] : 0,
1964 + ],
1965 + true
1966 + );
1967 +
1968 + update_option(
1969 + self::REGENERATION_ERROR_OPTION,
1970 + [
1971 + 'message' => $message,
1972 + 'source' => $source,
1973 + 'attempts' => $attempts,
1974 + 'time' => time(),
1975 + ],
1976 + false
1977 + );
1978 +
1979 + if (defined('WP_DEBUG') && WP_DEBUG) {
1980 + // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log
1981 + error_log(sprintf('ThinkRank: sitemap %s regeneration failed — %s', $source, $message));
1982 + }
1983 + }
1984 +
1985 + /**
1986 + * Is a rebuild outstanding and past the point where WP-Cron should have run
1987 + * it?
1988 + *
1989 + * Deliberately cheap — one autoloaded option read — because it is consulted
1990 + * on every admin request to decide whether the takeover is needed.
1991 + *
1992 + * @since 2.2.1
1993 + * @return bool True when a request should rebuild the sitemap itself.
1994 + */
1995 + public static function has_overdue_regeneration(): bool {
1996 + $pending = get_option(self::REGENERATION_PENDING_OPTION, []);
1997 +
1998 + if (!is_array($pending) || empty($pending['since'])) {
1999 + return false;
2000 + }
2001 +
2002 + $due = !empty($pending['next_attempt'])
2003 + ? (int) $pending['next_attempt']
2004 + : (int) $pending['since'] + self::REGENERATION_TAKEOVER_GRACE;
2005 +
2006 + return time() >= $due;
2007 + }
2008 +
2009 + /**
2010 + * Rebuild the sitemap in-request when WP-Cron has not delivered.
2011 + *
2012 + * Hooked on `shutdown` for admin, REST and CLI requests only (see
2013 + * Plugin::register_sitemap_cron_listeners()), so the work happens after the
2014 + * response has been sent and never adds latency to a visitor page view.
2015 + *
2016 + * @since 2.2.1
2017 + * @return void
2018 + */
2019 + public function run_overdue_regeneration(): void {
2020 + if (!self::has_overdue_regeneration()) {
2021 + return;
2022 + }
2023 +
2024 + // Cron is running: it is about to do exactly this work.
2025 + if (wp_doing_cron()) {
2026 + return;
2027 + }
2028 +
2029 + $pending = get_option(self::REGENERATION_PENDING_OPTION, []);
2030 + $source = (is_array($pending) && isset($pending['source'])) ? (string) $pending['source'] : 'content';
2031 +
2032 + if ($source === 'settings') {
2033 + $this->regenerate_sitemap_from_settings();
2034 + return;
2035 + }
2036 +
2037 + $this->auto_regenerate_sitemap();
2038 + }
2039 +
2040 + /**
2041 + * Acquire the shared generation lock.
2042 + *
2043 + * @since 2.2.1
2044 + * @return bool True when this process may generate.
2045 + */
2046 + private function acquire_generation_lock(): bool {
2047 + if (get_transient(self::GENERATION_LOCK_TRANSIENT)) {
2048 + return false;
2049 + }
2050 +
2051 + set_transient(self::GENERATION_LOCK_TRANSIENT, time(), 5 * MINUTE_IN_SECONDS);
2052 +
2053 + return true;
2054 + }
2055 +
2056 + /**
2057 + * Release the shared generation lock.
2058 + *
2059 + * @since 2.2.1
2060 + * @return void
2061 + */
2062 + private function release_generation_lock(): void {
2063 + delete_transient(self::GENERATION_LOCK_TRANSIENT);
2064 + }
2065 +
2066 + /**
2067 + * Report how automatic regeneration is faring, for the admin UI.
2068 + *
2069 + * The feature used to fail invisibly: `last_generated` simply stopped
2070 + * advancing and nothing drew attention to it (#629).
2071 + *
2072 + * @since 2.2.1
2073 + * @return array Health payload.
2074 + */
2075 + public function get_regeneration_health(): array {
2076 + $settings = $this->get_settings('site');
2077 + $pending = get_option(self::REGENERATION_PENDING_OPTION, []);
2078 + $pending = is_array($pending) ? $pending : [];
2079 + $error = get_option(self::REGENERATION_ERROR_OPTION, []);
2080 + $error = is_array($error) ? $error : [];
2081 +
2082 + $since = !empty($pending['since']) ? (int) $pending['since'] : 0;
2083 +
2084 + $next_scheduled = wp_next_scheduled('thinkrank_regenerate_sitemap');
2085 + if ($next_scheduled === false) {
2086 + $next_scheduled = wp_next_scheduled('thinkrank_regenerate_sitemap_settings');
2087 + }
2088 +
2089 + return [
2090 + 'auto_generate' => !empty($settings['auto_generate']),
2091 + 'last_generated' => $settings['last_generated'] ?? '',
2092 + 'pending_since' => $since ? gmdate('c', $since) : null,
2093 + 'pending_seconds' => $since ? max(0, time() - $since) : 0,
2094 + 'next_scheduled' => $next_scheduled ? gmdate('c', (int) $next_scheduled) : null,
2095 + 'cron_disabled' => defined('DISABLE_WP_CRON') && DISABLE_WP_CRON,
2096 + 'stale' => $this->is_sitemap_stale($settings),
2097 + 'last_error' => !empty($error['message'])
2098 + ? [
2099 + 'message' => (string) $error['message'],
2100 + 'source' => isset($error['source']) ? (string) $error['source'] : 'content',
2101 + 'time' => !empty($error['time']) ? gmdate('c', (int) $error['time']) : null,
2102 + ]
2103 + : null,
2104 + ];
2105 + }
2106 +
2107 + /**
2108 + * Has published content changed since the served sitemap was last written?
2109 + *
2110 + * Uses core's cached last-modified lookup, which only considers published
2111 + * posts — the same content the sitemap covers.
2112 + *
2113 + * @since 2.2.1
2114 + * @param array $settings Sitemap settings.
2115 + * @return bool True when the sitemap is behind the content.
2116 + */
2117 + private function is_sitemap_stale(array $settings): bool {
2118 + if (empty($settings['enabled']) || empty($settings['last_generated'])) {
2119 + // Never generated is already reported separately by the UI.
2120 + return false;
2121 + }
2122 +
2123 + $generated = strtotime((string) $settings['last_generated']);
2124 + if (!$generated) {
2125 + return false;
2126 + }
2127 +
2128 + $modified = get_lastpostmodified('gmt');
2129 + if (!$modified) {
2130 + return false;
2131 + }
2132 +
2133 + $modified = strtotime($modified . ' UTC');
2134 + if (!$modified) {
2135 + return false;
2136 + }
2137 +
2138 + // A minute of slack keeps a rebuild that ran alongside the edit from
2139 + // reporting itself as stale.
2140 + return $modified > ($generated + MINUTE_IN_SECONDS);
2141 + }
2142 +
2143 + /**
2144 + * Public entry point to debounce-rebuild the sitemap after a settings change
2145 + * (e.g. toggling inclusion rules via REST or the MCP ability), so the served
2146 + * file reflects the new settings instead of going stale until a content edit.
2147 + *
2148 + * @return void
2149 + */
2150 + public function schedule_regeneration(): void {
2151 + // Debounce against rapid successive saves, but use the settings-specific
2152 + // hook so the rebuild runs regardless of the auto_generate toggle (which
2153 + // only governs content-change-triggered regeneration).
2154 + $this->mark_regeneration_pending('settings');
2155 + $this->debounce_event('thinkrank_regenerate_sitemap_settings');
2156 + }
2157 +
2158 + /**
2159 + * Rebuild the served sitemap after an explicit settings change.
2160 + *
2161 + * Unlike {@see auto_regenerate_sitemap()}, this is NOT gated on the
2162 + * auto_generate setting: the user deliberately changed inclusion rules and
2163 + * expects the served file to reflect them even if content-triggered
2164 + * auto-generation is turned off. Still respects the master `enabled` flag.
2165 + *
2166 + * @return void
2167 + */
2168 + public function regenerate_sitemap_from_settings(): void {
2169 + if (!$this->acquire_generation_lock()) {
2170 + // A manual generation (or another request's takeover) is already
2171 + // writing the files; the pending marker survives so this rebuild is
2172 + // retried rather than lost.
2173 + return;
2174 + }
2175 +
2176 + try {
2177 + $settings = $this->get_settings('site');
2178 + if (empty($settings['enabled'])) {
2179 + // The sitemap was disabled: remove the previously generated static
2180 + // files so the web server stops serving a stale sitemap that
2181 + // crawlers would otherwise keep fetching.
2182 + $this->delete_published_sitemaps();
2183 + $this->mark_regeneration_complete();
2184 + return;
2185 + }
2186 +
2187 + $revision = $this->current_regeneration_revision();
2188 +
2189 + if ('dynamic' === $this->resolve_delivery_mode($settings)) {
2190 + $this->switch_to_dynamic_delivery($settings, $revision, 'settings');
2191 + return;
2192 + }
2193 +
2194 + if ($this->generate_and_save($settings)) {
2195 + $this->mark_regeneration_complete($revision);
2196 + } else {
2197 + $this->record_regeneration_failure(
2198 + $this->write_failure_message(),
2199 + 'settings'
2200 + );
2201 + }
2202 + } catch (\Throwable $e) {
2203 + $this->record_regeneration_failure($e->getMessage(), 'settings');
2204 + } finally {
2205 + $this->release_generation_lock();
2206 + }
2207 + }
2208 +
2209 + /**
2210 + * Remove every static sitemap file ThinkRank publishes to the web root.
2211 + *
2212 + * Called when the sitemap feature is disabled, by the cleanup route, and by
2213 + * both removal paths, so /sitemap.xml, /sitemap_index.xml, the segmented
2214 + * children (incl. paginated -N pages), and /local-sitemap.xml stop being
2215 + * served. Only ThinkRank's own filenames are targeted; WordPress core's
2216 + * wp-sitemap.xml and any other plugin's sitemap in the web root are left
2217 + * untouched.
2218 + *
2219 + * @since 1.31.0 Returns the filenames removed, and accepts the settings to
2220 + * derive them from, so a caller that already read them (and
2221 + * needs to report what went) does not have to re-read or
2222 + * re-derive the name list.
2223 + * @since 2.1.0 Delegates to thinkrank_webroot_delete_sitemaps(). Uninstall
2224 + * needs the same removal but has no autoloader to reach this
2225 + * class, so the logic moved to includes/cleanup-webroot.php
2226 + * and this stays as the in-plugin entry point.
2227 + *
2228 + * @param array|null $settings Optional. Sitemap settings; defaults to the
2229 + * saved site settings.
2230 + * @return array{deleted: string[], failed: string[]} Basenames removed, and
2231 + * those that existed but could not be removed.
2232 + */
2233 + public function delete_published_sitemaps(?array $settings = null): array {
2234 + return thinkrank_webroot_delete_sitemaps($settings ?? $this->get_settings('site'));
2235 + }
2236 +
2237 + /**
2238 + * Every child-sitemap filename this site could have published.
2239 + *
2240 + * @since 1.31.0
2241 + * @since 2.1.0 Delegates to thinkrank_webroot_segment_filenames().
2242 + *
2243 + * @param array $settings Sitemap settings (read for `custom_url_pattern`).
2244 + * @return string[] Basenames, e.g. ['sitemap-posts.xml', 'sitemap-pages.xml'].
2245 + */
2246 + private function publishable_segment_filenames(array $settings): array {
2247 + return thinkrank_webroot_segment_filenames($settings);
2248 + }
2249 +
2250 + /**
2251 + * Can this web-root file be shown to be a sitemap ThinkRank wrote?
2252 + *
2253 + * The generator deletes as often as cleanup does — a segment that dropped
2254 + * out of the set, a pagination page beyond the new count, the local sitemap
2255 + * after the business identity was cleared — and until 2.1.1 it did all
2256 + * three by filename alone. That is the #515 bug on a far more frequent
2257 + * trigger: our names are the canonical ones, so an ordinary regeneration
2258 + * (post save, term change, settings save) destroyed RankMath's
2259 + * `sitemap-tags.xml` and `local-sitemap.xml` with no deactivation involved.
2260 + *
2261 + * Every name the generator derives comes from the current settings — the
2262 + * url pattern, the configured `sitemap_urls`, `local-sitemap.xml` — but the
2263 + * ownership test is still asked with `$name_derived = false`, which switches
2264 + * off the legacy fallback for the whole generator side.
2265 + *
2266 + * The fallback exists to recover a pre-2.1.1 file written with
2267 + * `enable_styling` off, which carries neither marker. That recovery belongs
2268 + * to the once-off cleanup paths. Here it can only do harm: this method runs
2269 + * on every post save, and everything this version writes carries
2270 + * THINKRANK_SITEMAP_MARKER, so after the site's first regeneration an
2271 + * unmarked file at one of our names is by definition somebody else's — and
2272 + * deleting it on an ordinary regeneration is #515 through the more common
2273 + * door. The cost is a stale unmarked segment left on disk until deactivation
2274 + * picks it up, which is the safe direction to fail in.
2275 + *
2276 + * @since 2.1.1
2277 + *
2278 + * @param string $path Absolute path to a file in the web root.
2279 + * @param array $settings Sitemap settings.
2280 + * @return bool True when the file may be deleted.
2281 + */
2282 + private function webroot_sitemap_is_ours(string $path, array $settings): bool {
2283 + return thinkrank_webroot_sitemap_is_ours($path, $settings, false);
2284 + }
2285 +
2286 + /**
1112 2287 * Auto-regenerate sitemap (called by scheduled action)
1113 2288 *
1114 2289 * @since 1.0.0
1115 2290 * @return void
@@ -1114,37 +2289,693 @@
1114 2289 * @since 1.0.0
1115 2290 * @return void
1116 2291 */
1117 2292 public function auto_regenerate_sitemap(): void {
2293 + if (!$this->acquire_generation_lock()) {
2294 + // A manual generation (or another request's takeover) is already
2295 + // writing the files; the pending marker survives so this rebuild is
2296 + // retried rather than lost.
2297 + return;
2298 + }
2299 +
1118 2300 try {
1119 2301 // Double-check that auto-generation is still enabled
1120 2302 if (!$this->should_auto_generate()) {
2303 + // Nothing outstanding can be delivered while the feature is off,
2304 + // so drop the marker rather than let the takeover retry forever.
2305 + $this->mark_regeneration_complete();
1121 2306 return;
1122 2307 }
1123 2308
1124 - // Generate sitemap with current settings
2309 + $revision = $this->current_regeneration_revision();
1125 2310 $settings = $this->get_settings('site');
1126 - $sitemap_xml = $this->generate_sitemap($settings);
1127 2311
1128 - // Save sitemap to file
1129 - $this->save_sitemap_to_file($sitemap_xml);
2312 + // See regenerate_sitemap_from_settings(): nothing to write.
2313 + if ('dynamic' === $this->resolve_delivery_mode($settings)) {
2314 + $this->switch_to_dynamic_delivery($settings, $revision, 'content');
2315 + return;
2316 + }
1130 2317
1131 - // Update last generated timestamp
1132 - $this->update_setting('last_generated', gmdate('c'), 'site');
2318 + if ($this->generate_and_save($settings)) {
2319 + $this->mark_regeneration_complete($revision);
2320 + } else {
2321 + // Previously this returned quietly and last_generated simply
2322 + // stopped advancing, leaving the site owner with no way to learn
2323 + // the sitemap had stopped updating (#629).
2324 + $this->record_regeneration_failure(
2325 + $this->write_failure_message(),
2326 + 'content'
2327 + );
2328 + }
2329 + } catch (\Throwable $e) {
2330 + $this->record_regeneration_failure($e->getMessage(), 'content');
2331 + } finally {
2332 + $this->release_generation_lock();
2333 + }
2334 + }
1133 2335
1134 - // Ping search engines if enabled
1135 - if (!empty($settings['ping_search_engines'])) {
1136 - $this->ping_search_engines();
2336 + /**
2337 + * Build and write the sitemap files for the given settings.
2338 + *
2339 + * Segmented files plus an index when the settings configure one, a single
2340 + * file otherwise, and the standalone local business sitemap either way.
2341 + * Records `last_generated` so the UI's "View Generated Sitemaps" links
2342 + * unlock, mirroring the manual generate endpoint.
2343 + *
2344 + * @since 1.17.0
2345 + * @param array $settings Sitemap settings.
2346 + * @return bool True when the sitemap files were written.
2347 + */
2348 + public function generate_and_save(array $settings): bool {
2349 + // Dynamic delivery publishes no files, so writing them here would put a
2350 + // static copy back in the web root for the server to serve in place of
2351 + // the dynamic route. Guarding at each call site left gaps — the
2352 + // snapshot migrator's post-import regeneration had none — so the rule
2353 + // lives with the writing instead.
2354 + //
2355 + // `is_collecting()` is the exception that makes dynamic delivery work
2356 + // at all: render_document() and collect_documents() reach this same
2357 + // method with the writer swapped for a collector, and that is precisely
2358 + // the dynamic build. Only a real write is skipped.
2359 + if (!$this->is_collecting() && 'dynamic' === $this->resolve_delivery_mode($settings)) {
2360 + // Whatever prompted this call changed the sitemap's content, so the
2361 + // rendered copies must not outlive it.
2362 + $this->flush_dynamic_cache();
2363 +
2364 + return true;
2365 + }
2366 +
2367 + // Index mode is driven by the use_sitemap_index toggle (not merely by how
2368 + // many sitemap_urls happen to be configured). When the toggle is on but
2369 + // no child sitemaps are set up yet, synthesize the per-type segmented set
2370 + // so we emit a real <sitemapindex> with paginated children instead of a
2371 + // flat urlset misnamed sitemap_index.xml.
2372 + $settings = $this->maybe_promote_to_index($settings);
2373 +
2374 + if (!empty($settings['use_sitemap_index']) || count((is_array($settings['sitemap_urls'] ?? null) ? $settings['sitemap_urls'] : [])) > 1) {
2375 + $results = $this->generate_multiple_sitemaps($settings);
2376 + $written = !empty($results['success']);
2377 + } else {
2378 + $xml = $this->generate_sitemap($settings);
2379 + $primary = $this->get_primary_sitemap_filename($settings);
2380 + $written = $this->save_sitemap_to_file($xml, $primary);
2381 +
2382 + // Local business sitemap is a standalone file, regenerated on the
2383 + // single-sitemap path too (this is the default mode).
2384 + $this->regenerate_local_sitemap($settings);
2385 +
2386 + // Switching out of index mode leaves sitemap_index.xml and every
2387 + // child on disk, still served and never refreshed again. The index
2388 + // path already prunes what it no longer owns; this path never did,
2389 + // so the site kept serving two sitemap trees (#563). Ownership is
2390 + // still tested per file, so another plugin's sitemap at one of our
2391 + // names is never touched (#515).
2392 + $this->prune_orphaned_segments($settings, [['filename' => basename($primary)]]);
2393 + }
2394 +
2395 + // last_generated describes what is on disk. A dynamic render publishes
2396 + // nothing, so advancing it would report a static publication that never
2397 + // happened and would let primary_sitemap_file_exists() callers believe
2398 + // there is a file to serve.
2399 + if ($written && !$this->is_collecting()) {
2400 + $settings['last_generated'] = gmdate('c');
2401 + $this->save_settings('site', null, $settings);
2402 + }
2403 +
2404 + return $written;
2405 + }
2406 +
2407 + /**
2408 + * Whether this instance is rendering documents rather than publishing them.
2409 + *
2410 + * @since 2.9.0
2411 + *
2412 + * @return bool
2413 + */
2414 + private function is_collecting(): bool {
2415 + return $this->document_sink !== null;
2416 + }
2417 +
2418 + /**
2419 + * Complete a regeneration that delivers dynamically, retiring stale files.
2420 + *
2421 + * Dynamic delivery renders nothing to disk, but that is only half the job.
2422 + * A web server hands back an existing `/sitemap.xml` without ever loading
2423 + * WordPress, so any file left over from a previous static generation goes on
2424 + * being served forever and {@see \ThinkRank\Frontend\SEO_Manager
2425 + * ::maybe_serve_sitemap()} is never reached. Switching to dynamic while
2426 + * leaving those files in place would therefore appear to do nothing at all.
2427 + *
2428 + * Both transitions matter and they differ:
2429 + *
2430 + * - An explicit switch to `dynamic` happens on a site whose root is usually
2431 + * still writable, so the files can simply be removed.
2432 + * - An `auto` site that becomes read-only cannot remove them, because
2433 + * deleting an entry needs write permission on the directory that holds
2434 + * it. There the stale sitemap really is stuck in front of us, and the
2435 + * honest outcome is a recorded failure naming it rather than a rebuild
2436 + * reported as complete (#754 review).
2437 + *
2438 + * Ownership is tested per file by the shared helper, so another plugin's
2439 + * sitemap at one of our names is never deleted (#515).
2440 + *
2441 + * @since 2.9.0
2442 + *
2443 + * @param array $settings Sitemap settings.
2444 + * @param int $revision Revision this rebuild is completing.
2445 + * @param string $source 'settings' or 'content', for the failure record.
2446 + * @return void
2447 + */
2448 + private function switch_to_dynamic_delivery(array $settings, int $revision, string $source): void {
2449 + $this->flush_dynamic_cache();
2450 +
2451 + $removal = $this->delete_published_sitemaps($settings);
2452 + $stuck = is_array($removal['failed'] ?? null) ? $removal['failed'] : [];
2453 +
2454 + if (!empty($stuck)) {
2455 + $this->record_regeneration_failure(
2456 + sprintf(
2457 + /* translators: 1: comma-separated file names, 2: absolute path to the WordPress root. */
2458 + __('The sitemap is being served from WordPress, but these files are still in the site root and your web server will keep serving them instead: %1$s. They could not be removed because %2$s is not writable. Delete them, or ask your host to make the WordPress root writable.', 'thinkrank'),
2459 + implode(', ', $stuck),
2460 + untrailingslashit(ABSPATH)
2461 + ),
2462 + $source
2463 + );
2464 +
2465 + return;
2466 + }
2467 +
2468 + $this->mark_regeneration_complete($revision);
2469 + }
2470 +
2471 + /**
2472 + * What to tell the site owner when publishing the files failed.
2473 + *
2474 + * The old wording stated the symptom and stopped there, so the reported
2475 + * cause was a guess and this reached support as a plugin fault rather than
2476 + * a folder permission (#752, #753). When the root is demonstrably
2477 + * unwritable, say that, and say what to do about it.
2478 + *
2479 + * @since 2.9.0
2480 + *
2481 + * @return string
2482 + */
2483 + private function write_failure_message(): string {
2484 + if (!wp_is_writable(ABSPATH)) {
2485 + return sprintf(
2486 + /* translators: %s: absolute path to the WordPress root. */
2487 + __('The sitemap could not be written because the folder %s is not writable by PHP. Ask your host to make the WordPress root writable, or set Sitemap Delivery to Dynamic to serve the sitemap without writing files.', 'thinkrank'),
2488 + untrailingslashit(ABSPATH)
2489 + );
2490 + }
2491 +
2492 + return __('The sitemap files could not be written to the site root.', 'thinkrank');
2493 + }
2494 +
2495 + /**
2496 + * How this site delivers its sitemap.
2497 + *
2498 + * `auto` is resolved on whether the web root can be written. That is the
2499 + * right signal here (unlike llms.txt, where the question is whether the
2500 + * server applies the .htaccess charset block): a site whose root is
2501 + * read-only cannot publish a sitemap file at all, and before this existed
2502 + * the feature simply failed with "The sitemap files could not be written to
2503 + * the site root." and served nothing (#752).
2504 + *
2505 + * @since 2.9.0
2506 + *
2507 + * @param array|null $settings Sitemap settings (falls back to saved ones).
2508 + * @return string One of 'static' or 'dynamic'. Never 'auto'.
2509 + */
2510 + public function resolve_delivery_mode(?array $settings = null): string {
2511 + $settings = $settings ?? $this->get_settings('site');
2512 + $mode = (string) ($settings['delivery_mode'] ?? 'auto');
2513 +
2514 + if ('static' === $mode || 'dynamic' === $mode) {
2515 + return $mode;
2516 + }
2517 +
2518 + return wp_is_writable(ABSPATH) ? 'static' : 'dynamic';
2519 + }
2520 +
2521 + /**
2522 + * Render one published sitemap document without touching the filesystem.
2523 + *
2524 + * Runs the ordinary build pipeline with the writer swapped for a collector,
2525 + * so the bytes returned here are the bytes the static path would have
2526 + * written. `SitemapDeliveryParityTest` asserts that equivalence rather than
2527 + * trusting it.
2528 + *
2529 + * The whole set is built to answer for one file, because the index can only
2530 + * be assembled from the children that were actually produced. The result is
2531 + * cached per document, so that cost is paid once per change and not once
2532 + * per crawler request.
2533 + *
2534 + * @since 2.9.0
2535 + *
2536 + * @param string $filename Published file name, e.g. 'sitemap.xml'.
2537 + * @param array|null $settings Sitemap settings (falls back to saved ones).
2538 + * @return string|null XML, or null when this site does not publish that name.
2539 + */
2540 + public function render_document(string $filename, ?array $settings = null): ?string {
2541 + $filename = basename($filename);
2542 + $settings = $settings ?? $this->get_settings('site');
2543 +
2544 + if (empty($settings['enabled'])) {
2545 + return null;
2546 + }
2547 +
2548 + $cached = get_transient($this->dynamic_cache_key($filename));
2549 + if (self::ABSENT_MARKER === $cached) {
2550 + return null;
2551 + }
2552 + if (is_string($cached) && '' !== $cached) {
2553 + return $cached;
2554 + }
2555 +
2556 + // A miss builds the whole set, because the index can only be assembled
2557 + // from the children that were actually produced. Caching only the
2558 + // requested document therefore made a crawler walking the index and its
2559 + // children rebuild the entire site's sitemap once per file — every post
2560 + // and taxonomy query repeated N times on a public endpoint (#754
2561 + // review). The set is built once and stored in full.
2562 + return $this->stream_documents($settings, $filename);
2563 + }
2564 +
2565 + /**
2566 + * Build every document, caching each as it is produced, keeping one.
2567 + *
2568 + * A miss has to build the whole set, because the index can only be
2569 + * assembled from the children that were actually produced. It does not have
2570 + * to *hold* the whole set: the static path never keeps more than one page
2571 + * in memory, writing each to disk as it goes, and buffering every
2572 + * document's XML to return one of them undid that on the request path,
2573 + * where a large site's entire sitemap corpus would sit in a single PHP
2574 + * process (#754 review).
2575 + *
2576 + * So the sink writes each document straight to its cache entry and lets it
2577 + * go, retaining only the one this request is answering. Peak retention is
2578 + * one document, whatever the site's size.
2579 + *
2580 + * Concurrency: the first request through takes a short lock and does the
2581 + * work. One that finds the lock held waits a bounded moment for the winner
2582 + * to publish, then builds anyway, because serving a correct sitemap late
2583 + * beats serving none.
2584 + *
2585 + * @since 2.9.0
2586 + *
2587 + * @param array $settings Sitemap settings.
2588 + * @param string $wanted Document this request is answering.
2589 + * @return string|null XML for $wanted, or null when the site does not publish it.
2590 + */
2591 + private function stream_documents(array $settings, string $wanted): ?string {
2592 + $lock = self::DYNAMIC_CACHE_PREFIX . 'lock';
2593 +
2594 + if (!$this->acquire_render_lock($lock)) {
2595 + for ($attempt = 0; $attempt < self::RENDER_LOCK_WAIT_ATTEMPTS; $attempt++) {
2596 + usleep(self::RENDER_LOCK_WAIT_MICROSECONDS);
2597 +
2598 + $cached = get_transient($this->dynamic_cache_key($wanted));
2599 + if (self::ABSENT_MARKER === $cached) {
2600 + return null;
2601 + }
2602 + if (is_string($cached) && '' !== $cached) {
2603 + return $cached;
2604 + }
1137 2605 }
2606 + }
1138 2607
1139 - // Sitemap auto-regenerated successfully
2608 + $kept = null;
2609 + // Names only. Keeping the bodies here would be the very retention this
2610 + // method exists to avoid.
2611 + $produced = [];
1140 2612
1141 - } catch (\Exception $e) {
1142 - // Sitemap auto-regeneration failed - error details available in exception
2613 + $previous = $this->document_sink;
2614 + $this->document_sink = function (string $name, string $xml) use (&$kept, &$produced, $wanted): void {
2615 + $produced[$name] = true;
2616 + set_transient($this->dynamic_cache_key($name), $xml, self::DYNAMIC_CACHE_TTL);
2617 +
2618 + if ($name === $wanted) {
2619 + $kept = $xml;
2620 + }
2621 + };
2622 +
2623 + try {
2624 + $this->generate_and_save($settings);
2625 +
2626 + // Names the configuration lists but this build did not produce get
2627 + // a negative entry, so asking for one again is a cache hit rather
2628 + // than another full rebuild.
2629 + $absent = $this->published_document_names($settings);
2630 +
2631 + // Also the exact name this request asked for: a paginated page past
2632 + // the end of a stem is a legitimate request shape that the base
2633 + // list cannot enumerate, and without an entry it would rebuild on
2634 + // every hit.
2635 + $absent[] = $wanted;
2636 +
2637 + foreach (array_unique($absent) as $name) {
2638 + if (!isset($produced[$name])) {
2639 + set_transient($this->dynamic_cache_key($name), self::ABSENT_MARKER, self::DYNAMIC_CACHE_TTL);
2640 + }
2641 + }
2642 + } finally {
2643 + $this->document_sink = $previous;
2644 + delete_transient($lock);
1143 2645 }
2646 +
2647 + return $kept;
1144 2648 }
1145 2649
1146 2650 /**
2651 + * Take the render lock, if it is free.
2652 + *
2653 + * Not atomic across processes, and deliberately so: the fallback for losing
2654 + * a race is duplicated work, never a wrong or missing sitemap, so a
2655 + * heavier primitive would buy nothing here.
2656 + *
2657 + * @since 2.9.0
2658 + *
2659 + * @param string $lock Lock transient name.
2660 + * @return bool True when this request holds the lock.
2661 + */
2662 + private function acquire_render_lock(string $lock): bool {
2663 + if (false !== get_transient($lock)) {
2664 + return false;
2665 + }
2666 +
2667 + set_transient($lock, time(), self::RENDER_LOCK_TTL);
2668 +
2669 + return true;
2670 + }
2671 +
2672 + /**
2673 + * Build every document this site publishes and return them all.
2674 + *
2675 + * Verification and tooling only. This retains the whole set in memory, so
2676 + * it must never be used to answer a request: {@see self::stream_documents()}
2677 + * is the serving path and keeps one document at a time regardless of site
2678 + * size (#754 review). `SitemapDeliveryParityTest` enforces that separation
2679 + * by failing if the request path routes back through here.
2680 + *
2681 + * @since 2.9.0
2682 + *
2683 + * @param array $settings Sitemap settings.
2684 + * @return array<string,string> Filename => XML.
2685 + */
2686 + public function collect_documents(array $settings): array {
2687 + $documents = [];
2688 +
2689 + $previous = $this->document_sink;
2690 + $this->document_sink = static function (string $name, string $xml) use (&$documents): void {
2691 + $documents[$name] = $xml;
2692 + };
2693 +
2694 + try {
2695 + $this->generate_and_save($settings);
2696 + } finally {
2697 + $this->document_sink = $previous;
2698 + }
2699 +
2700 + return $documents;
2701 + }
2702 +
2703 + /**
2704 + * The file names this site publishes, without building their contents.
2705 + *
2706 + * Used by the request router to decide whether a URL is ours before doing
2707 + * any work. Cheap: it reads the configured child list rather than querying
2708 + * for entries.
2709 + *
2710 + * @since 2.9.0
2711 + *
2712 + * @param array|null $settings Sitemap settings (falls back to saved ones).
2713 + * @return string[] File names, including paginated pages that may exist.
2714 + */
2715 + public function published_document_names(?array $settings = null): array {
2716 + $settings = $settings ?? $this->get_settings('site');
2717 + $resolved = $this->maybe_promote_to_index($settings);
2718 +
2719 + $names = [$this->get_primary_sitemap_filename($settings), 'local-sitemap.xml'];
2720 +
2721 + foreach ((array) ($resolved['sitemap_urls'] ?? []) as $child) {
2722 + if (!is_array($child) || empty($child['enabled'])) {
2723 + continue;
2724 + }
2725 +
2726 + $path = (string) wp_parse_url((string) ($child['url'] ?? ''), PHP_URL_PATH);
2727 + if ('' !== $path) {
2728 + $names[] = basename($path);
2729 + }
2730 + }
2731 +
2732 + return array_values(array_unique(array_filter($names)));
2733 + }
2734 +
2735 + /**
2736 + * Does this site publish a document under that name?
2737 + *
2738 + * Not a plain membership test against {@see self::published_document_names()}:
2739 + * that lists the configured children, and a child over the per-file URL cap
2740 + * is split into `<stem>-2.xml`, `<stem>-3.xml` and so on, with every page
2741 + * listed in the index. Gating the request router on the base list alone
2742 + * therefore 404'd exactly the pages the index points at, which is worse than
2743 + * not serving them at all.
2744 + *
2745 + * Page counts are not knowable without building, so the stem is what is
2746 + * matched; a page that does not exist is answered by the build finding
2747 + * nothing for it, and is then cached as absent.
2748 + *
2749 + * @since 2.9.0
2750 + *
2751 + * @param string $name Requested file name.
2752 + * @param array|null $settings Sitemap settings (falls back to saved ones).
2753 + * @return bool
2754 + */
2755 + public function publishes_document_name(string $name, ?array $settings = null): bool {
2756 + $names = $this->published_document_names($settings);
2757 +
2758 + if (in_array($name, $names, true)) {
2759 + return true;
2760 + }
2761 +
2762 + if (!preg_match('/^(.*)-\d+\.xml$/i', $name, $m)) {
2763 + return false;
2764 + }
2765 +
2766 + return in_array($m[1] . '.xml', $names, true);
2767 + }
2768 +
2769 + /**
2770 + * Transient key for a rendered document.
2771 + *
2772 + * @since 2.9.0
2773 + *
2774 + * @param string $filename Published file name.
2775 + * @return string
2776 + */
2777 + private function dynamic_cache_key(string $filename): string {
2778 + return self::DYNAMIC_CACHE_PREFIX . md5($filename);
2779 + }
2780 +
2781 + /**
2782 + * Drop every cached dynamic document.
2783 + *
2784 + * Called from the same places that mark the static files stale, so the two
2785 + * delivery modes invalidate on identical triggers.
2786 + *
2787 + * @since 2.9.0
2788 + *
2789 + * @return void
2790 + */
2791 + public function flush_dynamic_cache(): void {
2792 + foreach ($this->published_document_names() as $name) {
2793 + delete_transient($this->dynamic_cache_key($name));
2794 + }
2795 + }
2796 +
2797 + /**
2798 + * Resolve index-vs-single mode, synthesizing child sitemaps when needed.
2799 + *
2800 + * - When use_sitemap_index is on but no child sitemaps are configured, build
2801 + * the per-type segmented set so a real <sitemapindex> is produced (#127).
2802 + * - When the toggle is off but a single flat file would exceed the per-file
2803 + * URL cap, auto-promote to a paginated index instead of one oversized file
2804 + * that can cross Google's 50k-URL/50MB limits (#129).
2805 + *
2806 + * @param array $settings Sitemap settings.
2807 + * @return array Possibly-updated settings.
2808 + */
2809 + public function maybe_promote_to_index(array $settings): array {
2810 + $saved = $this->get_settings('site');
2811 +
2812 + // Read from the *payload*, before the merge below folds the saved values
2813 + // in: "the caller named this" and "this has a value" are different
2814 + // questions, and the mode resolution turns on the former.
2815 + $mode_supplied = array_key_exists('use_sitemap_index', $settings);
2816 + $urls_supplied = is_array($settings['sitemap_urls'] ?? null);
2817 + $has_children = count($urls_supplied ? $settings['sitemap_urls'] : []) > 1;
2818 +
2819 + // Which inclusion flags did the caller actually name? The child list is
2820 + // the only thing that reads them, and inheriting a saved one skipped
2821 + // that — so on an index-mode site the include_* flags were enforced
2822 + // nowhere but in the browser, where SitemapGeneration.js recomputes
2823 + // sitemap_urls itself. Every non-UI client, the shipped
2824 + // `update-sitemap-settings` ability included, saved the flag and changed
2825 + // nothing (#398). Read from the payload for the same reason as above:
2826 + // after the merge every saved flag would look like one the caller named.
2827 + $named_inclusions = array_intersect(
2828 + array_keys(self::INCLUSION_CHILD_TYPES),
2829 + array_keys($settings)
2830 + );
2831 + $inclusions_supplied = (bool) $named_inclusions;
2832 +
2833 + // Inclusion flags may be absent from a partial payload (e.g. the manual
2834 + // generate endpoint) — fall back to saved settings so synthesized child
2835 + // sitemaps reflect the real include_posts/pages/categories choices.
2836 + $inclusions = array_merge($saved, $settings);
2837 +
2838 + // Hand the generators a *complete* settings array. Only the mode was
2839 + // resolved before, so every other unnamed key reached them missing: a
2840 + // bare `{}` from a REST/MCP client republished the sitemap with
2841 + // enable_styling and include_images read as off, overwriting the live
2842 + // files with output that had lost its XSL stylesheet, its image
2843 + // namespace and its image entries. Presentation and inclusion settings
2844 + // are not something a generate call opts into — they are the site's
2845 + // configuration, and only a value actually present in the payload
2846 + // overrides them.
2847 + $settings = $inclusions;
2848 +
2849 + // The two keys that drive mode keep their own resolution rules below,
2850 + // so they must go back to "not specified" when the caller omitted them.
2851 + if (!$mode_supplied) {
2852 + unset($settings['use_sitemap_index']);
2853 + }
2854 + if (!$urls_supplied) {
2855 + unset($settings['sitemap_urls']);
2856 + }
2857 +
2858 + // An absent use_sitemap_index means "not specified", which is not the
2859 + // same as "single file". Reading it as the latter meant a partial payload
2860 + // — `{}` from a REST/MCP client, or anything short of the full settings
2861 + // object the admin bundle sends — republished one flat sitemap.xml on an
2862 + // index-mode site and left sitemap_index.xml and its children stale or
2863 + // missing. Inherit the saved mode instead; only a value actually present
2864 + // in the payload decides the mode.
2865 + if (!array_key_exists('use_sitemap_index', $settings)) {
2866 + $settings['use_sitemap_index'] = $saved['use_sitemap_index'] ?? '';
2867 +
2868 + // Inheriting the mode means inheriting its children too, unless the
2869 + // caller named its own set.
2870 + $saved_children = (is_array($saved['sitemap_urls'] ?? null) ? $saved['sitemap_urls'] : []);
2871 + if (!empty($settings['use_sitemap_index'])
2872 + && !$urls_supplied
2873 + && count($saved_children) > 1) {
2874 + // A named inclusion flag is applied *to* the inherited list, not
2875 + // used to regenerate it. build_segmented_sitemap_urls() also adds
2876 + // a child for every public custom post type, so rebuilding here
2877 + // would make `{include_pages: false}` — one thing off — silently
2878 + // switch on children the saved list never had (an Elementor
2879 + // internal CPT, a WooCommerce product feed). Only the flags the
2880 + // caller actually named change anything.
2881 + $settings['sitemap_urls'] = $inclusions_supplied
2882 + ? $this->apply_inclusion_flags_to_children($saved_children, $named_inclusions, $inclusions)
2883 + : $saved_children;
2884 +
2885 + // The children are resolved either way — including when the
2886 + // caller switched the last one off, which leaves a bare index and
2887 + // is what they asked for.
2888 + $has_children = true;
2889 + }
2890 + }
2891 +
2892 + if (!empty($settings['use_sitemap_index'])) {
2893 + if (!$has_children) {
2894 + $settings['sitemap_urls'] = $this->build_segmented_sitemap_urls($inclusions);
2895 + }
2896 + return $settings;
2897 + }
2898 +
2899 + if (!$has_children) {
2900 + $limit = $this->get_links_per_sitemap($settings);
2901 + if ($limit > 0 && $this->estimate_total_sitemap_urls($inclusions) > $limit) {
2902 + $settings['use_sitemap_index'] = true;
2903 + $settings['sitemap_urls'] = $this->build_segmented_sitemap_urls($inclusions);
2904 + }
2905 + }
2906 +
2907 + return $settings;
2908 + }
2909 +
2910 + /**
2911 + * Rough count of URLs a single-file sitemap would contain, used only to
2912 + * decide whether to auto-promote to a paginated index. Cheap COUNT queries;
2913 + * intentionally approximate (homepage + published posts of enabled types +
2914 + * terms of enabled taxonomies).
2915 + *
2916 + * @param array $settings Sitemap settings.
2917 + * @return int
2918 + */
2919 + private function estimate_total_sitemap_urls(array $settings): int {
2920 + $total = 1; // homepage
2921 +
2922 + foreach ($this->get_enabled_post_types($settings) as $post_type) {
2923 + $counts = wp_count_posts($post_type);
2924 + $total += isset($counts->publish) ? (int) $counts->publish : 0;
2925 + }
2926 +
2927 + foreach ($this->get_enabled_taxonomies($settings) as $taxonomy) {
2928 + $count = wp_count_terms(['taxonomy' => $taxonomy, 'hide_empty' => true]);
2929 + if (!is_wp_error($count)) {
2930 + $total += (int) $count;
2931 + }
2932 + }
2933 +
2934 + return $total;
2935 + }
2936 +
2937 + /**
2938 + * Resolve the sitemap file the site publishes for the given settings.
2939 + *
2940 + * Index mode serves the index (`sitemap_index.xml`); the default single-file
2941 + * mode serves `sitemap.xml`. Callers use this to link to — or check for —
2942 + * the file the site actually serves, since ThinkRank's sitemap is a static
2943 + * file in the web root rather than a route.
2944 + *
2945 + * @since 1.17.0
2946 + * @param array $settings Sitemap settings.
2947 + * @return string Sitemap filename.
2948 + */
2949 + public function get_primary_sitemap_filename(array $settings): string {
2950 + return thinkrank_webroot_primary_sitemap_filename($settings);
2951 + }
2952 +
2953 + /**
2954 + * Public URL of the sitemap the site serves.
2955 + *
2956 + * @since 1.17.0
2957 + * @param array|null $settings Sitemap settings (falls back to saved site settings).
2958 + * @return string Absolute sitemap URL.
2959 + */
2960 + public function get_primary_sitemap_url(?array $settings = null): string {
2961 + $settings = $settings ?? $this->get_settings('site');
2962 +
2963 + return home_url('/' . $this->get_primary_sitemap_filename($settings));
2964 + }
2965 +
2966 + /**
2967 + * Whether the sitemap file this site publishes exists on disk.
2968 + *
2969 + * @since 1.17.0
2970 + * @param array $settings Sitemap settings.
2971 + * @return bool True when the file is present.
2972 + */
2973 + public function primary_sitemap_file_exists(array $settings): bool {
2974 + return file_exists(ABSPATH . $this->get_primary_sitemap_filename($settings));
2975 + }
2976 +
2977 + /**
1147 2978 * Save sitemap XML to file
1148 2979 *
1149 2980 * @since 1.0.0
1150 2981 * @param string $sitemap_xml Sitemap XML content
@@ -1159,8 +2990,18 @@
1159 2990 // File validation failed - error details available in exception
1160 2991 return false;
1161 2992 }
1162 2993
2994 + // Dynamic delivery: hand the document to the collector instead of the
2995 + // filesystem. Reported as published, because for this run it is — the
2996 + // caller's success/failure bookkeeping and the index assembly both key
2997 + // off this return value.
2998 + if ($this->document_sink !== null) {
2999 + ($this->document_sink)($filename, $sitemap_xml);
3000 +
3001 + return true;
3002 + }
3003 +
1163 3004 $sitemap_path = ABSPATH . $filename;
1164 3005
1165 3006 // Use WordPress filesystem API for better security
1166 3007 global $wp_filesystem;
@@ -1169,16 +3010,202 @@
1169 3010 WP_Filesystem();
1170 3011 }
1171 3012
1172 3013 if ($wp_filesystem) {
1173 - return $wp_filesystem->put_contents($sitemap_path, $sitemap_xml, FS_CHMOD_FILE);
3014 + $written = $wp_filesystem->put_contents($sitemap_path, $sitemap_xml, FS_CHMOD_FILE);
3015 +
3016 + if ($written) {
3017 + // Every sitemap this version writes carries the ownership
3018 + // marker, so once one has been written an unmarked file at one
3019 + // of our names cannot be ours. Recording that retires the
3020 + // legacy fallback for this install — see
3021 + // thinkrank_webroot_sitemap_is_ours().
3022 + if (get_option(THINKRANK_SITEMAP_MARKED_WRITE_OPTION) !== '1') {
3023 + update_option(THINKRANK_SITEMAP_MARKED_WRITE_OPTION, '1', false);
3024 + }
3025 + }
3026 +
3027 + return $written;
1174 3028 }
1175 3029
1176 - // Fallback to file_put_contents if WP_Filesystem fails
1177 - return file_put_contents($sitemap_path, $sitemap_xml) !== false;
3030 + // WP_Filesystem initialization failed
3031 + return false;
1178 3032 }
1179 3033
1180 3034 /**
3035 + * Build a segmented, index-based sitemap_urls list from inclusion settings.
3036 + *
3037 + * Produces the index entry plus one child sitemap per enabled content type
3038 + * (posts/pages/categories) and one per public custom post type — the shape
3039 + * the "complete" preset creates and that generate_multiple_sitemaps() expects.
3040 + * Used when enabling the index during import so the index has real children
3041 + * instead of being empty.
3042 + *
3043 + * @since 1.14.0
3044 + *
3045 + * @param array $inclusions Inclusion flags (include_posts/pages/categories)
3046 + * and optionally custom_url_pattern.
3047 + * @return array Sitemap URL configs
3048 + */
3049 + public function build_segmented_sitemap_urls(array $inclusions): array {
3050 + $pattern = $inclusions['custom_url_pattern'] ?? 'sitemap-{type}.xml';
3051 +
3052 + $urls = [$this->sitemap_child_entry('/sitemap_index.xml', 'index')];
3053 +
3054 + foreach (self::INCLUSION_CHILD_TYPES as $flag => $type) {
3055 + if (!empty($inclusions[$flag])) {
3056 + $urls[] = $this->build_child_sitemap_entry($type, $pattern);
3057 + }
3058 + }
3059 +
3060 + // Public custom post types each get a child sitemap (parity with the
3061 + // "complete" preset and with Rank Math, which lists every public CPT).
3062 + foreach (get_post_types(['public' => true, '_builtin' => false], 'names') as $cpt) {
3063 + if (!$this->should_include_post_type($cpt)) {
3064 + continue;
3065 + }
3066 +
3067 + // ...and the per-content-type sitemap switch (#660).
3068 + // get_enabled_post_types() already honours it, but this list is what
3069 + // index mode builds its children from — so without the same test a
3070 + // CPT the user had switched off still got its own child sitemap,
3071 + // created and streamed in full. The flags live in $inclusions, which
3072 + // is the settings array these children are derived from.
3073 + if (!\ThinkRank\SEO\Content_Type_Settings::is_included_in_sitemap('post_type', $cpt, $inclusions)) {
3074 + continue;
3075 + }
3076 +
3077 + $urls[] = $this->build_child_sitemap_entry($cpt, $pattern);
3078 + }
3079 +
3080 + // Public custom taxonomies get the same treatment (#690). Flat mode has
3081 + // always walked them through get_enabled_taxonomies(); index mode built
3082 + // its children from the list above and never consulted a taxonomy at
3083 + // all, so every custom-taxonomy archive silently vanished from the
3084 + // sitemap the moment a site switched modes — and the per-taxonomy switch
3085 + // the matrix writes had nothing to act on. Same two tests the post-type
3086 + // walk applies, in the same order.
3087 + $taken = array_column($urls, 'type');
3088 +
3089 + foreach (get_taxonomies(['public' => true, '_builtin' => false], 'names') as $taxonomy) {
3090 + if (!$this->should_include_taxonomy($taxonomy)) {
3091 + continue;
3092 + }
3093 +
3094 + if (!\ThinkRank\SEO\Content_Type_Settings::is_included_in_sitemap('taxonomy', $taxonomy, $inclusions)) {
3095 + continue;
3096 + }
3097 +
3098 + // Post types and taxonomies are separate registries, so a site can
3099 + // hold both a `foo` post type and a `foo` taxonomy. They would
3100 + // resolve to one filename, and stream_type_entries() answers post
3101 + // types first, so the second child would list the first one's file
3102 + // twice in the index rather than adding anything.
3103 + if (in_array($taxonomy, $taken, true)) {
3104 + continue;
3105 + }
3106 +
3107 + $urls[] = $this->build_child_sitemap_entry($taxonomy, $pattern);
3108 + }
3109 +
3110 + return $urls;
3111 + }
3112 +
3113 + /**
3114 + * Apply only the inclusion flags the caller named to an existing child list.
3115 + *
3116 + * The narrow counterpart to build_segmented_sitemap_urls(): that one
3117 + * regenerates the whole set from scratch, which is right when there is no set
3118 + * yet and wrong when there is. Rebuilding an existing list would add a child
3119 + * for every public custom post type it had never contained, so a payload that
3120 + * switches one thing off would switch others on. Here a flag adds or removes
3121 + * exactly its own child and leaves every other entry — custom post types,
3122 + * hand-added URLs, per-child enabled/status state — untouched (#398).
3123 + *
3124 + * @since 1.31.0
3125 + *
3126 + * @param array $children Existing child sitemap entries.
3127 + * @param string[] $named_inclusions Inclusion flag keys present in the payload.
3128 + * @param array $inclusions Merged settings, for the resolved flag
3129 + * values and custom_url_pattern.
3130 + * @return array Updated child sitemap entries.
3131 + */
3132 + private function apply_inclusion_flags_to_children(
3133 + array $children,
3134 + array $named_inclusions,
3135 + array $inclusions
3136 + ): array {
3137 + $pattern = $inclusions['custom_url_pattern'] ?? 'sitemap-{type}.xml';
3138 +
3139 + foreach ($named_inclusions as $flag) {
3140 + $type = self::INCLUSION_CHILD_TYPES[$flag];
3141 +
3142 + $present = false;
3143 + foreach ($children as $entry) {
3144 + if (($entry['type'] ?? '') === $type) {
3145 + $present = true;
3146 + break;
3147 + }
3148 + }
3149 +
3150 + if (empty($inclusions[$flag])) {
3151 + if ($present) {
3152 + $children = array_values(array_filter(
3153 + $children,
3154 + static function ($entry) use ($type): bool {
3155 + return (is_array($entry) ? ($entry['type'] ?? '') : '') !== $type;
3156 + }
3157 + ));
3158 + }
3159 + continue;
3160 + }
3161 +
3162 + if (!$present) {
3163 + $children[] = $this->build_child_sitemap_entry($type, $pattern);
3164 + }
3165 + }
3166 +
3167 + return $children;
3168 + }
3169 +
3170 + /**
3171 + * Build one child sitemap entry, resolving its filename from the url pattern.
3172 + *
3173 + * @since 1.31.0
3174 + *
3175 + * @param string $type Child sitemap type (posts, pages, a post type name).
3176 + * @param string $pattern Filename pattern containing {type}.
3177 + * @return array Sitemap URL config.
3178 + */
3179 + private function build_child_sitemap_entry(string $type, string $pattern): array {
3180 + $file = str_replace('{type}', $type, $pattern);
3181 + if (strpos($file, '/') !== 0) {
3182 + $file = '/' . $file;
3183 + }
3184 +
3185 + return $this->sitemap_child_entry($file, $type);
3186 + }
3187 +
3188 + /**
3189 + * The shape generate_multiple_sitemaps() expects of a sitemap_urls entry.
3190 + *
3191 + * @since 1.31.0
3192 + *
3193 + * @param string $url Sitemap path.
3194 + * @param string $type Entry type.
3195 + * @return array Sitemap URL config.
3196 + */
3197 + private function sitemap_child_entry(string $url, string $type): array {
3198 + return [
3199 + 'url' => $url,
3200 + 'type' => $type,
3201 + 'enabled' => true,
3202 + 'last_checked' => null,
3203 + 'status' => 'unknown',
3204 + ];
3205 + }
3206 +
3207 + /**
1181 3208 * Generate multiple sitemaps based on settings
1182 3209 *
1183 3210 * @since 1.0.0
1184 3211 * @param array $settings Sitemap settings
@@ -1191,9 +3218,9 @@
1191 3218 'errors' => [],
1192 3219 'total_urls' => 0
1193 3220 ];
1194 3221
1195 - $sitemap_urls = $settings['sitemap_urls'] ?? [];
3222 + $sitemap_urls = (is_array($settings['sitemap_urls'] ?? null) ? $settings['sitemap_urls'] : []);
1196 3223
1197 3224 if (empty($sitemap_urls)) {
1198 3225 $results['success'] = false;
1199 3226 $results['errors'][] = 'No sitemap URLs configured';
@@ -1199,215 +3226,663 @@
1199 3226 $results['errors'][] = 'No sitemap URLs configured';
1200 3227 return $results;
1201 3228 }
1202 3229
3230 + $limit = $this->get_links_per_sitemap($settings);
3231 +
3232 + // Defer the index until every child sitemap has been generated, so it can
3233 + // list the actual files produced (including pagination pages).
3234 + $index_config = null;
3235 + $index_children = [];
3236 +
1203 3237 foreach ($sitemap_urls as $sitemap_config) {
1204 - if (!$sitemap_config['enabled']) {
3238 + if (empty($sitemap_config['enabled'])) {
1205 3239 continue;
1206 3240 }
1207 3241
3242 + $type = $sitemap_config['type'];
3243 +
3244 + if ($type === 'index') {
3245 + $index_config = $sitemap_config;
3246 + continue;
3247 + }
3248 +
3249 + // Skip CPT children that no longer qualify (e.g. an internal store
3250 + // like Templately's `templately_library`) even when a previously
3251 + // saved config still lists them. Built-in aggregate types ('posts',
3252 + // 'pages', 'general', etc.) are not post type names, so this only
3253 + // affects real custom post types.
3254 + if (post_type_exists($type) && !$this->should_include_post_type($type)) {
3255 + continue;
3256 + }
3257 +
3258 + // Same for the matrix switch: a child list saved before the user
3259 + // excluded this content type still names it, and regenerating from
3260 + // that list would rewrite the file they asked not to have. Built-in
3261 + // aggregates ('posts', 'pages', ...) are not post type names, so
3262 + // post_type_exists() keeps this to real custom post types.
3263 + if (post_type_exists($type)
3264 + && !\ThinkRank\SEO\Content_Type_Settings::is_included_in_sitemap('post_type', $type, $settings)) {
3265 + continue;
3266 + }
3267 +
3268 + // The taxonomy counterpart of the two guards above (#690). A child
3269 + // list saved while a taxonomy was still included keeps naming it, so
3270 + // without this, excluding one in the matrix would still rewrite and
3271 + // re-list the file the user asked not to have. The built-in
3272 + // aggregates are named 'categories'/'tags' rather than
3273 + // 'category'/'post_tag', so taxonomy_exists() leaves them to the
3274 + // inclusion-flag check below.
3275 + $child_taxonomy = self::CHILD_TYPE_ALIASES[$type] ?? $type;
3276 + if (taxonomy_exists($child_taxonomy)
3277 + && (!$this->should_include_taxonomy($child_taxonomy)
3278 + || !\ThinkRank\SEO\Content_Type_Settings::is_included_in_sitemap('taxonomy', $child_taxonomy, $settings))) {
3279 + continue;
3280 + }
3281 +
3282 + // The built-in aggregates carry their switch in the inclusion flag
3283 + // rather than under a post type name, and they are the four most
3284 + // people actually use. build_segmented_sitemap_urls() drops a child
3285 + // whose flag is empty; regenerating from a list saved while it was
3286 + // still on has to make the same decision, or turning Posts, Pages,
3287 + // Categories or Tags off in the matrix rewrites and re-lists the
3288 + // very file it was asked to remove.
3289 + // An absent flag means "not configured", which every other reader
3290 + // treats as included; only a flag that is present and off excludes.
3291 + $aggregate_flag = array_search($type, self::INCLUSION_CHILD_TYPES, true);
3292 + if ($aggregate_flag !== false
3293 + && array_key_exists($aggregate_flag, $settings)
3294 + && empty($settings[$aggregate_flag])) {
3295 + continue;
3296 + }
3297 +
1208 3298 try {
1209 - $sitemap_xml = '';
1210 - $url_count = 0;
3299 + // The single "general"/"WordPress" sitemap is one un-paginated file
3300 + // (there is no index to reference extra pages); it no longer drops
3301 + // overflow URLs.
3302 + if ($type === 'general' || $type === 'wordpress') { // phpcs:ignore WordPress.WP.CapitalPDangit.MisspelledInText -- lowercase on purpose: this is the stored type slug.
3303 + $xml = $this->generate_sitemap($settings);
3304 + $this->write_sitemap_page($sitemap_config['url'], $xml, $type, $this->count_urls_in_xml($xml), $results, $index_children);
3305 + continue;
3306 + }
1211 3307
1212 - // Generate sitemap based on type
1213 - switch ($sitemap_config['type']) {
1214 - case 'index':
1215 - $sitemap_xml = $this->generate_sitemap_index($sitemap_urls);
1216 - $url_count = count(array_filter($sitemap_urls, fn($s) => $s['enabled'] && $s['type'] !== 'index'));
1217 - break;
1218 - case 'general':
1219 - case 'wordpress':
1220 - $sitemap_xml = $this->generate_sitemap($settings);
1221 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1222 - break;
1223 - case 'posts':
1224 - $sitemap_xml = $this->generate_post_sitemap('post', $settings);
1225 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1226 - break;
1227 - case 'pages':
1228 - $sitemap_xml = $this->generate_post_sitemap('page', $settings);
1229 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1230 - break;
1231 - case 'categories':
1232 - $sitemap_xml = $this->generate_taxonomy_sitemap('category', $settings);
1233 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1234 - break;
1235 - case 'products':
1236 - // Generate product-specific sitemap
1237 - if (post_type_exists('product')) {
1238 - $sitemap_xml = $this->generate_post_sitemap('product', $settings);
1239 - } else {
1240 - // Create empty sitemap if WooCommerce not installed
1241 - $sitemap_xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
3308 + $source = $this->stream_type_entries($type, $settings);
1242 3309
1243 - // Add XSL stylesheet only if styling is enabled
1244 - if (!empty($settings['enable_styling'])) {
1245 - $sitemap_xml .= '<?xml-stylesheet type="text/xsl" href="' . home_url('/wp-content/plugins/thinkrank/assets/sitemap.xsl') . '"?>' . "\n";
1246 - }
3310 + // Unknown type — fall back to a single general sitemap file.
3311 + if ($source === null) {
3312 + $xml = $this->generate_sitemap($settings);
3313 + $this->write_sitemap_page($sitemap_config['url'], $xml, $type, $this->count_urls_in_xml($xml), $results, $index_children);
3314 + continue;
3315 + }
1247 3316
1248 - $sitemap_xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
1249 - $sitemap_xml .= '</urlset>';
1250 - }
1251 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1252 - break;
1253 - case 'product_categories':
1254 - // Generate product category sitemap
1255 - if (taxonomy_exists('product_cat')) {
1256 - $sitemap_xml = $this->generate_taxonomy_sitemap('product_cat', $settings);
1257 - } else {
1258 - // Create empty sitemap if WooCommerce not installed
1259 - $sitemap_xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
3317 + // Stream the entries into files of at most $limit URLs, matching
3318 + // Rank Math: page 1 keeps the base filename, pages 2+ get a -N
3319 + // suffix, and every page is listed in the index. Buffering only one
3320 + // page at a time keeps peak memory bounded to $limit entries rather
3321 + // than every URL of the type.
3322 + $image_ns = $source['image_ns'];
3323 + $buffer = [];
3324 + $page = 0;
1260 3325
1261 - // Add XSL stylesheet only if styling is enabled
1262 - if (!empty($settings['enable_styling'])) {
1263 - $sitemap_xml .= '<?xml-stylesheet type="text/xsl" href="' . home_url('/wp-content/plugins/thinkrank/assets/sitemap.xsl') . '"?>' . "\n";
1264 - }
3326 + foreach ($source['entries'] as $entry) {
3327 + $buffer[] = $entry;
3328 + if (count($buffer) >= $limit) {
3329 + $page++;
3330 + $this->write_sitemap_page($this->paginate_url($sitemap_config['url'], $page), $this->wrap_urlset($buffer, $settings, $image_ns), $type, count($buffer), $results, $index_children);
3331 + $buffer = [];
3332 + }
3333 + }
1265 3334
1266 - $sitemap_xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
1267 - $sitemap_xml .= '</urlset>';
1268 - }
1269 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1270 - break;
1271 - default:
1272 - // Check if it's a custom post type
1273 - $post_types = get_post_types(['public' => true, '_builtin' => false], 'names');
1274 - if (in_array($sitemap_config['type'], $post_types)) {
1275 - $sitemap_xml = $this->generate_post_sitemap($sitemap_config['type'], $settings);
1276 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1277 - } else {
1278 - // Fallback to general sitemap
1279 - $sitemap_xml = $this->generate_sitemap($settings);
1280 - $url_count = $this->count_urls_in_xml($sitemap_xml);
1281 - }
1282 - break;
3335 + // Flush the trailing partial page, or a single empty page when the
3336 + // type had no entries at all (parity with the previous behavior of
3337 + // always writing at least one page per configured child).
3338 + if (!empty($buffer) || $page === 0) {
3339 + $page++;
3340 + $this->write_sitemap_page($this->paginate_url($sitemap_config['url'], $page), $this->wrap_urlset($buffer, $settings, $image_ns), $type, count($buffer), $results, $index_children);
1283 3341 }
1284 3342
1285 - // Extract filename from URL
1286 - $filename = basename(wp_parse_url($sitemap_config['url'], PHP_URL_PATH));
3343 + // Remove pages left over from a previous, larger generation.
3344 + $this->cleanup_stale_pages($sitemap_config['url'], $page, $settings);
1287 3345
1288 - // Save sitemap to file
1289 - if ($this->save_sitemap_to_file($sitemap_xml, $filename)) {
3346 + } catch (\Exception $e) {
3347 + $results['errors'][] = "Error generating {$type} sitemap: " . $e->getMessage();
3348 + $results['success'] = false;
3349 + }
3350 + }
3351 +
3352 + // Local business sitemap (parity with Rank Math's local-sitemap.xml).
3353 + // The physical file is written whenever a business identity is
3354 + // configured — independent of segmented vs single mode — and is also
3355 + // listed in the sitemap index when one exists.
3356 + try {
3357 + if ($this->regenerate_local_sitemap($settings) && $index_config !== null) {
3358 + $index_children[] = ['url' => '/local-sitemap.xml'];
3359 + }
3360 + } catch (\Exception $e) {
3361 + $results['errors'][] = 'Error generating local sitemap: ' . $e->getMessage();
3362 + $results['success'] = false;
3363 + }
3364 +
3365 + // Build the index last, from the child files actually generated, plus the
3366 + // sitemaps other plugins own: those serve their own URLs and write no
3367 + // file here, so they are appended to the index only (#104).
3368 + if ($index_config !== null) {
3369 + foreach (self::additional_sitemaps() as $extra) {
3370 + $index_children[] = ['url' => $extra];
3371 + }
3372 +
3373 + try {
3374 + $index_xml = $this->generate_sitemap_index($index_children, $settings);
3375 + $filename = basename(wp_parse_url($index_config['url'], PHP_URL_PATH));
3376 +
3377 + if ($this->save_sitemap_to_file($index_xml, $filename)) {
1290 3378 $results['sitemaps_generated'][] = [
1291 - 'url' => $sitemap_config['url'],
1292 - 'type' => $sitemap_config['type'],
1293 - 'filename' => $filename,
1294 - 'url_count' => $url_count
3379 + 'url' => $index_config['url'],
3380 + 'type' => 'index',
3381 + 'filename' => $filename,
3382 + 'url_count' => count($index_children),
1295 3383 ];
1296 - $results['total_urls'] += $url_count;
1297 3384 } else {
1298 - $error_message = "Failed to save sitemap: {$filename}";
1299 - $results['errors'][] = $error_message;
3385 + $results['errors'][] = "Failed to save sitemap: {$filename}";
1300 3386 $results['success'] = false;
1301 -
1302 - // File save error details available in results array
1303 3387 }
1304 -
1305 3388 } catch (\Exception $e) {
1306 - $results['errors'][] = "Error generating {$sitemap_config['type']} sitemap: " . $e->getMessage();
3389 + $results['errors'][] = 'Error generating index sitemap: ' . $e->getMessage();
1307 3390 $results['success'] = false;
1308 3391 }
1309 3392 }
1310 3393
3394 + // Remove segments that are no longer part of the set. Publishing was
3395 + // purely additive: a type that dropped out (Categories unticked, a CPT
3396 + // that stopped qualifying) simply stopped being overwritten, so its file
3397 + // kept serving and — until the index happened to be rebuilt — kept being
3398 + // listed in it. The index above is built from the children actually
3399 + // generated, so pruning here leaves disk and index agreeing.
3400 + $this->prune_orphaned_segments($settings, $results['sitemaps_generated']);
3401 +
1311 3402 return $results;
1312 3403 }
1313 3404
1314 3405 /**
1315 - * Generate sitemap index XML
3406 + * Delete published segment files that this run did not write.
1316 3407 *
1317 - * @since 1.0.0
1318 - * @param array $sitemap_urls Array of sitemap configurations
1319 - * @return string Sitemap index XML
3408 + * Only filenames this site could have published under its own url pattern
3409 + * are considered, so another plugin's or core's sitemap in the web root is
3410 + * never a candidate — the same reason cleanup does not glob 'sitemap-*.xml'.
3411 + *
3412 + * @since 1.31.0
3413 + *
3414 + * @param array $settings Sitemap settings (read for `custom_url_pattern`).
3415 + * @param array $generated Entries from $results['sitemaps_generated'].
3416 + * @return string[] Basenames removed.
1320 3417 */
1321 - private function generate_sitemap_index(array $sitemap_urls): string {
1322 - $settings = $this->get_settings('site');
1323 - $xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
3418 + private function prune_orphaned_segments(array $settings, array $generated): array {
3419 + // Rendering for a request, not publishing: there is nothing on disk
3420 + // this run owns, and a dynamic render must never delete the files a
3421 + // site's previous static mode left behind.
3422 + if ($this->is_collecting()) {
3423 + return [];
3424 + }
1324 3425
1325 - // Add XSL stylesheet only if styling is enabled
1326 - if (!empty($settings['enable_styling'])) {
1327 - $xml .= '<?xml-stylesheet type="text/xsl" href="' . home_url('/wp-content/plugins/thinkrank/assets/sitemap-index.xsl') . '"?>' . "\n";
3426 + $kept = [];
3427 + foreach ($generated as $entry) {
3428 + if (!empty($entry['filename'])) {
3429 + $kept[strtolower((string) $entry['filename'])] = true;
3430 + }
1328 3431 }
1329 - $xml .= '<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
1330 3432
1331 - $site_url = home_url();
3433 + // The current mode's primary and the local business sitemap are written
3434 + // by their own paths and are never orphans here.
3435 + $primary = strtolower(basename($this->get_primary_sitemap_filename($settings)));
3436 + $kept[$primary] = true;
3437 + $kept['local-sitemap.xml'] = true;
1332 3438
1333 - foreach ($sitemap_urls as $sitemap_config) {
1334 - if (!$sitemap_config['enabled'] || $sitemap_config['type'] === 'index') {
3439 + // The OTHER mode's primary is an orphan the moment the mode changes:
3440 + // index mode leaves sitemap.xml behind, flat mode leaves
3441 + // sitemap_index.xml and its children. Both used to be kept
3442 + // unconditionally, so the site served two sitemap trees and only ever
3443 + // refreshed one (#563). The children are already covered by the segment
3444 + // sweep below, which now sees them because the index is no longer kept.
3445 + $stale_primaries = array_diff(['sitemap.xml', 'sitemap_index.xml'], [$primary]);
3446 +
3447 + $removed = [];
3448 +
3449 + global $wp_filesystem;
3450 + if (!$wp_filesystem) {
3451 + require_once ABSPATH . 'wp-admin/includes/file.php';
3452 + WP_Filesystem();
3453 + }
3454 + if (!$wp_filesystem) {
3455 + return $removed;
3456 + }
3457 +
3458 + $candidates = array_merge($this->publishable_segment_filenames($settings), $stale_primaries);
3459 +
3460 + foreach ($candidates as $candidate) {
3461 + if (isset($kept[strtolower($candidate)])) {
1335 3462 continue;
1336 3463 }
1337 3464
1338 - $sitemap_url = $sitemap_config['url'];
1339 - if (!str_starts_with($sitemap_url, 'http')) {
1340 - $sitemap_url = $site_url . $sitemap_url;
3465 + if (!preg_match('/^(.*)\.xml$/i', $candidate, $m)) {
3466 + continue;
1341 3467 }
1342 3468
1343 - $xml .= " <sitemap>\n";
1344 - $xml .= " <loc>" . esc_url($sitemap_url) . "</loc>\n";
1345 - $xml .= " <lastmod>" . gmdate('c') . "</lastmod>\n";
1346 - $xml .= " </sitemap>\n";
3469 + // The base file plus its numeric pagination pages.
3470 + $paths = [ABSPATH . $candidate];
3471 + foreach (glob(ABSPATH . $m[1] . '-*.xml') ?: [] as $paged) {
3472 + if (preg_match('/^' . preg_quote($m[1], '/') . '-\d+\.xml$/i', basename($paged))) {
3473 + $paths[] = $paged;
3474 + }
3475 + }
3476 +
3477 + foreach ($paths as $path) {
3478 + if (!file_exists($path)) {
3479 + continue;
3480 + }
3481 + // A name we could have published is not proof we published
3482 + // this file: RankMath and core write at the same paths (#515).
3483 + if (!$this->webroot_sitemap_is_ours($path, $settings)) {
3484 + continue;
3485 + }
3486 + if ($wp_filesystem->delete($path)) {
3487 + $removed[] = basename($path);
3488 + }
3489 + }
1347 3490 }
1348 3491
1349 - $xml .= '</sitemapindex>';
3492 + return $removed;
3493 + }
1350 3494
1351 - return $xml;
3495 +
3496 + /**
3497 + * Collect the full (un-paginated) entry list for a content sitemap type.
3498 + *
3499 + * @since 1.14.0
3500 + *
3501 + * @param string $type Sitemap config type (posts, pages, categories, …)
3502 + * @param array $settings Sitemap settings
3503 + * @return array{entries: array<string>, image_ns: bool}|null Null for an
3504 + * unknown type (caller falls back to a general sitemap).
3505 + */
3506 + /**
3507 + * Write (or remove) the physical local-sitemap.xml file.
3508 + *
3509 + * Called from every sitemap regeneration path — segmented generation, the
3510 + * single-sitemap auto-regeneration, and the manual generate endpoint — so
3511 + * the local sitemap works regardless of whether the site uses a sitemap
3512 + * index. When no business identity is configured, any stale file is removed.
3513 + *
3514 + * @since 1.15.x
3515 + * @param array|null $settings Sitemap settings (falls back to saved site settings).
3516 + * @return bool True when the file was written, false when nothing was written.
3517 + */
3518 + public function regenerate_local_sitemap(?array $settings = null): bool {
3519 + $settings = $settings ?? $this->get_settings('site');
3520 + $entries = $this->collect_local_entries();
3521 +
3522 + if (empty($entries)) {
3523 + // Business identity was cleared — drop the file we left from
3524 + // before, but only ours. `local-sitemap.xml` is the name Rank Math
3525 + // publishes under too (this method mirrors it deliberately), so on
3526 + // a migrated site the file at that path may never have been ours
3527 + // to delete (#515).
3528 + $path = ABSPATH . 'local-sitemap.xml';
3529 + if (!$this->is_collecting() && file_exists($path) && $this->webroot_sitemap_is_ours($path, $settings)) {
3530 + wp_delete_file($path);
3531 + }
3532 + return false;
3533 + }
3534 +
3535 + $xml = $this->wrap_urlset($entries, $settings, false);
3536 + return $this->save_sitemap_to_file($xml, 'local-sitemap.xml');
1352 3537 }
1353 3538
1354 3539 /**
1355 - * Generate sitemap for specific post type
3540 + * Build the local business sitemap entries.
1356 3541 *
1357 - * @since 1.0.0
1358 - * @param string $post_type Post type to generate sitemap for
1359 - * @param array $settings Sitemap settings
1360 - * @return string Sitemap XML
3542 + * Returns a single URL entry pointing at the on-site page that carries the
3543 + * business's LocalBusiness/Organization schema (the configured business URL
3544 + * when it's on this site, otherwise the homepage). Gated — like Rank Math's
3545 + * `local-sitemap.xml` — on a business (non-person) type being configured
3546 + * with an actual location (address or geo coordinates). Returns an empty
3547 + * array when no business location is set, so no empty local sitemap is
3548 + * written or added to the index.
3549 + *
3550 + * @since 1.15.x
3551 + * @return array Zero or one URL entry
1361 3552 */
1362 - private function generate_post_sitemap(string $post_type, array $settings): string {
1363 - $xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
3553 + /**
3554 + * Does this site publish a local business sitemap right now?
3555 + *
3556 + * The same gate {@see self::regenerate_local_sitemap()} applies, asked
3557 + * without writing anything. Callers that need to know whether the document
3558 + * exists must not test the filesystem: under dynamic delivery it is served
3559 + * from PHP and there is no file, which is how `local-sitemap.xml` came to be
3560 + * dropped from robots.txt on exactly those sites (#752).
3561 + *
3562 + * @since 2.9.0
3563 + *
3564 + * @return bool True when the local sitemap has content to publish.
3565 + */
3566 + public function publishes_local_sitemap(): bool {
3567 + return !empty($this->collect_local_entries());
3568 + }
1364 3569
1365 - // Add XSL stylesheet only if styling is enabled
1366 - if (!empty($settings['enable_styling'])) {
1367 - $xml .= '<?xml-stylesheet type="text/xsl" href="' . home_url('/wp-content/plugins/thinkrank/assets/sitemap.xsl') . '"?>' . "\n";
3570 + private function collect_local_entries(): array {
3571 + if (!class_exists('ThinkRank\\SEO\\Site_Identity_Manager')) {
3572 + require_once THINKRANK_PLUGIN_DIR . 'includes/seo/class-site-identity-manager.php';
1368 3573 }
1369 3574
1370 - // Add image namespace if images are enabled
1371 - if (!empty($settings['include_images'])) {
1372 - $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1">' . "\n";
3575 + $identity = (new \ThinkRank\SEO\Site_Identity_Manager())->get_settings('site');
3576 +
3577 + // Gate like Rank Math's local sitemap: a business (non-person) identity
3578 + // is configured. We only emit a single URL (the location page), so a
3579 + // full postal address is NOT required — requiring one wrongly excluded
3580 + // migrated sites, since the Rank Math importer carries over business
3581 + // type/name/phone but not the address. Personal sites, and sites with no
3582 + // business identity at all, get no local sitemap.
3583 + $business_type = strtolower((string) ($identity['business_type'] ?? ''));
3584 + if ($business_type === 'person') {
3585 + return [];
3586 + }
3587 + if ($business_type === '' && empty($identity['business_name'])) {
3588 + return [];
3589 + }
3590 +
3591 + // Prefer the configured business URL when it points at this site;
3592 + // otherwise fall back to the homepage (which outputs the schema).
3593 + $location_url = home_url('/');
3594 + if (!empty($identity['business_url'])) {
3595 + $candidate = esc_url_raw((string) $identity['business_url']);
3596 + if ($candidate && wp_parse_url($candidate, PHP_URL_HOST) === wp_parse_url(home_url(), PHP_URL_HOST)) {
3597 + $location_url = $candidate;
3598 + }
3599 + }
3600 +
3601 + // Omit lastmod — no real modification source for the local business URL.
3602 + return [$this->generate_url_entry($location_url, '', 0.8, 'weekly')];
3603 + }
3604 +
3605 + /**
3606 + * Resolve a streaming entry source for a sitemap type.
3607 + *
3608 + * Returns an iterable that yields the type's <url> entries one at a time
3609 + * (so the paginator never materializes the whole type), the image-namespace
3610 + * flag, or null when the type isn't one we build (caller falls back to a
3611 + * single general sitemap). Entry order matches the previous array-based
3612 + * collect_type_entries() exactly.
3613 + *
3614 + * @param string $type Sitemap type.
3615 + * @param array $settings Sitemap settings.
3616 + * @return array{entries: iterable<string>, image_ns: bool}|null
3617 + */
3618 + private function stream_type_entries(string $type, array $settings): ?array {
3619 + switch ($type) {
3620 + case 'posts':
3621 + return ['entries' => $this->collect_post_entries_iter(['post'], $settings), 'image_ns' => true];
3622 +
3623 + case 'pages':
3624 + // The homepage lives in the pages sitemap (parity with prior
3625 + // output) and is emitted first; collect_post_entries_iter()
3626 + // already excludes the static front page, so there's no duplicate.
3627 + $entries = (function () use ($settings) {
3628 + yield $this->generate_url_entry(home_url('/'), $this->get_homepage_lastmod(), 1.0, 'daily');
3629 + yield from $this->collect_post_entries_iter(['page'], $settings);
3630 + })();
3631 + return ['entries' => $entries, 'image_ns' => true];
3632 +
3633 + case 'categories':
3634 + return ['entries' => $this->collect_taxonomy_entries_iter('category', $settings), 'image_ns' => false];
3635 +
3636 + case 'tags':
3637 + return ['entries' => $this->collect_taxonomy_entries_iter('post_tag', $settings), 'image_ns' => false];
3638 +
3639 + case 'products':
3640 + $entries = post_type_exists('product') ? $this->collect_post_entries_iter(['product'], $settings) : [];
3641 + return ['entries' => $entries, 'image_ns' => true];
3642 +
3643 + default:
3644 + // Resolve a preset's display name to the object it streams, so
3645 + // 'product_categories' is an ordinary taxonomy child rather than
3646 + // a case of its own (#690).
3647 + $alias = self::CHILD_TYPE_ALIASES[$type] ?? null;
3648 + $object = $alias ?? $type;
3649 +
3650 + $custom_post_types = get_post_types(['public' => true, '_builtin' => false], 'names');
3651 + if (in_array($object, $custom_post_types, true)) {
3652 + return ['entries' => $this->collect_post_entries_iter([$object], $settings), 'image_ns' => true];
3653 + }
3654 +
3655 + // Custom taxonomies reach index mode here, streamed through the
3656 + // same iterator flat mode uses so the two modes emit identical
3657 + // URLs for the same settings.
3658 + if (taxonomy_exists($object) && $this->should_include_taxonomy($object)) {
3659 + return ['entries' => $this->collect_taxonomy_entries_iter($object, $settings), 'image_ns' => false];
3660 + }
3661 +
3662 + // An aliased child whose object is gone (WooCommerce deactivated)
3663 + // keeps writing the empty file it always wrote. Returning null
3664 + // here would hand it the whole-site fallback instead, dumping
3665 + // every URL on the site into a file named for products.
3666 + //
3667 + // A registered taxonomy this generator will not emit
3668 + // (`post_format`, `nav_menu`, a non-public one) needs the same
3669 + // answer for the same reason. generate_multiple_sitemaps()
3670 + // skips those before they reach here, so nothing takes this
3671 + // path today — but it is the one branch where falling through
3672 + // to null is silently catastrophic rather than merely wrong,
3673 + // and the guard keeping it unreachable lives in another method.
3674 + if ($alias !== null || taxonomy_exists($object)) {
3675 + return ['entries' => [], 'image_ns' => false];
3676 + }
3677 +
3678 + return null;
3679 + }
3680 + }
3681 +
3682 + /**
3683 + * Write one sitemap page file and record it in the results + index child list.
3684 + *
3685 + * @since 1.14.0
3686 + *
3687 + * @param string $url Sitemap page URL
3688 + * @param string $xml Sitemap XML
3689 + * @param string $type Sitemap type (for reporting)
3690 + * @param int $url_count Number of URLs in this page
3691 + * @param array $results Results accumulator (by reference)
3692 + * @param array $index_children Index child list (by reference)
3693 + * @return void
3694 + */
3695 + private function write_sitemap_page(string $url, string $xml, string $type, int $url_count, array &$results, array &$index_children): void {
3696 + $filename = basename(wp_parse_url($url, PHP_URL_PATH));
3697 +
3698 + if ($this->save_sitemap_to_file($xml, $filename)) {
3699 + $results['sitemaps_generated'][] = [
3700 + 'url' => $url,
3701 + 'type' => $type,
3702 + 'filename' => $filename,
3703 + 'url_count' => $url_count,
3704 + ];
3705 + $results['total_urls'] += $url_count;
3706 + $index_children[] = ['url' => $url];
1373 3707 } else {
1374 - $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
3708 + $results['errors'][] = "Failed to save sitemap: {$filename}";
3709 + $results['success'] = false;
1375 3710 }
3711 + }
1376 3712
1377 - // Add homepage only for general sitemap
1378 - if ($post_type === 'page') {
1379 - $xml .= $this->generate_url_entry(home_url('/'), gmdate('c'), 1.0, 'daily');
3713 + /**
3714 + * Delete pagination files left over when a type shrinks to fewer pages.
3715 + *
3716 + * For a base URL like /sitemap-posts.xml, removes sitemap-posts-N.xml files
3717 + * whose page number N exceeds the current page count. Page 1 (the base file,
3718 + * which has no -N suffix) is never touched.
3719 + *
3720 + * @since 1.14.0
3721 + *
3722 + * @since 2.1.1 Each candidate must pass the content ownership test — a
3723 + * `-N.xml` page of another plugin's sitemap paginates our
3724 + * stem exactly as ours does (#515).
3725 + *
3726 + * @param string $base_url Base (page 1) sitemap URL
3727 + * @param int $current_pages Number of pages generated this run
3728 + * @param array $settings Sitemap settings, for the ownership test.
3729 + * @return void
3730 + */
3731 + private function cleanup_stale_pages(string $base_url, int $current_pages, array $settings): void {
3732 + // See prune_orphaned_segments(): a dynamic render deletes nothing.
3733 + if ($this->is_collecting()) {
3734 + return;
1380 3735 }
1381 3736
1382 - // Add posts/pages of specific type
1383 - $xml .= $this->generate_post_entries($post_type, $settings);
3737 + $filename = basename(wp_parse_url($base_url, PHP_URL_PATH));
3738 + if (!preg_match('/^(.*)\.xml$/i', $filename, $m)) {
3739 + return;
3740 + }
3741 + $stem = $m[1];
1384 3742
1385 - $xml .= '</urlset>';
1386 - return $xml;
3743 + global $wp_filesystem;
3744 + if (!$wp_filesystem) {
3745 + require_once ABSPATH . 'wp-admin/includes/file.php';
3746 + WP_Filesystem();
3747 + }
3748 + if (!$wp_filesystem) {
3749 + return;
3750 + }
3751 +
3752 + $candidates = glob(ABSPATH . $stem . '-*.xml') ?: [];
3753 + foreach ($candidates as $path) {
3754 + // Only delete numeric-suffixed pages beyond the current count.
3755 + if (preg_match('/-(\d+)\.xml$/', basename($path), $mm)
3756 + && (int) $mm[1] > $current_pages
3757 + && $this->webroot_sitemap_is_ours($path, $settings)) {
3758 + $wp_filesystem->delete($path);
3759 + }
3760 + }
1387 3761 }
1388 3762
1389 3763 /**
1390 - * Generate sitemap for specific taxonomy
3764 + * Sitemap URLs contributed by other plugins.
1391 3765 *
1392 - * @since 1.0.0
1393 - * @param string $taxonomy Taxonomy to generate sitemap for
3766 + * ThinkRank owns the sitemap index and the robots.txt `Sitemap:` lines, so a
3767 + * companion plugin that serves its own sitemap — Pro's news and video
3768 + * sitemaps, for instance — had no way to be discovered: it appeared in
3769 + * neither, leaving manual Search Console submission as the only route in
3770 + * (#104). Registering here puts a sitemap in the index when one exists, and
3771 + * in robots.txt when it does not.
3772 + *
3773 + * Callers get root-relative paths. Entries are normalised to a leading
3774 + * slash, de-duplicated, and anything that is not a non-empty string is
3775 + * dropped, so one badly-behaved callback cannot produce a malformed index.
3776 + *
3777 + * @since 2.3.1
3778 + *
3779 + * @return string[] Root-relative sitemap paths, e.g. ['/news-sitemap.xml'].
3780 + */
3781 + public static function additional_sitemaps(): array {
3782 + /**
3783 + * Filters the sitemaps contributed by other plugins.
3784 + *
3785 + * @since 2.3.1
3786 + *
3787 + * @param string[] $sitemaps Root-relative sitemap paths.
3788 + */
3789 + $sitemaps = apply_filters('thinkrank_additional_sitemaps', []);
3790 +
3791 + if (!is_array($sitemaps)) {
3792 + return [];
3793 + }
3794 +
3795 + // Both consumers resolve an entry with home_url(), which prefixes the
3796 + // install's own directory. Everything below is measured against that so
3797 + // an absolute URL is reduced to what home_url() will put back.
3798 + $home = wp_parse_url(home_url('/'));
3799 + $home_host = strtolower((string) ($home['host'] ?? ''));
3800 + $home_path = '/' . trim((string) ($home['path'] ?? ''), '/');
3801 +
3802 + $clean = [];
3803 + foreach ($sitemaps as $sitemap) {
3804 + if (!is_string($sitemap)) {
3805 + continue;
3806 + }
3807 +
3808 + $sitemap = trim($sitemap);
3809 + if ('' === $sitemap) {
3810 + continue;
3811 + }
3812 +
3813 + // A full URL on this site is accepted and reduced to the part
3814 + // home_url() does not already supply, so a caller that reached for
3815 + // home_url() still lands in the right place — including on a
3816 + // subdirectory install, where keeping the whole path would repeat
3817 + // the directory. A URL on another host is dropped rather than
3818 + // rewritten: the sitemaps protocol will not accept a cross-host
3819 + // child anyway, and reusing its path would advertise a URL on this
3820 + // site that does not exist.
3821 + if (preg_match('#^(https?:)?//#i', $sitemap)) {
3822 + $parts = wp_parse_url('//' === substr($sitemap, 0, 2) ? 'https:' . $sitemap : $sitemap);
3823 + if (!is_array($parts)) {
3824 + continue;
3825 + }
3826 +
3827 + if (strtolower((string) ($parts['host'] ?? '')) !== $home_host) {
3828 + continue;
3829 + }
3830 +
3831 + $path = (string) ($parts['path'] ?? '');
3832 + if ('' === $path) {
3833 + continue;
3834 + }
3835 +
3836 + if ('/' !== $home_path && ($path === $home_path || 0 === strpos($path, $home_path . '/'))) {
3837 + $path = substr($path, strlen($home_path));
3838 + }
3839 +
3840 + // A sitemap served from a query string keeps it; dropping the
3841 + // query would point at a different document.
3842 + $query = (string) ($parts['query'] ?? '');
3843 + $sitemap = $path . ('' !== $query ? '?' . $query : '');
3844 + }
3845 +
3846 + $clean[] = '/' . ltrim($sitemap, '/');
3847 + }
3848 +
3849 + return array_values(array_unique($clean));
3850 + }
3851 +
3852 + /**
3853 + * Generate sitemap index XML from the list of child sitemap files produced
3854 + * during generation (each already resolved to its final, possibly paginated,
3855 + * URL).
3856 + *
3857 + * @since 1.0.0 (signature updated 1.14.0)
3858 + * @param array $children Array of ['url' => string] child sitemap entries
1394 3859 * @param array $settings Sitemap settings
1395 - * @return string Sitemap XML
3860 + * @return string Sitemap index XML
1396 3861 */
1397 - private function generate_taxonomy_sitemap(string $taxonomy, array $settings): string {
1398 - $xml = '<?xml version="1.0" encoding="UTF-8"?>' . "\n";
3862 + private function generate_sitemap_index(array $children, array $settings): string {
3863 + $xml = $this->xml_prolog($settings, 'index');
3864 + $xml .= '<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
1399 3865
1400 - // Add XSL stylesheet only if styling is enabled
1401 - if (!empty($settings['enable_styling'])) {
1402 - $xml .= '<?xml-stylesheet type="text/xsl" href="' . home_url('/wp-content/plugins/thinkrank/assets/sitemap.xsl') . '"?>' . "\n";
3866 + $site_url = home_url();
3867 +
3868 + foreach ($children as $child) {
3869 + $sitemap_url = $child['url'] ?? '';
3870 + if ($sitemap_url === '') {
3871 + continue;
3872 + }
3873 + if (!str_starts_with($sitemap_url, 'http')) {
3874 + $sitemap_url = $site_url . $sitemap_url;
3875 + }
3876 +
3877 + $xml .= " <sitemap>\n";
3878 + $xml .= " <loc>" . esc_url(Url_Scheme::apply($sitemap_url)) . "</loc>\n";
3879 + $xml .= " <lastmod>" . gmdate('c') . "</lastmod>\n";
3880 + $xml .= " </sitemap>\n";
1403 3881 }
1404 - $xml .= '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' . "\n";
1405 3882
1406 - // Add taxonomy terms
1407 - $xml .= $this->generate_taxonomy_entries($taxonomy, $settings);
3883 + $xml .= '</sitemapindex>';
1408 3884
1409 - $xml .= '</urlset>';
1410 3885 return $xml;
1411 3886 }
1412 3887
1413 3888 /**
@@ -1418,35 +3893,8 @@
1418 3893 * @return int Number of URLs
1419 3894 */
1420 3895 private function count_urls_in_xml(string $sitemap_xml): int {
1421 3896 return substr_count($sitemap_xml, '<url>');
1422 - }
1423 -
1424 - /**
1425 - * Ping search engines about sitemap update
1426 - *
1427 - * @since 1.0.0
1428 - * @return void
1429 - */
1430 - private function ping_search_engines(): void {
1431 - $sitemap_url = home_url('/sitemap.xml');
1432 -
1433 - $ping_urls = [
1434 - 'google' => 'https://www.google.com/ping?sitemap=' . urlencode($sitemap_url),
1435 - 'bing' => 'https://www.bing.com/ping?sitemap=' . urlencode($sitemap_url)
1436 - ];
1437 -
1438 - foreach ($ping_urls as $engine => $ping_url) {
1439 - // Use wp_remote_get with timeout to prevent hanging
1440 - $response = wp_remote_get($ping_url, [
1441 - 'timeout' => 10,
1442 - 'blocking' => false // Non-blocking to prevent delays
1443 - ]);
1444 -
1445 - if (is_wp_error($response)) {
1446 - // Search engine ping failed - error details available in WP_Error response
1447 - }
1448 - }
1449 3897 }
1450 3898
1451 3899 /**
1452 3900 * Validate and sanitize exclude posts input