← All changes | classes/Visualizer/Source/Query.php +64 -3 3.10.1 → 3.11.7 View file →

		@@ -59,14 +59,31 @@
59	59	* @param int $chart_id The chart id.
60	60	* @param array $params Any additional parameters (e.g. for connecting to a remote db).
61	61	*/
62	62	public function __construct( $query = null, $chart_id = null, $params = null ) {
63		- $this->_query = $query;
	63	+ $this->_query = $this->strip_sql_comments( $query );
64	64	$this->_chart_id = $chart_id;
65	65	$this->_params = $params;
66	66	}
67	67
68	68	/**
	69	+ * Strips SQL comments from the query.
	70	+ *
	71	+ * @param string $query The query.
	72	+ *
	73	+ * @return string
	74	+ */
	75	+ private function strip_sql_comments( $query = '' ) {
	76	+ if ( empty( $query ) ) {
	77	+ return $query;
	78	+ }
	79	+
	80	+ // Regex https://regex101.com/r/xd5Vrg/1
	81	+ $sql_comments_regex = '@(--[^\r\n]*)|(\#[^\r\n]*)|(/\*[\w\W]*?(?=\*/)\*/)@ms';
	82	+ return trim( preg_replace( $sql_comments_regex, '', $query ) );
	83	+ }
	84	+
	85	+ /**
69	86	* Fetches information from source, parses it and builds series and data arrays.
70	87	*
71	88	* @param bool $as_html Should the result be fetched as an HTML table or as an object.
72	89	* @param bool $results_as_numeric_array Should the result be fetched as ARRAY_N instead of ARRAY_A.
		@@ -78,14 +95,53 @@
78	95	if ( empty( $this->_query ) ) {
79	96	return false;
80	97	}
81	98
82		- // only select queries allowed.
83		- if ( preg_match( '/^\s*(insert|delete|update|replace|create|alter|drop|truncate)\s/i', $this->_query ) ) {
	99	+ // only select queries allowed. must start with SELECT keyword.
	100	+ if ( ! preg_match( '/^(\bselect\b)\s/i', $this->_query ) ) {
84	101	$this->_error = __( 'Only SELECT queries are allowed', 'visualizer' );
85	102	return false;
86	103	}
87	104
	105	+ // if previous check passed, check for disallowed query parts to prevent subqueries and other harmful queries.
	106	+ $disallow_query_parts = array(
	107	+ 'CREATE',
	108	+ 'ALTER',
	109	+ 'TRUNCATE',
	110	+ 'DROP',
	111	+
	112	+ 'INSERT',
	113	+ 'DELETE',
	114	+ 'UPDATE',
	115	+ 'REPLACE',
	116	+
	117	+ 'RENAME',
	118	+ 'COMMIT',
	119	+ 'ROLLBACK',
	120	+ 'MERGE',
	121	+ 'CALL',
	122	+ 'EXPLAIN',
	123	+ 'LOCK',
	124	+ 'GRANT',
	125	+ 'REVOKE',
	126	+ 'SAVEPOINT',
	127	+ 'TRANSACTION',
	128	+ 'SET',
	129	+ );
	130	+ $disallow_regex = implode(
	131	+ '|',
	132	+ array_map(
	133	+ function ( $value ) {
	134	+ return '\b' . $value . '\b';
	135	+ }, $disallow_query_parts
	136	+ )
	137	+ );
	138	+
	139	+ if ( preg_match( '/(' . $disallow_regex . ')/i', $this->_query) !== 0 ) {
	140	+ $this->_error = __( 'Only SELECT queries are allowed', 'visualizer' );
	141	+ return false;
	142	+ }
	143	+
88	144	// impose a limit if no limit clause is provided.
89	145	if ( strpos( strtolower( $this->_query ), ' limit ' ) === false ) {
90	146	$this->_query .= ' LIMIT ' . apply_filters( 'visualizer_sql_query_limit', 1000, $this->_chart_id );
91	147	}
		@@ -119,8 +175,13 @@
119	175	$wpdb->show_errors();
120	176
121	177	if ( $raw_results ) {
122	178	return $rows;
	179	+ }
	180	+
	181	+ if ( $wpdb->last_error ) {
	182	+ $this->_error = $wpdb->last_error;
	183	+ return [];
123	184	}
124	185
125	186	if ( $rows ) {
126	187	$results = array();