PluginProbe
WP Data Access – App Builder for Tables, Forms, Dashboards, Charts & Maps / 5.5.87
WP Data Access – App Builder for Tables, Forms, Dashboards, Charts & Maps v5.5.87
5.5.87 5.5.85 5.5.84 5.5.83 5.5.82 5.5.81 5.5.80 5.5.79 5.5.77 5.5.76 5.5.75 5.5.73 5.5.72 5.5.22 5.5.23 5.5.29 5.5.3 5.5.31 5.5.32 5.5.34 5.5.35 5.5.36 5.5.37 5.5.4 5.5.40 All 162 releases
← All changes | WPDataAccess/API/WPDA_Apps.php +219 -68 5.5.80 → 5.5.87 View file →
@@ -3,9 +3,8 @@
3 3 namespace WPDataAccess\API;
4 4
5 5 use stdClass;
6 6 use WPDataAccess\Connection\WPDADB;
7 -use WPDataAccess\Data_Apps\WPDA_PWA;
8 7 use WPDataAccess\Data_Dictionary\WPDA_List_Columns_Cache;
9 8 use WPDataAccess\Plugin_Table_Models\WPDA_App_Container_Model;
10 9 use WPDataAccess\Plugin_Table_Models\WPDA_App_Apps_Model;
11 10 use WPDataAccess\Plugin_Table_Models\WPDA_App_Model;
@@ -281,9 +280,13 @@
281 280 'map' => array(
282 281 'required' => false,
283 282 'type' => 'string',
284 283 'description' => __( 'Map settings - JSON string', 'wp-data-access' ),
285 - 'sanitize_callback' => 'wp_kses_post',
284 + 'sanitize_callback' => function ( $param ) {
285 + $sanitized_settings = $this->sanitize_settings( json_decode( (string) $param, true ) );
286 + // Save sanitized JSON as string
287 + return json_encode( $sanitized_settings );
288 + },
286 289 'validate_callback' => 'rest_validate_request_arg',
287 290 ),
288 291 'chart' => array(
289 292 'required' => false,
@@ -515,8 +518,15 @@
515 518 'permission_callback' => '__return_true',
516 519 'args' => array(
517 520 'dbs_source' => $this->get_param( 'dbs' ),
518 521 'dbs_destination' => $this->get_param( 'dbs' ),
522 + 'appDbId' => array(
523 + 'required' => false,
524 + 'type' => 'integer',
525 + 'description' => __( 'App Id', 'wp-data-access' ),
526 + 'sanitize_callback' => 'absint',
527 + 'validate_callback' => 'rest_validate_request_arg',
528 + ),
519 529 ),
520 530 ) );
521 531 register_rest_route( WPDA_API::WPDA_NAMESPACE, 'app/lang/get', array(
522 532 'methods' => array('POST'),
@@ -565,8 +575,24 @@
565 575 'validate_callback' => 'rest_validate_request_arg',
566 576 ),
567 577 ),
568 578 ) );
579 + register_rest_route( WPDA_API::WPDA_NAMESPACE, 'app/proxy', array(
580 + 'methods' => array('GET'),
581 + 'callback' => array($this, 'app_proxy'),
582 + 'permission_callback' => '__return_true',
583 + 'args' => array(
584 + 'app_id' => $this->get_param( 'app_id' ),
585 + 'cnt_id' => $this->get_param( 'cnt_id' ),
586 + 'url' => array(
587 + 'required' => true,
588 + 'type' => 'string',
589 + 'description' => __( 'URL', 'wp-data-access' ),
590 + 'sanitize_callback' => 'sanitize_text_field',
591 + 'validate_callback' => 'rest_validate_request_arg',
592 + ),
593 + ),
594 + ) );
569 595 // PWA
570 596 register_rest_route( WPDA_API::WPDA_NAMESPACE, 'app/pwa/get', array(
571 597 'methods' => array('POST'),
572 598 'callback' => array($this, 'app_wpa_get'),
@@ -626,8 +652,24 @@
626 652 ),
627 653 ) );
628 654 }
629 655
656 + public function app_proxy( $request ) {
657 + wp_die();
658 + }
659 +
660 + private function detect_image_mime( $body ) {
661 + return null;
662 + }
663 +
664 + private function is_safe_remote_url( $url, $allowed_hosts ) {
665 + return false;
666 + }
667 +
668 + private function is_public_ip( $ip ) {
669 + return false;
670 + }
671 +
630 672 public function app_download( $request ) {
631 673 return $this->WPDA_Rest_Response( 'OK' );
632 674 }
633 675
@@ -1014,8 +1056,27 @@
1014 1056 }
1015 1057 }
1016 1058 }
1017 1059 }
1060 + if ( isset( $settings['columns'] ) && is_array( $settings['columns'] ) && '1' !== $rel_tab ) {
1061 + $queryable_columns = array();
1062 + if ( isset( $settings['table']['columns'] ) && is_array( $settings['table']['columns'] ) ) {
1063 + foreach ( $settings['table']['columns'] as $column ) {
1064 + if ( isset( $column['queryable'] ) && $column['queryable'] ) {
1065 + $queryable_columns[] = $column['columnName'];
1066 + }
1067 + }
1068 + }
1069 + $app_columns = array();
1070 + foreach ( $settings['columns'] as $column ) {
1071 + if ( isset( $column['columnName'], $column['isSelected'] ) && $column['isSelected'] ) {
1072 + $app_columns[$column['columnName']] = in_array( $column['columnName'], $queryable_columns );
1073 + }
1074 + }
1075 + if ( 0 < count( $app_columns ) ) {
1076 + $col = $app_columns;
1077 + }
1078 + }
1018 1079 $table_api = new WPDA_Table();
1019 1080 return $table_api->select(
1020 1081 $dbs,
1021 1082 $tbl,
@@ -1067,8 +1128,9 @@
1067 1128 return array_map( function ( $value ) {
1068 1129 if ( true === $value['isSelected'] ) {
1069 1130 return $value['columnName'];
1070 1131 }
1132 + return null;
1071 1133 }, $columns );
1072 1134 }
1073 1135
1074 1136 public function app_get( $request ) {
@@ -1342,8 +1404,12 @@
1342 1404 }
1343 1405 }
1344 1406
1345 1407 public function app_lookup_dbs( $request ) {
1408 + // Only admins are allowed to configre lookups
1409 + if ( !$this->current_user_can_access() ) {
1410 + return $this->unauthorized();
1411 + }
1346 1412 $app_id = $request->get_param( 'app_id' );
1347 1413 $cnt_id = $request->get_param( 'cnt_id' );
1348 1414 if ( $this->check_app_access(
1349 1415 $app_id,
@@ -1366,8 +1432,12 @@
1366 1432 }
1367 1433 }
1368 1434
1369 1435 public function app_lookup_tbl( $request ) {
1436 + // Only admins are allowed to configre lookups
1437 + if ( !$this->current_user_can_access() ) {
1438 + return $this->unauthorized();
1439 + }
1370 1440 $app_id = $request->get_param( 'app_id' );
1371 1441 $cnt_id = $request->get_param( 'cnt_id' );
1372 1442 $dbs = $request->get_param( 'dbs' );
1373 1443 if ( $this->check_app_access(
@@ -1391,8 +1461,12 @@
1391 1461 }
1392 1462 }
1393 1463
1394 1464 public function app_lookup_cls( $request ) {
1465 + // Only admins are allowed to configre lookups
1466 + if ( !$this->current_user_can_access() ) {
1467 + return $this->unauthorized();
1468 + }
1395 1469 $app_id = $request->get_param( 'app_id' );
1396 1470 $cnt_id = $request->get_param( 'cnt_id' );
1397 1471 $dbs = $request->get_param( 'dbs' );
1398 1472 $tbl = $request->get_param( 'tbl' );
@@ -1441,8 +1515,68 @@
1441 1515 $renamed = 0;
1442 1516 $debug_mode = 'on' === WPDA::get_option( WPDA::OPTION_PLUGIN_DEBUG );
1443 1517 $debug = array();
1444 1518 $errors = array();
1519 + if ( $request->get_param( 'appDbId' ) ) {
1520 + // Update app only
1521 + $appDbId = $request->get_param( 'appDbId' );
1522 + // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching, WordPress.DB.PreparedSQL.NotPrepared -- plugin table
1523 + $sql = $wpdb->prepare( "update `{$wpdb->prefix}wpda_app_container` set `cnt_dbs` = %s where `cnt_dbs` = %s and app_id = %d", array($dbs_destination, $dbs_source, $appDbId) );
1524 + $result = $wpdb->query( $sql );
1525 + // phpcs:enable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching, WordPress.DB.PreparedSQL.NotPrepared
1526 + $renamed += $result;
1527 + if ( $debug_mode ) {
1528 + $debug[] = array(
1529 + 'sql' => $sql,
1530 + 'result' => $result,
1531 + );
1532 + }
1533 + if ( '' !== $wpdb->last_error ) {
1534 + $errors[] = array(
1535 + 'sql' => $sql,
1536 + 'error' => $wpdb->last_error,
1537 + );
1538 + }
1539 + $sql_content = array("update `{$wpdb->prefix}wpda_app_container` set `cnt_table` = replace(`cnt_table`, '\"dbs\":\"%1s\"', '\"dbs\":\"%1s\"') where `cnt_table` like '%\"dbs\":\"%1s\"%' and app_id = %d", "update `{$wpdb->prefix}wpda_app_container` set `cnt_form` = replace(`cnt_form`, '\"dbs\":\"%1s\"', '\"dbs\":\"%1s\"') where `cnt_form` like '%\"dbs\":\"%1s\"%' and app_id = %d");
1540 + foreach ( $sql_content as $sql ) {
1541 + // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching, WordPress.DB.PreparedSQL.NotPrepared -- plugin table
1542 + $result = $wpdb->query( $wpdb->prepare( $sql, array(
1543 + $dbs_source,
1544 + $dbs_destination,
1545 + $dbs_source,
1546 + $appDbId
1547 + ) ) );
1548 + $renamed += $result;
1549 + if ( $debug_mode ) {
1550 + $debug[] = array(
1551 + 'sql' => $sql,
1552 + 'result' => $result,
1553 + );
1554 + }
1555 + if ( '' !== $wpdb->last_error ) {
1556 + $errors[] = array(
1557 + 'sql' => $sql,
1558 + 'error' => $wpdb->last_error,
1559 + );
1560 + }
1561 + }
1562 + $context = array();
1563 + if ( $debug_mode ) {
1564 + $context['debug'] = $debug;
1565 + }
1566 + if ( 0 < count( $errors ) ) {
1567 + $context['errors'] = $errors;
1568 + return new \WP_Error('error', 'Failed renaming database', array(
1569 + 'status' => 401,
1570 + 'context' => $context,
1571 + ));
1572 + }
1573 + return $this->WPDA_Rest_Response( sprintf(
1574 + /* translators: %s = number of database substitutions */
1575 + __( 'Successfully renamed %s database occurrences', 'wp-data-access' ),
1576 + $renamed
1577 + ), null, $context );
1578 + }
1445 1579 // Rename all occurrences in repository tables and apps
1446 1580 $sqls = array(
1447 1581 "update `{$wpdb->prefix}wpda_publisher` set `pub_schema_name` = %s where `pub_schema_name` = %s",
1448 1582 "update `{$wpdb->prefix}wpda_project_page` set `page_schema_name` = %s where `page_schema_name` = %s",
@@ -1539,14 +1673,23 @@
1539 1673 ));
1540 1674 }
1541 1675 $suppress = $wpdadb->suppress_errors( true );
1542 1676 $chart_data = $wpdadb->get_results( $query, 'ARRAY_A' );
1677 + // Add an * before each label to support numeric labels
1678 + $chart_data_converted = array();
1679 + foreach ( $chart_data as $data ) {
1680 + $row = array();
1681 + foreach ( $data as $key => $value ) {
1682 + $row['*' . $key] = $value;
1683 + }
1684 + $chart_data_converted[] = $row;
1685 + }
1543 1686 $wpdadb->get_results( "create temporary table `wpda_chart_data_types` as {$query}", 'ARRAY_A' );
1544 1687 $explain = $wpdadb->get_results( "desc `wpda_chart_data_types`", 'ARRAY_A' );
1545 1688 $wpdadb->get_results( "drop temporary table `wpda_chart_data_types`", 'ARRAY_A' );
1546 1689 $wpdadb->suppress_errors( $suppress );
1547 1690 return array(
1548 - 'data' => $chart_data,
1691 + 'data' => $chart_data_converted,
1549 1692 'explain' => $explain,
1550 1693 );
1551 1694 } else {
1552 1695 return new \WP_Error('error', $msg, array(
@@ -2027,8 +2170,9 @@
2027 2170 $app_id_details = array_map( function ( $e ) {
2028 2171 if ( isset( $e['app_id_detail'] ) ) {
2029 2172 return $e['app_id_detail'];
2030 2173 }
2174 + return null;
2031 2175 }, $apps );
2032 2176 $app_titles = array();
2033 2177 foreach ( $app_id_details as $app_id_detail ) {
2034 2178 $app_detail = WPDA_App_Model::get_by_id( $app_id_detail );
@@ -2072,12 +2216,37 @@
2072 2216 'date_format' => get_option( 'date_format' ),
2073 2217 'time_format' => get_option( 'time_format' ),
2074 2218 'scroll_offset' => WPDA::get_option( WPDA::OPTION_APPS_SCROLL_OFFSET ),
2075 2219 'upload' => @ini_get( 'upload_max_filesize' ),
2220 + 'uploadBytes' => $this->uploadToBytes( @ini_get( 'upload_max_filesize' ) ),
2221 + 'locale' => get_locale(),
2076 2222 ];
2077 2223 return $settings;
2078 2224 }
2079 2225
2226 + /**
2227 + * Convert a PHP shorthand notation (e.g., "2M", "512K", "1G") to bytes.
2228 + *
2229 + * @param string $val The shorthand size string.
2230 + *
2231 + * @return int The size in bytes.
2232 + */
2233 + private function uploadToBytes( $val ) : int {
2234 + $val = trim( $val );
2235 + $lastChar = strtolower( $val[strlen( $val ) - 1] );
2236 + $num = (float) $val;
2237 + switch ( $lastChar ) {
2238 + case 'g':
2239 + $num *= 1024;
2240 + case 'm':
2241 + $num *= 1024;
2242 + case 'k':
2243 + $num *= 1024;
2244 + break;
2245 + }
2246 + return (int) round( $num );
2247 + }
2248 +
2080 2249 private function get_app_container_meta( $app_id, $container, $rel_tab = false ) {
2081 2250 $app = WPDA_App_Model::get_by_id( $app_id );
2082 2251 if ( false === $app ) {
2083 2252 return $this->bad_request();
@@ -2154,8 +2323,17 @@
2154 2323 return $this->get_app_container_meta( $app_id, $container );
2155 2324 }
2156 2325 }
2157 2326
2327 + private function escapeUnicodeForExport( $str ) {
2328 + if ( empty( $str ) ) {
2329 + return $str;
2330 + }
2331 + return preg_replace_callback( '/\\\\(u[0-9a-fA-F]{4})/', function ( $matches ) {
2332 + return '\\\\' . $matches[1];
2333 + }, $str );
2334 + }
2335 +
2158 2336 private function do_app_export_app( $app_id, $main_app_id ) {
2159 2337 global $wpdb;
2160 2338 $quotes = function ( $value ) {
2161 2339 return str_replace( array(
@@ -2165,9 +2343,10 @@
2165 2343 "\\t",
2166 2344 "\\\\n",
2167 2345 "\\n",
2168 2346 "\\r\\n",
2169 - "\\r"
2347 + "\\r",
2348 + "\\d"
2170 2349 ), array(
2171 2350 "''",
2172 2351 '\\\\"',
2173 2352 "\\\\\\t",
@@ -2174,9 +2353,10 @@
2174 2353 "\\\\t",
2175 2354 "\\\\\\n",
2176 2355 "\\\\n",
2177 2356 "\\\\r\\\\n",
2178 - "\\\\r"
2357 + "\\\\r",
2358 + "\\\\\\\\\\d"
2179 2359 ), $value );
2180 2360 };
2181 2361 $app = WPDA_App_Model::get_by_id( $app_id );
2182 2362 $app_settings = ( null === $app[0]['app_settings'] ? 'null' : "{$quotes( $app[0]['app_settings'] )}" );
@@ -2223,8 +2403,11 @@
2223 2403 // Replace default WordPress database with conversion string
2224 2404 $cnt_dbs = ( $wpdb->dbname === $container['cnt_dbs'] ? '{wp_schema}' : "{$quotes( $container['cnt_dbs'] )}" );
2225 2405 $cnt_table = str_replace( "\"dbs\":\"{$wpdb->dbname}\"", "\"dbs\":\"{wp_schema}\"", $cnt_table );
2226 2406 $cnt_form = str_replace( "\"dbs\":\"{$wpdb->dbname}\"", "\"dbs\":\"{wp_schema}\"", $cnt_form );
2407 + // Replace Unicode characters
2408 + $cnt_table = $this->escapeUnicodeForExport( $cnt_table );
2409 + $cnt_form = $this->escapeUnicodeForExport( $cnt_form );
2227 2410 // phpcs:ignore PluginCheck.CodeAnalysis.Heredoc.NotAllowed
2228 2411 $containers_sql .= <<<SQL
2229 2412 # Import app container
2230 2413 insert into `{wp_prefix}wpda_app_container`
@@ -2532,14 +2715,16 @@
2532 2715 $dynamic_params = array()
2533 2716 ) {
2534 2717 // Process $search_custom > URL parameters
2535 2718 global $wpdb;
2719 + $replacements = array();
2720 + $nonce = bin2hex( random_bytes( 8 ) );
2536 2721 foreach ( self::METHODS as $method ) {
2537 2722 $offset = 0;
2538 2723 $search = $method . '[';
2724 + // Get filter
2539 2725 while ( ($pos_start = stripos( $where, $search, $offset )) !== false ) {
2540 2726 if ( ($pos_end = stripos( $where, ']', $pos_start )) !== false ) {
2541 - // Get filter
2542 2727 $filter = substr( $where, $pos_start, $pos_end - $pos_start + 1 );
2543 2728 // Get name
2544 2729 $arg_name = substr( $where, $pos_start + strlen( $search ), $pos_end - $pos_start - strlen( $search ) );
2545 2730 // Remove quotes from name
@@ -2545,64 +2730,34 @@
2545 2730 // Remove quotes from name
2546 2731 if ( substr( $arg_name, 0, 1 ) === "'" && substr( $arg_name, -1 ) === "'" ) {
2547 2732 $arg_name = substr( $arg_name, 1, -1 );
2548 2733 }
2549 - // Remove double quotes from name
2734 + // Remove quotes from name
2550 2735 if ( substr( $arg_name, 0, 1 ) === '"' && substr( $arg_name, -1 ) === '"' ) {
2551 2736 $arg_name = substr( $arg_name, 1, -1 );
2552 2737 }
2738 + $arg_value = null;
2553 2739 // Handle GET args
2554 - // phpcs:disable WordPress.DB.PreparedSQL.NotPrepared
2555 - if ( $method === self::METHODS[0] ) {
2740 + if ( $method === self::METHODS[0] && isset( $search_custom['get'][$arg_name] ) ) {
2741 + $arg_value = sanitize_text_field( wp_unslash( $search_custom['get'][$arg_name] ) );
2742 + } elseif ( $method === self::METHODS[1] && isset( $search_custom['post'][$arg_name] ) ) {
2743 + $arg_value = sanitize_text_field( wp_unslash( $search_custom['post'][$arg_name] ) );
2744 + } elseif ( $method === self::METHODS[2] ) {
2556 2745 if ( isset( $search_custom['get'][$arg_name] ) ) {
2557 2746 $arg_value = sanitize_text_field( wp_unslash( $search_custom['get'][$arg_name] ) );
2558 - $where = $wpdb->prepare( substr_replace(
2559 - $where,
2560 - '%s',
2561 - $pos_start,
2562 - $pos_end - $pos_start + 1
2563 - ), $arg_value );
2564 - } else {
2565 - $where = str_replace( $filter, 'null', $where );
2747 + } elseif ( isset( $search_custom['post'][$arg_name] ) ) {
2748 + $arg_value = sanitize_text_field( wp_unslash( $search_custom['post'][$arg_name] ) );
2566 2749 }
2567 2750 }
2568 2751 // Handle POST args
2569 - if ( $method === self::METHODS[1] ) {
2570 - if ( isset( $search_custom['post'][$arg_name] ) ) {
2571 - $arg_value = sanitize_text_field( wp_unslash( $search_custom['post'][$arg_name] ) );
2572 - $where = $wpdb->prepare( substr_replace(
2573 - $where,
2574 - '%s',
2575 - $pos_start,
2576 - $pos_end - $pos_start + 1
2577 - ), $arg_value );
2578 - } else {
2579 - $where = str_replace( $filter, 'null', $where );
2580 - }
2581 - }
2752 + $placeholder = '###URL_PLACEHOLDER_' . $nonce . '_' . md5( $filter ) . '###';
2753 + $where = str_replace( $filter, $placeholder, $where );
2582 2754 // Handle REQUEST args
2583 - if ( $method === self::METHODS[2] ) {
2584 - if ( isset( $search_custom['get'][$arg_name] ) ) {
2585 - $arg_value = sanitize_text_field( wp_unslash( $search_custom['get'][$arg_name] ) );
2586 - $where = $wpdb->prepare( substr_replace(
2587 - $where,
2588 - '%s',
2589 - $pos_start,
2590 - $pos_end - $pos_start + 1
2591 - ), $arg_value );
2592 - } elseif ( isset( $search_custom['post'][$arg_name] ) ) {
2593 - $arg_value = sanitize_text_field( wp_unslash( $search_custom['post'][$arg_name] ) );
2594 - $where = $wpdb->prepare( substr_replace(
2595 - $where,
2596 - '%s',
2597 - $pos_start,
2598 - $pos_end - $pos_start + 1
2599 - ), $arg_value );
2600 - } else {
2601 - $where = str_replace( $filter, 'null', $where );
2602 - }
2755 + if ( $arg_value !== null ) {
2756 + $replacements[$placeholder] = $wpdb->prepare( '%s', $arg_value );
2757 + } else {
2758 + $replacements[$placeholder] = 'null';
2603 2759 }
2604 - // phpcs:enable WordPress.DB.PreparedSQL.NotPrepared
2605 2760 }
2606 2761 $offset = $pos_start + 1;
2607 2762 if ( $offset > strlen( $where ) ) {
2608 2763 $offset = strlen( $where ) - 1;
@@ -2613,19 +2768,17 @@
2613 2768 if ( is_array( $search_params ) && 1 === count( $search_params ) ) {
2614 2769 $filter_field_name = $this->sanitize_db_identifier( array_keys( $search_params )[0] );
2615 2770 $filter_field_value = sanitize_text_field( $search_params[$filter_field_name] );
2616 2771 $filter_field_name_array = array_map( 'trim', explode( ',', $filter_field_name ) );
2617 - // phpcs:ignore -- 8.1 proof
2618 2772 $filter_field_value_array = array_map( 'trim', explode( ',', $filter_field_value ) );
2619 - // phpcs:ignore -- 8.1 proof
2620 2773 if ( count( $filter_field_name_array ) === count( $filter_field_value_array ) ) {
2621 - // phpcs:ignore -- 8.1 proof
2622 2774 // Add filter to where clause.
2623 - // phpcs:disable Generic.CodeAnalysis.ForLoopWithTestFunctionCall, Squiz.PHP.DisallowSizeFunctionsInLoops, WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQLPlaceholders.UnquotedComplexPlaceholder
2624 2775 for ($i = 0; $i < count( $filter_field_name_array ); $i++) {
2625 - $where .= (( '' === $where ? '' : ' and ' )) . $wpdb->prepare( ' `%1s` like %s ', array($filter_field_name_array[$i], $filter_field_value_array[$i]) );
2776 + $where .= ( '' === $where ? '' : ' and ' );
2777 + $placeholder = '###SHORTCODE_PARAM_' . $nonce . '_' . md5( $filter_field_name_array[$i] ) . '###';
2778 + $where .= ' `' . $filter_field_name_array[$i] . '` like ' . $placeholder;
2779 + $replacements[$placeholder] = $wpdb->prepare( '%s', $filter_field_value_array[$i] );
2626 2780 }
2627 - // phpcs:enable Generic.CodeAnalysis.ForLoopWithTestFunctionCall, Squiz.PHP.DisallowSizeFunctionsInLoops, WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQLPlaceholders.UnquotedComplexPlaceholder
2628 2781 }
2629 2782 }
2630 2783 // Substitute all shortcode parameters
2631 2784 if ( is_array( $shortcode_params ) ) {
@@ -2631,15 +2784,11 @@
2631 2784 if ( is_array( $shortcode_params ) ) {
2632 2785 foreach ( $shortcode_params as $column_name => $column_value ) {
2633 2786 $occurences = substr_count( strtolower( $where ), strtolower( "shortcodeParam['{$column_name}']" ) );
2634 2787 if ( 0 < $occurences ) {
2635 - $column_values = array();
2636 - for ($i = 0; $i < $occurences; $i++) {
2637 - $column_values[] = sanitize_text_field( $column_value );
2638 - }
2639 - // phpcs:disable WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
2640 - $where = $wpdb->prepare( str_ireplace( "shortcodeParam['{$column_name}']", '%s', $where ), $column_values );
2641 - // phpcs:enable WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
2788 + $placeholder = '###SHORTCODE_PARAM_' . $nonce . '_' . md5( $column_name ) . '###';
2789 + $where = str_ireplace( "shortcodeParam['{$column_name}']", $placeholder, $where );
2790 + $replacements[$placeholder] = $wpdb->prepare( '%s', sanitize_text_field( $column_value ) );
2642 2791 }
2643 2792 }
2644 2793 }
2645 2794 // Substitute all unused shortcode parameter calls with null
@@ -2657,13 +2806,15 @@
2657 2806 }
2658 2807 // Substitute all dynamic parameters
2659 2808 if ( is_array( $dynamic_params ) && 0 < count( $dynamic_params ) ) {
2660 2809 foreach ( $dynamic_params as $column_name => $column_value ) {
2661 - // phpcs:disable WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
2662 - $where = $wpdb->prepare( str_ireplace( "{:{$column_name}}", '%s', $where ), $column_value );
2663 - // phpcs:enable WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
2810 + if ( stripos( $where, "{:{$column_name}}" ) !== false ) {
2811 + $placeholder = '###DYNAMIC_PARAM_' . $nonce . '_' . md5( $column_name ) . '###';
2812 + $where = str_ireplace( "{:{$column_name}}", $placeholder, $where );
2813 + $replacements[$placeholder] = $wpdb->prepare( '%s', $column_value );
2814 + }
2664 2815 }
2665 2816 }
2666 - return $where;
2817 + return strtr( $where, $replacements );
2667 2818 }
2668 2819
2669 2820 }