| @@ -99,10 +99,14 @@ | ||
| 99 | 99 | |
| 100 | 100 | // Drop-in installed (only when cache is enabled — otherwise N/A) |
| 101 | 101 | $cache_enabled = (bool) Settings::get()['cache_enabled']; |
| 102 | 102 | if ( $cache_enabled ) { |
| 103 | - $dropin_path = WP_CONTENT_DIR . '/advanced-cache.php'; | |
| 104 | - $dropin_match = file_exists( $dropin_path ) && false !== strpos( (string) file_get_contents( $dropin_path ), 'xspeed' ); | |
| 103 | + // Ask the ownership oracle, not the bytes. A loose "xspeed" | |
| 104 | + // substring matched any foreign drop-in that so much as mentions | |
| 105 | + // us in a compatibility note, and reported it as "owned by | |
| 106 | + // xSpeed" while another plugin served every hit — the exact | |
| 107 | + // loose-substring test the drop-in contract forbids. | |
| 108 | + $dropin_match = Cache::DROPIN_XSPEED === Cache::dropin_owner(); | |
| 105 | 109 | $out[] = array( |
| 106 | 110 | 'id' => 'dropin', |
| 107 | 111 | 'tone' => $dropin_match ? self::OK : self::FAIL, |
| 108 | 112 | 'label' => 'advanced-cache.php drop-in', |
| @@ -114,16 +118,56 @@ | ||
| 114 | 118 | |
| 115 | 119 | // WP_CACHE constant |
| 116 | 120 | $wp_cache_const = defined( 'WP_CACHE' ) && WP_CACHE; |
| 117 | 121 | if ( $cache_enabled ) { |
| 118 | - $out[] = array( | |
| 122 | + // Why the constant is missing decides what we tell the user to | |
| 123 | + // do, so the two cases can't share one sentence. An unwritable | |
| 124 | + // wp-config.php (managed hosts make it read-only by design) is | |
| 125 | + // the common cause and the user must paste the line by hand. | |
| 126 | + // But it is NOT the only way to land here: a leftover | |
| 127 | + // `define( 'WP_CACHE', false );` from a previous cache plugin, | |
| 128 | + // a missing wp-config.php, or a WP_Filesystem that wants FTP | |
| 129 | + // credentials all fail set_wp_cache_constant() on a perfectly | |
| 130 | + // writable file. Asserting "not writable" unconditionally told | |
| 131 | + // those users something demonstrably false about their own | |
| 132 | + // server and sent them hand-editing a file the plugin could | |
| 133 | + // have fixed by toggling the cache off and on. (#19) | |
| 134 | + // The cost is real, but it is NOT "nothing is being cached": with | |
| 135 | + // the constant absent, Cache::maybe_start_cache() still serves on | |
| 136 | + // template_redirect and tags the response `HIT (php)`. What the | |
| 137 | + // constant buys is answering from the drop-in BEFORE WordPress | |
| 138 | + // boots — worth roughly an order of magnitude on TTFB, which is | |
| 139 | + // what makes this a WARN worth acting on. Claiming the cache was | |
| 140 | + // idle was simply false, and it is the sentence a worried user | |
| 141 | + // reads first. (#19, QA on #174) | |
| 142 | + // | |
| 143 | + // Ask the WRITER which branch to show, not a second oracle: Health | |
| 144 | + // used to run its own wp_is_writable() against its own path | |
| 145 | + // resolution, and the two disagreed with set_wp_cache_constant() | |
| 146 | + // in both directions — see Cache::can_write_wp_config(). | |
| 147 | + $wp_config_writable = Cache::can_write_wp_config(); | |
| 148 | + $check = array( | |
| 119 | 149 | 'id' => 'wp_cache_constant', |
| 120 | 150 | 'tone' => $wp_cache_const ? self::OK : self::WARN, |
| 121 | 151 | 'label' => 'WP_CACHE constant', |
| 122 | 152 | 'detail' => $wp_cache_const |
| 123 | 153 | ? 'Defined and truthy in wp-config.php.' |
| 124 | - : 'Not set. Cache is configured but WordPress will not load the drop-in until WP_CACHE = true is added to wp-config.php.', | |
| 154 | + : 'Not set — cached pages are being served the slow way. Without this constant WordPress boots fully before xSpeed can answer from cache, costing roughly 10ms per hit. ' . ( $wp_config_writable | |
| 155 | + ? 'wp-config.php is writable, so toggling Enable Cache off and on should set it for you; if it comes back, another plugin may have left define( \'WP_CACHE\', false ) behind — add the line below by hand instead.' | |
| 156 | + : 'wp-config.php is not writable here (managed hosts often make it read-only), so add the line below by hand, above the "That\'s all, stop editing!" comment.' ), | |
| 125 | 157 | ); |
| 158 | + if ( ! $wp_cache_const ) { | |
| 159 | + // The line to paste, carried on the check itself so it | |
| 160 | + // survives on a persistent surface. Enabling the cache | |
| 161 | + // offered this only inside a toast that cleared after two | |
| 162 | + // seconds with no copy button, so a user who looked away | |
| 163 | + // had no way back to it anywhere in the dashboard — while | |
| 164 | + // the toggle read green and the site cached nothing. | |
| 165 | + // HealthCard already renders `snippet` through CopySnippet | |
| 166 | + // (the nginx check proves the wiring). (#19) | |
| 167 | + $check['snippet'] = "define( 'WP_CACHE', true );"; | |
| 168 | + } | |
| 169 | + $out[] = $check; | |
| 126 | 170 | } |
| 127 | 171 | |
| 128 | 172 | // Static-rewrite probe. Active end-to-end check: writes a probe |
| 129 | 173 | // file under the static-cache dir, fetches it over HTTP, and |
| @@ -152,8 +196,19 @@ | ||
| 152 | 196 | $inconclusive = (bool) ( $probe['inconclusive'] ?? false ); |
| 153 | 197 | $probe_reason = (string) ( $probe['reason'] ?? '' ); |
| 154 | 198 | |
| 155 | 199 | $block_reason = Cache::static_rewrite_block_reason(); |
| 200 | + | |
| 201 | + // An OBSERVED refusal, from the last cacheable render. The settings | |
| 202 | + // above say whether the rewrite is allowed; this says whether pages | |
| 203 | + // are actually reaching the tree. They disagree whenever a page is | |
| 204 | + // refused per-response — a nonce being the common one — and in that | |
| 205 | + // case the settings are right and irrelevant: nginx is configured | |
| 206 | + // correctly, and every hit still comes from PHP. (#372) | |
| 207 | + $skip = Cache::last_static_skip(); | |
| 208 | + if ( '' === $block_reason && ! empty( $skip['reason'] ) ) { | |
| 209 | + $block_reason = 'skipped_' . (string) $skip['reason']; | |
| 210 | + } | |
| 156 | 211 | $mobile_block = ( 'mobile_separate' === $block_reason ) |
| 157 | 212 | ? ' Note: Separate Mobile Cache is on, which disables the device-blind static rewrite — if your site serves the same HTML to all devices, turn it off (Cache settings) for much faster cache hits.' |
| 158 | 213 | : ''; |
| 159 | 214 | |
| @@ -178,8 +233,10 @@ | ||
| 178 | 233 | if ( $is_active ) { |
| 179 | 234 | $nginx_detail = 'nginx is serving cache hits directly — PHP bypassed (~5-15ms TTFB).'; |
| 180 | 235 | } elseif ( 'mobile_separate' === $block_reason ) { |
| 181 | 236 | $nginx_detail = 'nginx detected, but the static rewrite is disabled because Separate Mobile Cache is on.' . $mobile_block; |
| 237 | + } elseif ( 'skipped_nonce' === $block_reason ) { | |
| 238 | + $nginx_detail = self::nonce_skip_detail( $skip ); | |
| 182 | 239 | } elseif ( $inconclusive ) { |
| 183 | 240 | $nginx_detail = sprintf( |
| 184 | 241 | 'Could not verify the static rewrite — the check itself did not complete, so this is not evidence that your config is wrong. If you have already pasted the snippet, it may well be working. Reason: %s', |
| 185 | 242 | $probe_reason |
| @@ -233,8 +290,14 @@ | ||
| 233 | 290 | // still works via the drop-in; say so, and give the one |
| 234 | 291 | // step that actually changes the outcome. |
| 235 | 292 | $tone = self::INFO; |
| 236 | 293 | $detail = 'Cache hits are served by xSpeed\'s drop-in and tagged X-XSpeed-Cache: HIT (php), so every hit is visible and counted. The faster .htaccess fast path is off because Apache\'s mod_headers module is not loaded — without it a static hit could not be tagged or counted. Enable mod_headers (`a2enmod headers` on Debian/Ubuntu, then restart Apache) to shave roughly 20-30ms off each cache hit.'; |
| 294 | + } elseif ( 'skipped_nonce' === $block_reason ) { | |
| 295 | + // Before this, Apache fell through to "probe failed — | |
| 296 | + // check AllowOverride", sending the admin to audit a | |
| 297 | + // config that was never the problem. | |
| 298 | + $tone = self::WARN; | |
| 299 | + $detail = self::nonce_skip_detail( $skip ); | |
| 237 | 300 | } elseif ( ! $installed ) { |
| 238 | 301 | $tone = self::WARN; |
| 239 | 302 | $detail = 'Block missing from .htaccess. Toggle Enable Cache off and on to reinstall it.'; |
| 240 | 303 | } elseif ( $inconclusive ) { |
| @@ -259,8 +322,62 @@ | ||
| 259 | 322 | ); |
| 260 | 323 | } |
| 261 | 324 | } |
| 262 | 325 | |
| 326 | + /* | |
| 327 | + * A full-page cache owned by the WEB SERVER, in front of PHP. | |
| 328 | + * | |
| 329 | + * Reported only when it is actually there, because it is a fact about | |
| 330 | + * the host rather than a setting the admin can act on from here — an | |
| 331 | + * "absent" row would be noise on the ~99% of sites that have no such | |
| 332 | + * layer. When it IS there it outranks almost everything else on this | |
| 333 | + * panel: nginx answers before WordPress runs, so what a visitor sees | |
| 334 | + * is decided by that cache and not by anything xSpeed reports about | |
| 335 | + * its own. | |
| 336 | + * | |
| 337 | + * The severity is about DOUBLE full-page caching, not about the layer | |
| 338 | + * existing. Two independent full-page caches stacked in front of one | |
| 339 | + * site have independent TTLs, and the outer one can re-serve HTML the | |
| 340 | + * inner one has already regenerated — the classic "I purged and it is | |
| 341 | + * still stale" report. With xSpeed's own page cache off there is only | |
| 342 | + * one layer and nothing to warn about, so that case is INFO. | |
| 343 | + */ | |
| 344 | + $host_cache_path = Host_Page_Caches::nginx_helper_cache_path(); | |
| 345 | + if ( null !== $host_cache_path ) { | |
| 346 | + $detail = $cache_enabled | |
| 347 | + ? 'Your server is running its own full-page cache in nginx (FastCGI), managed by the Nginx Helper plugin your host installed — so this site has TWO full-page caches stacked in front of it. xSpeed forwards every Purge All to the server layer, but the two expire on their own schedules (the server side is typically an hour), so a page can still be served from nginx after xSpeed has regenerated it. If edits keep looking stale, purge from your host\'s dashboard too, or turn xSpeed\'s page cache off and let the server layer do the work — it is the faster of the two, because it answers before PHP starts.' | |
| 348 | + : 'Your server is running a full-page cache in nginx (FastCGI), managed by the Nginx Helper plugin your host installed. xSpeed\'s own page cache is off, so this is the only full-page cache in front of the site — and it is the fastest kind, answering before PHP starts. Purge All in xSpeed still clears it.'; | |
| 349 | + | |
| 350 | + // Path prefix as a fingerprint for the WORDING only — never as a | |
| 351 | + // gate. Nginx Helper is not xCloud-only; other hosts and manual | |
| 352 | + // installs use it with a cache directory somewhere else entirely. | |
| 353 | + if ( 0 === strpos( $host_cache_path, '/etc/nginx/cache/' ) ) { | |
| 354 | + $detail .= sprintf( ' Cache directory: %s (the layout xCloud provisions).', $host_cache_path ); | |
| 355 | + } else { | |
| 356 | + $detail .= sprintf( ' Cache directory: %s.', $host_cache_path ); | |
| 357 | + } | |
| 358 | + | |
| 359 | + // The purge is a direct unlink by the PHP-FPM user against a | |
| 360 | + // directory nginx owns. Whether that user can write there is a | |
| 361 | + // property of the host we cannot test from here without deleting | |
| 362 | + // someone's cache to find out, so say what to check rather than | |
| 363 | + // claiming an outcome either way. | |
| 364 | + if ( 'unlink_files' === Host_Page_Caches::nginx_helper_purge_method() ) { | |
| 365 | + $detail .= ' The server cache is purged by deleting its files directly, which needs PHP to have write access to that directory — if a purge here never changes what nginx serves, that permission is the thing to check with your host.'; | |
| 366 | + } | |
| 367 | + | |
| 368 | + if ( is_multisite() ) { | |
| 369 | + $detail .= ' On multisite, nginx keys one cache per install rather than per site, so this purge clears every site on the network.'; | |
| 370 | + } | |
| 371 | + | |
| 372 | + $out[] = array( | |
| 373 | + 'id' => 'host_page_cache', | |
| 374 | + 'tone' => $cache_enabled ? self::WARN : self::INFO, | |
| 375 | + 'label' => 'Server-level page cache (nginx FastCGI)', | |
| 376 | + 'detail' => $detail, | |
| 377 | + ); | |
| 378 | + } | |
| 379 | + | |
| 263 | 380 | // Cache expiry vs preloader schedule (deterministic rule, issue #31): |
| 264 | 381 | // pages that expire faster than the preloader re-warms them leave the |
| 265 | 382 | // cache cold for most real traffic — the classic "24.8% hit ratio with |
| 266 | 383 | // everything on" misconfiguration. Pure logic in |
| @@ -269,9 +386,9 @@ | ||
| 269 | 386 | $cache_opts = Settings_Manager::get( 'cache' ); |
| 270 | 387 | $pre_opts = Settings_Manager::get( 'preloader' ); |
| 271 | 388 | $schedule = (string) ( $pre_opts['schedule'] ?? 'manual' ); |
| 272 | 389 | $mismatch = self::expiry_preload_check( |
| 273 | - (int) ( $cache_opts['cache_expiry'] ?? 24 ), | |
| 390 | + (int) ( $cache_opts['cache_expiry'] ?? \XSpeed\Modules\Cache\CacheModule::DEFAULT_EXPIRY_HOURS ), | |
| 274 | 391 | $schedule, |
| 275 | 392 | ! empty( $pre_opts['enabled'] ), |
| 276 | 393 | self::schedule_interval_hours( $schedule ) |
| 277 | 394 | ); |
| @@ -333,13 +450,44 @@ | ||
| 333 | 450 | $out[] = array( |
| 334 | 451 | 'id' => 'conflicts', |
| 335 | 452 | 'tone' => empty( $conflicts ) ? self::OK : self::WARN, |
| 336 | 453 | 'label' => 'Caching plugin conflicts', |
| 454 | + // Not "Active:" — the list now includes a drop-in left behind by a | |
| 455 | + // plugin that is not running, which is exactly the case that made | |
| 456 | + // this row disagree with what the enable actually does. | |
| 337 | 457 | 'detail' => empty( $conflicts ) |
| 338 | 458 | ? 'No other caching plugins detected.' |
| 339 | - : sprintf( 'Active: %s. Deactivate before enabling xSpeed cache to avoid double-caching.', implode( ', ', $conflicts ) ), | |
| 459 | + : sprintf( 'Found: %s. Another page cache must be off, and its advanced-cache.php gone, before xSpeed can enable its own.', implode( ', ', $conflicts ) ), | |
| 340 | 460 | ); |
| 341 | 461 | |
| 462 | + /* | |
| 463 | + * A migration whose source is STILL RUNNING. | |
| 464 | + * | |
| 465 | + * Distinct from the generic `conflicts` check above, which only says | |
| 466 | + * "another caching plugin is active". This one knows the user imported | |
| 467 | + * from it and chose (or was refused) to leave it on, so it can name the | |
| 468 | + * plugin and the decision. | |
| 469 | + * | |
| 470 | + * The point is persistence: the import screen's warning disappears the | |
| 471 | + * moment the user navigates away, and the risk does not. Two page | |
| 472 | + * caches fighting over the drop-in is exactly what breaks caching for | |
| 473 | + * both, so the warning has to outlive the screen it was raised on. | |
| 474 | + * (#189 AC4) | |
| 475 | + */ | |
| 476 | + $pending = class_exists( '\\XSpeed\\Migration' ) ? Migration::pending_source() : null; | |
| 477 | + if ( null !== $pending ) { | |
| 478 | + $out[] = array( | |
| 479 | + 'id' => 'migration_source_active', | |
| 480 | + 'tone' => self::WARN, | |
| 481 | + 'label' => sprintf( '%s is still active after import', $pending['label'] ), | |
| 482 | + 'detail' => sprintf( | |
| 483 | + 'You imported settings from %s but left it running. Two page caches fight over the cache drop-in and can break caching for both — deactivate %s on the Plugins screen once you have checked the imported settings.', | |
| 484 | + $pending['label'], | |
| 485 | + $pending['label'] | |
| 486 | + ), | |
| 487 | + ); | |
| 488 | + } | |
| 489 | + | |
| 342 | 490 | return $out; |
| 343 | 491 | } |
| 344 | 492 | |
| 345 | 493 | /** |
| @@ -361,8 +509,38 @@ | ||
| 361 | 509 | * Falls back to `wp_get_schedules()` so custom crons registered by a |
| 362 | 510 | * theme or another plugin are covered too, rather than silently |
| 363 | 511 | * skipping the check. |
| 364 | 512 | */ |
| 513 | + /** | |
| 514 | + * Explain a static-tree refusal caused by nonces. | |
| 515 | + * | |
| 516 | + * Says four things, because leaving any of them out is what made this | |
| 517 | + * invisible: the config is FINE (so nobody re-pastes a snippet that was | |
| 518 | + * never the problem), hits are coming from PHP instead, which nonce keys | |
| 519 | + * caused it, and that the refusal is deliberate rather than a bug to work | |
| 520 | + * around. The keys are the actionable part — they name the plugin, and it | |
| 521 | + * is usually a widget the page does not use. (#372) | |
| 522 | + * | |
| 523 | + * @param array{reason?:string,url?:string,keys?:string[]} $skip Recorded refusal. | |
| 524 | + */ | |
| 525 | + private static function nonce_skip_detail( array $skip ): string { | |
| 526 | + $detail = 'Your nginx config is correct, but pages are not reaching the static cache, so hits are served by PHP (typically ~1s instead of ~5-15ms). ' | |
| 527 | + . 'They contain nonces, and a static file is served with no PHP — nothing could ever refresh them, so every anonymous form on the page would break once they expire. Keeping these pages on PHP is deliberate.'; | |
| 528 | + | |
| 529 | + $keys = array_filter( array_map( 'strval', (array) ( $skip['keys'] ?? array() ) ) ); | |
| 530 | + if ( ! empty( $keys ) ) { | |
| 531 | + $detail .= ' Nonces found: ' . implode( ', ', $keys ) . '.'; | |
| 532 | + $detail .= ' These come from plugin widgets — disabling the ones this site does not use lets its pages be served statically again.'; | |
| 533 | + } | |
| 534 | + | |
| 535 | + $url = (string) ( $skip['url'] ?? '' ); | |
| 536 | + if ( '' !== $url ) { | |
| 537 | + $detail .= sprintf( ' Last seen on %s.', $url ); | |
| 538 | + } | |
| 539 | + | |
| 540 | + return $detail; | |
| 541 | + } | |
| 542 | + | |
| 365 | 543 | public static function schedule_interval_hours( string $schedule ): ?int { |
| 366 | 544 | if ( isset( self::PRELOAD_INTERVALS[ $schedule ] ) ) { |
| 367 | 545 | return self::PRELOAD_INTERVALS[ $schedule ]; |
| 368 | 546 | } |
| @@ -453,15 +631,34 @@ | ||
| 453 | 631 | 'writable' => self::wp_config_writable(), |
| 454 | 632 | ), |
| 455 | 633 | 'permalinks_ok' => (bool) get_option( 'permalink_structure' ), |
| 456 | 634 | 'conflicts' => Server::conflicts(), |
| 635 | + /* | |
| 636 | + * The reason the enable would be refused right now, or null. | |
| 637 | + * | |
| 638 | + * `conflicts` is a list of plugins, and the wizard used it to | |
| 639 | + * decide whether to open with page caching ticked. The two are | |
| 640 | + * not the same question: an orphaned or doubly-defined WP_CACHE | |
| 641 | + * refuses the enable with no plugin to name, so the wizard | |
| 642 | + * offered a pre-ticked switch it already knew would fail. This | |
| 643 | + * is the gate's own answer, so the box and the outcome agree. | |
| 644 | + */ | |
| 645 | + 'page_cache_blocked' => Cache::acquisition_blocker(), | |
| 457 | 646 | ); |
| 458 | 647 | } |
| 459 | 648 | |
| 649 | + /** | |
| 650 | + * Cheap writability probe for the onboarding env payload only. | |
| 651 | + * | |
| 652 | + * Deliberately NOT the oracle behind the WP_CACHE check — that asks | |
| 653 | + * Cache::can_write_wp_config(), which runs the same WP_Filesystem test | |
| 654 | + * the writer runs, so advice can never contradict behaviour. This one | |
| 655 | + * stays a plain filesystem read because env_payload() is documented as | |
| 656 | + * making no outbound calls, and WP_Filesystem() can try to open an | |
| 657 | + * FTP/SSH connection. It shares the writer's path resolution so the two | |
| 658 | + * at least agree on WHICH file they are describing. (#19, QA on #174) | |
| 659 | + */ | |
| 460 | 660 | private static function wp_config_writable(): bool { |
| 461 | - $path = ABSPATH . 'wp-config.php'; | |
| 462 | - if ( ! file_exists( $path ) ) { | |
| 463 | - $path = dirname( ABSPATH ) . '/wp-config.php'; | |
| 464 | - } | |
| 465 | - return file_exists( $path ) && wp_is_writable( $path ); | |
| 661 | + $path = Cache::wp_config_path(); | |
| 662 | + return '' !== $path && wp_is_writable( $path ); | |
| 466 | 663 | } |
| 467 | 664 | } |
