| @@ -207,38 +207,41 @@ | ||
| 207 | 207 | } |
| 208 | 208 | } |
| 209 | 209 | |
| 210 | 210 | /** |
| 211 | - * Section deep-links rendered under the xSpeed menu. Mirrors the | |
| 212 | - * React sidebar's group manifest (see src/components/sidebarGroups.ts) | |
| 213 | - * so the WP admin rail reads as the same map as the in-app sidebar. | |
| 214 | - * Each entry points at the first module slug in that group; the | |
| 215 | - * React app's hash router lands the user on that module, which is | |
| 216 | - * the first row of that group's sidebar section — no manual scrolling. | |
| 211 | + * Section deep-links rendered under the xSpeed menu. | |
| 217 | 212 | * |
| 218 | - * If you add a group to React's SIDEBAR_GROUPS, add it here too. The | |
| 219 | - * two arrays are intentionally co-located in PR review (same change | |
| 220 | - * touches both) rather than DRY'd through a generated config file — | |
| 221 | - * this is the only PHP↔TS coupling and it's tiny. | |
| 213 | + * This is deliberately a SHORT LIST, not a mirror of React's | |
| 214 | + * SIDEBAR_GROUPS. It used to mirror all eight groups 1:1, which made the | |
| 215 | + * WP admin rail a second, competing copy of the in-app sidebar — the same | |
| 216 | + * map rendered twice, one of them permanently expanded and pushing every | |
| 217 | + * other plugin's menu down the page. | |
| 222 | 218 | * |
| 223 | - * @return array<string,string> map of first-module-hash → group label. | |
| 219 | + * What stays are the entry points a user navigates to from OUTSIDE the | |
| 220 | + * app: the dashboard itself, the two areas people arrive at with a | |
| 221 | + * specific errand (AI & agents to connect an assistant, Settings), and the | |
| 222 | + * wizard. Everything else — Cache, Optimization, Network, Health & | |
| 223 | + * insights, Tools — is one click away in the app's own sidebar, which is | |
| 224 | + * where in-app navigation belongs. | |
| 225 | + * | |
| 226 | + * So adding a group to React's SIDEBAR_GROUPS no longer means adding it | |
| 227 | + * here. The two lists are intentionally different lengths now. | |
| 228 | + * | |
| 229 | + * Setup Wizard is NOT in this array — it's a real submenu page registered | |
| 230 | + * by Onboarding::register_menu() on `admin_menu` at priority 20, so it | |
| 231 | + * lands after these entries. | |
| 232 | + * | |
| 233 | + * @return array<string,string> map of route hash → menu label. | |
| 224 | 234 | */ |
| 225 | 235 | private static function deep_link_items() { |
| 226 | - // Mirrors SIDEBAR_GROUPS (sidebarGroups.ts) 1:1, in the same order — | |
| 227 | - // the only PHP↔TS coupling. Redesign v2: groups are LANDING pages, so | |
| 228 | - // each key is the group's route hash (`/<group-id>`), not a module | |
| 229 | - // slug; the submenu loop prepends '#'. Overview is pinned first. React | |
| 230 | - // (nav.ts parseRoute) resolves `#/<group-id>` to that landing; legacy | |
| 231 | - // `#slug` links still redirect, so old bookmarks keep working. | |
| 236 | + // Keys are route hashes (`/<group-id>`); the submenu loop prepends '#'. | |
| 237 | + // React (nav.ts parseRoute) resolves `#/<group-id>` to that landing; | |
| 238 | + // legacy `#slug` links still redirect, so old bookmarks keep working — | |
| 239 | + // including bookmarks to the groups no longer listed here. | |
| 232 | 240 | return array( |
| 233 | - '/overview' => __( 'Overview', 'xspeed' ), | |
| 234 | - '/cache' => __( 'Cache', 'xspeed' ), | |
| 235 | - '/performance' => __( 'Optimization', 'xspeed' ), | |
| 236 | - '/network' => __( 'Network', 'xspeed' ), | |
| 237 | - '/insights' => __( 'Health & insights', 'xspeed' ), | |
| 238 | - '/tools' => __( 'Tools', 'xspeed' ), | |
| 239 | - '/ai-agents' => __( 'AI & agents', 'xspeed' ), | |
| 240 | - '/settings' => __( 'Settings', 'xspeed' ), | |
| 241 | + '/overview' => __( 'Overview', 'xspeed' ), | |
| 242 | + '/ai-agents' => __( 'AI & agents', 'xspeed' ), | |
| 243 | + '/settings' => __( 'Settings', 'xspeed' ), | |
| 241 | 244 | ); |
| 242 | 245 | } |
| 243 | 246 | |
| 244 | 247 | /** |
| @@ -393,10 +396,23 @@ | ||
| 393 | 396 | * @since 1.5.0 |
| 394 | 397 | */ |
| 395 | 398 | do_action( 'xspeed_admin_enqueue', $hook ); |
| 396 | 399 | |
| 397 | - wp_localize_script( | |
| 398 | - 'xspeed-admin', | |
| 400 | + // NOT wp_localize_script(). WP_Scripts::localize() casts every scalar | |
| 401 | + // to a string (wp-includes/class-wp-scripts.php: `(string) $value`), | |
| 402 | + // so an int arrives in JS as "21600" and a bool as "1" or "". | |
| 403 | + // | |
| 404 | + // That silently broke the Pro prewarm scheduler: it guards with | |
| 405 | + // `typeof gmtOffset === 'number'`, which a string fails, so the site's | |
| 406 | + // UTC offset was treated as 0 and every one-off warm was scheduled | |
| 407 | + // against UTC instead of site time — hours late on any non-UTC site, | |
| 408 | + // under a label that confidently read "Site time (UTC)". | |
| 409 | + // | |
| 410 | + // wp_add_inline_script() with wp_json_encode() preserves types, so | |
| 411 | + // numbers stay numbers and booleans stay booleans. Worth doing beyond | |
| 412 | + // the one field: every future numeric or boolean config value would | |
| 413 | + // hit the same trap. (#105) | |
| 414 | + self::print_config( | |
| 399 | 415 | 'XSpeedConfig', |
| 400 | 416 | array( |
| 401 | 417 | 'restUrl' => esc_url_raw( rest_url( Rest_Api::NAMESPACE_V1 ) ), |
| 402 | 418 | 'nonce' => wp_create_nonce( 'wp_rest' ), |
| @@ -426,8 +442,36 @@ | ||
| 426 | 442 | ); |
| 427 | 443 | } |
| 428 | 444 | |
| 429 | 445 | /** |
| 446 | + * Emit a JS global for the admin bundle with types intact. | |
| 447 | + * | |
| 448 | + * The type-preserving replacement for wp_localize_script(), which | |
| 449 | + * stringifies every scalar. Attached to the `xspeed-admin` handle as a | |
| 450 | + * `before` script so it is defined by the time the bundle executes — | |
| 451 | + * exactly the ordering guarantee localize gave us. | |
| 452 | + * | |
| 453 | + * Shared by the dashboard and the onboarding wizard so neither can drift | |
| 454 | + * back to the stringifying path. | |
| 455 | + * | |
| 456 | + * @param string $var_name JS global to define. | |
| 457 | + * @param array $data Payload; encoded with wp_json_encode(). | |
| 458 | + */ | |
| 459 | + public static function print_config( string $var_name, array $data ): void { | |
| 460 | + $json = wp_json_encode( $data ); | |
| 461 | + if ( false === $json ) { | |
| 462 | + // Never emit a broken assignment — the bundle reads this global | |
| 463 | + // on mount and a syntax error here blanks the whole screen. | |
| 464 | + $json = '{}'; | |
| 465 | + } | |
| 466 | + wp_add_inline_script( | |
| 467 | + 'xspeed-admin', | |
| 468 | + 'var ' . $var_name . ' = ' . $json . ';', | |
| 469 | + 'before' | |
| 470 | + ); | |
| 471 | + } | |
| 472 | + | |
| 473 | + /** | |
| 430 | 474 | * Pre-rendered settings + status payload, baked into the page so the |
| 431 | 475 | * React app can mount with real values instead of showing a loading state |
| 432 | 476 | * while it waits for /settings and /status REST calls. |
| 433 | 477 | */ |
| @@ -516,8 +560,14 @@ | ||
| 516 | 560 | // BrowserCache headers, GZIP, …). Null on non-nginx hosts |
| 517 | 561 | // or when no module contributes directives. Replaces the |
| 518 | 562 | // per-module "paste this snippet" notices. |
| 519 | 563 | 'nginx_server_block' => Cache::full_nginx_server_block(), |
| 564 | + // Mirrors the /status block so the enable-time disclosure is | |
| 565 | + // correct on FIRST PAINT. Without it the top-bar switch can be | |
| 566 | + // clicked before a status fetch lands, and the one moment the | |
| 567 | + // warning exists for — a leftover drop-in about to be | |
| 568 | + // replaced — is exactly when it would be missing. | |
| 569 | + 'dropin' => Page_Cache_Detector::dropin_disclosure(), | |
| 520 | 570 | ), |
| 521 | 571 | // Registered Modules (Free + Pro). The React app discovers them |
| 522 | 572 | // here and renders one sidebar item + one panel per module that |
| 523 | 573 | // declares a settings schema. Hidden modules are filtered. |
| @@ -568,12 +618,43 @@ | ||
| 568 | 618 | // panel — i.e., truly nothing to render in the dashboard. |
| 569 | 619 | if ( empty( $schema ) && empty( $custom_panel ) ) { |
| 570 | 620 | continue; |
| 571 | 621 | } |
| 622 | + $settings = Settings_Manager::get_public( $slug ); | |
| 623 | + | |
| 572 | 624 | $entry = array( |
| 573 | 625 | 'slug' => $slug, |
| 574 | 626 | 'tier' => $module->tier(), |
| 575 | 627 | 'version' => $module->version(), |
| 628 | + // Promoted from inside `settings` so the payload is | |
| 629 | + // self-describing. Consumers kept tripping on this — the Hub | |
| 630 | + // rendered every module "Inactive" until it learned to look | |
| 631 | + // inside the settings bag. `settings.enabled` is kept below | |
| 632 | + // for back-compat; this is the same value, not a second | |
| 633 | + // source of truth. Modules with no `enabled` key (status | |
| 634 | + // panels like Health) report null rather than a misleading | |
| 635 | + // false. (#146) | |
| 636 | + 'enabled' => array_key_exists( 'enabled', $settings ) | |
| 637 | + ? (bool) $settings['enabled'] | |
| 638 | + : null, | |
| 639 | + // Whether the module is actually DOING something, which is not | |
| 640 | + // the same question as `enabled` above. "On" has several shapes | |
| 641 | + // -- page caching lives in the global option, Minify and Lazy | |
| 642 | + // are on when any flag is set, MCP when it is connected -- so | |
| 643 | + // each module answers for itself via is_active(). Consumers | |
| 644 | + // that want "what is switched on?" (the sidebar's "N on" badge) | |
| 645 | + // must read THIS, not `enabled`, which only ever described the | |
| 646 | + // modules that happen to store that one key. null means the | |
| 647 | + // module has no meaningful on/off and should be excluded from | |
| 648 | + // any count rather than treated as off. (#363) | |
| 649 | + 'active' => $module->is_active(), | |
| 650 | + // One sentence explaining the line above, computed next to it | |
| 651 | + // so the two cannot disagree. The UI shows it behind an (i) | |
| 652 | + // beside the status pill: "On" is a bare assertion otherwise, | |
| 653 | + // and least obvious exactly where it matters -- Media | |
| 654 | + // Optimization reads On while its two most prominent switches | |
| 655 | + // are off, because three other flags are on. (#363) | |
| 656 | + 'active_reason' => $module->active_reason(), | |
| 576 | 657 | 'label' => $meta['label'] ?? ucfirst( $slug ), |
| 577 | 658 | 'icon' => $meta['icon'] ?? 'Square', |
| 578 | 659 | 'description' => $meta['description'] ?? '', |
| 579 | 660 | // Short label for the module's own tab when it hosts a tabbed |
| @@ -578,9 +659,19 @@ | ||
| 578 | 659 | 'description' => $meta['description'] ?? '', |
| 579 | 660 | // Short label for the module's own tab when it hosts a tabbed |
| 580 | 661 | // page (FBS-83633). Only set on host modules. |
| 581 | 662 | 'tab_label' => $meta['tab_label'] ?? null, |
| 582 | - 'settings' => Settings_Manager::get( $slug ), | |
| 663 | + // Public view: real values except secret fields, which are masked. | |
| 664 | + // The dashboard bundle localizes this into page HTML, so a raw | |
| 665 | + // credential here would be readable from view-source. (#115) | |
| 666 | + 'settings' => $settings, | |
| 667 | + // Where each value actually came from: a wp-config.php constant, | |
| 668 | + // the option row, or the schema default. The panel renders a | |
| 669 | + // constant-sourced field read-only and names the constant, so it | |
| 670 | + // can never present an editable box over a value the site is not | |
| 671 | + // using. Every module gets this, not just the ones that declare | |
| 672 | + // constants today. (#398) | |
| 673 | + 'setting_origins' => Settings_Manager::origins( $slug ), | |
| 583 | 674 | 'schema' => $schema, |
| 584 | 675 | 'notices' => $module->ui_notices(), |
| 585 | 676 | 'custom_panel' => $meta['custom_panel'] ?? null, |
| 586 | 677 | ); |
