PluginProbe
xSpeed Cache: AI-Powered Performance Hub with MCP, Caching & CDN / 1.3.4
xSpeed Cache: AI-Powered Performance Hub with MCP, Caching & CDN v1.3.4
1.3.4 1.3.3 1.3.2 1.3.1 1.3.0 1.2.4 trunk 1.0.0 1.0.1 1.0.2 1.0.3 1.0.4 1.0.5 1.0.6 1.0.7 1.0.8 1.0.9 1.1.0 1.1.1 1.1.2 1.1.3 1.1.4 1.1.5 1.1.6 1.1.7 All 30 releases
← All changes | includes/class-minifier.php +282 -19 1.1.31.3.4 View file →
@@ -55,8 +55,17 @@
55 55 if ( is_admin() || ( defined( 'DOING_AJAX' ) && DOING_AJAX ) || ( defined( 'DOING_CRON' ) && DOING_CRON ) || ( defined( 'REST_REQUEST' ) && REST_REQUEST ) ) {
56 56 return;
57 57 }
58 58
59 + // A page-builder editing screen is a front-end URL, so none of the
60 + // guards above catch it. Optimizing it breaks the editor outright --
61 + // Combine JS reorders the builder's own dependency graph and the
62 + // toolbar never renders. There is no speed to win on a logged-in,
63 + // uncacheable editing request anyway. (#281)
64 + if ( Builder_Editor::is_active() ) {
65 + return;
66 + }
67 +
59 68 // Settings now live in the per-module option (xspeed_module_minify),
60 69 // owned by XSpeed\Modules\Minify\MinifyModule. We read through
61 70 // Settings_Manager so schema-validated values are returned even
62 71 // if the option was hand-edited.
@@ -66,8 +75,15 @@
66 75 add_filter( 'style_loader_src', array( __CLASS__, 'rewrite_style' ), 10, 2 );
67 76 }
68 77 if ( ! empty( $opts['minify_js'] ) ) {
69 78 add_filter( 'script_loader_src', array( __CLASS__, 'rewrite_script' ), 10, 2 );
79 + // The src rewrite above runs before any plugin's own
80 + // `script_loader_tag` filter can stamp data-no-minify /
81 + // data-no-optimize onto the tag, so the marker arrives too late
82 + // to prevent it. Priority 15: after third-party tag filters at
83 + // the default 10 have printed their markers, before our defer
84 + // (20) and delay (30) look at the tag. (#456)
85 + add_filter( 'script_loader_tag', array( Minify_Filters::class, 'restore_marked_script_src' ), 15, 3 );
70 86 }
71 87
72 88 // Phase 4.1a — filter-only "smarter minifier" features. Each is
73 89 // gated on its own toggle so users can enable any subset.
@@ -91,20 +107,70 @@
91 107 // minify_html (same filter, default priority) and is baked into
92 108 // the cache file, so it replays on static hits where PHP never
93 109 // boots.
94 110 add_filter( 'xspeed_cache_final_html', array( Minify_Filters::class, 'delay_raw_script_tags' ), 20 );
111 + // The vendors' own install snippets are INLINE (no src at all),
112 + // so the src sweep above never sees them; this one parks an
113 + // inline body that names a known third-party host.
114 + add_filter( 'xspeed_cache_final_html', array( Minify_Filters::class, 'delay_inline_snippets' ), 21 );
95 115 }
116 +
117 + // Everything above honors data-no-optimize / data-no-minify, but
118 + // only sees markers stamped before priority 30. Borlabs Cookie
119 + // stamps at 100, so its consent config was minified AND delayed
120 + // despite carrying both markers. Snapshot the tag before our
121 + // transforms (9) and hand the original back if a marker turns up
122 + // after them (1000, past Borlabs' own 100 and 999). Registered
123 + // whenever any of the three is on,
124 + // since each one is individually enough to damage a marked
125 + // script. (#469)
126 + if ( ! empty( $opts['minify_js'] ) || ! empty( $opts['defer_js'] ) || ! empty( $opts['delay_js'] ) ) {
127 + add_filter( 'script_loader_tag', array( Minify_Filters::class, 'snapshot_tag' ), 9, 3 );
128 + add_filter(
129 + 'script_loader_tag',
130 + array( Minify_Filters::class, 'revert_late_marked_tag' ),
131 + Minify_Filters::late_opt_out_priority(),
132 + 3
133 + );
134 + }
96 135 if ( ! empty( $opts['async_css'] ) ) {
97 136 add_filter( 'style_loader_tag', array( Minify_Filters::class, 'async_style_tag' ), 20, 2 );
137 + // style_loader_tag only fires for wp_enqueue_style()'d sheets.
138 + // Themes print Google/Bunny/Typekit font CSS as literal <link>
139 + // markup in the head, so those sheets never reach the filter and
140 + // stay render-blocking — sweep the finished buffer for the known
141 + // font-CSS hosts. Baked into the cache file, so it replays on
142 + // static hits where PHP never boots.
143 + add_filter( 'xspeed_cache_final_html', array( Minify_Filters::class, 'async_raw_font_css_links' ), 22 );
98 144 }
99 145
100 - // Phase 4.1b — combine engine. Hook late so every plugin /
101 - // theme has finished enqueueing by the time we walk the queue.
102 - // Priority 999 mirrors the WP-Optimize / Rocket convention.
146 + /*
147 + * CSS combining runs on the FINISHED HTML, not the enqueue queue.
148 + *
149 + * The queue-walking version could not be made correct: whatever it
150 + * wrote at priority 999, WordPress edited afterwards. Core's
151 + * wp_maybe_inline_styles() inlines any queued handle carrying a `path`
152 + * and sets src=false on it, which silently threw away the combined URL
153 + * and took the sheets we had blanked with it — six stylesheets became
154 + * one and the site rendered unstyled. See Css_Combine_Buffer's header
155 + * for the full trace. (#195)
156 + *
157 + * Two entry points, because the page cache's filter is not always
158 + * available: `xspeed_cache_final_html` fires only on a cacheable MISS,
159 + * so on a site with the cache off — or on an excluded URL like /cart —
160 + * combining would silently stop working. Css_Combine_Buffer::boot()
161 + * opens its own buffer in exactly those cases and no-ops otherwise, so
162 + * the page is transformed once either way.
163 + */
103 164 if ( ! empty( $opts['combine_css'] ) ) {
104 - add_action( 'wp_enqueue_scripts', array( Asset_Combiner::class, 'combine_styles' ), 999 );
165 + add_filter( 'xspeed_cache_final_html', array( Css_Combine_Buffer::class, 'process' ), 5 );
166 + Css_Combine_Buffer::boot();
105 167 }
106 168 if ( ! empty( $opts['combine_js'] ) ) {
169 + // JS stays on the enqueue path for now: dependency order,
170 + // async/defer and wp_add_inline_script make it a different
171 + // problem, and the reported break is CSS-only. Moving it is worth
172 + // its own change rather than doubling the blast radius here.
107 173 add_action( 'wp_enqueue_scripts', array( Asset_Combiner::class, 'combine_scripts' ), 999 );
108 174 }
109 175 }
110 176
@@ -161,10 +227,18 @@
161 227 $pattern = '#<(pre|textarea|script|style)\b[^>]*>.*?</\1>#is';
162 228 $html = preg_replace_callback(
163 229 $pattern,
164 230 function ( $m ) use ( &$placeholders ) {
165 - $key = '__XSPEED_PH_' . count( $placeholders ) . '__';
166 - $placeholders[ $key ] = $m[0];
231 + $key = '__XSPEED_PH_' . count( $placeholders ) . '__';
232 + // The placeholder pass exists to protect content whose
233 + // whitespace is significant (<pre>, <textarea>) and to keep
234 + // the tag-boundary regex off script bodies. <style> and
235 + // <script> were grouped in with them, so protection became a
236 + // permanent exemption: on builder sites where most CSS is
237 + // inline, a page with minify ON shipped fully indented. Minify
238 + // the BODY here, before it's stashed, so the outer passes
239 + // still never see it. (#2)
240 + $placeholders[ $key ] = self::minify_inline_block( $m[0], strtolower( $m[1] ) );
167 241 return $key;
168 242 },
169 243 $html
170 244 );
@@ -243,10 +317,12 @@
243 317 if ( false !== strpos( $src, '.min.' ) ) {
244 318 return $src;
245 319 }
246 320
247 - // Skip anything we already produced. The Asset_Combiner writes a
248 - // pre-minified combined-<hash>.css under min/combined/ and enqueues it
321 + // Skip anything we already produced. The Asset_Combiner minifies the
322 + // combined body itself before writing combined-<hash>.css under
323 + // min/combined/ (issue #331 — that used to be asserted here but was
324 + // not actually true, so the artifact shipped unminified), and enqueues it
249 325 // as `xspeed-combined-css`; the per-file minifier used to re-minify
250 326 // that combined output into a SECOND file (min/<hash2>.css) with its
251 327 // own mtime-derived hash. The served HTML then pinned that second
252 328 // hash, so a purge/regeneration (which changes the combined file's
@@ -343,18 +419,175 @@
343 419 * literal `{` / `}` / `[` / `]` that throw off the count by the same
344 420 * amount in both bodies (since they survive minification as-is), so
345 421 * the equality check is robust to that noise.
346 422 */
347 - private static function balanced( string $source, string $minified ): bool {
348 - $pairs = array( '(', ')', '{', '}', '[', ']', '`' );
349 - foreach ( $pairs as $token ) {
350 - if ( substr_count( $source, $token ) !== substr_count( $minified, $token ) ) {
423 + /**
424 + * Minify the body of one captured inline block, or return it untouched.
425 + *
426 + * Only `<style>` and JavaScript `<script>` bodies are eligible:
427 + *
428 + * - `<pre>` / `<textarea>` — whitespace is rendered, never touch it.
429 + * - `<script>` with a non-JS `type` — `application/ld+json`,
430 + * `text/template`, `text/x-handlebars` and anything unrecognised are
431 + * data or markup, not code. Minifying JSON-LD would corrupt structured
432 + * data; minifying a template would eat the markup it holds. An unknown
433 + * type is treated as non-JS on purpose: guessing wrong breaks the page,
434 + * while skipping only forgoes a few bytes.
435 + * - `<script src="...">` — the body is empty; the file path already goes
436 + * through minify_file().
437 + *
438 + * Every result is checked with balanced(), the same structural guard the
439 + * file path uses, so a body the library truncates is shipped as-is rather
440 + * than broken. (#2)
441 + *
442 + * @param string $block Full matched tag, opening tag through closing tag.
443 + * @param string $tag Lowercased tag name.
444 + * @return string Minified block, or $block unchanged.
445 + */
446 + private static function minify_inline_block( string $block, string $tag ): string {
447 + if ( 'style' !== $tag && 'script' !== $tag ) {
448 + return $block; // pre / textarea — significant whitespace.
449 + }
450 + if ( ! class_exists( '\\MatthiasMullie\\Minify\\CSS' ) ) {
451 + return $block;
452 + }
453 +
454 + // Split into opening tag / body / closing tag. Anything that doesn't
455 + // match this shape isn't something we should be rewriting.
456 + if ( ! preg_match( '#^(<' . $tag . '\b[^>]*>)(.*)(</' . $tag . '\s*>)$#is', $block, $parts ) ) {
457 + return $block;
458 + }
459 + list( , $open, $body, $close ) = $parts;
460 +
461 + if ( '' === trim( $body ) ) {
462 + return $block;
463 + }
464 +
465 + // The tag asked to be left alone (data-no-optimize / data-no-minify —
466 + // the convention consent managers print on their config scripts). (#456)
467 + if ( Minify_Filters::tag_opts_out( $open ) ) {
468 + return $block;
469 + }
470 +
471 + // Refuse a body that is already structurally broken. balanced() only
472 + // compares source against minified, so it passes when BOTH are equally
473 + // unbalanced — `function x( {` minifies to `function x({`, same counts,
474 + // guard satisfied, broken code reformatted. Rewriting a body we can't
475 + // parse risks turning a page that happens to work into one that does
476 + // not, for no gain. (#2 AC: a syntactically broken block is left
477 + // untouched.)
478 + if ( ! self::self_consistent( $body ) ) {
479 + return $block;
480 + }
481 +
482 + if ( 'script' === $tag ) {
483 + // An external script has no body worth minifying.
484 + if ( preg_match( '#\bsrc\s*=#i', $open ) ) {
485 + return $block;
486 + }
487 + // No type, or an explicitly JavaScript type, is code. Everything
488 + // else is data/markup — see the docblock.
489 + $js_types = array(
490 + 'text/javascript',
491 + 'application/javascript',
492 + 'application/ecmascript',
493 + 'text/ecmascript',
494 + 'module',
495 + );
496 + if ( preg_match( '#\btype\s*=\s*["\']?([^"\'\s>]+)#i', $open, $type_match ) ) {
497 + if ( ! in_array( strtolower( trim( $type_match[1] ) ), $js_types, true ) ) {
498 + return $block;
499 + }
500 + }
501 + }
502 +
503 + try {
504 + $minifier = 'style' === $tag
505 + ? new \MatthiasMullie\Minify\CSS()
506 + : new \MatthiasMullie\Minify\JS();
507 + $minifier->add( $body );
508 + $minified = $minifier->minify();
509 + } catch ( \Throwable $e ) {
510 + return $block;
511 + }
512 +
513 + // A minifier that returns nothing for a non-empty body has failed, not
514 + // succeeded — shipping '' would silently delete the rule set.
515 + if ( ! is_string( $minified ) || '' === trim( $minified ) ) {
516 + return $block;
517 + }
518 + if ( ! self::balanced( $body, $minified ) ) {
519 + return $block;
520 + }
521 +
522 + return $open . $minified . $close;
523 + }
524 +
525 + /**
526 + * Does a body's own paired delimiters balance?
527 + *
528 + * balanced() is a RELATIVE check — source against minified — so it cannot
529 + * see input that was already broken: an unbalanced body minifies to an
530 + * equally unbalanced one and the counts still agree. This is the absolute
531 + * check, applied to the source alone before we touch it.
532 + *
533 + * Deliberately naive: it counts tokens without parsing, so a brace inside
534 + * a string or comment skews it. That only ever makes it MORE conservative —
535 + * a false negative skips minification, which costs bytes, while a false
536 + * positive would ship broken code. (#2)
537 + *
538 + * @param string $body Inline block body.
539 + */
540 + private static function self_consistent( string $body ): bool {
541 + $pairs = array(
542 + '{' => '}',
543 + '(' => ')',
544 + '[' => ']',
545 + );
546 + foreach ( $pairs as $open => $close ) {
547 + if ( substr_count( $body, $open ) !== substr_count( $body, $close ) ) {
351 548 return false;
352 549 }
353 550 }
551 + // Backticks and quotes pair with themselves, so an odd count means an
552 + // unterminated literal.
553 + foreach ( array( '`' ) as $token ) {
554 + if ( 0 !== substr_count( $body, $token ) % 2 ) {
555 + return false;
556 + }
557 + }
354 558 return true;
355 559 }
356 560
561 + private static function balanced( string $source, string $minified ): bool {
562 + unset( $source );
563 +
564 + // Judge the OUTPUT, not the difference between input and output.
565 + //
566 + // This used to compare token counts across the pair, on the stated
567 + // assumption that "literal braces inside strings survive minification
568 + // unchanged, so they cancel out". Comments do not: stripping them is
569 + // the minifier's whole job, and every brace, bracket and backtick
570 + // inside one disappears with it. So any file whose comments contain a
571 + // delimiter — a commented-out block, a URL in a docblock, an SVG in a
572 + // note — failed the check and silently shipped unminified.
573 + //
574 + // It is not a rare shape. EmbedPress's front.js counts 372 braces
575 + // against 368, 61 brackets against 58 and 110 backticks against 102
576 + // purely from comment removal, so 67 KB shipped raw where 46 KB was
577 + // correct — and `node --check` confirms that rejected output parses
578 + // fine. A guard that refuses valid work is not conservative, it is
579 + // broken: it costs bytes on every request and reports nothing.
580 + //
581 + // What the guard is FOR still stands (#2): matthiasmullie/minify can
582 + // truncate inside a template literal on complex modern JS and return a
583 + // body that looks minified but is structurally broken. That failure is
584 + // visible in the output alone — an unterminated literal leaves an odd
585 + // backtick count and unmatched braces — which is exactly what
586 + // self_consistent() measures, without the false positives.
587 + return self::self_consistent( $minified );
588 + }
589 +
357 590 /**
358 591 * Resolve a local asset URL to a filesystem path using a strict allowlist
359 592 * of "URL prefix → filesystem prefix" pairs registered with WordPress.
360 593 *
@@ -396,19 +629,40 @@
396 629 array( content_url(), WP_CONTENT_DIR ),
397 630 array( includes_url(), ABSPATH . WPINC ),
398 631 );
399 632
633 + // The host check above normalised the HOST but not the SCHEME, and the
634 + // prefix match below is a plain string compare — so an https asset URL
635 + // never matched an http base and the file silently shipped unminified.
636 + // That is not a corner case: WP_CONTENT_URL is derived from a stored
637 + // option, `plugins_url()` from another, and a site moved to https
638 + // without rewriting every row (or one behind a TLS-terminating proxy
639 + // where `is_ssl()` reads false) serves https pages off http-rooted
640 + // bases all day. Comparing scheme-less is the whole fix; the host
641 + // equality test already did the security work of refusing anything
642 + // off-site, and this runs after it.
643 + $strip_scheme = static function ( string $value ): string {
644 + return (string) preg_replace( '#^https?://#i', '//', $value );
645 + };
646 + $clean_match = $strip_scheme( $clean );
647 +
400 648 foreach ( $candidates as $pair ) {
401 649 list( $url_base, $path_base ) = $pair;
402 650 if ( ! $url_base || ! $path_base ) {
403 651 continue;
404 652 }
405 - $url_base = rtrim( $url_base, '/' );
406 - if ( 0 !== strpos( $clean, $url_base . '/' ) && $clean !== $url_base ) {
653 + $url_base = rtrim( $url_base, '/' );
654 + $base_match = $strip_scheme( $url_base );
655 + if ( 0 !== strpos( $clean_match, $base_match . '/' ) && $clean_match !== $base_match ) {
407 656 continue;
408 657 }
409 658
410 - $relative = ltrim( substr( $clean, strlen( $url_base ) ), '/' );
659 + // Slice the scheme-less pair, not the original. `https://…` and
660 + // `http://…` differ by one byte, so an offset taken from the base
661 + // as written would cut one character short of (or past) the path
662 + // when the two schemes disagree — which is the case this fix
663 + // exists for.
664 + $relative = ltrim( substr( $clean_match, strlen( $base_match ) ), '/' );
411 665 $candidate = trailingslashit( $path_base ) . $relative;
412 666
413 667 $real_base = realpath( $path_base );
414 668 $real = realpath( $candidate );
@@ -436,10 +690,16 @@
436 690 Cache::write_silence( $dir );
437 691 }
438 692 }
439 693
694 + /**
695 + * Clear every minified / combined asset.
696 + *
697 + * @return int Files removed. Most callers are `add_action` callbacks and
698 + * ignore it; `wp xspeed purge` reports it as a line item.
699 + */
440 700 public static function purge_minified() {
441 - self::rmtree_files( self::min_dir() );
701 + return self::rmtree_files( self::min_dir() );
442 702 }
443 703
444 704 /**
445 705 * Recursively delete every file under $dir (and the emptied
@@ -448,18 +708,21 @@
448 708 * min/combined/ were never cleared — a purge left a stale
449 709 * combined-<hash>.css the regenerated page no longer referenced.
450 710 * (FBS-83114 / FBS-83116)
451 711 */
452 - private static function rmtree_files( string $dir ): void {
712 + private static function rmtree_files( string $dir ): int {
453 713 if ( ! is_dir( $dir ) ) {
454 - return;
714 + return 0;
455 715 }
716 + $removed = 0;
456 717 foreach ( (array) glob( $dir . '/*' ) as $path ) {
457 718 if ( is_dir( $path ) ) {
458 - self::rmtree_files( $path );
719 + $removed += self::rmtree_files( $path );
459 720 @rmdir( $path ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_operations_rmdir, WordPress.PHP.NoSilencedErrors.Discouraged -- best-effort cleanup of our own cache subdir; WP_Filesystem is unavailable on the frontend purge path.
460 721 continue;
461 722 }
462 723 wp_delete_file( $path );
724 + ++$removed;
463 725 }
726 + return $removed;
464 727 }
465 728 }